FGFS-4.1/OpenSceneGraph
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

From Sebastian Messerschmidt, "Seems like your re-factoring didn't really produces the correct results.

Browse Source 
You can check with the tester2.flt provided earlier and check with the result image.
I double checked this with OpenFlight creator, and it seems the yaw is broken.

With my initial quaternion version is seems correct and if I change the


float cos_yaw = cosf(osg::inDegrees(yaw));
float sin_yaw = sinf(osg::inDegrees(yaw));

to be
float cos_yaw = cosf(osg::inDegrees(-yaw));
float sin_yaw = sinf(osg::inDegrees(-yaw));

it seems to work as well."
This commit is contained in:
Robert Osfield 2013-08-01 10:04:05 +00:00
parent 837a680849
commit 46ec50aecb
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/osgPlugins/OpenFlight/PrimaryRecords.cpp
View File

@ -12,7 +12,7 @@
*/
//
// OpenFlight® loader for OpenSceneGraph
// OpenFlight loader for OpenSceneGraph
//
// Copyright (C) 2005-2007 Brede Johansen
//
@ -1030,9 +1030,9 @@ protected:
if ((w==0.0) || (light->getSpotCutoff()<180.0))
{
// assume yaw is zero along y axis, increase positive clockwise
// assume patch is zero along xy plane, increase positive upwards
float cos_yaw = cosf(osg::inDegrees(yaw));
float sin_yaw = sinf(osg::inDegrees(yaw));
// assume pitch is zero along xy plane, increase positive upwards
float cos_yaw = cosf(osg::inDegrees(-yaw));
float sin_yaw = sinf(osg::inDegrees(-yaw));
float cos_pitch = cosf(osg::inDegrees(pitch));
float sin_pitch = sinf(osg::inDegrees(pitch));
light->setDirection(osg::Vec3(sin_yaw*cos_pitch, cos_yaw*cos_pitch, sin_pitch));