Richard Mudgett
27a5c7afb6
Fix potential buffer overflow in pri_dump_info_str().
...
* Created pri_snprintf() to prevent buffer overflow in pri_dump_info_str().
* Extracted timer name to timer number table from pri_timer2idx() so
pri_dump_info_str() can use it.
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@921 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-06-26 19:50:19 +00:00
Richard Mudgett
01e637393e
Eliminate local version of PRI_MAX_TIMERS.
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@920 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-06-26 19:43:13 +00:00
Richard Mudgett
4f0b3f3109
Doxygenify the timer comments.
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@919 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-06-26 19:41:56 +00:00
Richard Mudgett
24cc37a839
Added printf format attribute to pri_message() and pri_error() and fixed some detected errors.
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@914 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-06-26 18:37:15 +00:00
Sean Bright
562e1fb7ca
Add support for sending Reverse Charging Indication IE on ISDN PRI.
...
Add the ability to transmit a Reverse Charging Indication IE during a SETUP
message. In passing, re-work some of the receive logic to be forwards
compatible with new RCI values that may be added in the future. Also removed
the PRI_REVERSECHARGE_SUPPORT define that I added on the last commit since we
can just check for PRI_REVERSECHARGE_NONE or _REQUESTED on the Asterisk side to
determine support for this.
Special thanks to rmudgett who could have written this in half the time he spent
reviewing it, but instead talked me through it. Much appreciated!
(issue #13760 )
Reported by: mrgabu
Review: https://reviewboard.asterisk.org/r/292/
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@907 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-06-25 18:53:38 +00:00
Richard Mudgett
c5cdc66b72
Convert PRI_TIMER_xxx to an enum so PRI_MAX_TIMERS can be automatically adjusted.
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@901 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-06-25 17:35:23 +00:00
Richard Mudgett
2eaca806b9
Make it easier to add more timers/counters and vary the defaults based upon switchtype.
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@894 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-06-24 21:45:04 +00:00
Sean Bright
7092459702
Capture and expose the Reverse Charging Indication IE on ISDN PRI.
...
(issue #13760 )
Reported by: mrgabu
Patches:
20090619_libpri_1.4.patch uploaded by seanbright (license 71)
Tested by: seanbright, pruonckk
Review: https://reviewboard.asterisk.org/r/291/
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@885 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-06-24 18:19:24 +00:00
Sean Bright
64fd25fcac
Revert unintentional changes
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@879 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-06-23 23:15:56 +00:00
Sean Bright
16304b6a65
Set reviewboard property.
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@878 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-06-23 23:15:04 +00:00
Richard Mudgett
ea4d305ffb
Miscellaneous minor changes.
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@865 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-06-12 14:29:42 +00:00
Matthew Fredrickson
3a1739883b
There are two changes in this commit that are bug fixes for various Q.921 issues found in internal testing.
...
Both were exposed/introduced by the TBR4 compliance patch for bug #12861 , in changing how retransmissions and in how
the transmission queue was maintained. TX-RX message flow and acknowledgement was severely restricted,
since the patch changed the behavior so that pending untransmitted frames would not actually be send until
the next RR was received in normal circumstances, or REJ when a reject frame was received. On busy links,
this can severly limit the amount of useful traffic that is sent, and can slow down message transmission.
Until someone can point out where in Q.921 it is mandated for us to wait for RR frames to start sending
untransmitted messages, the first change is to allow us to send untransmitted frames when we receive new
I frames as well, with updated N(R).
The other bug fixed is a situation caused by the restricted traffic flow, if an outside process tries to send
an I-frame asynchronous to an RR frame, when the transmit window was previously closed and then opened up but
an RR has not been received yet. A bug was found with the integration of the old transmit code with the new reject
handling code which caused the new frame to be sent immediately, regardless if there were any pending untransmitted
I-frames in the queue to be sent and causing an out of order I-frame to be sent to the other side. This bug is
also fixed in this patch.
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@859 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-06-09 19:47:05 +00:00
Richard Mudgett
47830a68aa
Made ASN.1 memory dump also display printable characters.
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@848 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-06-03 22:51:42 +00:00
Richard Mudgett
2176bd7fa3
Renamed callstate2str() to q931_call_state_str().
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@842 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-06-03 21:35:14 +00:00
Richard Mudgett
3c12135659
Made transmit_facility() debug message indiate to which message the facility ie is being added.
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@836 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-06-03 21:25:59 +00:00
Richard Mudgett
c69e4780ef
Renamed local struct pri *pri variables to struct pri *ctrl in q931.c.
...
The context tagging for my editor is much happier now that the struct and the
variable do not have the same name. (At least for this file.)
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@824 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-05-29 15:39:48 +00:00
Richard Mudgett
e7b64b16da
Removed usage of FUNC_DUMP(), FUNC_RECV(), and FUNC_SEND() defines.
...
They did not really help and hindered easy lookup of parameter types.
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@804 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-05-20 15:03:34 +00:00
Kevin P. Fleming
39f7f72d8f
Add 'const' qualifier to character string argument to keypad facility API calls
...
These API calls do not modify the string supplied, and should not be allowed to modify it, so this patch adds a 'const' qualifier to that argument to allow the compiler to enforce this restriction (and allow callers of the API that already have a 'const' pointer to be able to pass it to this API).
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@798 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-05-13 15:17:08 +00:00
Richard Mudgett
5484712af0
Minor code clean up.
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@794 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-05-07 16:21:24 +00:00
Richard Mudgett
a5b9b792ea
Avoid a stale pointer crash if the TE BRI TEI is removed when active calls exist.
...
Made the q931_call record point to the master D channel control structure
instead of the BRI TEI subchannel control structure. When a layer 3 message
is sent, the current TEI subchannel control structure is used.
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@790 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-05-07 16:06:19 +00:00
Richard Mudgett
c430cba165
Added Q.931 call state description comments.
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@786 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-05-05 22:25:03 +00:00
Richard Mudgett
ac40946c11
Comment changes.
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@782 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-05-01 22:47:41 +00:00
Richard Mudgett
b19c0b0a04
Added Q.SIG Advice-Of-Charge encode/decode routines.
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@772 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-04-21 23:32:13 +00:00
Richard Mudgett
ba45095c5a
ROSE ASN.1 facility encode and decode rewrite of existing messages.
...
Several components are now parsed correctly. Most notably:
PartyNumber and Q.SIG Name.
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@766 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-04-21 22:08:45 +00:00
Jeff Peeler
18fa4716a5
Add service maintenance message support
...
This adds support for two new message types: Service and Service Acknowledge.
When a channel receives a service message it will either take the channel in
or out of service and then send a service acknowledgment. Although not
enforced here (enforced in chan_dahdi), the service messages are only supported
with switch types 4ess/5ess. The required Asterisk changes will be coming next.
(issue #3450 )
Reported by: cmaj
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@732 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-04-14 15:05:21 +00:00
Richard Mudgett
f9d5aa3c3a
Comment changes and some string content corrections.
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@726 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-04-02 19:33:38 +00:00
Richard Mudgett
88551af7ef
Comment changes to note what ISDN message type causes the event.
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@715 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-03-26 16:01:45 +00:00
Richard Mudgett
29ded17c0b
Added pSS1InfoElement comments in qsig_cf_callrerouting().
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@711 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-03-19 01:39:21 +00:00
Richard Mudgett
bbaeec9513
Use the correct branch integrated property when generating the version string.
...
Update the make_version file to the latest Asterisk version with the
appropriate libpri required chage.
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@705 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-03-13 01:05:54 +00:00
Joshua Colp
48fc219865
Make sure we only have 4 octects on unrestricted 64k data calls.
...
(closes issue #14507 )
Reported by: jsmith
Patches:
64k-data.patch uploaded by jsmith (license 15)
Tested by: jsmith
(closes issue #13118 )
Reported by: radpeter
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@701 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-03-04 20:31:20 +00:00
Leif Madsen
9ecdbed001
Fix a small spelling error.
...
(closes issue #14375 )
Reported by: jeremy1
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@687 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-02-02 20:18:03 +00:00
Matthew Fredrickson
3d91cd5e30
A couple of last BRI fixes in libpri... don't discard pending iframes when we call the q921_dchannel_up routine, since we need to be able to send the ones that were queued up while the D-channel went down and is being reactivated. Also fix some buggy logic in the frame transmission decision code.
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@680 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-01-27 23:22:06 +00:00
Matthew Fredrickson
a30eeee9a8
Change behavior so that we do not send I-frames when link is down, but instead queue them up until the link comes up and send them out then.
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@675 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-01-22 21:48:41 +00:00
Matthew Fredrickson
07c4195876
Add additional case where T200 expires greater than N200 times and we need to release and reacquire the TEI.
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@656 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2009-01-09 17:58:28 +00:00
Matthew Fredrickson
40ae2a030a
Add some additional debug for Q.921 MDL messages as well as fix a bug in RESTART messages on BRI
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@653 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2008-12-23 21:38:25 +00:00
Matthew Fredrickson
2c104c4dbd
Fix a number of Q.921 bugs, found doing TBR4 compliance testing, thanks to Tzafrir, Xorcom, and co. ( #12861 ). Thanks!
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@645 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2008-11-22 00:34:26 +00:00
Matthew Fredrickson
e1bfec4b1e
Merging in additional Q.SIG features in #13454 . Includes Q.SIG physical/logical channel mapping support, extended coding of Q.SIG name operations (calling name), and call rerouting support via added dialplan application.
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@636 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2008-10-17 16:13:42 +00:00
Jason Parker
aeb5a6d284
Make install paths use libdir, like libss7
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@616 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2008-08-06 18:20:51 +00:00
Kevin P. Fleming
64eaca5bfa
Merged revisions 610 via svnmerge from
...
https://origsvn.digium.com/svn/libpri/branches/1.2
........
r610 | kpfleming | 2008-08-05 17:16:58 -0500 (Tue, 05 Aug 2008) | 2 lines
clean up license headers, and explicitly grant additional permissions when used with Asterisk
........
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@611 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2008-08-05 22:18:12 +00:00
Kevin P. Fleming
67bc1003ab
update ignore list
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@607 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2008-07-30 15:43:55 +00:00
Kevin P. Fleming
419282d399
use better version.c creation process, and better dependency tracking process too
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@606 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2008-07-30 15:39:37 +00:00
Jason Parker
9e6df1092c
I believe this is what was meant. (it matches how Asterisk does it)
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@602 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2008-07-29 22:47:37 +00:00
Jason Parker
1c7588ead5
libpri is not libss7 :D
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@598 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2008-07-29 22:29:11 +00:00
Kevin P. Fleming
16df54e01a
correct comments to match code
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@594 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2008-07-22 22:36:25 +00:00
Kevin P. Fleming
16719a5f74
rename API call and option (nothing has been released to use it yet so this should be safe) to be more accurate in describing what it does
...
(closes issue #13042 )
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@589 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2008-07-22 19:43:26 +00:00
Kevin P. Fleming
8c5da8a278
ignore generated files
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@579 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2008-07-11 16:44:11 +00:00
Kevin P. Fleming
aad7c3e8f1
modify work done for issue #10552 , making the support of inband audio after RELEASE a configurable option, since it is causing problems for a number of users
...
(closes issue #13042 )
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@574 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2008-07-11 16:24:01 +00:00
Dwayne M. Hubbard
95ccc0e03c
While working on issue 3450 I noticed that the information channel selection field in the channel identification IE was displayed incorrectly when using 'pri intense debug'. I wanted another pair of eyes to look at the code because everything looked correct until Shaun Ruffell noticed the missing comma in the msg_chan_sel array.
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@562 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2008-06-04 17:02:12 +00:00
Matthew Fredrickson
b9a6ab0c69
Moving trunk changes back into 1.4
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@557 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2008-05-07 19:51:44 +00:00
Brett Bryant
dee4c9ae0f
Add new API call (pri_get_version) to show the current version of the branch for support purposes.
...
git-svn-id: https://origsvn.digium.com/svn/libpri/branches/1.4@552 2fbb986a-6c06-0410-b554-c9c1f0a7f128
2008-05-02 20:21:04 +00:00