FGCOM/dahdi-linux
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

wctdm24xxp: Fix bug if hook state on FXS changes before channel configuration.

Browse Source 
If the hook state on an FXS port changes before the channel is
configured with dahdi_cfg it is possible to erroneously force the line
feed register open without setting a timer to clear it.

The result would be a "dead" channel that cannot be cleared unless the
driver is reloaded and warning in the kernel log that "0 is an invalid
signaling state for an FXS module".

This change makes the OFF_HOOK to ON_HOOK change behave just as the
ON_HOOK to OFF_HOOK change has.

Internal-Issue-ID: DAHLIN-272
Reported-and-Tested-by: Tzafrir Cohen <tzafrir.cohen@xorcom.com>
Signed-off-by: Shaun Ruffell <sruffell@digium.com>

git-svn-id: http://svn.asterisk.org/svn/dahdi/linux/trunk@10396 a0bf4364-ded3-4de4-8d8a-66a801d63aff
This commit is contained in:
Shaun Ruffell 2012-01-03 19:25:46 +00:00
parent afe3702873
commit b91ec305be
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/dahdi/wctdm24xxp/base.c
View File

@ -2256,20 +2256,16 @@ wctdm_fxs_hooksig(struct wctdm *wc, struct wctdm_module *const mod,
switch (txsig) { switch (txsig) {
case DAHDI_TXSIG_ONHOOK: case DAHDI_TXSIG_ONHOOK:
switch (get_dahdi_chan(wc, mod)->sig) { switch (get_dahdi_chan(wc, mod)->sig) {
case DAHDI_SIG_EM:
case DAHDI_SIG_FXOKS:
case DAHDI_SIG_FXOLS:
x = fxs->idletxhookstate;
break;
case DAHDI_SIG_FXOGS: case DAHDI_SIG_FXOGS:
x = (POLARITY_XOR(fxs)) ? x = (POLARITY_XOR(fxs)) ?
SLIC_LF_RING_OPEN : SLIC_LF_RING_OPEN :
SLIC_LF_TIP_OPEN; SLIC_LF_TIP_OPEN;
break; break;
case DAHDI_SIG_EM:
case DAHDI_SIG_FXOKS:
case DAHDI_SIG_FXOLS:
default: default:
WARN_ONCE(1, "%x is an invalid signaling state for " x = fxs->idletxhookstate;
"an FXS module.\n",
get_dahdi_chan(wc, mod)->sig);
break; break;
} }
break; break;