FGCOM/dahdi-linux
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

wct4xxp: Print warning in dmesg if span priority is not set correctly.

Browse Source 
dahdi_genconf currently does not take into account the number of spans
configured for a particular board. Therefore if you have two dual span cards
installed in the system, it could be possible to have something like this in
/etc/dahdi/system.conf:

  spans=1,1,...
  spans=2,2,...
  spans=3,3,...
  spans=4,4,...

When what you really want is something like this:

  spans=1,1,...
  spans=2,2,...
  spans=3,1,...
  spans=4,2,...

Otherwise, spans 3 and 4 will be configured to not recover the clock from the
span which is most likely NOT what you want.

Signed-off-by: Shaun Ruffell <sruffell@digium.com>
This commit is contained in:
Shaun Ruffell 2013-09-18 18:17:37 -05:00
parent 92f1e46b8f
commit 706dc43483
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/dahdi/wct4xxp/base.c
View File

@ -1712,8 +1712,11 @@ _t4_spanconfig(struct file *file, struct dahdi_span *span,
if (lc->sync < 0) if (lc->sync < 0)
lc->sync = 0; lc->sync = 0;
if (lc->sync > wc->numspans) if (lc->sync > wc->numspans) {
dev_warn(&wc->dev->dev, "WARNING: Cannot set priority on span %d to %d. Please set to a number between 1 and %d\n",
span->spanno, lc->sync, wc->numspans);
lc->sync = 0; lc->sync = 0;
}
/* remove this span number from the current sync sources, if there */ /* remove this span number from the current sync sources, if there */
for(i = 0; i < wc->numspans; i++) { for(i = 0; i < wc->numspans; i++) {