FGCOM/dahdi-linux
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

wct4xxp: t4_serial_setup() was called more often than necessary.

Browse Source 
The driver iterates through all the spans on a given device during assignment,
checking for unassigned spans, but it was erroneously testing the span on which
assigned was called.

This just removes some unexpected behavior and provides a slight performance
increase on load and does not impact the functionality of the driver as far as
I'm aware.

Reported-by: Doug Bailey <dbailey@digium.com>
Signed-off-by: Shaun Ruffell <sruffell@digium.com>
(cherry picked from commit 9de213b104)
This commit is contained in:
Shaun Ruffell 2012-12-17 13:00:18 -06:00 committed by Russ Meyerriecks
parent 42be50ca28
commit 46cfdca5d5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/dahdi/wct4xxp/base.c
View File

@ -2039,7 +2039,7 @@ static void t4_span_assigned(struct dahdi_span *span)
/* We use this to make sure all the spans are assigned before /* We use this to make sure all the spans are assigned before
* running the serial setup. */ * running the serial setup. */
list_for_each_entry(pos, &wc->ddev->spans, device_node) { list_for_each_entry(pos, &wc->ddev->spans, device_node) {
if (!test_bit(DAHDI_FLAGBIT_REGISTERED, &span->flags)) if (!test_bit(DAHDI_FLAGBIT_REGISTERED, &pos->flags))
++unassigned_spans; ++unassigned_spans;
} }