24ae746a88
Jitter evaluation, as an alert trigger, was changed in 3.0 to get the internal average jitter used in the conn-status component data (which is total jitter delay divided by jitterbuffer emit events). This was done accidentally and that metric is _very_ different from the one used in 2.7 (point-in-time jitter from remote-inbound-rtp/inbound-rtp, highest on the interval, gathered on /utils/stats.js). The alert thresholds were preserved, which makes it overly sensitive in regards to jitter (and thus causes it to be critical whenever the user is in audio). Remove jitter as a connection status alert trigger, which fixes the false positive. The implementation on <= 2.7 is also not ideal - if anything, it generates false negatives. That's why I'm removing jitter for the time being since it's ill-suited (at least in the way it's used) for what we want to achieve.
24 lines
827 B
JavaScript
24 lines
827 B
JavaScript
import React from 'react';
|
|
import { useReactiveVar } from '@apollo/client';
|
|
import ConnectionStatusButtonComponent from './component';
|
|
import connectionStatus from '/imports/ui/core/graphql/singletons/connectionStatus';
|
|
import { getWorstStatus } from '../service';
|
|
|
|
const ConnectionStatusButtonContainer = (props) => {
|
|
const connected = useReactiveVar(connectionStatus.getConnectedStatusVar());
|
|
const rttStatus = useReactiveVar(connectionStatus.getRttStatusVar());
|
|
const packetLossStatus = useReactiveVar(connectionStatus.getPacketLossStatusVar());
|
|
|
|
const myCurrentStatus = getWorstStatus([rttStatus, packetLossStatus]);
|
|
|
|
return (
|
|
<ConnectionStatusButtonComponent
|
|
myCurrentStatus={myCurrentStatus}
|
|
connected={connected}
|
|
{...props}
|
|
/>
|
|
);
|
|
};
|
|
|
|
export default ConnectionStatusButtonContainer;
|