Commit Graph

12179 Commits

Author SHA1 Message Date
Ramón Souza
1540a9a7ec
Merge branch 'v2.7.x-release' into I-16114 2023-05-25 16:38:15 -03:00
Scroody
5693ead6fa Fix: Poll creation allows for 5 choices, but the resulting poll will only have 4 choices 2023-05-25 15:35:35 -03:00
Gabriel Porfirio
999bf44a11 adding data-test to yes/no option 2023-05-25 12:59:23 -03:00
Anton Georgiev
25af259d2d Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into merge-may-24 2023-05-24 17:23:00 -04:00
Ramón Souza
219b1d1a72
add inline comment 2023-05-24 15:45:08 -03:00
Anton Georgiev
cb68297273
Merge pull request #17963 from ramonlsouza/fix-self-checked-value
fix: webcam self view toggle label
2023-05-24 14:40:15 -04:00
Scroody
fe24abddca Fix: Camerasa behind drop areas and presentation when dragging 2023-05-24 14:44:26 -03:00
Ramón Souza
60713e6f54 fix slide render issue in firefox 2023-05-24 14:36:58 -03:00
prlanzarin
b40a88cf69 fix(screenshare): size dispatch fails due to wrong scope 2023-05-24 12:07:35 -03:00
prlanzarin
636ab74826 fix(screenshare): adjustments to make output device switching work 2023-05-24 11:40:32 -03:00
AtilaU19
56dba30877 fix(screenshare): audio from screenshare match with audio from microphone 2023-05-24 11:33:32 -03:00
Arthurk12
3efdbd9012 feat(reactions): add akka messages to clear all emojis status
Adds two new messages which clear the users emoji statuses. This messages
enables this task to be done in a single call, instead of triggering one
method call for each user.
'ClearAllUsersEmojiCmdMsg' is sent from meteor to akka and updates all the
emoji states in the users model.
'ClearedAllUsersEmojiEvtMsg' is sent from akka to meteor. This triggers the
 mongo collection update.
2023-05-24 10:49:42 -03:00
Scroody
6e6fbe11be Fix: Self cam caoming back after trying to add effects or settings 2023-05-22 16:54:41 -03:00
Arthurk12
8541a5aae1 fix(reactions): prop name 2023-05-22 12:07:08 -03:00
Ramón Souza
7312021d9b fix self view label value 2023-05-22 10:19:49 -03:00
Ramón Souza
810a9895f8 change enable/disable self cam label based on state 2023-05-22 09:06:39 -03:00
Scroody
08a0226b59 Fix: Send to chat presentation not having unread notification 2023-05-19 10:54:29 -03:00
Ramón Souza
0040ee7028 do not display self view disabled message if camera is not being shared 2023-05-19 09:44:08 -03:00
Anton Georgiev
6e9eb023c5
Merge pull request #17883 from ramonlsouza/issue-13844
feat: Add "Grid View" layout
2023-05-18 15:43:02 -04:00
Anton Georgiev
1d3bdb5802
Merge pull request #17648 from GuiLeme/issue-17531
feat: Restore old downloading of original presentation
2023-05-18 15:40:01 -04:00
Arthurk12
33878f6224 fix(timer): tab title indicator flag
Adds a flag to the settings.yml file to enable and disable the timer
indicator in the tab title.
2023-05-18 15:29:43 -03:00
Arthurk12
b3c12153c3 feat(timer): add indicator to the tab title
Adds the current time string to the tab title, enclosed by opening and
closing brackets.
2023-05-18 15:29:43 -03:00
Arthurk12
ecb6527bae fix(timer): missing prop
Some tweaks that went unnoticed when porting the timer feature.
2023-05-18 15:29:42 -03:00
Arthurk12
f13217607e feat(timer): add model and messages to akka apps
This commit makes the messages of the timer feature to be proxied by
akka-apps and also adds a timer model that is updated based on these
messages.
Moving the timer panel opening logic to the timer button component in
the navigation panel was a consequence of these changes.
2023-05-18 15:29:42 -03:00
Arthurk12
215fe73542 fix(timer): update time offset edge case
Prevents the client from updating its time offset when the time returned
from the server is zero, which is the default returned value when there
is no userId.
This would make the client to calculate a gigantic negative time offset
leading the timer to reach the end prematurely/instantaneously.
2023-05-18 15:29:42 -03:00
Carlos Henrique
0659f15211 fix(disabledFeatures) add timer
"disableFeatures=timer"
2023-05-18 15:29:41 -03:00
Carlos Henrique
98aed5d715 fix(icon) aligned icons
Timer and notes icon aligned.
Removed line between questions and chat buttons.
2023-05-18 15:29:41 -03:00
Carlos
da156b7486 fix(timer) presentation blocking the buttons
Add scroll to timer menu.
2023-05-18 15:29:41 -03:00
Átila
a23e19adde fix(timer): Item alignment
* fix(timer): Item alignment

Co-authored-by: Arthur B. Grossi <32987232+Arthurk12@users.noreply.github.com>
2023-05-18 15:29:40 -03:00
AtilaU19
f0b1a755cb fix(timer): timer song list centering 2023-05-18 15:29:40 -03:00
Arthurk12
a671d45739 fix(layout): adjusts the timer tab height
Changes the timer's tab height to be relative, so it does not cover the
presentation when it is under the content panel.
2023-05-18 15:29:40 -03:00
Arthurk12
0d06241a68 feat(timer): port to 2.5
Port timer feature to 2.5 which includes 3 components:
	- Timer component
	- Timer indicator component
	- Timer sidebar button component
2023-05-18 15:29:39 -03:00
AtilaU19
7a6e457f5d refactor(timer): updateTimer fuction argument list
Replacement of the list of arguments of the update Timer function in an object and adequacy of its calls in the functions when necessary.
2023-05-18 15:29:39 -03:00
Arthurk12
02a6feb1c8 fix(timer): change users count threshold
Changes the timer auto-stop threshold from 90% to 100% of user count
to prioritize the timer alert sounding for all users over the timer state
being consistent.

Also, puts the user count fetch back to where it was to avoid a race
condition where the number of users when setting the observer is
different than when the timer ends(i.e. users've joined or left the
meeting while the timer was running) causing the timer not to stop or
stop prematurely.
2023-05-18 15:29:39 -03:00
Arthurk12
10e1b70bf9 chore(timer): adds log message to beep 2023-05-18 15:29:38 -03:00
Arthurk12
6628296471 fix(timer): wrong attribute to get users count
There was a legacy attribute being used to find active users in the meeting.
This wrong attribute caused the returned number of users to be 0 which
makes the timer stop prematurely and, possibly, not to issue the timer beep.

Also adds a missing argument to updateTimer and moves the find call to
the Users collection to a external function, so it doesn't get executed
every time an user notifies timer has ended.
2023-05-18 15:29:38 -03:00
AtilaU19
a694595275 feat(timer): added requestedUserId and Action logs 2023-05-18 15:29:38 -03:00
Arthurk12
df9b0a2655 refactor(timer): audio tag and play/stop conditions
Sets conditions for calling play and stop music to avoid being called
repeatedly.
Groups all stop calls into a point to make the code cleaner.
Avoid recreating new audio tag whenever the timer song changes.
2023-05-18 15:29:37 -03:00
Arthurk12
857389e295 fix(timer): music selectors
Disables track radio selectors when timer feature is in stopwatch mode.
2023-05-18 15:29:37 -03:00
Arthurk12
cc2387a7dd fix(timer): stop music on unmount
Stops music when timer indicator component is unmounted.
2023-05-18 15:29:37 -03:00
Arthurk12
3895d86823 fix(timer): indicator not showing on mobile
Due to the new layout manager, open panels' checking needed tweaking.
2023-05-18 15:29:36 -03:00
Pedro Beschorner Marin
a8e7f9c896 fix(timer): add key prop to tracks list 2023-05-18 15:29:36 -03:00
Pedro Beschorner Marin
2b4d40d6e8 refactor(timer): functions order 2023-05-18 15:29:36 -03:00
Pedro Beschorner Marin
47cecbfea2 refactor(timer): add parseInt radix 2023-05-18 15:29:35 -03:00
Arthurk12
f5a5a960ba feat(timer): adds more songs
Adds 2 more songs to the timer, which can be switched using the radio
buttons inside timer panel.
Changed the music loop logic to make it gapless.
2023-05-18 15:29:35 -03:00
Arthurk12
529a5a6b10 fix(timer): music stop
Forces timer music to stop when timer is deactivated while running.
2023-05-18 15:29:35 -03:00
Arthur B. Grossi
17aa3d7177 Requested changes
Filters users collection by 'online' connection status and describes when/how
server detects that the timer has ended to automatically stop it.
Also, fixed a corner case that when timer alarm was disabled, clients didn't
notify that the timer ended.
2023-05-18 15:29:35 -03:00
Arthur B. Grossi
737b5e6b3a fix(timer): music toggle alignment
Music label and toggle are closer and centralized.
2023-05-18 15:29:34 -03:00
Arthur B. Grossi
dbbef569a9 fix(timer): autoplay
When user enters meeting with music already playing, an event listener is set
to play the music only after user interaction.
Also, to keep timer more cohesive and reduce complexity of the condition for
playing music, timer automatically stops after 90% of users notify that the
timer has expired.
2023-05-18 15:29:34 -03:00
Arthur B. Grossi
cc61652aa3 feat(timer): ambient music
Adds a music player for ambient sound which can be turned on and off using a
toggle located inside timer panel. When stopwatch is selected, this toggle is
automattically turned off.
2023-05-18 15:29:34 -03:00
Arthurk12
3952112f49 fix(timer): start/stop button color 2023-05-18 15:29:33 -03:00
Pedro Beschorner Marin
ea30525cb4 Timer design extra tweaks 2023-05-18 15:29:33 -03:00
Arthurk12
cc2f509c7c Refactored timer design 2023-05-18 15:29:33 -03:00
Pedro Beschorner Marin
585dbef43d Time offset refactor 2023-05-18 15:29:33 -03:00
Pedro Beschorner Marin
c040db8f58 Fix alarm when deactivated 2023-05-18 15:29:32 -03:00
Pedro Beschorner Marin
2f104eafc8 Syncing time offset between client and server 2023-05-18 15:29:32 -03:00
Pedro Beschorner Marin
4d8f7070de Add timer alarm 2023-05-18 15:29:32 -03:00
Pedro Beschorner Marin
f4a5421843 Add timer view 2023-05-18 15:29:31 -03:00
Pedro Beschorner Marin
5463a4a423 Stopwatch handlers 2023-05-18 15:29:31 -03:00
Arthurk12
953a3d3548 Timer first commit 2023-05-18 15:29:31 -03:00
Ramón Souza
e0cea4834b
Merge pull request #17907 from KDSBrowne/bbb-17466
fix: Localize Regular Expressions for Quick Poll Options
2023-05-18 09:06:19 -03:00
Ramón Souza
18720e1536 Merge remote-tracking branch 'upstream/v2.7.x-release' into issue-13844 2023-05-17 15:44:39 -03:00
Ramón Souza
c64cf5ccbd
Merge pull request #17935 from Scroody/I-16114
feat: Disable self-view of webcam
2023-05-17 14:49:40 -03:00
Scroody
0fa1b9b3eb More requested changes made 2023-05-17 13:54:54 -03:00
Scroody
4a6d1258ae Requested changes made and fix of deactivating mutiple cams 2023-05-17 11:30:06 -03:00
Scroody
99885c20ed Final Adjust 2023-05-16 15:43:06 -03:00
GuiLeme
1b26302745 [issue-17531] - merge upstream/v2.7.x-release 2023-05-16 15:30:15 -03:00
Scroody
8272b487f3 Testing 2023-05-16 14:39:56 -03:00
Anton Georgiev
510c94cfa7 Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into may16-merge 2023-05-16 13:35:47 -04:00
Ramón Souza
40c826b127 preserve font settings on page change 2023-05-16 10:41:24 -03:00
Ramón Souza
99832aa570
Merge pull request #17864 from hiroshisuga/dev2.6_fitToWidthStyle
style: Change style of fit-to-width button when it's on
2023-05-16 08:56:39 -03:00
Ramón Souza
341e2c9464
Merge pull request #17862 from hiroshisuga/patch-4
style: remove unnecessary fit-to-width style
2023-05-16 08:51:45 -03:00
Ramón Souza
af23ce542e
Merge pull request #17702 from Scroody/virtual-backgound-accepts-webp
feat (html5): Virtual backgrounds now accepts webp format
2023-05-15 17:06:41 -03:00
Ramón Souza
fecf42dada
Merge pull request #17905 from danielpetri1/export-toast-fix
fix(bbb-html5): Successful annotated export toast
2023-05-15 16:39:16 -03:00
Ramón Souza
01246a6307 fix whiteboard right-click 2023-05-15 16:21:27 -03:00
danielpetri1
6435fbbf25 Linting changes 2023-05-15 18:56:01 +00:00
Paulo Lanzarin
2b374533ae
Merge pull request #17904 from prlanzarin/u26/fix/video-button-ios-uacheck
fix: remove legacy iOS UA checks that borked camera sharing in iPads
2023-05-15 15:16:56 -03:00
Ramón Souza
dcef3e3d7b
Merge pull request #17845 from ramonlsouza/issue-17839
fix: ignore restore on update for first load of initial presentation
2023-05-15 13:41:27 -03:00
KDSBrowne
b0ae991b1f format new line character in question string 2023-05-15 16:35:32 +00:00
prlanzarin
a693133b5a fix: remove legacy iOS UA checks that borked camera sharing in iPads
There are a couple of hardcoded UA checks targeted at iOS endpoints
introduced circa 2.2-beta. One of those pops up an "unsupported" toast
when the device joins a conference - the other blocks camera
sharing.

Those checks are outdated since we transitioned to minBrowserVersions
approach that redirects the client to an unsupported view upon join. I
also assume the checks are bugged since, in some environments, it flags
iPadOS endpoints as iOS and version-checks it to a hardcoded "12.2"
threshold (which is incompatible with iPadOS versioning). That caused
camera sharing not to work, which is a false negative.

I consider the checks to be outdated, so I removed all references to
them.
2023-05-15 13:22:52 -03:00
danielpetri1
c0c7f9d516 Add successful file export toast 2023-05-15 16:12:12 +00:00
KDSBrowne
783428bf71 localize true/false and yes/no regex patterns 2023-05-15 16:01:53 +00:00
Anton Georgiev
4e851a7571 Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into merge-267-27 2023-05-15 11:51:17 -04:00
GuiLeme
89eafc6315 [issue-17531] - changes in review 2023-05-12 12:40:07 -03:00
Ramón Souza
494b547b49
Merge pull request #17879 from Scroody/fix-poll-results-editable-for-presenter
fix: Making poll results editing possible to presenter
2023-05-12 11:42:23 -03:00
Ramón Souza
aca4179248 add isTalking animation 2023-05-12 11:17:04 -03:00
André Castro
e9ae302d54
Making editing possible to presenter 2023-05-12 11:15:41 -03:00
Ramón Souza
102063ca60 disable drop bg, pin and focus for grid items 2023-05-12 10:34:35 -03:00
Ramón Souza
1d27aaa35b fix grid on user leave 2023-05-12 09:03:54 -03:00
Anton Georgiev
1c9ba032a6
Merge pull request #17554 from AtilaU19/reconection-fixes
fix: overlapping screen end alerts and invisible cameras on reconnections
2023-05-11 17:15:12 -04:00
GuiLeme
4c2806a018 [issue-17531] - changes in review and ES-lint fixes 2023-05-11 18:06:48 -03:00
Ramón Souza
ffe8754733 add grid layout 2023-05-11 17:20:26 -03:00
KDSBrowne
eb1f5f5935 update to react 18 2023-05-11 16:16:10 +00:00
Anton Georgiev
9c513f2bab
Merge pull request #17777 from danielpetri1/notes-current-issue
fix(bbb-html5): Inconsistent current presentation indicator
2023-05-11 09:10:07 -04:00
Anton Georgiev
adc654880c
Merge pull request #17868 from Scroody/I-17734
Fix: Order of first and last names in save users
2023-05-10 17:43:40 -04:00
Anton Georgiev
52df800720
Merge pull request #17837 from Scroody/I-17684
Fix: editable polls.
2023-05-10 17:43:08 -04:00
Anton Georgiev
a91ae56b34
Merge pull request #17822 from ramonlsouza/issue-17720
fix: Toast notifications shows again when the language is switched
2023-05-10 15:49:08 -04:00
Scroody
1c777fca3b Fix: Order of first and last names in save users 2023-05-10 15:33:51 -03:00
Gustavo Trott
32276c084b Fix second user trying to open private chat 2023-05-10 14:55:33 -03:00
hiroshisuga
d07afd5414
Update component.jsx 2023-05-10 23:54:17 +09:00
hiroshisuga
c2422a96dd
Update styles.js 2023-05-10 23:53:11 +09:00
hiroshisuga
63318919d8
Update styles.js 2023-05-10 23:34:49 +09:00
Ramón Souza
5b1c0bef9d
Merge pull request #17846 from Scroody/I-17832
Fix: Closed captions hindering elements
2023-05-10 10:15:10 -03:00
KDSBrowne
4ad5b93f3b update tabindex value 2023-05-10 02:15:08 +00:00
KDSBrowne
1b51377147 fix getContentAnchorEl console error 2023-05-10 01:31:48 +00:00
bigbluebutton
a7b8704b06 update material ui from v4 to v5 2023-05-10 00:09:54 +00:00
Anton Georgiev
677ecd7406
Merge pull request #17561 from KDSBrowne/bbb-005
fix: Update Question Regex to Exclude URLs
2023-05-09 17:51:09 -04:00
Arthurk12
9c5b2e9d06 fix(camera as content): close modal
Adds missing code to close the webcam modal when camera as content
is stopped via webcam modal's button.
2023-05-09 17:21:49 -03:00
Carlos
1aa659a1ff fix(camera as content): removed extra configs in the modal 2023-05-09 17:21:48 -03:00
Carlos
5ddfb8b883 fix(camera as content): merge fixes 2023-05-09 17:21:48 -03:00
Arthurk12
a03064aa41 fix(camera as content): stop ongoing screenshare
Camera as content and screenshare are 2 features that are mutually exclusive
because they share the same space in the UI. This commit adds the behavior
that when one this features is started, the other one is closed if it is
running.
2023-05-09 17:21:48 -03:00
Arthurk12
d0c460f9c0 fix(camera as content): device sharing
Prevents the same camera device from being shared twice(webcam and "camera
as content"). The camera device shared using the camera as content feature
is tracked locally and then taken into account in the video-preview modal.
2023-05-09 17:21:48 -03:00
Arthurk12
7697367335 feat(screenshare): make component generic
Turns the screenshare component into a generic component, so that it can be
used both for screenshare and camera as content fetures.
Also changes specific locales and icons for the camera as content feature.
2023-05-09 17:21:47 -03:00
Arthurk12
e902f2ee27 feat(screenshare): add contentType field
This commit adds a contentType field in the back-end components of the
screenshare feature in order to accomodate the new 'camera as content'
feature.
2023-05-09 17:21:47 -03:00
Arthurk12
33c9abd874 requested changes 2023-05-09 17:21:47 -03:00
Carlos
8f8bfc8903 feat(camera as content): port to BBB
Enables the presenter to share a camera in the presentation area.
The shared camera automatically uses a pre-defined, fixed and hidden camera.
Profile defined in the settings.yml file.
It is currently using the screenshare's backend.
2023-05-09 17:21:46 -03:00
Scroody
cdfa38ad85 Change of approach 2023-05-09 15:51:35 -03:00
Scroody
0cc3a4e818 Fix: Closed captions hindering elements 2023-05-09 14:26:27 -03:00
GuiLeme
d2c5b33eec [issue-17839] - back-end part for hide_presentation_on_join issue 2023-05-09 12:01:55 -03:00
Anton Georgiev
2645bc8d83
Merge pull request #17827 from hiroshisuga/patch-3
fix(poll): fix Yes/No quick poll button
2023-05-09 10:38:42 -04:00
Ramón Souza
854d0a162e wip: ignore restore on update for first load of initial presentation 2023-05-09 10:58:40 -03:00
Anton Georgiev
c8342ce5ac
Merge pull request #17821 from antobinary/meteor-timeout-part-2
refactor: ensure setTimeout and clearTimeout run within Fiber
2023-05-08 16:23:19 -04:00
Anton Georgiev
9d1a4e1dfc
Merge pull request #17829 from ramonlsouza/issue-17819
fix: Joining a meeting with pinned shared notes you don't see presentation area
2023-05-08 16:13:52 -04:00
Scroody
46b9cfa1e2 Id correction 2023-05-08 16:03:24 -03:00
Scroody
d0b73e9c0b Fix: editable polls. 2023-05-08 15:50:43 -03:00
Anton Georgiev
d04c07d59b
Merge pull request #17818 from ramonlsouza/issue-17723
fix(chat): character limit warning is not removed on submit
2023-05-08 09:15:06 -04:00
Anton Georgiev
1340265d26
Update bigbluebutton-html5/imports/api/users/server/handlers/validateAuthToken.js 2023-05-08 09:05:13 -04:00
Ramón Souza
a97d0216eb fix pinned shared notes on join 2023-05-08 10:01:08 -03:00
hiroshisuga
c66177d543
Update component.jsx 2023-05-07 00:20:55 +09:00
Anton Georgiev
1746c9376f refactor: add userId and authToken for each PendingAuth 2023-05-05 16:01:07 -04:00
Ramón Souza
b5b98ff911 fix notifications being displayed more than once 2023-05-05 16:55:37 -03:00
Anton Georgiev
340f727b0f refactor: ensure setTimeout and clearTimeout run within Fiber 2023-05-05 15:39:27 -04:00
Anton Georgiev
f51205a119 refactor: adding logs for closing the connection due to invalid user 2023-05-05 15:28:21 -04:00
Ramón Souza
7898482c58 remove error message from chat input on submit 2023-05-05 15:00:21 -03:00
Paul Trudel
cdfe54bc56 Use meteor.setTimeout to keep call inside fiber 2023-05-05 15:26:56 +00:00
Anton Georgiev
9814e4ebaf
Merge pull request #17811 from antonbsa/layout-tests-migration
test: Layout tests additions and serial mode migration
2023-05-04 16:27:16 -04:00
Anton Georgiev
5f0686697a
Merge pull request #17792 from Scroody/I-17741
fix: Default cursor not appearing when entering meeting.
2023-05-04 10:38:31 -04:00
Anton Georgiev
d2cfe301d7
Merge pull request #17806 from ramonlsouza/fix-multi-user-cursor
fix: cursor not appearing for non-presenter when multi-user whiteboard is enabled
2023-05-04 10:37:11 -04:00
Ramón Souza
c3ad0e7727 fix cursor for multi-user whiteboard 2023-05-04 09:20:36 -03:00
GuiLeme
90078aedc7 [issue-17531] - resolve conflicts with 2.7 2023-05-04 08:56:27 -03:00
GuiLeme
f650ade561 [issue-17531] - prevent user from exporting annotations when there is no annotation 2023-05-04 08:48:32 -03:00
Tainan Felipe
66052802c0 Fix: duplicate messages when start a new chat 2023-05-03 17:14:05 -03:00
Anton Georgiev
80079bd3bf
Merge pull request #17798 from Scroody/meteor-migration
fix: Meteor migration async annotation tweaks
2023-05-03 15:12:12 -04:00
Scroody
ab8e8b9ddb Changes to annotations async 2023-05-03 13:56:47 -03:00
Scroody
1a75eb884e Tweeks to annotations async 2023-05-03 13:53:28 -03:00
GuiLeme
f3969c083a [issue-17531] - disabled dropdown when uploading a presentation to not throw errors 2023-05-03 08:50:36 -03:00
Scroody
85669f0038 Fix: Default cursor not appearing when entering meeting. 2023-05-02 15:32:10 -03:00
Ramón Souza
f6ae122fd0
Merge pull request #17728 from ramonlsouza/fix-private-typing-indicator
fix: typing indicator does not work in private chat
2023-05-02 11:26:04 -03:00
Ramón Souza
fdaf5af5ce
Merge pull request #17759 from ramonlsouza/issue-17739
fix: Part of the camera border is not resizable when positioned below the chat
2023-05-02 11:25:49 -03:00
GuiLeme
f03c01399f [issue-17531] - added ConvertedPresentationName to be referenced when getting the link to downloading the original file 2023-05-02 11:14:40 -03:00
danielpetri1
72c0606a80 Fix current presentation indicator 2023-05-01 14:01:04 +00:00
Lucas Fialho Zawacki
fcb6b94787 feature(reactions): Flags to enable new/old status button and to position it centered or to the right 2023-04-28 14:10:27 -03:00
Lucas Zawacki
f81652a4dd feature(reactions): Unify reaction messages with emoji status and pass it through akka 2023-04-28 11:47:15 -03:00
Lucas Fialho Zawacki
f18130c4f3 fix(reactions): Correct style after merge 2023-04-28 11:35:41 -03:00
André Castro
2c52c1a596
Merge branch 'v2.6.x-release' into I-17465 2023-04-27 19:25:56 -03:00
Ramón Souza
65e16518dc
Merge pull request #17676 from Scroody/fix-draggable-cameras-no-presentation
Fix: Draggable cameras when presentation minimized.
2023-04-27 19:16:01 -03:00
Ramón Souza
d082d0b044 fix sidebar resizing on cameradock 2023-04-27 18:59:13 -03:00
Lucas Fialho Zawacki
2a3e2d4993 feat(user-actions): enabled option in settings.yml 2023-04-27 18:37:18 -03:00
Lucas Fialho Zawacki
b91697d0b9 fix(reactions): Fix merge 2023-04-27 18:31:11 -03:00
Carlos Henrique
2fba5f23ac fix(reactions) reactions when using avatar
Add a variable that removes the avatar before applying the reaction.
2023-04-27 15:43:25 -03:00
Lucas Zawacki
94e045d0e7 fix(reactions): Fix chat input reactions button 2023-04-27 15:42:47 -03:00
Carlos
6728d0a725 fix(reactions): working after 2.5 merge
Reactions are working now
2023-04-27 14:49:09 -03:00
Carlos
fe745dea94 fix(reactions) menu blocking reactions button
Add options to dropdown.
2023-04-27 14:48:27 -03:00
Carlos
747a02a573 fix(reactions) bug display
Fix bug that causes the emoji modal be too large.
Fix bug when modal is on mobile.
2023-04-27 14:40:38 -03:00
Carlos
3b6c1d565c fix(interactions): add correct border
Fix hand button border style.
2023-04-27 14:40:08 -03:00
Carlos
3990f29f7c fix(reactions): reactions emoji picker
Fix reaction add style.
2023-04-27 14:20:53 -03:00
Arthurk12
b565a91cd2 fix(interactions): raised hands toast
Makes user avatars on raised hands toast appear with the same
color and same avatar image they have in the user list.
2023-04-27 14:16:35 -03:00
Max Franke
6d146d07d4 fix(interactions-button): typo 2023-04-27 14:08:16 -03:00
Max Franke
ddd1712f56 fix(interactions): user status debounce 2023-04-27 14:04:55 -03:00
Max Franke
fbcc611bd9 feat(interactions): add new interactions button
Interactions button is a button that stays in action bar.
Integrates several features in just one place: user-reaction, raise hand,
user-status (away/not away), toggle question panel.
2023-04-27 13:57:40 -03:00
Max Franke
d28b93a586 feat(reactions): add user reaction
add user-reaction collection
add emoji picker for user reaction in the user list
add options to enable/disable user-reaction
add a way to pass style to emoji-picker component
2023-04-27 11:54:11 -03:00
Anton Georgiev
4406dcb971
Merge pull request #17744 from diegobenetti/transfer-button-not-displayed-in-tablets
fix: Transfer button not displayed in tablets
2023-04-27 08:37:46 -04:00
Diego Benetti
910e3f2e6f Fixes url concatenation to encode the parameters 2023-04-27 12:17:14 +00:00
Anton Barboza
860766b4cf Merge remote-tracking branch 'upstream/v2.6.x-release' into layout-tests-migration 2023-04-26 15:14:24 -03:00
André Castro
14d80a2154
Update bigbluebutton-html5/imports/ui/components/webcam/component.jsx
Co-authored-by: Samuel Weirich <4281791+SamuelWei@users.noreply.github.com>
2023-04-26 14:59:45 -03:00
André Castro
d1e72d9ada
Update bigbluebutton-html5/imports/ui/components/webcam/component.jsx
Co-authored-by: Samuel Weirich <4281791+SamuelWei@users.noreply.github.com>
2023-04-26 14:54:30 -03:00
Diego Benetti
9306e38dd9 Improves iOS detection to consider tablet as iOS instead of macOS 2023-04-26 14:33:27 +00:00
andre-imdt
d4b3a3b0e8 New logic apllied to dragging cameras. 2023-04-26 11:28:59 -03:00
Anton Barboza
9628f03af1 test: add smart, custom and push layout tests 2023-04-25 18:20:48 -03:00
Ramón Souza
2e8f3bdbb8 fix typing indicator in private chat 2023-04-25 16:59:07 -03:00
Lucas Zawacki
894bd3e126 fix(transcription): Don't set webspeech provider for transcription-controller 2023-04-25 10:25:35 -03:00
Arthurk12
3b871e5ca2 fix(captions): "not supported" in chrome
Fixes a case where the locale selector don't show up in Chrome when using
'webspeech' provider.
And adds missing fields to the webspeech transcription messages, after the
addition of some new parameters to those messages with the open
transcription server.
2023-04-25 10:25:20 -03:00
Arthurk12
eafa0f200e feat(captions): no longer writes in the pad
This feature was too coupled to the old closed captions' pads.
(e.g. the old closed captions feature should be enabled for this
 to work properly)
Some things were hardcoded and others didn't make sense from the
user experience perspective.
Reverts #876d8aa.
Partially reverts #802964f, removes changes to make closed captions'
pads compatible with live-transcription but keeps provider settings.
2023-04-25 10:24:48 -03:00
prlanzarin
54b6578b03 fix(audio): forcefully disable stereo when using Vosk transcription
The current Vosk CC provider does not support stereo mic streams
(pending investigation as to why).

This commits makes sure stereo is forcefully disabled via SDP munging
only when transcription is active and using Vosk. Having it disabled
in the server side (FreeSWITCH) is not enough because the stereo parameter
is client mandated and replicated by FS on its answer. So we need to
make sure it's always disabled for the time being.
SFU audio does munging server side (and stereo is always off), so no changes
needed there.

The rest of the providers (except WebSpeech) need to be validated against
stereo audio as well.
This is also intended to be temporary - ideally this needs to be fixed in
mod_audio_fork/Vosk/wherever this is breaking.
2023-04-25 10:10:39 -03:00
Lucas Fialho Zawacki
4400cc68c8 feat(captions): Add SetUserSpeechLocaleMsg files 2023-04-25 10:05:16 -03:00
Lucas Fialho Zawacki
fee6ff026a feat(captions): Use setUserSpeechLocale as an akka event and catch it in the transcription manager 2023-04-25 09:54:34 -03:00
Lucas Fialho Zawacki
6979432c36 feat(transcription): Server side open source transcriptions 2023-04-24 18:23:34 -03:00
Ramón Souza
af8556e026 Merge remote-tracking branch 'upstream/v2.6.x-release' into 26-27-apr24 2023-04-24 17:15:47 -03:00
andre-imdt
cb02bd965e Fix: Cameras don't obstruct buttons anymore. 2023-04-24 17:02:05 -03:00
andre-imdt
df9d11180f Enhancement: Virutal backgrounds now accepts webp 2023-04-24 13:56:54 -03:00
Anton Georgiev
bf04095593
Merge pull request #17695 from KDSBrowne/bbb-iphone-patch
fix: Prevent Webcam Styling Crash On iPhones
2023-04-24 08:56:57 -04:00
Ramón Souza
3fd5fbd9c6
Merge pull request #17686 from ramonlsouza/fix-dropdown-ios
fix: Wrong style for set status dropdown button on iPhone
2023-04-24 09:47:01 -03:00
KDSBrowne
2c01efd969 add new line 2023-04-23 21:03:38 +00:00
KDSBrowne
9bdf7d5381 fix styling crash on iPhones by using pt units 2023-04-23 20:49:53 +00:00
Anton Georgiev
ba033ab10e
Merge pull request #17685 from KDSBrowne/bbb-ipad-canvas-patch-2
fix: Disable Canvas Magnifier On iPad While Using Canvas
2023-04-20 16:24:37 -04:00
KDSBrowne
82c946233f
Update bigbluebutton-html5/imports/ui/components/whiteboard/cursors/component.jsx
Co-authored-by: Anton Georgiev <antobinary@users.noreply.github.com>
2023-04-20 16:14:42 -04:00
Ramón Souza
861ef712b3 fix dropdown size on ios 2023-04-20 15:56:00 -03:00
KDSBrowne
8ee76b6b3e restore chat text selection | disable loupe in ipad while writing on canvas 2023-04-20 18:13:45 +00:00
GuiLeme
6e05e3ca51 [issue-17131] - Suggestions in review and some change of behavior 2023-04-20 08:48:43 -03:00
Ramón Souza
5cd67818b5
Merge pull request #17673 from ramonlsouza/issue-17668
Fix: Presentation un-minimizing when exiting external video or screen sharing.
2023-04-19 16:38:02 -03:00
Scroody
23bac8b628 Fix: Draggable cameras when presentation minimized 2023-04-19 14:04:28 -03:00
Gustavo Trott
d19d286811 Adds prop color for voiceUsers create msgs 2023-04-19 12:16:35 -03:00
Ramón Souza
c89349858b
Merge pull request #17667 from KDSBrowne/bbb-autohide-tools-fix
fix: Patch Auto Hidden Tools To Stay Invisible On Page Change
2023-04-19 10:46:26 -03:00
Ramón Souza
ce627f8bdb fix presentation minimized after screenshare 2023-04-19 09:41:30 -03:00
Scroody
e27c50a487 Fix: Presentation unminimizing when exiting external video or screen share. 2023-04-19 08:25:24 -03:00
Anton Georgiev
7b864cc841
Revert "Fix: Presentation un-minimizing when exiting external video or screen sharing." 2023-04-18 17:18:46 -04:00
KDSBrowne
65ac2b6d55 patch auto hidden tools to stay invisible on page change 2023-04-18 20:56:18 +00:00
Anton Georgiev
a811888dea
Merge pull request #17664 from ramonlsouza/keep-toolbar-on-resize
fix: whiteboard toolbar reappears if whiteboard is resized
2023-04-18 16:31:23 -04:00
Ramón Souza
2c8f357977 keep whiteboard toolbar hidden on resize / slide change 2023-04-18 15:03:22 -03:00
GuiLeme
13e37e61c3 [issue-17531] - removing logs for debbug 2023-04-17 09:44:56 -03:00
GuiLeme
90bbb10de6 [issue-17531] - insert tag besides the presentation's name 2023-04-17 09:04:58 -03:00
Ramón Souza
ae83dd3b94
Merge pull request #17512 from Scroody/I-17464
Fix: Presentation un-minimizing when exiting external video or screen sharing.
2023-04-17 08:35:24 -03:00
Paulo Lanzarin
5c2e9bff94
Merge pull request #17021 from prlanzarin/u27/fix/audio-reconn-inbound-delay
fix(audio): decouple remote media setup (play) from state callback
2023-04-14 16:08:25 -03:00
Paulo Lanzarin
88b5feb21f
Merge pull request #17508 from prlanzarin/u26/fix/cam-reconn-state-sync
fix(video): ensure streams are always attached on reconnections
2023-04-14 16:08:09 -03:00
Paulo Lanzarin
a7fec34cd1
Merge pull request #17524 from prlanzarin/u27/refactor/remove-vu-socket-ejection
refactor(audio): remove unused VU ejection on socket disconnection
2023-04-14 16:07:49 -03:00
Paulo Lanzarin
7c1f036b9e
Merge pull request #17526 from prlanzarin/u26/fix/ff-default-output-live
fix(audio): add default output device placeholder in input-stream-live-selector
2023-04-14 16:07:21 -03:00
KDSBrowne
3a6fde4fd0 disable toolbar autohide animations based on app settings 2023-04-14 15:27:37 +00:00
GuiLeme
536285fc37 [issue-17531] - restored old feature of downloading original presentation 2023-04-14 11:04:24 -03:00
KDSBrowne
610af45daf fix an error for undefined of includes 2023-04-13 20:13:30 +00:00
KDSBrowne
63e2a2b5e9 update question regex to exclude urls 2023-04-13 20:03:06 +00:00
Scroody
809a2a7012 Fix: Bigger presentations now restore on update as well 2023-04-13 15:25:31 -03:00
KDSBrowne
d0d3862708 Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into bbb-hover-tools 2023-04-13 17:45:39 +00:00
André Castro
e00a258d0d
Merge branch 'v2.6.x-release' into fix-warnings-on-create 2023-04-13 11:27:50 -03:00
Scroody
100e96bb99 panSelected added back to styles.js 2023-04-13 11:20:32 -03:00
Scroody
416656087a panSelected now passed as styleProp 2023-04-13 11:13:20 -03:00
Scroody
e3477b5e42 Fix: Restore on update 2023-04-13 10:56:54 -03:00
AtilaU19
6cb30af4e3 fix(webcams): insivible grid correction 2023-04-13 10:36:55 -03:00
AtilaU19
0654bc9394 fix(screenshare): correct end alert behavior 2023-04-13 10:34:29 -03:00
GuiLeme
b9f9e0f95d [issue-16954] - fix close randomUserModal for user doesn't affect presenter 2023-04-12 16:05:54 -03:00
KDSBrowne
628f001de6 handle update when userlist is resized 2023-04-12 18:36:13 +00:00
KDSBrowne
b9c04ad319 add presentationAreaHeight & presentationAreaWidth to editable wb key | remove throttle func 2023-04-12 17:03:54 +00:00
GuiLeme
d1025fcbe5 [issue-16954] - Changes in review and fix of minor bugs 2023-04-12 12:51:23 -03:00
Ramón Souza
6a06f994a9
Merge branch 'v2.6.x-release' into meteor-migration 2023-04-12 11:03:13 -03:00
Ramón Souza
99bc15a94b
Merge pull request #17513 from Carloshsc/screenshare-autoplay-bbb
fix(screenshare) autoplay overlay
2023-04-12 10:02:28 -03:00
Anton Georgiev
730e1e26e4
Merge pull request #17496 from gustavotrott/set-ismobile-on-akkaapps
refactor: Stores user-isMobile flag in akka-apps (instead of only in Meteor/Mongo)
2023-04-12 07:30:08 -04:00
Anton Georgiev
abc94a2906
Merge pull request #17495 from gustavotrott/pick-usercolor-on-akkaapps
refactor: Moves user color picker to akka-apps (instead of meteor-backend)
2023-04-12 07:08:35 -04:00
prlanzarin
b17ba35238 fix(audio): decouple remote media setup (play) from state callback
Audio state callback and remote media setup both depend on FS's state
(comes through Meteor) and the ICE state (local, peer connection). The
caveat: FS's state can come delayed on reconnection scenarios because
Meteor's websocket generally takes significantly longer to re-connect than
the peer connection, which means the ICE state gets completed way before FS
is flagged as ready.
The practical issue: while outbound audio (client -> FS) will work, inbound
audio (FS -> client) won't _just because it wasn't played_ (even though
data is  coming through).

This commit decouples the remote media setup step from the state
through:
  - Setup remote media when ICE state is completed
  - Run the state callback only after FS is flagged as ready. This
    should maintain the UI states consistent across client-server.
    Keep in mind the assumption that if FS is ready, ICE is completed by
    consequence.
2023-04-11 16:02:20 -03:00
prlanzarin
fb30b145af refactor: remove unused VU ejection on socket disconnection
The voice user ejection callback tethered to Meteor's socket
disconnection seems broken (since its introduction). The VU selector
uses an invalid field (requesterUserId) - so no VU is ever returned.

Since I'm unaware of the original goal behind this code and there's
already ejections in place in other components (akka-apps, for
instance), this is basically a revert of #9888.
2023-04-11 15:58:22 -03:00
prlanzarin
a47ef9c244 fix(audio): add default device placeholder in input-stream-live-selector
Handles scenarios where setSinkId is not supported and use a placeholder Default device label
2023-04-11 15:48:02 -03:00
Ramón Souza
fb308f0a60
Merge pull request #17397 from hiroshisuga/dev2.6.1_tooltip
[2.6 fix] Show the pan tool tip at the same timing and position as other tools
2023-04-11 13:18:18 -03:00
Anton Georgiev
94de530108
Merge pull request #17509 from KDSBrowne/bbb-imp-chat-sr
fix(access): Remove Aria-Live From Chat Area
2023-04-11 11:40:07 -04:00
GuiLeme
5eb29e0ab5 [issue-16954] - merge upstream/v2.7.x-release 2023-04-11 11:02:00 -03:00
prlanzarin
5d214cb27d fix(video): ensure streams are always attached on reconnections
There's a scenario where remote streams won't be attached again if the
sharer experienced a Meteor/client disconnection.
The disconnection empties some necessary user data temporarily, which
causes the corresponding video-list-item to be unmounted while the peer
persists for a little longer.
If the sharer re-connects fast enough, video-list-item will re-mount but
will 1) miss the current stream state (ie stuck in loading) 2) fail to
re-attach the streams since the peer was already flagged as attached.

Ensure remote camera streams are always attached and shown by:
  - always propagating the current stream state on attachment
  - refactoring the attachment pre-requisites away from a static boolean
    to a required data + diff check (based on target and current
    attached streams)
2023-04-11 09:36:13 -03:00
Paulo Lanzarin
67e4a9ebf3
Merge pull request #17394 from schrd/fix-issue-16057
Fix: Workaround firefox' missing audio output selection
2023-04-11 09:04:23 -03:00
Ramón Souza
95f4212c59
Merge pull request #16115 from KDSBrowne/dev26-link-nl
fix: Handle External Video Links On Multi Lines In Smart Slides
2023-04-11 09:04:13 -03:00
Daniel Schreiber
68c583f53e Fix: Workaround firefox' missing audio output selection
Firefox does not support selecting an audio output device in its default
configuration. This works around this flaw by just displaying default
output instead of no device found.

Fixes #16057
2023-04-11 10:41:32 +02:00
Carlos
1f16c8b483 fix(screenshare) autoplay overlay
Changed z-index of autoplay overlay.
2023-04-10 16:51:20 -03:00
Scroody
5b0bc16e5c Fix: Presentation unminimizing when exiting external video or screen share. 2023-04-10 16:25:19 -03:00
Scroody
69f39da665 Fix: Poll results not appearing. 2023-04-10 11:17:35 -03:00
Ramón Souza
d70788e832
Merge pull request #17060 from hiroshisuga/testHideTools
[2.6] Hide tldraw toolbar
2023-04-10 08:51:53 -03:00
Gustavo Trott
0b2bf8f68b Akka-apps will set mobile flag instead of Meteor 2023-04-06 17:43:57 -03:00
Ramón Souza
abbe64ab16
add missing await 2023-04-06 17:04:47 -03:00
Gustavo Trott
0630fb05ea Moves user color picker to akka-apps instead of meteor-backend 2023-04-06 16:39:05 -03:00
Scroody
958170bf8a Fix: Warnings when creating new meetings solved. 2023-04-06 16:22:21 -03:00
Ramón Souza
ca668f165e
Merge branch 'v2.6.x-release' into meteor-migration 2023-04-06 16:06:10 -03:00
Ramón Souza
17f428d0af
Merge pull request #17486 from danielpetri1/blank-space
fix(bbb-html5): Maximize webcams when removing all presentations
2023-04-06 13:17:52 -03:00
Anton Georgiev
72c575b911 Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into merge-apr-6 2023-04-06 11:50:26 -04:00
danielpetri1
eb9b12a581 No blank space in sidebar 2023-04-06 14:37:34 +00:00
Ramón Souza
030384b165
Merge pull request #17382 from KDSBrowne/bbb-imp-menu-access
fix(access): Keyboard Navigation With Arrows Only In Dropdown Menus
2023-04-06 09:33:37 -03:00
Ramón Souza
cd7fc0b11f
Merge pull request #17392 from KDSBrowne/bbb-17164
fix: Preserve Tool & Style Settings On Page Change
2023-04-06 09:09:51 -03:00
Anton Georgiev
e2dc7da98a
Merge pull request #16828 from prlanzarin/u27/fix/ss-cam-reconn
fix: re-connection improvements for cameras and screen sharing
2023-04-05 16:13:01 -04:00
Anton Georgiev
14b1abb6e4
Merge pull request #17114 from prlanzarin/u26/fix/echo-switch-output
fix(audio): output device changes not effective in local echo test
2023-04-05 16:11:28 -04:00
Anton Georgiev
124ab8d972
Merge pull request #17468 from prlanzarin/u26/feat/sfu-gather-block
feat: add option to force/extend gathering window in SFU components, +
2023-04-05 15:52:10 -04:00
Anton Georgiev
f6004b477c
Merge pull request #17340 from KDSBrowne/bbb-16951
fix: Handle Exception While Invoking ZoomSlide
2023-04-05 15:17:26 -04:00
Anton Georgiev
173ca01519
Merge pull request #17344 from KDSBrowne/bbb-17331
fix: Move Setting isForcePanning To Patch Event
2023-04-05 15:16:29 -04:00
Anton Georgiev
cc820ad02d
Merge pull request #17370 from Scroody/I-17330
Fixed: Error when trying to apply custom styles via URL.
2023-04-05 15:15:57 -04:00
Ramón Souza
92275c4e49
Merge pull request #17455 from Scroody/I-17403
Enhancement: Unread and read privet chats now order by unread and alphabetical order.
2023-04-05 15:36:17 -03:00
Scroody
4696503c81 Add: Order priority by number of unread messages. 2023-04-05 15:20:49 -03:00
Ramón Souza
10a00d8e05
Merge pull request #17427 from Scroody/fix-bbb-tips
Fix: BBB tips overlapping other elements out of his own box
2023-04-05 15:18:48 -03:00
Anton Georgiev
29f9bc47bd
Merge pull request #17436 from Carloshsc/bug-waiting-for-approval
fix(reconnect): Fix waiting for approval
2023-04-05 13:56:23 -04:00
Scroody
8bacc855a6 Fix: bug in animation caused by CSS overflow. 2023-04-05 14:46:22 -03:00
Ramón Souza
5d960887d2
Merge pull request #17395 from hiroshisuga/dev2.6.1_toolbarhover
[2.6 fix] recover hover effect on icons of whiteboard toolbar
2023-04-05 14:43:45 -03:00
prlanzarin
f4b4de6f88 fix(video): prevent a client crash when cleaning up video peers
There's a very rare scenario where the client may crash if a video
publisher is released before the source stream had its inactivation
listener callback set up.

This adds a type check to the inactivation handler before trying to
clean it up.
2023-04-05 13:31:59 -03:00
prlanzarin
c81a7e70f2 fix: properly check constraints before creating transceivers in peer.js
In peer.js offer generation method, the provided constraitns are only
being type checked. It needs a value check when the constraint is a
boolean.

This commit should prevent useless transceivers from being added when
explictly specifying audio/video as `false`
2023-04-05 13:30:30 -03:00
prlanzarin
be6a23a003 feat: add option to force/extend gathering window in SFU components
There's an edge case in finnicky networks where ALG-like firewalls
tamper with USE-CANDIDATE STUN packets and, consequently, bork ICE-lite
connectivity establishment. The odd part is that client-side gathering
seems to complete if intermediate STUN bindings work (before the final
USE-CANDIDATE), which may cause the peer not to generate relay
candidates == connectivity fails.

This adds the `public.kurento.gatheringTimeout` option to forcefully extend
the candidate gathering window in peers that act as offerers. The
behavior is as follows: if the flag is set (ms), the peer will wait
either the gathering completed stage or, _at most_,
public.kurento.gatheringTimeout ms before proceeding with calls chained
to setLocalDescription.

This option is disabled by default and intentionally ommited from the
base settings.yml file as to not encourage its use. Don't use it unless
you know what you're doing :).
2023-04-05 13:22:38 -03:00
Ramón Souza
a4c074658e
Merge pull request #17434 from ramonlsouza/fix-cam-position-sidebar
fix: camera position when notificationBar appears
2023-04-05 13:03:31 -03:00
danielpetri1
b91e766184 Maximize webcams when all presentations removed 2023-04-05 15:37:56 +00:00
Ramón Souza
20f020a7b2 replace react-color with react-colorful 2023-04-05 10:49:07 -03:00
Scroody
868ee54371 Enhancement: Unread and read privet chats now order by unread and alphabetical order. 2023-04-05 10:38:59 -03:00
Ramón Souza
7438f100fe remove new instances of lodash methods 2023-04-05 09:44:47 -03:00
Ramón Souza
bcd504b749 Merge remote-tracking branch 'upstream/v2.7.x-release' into lodash-radash 2023-04-05 09:42:05 -03:00
Carlos
39b308b91f fix(reconnect) waiting for approval
Removed code that enter the old status "waiting for approval".
2023-04-04 10:47:32 -03:00
Ramón Souza
caddf61259 fix camera position when notificationBar appears 2023-04-04 09:34:00 -03:00
hiroshisuga
b3e6cf0c78
Fix a bug
Clicking the presentation with the pan tool selected grayed the presentation.
2023-04-04 17:40:21 +09:00
hiroshisuga
4d2c6fecc0
lower case to avoid warning 2023-04-04 12:09:45 +09:00
hiroshisuga
5bc2976328
lower case to avoid warning 2023-04-04 12:08:35 +09:00
hiroshisuga
09460c3de0
Fix toggle animation setting
ignore the update if "delay" prop is set for the pan tool.
2023-04-04 11:03:51 +09:00
Scroody
356cf73f3c Fix: BBB tips overlapping other elements out of his own box 2023-04-03 15:10:22 -03:00
Ramón Souza
62e9b3a4d6
Merge pull request #17381 from Scroody/drop-down-arrow
style: drop down arrow better centralized.
2023-04-03 09:45:22 -03:00
hiroshisuga
58ef3c6a5a
add props to tooptip component 2023-04-03 17:13:54 +09:00
hiroshisuga
f6d401b502
add props to button component 2023-04-03 17:11:37 +09:00
hiroshisuga
828f692d7b
add two props to pan injector 2023-04-03 17:09:53 +09:00
hiroshisuga
d873156ed8
Update styles.js 2023-04-03 00:30:22 +09:00
hiroshisuga
2a31b1e0ee
Update styles.js 2023-04-03 00:13:44 +09:00
hiroshisuga
5be3e2ef1c
Update component.jsx 2023-04-02 23:42:12 +09:00
hiroshisuga
476c31a912
Update component.jsx 2023-04-02 23:39:41 +09:00
hiroshisuga
8b92b444ca
Update styles.js 2023-04-02 23:38:32 +09:00
KDSBrowne
a0f6bfcff2 fix the need to double click on style items 2023-04-01 21:05:27 +00:00
KDSBrowne
da66eeccc4 Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into bbb-17164 2023-04-01 20:22:50 +00:00
KDSBrowne
9abc00bcbc preserve tool and style setting on page change 2023-04-01 20:18:03 +00:00
KDSBrowne
f32ac70a7b remove unneeded aria-live area's 2023-04-01 20:10:41 +00:00
Scroody
4b965a2a71 Migration of the API to async for Meteor3.0 2023-03-31 17:40:41 -03:00
KDSBrowne
b3a6c0be98 remove aria-live from chat message list wrapper 2023-03-31 19:38:34 +00:00
KDSBrowne
9fbf5c2fde fix keyboard navigation in dropdown menus 2023-03-31 18:06:41 +00:00
imdt
90ea2bd98e Usability: drop down arrow better centralized. 2023-03-31 13:19:15 -03:00
Anton Georgiev
a6b5375391
Merge pull request #17377 from paultrudel/remove-client-config-service
refactor(bbb-web): Remove Client Config Service
2023-03-31 09:33:50 -04:00
imdt
7d117e3dd6 Fixed: Error when trying to apply custom styles via URL. 2023-03-30 17:00:41 -03:00
Anton Georgiev
2e424bd2d4
Merge pull request #15680 from antonbsa/webcam-tests
test: Webcam tests additions
2023-03-30 12:12:58 -04:00
Anton Georgiev
77c5c27153
Merge pull request #17239 from danielpetri1/content-capture-toast-fix
fix(bbb-html5): Dismiss uploading toast after content capture
2023-03-30 09:29:30 -04:00
Anton Georgiev
71b07e5cd9
Merge pull request #17054 from paultrudel/allow-mods-unmute-users-fix
fix: Recover broken allowModsToUnmuteUsers functionality
2023-03-30 09:11:48 -04:00
Anton Georgiev
eecde552ce Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into mar-30-1 2023-03-30 08:47:07 -04:00
Ramón Souza
9684847ae7
Merge pull request #17361 from Scroody/I-17351
Fixed: Error message on layout change.
2023-03-30 09:09:08 -03:00
Ramón Souza
671d9a589e
Merge branch 'v2.6.x-release' into I-17081 2023-03-30 08:58:58 -03:00
imdt
573c8a47a9 Fixed: another bug cause by undo related to the one solved initial PR. 2023-03-29 16:30:32 -03:00
Anton Georgiev
279ee3211d
Merge pull request #17345 from antobinary/fix-const
fix: fix some code smell by adding const for variables
2023-03-29 15:22:40 -04:00
GuiLeme
280a65b3fe [issue-16954] - revert config 2023-03-29 15:57:11 -03:00
imdt
0b34b4e971 Fixed: Error message on layout change. 2023-03-29 15:38:55 -03:00
GuiLeme
93cd3268c4 [issue-16954] - remove of console.log 2023-03-29 12:37:31 -03:00
Paul Trudel
f11eac6064 Re-removed userLocked check from allowedToUnmuteAudio 2023-03-29 14:50:53 +00:00
GuiLeme
a277e77718 [issue-16954] - Adjusting modal priorities and refactor of code 2023-03-29 11:38:48 -03:00
Anton B
3a7b59c19a test: add video quality and background webcam tests 2023-03-29 11:16:47 -03:00
GuiLeme
81ae4e9ca6 [issue-16954] - Adjusting modal priorities 2023-03-29 11:08:56 -03:00
GuiLeme
9b39decec7 [issue-16954] - Fix minor issues and cleanning of the old modal structure traces 2023-03-29 11:02:14 -03:00
Anton B
4b5d4e9e2a Merge remote-tracking branch 'upstream/v2.6.x-release' into webcam-tests 2023-03-29 10:29:58 -03:00
Ramón Souza
ab8d9214af fix empty slide on presentation change 2023-03-29 09:35:10 -03:00
Paul Trudel
4b24e037f2 Changed value of userLocked 2023-03-28 21:26:40 +00:00
Paul Trudel
d5f8650666 Added userLocked check to allowedToUnmuteAudio check 2023-03-28 21:24:58 +00:00
Paul Trudel
4142917f57 Re-added check for user lock to unmute 2023-03-28 18:50:16 +00:00
Paul Trudel
349886b3b1 Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into allow-mods-unmute-users-fix 2023-03-28 17:52:43 +00:00
Anton Georgiev
e654c390b7 fix: fix some code smell by adding const for variables 2023-03-28 13:25:59 -04:00
KDSBrowne
8af51216fb move setting isForcePanning to patch event 2023-03-28 16:48:25 +00:00
Anton Georgiev
5887effe7c
Merge pull request #17097 from ramonlsouza/issue-17086
fix(whiteboard): Reduce max canvas size
2023-03-28 11:06:10 -04:00
KDSBrowne
d4d3b412df handle exception while invoking method zoomSlide 2023-03-28 14:47:23 +00:00
Ramón Souza
2138c98dc1
Merge pull request #17327 from Scroody/I-16943
Fixed: Note notification removed when shared notes pinned.
2023-03-28 10:50:28 -03:00
Ramón Souza
22ce3af864
Merge pull request #17322 from ramonlsouza/issue-17022
fix(whiteboard): Bug while panning the slide by pressing the scroll mouse button or spacebar
2023-03-28 10:25:24 -03:00
Ramón Souza
1fcad3e2f3
Merge pull request #17325 from KDSBrowne/bbb-16946
fix: Update Style Menu Position On Iphone
2023-03-28 09:41:42 -03:00
imdt
deee7e393b Fixed: Note notification removed when shared notes pinned. 2023-03-27 16:58:48 -03:00
Anton Georgiev
f31378ceee
Merge pull request #17163 from ramonlsouza/meteor-tests
refactor: migrate Meteor backend to new async api
2023-03-27 15:07:00 -04:00
Anton Georgiev
bef87282e0
Merge pull request #16961 from MaximKhlobystov/whiteboard-tests-and-refactoring
test: new whiteboard tests + refactoring of visual regression tests
2023-03-27 13:35:18 -04:00
KDSBrowne
481582cbbd add missing isIphone value 2023-03-27 15:45:16 +00:00
GuiLeme
5f3296fdb1 [issue-16954] - last migrations - VideoPreview and drag and drop of background 2023-03-27 12:36:25 -03:00
KDSBrowne
fc001edd51 update style menu position on iphone 2023-03-27 15:33:10 +00:00
Ramón Souza
5cd5c14c3d do not display grab cursor if the user is not presenter 2023-03-27 11:32:43 -03:00
Ramón Souza
b3754570ed fix force panning 2023-03-27 10:38:05 -03:00
Ramón Souza
2827434739
Merge pull request #17320 from ramonlsouza/issue-17023
fix: Dragging presentation area instead of rotated shape
2023-03-27 10:31:14 -03:00
Ramón Souza
fdf9b1a7cc fix drag presentation after rotating shape 2023-03-27 09:01:59 -03:00
Ramón Souza
234d1ee0f6
Merge pull request #17194 from Arthurk12/17192
fix(presentation): workaround for slide download
2023-03-27 08:35:47 -03:00
Ramón Souza
5b0a0d7cf6
Merge pull request #17231 from Scroody/I-17125
Fixed: Missing buttons on menus in low resolutions.
2023-03-27 08:11:16 -03:00
KDSBrowne
72adc96dbe add autohide option for whitboard toolbars 2023-03-26 22:08:09 +00:00
GuiLeme
9329e194fd [issue-16954] - migration of screenshare unavailable, connectionStatus and randomUser 2023-03-24 17:48:00 -03:00
danielpetri1
a9132c7740 Dismiss processing toast after breakout capture 2023-03-24 16:19:10 +00:00
GuiLeme
c1676004d4 [issue-16954] - migration of audio modal 2023-03-24 12:29:09 -03:00
imdt
9a73db883a Fixed: Missing buttons on menus in low resolutions. 2023-03-24 11:43:55 -03:00
GuiLeme
d389a5b9e3 [issue-16954] - migration of fallback modal and caption reader modal 2023-03-24 10:07:56 -03:00
GuiLeme
c5e38507bb [fix-pres-with-errors-freeze] - fix for presentation modal uploader freez when cleaning errors. 2023-03-24 09:21:49 -03:00
GuiLeme
7ce2203c04 [issue-16954] - merge v2.6.x-release 2023-03-24 08:44:19 -03:00
Anton Georgiev
f7efedf1a7
Merge pull request #16989 from KDSBrowne/bbb-br-manage-access
fix(access): Presentation Interference With Keyboard Access in Breakout Management
2023-03-23 16:56:52 -04:00
Ramón Souza
f8ce724bcc
Merge pull request #17084 from zhem0004/redesignWU
fix: Allow viewing of longer names in guest waiting queue
2023-03-23 15:42:53 -03:00
Ramón Souza
53899b2852 styles adjustments 2023-03-23 15:41:32 -03:00
GuiLeme
53fbcf0f67 [issue-16954] - refactor modals rendering 2023-03-23 12:26:39 -03:00
GuiLeme
d4bd29ea67 [issue-16954] - Migrating userOptions and remove user modals 2023-03-23 11:56:00 -03:00
Arthurk12
b7348cffdd fix(presentation): workaround for slide download
This is a workaround to the conflict that is happening when an user tries to
download the slide when dark mode is enabled. There is a conflict between
dark mode's styles and the html-to-image lib. To temporarily prevent this from
happening, the dark mode is disabled before downloading the slide, and then
re-enabled when the download is complete.

In order to be able to enable and disable dark mode from another component than
the App, all the dark mode switch logic was extracted into the service of the
app component.
2023-03-23 10:57:46 -03:00
Ramón Souza
ade1ae22b1
Merge pull request #17107 from KDSBrowne/bbb-17093
Prevent URLs Triggering Typed Response Poll Option
2023-03-23 09:23:55 -03:00
GuiLeme
a5b5a754a0 [issue-16954] - Migrating recording modals components 2023-03-22 17:32:47 -03:00
André Castro
97749719b6 Fix: Undo bug returning to slide '0'. 2023-03-22 18:00:19 +00:00
Ramón Souza
b487f90cd8
Merge pull request #17052 from zhem0004/fixPoll
fix: Close poll on slide change
2023-03-22 14:36:21 -03:00
Ramón Souza
e08d1ed45a
Merge pull request #17110 from Tainan404/i-17072
Fix custom virtual background not being disabled when removed
2023-03-22 13:40:41 -03:00
Anton Georgiev
bae26e0b77 Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into v2.7.x-release 2023-03-22 10:44:36 -04:00
GuiLeme
2f4b0bd592 [issue-16954] - Migration of breakoutroom invitation 2023-03-22 09:50:39 -03:00
GuiLeme
86e1209049 [issue-16954] - migrating user-options createBreakoutRoomModal and GuestPolicy 2023-03-21 17:45:20 -03:00
Anton Georgiev
e0e88286e2
Merge pull request #17071 from KDSBrowne/bbb-role-rc
fix(access): Prevent Race Condition Removing Role Value
2023-03-21 15:45:09 -04:00
Anton Georgiev
b891f318af
Merge pull request #17085 from ramonlsouza/fix-preload-firefox
fix: poll results size calculation on firefox
2023-03-21 14:41:28 -04:00
GuiLeme
4e17e80873 [issue-16954] - migrating dropdown menu from presenter 2023-03-21 14:55:43 -03:00
imdt
76b546f6d6 fetchAsync not working with some method fixed. 2023-03-21 14:44:12 -03:00
GuiLeme
031ead2176 [issue-16954] - Changes to settings dropdown 2023-03-21 10:00:46 -03:00
Ramón Souza
2dee62d5e3
Merge pull request #16979 from ramonlsouza/issue-16969
fix: Copy/Paste into Guest Policy textbox will cause a text box to appear in whiteboard
2023-03-21 08:19:49 -03:00
prlanzarin
1ada7dc57e fix(audio): output device changes not effective in local echo test
Output device changes aren't working in 2.6's echo test when artifical delay
is on due to the fact that the feedback audio is being played via the WebAudio
context rather the the HTMLMediaElement. Since output device change works
via HTMLMediaElement's setSinkId, it's basically a no-op.

This commit fixes the issue by piping the AudioContext destination
through the main audio element rather than using WebAudio directly for
playback. An additional stub media element (muted) is added to circumvent one
of Chrome's WebAudio issue.
The alternative would be to use AudioContext's setSinkId, but it isn't
supported by Firefox (setSinkId enabled) and Chrome < 110.

This should work with FF (setSinkId enabled) and a wide array of Chromium
versions.
2023-03-20 17:38:06 -03:00
Anton Georgiev
87ced428f8 Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into v2.7.x-release 2023-03-20 16:24:52 -04:00
Tainan Felipe
a393ad6997 Fix custom virtual background not being disabled when removed 2023-03-20 17:17:27 -03:00
imdt
2a5142a4ea Users persistent data back-end migrated to new async API 2023-03-20 16:43:05 -03:00
Tainan Felipe
3959eab633 Refactor: Migrate video-streams for the Meteor 3.0 api 2023-03-20 16:39:36 -03:00
imdt
6949e9b59b Voice call states and voice users back-end migrated to new async API. 2023-03-20 16:39:24 -03:00
Tainan Felipe
3fb59bcb41 Refactor: Migrate screenshare for the Meteor 3.0 api 2023-03-20 16:39:11 -03:00
imdt
b27542065e Users settings migrated to new async API. 2023-03-20 16:38:56 -03:00
Tainan Felipe
f7b8b116e7 Refactor: Migrate presentation upload token for the Meteor 3.0 api 2023-03-20 16:38:42 -03:00
Tainan Felipe
029929e7d8 Refactor: Migrate pads for the Meteor 3.0 api 2023-03-20 16:38:31 -03:00
imdt
fc14710e14 Local settings back-end migrated to new async API. 2023-03-20 16:38:20 -03:00
Tainan Felipe
8b1565f2c9 Refactor: Migrate cursors for the Meteor 3.0 api 2023-03-20 16:38:05 -03:00
Tainan Felipe
2bb7235836 Refactor: Migrate group chat for the Meteor 3.0 api 2023-03-20 16:37:51 -03:00
Tainan Felipe
e3bbf1156f Refactor: Migrate auth-token for the Meteor 3.0 api 2023-03-20 16:37:36 -03:00
imdt
bbac3e5b11 Slides back-end migrated to new async API. 2023-03-20 16:37:16 -03:00
Tainan Felipe
470937bf6f Refactor: Migrate users for the Meteor 3.0 api 2023-03-20 16:35:52 -03:00
imdt
f03cc32b56 Presentation pod migrated to new async API 2023-03-20 16:35:40 -03:00
imdt
d7d1eb65da Presentations back-end migrated to new async API. 2023-03-20 16:35:06 -03:00
imdt
f3c6fbc5f2 Group chat msg back-end migrated to new async API. 2023-03-20 16:24:58 -03:00
Tainan Felipe
7c8337733f Refactor: Migrate meetings for the Meteor 3.0 api 2023-03-20 16:24:41 -03:00
imdt
16ff3be4ee External video back-end migrated to new async API 2023-03-20 16:24:26 -03:00
imdt
03e037b5ea Audio captions back-end migrated to new async API 2023-03-20 16:24:09 -03:00
imdt
5add111aa9 Connection status back-end migrated to new async API 2023-03-20 16:23:56 -03:00
Tainan Felipe
a5dea6f595 Refactor: Migrate captions for the Meteor 3.0 api 2023-03-20 16:23:41 -03:00
imdt
6472cf8d0d Breackouts history back-end migrated to new async API 2023-03-20 16:23:27 -03:00
imdt
c701ff5c66 Users info back-end migrated to new async API 2023-03-20 16:23:11 -03:00
Tainan Felipe
314395298b Refactor: Migrate whiteboard-multi-user for the Meteor 3.0 api 2023-03-20 16:22:55 -03:00
imdt
f18d4018f0 Backend of guest-users migrated to new async API. 2023-03-20 16:21:40 -03:00
Tainan Felipe
77fc5d4067 Refactor: Migrate annotations for the Meteor 3.0 api 2023-03-20 16:16:52 -03:00
imdt
074ce93a4f refactor: Migrate polls backend to new async api 2023-03-20 16:15:55 -03:00
GuiLeme
ec17b5dca9 [issue-16954] - new structure and connection status modal transition 2023-03-20 14:57:36 -03:00
KDSBrowne
de75d18e30 remove url detected as question 2023-03-20 16:18:42 +00:00
GuiLeme
e77af8874b [issue-16954] - patch for renaming 2023-03-20 10:13:35 -03:00
GuiLeme
f943cbf732 [issue-16954] - renaming referencing of Modals 2023-03-20 10:08:35 -03:00
Ramón Souza
630247a568 reduce canvas max size 2023-03-20 08:43:27 -03:00
Ramón Souza
3b849a9600 fix poll results size on firefox 2023-03-17 14:51:39 -03:00
Ramón Souza
c3d89ee4fc
Merge pull request #17044 from antobinary/fix-undefined-user
fix: Fix undefined user in rare end-breakout scenario
2023-03-17 14:06:15 -03:00
Anton Georgiev
2f3a8f03e9
Merge pull request #17083 from ramonlsouza/pr-16950
feat(layout): Recover (from 2.5) the ability of viewers to set their own layout
2023-03-17 12:50:26 -04:00
Anton Georgiev
19d3b03afd
Merge pull request #16972 from gabriellpr/learning-dashboard-test
test: learning dashboard
2023-03-17 12:25:25 -04:00
KDSBrowne
97d68f9416 fix chat semantics on mount and on update 2023-03-17 13:24:50 +00:00
Bohdan Zhemelinskyi
f5e83d336d redesign waiting user buttons 2023-03-17 13:10:27 +00:00
Ramón Souza
9a56952483 restore popup menu 2023-03-17 09:54:36 -03:00
Ramón Souza
b3be1c3a74 fix sync layout only if custom 2023-03-17 09:37:45 -03:00
Ramón Souza
f4bd2e8bef
Merge pull request #17039 from ramonlsouza/issue-16682
fix: Poll results are difficult to read and not scaled to fit slide
2023-03-17 08:41:01 -03:00
Ramón Souza
dcc9e4fb64 add links to tldraw functions 2023-03-17 08:40:24 -03:00
Ramón Souza
1cc60fda31 adjust size calculation, preload font 2023-03-16 15:55:56 -03:00
KDSBrowne
3eb54122c5 add timeout to prevent race condition removing role value 2023-03-16 15:36:28 +00:00
Ramón Souza
8dbff37a43
Merge pull request #16868 from Arthurk12/bbb/2.6/15716
fix(breakout rooms): video and audio modal appearing for all mods when rejoining
2023-03-16 10:42:16 -03:00
hiroshisuga
7e7c46b9e9
change icon 2023-03-16 21:34:13 +09:00
hiroshisuga
12a53e3a59
reset opacity RTL <-> LTR
Some comments have been removed as well.
2023-03-16 19:37:21 +09:00
hiroshisuga
d18dca3eaf
Merge pull request #153 from hiroshisuga/dev2.6.0rc8_hidetoolbar
Dev2.6.0rc8 hidetoolbar
2023-03-16 18:46:40 +09:00
Ramón Souza
c282bbfae2
Merge pull request #17049 from KDSBrowne/bbb-17046
fix: Prevent Response Poll Displaying For True / False
2023-03-15 16:48:08 -03:00
Paul Trudel
ccc0274931 Removed condition on unmute that prevented option from displaying 2023-03-15 19:01:29 +00:00
Bohdan Zhemelinskyi
ecdc5304df add prop type 2023-03-15 18:24:34 +00:00
Bohdan Zhemelinskyi
2015c50105 destructure function 2023-03-15 18:16:56 +00:00
Bohdan Zhemelinskyi
1025e4b1dc move cloe function to container 2023-03-15 18:06:59 +00:00
Bohdan Zhemelinskyi
dc9ac7a125 close poll on slide change 2023-03-15 17:12:47 +00:00
Ramón Souza
5d0b1c842f handle select all shortcut in whiteboard 2023-03-15 11:39:33 -03:00
KDSBrowne
c4d45e94b6 prevent response poll displaying for true / false 2023-03-15 13:36:40 +00:00
hiroshisuga
02fe1a8955
comment for using the API setSetting 2023-03-15 13:53:37 +09:00
hiroshisuga
0e188d5c30
menu item for tool visibility 2023-03-15 13:49:17 +09:00
hiroshisuga
1fe0edf2a4
add props hsWBAccess and amIPresenter 2023-03-15 13:43:21 +09:00
Anton Georgiev
372e17ca08 fix: check if defined before checking .role 2023-03-14 16:39:06 -04:00
Ramón Souza
cc4f7a9f0b
Merge pull request #17018 from KDSBrowne/bbb-16379
Zoom By Mouse Wheel Only Operation
2023-03-14 17:21:43 -03:00
zhem0004
5fdd91ba67
Add new setting to enable/disable extra guest policy Allow buttons (#17034)
* add new setting to enable/disable extra guest policy buttons
2023-03-14 14:39:37 -04:00
Anton Georgiev
af06006163
Merge pull request #16990 from GuiLeme/issue-16872
fix (html5): not showing invitation when user is moved to another breakout room
2023-03-14 14:26:38 -04:00
Anton Georgiev
1a3221ee3e
Merge pull request #16675 from GuiLeme/issue-16660
fix: Presentation-uploader not working properly
2023-03-14 14:24:23 -04:00
Anton Georgiev
b3d3258120 Merge branch 'issue-16872' of github.com:GuiLeme/bigbluebutton into v2.6.x-release 2023-03-14 14:22:58 -04:00
Ramón Souza
fa1ad677d6 add border and formatting to poll results 2023-03-14 15:16:21 -03:00
GuiLeme
844b0995e1 [issue-16660] - fix duplicationo of file when cleanning errors in page generation stage 2023-03-14 09:56:27 -03:00
KDSBrowne
5fe6a9a0a9 add query for canvas element 2023-03-13 17:22:38 +00:00
Ramón Souza
990e3f2e7a
Merge pull request #17011 from ramonlsouza/fix-pres-snapshot
fix: snapshot of current slide
2023-03-13 13:17:18 -03:00
KDSBrowne
53cc7c48f3 intercept wheel event and force ctrl key for zooming 2023-03-13 16:16:37 +00:00
Ramón Souza
f7586dedca
Revert "fix(html5): Empty space when removing all presentations" 2023-03-13 13:09:31 -03:00
GuiLeme
4f3931c0ff [issue-16872] - Changes in review 2023-03-13 12:44:35 -03:00
GuiLeme
e68997e673 [issue-16872] - Changes in review 2023-03-13 12:27:11 -03:00
GuiLeme
f7649cdd19 [issue-16872] - Change session logic to event logic 2023-03-13 11:13:56 -03:00
Ramón Souza
4a6c10a3dd fix whiteboard snapshot 2023-03-13 09:17:14 -03:00
Ramón Souza
718aee3514
Merge pull request #16823 from danielpetri1/issue-16511
fix(html5): Empty space when removing all presentations
2023-03-13 08:30:56 -03:00
danielpetri1
cfe77c1ba9 Maximize webcams upon joining meeting with no presentation 2023-03-12 16:47:11 +00:00
KDSBrowne
e577d0a8f7 remove disabled from pan tool 2023-03-11 17:11:48 +00:00
KDSBrowne
8eba308f36 add crosshair cursor for arrow and eraser tool 2023-03-11 16:09:30 +00:00
danielpetri1
840a824cb3 Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into issue-16511 2023-03-10 20:33:54 +00:00
GuiLeme
f711a4ca32 [issue-16872] - Fixed flashing of breakout modal invitation 2023-03-10 16:28:05 -03:00
KDSBrowne
a9e7f54a1d fix presentation interference with keyboard access in br management 2023-03-10 18:42:57 +00:00
Anton Georgiev
2c5cd8f2a0 Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into merge-26-27 2023-03-10 13:03:56 -05:00
germanocaumo
a0ef1957c6 fix(pantool): prop type warning 2023-03-10 12:36:54 +00:00
germanocaumo
37c3e4afcc Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into prest-whit-code-refactor 2023-03-10 12:22:10 +00:00
Ramón Souza
f51f445896
Merge pull request #16923 from lfzawacki/v2.6.x-release-presentation-minimize
fix(presentation): Remove old presentation minize code
2023-03-10 09:05:53 -03:00
germanocaumo
eaa7a9cb6f refactor(html5): remove unused code 2023-03-10 11:52:00 +00:00
Ramón Souza
619badda22
Merge pull request #16890 from KDSBrowne/bbb-export-notification
fix: Notifications on export presentation with annotations
2023-03-10 08:43:04 -03:00
germanocaumo
d09f2681d9 refactor(html5): presentation/whiteboard/cursor code cleanup and linting 2023-03-10 11:30:46 +00:00
Ramón Souza
6970fef004
Merge pull request #16962 from germanocaumo/cursor-fixes
fix(tldraw): cursor fixes
2023-03-10 08:04:31 -03:00
germanocaumo
a3f8147b42 fix(cursor): remove duplicate code 2023-03-09 23:10:18 +00:00
Ramón Souza
42a2a729bb auto focus on external video input 2023-03-09 16:44:47 -03:00
Ramón Souza
6bd6dd2767 fix copy/paste/cut on guest user message input 2023-03-09 14:46:45 -03:00
Ramón Souza
9a60bdcd06
Merge pull request #16971 from KDSBrowne/bbb-16959
fix: Stop Tool Lock Being Reset on Updates
2023-03-09 10:47:36 -03:00
KDSBrowne
c6379443cc
update isToolLocked initial value 2023-03-09 08:42:05 -05:00
KDSBrowne
47e7bda1a9 stop tool lock being reset on updates 2023-03-08 20:41:25 +00:00
prlanzarin
3bddbb96cf fix(video): signaling and reconnection edge cases
There are still a bunch of edge cases and issues with reconnection
scenarios for video:
  - Signaling socket refuses to reconnect once maxRetries expire
  - Race conditions on local stream attachment: local camera wouldn't be
    correctly rendered _if_ the attached stream existed _without_ video
    tracks yet
  - Video tracks leak on local streams when replacing them (virtual bgs)
  - Completely ignoring Meteor state when trying to reconnect cameras
  - Streams aren't proactively stopped when the signaling socket dies
  - Outbound request queues aren't isolated by stream nor are they
    flushed when a newer peer with the same ID is created
  - Server originated negotiation errors won't trigger a local peer
    cleanup - thus leaving dangling peers that take way too long to
    reconnect

This commit fixes or improves all of the aforementioned issues, +:
  - Remove unused arguments in the peer (client->SFU) 'start' request
  - Prevent crashes when trying to render video-list-items without user
    data (which might happen on re-connections)
2023-03-08 15:49:35 -03:00
prlanzarin
afa2908ded fix(screenshare): better reconnection timers and UI for abrupt failures
Reconnection timers are far too long for abrupt failures because we
are waiting the original timeouts to elapse (30-60s) before trying it
again - even if a connection worked N-sessions back in that session's
history. The ideal thing to have is another intermediate, smaller and
fixed reconnection timer for sessions that had a working screen share
at least once.
The UI is also not being updated to the reconnecting state on negotiation
failures.

* Add an intermediate reconnection timer for abrupt failures set to 8s.
  This should improve reconnection times.
* Lower default connection timers values (base 20s down from 30s, max
  25s down from 60s)
* Set screen share UI to reconnecting on abrupt failures as well - we
  were only tracking ICE states prior to this, not negotiation errors
2023-03-08 15:48:30 -03:00
prlanzarin
bd0dfa17cc fix(screenshare): default to not flowing is peer was lost
The media monitor responsible for triggering the reconnecting view in
the screen sharing component was maintaing the previous state (eg
flowing) in cases where the peer just failed before media stopped
flowing. That triggered an error in the bps calculations that caused the
previous state to be preserved - eg stuck in flowing while it should be
not_flowing.

These changes make it so that if there's not peer to fetch stats from,
them the bps calculations will correctly return 0 (which translates to
not_flowing).
2023-03-08 15:48:22 -03:00
prlanzarin
d2e8e74471 fix(screenshare): always try to reconnect to screen as viewer
The reconnect routine is stopping for viewers if a broker cannot
re-connect in the first try. That is wrong: viewers should try to
reconnect as long as there'sigaling data that mandates so.

The reconnect trigger is changed from broker's started attribute to the
presence of a scheduled reconnection timeout - if there isn't one (not
schedule), always re-schedule it.
2023-03-08 15:47:01 -03:00
prlanzarin
5ee0ff9af2 fix(screenshare): add proper signaling heartbeat, +
Same rationale as in video-provider's commit
(34fa37ae4f092af4a5aef0cf01d96c033d97473c).

This commit does the following:
  - Implement actual heartbeat checks to trigger reconnects when
    necessary
  - Properly catch and log WebSocket.send errors
2023-03-08 15:46:55 -03:00
prlanzarin
a83f3b675e fix(video): add proper signaling WS heartbeat, +
video-provider's current ping-pong is as good as nothing in 2.5+. We
were counting on Meteor's (and consequently the component's mount state)
before 2.5 to act as a "heartbeat" as far as the socket is concerned.
The ping-pong served only to sustain traffic for finnicky,
traffic-dependant firewall.
Since 2.5, the component's state is _kind of_ detached from Meteor's -
which means it won't unmount when Meteor disconnects. That causes the
video-provider websocket to lose its borrowed heartbeat and leads to a
bunch of reconnectiong inconsistencies, the worst of them being a stuck,
useless signaling socket that will cause cameras not to work until a
client refresh.

This commit does the following:
  - Implements actual heartbeat checks to trigger signaling socket
    reconnects when necessary, all within the scope of video-provider
  - Remove borked, eons old 'offline'/'online' event handlers: they were
    causing unnecessary camera drops AND causing video-provider to
    generate a stuck signaling socket
  - Properly catch WebSockets.send errors
2023-03-08 15:46:51 -03:00
prlanzarin
e9f0a7347c fix(video): properly render reconnecting view
The stream state change handler in video-list-item is using a component
state reference inside a DOM event callback - which means it is always
presuming `isStreamHealthy` is false (initial value). That prevents the
health state from actually transitioning when necessary (and
consequently rendering the reconnecting view in video-list item).

This commit removes the state-based transition check in the state change
handler and unifies the reconnecting view to use the username
placeholde (replacing the loading spinners).
2023-03-08 15:46:44 -03:00
germanocaumo
8aa15ef861 fix(cursor): send cursor position disabled on unmount
This fixes the cursors staying visible in the recording after the multiuser was disabled.
Also stop sending some unnecessary end events.
2023-03-08 16:39:53 +00:00
Ramón Souza
f2a3031b04
Merge pull request #16949 from KDSBrowne/bbb-chat-list-a11y
Add List and List Item Roles to Chat Elements
2023-03-08 13:14:56 -03:00
Maxim Khlobystov
8108f10d0f Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into whiteboard-tests-and-refactoring 2023-03-08 15:33:37 +00:00
Maxim Khlobystov
5f617d94db New whiteboard tests + refactoring 2023-03-08 15:33:05 +00:00
Ramón Souza
8ee8a5508f fix whiteboard crash when adding a new presentation 2023-03-08 10:01:18 -03:00
Anton Georgiev
8e640a7918 fix: avoid wb crash when switching presentation 2023-03-07 16:11:40 -05:00
Carlos Henrique
b2bc2d174c feature(layout) viewers layout
Add a button for viewers to change the layout.
2023-03-07 16:09:02 -03:00
germanocaumo
c1810360ef fix(cursor): improve cursor position for others
Cursor position was desynced after the presenter zoomed with ctrl+scroll, also fixes the last position of the cursor not being sent sometimes.
Move the throttle to the service call so it is considered in all cases (and there was already a throttle there).
2023-03-07 19:03:07 +00:00
KDSBrowne
68caf7549c add list and listitem roles to chat 2023-03-07 18:18:15 +00:00
Ramón Souza
3c376e112d
Merge pull request #16936 from ramonlsouza/not-logged-redirect
fix: return logoutUrl on logout even if the user is not logged in
2023-03-07 13:03:20 -03:00
Ramón Souza
4aeb406aaf
Merge pull request #16754 from Scroody/i-16640
fix: Banned user sees message upon return attempt (before - only blue screen)
2023-03-07 13:03:00 -03:00
Anton Georgiev
5fced70d2e
Merge pull request #16932 from hiroshisuga/patch-63
fix: Fix an inline typo
2023-03-07 09:13:18 -05:00
Ramón Souza
966a471e50
Merge pull request #16800 from Tainan404/migrate-to-async
refactor: Migrate the breakout room backend to new async api
2023-03-07 10:57:34 -03:00
Ramón Souza
5846312f93 return logoutUrl even if the user is not logged in 2023-03-07 09:38:57 -03:00
Ramón Souza
65a91970d3
Merge pull request #16820 from antobinary/indexing-2
fix: index auth-token-validation by connectionId
2023-03-07 09:04:24 -03:00
Ramón Souza
e69f3af339
Merge pull request #16922 from lfzawacki/v2.6.x-release-moderator-layout
feature(layout): Moderators can now setPushLayout
2023-03-07 08:30:05 -03:00
hiroshisuga
20325de995
typo 2023-03-07 13:29:00 +09:00
Lucas Fialho Zawacki
8f5460312a fix(layout): Propagate correct presenter layout when push is off and moderator sets it to true 2023-03-06 18:08:25 -03:00