Commit Graph

6111 Commits

Author SHA1 Message Date
Pedro Beschorner Marin
f6fae58ef1
Merge pull request #12522 from pedrobmarin/f-s-rme
feat(screenshare): reduce mirror effect
2021-06-14 14:38:46 -03:00
Pedro Beschorner Marin
068b82b1fa refactor(connection status): remove legacy monitor
Remove parts of a previous connection monitor.

To add some context (as far as my memory goes) to the multiple connection
monitor features the product has, `stats` (currently named `connection status`)
was introduced at the Flash client back in ~2016. @fcecagno and I did it
as a BigBlueButton's Summit activity. Our work was squashed into a single
commit in 92554f8b3e :).

I'm not sure about the whole story behind `network information` (the late
connection monitor added to the HTML5 client) but I assume it should work
as a collector for a bunch of different connectivity monitors. I remember
when it was introduced but I don't know why it wasn't adopted. My best guess
would be because of some performance issues the `user list` had back then.

To follow on why `connection status` replaced `network information` at the
HTML5 client, when I did the `multiple webcams` feature I had to refactor
a big chunk of the `video provider` (#8374). Something that wasn't really
helping there was the adaptation of `stats` that was made to show local
feedback for each webcam connection. Although this feature wasn't being
used anymore, `network information` did rely on that to build up data. With
this monitor gone I assumed it was my responsibility to provide an alternative
so I promoted Mconf's port of the Flash `stats` monitor to BigBlueButton's
HTML5 client (#8579).

Well, that's my perspective on how things went for those features. If
anyone would like to correct me on something or add something else on
that history I would appreciate to know.
2021-06-13 14:02:46 -03:00
Anton Georgiev
78385ab3ea
Merge pull request #12569 from pedrobmarin/f-v-ds
feat(video): data savings
2021-06-12 16:59:38 -04:00
Arthur
78047eb68e feat(video): data savings
Enable video sharing when data savings is activated.
2021-06-12 14:16:32 -03:00
Max Franke
8b274476b1 feat(video): indicate who is sharing webcam
Add the `camera` icon in the user list for whoever is sharing,
in order to improve the understanding of who is sharing the webcam.
It is possible to enable/disable this indication in the settings.yml
2021-06-12 13:40:47 -03:00
Anton Georgiev
1369cb2269
Merge pull request #12505 from gustavotrott/breakoutroom-inscrease-time
Add 'Extend duration' option for breakout rooms
2021-06-11 16:33:15 -04:00
Anton Georgiev
2903c5e3cd
Merge pull request #12452 from ramonlsouza/chat-alerts-refactor
refactor: chat alerts
2021-06-09 08:54:56 -04:00
Ramon Souza
97aa7278a5 add option to emphasize moderator messages in public chat 2021-06-08 08:56:59 -03:00
Gustavo Trott
5b579d3a16 Avoid extend breakout rooms time exceed parent meeting remaining time 2021-06-07 14:19:20 -03:00
Ramon Souza
0598394329 fix updated notification bug 2021-06-07 13:53:35 -03:00
Ramon Souza
5b8f783e87 fix push alert onClick (open chat) 2021-06-07 11:18:57 -03:00
Max Franke
f2c95c61e3 feat(screenshare): reduce mirror effect
Add the shrink/expand button in the screenshare layout to reduce the mirror/tunnel
effect, when the presenter is sharing the same screen as the application is.
2021-06-07 09:11:32 -03:00
Arthur B. Grossi
bf62857ca7 fix(video): talking indicator
Shows video talking indicator even if the video isn't ready
2021-06-06 15:24:39 -03:00
Anton Georgiev
2f2b75097d
Merge pull request #12504 from pedrobmarin/f-ev-bei
feat(external videos): back end improvements
2021-06-04 15:57:19 -04:00
Ramon Souza
3030fbc206 Merge remote-tracking branch 'upstream/develop' into chat-alerts-refactor 2021-06-04 08:28:47 -03:00
Anton Georgiev
776d979e42
Merge pull request #12486 from ramonlsouza/actions-bar-new-lm
actions bar in new layout manager
2021-06-02 16:47:12 -04:00
Gustavo Trott
02ef1186be Avoid set negative values in Extend time for breakout rooms 2021-06-02 17:36:43 -03:00
Gustavo Trott
2551f71d7c
code fix: use 0 instead of string
Co-authored-by: Anton Georgiev <antobinary@users.noreply.github.com>
2021-06-02 16:16:35 -03:00
Anton Georgiev
e01bdf69c5 Merge branch 'v2.3.x-release' of github.com:bigbluebutton/bigbluebutton into june2-merge-into-develop 2021-06-02 18:45:31 +00:00
Gustavo Trott
fd2ef393ed Code fixes in Breakoutroom extend time parts 2021-06-02 15:38:26 -03:00
Gustavo Trott
a312557461 Adds extend breakout room time functionality 2021-06-02 15:29:40 -03:00
Pedro Beschorner Marin
d4888f585c refactor(external videos): state as integer
A media state may have more than 2 states. Moving this property back to
integer so it can be extended.
2021-06-02 15:07:03 -03:00
Pedro Beschorner Marin
6c84a3295b refactor(external videos): frontend permissions
Revoked extra frontend permission checks and removed dependency from
external video stop Meteor's system call.
2021-06-02 13:03:04 -03:00
Max Franke
7f926edfcc refactor(external videos): add own collection
Refactor the external videos collection, moving the logic and functionalities
outside of /imports/api/meetings to a new location in /external-videos/server/modifiers
in order to decrease the coupling between the functionalities, favoring
the maintenance.
2021-06-02 12:50:40 -03:00
Anton Georgiev
9395f50b99
Merge pull request #12474 from Tainan404/refactor-dropdown
refactor: Decrease amount of imports in dropdown
2021-06-01 09:32:14 -04:00
Ramon Souza
f526ab88fb actions bar in new layout manager 2021-05-31 17:28:57 -03:00
Ramon Souza
a4849f109c fix navbar z-index - new LM 2021-05-31 15:37:14 -03:00
Tainan Felipe
baf7afc883 Decrease amount of imports in dropdown 2021-05-31 15:28:27 -03:00
Anton Georgiev
ff24c5ae0d
Merge pull request #12466 from pedrobmarin/f-g-ns
feat(guests): notification settings
2021-05-31 10:48:15 -04:00
Ramon Souza
fdb07b8c37 use same z-index for all new layouts 2021-05-31 10:44:55 -03:00
Pedro Beschorner Marin
21a7324f70 feat(guests): notification settings
Avoid showing the guest's notification toggles at client's settings if the guest
policy isn't `ASK_MODERATOR`.
2021-05-30 12:09:33 -03:00
germanocaumo
be8d7405a0 fix: missing line break of poll chat export 2021-05-29 00:56:25 +00:00
germanocaumo
5c7fa6ece5 fix: export poll chat message
Include the new poll text in the chat export function.
Refactor some chat type constants.
Also fixes empty lines in the export chat file.
2021-05-29 00:28:47 +00:00
Ramon Souza
247601ad3d fix captions button crash 2021-05-28 17:16:35 -03:00
Anton Georgiev
409f10bd03
Merge pull request #12460 from ramonlsouza/fix-poll-panel-new-lm
fix: poll panel styles - new LM
2021-05-28 15:06:17 -04:00
Ramon Souza
7b2fd3b38e fix poll panel in new layout manager 2021-05-28 15:55:12 -03:00
Ramon Souza
8cfc4aa5c4 fix panels height with focus on video - LM 2021-05-28 15:20:29 -03:00
Ramon Souza
e0b3de1d3c add modals to new layout manager 2021-05-28 10:30:35 -03:00
Ramon Souza
29ed0c658b fix open chat alert 2021-05-27 16:19:16 -03:00
Pedro Beschorner Marin
10e29f3832
Merge pull request #12451 from germanocaumo/poll-chat-translation
fix: translate poll answer key for default polls in chat message
2021-05-27 15:21:57 -03:00
germanocaumo
4d62f8a971 fix: translate poll answer key for default polls 2021-05-27 18:16:11 +00:00
Ramon Souza
3c41c6fd83 lint + cleanup 2021-05-27 15:12:49 -03:00
Ramon Souza
94436d2630 chat alerts refactor 2021-05-27 14:46:27 -03:00
germanocaumo
c213b88451 refactor(poll): improve poll types code
this also fixes certain poll type detection for other languages than english,
so that the correct poll type is sent in the events (they were being detected as custom)
2021-05-26 17:52:55 +00:00
Pedro Beschorner Marin
b3c698a2a9
Merge pull request #12422 from germanocaumo/poll-chat-refactor
refactor: redo how poll result chat message is done
2021-05-26 14:49:19 -03:00
Anton Georgiev
a82505dee1
Merge pull request #12440 from ramonlsouza/unused-remove
refactor: remove unused import and variables
2021-05-26 09:16:08 -04:00
Ramon Souza
1cb880bb30 fix extract poll question crash 2021-05-25 15:48:53 -03:00
Ramon Souza
fe804ae657 remove unused imports in app component 2021-05-25 13:15:09 -03:00
Ramon Souza
d515f90b2d remove unused import and variables in layout manager 2021-05-25 13:11:27 -03:00
Mohamed Amine Ben Salah
2a9fdebd61
Mobile/Tablet devices automated tests for mobile/tablet on ios/android devices (#12173)
* adds unability to see screenshare button on mobile devices test specs

* simplify code in testMobileDevice()

* userlist and chat panels should not appear at page load in mobile devices

* lint

* updates outdated audio specs due to leaveAudio changes

* correct clicks on disconnectAudio elements

* whiteboard not visible on userlistPanel or on chatPanel

* reworks mobile devices/usersagents

* fixes screenshare mobile/tablet specs

* adds whiteboardNotAppearOnMobile spec

* adds Chat Panel specification to Mobile-Tablet specs

* simplify getArgs() functions for all devices
2021-05-25 12:05:11 -04:00