Commit Graph

5966 Commits

Author SHA1 Message Date
Anton Georgiev
b699790251
Merge pull request #11773 from PhMemmel/reflect-hand-raised-state-in-button-style
Hand raise button now reflects hand raised state
2021-04-06 13:45:17 -04:00
Ramon Souza
3efcfcd0fd fix action button over userlist and dropdown 2021-04-06 14:15:18 -03:00
Anton Georgiev
d941e208a7
Merge pull request #11904 from mariogasparoni/fix-11870
fix: audio device selector problem when using RTL locales
2021-04-06 10:17:37 -04:00
Mario Jr
68628855a3 fix: audio device selector problem when using RTL locales
Closes #11870
2021-04-06 10:56:01 -03:00
Anton Georgiev
42e3477003
Merge pull request #11826 from daminebenq/add-connection-status-test-spec
Add connection status (++ webcams, screenshare) test specs
2021-04-06 09:33:34 -04:00
KDSBrowne
ff7c862f00 fix keyboard navigation of users list 2021-04-06 01:00:41 +00:00
Maxim Khlobystov
11fe501214 Avoid going over the maximum allowed number of poll responses 2021-04-05 19:41:26 +00:00
Ramon Souza
3d6314012f localized quick poll answers 2021-04-05 14:50:50 -03:00
Anton Georgiev
9dbb298a7d
Merge pull request #11890 from Tainan404/issue-11795
Fix unread notes being not shown in navbar
2021-04-05 13:19:27 -04:00
Anton Georgiev
ad460a7d7a
Merge pull request #11824 from Tainan404/fix-unread-message
Fix unread message indicator remaining visible
2021-04-05 12:32:11 -04:00
Pedro Beschorner Marin
99690b55ec Extra connection's status sorting
Push offline users to the bottom of the list.
2021-04-05 13:19:24 -03:00
Pedro Beschorner Marin
082cdba78d Add offline property to user's own status 2021-04-05 13:18:45 -03:00
Anton Georgiev
9ec5408c9e
Merge pull request #11847 from ramonlsouza/offline-users-connection
Re-include offline users to the connection modal's users list
2021-04-05 12:10:47 -04:00
Anton Georgiev
6b9eee92e5
Merge pull request #11855 from hiroshisuga/patch-31
Minimum width of confirm button
2021-04-05 11:56:54 -04:00
Mohamed Amine Ben Salah
a69307b06e Merge remote-tracking branch 'upstream/develop' into add-connection-status-test-spec 2021-04-05 11:57:57 -03:00
Ramon Souza
00c873648e fix settings modal z-index 2021-04-05 09:40:59 -03:00
Mario Jr
e69421e671 fix: Do not show unsupported browser warning for microsoft edge
This was being shown in both audio in video modal.
Related to #11865.
2021-04-02 15:12:40 -03:00
Mario Jr
9411110742 fix: User can't join using microsoft edge
When browser's name string has whitespaces, we must treat it before adding to the
body class. For example Edge uses 'microsoft edge' string
This class string must match names used in css.

Tested in firefox, chrome and safari and it's corresponding mobile versions,
this is working for all.

Fixes #11865
2021-04-02 14:25:00 -03:00
hiroshisuga
c6cca4fe15
minimum width of button 2021-04-03 01:14:26 +09:00
hiroshisuga
eb39720130
Portuguese -> English 2021-04-02 11:26:46 +09:00
hiroshisuga
9a6d76e6e3
no width for confirm button 2021-04-02 11:06:16 +09:00
Mohamed Amine Ben Salah
040fed5ca7 add mobile user sub-username tag check 2021-04-01 21:54:55 -03:00
Mario Jr
951fc0ade8 fix: MEDIA_ERROR when joining room using Firefox
Firefox doesn't create a  device called 'default' and we were trying
to set this when user is joining the room. We don't do this anymore, letting
devices to be changed when there's some user request.

Moved outputDeviceId inputDeviceId information to be managed in bridge
(just like we do with inputDeviceId), we don't store this duplicated
information in audio container anymore.

Fixed the eslint warning in "playAlertSound(url) { ..."

We are safe to let users try to change input/output devices because the
device list is retrieved from enumerateDevices.
2021-04-01 15:53:43 -03:00
Ramon Souza
3be14632de adding meetingId to usersPersistentData 2021-04-01 15:53:03 -03:00
Ramon Souza
c5b229b4eb adding offline css class 2021-04-01 15:46:28 -03:00
Anton Georgiev
ff45cccd66 Merge branch 'v2.2.x-release' of github.com:bigbluebutton/bigbluebutton into apr1-merge 2021-04-01 18:11:13 +00:00
Ramon Souza
9e35bb09be reinclude offline users do connection modal 2021-04-01 15:10:15 -03:00
Anton Georgiev
ade1401cfa
Merge pull request #11845 from ramonlsouza/mobile-dropdown-fix
Fix mobile video dropdown
2021-04-01 11:21:18 -04:00
Tainan Felipe
5641b46aa3 Fix unread notes being not shown in navbar 2021-04-01 11:58:58 -03:00
Ramon Souza
369aa50836 fix mobile video dropdown 2021-04-01 11:28:20 -03:00
Ramon Souza
78c7abde7d actionsbar different height on mobile 2021-04-01 10:57:54 -03:00
Mohamed Amine Ben Salah
2fbbd94ddd add bad user connection reporting test spec 2021-04-01 10:55:27 -03:00
Anton Georgiev
8adbbe8288
Merge pull request #11841 from ramonlsouza/device-detect
Change browser detection library to bowser
2021-04-01 09:52:16 -04:00
Anton Georgiev
3a19a7000d
Merge pull request #11831 from mariogasparoni/improvements-in-muted-banner
Improvements in muted banner
2021-04-01 09:30:53 -04:00
Ramon Souza
05a0d5afbf move browser info to helper + remove unused libs 2021-04-01 08:14:24 -03:00
Philipp Memmel
48571734c8 fix localization of heading in presentation manager 2021-04-01 11:18:32 +02:00
Mario Jr
37e6755008 Fix muted banner being created for listen-only fallback stream
When listen only fallbacks from Kurento to FreeSWITCH, we must guarantee
the muted alert won't be created, speciallly because listen-only's fallback
uses a flow similar to microphone's. Client currently crashes when this
happens: this commit fixes this peoblem.
2021-03-31 16:25:07 -03:00
Mario Jr
4ad41bc8c5 Improvements in muted banner
We now stop the MediaStream (cloned/dummy input stream) when this is not
needed anymore.
We don't create/clone a new MediaStream when it already exists.
Fixed eslint warning in muted-alert/component.jsx
2021-03-31 16:25:04 -03:00
Ramon Souza
9218262e0a all device info moved to helper 2021-03-31 14:13:36 -03:00
Mohamed Amine Ben Salah
c57c45399c Adds connection status (++ webcams, screenshare) test specs 2021-03-31 10:10:57 -03:00
Philipp Memmel
32d3c39acc fixes option to allow mods to unmute users 2021-03-31 15:06:54 +02:00
Tainan Felipe
9def3f3785 Remove debug code 2021-03-31 08:14:03 -03:00
Anton Georgiev
6695f7a119
Merge pull request #11813 from mariogasparoni/merge-update-pr-10129
Update and some improvements on PR #10129 - dynamic change audio device
2021-03-30 13:50:30 -04:00
Anton Georgiev
d0b9a780ef
Merge pull request #11811 from MaximKhlobystov/poll-user-response-button-style
Different colors for the selected User Response poll button
2021-03-30 13:17:36 -04:00
Anton Georgiev
85a84f7cbf
Revert "Change browser detection library from browser-detect to bowser" 2021-03-30 13:16:10 -04:00
Maxim Khlobystov
7fa1dc3128 Changge the style of selected User Response poll button 2021-03-30 16:52:14 +00:00
Anton Georgiev
027658ac5c
Merge pull request #11806 from ramonlsouza/mobile-detect
Change browser detection library from browser-detect to bowser
2021-03-30 12:28:13 -04:00
Anton Georgiev
87b770fee7
Merge pull request #11807 from jfsiebel/handle-reason-code
Rework banned users
2021-03-30 11:21:56 -04:00
Maxim Khlobystov
9d4bd0e199 Syncing the number of poll options with the drag and drop input 2021-03-30 14:33:57 +00:00
Joao Siebel
c1503a2931 Remove banned users structure and handle reasonCode in validateAuthToken 2021-03-30 10:09:25 -03:00
Ramon Souza
3fa193005b change browser detection lib to bowser 2021-03-30 09:53:47 -03:00
Anton Georgiev
6e6563c202
Merge pull request #11792 from ramonlsouza/mobile-video-dropdown
Mobile video dropdown size
2021-03-30 08:38:14 -04:00
Mohamed Amine Ben Salah
cd985a02c2
Add additional user whiteboard access test spec (#11799)
* WIP adding whiteboard special user access test spec

* Adds additional user whiteboard access test spec to whiteboard.obj.js
2021-03-30 06:49:07 -04:00
Mario Jr
60378e8c63 Merge branch 'develop' into merge-update-pr-10129 2021-03-29 19:07:27 -03:00
Mario Jr
8b52265766 Do not allow dynamic audio device change for mobile users
Setting this as default to prevent bad UX: device selector is currently small
for mobile devices

This could be added as a config in future
2021-03-29 18:55:23 -03:00
Mario Jr
be84fc91ee Add option to enable/disable dynamic audio device selection
By default this is set to true, allowing users to dynamic change audio devices
Fixed a few linter warnings
2021-03-29 18:55:20 -03:00
Mario Jr
cddca95ad1 Fixes and improvements on pr #10129 - dynamic change audio device
Allow listenonly users to change output devices
Fixed dynamic audio device change for firefox
Fixed shortcuts for audio join/leave
Show (with a bold font) the current selected device
[performance] Prevent calling mediaDevices.enumerateDevices every time we render
the selector. This adds a delay (~200ms, on my chrome setup) to render this component
[performance] Do not call enumerateDevices to search for new devices, instead we listen on mediaDevices.deviceChange event
Small refactoring and fixed a few errors that were being throw in browser's console
Fixed device selection when this is done in audio-settings modal
Fallback to default device when current device is removed
Truncate device name length
Renamed "Input","Output" labels to "Microphone","Speakers", respectively
Update eslint rule for accessKey
2021-03-29 18:55:17 -03:00
Mario Jr
cec88c996d Merge remote-tracking branch 'tainan/issue-9723' into merge-update-pr-10129 2021-03-29 18:52:12 -03:00
Pedro Beschorner Marin
1aa7685dcc Refactor Etherpad API calls
Isolate most Pad related functions and secure shared notes and closed
captions creation to only when there is a reachable Etherpad server
configured.
2021-03-29 18:35:33 -03:00
Anton Georgiev
70d283eb08
Merge pull request #11783 from KDSBrowne/bbb-11733
Fix actions bar buttons overlapped by right side
2021-03-29 17:21:01 -04:00
Tainan Felipe
4db0fb64c6 change in viewport logic 2021-03-29 17:25:04 -03:00
Anton Georgiev
6040913658
Merge pull request #11784 from KDSBrowne/bbb-acc-6
Remove invalid aria values and roles without proper structure
2021-03-29 13:42:58 -04:00
Ramon Souza
40632c2211 adding comments on magic numbers 2021-03-29 14:09:26 -03:00
Ramon Souza
d97ffa954c fix mobile video dropdown size 2021-03-29 13:46:50 -03:00
Anton Georgiev
b836e5f7ca
Merge pull request #11758 from pedrobmarin/connection-status-button
Move connection-status to nav-bar
2021-03-29 11:44:49 -04:00
KDSBrowne
ff7dc18669 remove invalid aria values and roles without proper children 2021-03-29 02:12:58 +00:00
KDSBrowne
f26cee6d91 fix raise hand button overlapping others 2021-03-27 17:40:38 +00:00
Philipp Memmel
f05566d946 hand raise button now reflects hand raised state 2021-03-27 14:26:59 +01:00
Anton Georgiev
7dfea96fbc
Merge pull request #11766 from ramonlsouza/webcam-reconnect-breakout
Auto-reconnect webcam after leaving breakout room
2021-03-26 16:48:21 -04:00
Ramon Souza
4a761f923f adding comment about canConnect 2021-03-26 17:43:19 -03:00
Anton Georgiev
7d9abe77a0
Merge pull request #11127 from FarzadKarkhani/patch-2
Fix for poll result in RTL languages
2021-03-26 16:35:33 -04:00
Ramon Souza
5fe5705ac0 auto-reconnect webcam after leaving breakout room 2021-03-26 16:54:58 -03:00
Pedro Beschorner Marin
280b32d21d Move connection-status to nav-bar
- Removed the connection-status history from the user list's gear
icon and now is opened by the connection-status button. Moderators will
render the same modal as before and viewers will only have access to their
own data.

 - Added data-savings shortcut at the connection-status modal.

 - Added websocket round-trip time.
2021-03-26 10:12:09 -03:00
Anton Georgiev
ded205e196
Merge pull request #11722 from Tainan404/issue-11081
Add collection user persistent data
2021-03-26 08:56:41 -04:00
Anton Georgiev
f1fe98b403
Merge pull request #11734 from Tainan404/remove-props-from-message
Remove `sender.name` and `color` from message payload
2021-03-26 08:40:02 -04:00
Anton Georgiev
3d35f3cd05
Revert "Remove black border on video resize" 2021-03-25 15:33:33 -04:00
Ramon Souza
2ac8d08b77 remove black border on video resize 2021-03-25 14:02:49 -03:00
Anton Georgiev
bf7365c1e4
Merge pull request #11749 from Tainan404/fix-posJoinsMessage-issue
Fix Cannot read property 'posJoinMessages' of undefined
2021-03-25 10:48:56 -04:00
Anton Georgiev
f197bde121
Merge pull request #11747 from ramonlsouza/annotations-delay
Retry sending annotations if user information is not available
2021-03-25 10:15:22 -04:00
Tainan Felipe
8a36d8cb42 Fix Cannot read property 'posJoinMessages' of undefined 2021-03-25 10:41:13 -03:00
Ramon Souza
84f5ef9133 check+retry sending annotations if userid is not available 2021-03-25 09:47:57 -03:00
Anton Georgiev
43cfa5a629
Merge pull request #11735 from KDSBrowne/bbb-acc-1
Remove gradient from content styling
2021-03-25 02:14:32 -04:00
Anton Georgiev
5adab18af2
Merge pull request #11736 from KDSBrowne/bbb-acc-2
Fix duplicate element Id in UserParticipants
2021-03-25 02:13:18 -04:00
Anton Georgiev
2746a1c57a
Merge pull request #11737 from KDSBrowne/bbb-acc-3
Remove complementary role from user content
2021-03-25 02:12:24 -04:00
Anton Georgiev
5c5bcdf1e8
Merge pull request #11738 from KDSBrowne/bbb-acc-4
Reduce Audio Modal Heading To H2
2021-03-25 02:10:51 -04:00
Maxim Khlobystov
ea5d5a879c Avoid displaying drag and drop input field for typed response polls 2021-03-25 01:37:25 +00:00
KDSBrowne
310b7bc988 reduce audio modal heading to h2 2021-03-24 20:35:09 +00:00
KDSBrowne
9286d1f90d remove complementary role 2021-03-24 20:26:20 +00:00
Tainan Felipe
fa3ab71d40 Change export chat function 2021-03-24 17:20:33 -03:00
KDSBrowne
8fa8c1a463 update element id 2021-03-24 20:20:01 +00:00
Tainan Felipe
b5e52012ec Remove sender.name and color from message payload 2021-03-24 16:57:09 -03:00
KDSBrowne
0e00e9791f remove gradient from styling 2021-03-24 18:48:26 +00:00
prlanzarin
1e199097b4 screenshare: check if the user is still presenter after gDM resolves
If the presenter gets changed while the user kept the getDisplayMedia browser picker open, accepting the getDisplayMedia prompt might get the previous presenter´s client-side state inconsistent as if they were sharing. The screen sharing is a no-op though

This adds a check after gDM resolves to see whether the user is still the presenter; if they aren`t, just clean up the gDM stream and make it a full no op
2021-03-24 18:41:14 +00:00
Ramon Souza
6a2496fcb3 Merge remote-tracking branch 'upstream/develop' into improve-poll-function 2021-03-24 14:22:43 -03:00
Anton Georgiev
8c6e7b8849
Merge pull request #11724 from ramonlsouza/userlist-rtl
Fix userlist RTL/LTR for userlist when language is changed
2021-03-24 11:50:10 -04:00
Anton Georgiev
7398e005e8
Merge pull request #11725 from Tainan404/fix-chat-reconnection
Fix reactive issue with reconnection
2021-03-24 10:25:51 -04:00
Ramon Souza
4cca83b202 fix userlist rtl/ltr when language is changed 2021-03-23 17:30:51 -03:00
Tainan Felipe
36c1abc890 Fix reactive issue with reconnection 2021-03-23 17:30:38 -03:00
Mario Jr
af4f9dbf26 Merge branch 'v2.2.x-release' into merge-2.2-develop 2021-03-23 17:10:28 -03:00
Mario Jr
b830e794f7 Do not create mutedalert component when user is disconnected
If created, mutedalert will crash client when trying to access inputstream
which is not yet ready.
Fixes #11433
2021-03-23 14:45:38 -03:00
Anton Georgiev
fe58a11249
Merge pull request #11718 from MaximKhlobystov/typed-poll-case-insensitive
Case insensitive typed poll responses grouping
2021-03-23 10:58:15 -04:00
Anton Georgiev
428b048b2e
Merge pull request #11713 from ramonlsouza/guest-user-messages
Retrieve guest user pre-join messages only when userId is available
2021-03-23 09:17:52 -04:00
Maxim Khlobystov
5adb3429eb Make typed poll responses grouping case insensitive 2021-03-23 06:30:37 +00:00
Tainan Felipe
443df78c6e add logs to observer and re-implement role render logic 2021-03-22 18:07:46 -03:00
Tainan Felipe
ba91dcb17c Implements user persistent data to user context and redo users status logic on chat item 2021-03-22 17:44:53 -03:00
Anton Georgiev
70ef985fde
Merge pull request #11703 from KDSBrowne/bbb-move-raiseHand
Move Raise Hand Functionality To Actions Bar Button
2021-03-22 14:24:32 -04:00
KDSBrowne
d89e6a8c3a move debounce to service 2021-03-22 18:02:31 +00:00
Ramon Souza
192f202f9c only retrieve guest user pre-join messages after userId is available 2021-03-22 14:00:03 -03:00
KDSBrowne
8e9718eb0b add debounce to raise hand toggle 2021-03-22 16:08:53 +00:00
KDSBrowne
6f5b9ceff5 adjust actions bar buttons position on mobile 2021-03-22 15:50:35 +00:00
Anton Georgiev
3e526f4e14
Merge pull request #11711 from ramonlsouza/presenter-menu-width
Increasing presenter menu width
2021-03-22 10:52:06 -04:00
Anton Georgiev
800c10eb1c
Merge pull request #11691 from Tainan404/issue-11618
Fix messages being not cleared
2021-03-22 10:48:08 -04:00
Ramon Souza
34dc5ca79f increasing presentation menu width 2021-03-22 11:42:13 -03:00
Ramon Souza
383efc31f8 increasing userlist width 2021-03-22 10:54:23 -03:00
Tainan Felipe
2271d4fe61 Fix messages being not cleared 2021-03-22 08:34:12 -03:00
KDSBrowne
4473fa084b add lower hand label 2021-03-21 23:56:00 +00:00
KDSBrowne
132dfb02d9 add raise hand shortcut and help entry 2021-03-21 23:47:15 +00:00
KDSBrowne
676abd1f85 move raise hand functionality to actions bar 2021-03-21 17:06:16 +00:00
Anton Georgiev
5641252e56
Merge pull request #11700 from ramonlsouza/select-random-user-flag
Add selectRandomUser settings
2021-03-19 17:40:45 -04:00
Tainan Felipe
fa550c707b Subscribe to user pesistent data only after the other subscriptions be ready 2021-03-19 17:33:32 -03:00
Ramon Souza
3715266883 add selectRandomUser flag 2021-03-19 15:54:54 -03:00
Anton Georgiev
cbb7a69cf2
Merge pull request #11698 from ramonlsouza/camera-remove-crash
Fix client crash when user is sharing video
2021-03-19 14:05:30 -04:00
Ramon Souza
050844c275 fix client crash when user is sharing video 2021-03-19 14:26:06 -03:00
Jonathan S
fc367b7641 Mouse input isn't affected by palm rejection. 2021-03-19 12:35:30 +00:00
Jonathan S
87a9386f93 Delete text pointer listener. Textfields aren't affected by palm rejection. 2021-03-19 12:35:30 +00:00
Jonathan S
b5a014eea7 Add icon to new button. 2021-03-19 12:35:30 +00:00
Jonathan Schilling
7313916940 Add browser sniffing.
If a browser version can not handle the pointer events, it becomes detected and that browser uses the mouse event etc.
For these browser is no palm rejection provided. All other browser use the pointer events.
2021-03-19 12:35:29 +00:00
Jonathan Schilling
fc1b09b5ca Palm rejection menu button only appears if the browser supports pointer events. 2021-03-19 12:35:29 +00:00
Jonathan Schilling
a9e971cd60 Add palm rejection mode to pointer event handler. 2021-03-19 12:35:29 +00:00
Jonathan Schilling
a19451a2c4 Create pointer event handler for pencil, shape and text. 2021-03-19 12:35:29 +00:00
Jonathan Schilling
52637c59e0 Prepare whiteboard toolbar for palm rejection:
* add button to the toolbar to switch palm rejection mode
  * add a message for that new button to the locales/en
  * add boolean palmRejection to state of the toolbar
  * save that boolean also to the session storage, so it is ready to use it in the input handler
2021-03-19 12:35:28 +00:00
Ramon Souza
c85abbbb75 fix userlist height if banners are enabled 2021-03-19 09:00:39 -03:00
Pedro Beschorner Marin
63a637940b
Merge pull request #11689 from pedrobmarin/fix-solo-presenter-multi-user-whiteboard
Handle multi-user whiteboard for solo presenter
2021-03-18 21:06:15 -03:00
Pedro Beschorner Marin
92d3300d81 Handle multi-user whiteboard for solo presenter
Adjusts the user interface to keep coherence when activating the multi-user
whiteboard while there is only the presenter in the meeting.
2021-03-18 14:53:11 -03:00
Ramon Souza
1df849a218 show poll question in polling panel 2021-03-18 14:16:32 -03:00
Ramon Souza
70ab1f099a show poll question in chat 2021-03-18 13:13:57 -03:00
Anton Georgiev
4e762c6ae9
Merge pull request #11574 from daminebenq/update-and-add-polling-specs
Update and add Polling specs
2021-03-17 18:40:12 -04:00
Anton Georgiev
5284a39323
Merge pull request #11671 from ramonlsouza/poll-chat-escape
Escaping user typed poll results
2021-03-17 16:53:19 -04:00
Anton Georgiev
51c7ea4ff3
Merge pull request #11678 from ramonlsouza/active-mic-webcam-icon
Show unmuted microphone in video
2021-03-17 15:34:00 -04:00
Ramon Souza
1b8d6a0fab show unmuted microphone in video 2021-03-17 16:26:31 -03:00
Anton Georgiev
483d37fc02
Merge pull request #11676 from Tainan404/issue-11528
Fix for posJoinMessage as undefined
2021-03-17 15:10:36 -04:00
Ramon Souza
5c5834ddc6 fix poll results counter 2021-03-17 15:20:00 -03:00
Tainan Felipe
e40a1cfcfc Fix posJoinMessage as undefined 2021-03-17 14:49:44 -03:00
Ramon Souza
8a2ddd5b9f escape all <br/> 2021-03-17 11:44:09 -03:00
Anton Georgiev
6f3898f933
Merge pull request #11664 from prlanzarin/u23-imago
video-provider: add dynamic video page sizes based on number of users
2021-03-17 09:48:50 -04:00
Ramon Souza
e450173bd0 escaping typed poll response before displaying results in chat 2021-03-17 08:26:12 -03:00
Pedro Beschorner Marin
d90ba5e286 Merge branch '2.3-per-user-wb' into develop 2021-03-16 20:28:39 -03:00
Pedro Beschorner Marin
381c5cb15c Isolated whiteboard access
Modified the previous implementation of the whiteboard individual access to remove
multiple Collections dependency on this feature. Multi-user whiteboard is now an
array instead of a boolean value and most of the access control can be synchronized
and handled by akka-apps.
2021-03-16 19:55:25 -03:00
prlanzarin
e8a8deb006 video, user-list: remove obsolete connectionStatus from getUserCount 2021-03-16 20:34:25 +00:00
prlanzarin
0a0a4b4915 video-provider: add dynamic video page sizes based on number of users
New config called paginationThreshold defines classes of page sizes that depend on the number of participants of a meeting

The rationale is pretty much the same as the cameraQualityThresholds, but the thresholds are users here and the ceilings are the page sizes
2021-03-16 20:15:13 +00:00
Ramon Souza
adc48047a1 prevent sending typed poll empty response 2021-03-16 14:10:10 -03:00
hiroshisuga
cabddc6ddf
Change the color of color-picker icon even when the text tool is selected (#11642) 2021-03-15 14:19:52 -04:00
Mohamed Amine Ben Salah
c0834840a8 Merge remote-tracking branch 'upstream/develop' into update-and-add-polling-specs 2021-03-12 21:12:55 -03:00
Anton Georgiev
e673fb2cf4
Merge pull request #11630 from prlanzarin/u23-sculptor
listenonly,video-provider,screenshare: remove ICE gathering pre-flight check
2021-03-12 12:58:43 -05:00
Pedro Beschorner Marin
dbb19b79a4 Avoid guest policy change inside breakout rooms 2021-03-12 09:56:04 -03:00
Pedro Beschorner Marin
af64232e45 Change guest policy 2021-03-12 09:19:22 -03:00
Anton Georgiev
9f841bd64b
Merge pull request #11622 from prlanzarin/u23-ilgiardino
[screenshare] Rewrite SFU/Kurento screensharing bridge (+reconnections|audio sharing|QoL, was #11025)
2021-03-12 05:13:11 -05:00
prlanzarin
ab17b10c38 listenonly,video-provider,screenshare: remove ICE gathering pre-flight check 2021-03-12 02:51:45 +00:00
prlanzarin
35f519206b Revert additional indentation to actions-bar component
I must have messed this up in the 2.2 - 2.3 merge or with vim somehow, mea culpa
2021-03-12 01:47:05 +00:00
prlanzarin
ef4ad8820d screenshare: adapt shutdown on breakout room joins, only stop sharers
Adapted the breakout room screen sharing shutdown to use the new refactor calls

Also changed the behaviour a bit to only trigger the stop code for presenters/sharers, mimicking the camera behaviour and not leaving viewer with stuck screens
2021-03-12 01:31:46 +00:00
prlanzarin
775cbf4124 screenshare: move end alert sound to a reliable place 2021-03-12 00:44:38 +00:00
Anton Georgiev
a165d3a7e3
Merge pull request #11606 from prlanzarin/u22-sadl1
video-provider: add video pagination UI toggle (was #10970)
2021-03-11 16:05:33 -05:00
Mohamed Amine Ben Salah
5fe7a18db4 Merge remote-tracking branch 'upstream/develop' into update-and-add-polling-specs 2021-03-11 17:38:49 -03:00
Ramon Souza
17cfd8c9bd fix guest openPanel 2021-03-11 17:00:54 -03:00
Ramon Souza
55a2bc2d02 fix captions openPanel 2021-03-11 16:12:35 -03:00
prlanzarin
7eb91f9273 Merge branch 'u22-screenshare18102020' of https://github.com/prlanzarin/bigbluebutton-1 into u23-ilgiardino 2021-03-11 18:49:14 +00:00
Anton Georgiev
73979f1cba
Merge pull request #11621 from ramonlsouza/fix-captions
Fix locales url settings + captions locales order
2021-03-11 13:44:56 -05:00
Ramon Souza
150bedf16d fix locales url settings + captions locales order 2021-03-11 15:33:48 -03:00
Anton Georgiev
8a640877b2
Merge pull request #11611 from BrentBaccala/audio-prompt
don't prompt for "Microphone" if that's the only option presented to the user
2021-03-11 13:27:31 -05:00
Anton Georgiev
9cc78ca4a5
Merge pull request #11620 from ramonlsouza/issue-11578
Submit typed polling response by pressing enter
2021-03-11 13:01:22 -05:00
Anton Georgiev
6a96bbfb93
Merge pull request #11612 from prlanzarin/u23-planF
video-provider: add inbound/recvonly video reconnection (was #11233)
2021-03-11 13:00:14 -05:00
Ramon Souza
15fccf0ba1 submit typed polling response by pressing enter 2021-03-11 14:45:48 -03:00
Tainan Felipe
87ebdbd02a Merge remote-tracking branch 'upstream/develop' into fix-chat-issues 2021-03-11 10:07:16 -03:00
Tainan Felipe
1c21fcc4ff Fix loading on clear 2021-03-11 10:02:16 -03:00
prlanzarin
d00e8e0436 Merge remote-tracking branch 'origin/develop' into u22-sadl1 2021-03-11 12:31:10 +00:00
Mohamed Amine Ben Salah
36ba0c5bb6 Merge remote-tracking branch 'upstream/develop' into update-and-add-polling-specs 2021-03-11 09:16:55 -03:00
Ramón Souza
0105373cee
Applies changes needed to serve locale files as static content (#11234)
* moving locales folder to /public and applying changes needed to serve locales as static files

* better dev/prod check

* transifex pull script changes to match new locales directory + ignore locales with less than 100 lines

* fix local/prod locales path

* merge fallback messages

* applies new locale changes to legacy client

`bbb-html5.nginx` file content should also be changed to the following:

```
location /html5client/locales {
  alias /usr/share/meteor/bundle/programs/web.browser/app/locales;
}

location /html5client/compatibility {
  alias /usr/share/meteor/bundle/programs/web.browser/app/compatibility;
}

location /html5client/resources {
  alias /usr/share/meteor/bundle/programs/web.browser/app/resources;
}

location /html5client/svgs {
  alias /usr/share/meteor/bundle/programs/web.browser/app/svgs;
}

location /html5client/fonts {
  alias /usr/share/meteor/bundle/programs/web.browser/app/fonts;
}

location /html5client {
  # proxy_pass http://127.0.0.1:4100; # use for development
  proxy_pass http://poolhtml5servers; # use for production
  proxy_http_version 1.1;
  proxy_set_header Upgrade $http_upgrade;
  proxy_set_header Connection "Upgrade";
}
```
2021-03-11 06:42:41 -05:00
Brent Baccala
e5e3b5532b don't prompt for "Microphone" if that's the only option presented to the user 2021-03-10 16:44:41 -05:00
Anton Georgiev
c280769ebf
Merge pull request #11559 from MaximKhlobystov/dragndrop-poll-23
Editing poll options via drag and drop
2021-03-10 16:40:00 -05:00
Anton Georgiev
a630099cc6
Merge pull request #11595 from ramonlsouza/presentation-container-fix
Fixes presentation invisible box appearing if presentation is hidden
2021-03-10 16:37:53 -05:00
prlanzarin
f9f58cb91d video-provider: make sure the provider is unmounted if meteor disconnects
This is a workaround that shaves off some edge cases around wrongfully done camera reconnections and outbound cameras getting stuck in the UI even though they arent being shared anymore
2021-03-10 20:21:08 +00:00
prlanzarin
db15d1b280 video-provider: fix setReconnectionTimeout race condition that caused webcams to drop
Problem: setReconnectionTimeout was being called in the first candidate generation to set the negotiation/reconnection timeout up. That caused some browsers or specific scenarios (mainly envs without STUN) to establish the negotiation (playStart) before generating any useful out-of-band candidates (relay). That would cause the timeout to be set AFTER it is supposed to be cleared due to success (playStart), making the webcam drop after a while

So I moved the setReconnectionTimeout call to a safer spot: right after the first negotiation requisition goes out to bbb-webrtc-sfu
2021-03-10 20:09:55 +00:00
prlanzarin
6418d0f556 video-provider: more logging improvements, clean up playStart restart timers reset 2021-03-10 20:09:00 +00:00
prlanzarin
f85b5dfa5b video-provider: quick logging cleanup
Reduce logging volume and payload size, perf
2021-03-10 20:08:40 +00:00
prlanzarin
ee142501ab video-provider: fix inbound/recvonly video reconnection 2021-03-10 20:08:29 +00:00
Pedro Beschorner Marin
c120dc2859 Avoid dispatching fallback error toast message
There's some scenarios that video errors triggers multiple toast notifications
that don't have any mapped defined message feedback so they all drop to the default
permission error. This leaves the impression that something is broken at the toast
container.

Since those messages don't bring up much information about the problem we can avoid sending
them until we don't have a more informative one to notify the user.
2021-03-10 19:47:25 +00:00
prlanzarin
cf8b5e422f video-provider: add pagination settings toggle 2021-03-10 18:44:23 +00:00
Maxim Khlobystov
619c5ed176 Make the poll drag and drop feature optional 2021-03-10 18:23:25 +00:00
Anton Georgiev
bbec7efb57
Merge pull request #11593 from pedrobmarin/2.3-lobby-message
Add guest lobby messages
2021-03-10 11:35:35 -05:00
Ramon Souza
45421b1276 fix an error that might happen if PR 11529 is applied to an ongoing meeting 2021-03-10 09:16:31 -03:00
Anton Georgiev
65fd2d434a
Merge pull request #11584 from ramonlsouza/issue-9856
When a moderator ends a meeting, indicate to viewers who ended the meeting
2021-03-10 05:59:43 -05:00
Tainan Felipe
927e2167bc Re-implements chat sync and clear 2021-03-09 17:52:20 -03:00
Ramon Souza
4445d4e309 fix invisible box appearing if presentation is hidden 2021-03-09 16:43:51 -03:00
Pedro Beschorner Marin
0365018e92 Add guest lobby messages
Moderators are able to send a message to the meeting's guest lobby. This new
event reaches bbb-web and is sent to the guest user with her/his status response
while polling. All guest users that are waiting for acceptance will be able to
read this message.

enableGuestLobbyMessage is disabled by default.
2021-03-09 11:02:25 -03:00
Mohamed Amine Ben Salah
982ddc56a1 adds YNA and UR polling cases 2021-03-08 18:11:36 -03:00
Ramon Souza
826c420788 update meetingEndedBy with information coming from bbb core 2021-03-08 16:45:09 -03:00
Ramon Souza
0a09112f80 split end meeting message in two parts 2021-03-08 16:14:09 -03:00
Ramon Souza
78095f830d 'active users' message change on ending meeting 2021-03-08 15:11:31 -03:00
Mario Jr
1c7c1d5076 Change breakout-audio-transfer-status function signature
We now update breakout'a audio transfer status by using an object
2021-03-08 14:55:15 -03:00
Mario Jr
ff6cba8d53 Store information about user status during breakout room audio transfer
Currently this information is lost everytime breakout-room component is
unmounted, causing the panel to shows wrong information during next renders
Fixes #11333
2021-03-08 14:55:05 -03:00
Ramon Souza
c9ac737207 display name of the user who ended the meeting 2021-03-08 13:05:33 -03:00
Ramon Souza
2923ea1641 fix 'restore presentation' button when presentation is disabled 2021-03-08 09:33:25 -03:00
Mohamed Amine Ben Salah
620183d5d3 added True/False, A/B/C/D polling cases WIP 2021-03-07 20:53:58 -03:00
hiroshisuga
190bde3320
Fix slide size problem at fullscreen <-> window-mode transition #2 (#11540)
Replaces the PR #10604, which has been temporarily fixed a problem in 2.3a2, that is, the slide size gets crazy when turning on and off fullscreen mode. Since #10604 was just a workaround, I tried to fix it in a way making more sense.

### Closes Issue(s)

closes #10459 (already closed by #10604) and #10589

### Motivation

#10604 is fixing the problem by calling "slide change" event, although the slide has not been changed actually. I tried to fix the same problem by adding a "full screen change" event listener in the layout manager, which I think is more elegant.
2021-03-05 11:01:47 -05:00
Anton Georgiev
68cfcd0215
Merge pull request #11544 from pedrobmarin/guest-doorbell
Waiting users audio and push alerts
2021-03-05 09:13:29 -05:00
Anton Georgiev
01ca99208f
Merge pull request #11529 from ramonlsouza/issue-11071
Fix openPanel errors related to polling and shared notes
2021-03-05 09:01:45 -05:00
Ramon Souza
4d59f9d23e fix new found errors 2021-03-05 10:49:28 -03:00
Anton Georgiev
c9bbcebe59
Revert "Add reconnection and sync handler" 2021-03-05 03:53:36 -05:00
Anton Georgiev
e89faec1cd
Revert "Fix clear chat for single message" 2021-03-05 03:51:07 -05:00
Mario Jr
39780c6a50 Do not try to recover mute state when joining listenonly
Prevent toggleMute api call to be called for listenonly
This has no effect to the end user, but avoids unnecessary server calls
2021-03-05 00:23:20 -03:00
Mario Jr
c0625e2ee1 Cleanup joinedAudioOnly state when user disconnects or reconnect microphone
Fixes #11490
2021-03-05 00:06:19 -03:00
Mario Jr
e16566de9d Recover mute state for moderator when returning from breakout's audio transfer
Fixes #11489
2021-03-05 00:02:31 -03:00
Anton Georgiev
5953f21196
Merge pull request #11558 from antobinary/march4-merge
Merge 2.2.[32..35] into 'develop'
2021-03-04 17:09:22 -05:00
Maxim Khlobystov
e3ec0da0a9 Deleted unused code left from the 2.2 implementation of the drag and drop for poll options 2021-03-04 22:04:38 +00:00
Anton Georgiev
228bad03d5 Merge branch 'v2.2.x-release' of github.com:bigbluebutton/bigbluebutton into march4-merge 2021-03-04 21:25:47 +00:00
Anton Georgiev
d5a7846020
Merge pull request #11550 from KDSBrowne/bbb-11291x2
Add avatar back to chat poll result message
2021-03-04 15:05:58 -05:00
Anton Georgiev
7b58f0b269
Merge pull request #11556 from ramonlsouza/quick-poll-fix
Quick poll improvements
2021-03-04 15:01:10 -05:00
Maxim Khlobystov
e8229726f2 Make the drag-and-drop properly work with 2.3 polling 2021-03-04 19:43:43 +00:00
gersti07
3fae071001 Update styles.scss 2021-03-04 19:26:18 +00:00
gersti07
885a8f2598 improved button style 2021-03-04 19:25:53 +00:00
gersti07
09e8e7353d removed unused code 2021-03-04 19:25:22 +00:00
gersti07
dd68990c7b removed unused code from styles.scss 2021-03-04 19:24:47 +00:00
gersti07
6011eb524a refactor drag handling 2021-03-04 19:24:07 +00:00
gersti07
b36042babd implemented add polloptions via drag and drop
(merging with 2.3)
2021-03-04 19:20:17 +00:00
Ramon Souza
ce5f0c04f3 changes to match issue #8197 tests 2021-03-04 15:00:21 -03:00
Anton Georgiev
c7f6b819a5
Merge pull request #11553 from Tainan404/issue-11530
Fix clear chat for single message
2021-03-04 12:22:00 -05:00
Tainan Felipe
51c45e1595 Fix crashing after second clean 2021-03-04 14:16:26 -03:00
Ramon Souza
47a21dfd98 quick poll fix 2021-03-04 13:34:23 -03:00
Tainan Felipe
21045abf16 Merge remote-tracking branch 'upstream/develop' into issue-11438 2021-03-04 11:29:01 -03:00
Tainan Felipe
b983c8e1b4 Fix clear chat for single message 2021-03-04 10:20:18 -03:00
Tainan Felipe
53a7abe4c6 Fix clear chat timeout 2021-03-04 10:09:18 -03:00
KDSBrowne
2880613138 add avatar to chat poll result message 2021-03-04 04:22:19 +00:00
Pedro Beschorner Marin
e08af4b43e Include waiting users push alert in settings
Since we added audio alert notifications in settings controls there was an ampty
grid gap reserved for the push alerts.
2021-03-03 16:26:15 -03:00
Ramon Souza
0a1516c36e fix svg width error 2021-03-03 15:59:34 -03:00
Pedro Beschorner Marin
e0bbe6e189 Using the correct constant value 2021-03-03 15:48:17 -03:00
Vitor Vanacor
1b218d4730 Change guest waiting bell debounce to throttle
Debounce could make the behaviour of "not always ringing when a guest
enters" feel "buggy". Throttle makes it clearer that it happens to
prevent it from ringing too frequently.

Also move Throttle time from magic number to constant for
a meaningful variable name.
2021-03-03 15:26:50 -03:00
Vitor Vanacor
f2e40d3286 guestWaitingAudioAlert moved to settings 2021-03-03 15:24:54 -03:00
Vitor Vanacor
55092a9de6 Use doorbell sound as waiting guest notification 2021-03-03 15:03:24 -03:00
Vitor Vanacor
d9007d2ce6 Add sound notification for waiting guest
Both debounce or throttle could be used to prevent a spammer from
annoying the moderators.
With debounce, a spammer won't even be noticed by the mods, but
there won't be new notifications for legit guests during the spam.
With throttle, a spammer could still annoy the mods, we would only make
the interval between notifications bigger.
It is a tradeoff. An ideal solution would be preventing spamming from
the same user, but probably unnecessarily complex.
2021-03-03 15:03:00 -03:00
Anton Georgiev
6c238dd240
Merge pull request #11537 from antobinary/backport-11477
Update handleClick condition (fix text-area for FireFox)
2021-03-02 15:02:02 -05:00
KDSBrowne
ccf12c268e update handleClick condition (fix text-area for FireFox) 2021-03-02 14:55:51 -05:00
Anton Georgiev
eba2d0ab58
Merge pull request #11535 from pedrobmarin/etherpad-patch
Rework padIds and turn bbb-web pad aware
2021-03-02 14:48:34 -05:00
Anton Georgiev
17fa7ffea3
Merge pull request #11514 from daminebenq/add-tests-recording-to-video
Adds tests recording + updates some outdated tests + linting
2021-03-02 12:00:05 -05:00
Tainan Felipe
71e0ca9d92 Add sync and reconnection handler 2021-03-02 11:35:26 -03:00
Anton Georgiev
879c54981e
Merge pull request #11447 from antobinary/external-video-sync-lucas-amguirado73
External video events propagated through akka-apps
2021-03-02 08:53:09 -05:00
Ramon Souza
c1efb6e6b4 fix openPanel errors related to polling and shared notes 2021-03-02 09:36:44 -03:00
Mohamed Amine Ben Salah
8daa4443cb Merge remote-tracking branch 'upstream/develop' into add-tests-recording-to-video 2021-03-01 18:47:35 -03:00
Mohamed Amine Ben Salah
2c9d8e4380 updates and adds specifications for polling 2021-03-01 18:47:08 -03:00
Anton Georgiev
f6147d4425
Merge pull request #11526 from ramonlsouza/issue-11354
Fix chat textarea resizing bug
2021-03-01 13:43:23 -05:00
Anton Georgiev
b6ead0baa4
Merge pull request #11524 from ramonlsouza/issue-11461
Fix chat messages timestamp
2021-03-01 13:37:59 -05:00