Commit Graph

39557 Commits

Author SHA1 Message Date
prlanzarin
2084392ac7 fix: undefined accesses causes crashes in actions-bar breakout utils
Multiple undefined accesses in actions-bar's service, mainly related to
breakouts and ageneral Meetings info, cause crashes in production
environments - most likely in reconnection scenarios.

Guarantee that nested data is safely accessed.
2024-04-30 14:41:16 -03:00
prlanzarin
141c553b17 fix(audio): review device selection in mobile endpoints
Mobile users have no way to change I/O devices after joining audio.
The removal of the audio options chevron in mobile browsers was supposed
to be replaced by something else - in this case, by the dedicated
leave/join audio button. That didn't happen, leave/join audio button
retained the old behavior.

Review device selection in mobile endpoints via two UI/UX changes:
  - Restore the device selection chevron/icon in mobile endpoints
  - Override the leave/join button action in mobile endpoints so that it
    opens the device selection contextual menu, which also includes the
    "Leave audio" option. This retains the old behavior (leaving audio)
    while also providing an way for users to change devices mid-call in
    mobile browsers.
2024-04-30 14:29:53 -03:00
prlanzarin
9956af9aa1 fix(audio): improve help modal for listen only scenarios
The audio troubleshooting modal has very microphone-specific strings,
which might confuse users trying to join listen only.

Review the Help screen so that listen only scenarios are more generic.
As a bonus, review the unknownError locale with a more actionable text.
2024-04-30 13:59:08 -03:00
prlanzarin
f91402bc4a fix(audio): remove listen only retry routines
Listen only has a built-in retry routine on join failures that's
convoluted half-broken. It stems from the Kurento era where it could
fail randomly due to a myriad of reasons.
Production logs indicate that the retry is seldom used nowadays in
mediasoup-based environments. The presence of the retry also breaks
the error troubleshooting modal when actual failures happening, leaving
users in the dark about what's happening.

Remove the listen only retry code from AudioManager and bubble up any
join failure to the callers.
2024-04-30 13:58:06 -03:00
prlanzarin
a2e22fffb3 fix(audio): broken connection stats on Firefox >= 125
WebRTC-based stats generation in the connection status modal is broken
on Firefox >= 125. A broken type check coupled with a new partially
implemented RTCIceTransport dictionary causes and undefined function
call when fetching the selected candidate pair. Since that error is
unhandled, collection breaks.

Correctly check for the getSelectedCandidatePair method availability in
RTCIceTransport so that it skips to pair inference from getStats if
necessary.
2024-04-30 13:44:29 -03:00
Paul Trudel
698a736d58 Document API validation changes 2024-04-30 08:44:07 -04:00
Tainan Felipe
da60b246d0 Fix: user reaction not showing right emoji 2024-04-26 16:52:28 -03:00
Paul Trudel
fd6bd798f8 Add support for text/xml to create and insertDocument 2024-04-23 14:40:15 -04:00
Paul Trudel
fa38c7747e Removed unused set of supported content types from validator 2024-04-23 12:23:24 -04:00
Paul Trudel
7d156e8828 Added servlet request back to the checksums 2024-04-23 11:44:57 -04:00
Anton Georgiev
be96230894
Merge pull request #20065 from bigbluebutton/translations_60cd9b750d2d41cd929b29887b4db1e8_fr
Updates for project BigBlueButton v2.7 HTML5 client and language fr
2024-04-23 07:56:38 -04:00
transifex-integration[bot]
c83999dd46
Translate en.json in fr
100% translated source file: 'en.json'
on 'fr'.
2024-04-23 07:56:36 +00:00
Paul Trudel
de83c75716 Allow each request to define its own supported content types 2024-04-22 16:11:10 -04:00
Anton Georgiev
ebe0488aa6
Merge pull request #20052 from bigbluebutton/translations_60cd9b750d2d41cd929b29887b4db1e8_el_GR
Updates for project BigBlueButton v2.7 HTML5 client and language el_GR
2024-04-22 08:05:06 -04:00
Anton Georgiev
35c2370aca
Merge pull request #20055 from bigbluebutton/translations_60cd9b750d2d41cd929b29887b4db1e8_ja
Updates for project BigBlueButton v2.7 HTML5 client and language ja
2024-04-22 08:03:23 -04:00
transifex-integration[bot]
ea21caec53
Translate en.json in ja
100% translated source file: 'en.json'
on 'ja'.
2024-04-22 11:52:06 +00:00
transifex-integration[bot]
4cb07ad7e7
Translate en.json in el_GR
100% translated source file: 'en.json'
on 'el_GR'.
2024-04-21 18:17:00 +00:00
Anton Georgiev
0a0e8ef773
Merge pull request #20049 from bigbluebutton/translations_60cd9b750d2d41cd929b29887b4db1e8_ar
Updates for project BigBlueButton v2.7 HTML5 client and language ar
2024-04-19 14:58:59 -04:00
transifex-integration[bot]
503e7420a2
Translate en.json in ar
100% translated source file: 'en.json'
on 'ar'.
2024-04-19 18:31:09 +00:00
Anton Georgiev
0eae452d25
Merge pull request #19987 from lfzawacki/v2.7.x-release-more-languages
[2.7] Support more transcription languages
2024-04-19 11:53:22 -04:00
Anton Georgiev
3c2d89280b
Update bigbluebutton-html5/private/config/settings.yml 2024-04-19 11:24:32 -04:00
Paul Trudel
1b481a9500 Changed content type validation error key and message 2024-04-18 15:29:34 -04:00
Anton Georgiev
5f1c07f4c0
Merge pull request #20042 from bigbluebutton/snyk-fix-8ebee6c1447c58a1f87111817c06d09c
[Snyk] Fix for 1 vulnerabilities
2024-04-18 14:40:55 -04:00
snyk-bot
ffe42d1b10
fix: record-and-playback/core/Gemfile & record-and-playback/core/Gemfile.lock to reduce vulnerabilities
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-RUBY-NOKOGIRI-6228056
2024-04-18 18:03:10 +00:00
Anton Georgiev
b4158cbf14
Merge pull request #20033 from antobinary/port-19815
fix(sec): Bump logback-classic (backport)
2024-04-18 13:53:02 -04:00
Anton Georgiev
b5fe0ac64c
Merge pull request #20034 from antobinary/port-19814
fix(sec): Bump tomcatEmbed to 9.0.86 (#19814) (backport)
2024-04-18 13:52:46 -04:00
Anton Georgiev
304c3136be
Merge pull request #20035 from antobinary/port-19816
fix(sec): Bump org.json:json (backport)
2024-04-18 13:52:25 -04:00
Paul Trudel
e24e358ddd Reject requests with a body but no Content-Type header 2024-04-18 10:58:22 -04:00
Anton Georgiev
a184c67e44 fix(sec): Bump org.json:json 2024-04-17 14:30:10 -04:00
Anton Georgiev
c6ad69f292 fix(sec): Bump logback-classic 2024-04-17 14:29:18 -04:00
Anton Georgiev
3b3e7d840a fix(sec): Bump tomcatEmbed to 9.0.86 (#19814) 2024-04-17 14:24:41 -04:00
Anton Georgiev
f5be95da32
Merge pull request #20026 from Arthurk12/bbb/2.7/multiuser-non-presenter-error
fix(whiteboard): check before manipulating pan tool class list
2024-04-16 19:57:32 -04:00
Arthurk12
49c33b4eea fix(whiteboard): check before manipulating pan tool class list
Since the pan tool is only available for the presenter, it has to be checked
whether it actually exists before attempting to modify its class list.
2024-04-16 16:18:30 -03:00
Arthurk12
45e1724954 fix(presentation): toolbar width on small screens
Forces the toolbar width to be the maximum available width, which is
the width of the media area, on mobile devices. Also allow the toolbar to
overflow with an horizontal scroll when the available width is not enough
to display all of its contents.
2024-04-16 15:46:50 -03:00
transifex-integration[bot]
31537b1910
Updates for project BigBlueButton v2.7 HTML5 client and language fr (#20015)
* Translate en.json in fr

100% translated source file: 'en.json'
on 'fr'.

---------

Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>
2024-04-16 09:41:34 -04:00
Paul
8e40d91877 Removed support for application/json content 2024-04-15 11:29:03 -04:00
Paul
183983be7f Added request content type validation 2024-04-15 11:29:03 -04:00
Paul
1e9e461f50 Check for pressence of query and body 2024-04-15 11:29:03 -04:00
Anton Georgiev
916d601d2b
Merge pull request #20008 from prlanzarin/u27/fix/crash-videoprovider-onmessage
[2.7] fix(bbb-html5): crash on video-provider unmount
2024-04-12 15:54:17 -04:00
Anton Georgiev
85b5e83bd5
Merge pull request #20013 from prlanzarin/u27/fix/arthurk12-undefined-role-crash
[2.7] fix: add safeguards when returning user roles
2024-04-12 15:53:42 -04:00
Anton Georgiev
6eaf8cd44d
Merge pull request #20004 from prlanzarin/u27/fix/audio-less-toasts
[2.7] fix(audio): minimize redundant audio exit toasts
2024-04-12 15:53:18 -04:00
Anton Georgiev
b98340bd27
Merge pull request #20003 from prlanzarin/u27/fix/ua-invalid-version-number
[2.7] fix: crash due to invalid UA version number in WKWebView (backport)
2024-04-12 15:37:15 -04:00
Anton Georgiev
10cb2f3875
Merge pull request #20012 from prlanzarin/u27/fix/arthurk12-screenreader-crash
[2.7] fix(screen-reader): add safeguards for adding alerts
2024-04-12 15:33:28 -04:00
Anton Georgiev
2f3e709324
Merge pull request #20007 from prlanzarin/u27/fix/invalid-metadataprop-access
[2.7] fix(bbb-html5): crash due to undefined metadataProp access
2024-04-12 15:32:17 -04:00
Anton Georgiev
711487c2c9
Merge pull request #20009 from prlanzarin/u27/fix/onconnectionstatechange-crash-rc
[2.7] fix(bbb-html5): crash when stopping WebRTC peers
2024-04-12 15:15:03 -04:00
Anton Georgiev
e511535adc
Merge pull request #20006 from prlanzarin/u27/fix/audio-answerer-gum-failure
[2.7] fix(audio): acquire streams before negotiation when peer is answerer
2024-04-12 15:14:17 -04:00
Anton Georgiev
fda4a5a2ff
Merge pull request #20005 from prlanzarin/u27/fix/crash-getBoundingClientRect-emojirain
[2.7] fix(reactions): crash when interactionsButton coords are absent
2024-04-12 15:13:33 -04:00
Arthurk12
72032f2397 fix: add safeguards when returning user roles 2024-04-12 15:14:49 -03:00
Arthurk12
6cb0e914ab fix(screen-reader): add safeguards for adding alerts
Adds checks for the alert's text and DOM element before adding screen
reader alerts.
2024-04-12 15:09:23 -03:00
prlanzarin
68f66a1fbb fix(audio): handle NotAllowedError in skipCheck:true scenarios
In scenarios where the join audio flow skips echo test, NotAllowedError
(and any other errors) are all being mashed together under a generic
MEDIA_ERROR object.

Properly handle specific errors in audio-manager so they're correctly
render in the audio modal help screen.
2024-04-12 14:40:51 -03:00