GuiLeme
81ae4e9ca6
[issue-16954] - Adjusting modal priorities
2023-03-29 11:08:56 -03:00
GuiLeme
9b39decec7
[issue-16954] - Fix minor issues and cleanning of the old modal structure traces
2023-03-29 11:02:14 -03:00
Anton B
4b5d4e9e2a
Merge remote-tracking branch 'upstream/v2.6.x-release' into webcam-tests
2023-03-29 10:29:58 -03:00
Ramón Souza
ab8d9214af
fix empty slide on presentation change
2023-03-29 09:35:10 -03:00
Paul Trudel
4b24e037f2
Changed value of userLocked
2023-03-28 21:26:40 +00:00
Paul Trudel
d5f8650666
Added userLocked check to allowedToUnmuteAudio check
2023-03-28 21:24:58 +00:00
Paul Trudel
4142917f57
Re-added check for user lock to unmute
2023-03-28 18:50:16 +00:00
Paul Trudel
349886b3b1
Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into allow-mods-unmute-users-fix
2023-03-28 17:52:43 +00:00
Anton Georgiev
e654c390b7
fix: fix some code smell by adding const for variables
2023-03-28 13:25:59 -04:00
KDSBrowne
8af51216fb
move setting isForcePanning to patch event
2023-03-28 16:48:25 +00:00
Anton Georgiev
5887effe7c
Merge pull request #17097 from ramonlsouza/issue-17086
...
fix(whiteboard): Reduce max canvas size
2023-03-28 11:06:10 -04:00
KDSBrowne
d4d3b412df
handle exception while invoking method zoomSlide
2023-03-28 14:47:23 +00:00
Ramón Souza
2138c98dc1
Merge pull request #17327 from Scroody/I-16943
...
Fixed: Note notification removed when shared notes pinned.
2023-03-28 10:50:28 -03:00
Ramón Souza
22ce3af864
Merge pull request #17322 from ramonlsouza/issue-17022
...
fix(whiteboard): Bug while panning the slide by pressing the scroll mouse button or spacebar
2023-03-28 10:25:24 -03:00
Ramón Souza
1fcad3e2f3
Merge pull request #17325 from KDSBrowne/bbb-16946
...
fix: Update Style Menu Position On Iphone
2023-03-28 09:41:42 -03:00
imdt
deee7e393b
Fixed: Note notification removed when shared notes pinned.
2023-03-27 16:58:48 -03:00
Anton Georgiev
f31378ceee
Merge pull request #17163 from ramonlsouza/meteor-tests
...
refactor: migrate Meteor backend to new async api
2023-03-27 15:07:00 -04:00
Anton Georgiev
bef87282e0
Merge pull request #16961 from MaximKhlobystov/whiteboard-tests-and-refactoring
...
test: new whiteboard tests + refactoring of visual regression tests
2023-03-27 13:35:18 -04:00
KDSBrowne
481582cbbd
add missing isIphone value
2023-03-27 15:45:16 +00:00
GuiLeme
5f3296fdb1
[issue-16954] - last migrations - VideoPreview and drag and drop of background
2023-03-27 12:36:25 -03:00
KDSBrowne
fc001edd51
update style menu position on iphone
2023-03-27 15:33:10 +00:00
Ramón Souza
5cd5c14c3d
do not display grab cursor if the user is not presenter
2023-03-27 11:32:43 -03:00
Ramón Souza
b3754570ed
fix force panning
2023-03-27 10:38:05 -03:00
Ramón Souza
2827434739
Merge pull request #17320 from ramonlsouza/issue-17023
...
fix: Dragging presentation area instead of rotated shape
2023-03-27 10:31:14 -03:00
Ramón Souza
fdf9b1a7cc
fix drag presentation after rotating shape
2023-03-27 09:01:59 -03:00
Ramón Souza
234d1ee0f6
Merge pull request #17194 from Arthurk12/17192
...
fix(presentation): workaround for slide download
2023-03-27 08:35:47 -03:00
Ramón Souza
5b0a0d7cf6
Merge pull request #17231 from Scroody/I-17125
...
Fixed: Missing buttons on menus in low resolutions.
2023-03-27 08:11:16 -03:00
KDSBrowne
72adc96dbe
add autohide option for whitboard toolbars
2023-03-26 22:08:09 +00:00
GuiLeme
9329e194fd
[issue-16954] - migration of screenshare unavailable, connectionStatus and randomUser
2023-03-24 17:48:00 -03:00
Gustavo Trott
7b7d2636ad
Merge remote-tracking branch 'upstream/v2.7.x-release' into bbb27-graphql-server
2023-03-24 13:34:00 -03:00
danielpetri1
a9132c7740
Dismiss processing toast after breakout capture
2023-03-24 16:19:10 +00:00
GuiLeme
c1676004d4
[issue-16954] - migration of audio modal
2023-03-24 12:29:09 -03:00
imdt
9a73db883a
Fixed: Missing buttons on menus in low resolutions.
2023-03-24 11:43:55 -03:00
GuiLeme
d389a5b9e3
[issue-16954] - migration of fallback modal and caption reader modal
2023-03-24 10:07:56 -03:00
GuiLeme
c5e38507bb
[fix-pres-with-errors-freeze] - fix for presentation modal uploader freez when cleaning errors.
2023-03-24 09:21:49 -03:00
GuiLeme
7ce2203c04
[issue-16954] - merge v2.6.x-release
2023-03-24 08:44:19 -03:00
Anton Georgiev
f7efedf1a7
Merge pull request #16989 from KDSBrowne/bbb-br-manage-access
...
fix(access): Presentation Interference With Keyboard Access in Breakout Management
2023-03-23 16:56:52 -04:00
Ramón Souza
f8ce724bcc
Merge pull request #17084 from zhem0004/redesignWU
...
fix: Allow viewing of longer names in guest waiting queue
2023-03-23 15:42:53 -03:00
Ramón Souza
53899b2852
styles adjustments
2023-03-23 15:41:32 -03:00
GuiLeme
53fbcf0f67
[issue-16954] - refactor modals rendering
2023-03-23 12:26:39 -03:00
GuiLeme
d4bd29ea67
[issue-16954] - Migrating userOptions and remove user modals
2023-03-23 11:56:00 -03:00
Arthurk12
b7348cffdd
fix(presentation): workaround for slide download
...
This is a workaround to the conflict that is happening when an user tries to
download the slide when dark mode is enabled. There is a conflict between
dark mode's styles and the html-to-image lib. To temporarily prevent this from
happening, the dark mode is disabled before downloading the slide, and then
re-enabled when the download is complete.
In order to be able to enable and disable dark mode from another component than
the App, all the dark mode switch logic was extracted into the service of the
app component.
2023-03-23 10:57:46 -03:00
Ramón Souza
ade1ae22b1
Merge pull request #17107 from KDSBrowne/bbb-17093
...
Prevent URLs Triggering Typed Response Poll Option
2023-03-23 09:23:55 -03:00
GuiLeme
a5b5a754a0
[issue-16954] - Migrating recording modals components
2023-03-22 17:32:47 -03:00
André Castro
97749719b6
Fix: Undo bug returning to slide '0'.
2023-03-22 18:00:19 +00:00
Ramón Souza
b487f90cd8
Merge pull request #17052 from zhem0004/fixPoll
...
fix: Close poll on slide change
2023-03-22 14:36:21 -03:00
Ramón Souza
e08d1ed45a
Merge pull request #17110 from Tainan404/i-17072
...
Fix custom virtual background not being disabled when removed
2023-03-22 13:40:41 -03:00
Anton Georgiev
bae26e0b77
Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into v2.7.x-release
2023-03-22 10:44:36 -04:00
GuiLeme
2f4b0bd592
[issue-16954] - Migration of breakoutroom invitation
2023-03-22 09:50:39 -03:00
GuiLeme
86e1209049
[issue-16954] - migrating user-options createBreakoutRoomModal and GuestPolicy
2023-03-21 17:45:20 -03:00
Anton Georgiev
e0e88286e2
Merge pull request #17071 from KDSBrowne/bbb-role-rc
...
fix(access): Prevent Race Condition Removing Role Value
2023-03-21 15:45:09 -04:00
Anton Georgiev
b891f318af
Merge pull request #17085 from ramonlsouza/fix-preload-firefox
...
fix: poll results size calculation on firefox
2023-03-21 14:41:28 -04:00
GuiLeme
4e17e80873
[issue-16954] - migrating dropdown menu from presenter
2023-03-21 14:55:43 -03:00
imdt
76b546f6d6
fetchAsync not working with some method fixed.
2023-03-21 14:44:12 -03:00
GuiLeme
031ead2176
[issue-16954] - Changes to settings dropdown
2023-03-21 10:00:46 -03:00
Gustavo Trott
0aa923e269
Merge remote-tracking branch 'origin/bbb-graphql-server' into bbb27-graphql-server
2023-03-21 08:36:50 -03:00
Ramón Souza
2dee62d5e3
Merge pull request #16979 from ramonlsouza/issue-16969
...
fix: Copy/Paste into Guest Policy textbox will cause a text box to appear in whiteboard
2023-03-21 08:19:49 -03:00
prlanzarin
1ada7dc57e
fix(audio): output device changes not effective in local echo test
...
Output device changes aren't working in 2.6's echo test when artifical delay
is on due to the fact that the feedback audio is being played via the WebAudio
context rather the the HTMLMediaElement. Since output device change works
via HTMLMediaElement's setSinkId, it's basically a no-op.
This commit fixes the issue by piping the AudioContext destination
through the main audio element rather than using WebAudio directly for
playback. An additional stub media element (muted) is added to circumvent one
of Chrome's WebAudio issue.
The alternative would be to use AudioContext's setSinkId, but it isn't
supported by Firefox (setSinkId enabled) and Chrome < 110.
This should work with FF (setSinkId enabled) and a wide array of Chromium
versions.
2023-03-20 17:38:06 -03:00
Anton Georgiev
87ced428f8
Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into v2.7.x-release
2023-03-20 16:24:52 -04:00
Tainan Felipe
a393ad6997
Fix custom virtual background not being disabled when removed
2023-03-20 17:17:27 -03:00
imdt
2a5142a4ea
Users persistent data back-end migrated to new async API
2023-03-20 16:43:05 -03:00
Tainan Felipe
3959eab633
Refactor: Migrate video-streams for the Meteor 3.0 api
2023-03-20 16:39:36 -03:00
imdt
6949e9b59b
Voice call states and voice users back-end migrated to new async API.
2023-03-20 16:39:24 -03:00
Tainan Felipe
3fb59bcb41
Refactor: Migrate screenshare for the Meteor 3.0 api
2023-03-20 16:39:11 -03:00
imdt
b27542065e
Users settings migrated to new async API.
2023-03-20 16:38:56 -03:00
Tainan Felipe
f7b8b116e7
Refactor: Migrate presentation upload token for the Meteor 3.0 api
2023-03-20 16:38:42 -03:00
Tainan Felipe
029929e7d8
Refactor: Migrate pads for the Meteor 3.0 api
2023-03-20 16:38:31 -03:00
imdt
fc14710e14
Local settings back-end migrated to new async API.
2023-03-20 16:38:20 -03:00
Tainan Felipe
8b1565f2c9
Refactor: Migrate cursors for the Meteor 3.0 api
2023-03-20 16:38:05 -03:00
Tainan Felipe
2bb7235836
Refactor: Migrate group chat for the Meteor 3.0 api
2023-03-20 16:37:51 -03:00
Tainan Felipe
e3bbf1156f
Refactor: Migrate auth-token for the Meteor 3.0 api
2023-03-20 16:37:36 -03:00
imdt
bbac3e5b11
Slides back-end migrated to new async API.
2023-03-20 16:37:16 -03:00
Tainan Felipe
470937bf6f
Refactor: Migrate users for the Meteor 3.0 api
2023-03-20 16:35:52 -03:00
imdt
f03cc32b56
Presentation pod migrated to new async API
2023-03-20 16:35:40 -03:00
imdt
d7d1eb65da
Presentations back-end migrated to new async API.
2023-03-20 16:35:06 -03:00
imdt
f3c6fbc5f2
Group chat msg back-end migrated to new async API.
2023-03-20 16:24:58 -03:00
Tainan Felipe
7c8337733f
Refactor: Migrate meetings for the Meteor 3.0 api
2023-03-20 16:24:41 -03:00
imdt
16ff3be4ee
External video back-end migrated to new async API
2023-03-20 16:24:26 -03:00
imdt
03e037b5ea
Audio captions back-end migrated to new async API
2023-03-20 16:24:09 -03:00
imdt
5add111aa9
Connection status back-end migrated to new async API
2023-03-20 16:23:56 -03:00
Tainan Felipe
a5dea6f595
Refactor: Migrate captions for the Meteor 3.0 api
2023-03-20 16:23:41 -03:00
imdt
6472cf8d0d
Breackouts history back-end migrated to new async API
2023-03-20 16:23:27 -03:00
imdt
c701ff5c66
Users info back-end migrated to new async API
2023-03-20 16:23:11 -03:00
Tainan Felipe
314395298b
Refactor: Migrate whiteboard-multi-user for the Meteor 3.0 api
2023-03-20 16:22:55 -03:00
imdt
f18d4018f0
Backend of guest-users migrated to new async API.
2023-03-20 16:21:40 -03:00
Tainan Felipe
77fc5d4067
Refactor: Migrate annotations for the Meteor 3.0 api
2023-03-20 16:16:52 -03:00
imdt
074ce93a4f
refactor: Migrate polls backend to new async api
2023-03-20 16:15:55 -03:00
GuiLeme
ec17b5dca9
[issue-16954] - new structure and connection status modal transition
2023-03-20 14:57:36 -03:00
KDSBrowne
de75d18e30
remove url detected as question
2023-03-20 16:18:42 +00:00
GuiLeme
e77af8874b
[issue-16954] - patch for renaming
2023-03-20 10:13:35 -03:00
GuiLeme
f943cbf732
[issue-16954] - renaming referencing of Modals
2023-03-20 10:08:35 -03:00
Ramón Souza
630247a568
reduce canvas max size
2023-03-20 08:43:27 -03:00
Ramón Souza
3b849a9600
fix poll results size on firefox
2023-03-17 14:51:39 -03:00
Ramón Souza
c3d89ee4fc
Merge pull request #17044 from antobinary/fix-undefined-user
...
fix: Fix undefined user in rare end-breakout scenario
2023-03-17 14:06:15 -03:00
Anton Georgiev
2f3a8f03e9
Merge pull request #17083 from ramonlsouza/pr-16950
...
feat(layout): Recover (from 2.5) the ability of viewers to set their own layout
2023-03-17 12:50:26 -04:00
Anton Georgiev
19d3b03afd
Merge pull request #16972 from gabriellpr/learning-dashboard-test
...
test: learning dashboard
2023-03-17 12:25:25 -04:00
KDSBrowne
97d68f9416
fix chat semantics on mount and on update
2023-03-17 13:24:50 +00:00
Bohdan Zhemelinskyi
f5e83d336d
redesign waiting user buttons
2023-03-17 13:10:27 +00:00
Ramón Souza
9a56952483
restore popup menu
2023-03-17 09:54:36 -03:00
Ramón Souza
b3be1c3a74
fix sync layout only if custom
2023-03-17 09:37:45 -03:00
Ramón Souza
f4bd2e8bef
Merge pull request #17039 from ramonlsouza/issue-16682
...
fix: Poll results are difficult to read and not scaled to fit slide
2023-03-17 08:41:01 -03:00
Ramón Souza
dcc9e4fb64
add links to tldraw functions
2023-03-17 08:40:24 -03:00
Ramón Souza
1cc60fda31
adjust size calculation, preload font
2023-03-16 15:55:56 -03:00
KDSBrowne
3eb54122c5
add timeout to prevent race condition removing role value
2023-03-16 15:36:28 +00:00
Ramón Souza
8dbff37a43
Merge pull request #16868 from Arthurk12/bbb/2.6/15716
...
fix(breakout rooms): video and audio modal appearing for all mods when rejoining
2023-03-16 10:42:16 -03:00
hiroshisuga
7e7c46b9e9
change icon
2023-03-16 21:34:13 +09:00
hiroshisuga
12a53e3a59
reset opacity RTL <-> LTR
...
Some comments have been removed as well.
2023-03-16 19:37:21 +09:00
hiroshisuga
d18dca3eaf
Merge pull request #153 from hiroshisuga/dev2.6.0rc8_hidetoolbar
...
Dev2.6.0rc8 hidetoolbar
2023-03-16 18:46:40 +09:00
Ramón Souza
c282bbfae2
Merge pull request #17049 from KDSBrowne/bbb-17046
...
fix: Prevent Response Poll Displaying For True / False
2023-03-15 16:48:08 -03:00
Paul Trudel
ccc0274931
Removed condition on unmute that prevented option from displaying
2023-03-15 19:01:29 +00:00
Bohdan Zhemelinskyi
ecdc5304df
add prop type
2023-03-15 18:24:34 +00:00
Bohdan Zhemelinskyi
2015c50105
destructure function
2023-03-15 18:16:56 +00:00
Bohdan Zhemelinskyi
1025e4b1dc
move cloe function to container
2023-03-15 18:06:59 +00:00
Bohdan Zhemelinskyi
dc9ac7a125
close poll on slide change
2023-03-15 17:12:47 +00:00
Ramón Souza
5d0b1c842f
handle select all shortcut in whiteboard
2023-03-15 11:39:33 -03:00
KDSBrowne
c4d45e94b6
prevent response poll displaying for true / false
2023-03-15 13:36:40 +00:00
hiroshisuga
02fe1a8955
comment for using the API setSetting
2023-03-15 13:53:37 +09:00
hiroshisuga
0e188d5c30
menu item for tool visibility
2023-03-15 13:49:17 +09:00
hiroshisuga
1fe0edf2a4
add props hsWBAccess and amIPresenter
2023-03-15 13:43:21 +09:00
Anton Georgiev
372e17ca08
fix: check if defined before checking .role
2023-03-14 16:39:06 -04:00
Ramón Souza
cc4f7a9f0b
Merge pull request #17018 from KDSBrowne/bbb-16379
...
Zoom By Mouse Wheel Only Operation
2023-03-14 17:21:43 -03:00
zhem0004
5fdd91ba67
Add new setting to enable/disable extra guest policy Allow buttons ( #17034 )
...
* add new setting to enable/disable extra guest policy buttons
2023-03-14 14:39:37 -04:00
Anton Georgiev
af06006163
Merge pull request #16990 from GuiLeme/issue-16872
...
fix (html5): not showing invitation when user is moved to another breakout room
2023-03-14 14:26:38 -04:00
Anton Georgiev
1a3221ee3e
Merge pull request #16675 from GuiLeme/issue-16660
...
fix: Presentation-uploader not working properly
2023-03-14 14:24:23 -04:00
Anton Georgiev
b3d3258120
Merge branch 'issue-16872' of github.com:GuiLeme/bigbluebutton into v2.6.x-release
2023-03-14 14:22:58 -04:00
Ramón Souza
fa1ad677d6
add border and formatting to poll results
2023-03-14 15:16:21 -03:00
GuiLeme
844b0995e1
[issue-16660] - fix duplicationo of file when cleanning errors in page generation stage
2023-03-14 09:56:27 -03:00
KDSBrowne
5fe6a9a0a9
add query for canvas element
2023-03-13 17:22:38 +00:00
Ramón Souza
990e3f2e7a
Merge pull request #17011 from ramonlsouza/fix-pres-snapshot
...
fix: snapshot of current slide
2023-03-13 13:17:18 -03:00
KDSBrowne
53cc7c48f3
intercept wheel event and force ctrl key for zooming
2023-03-13 16:16:37 +00:00
Ramón Souza
f7586dedca
Revert "fix(html5): Empty space when removing all presentations"
2023-03-13 13:09:31 -03:00
GuiLeme
4f3931c0ff
[issue-16872] - Changes in review
2023-03-13 12:44:35 -03:00
GuiLeme
e68997e673
[issue-16872] - Changes in review
2023-03-13 12:27:11 -03:00
GuiLeme
f7649cdd19
[issue-16872] - Change session logic to event logic
2023-03-13 11:13:56 -03:00
Ramón Souza
4a6c10a3dd
fix whiteboard snapshot
2023-03-13 09:17:14 -03:00
Ramón Souza
718aee3514
Merge pull request #16823 from danielpetri1/issue-16511
...
fix(html5): Empty space when removing all presentations
2023-03-13 08:30:56 -03:00
danielpetri1
cfe77c1ba9
Maximize webcams upon joining meeting with no presentation
2023-03-12 16:47:11 +00:00
KDSBrowne
e577d0a8f7
remove disabled from pan tool
2023-03-11 17:11:48 +00:00
KDSBrowne
8eba308f36
add crosshair cursor for arrow and eraser tool
2023-03-11 16:09:30 +00:00
danielpetri1
840a824cb3
Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into issue-16511
2023-03-10 20:33:54 +00:00
GuiLeme
f711a4ca32
[issue-16872] - Fixed flashing of breakout modal invitation
2023-03-10 16:28:05 -03:00
KDSBrowne
a9e7f54a1d
fix presentation interference with keyboard access in br management
2023-03-10 18:42:57 +00:00
Anton Georgiev
2c5cd8f2a0
Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into merge-26-27
2023-03-10 13:03:56 -05:00
germanocaumo
a0ef1957c6
fix(pantool): prop type warning
2023-03-10 12:36:54 +00:00
germanocaumo
37c3e4afcc
Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into prest-whit-code-refactor
2023-03-10 12:22:10 +00:00
Ramón Souza
f51f445896
Merge pull request #16923 from lfzawacki/v2.6.x-release-presentation-minimize
...
fix(presentation): Remove old presentation minize code
2023-03-10 09:05:53 -03:00
germanocaumo
eaa7a9cb6f
refactor(html5): remove unused code
2023-03-10 11:52:00 +00:00
Ramón Souza
619badda22
Merge pull request #16890 from KDSBrowne/bbb-export-notification
...
fix: Notifications on export presentation with annotations
2023-03-10 08:43:04 -03:00
germanocaumo
d09f2681d9
refactor(html5): presentation/whiteboard/cursor code cleanup and linting
2023-03-10 11:30:46 +00:00
Ramón Souza
6970fef004
Merge pull request #16962 from germanocaumo/cursor-fixes
...
fix(tldraw): cursor fixes
2023-03-10 08:04:31 -03:00
germanocaumo
a3f8147b42
fix(cursor): remove duplicate code
2023-03-09 23:10:18 +00:00
Ramón Souza
42a2a729bb
auto focus on external video input
2023-03-09 16:44:47 -03:00
Ramón Souza
6bd6dd2767
fix copy/paste/cut on guest user message input
2023-03-09 14:46:45 -03:00
Ramón Souza
9a60bdcd06
Merge pull request #16971 from KDSBrowne/bbb-16959
...
fix: Stop Tool Lock Being Reset on Updates
2023-03-09 10:47:36 -03:00
KDSBrowne
c6379443cc
update isToolLocked initial value
2023-03-09 08:42:05 -05:00
KDSBrowne
47e7bda1a9
stop tool lock being reset on updates
2023-03-08 20:41:25 +00:00
prlanzarin
3bddbb96cf
fix(video): signaling and reconnection edge cases
...
There are still a bunch of edge cases and issues with reconnection
scenarios for video:
- Signaling socket refuses to reconnect once maxRetries expire
- Race conditions on local stream attachment: local camera wouldn't be
correctly rendered _if_ the attached stream existed _without_ video
tracks yet
- Video tracks leak on local streams when replacing them (virtual bgs)
- Completely ignoring Meteor state when trying to reconnect cameras
- Streams aren't proactively stopped when the signaling socket dies
- Outbound request queues aren't isolated by stream nor are they
flushed when a newer peer with the same ID is created
- Server originated negotiation errors won't trigger a local peer
cleanup - thus leaving dangling peers that take way too long to
reconnect
This commit fixes or improves all of the aforementioned issues, +:
- Remove unused arguments in the peer (client->SFU) 'start' request
- Prevent crashes when trying to render video-list-items without user
data (which might happen on re-connections)
2023-03-08 15:49:35 -03:00
prlanzarin
afa2908ded
fix(screenshare): better reconnection timers and UI for abrupt failures
...
Reconnection timers are far too long for abrupt failures because we
are waiting the original timeouts to elapse (30-60s) before trying it
again - even if a connection worked N-sessions back in that session's
history. The ideal thing to have is another intermediate, smaller and
fixed reconnection timer for sessions that had a working screen share
at least once.
The UI is also not being updated to the reconnecting state on negotiation
failures.
* Add an intermediate reconnection timer for abrupt failures set to 8s.
This should improve reconnection times.
* Lower default connection timers values (base 20s down from 30s, max
25s down from 60s)
* Set screen share UI to reconnecting on abrupt failures as well - we
were only tracking ICE states prior to this, not negotiation errors
2023-03-08 15:48:30 -03:00
prlanzarin
bd0dfa17cc
fix(screenshare): default to not flowing is peer was lost
...
The media monitor responsible for triggering the reconnecting view in
the screen sharing component was maintaing the previous state (eg
flowing) in cases where the peer just failed before media stopped
flowing. That triggered an error in the bps calculations that caused the
previous state to be preserved - eg stuck in flowing while it should be
not_flowing.
These changes make it so that if there's not peer to fetch stats from,
them the bps calculations will correctly return 0 (which translates to
not_flowing).
2023-03-08 15:48:22 -03:00
prlanzarin
d2e8e74471
fix(screenshare): always try to reconnect to screen as viewer
...
The reconnect routine is stopping for viewers if a broker cannot
re-connect in the first try. That is wrong: viewers should try to
reconnect as long as there'sigaling data that mandates so.
The reconnect trigger is changed from broker's started attribute to the
presence of a scheduled reconnection timeout - if there isn't one (not
schedule), always re-schedule it.
2023-03-08 15:47:01 -03:00
prlanzarin
5ee0ff9af2
fix(screenshare): add proper signaling heartbeat, +
...
Same rationale as in video-provider's commit
(34fa37ae4f092af4a5aef0cf01d96c033d97473c).
This commit does the following:
- Implement actual heartbeat checks to trigger reconnects when
necessary
- Properly catch and log WebSocket.send errors
2023-03-08 15:46:55 -03:00
prlanzarin
a83f3b675e
fix(video): add proper signaling WS heartbeat, +
...
video-provider's current ping-pong is as good as nothing in 2.5+. We
were counting on Meteor's (and consequently the component's mount state)
before 2.5 to act as a "heartbeat" as far as the socket is concerned.
The ping-pong served only to sustain traffic for finnicky,
traffic-dependant firewall.
Since 2.5, the component's state is _kind of_ detached from Meteor's -
which means it won't unmount when Meteor disconnects. That causes the
video-provider websocket to lose its borrowed heartbeat and leads to a
bunch of reconnectiong inconsistencies, the worst of them being a stuck,
useless signaling socket that will cause cameras not to work until a
client refresh.
This commit does the following:
- Implements actual heartbeat checks to trigger signaling socket
reconnects when necessary, all within the scope of video-provider
- Remove borked, eons old 'offline'/'online' event handlers: they were
causing unnecessary camera drops AND causing video-provider to
generate a stuck signaling socket
- Properly catch WebSockets.send errors
2023-03-08 15:46:51 -03:00
prlanzarin
e9f0a7347c
fix(video): properly render reconnecting view
...
The stream state change handler in video-list-item is using a component
state reference inside a DOM event callback - which means it is always
presuming `isStreamHealthy` is false (initial value). That prevents the
health state from actually transitioning when necessary (and
consequently rendering the reconnecting view in video-list item).
This commit removes the state-based transition check in the state change
handler and unifies the reconnecting view to use the username
placeholde (replacing the loading spinners).
2023-03-08 15:46:44 -03:00
germanocaumo
8aa15ef861
fix(cursor): send cursor position disabled on unmount
...
This fixes the cursors staying visible in the recording after the multiuser was disabled.
Also stop sending some unnecessary end events.
2023-03-08 16:39:53 +00:00
Ramón Souza
f2a3031b04
Merge pull request #16949 from KDSBrowne/bbb-chat-list-a11y
...
Add List and List Item Roles to Chat Elements
2023-03-08 13:14:56 -03:00
Maxim Khlobystov
8108f10d0f
Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into whiteboard-tests-and-refactoring
2023-03-08 15:33:37 +00:00
Maxim Khlobystov
5f617d94db
New whiteboard tests + refactoring
2023-03-08 15:33:05 +00:00
Gustavo Trott
42711ac5ae
Initial implementation of Postgres data and Hasura
2023-03-08 12:23:45 -03:00
Ramón Souza
8ee8a5508f
fix whiteboard crash when adding a new presentation
2023-03-08 10:01:18 -03:00
Anton Georgiev
8e640a7918
fix: avoid wb crash when switching presentation
2023-03-07 16:11:40 -05:00
Carlos Henrique
b2bc2d174c
feature(layout) viewers layout
...
Add a button for viewers to change the layout.
2023-03-07 16:09:02 -03:00
germanocaumo
c1810360ef
fix(cursor): improve cursor position for others
...
Cursor position was desynced after the presenter zoomed with ctrl+scroll, also fixes the last position of the cursor not being sent sometimes.
Move the throttle to the service call so it is considered in all cases (and there was already a throttle there).
2023-03-07 19:03:07 +00:00
KDSBrowne
68caf7549c
add list and listitem roles to chat
2023-03-07 18:18:15 +00:00
Ramón Souza
3c376e112d
Merge pull request #16936 from ramonlsouza/not-logged-redirect
...
fix: return logoutUrl on logout even if the user is not logged in
2023-03-07 13:03:20 -03:00
Ramón Souza
4aeb406aaf
Merge pull request #16754 from Scroody/i-16640
...
fix: Banned user sees message upon return attempt (before - only blue screen)
2023-03-07 13:03:00 -03:00
Anton Georgiev
5fced70d2e
Merge pull request #16932 from hiroshisuga/patch-63
...
fix: Fix an inline typo
2023-03-07 09:13:18 -05:00
Ramón Souza
966a471e50
Merge pull request #16800 from Tainan404/migrate-to-async
...
refactor: Migrate the breakout room backend to new async api
2023-03-07 10:57:34 -03:00
Ramón Souza
5846312f93
return logoutUrl even if the user is not logged in
2023-03-07 09:38:57 -03:00
Ramón Souza
65a91970d3
Merge pull request #16820 from antobinary/indexing-2
...
fix: index auth-token-validation by connectionId
2023-03-07 09:04:24 -03:00
Ramón Souza
e69f3af339
Merge pull request #16922 from lfzawacki/v2.6.x-release-moderator-layout
...
feature(layout): Moderators can now setPushLayout
2023-03-07 08:30:05 -03:00
hiroshisuga
20325de995
typo
2023-03-07 13:29:00 +09:00
Lucas Fialho Zawacki
8f5460312a
fix(layout): Propagate correct presenter layout when push is off and moderator sets it to true
2023-03-06 18:08:25 -03:00
Gabriel Porfirio
ac7be647c1
Merge remote-tracking branch 'upstream/v2.6.x-release' into learning-dashboard-test
2023-03-06 14:33:28 -03:00
Ramón Souza
529a6e470c
Merge pull request #16864 from Scroody/I-16437
...
fix: Switching from breakout room to parent meeting no longer keeps the webcam activated.
2023-03-06 10:25:27 -03:00
imdt
666dc838c8
Not required pieces of code removed.
2023-03-06 10:13:46 -03:00
Ramón Souza
0e28b96aa2
Merge pull request #16906 from Tainan404/fix-restoreOnUpdate-feature
...
Fix: restoreOnUpdate feature does not work when switching presentation
2023-03-06 09:09:05 -03:00
KDSBrowne
95fd2e3d3e
fix moving a group of objects | add select cursor
2023-03-05 23:20:56 +00:00
Lucas Fialho Zawacki
86843aebf6
fix(presentation): Remove old presentation minize code
2023-03-03 19:11:31 -03:00
Lucas Fialho Zawacki
e8a4b654cc
feature(layout): Moderators can now setPushLayout
2023-03-03 18:59:47 -03:00
Tainan Felipe
fdc6a64085
Fix restoreOnUpdate feature
2023-03-03 14:58:41 -03:00
danielpetri1
5d2b5594fe
Fix conflicts
2023-03-02 20:49:16 +00:00
Ramón Souza
50000ad806
Merge pull request #16851 from KDSBrowne/bbb-pan-fixes
...
fix: Prevent Lines Being Drawn While Panning | Style Updates
2023-03-02 17:05:19 -03:00
Daniel Petri Rocha
754e1b5424
Include meetingID as a selector
2023-03-02 19:58:08 +00:00
Gabriel Porfirio
6b0a260a71
3 tests added
2023-03-02 16:57:02 -03:00
Ramón Souza
cae4453a1a
Merge pull request #16799 from zhem0004/restorePres
...
fix: Restore presentation on layout push
2023-03-02 15:52:45 -03:00
Anton Georgiev
932f5ecf71
Merge pull request #16842 from ramonlsouza/issue-16818
...
fix: Deleting the target object for an arrow crashes the presentation area
2023-03-02 13:25:38 -05:00
Ramón Souza
ad9a2e9a1e
Merge pull request #16860 from hiroshisuga/patch-62
...
fix: Disable the hidden help icon of tldraw
2023-03-02 15:10:38 -03:00
Ramón Souza
d181eba1c2
replace lodash.throttle with native function
2023-03-02 10:25:08 -03:00
Ramón Souza
3804c8b57e
replace lodash/fp
2023-03-02 10:05:41 -03:00
GuiLeme
827d449eb8
Merge remote-tracking branch 'upstream/v2.6.x-release' into issue-16660
2023-03-02 09:27:12 -03:00