Commit Graph

364 Commits

Author SHA1 Message Date
Mario Jr
e16566de9d Recover mute state for moderator when returning from breakout's audio transfer
Fixes #11489
2021-03-05 00:02:31 -03:00
Mario Jr
2e92de8010 Clean up HTMLAudioElement used for notification sounds
After ending the notification playback, we set the ".src" property to null, which immediately stop the internal player of mobile browser (tested on Chrome for Android -  device list is on #11458).
For the specific list of devices, this prevents the internal buffer error "-61" described in #11458.
Fixes #11458.
2021-02-23 11:12:37 -03:00
Mario Jr
b7216dd100 Preserve mutestatus when disconnecting/reconnecting microphone
After audio reconnection, a muted user would have it's microphone unmuted by default, unless muteOnStart is set to true. This fix this problem.
Fixes #9016
2021-02-11 23:55:34 -03:00
prlanzarin
234efd289a audio: add a configurable throttle to action-bar`s mute toggle
Default value is 300ms, with default trailing/leading. Set toggleMuteThrottleTime to 0 to restore old behaviour
2021-01-26 11:47:48 -03:00
Mario Jr
97c76900cb Add setting for enabling/disabling microphone audio filters
As explained in #11143, disabling audio filters is desired in some scenarios.
This basically adds an option for user to disable default constraints.
When user doesn't change this value in Settings > Application, the default
value for each audio constraints is retrieved from settings.yml.
When user changes this value in Settings > Application, audio
filters (AGC, Noise Supression and Echo Cancellation) are all set to
true/false, according to the value selected in the Settings GUI.

To start it simple, we decided to not to add a different setting in the GUI for
each audio contraint. This may be added in the future, though (perhaps in a
dedicated Audio Settings tab)
This is related to #4873
2021-01-22 16:30:42 -03:00
Mario Jr
1b1a055d37 Fix audio modal buttons (MIC/LISTEN) not working after audio error
When user joins audio and for some reason an error (such as 1001, 1002,...), happens, the user is not able to click "Mic" and "Listen Only Buttons"; except if the audio window is closed and oppened again.
2020-11-17 15:31:42 -03:00
Mario Jr
df67d2e680 Better handling audio reconnection
When getting disconnected with 1001 ("websocket closed unexpectedly" error) we were creating a new SIP session, therefore a new FreeSWITCH channel.
While reconnecting the socket, instead of closing the SIP session, we keep it alive during reconnection (audio should keep working in the meantime). When reconnected we keep using this same session (avoiding the creation of an extra one).
We also better handle WebSocket error codes from SIP.js.
FF immediately closes websocket when unloading page, so we now to stop user agent when 'beforeunload' event is triggered, to avoid leaving open sessions in FreeSWITCH when user leaves page.
2020-10-15 11:24:23 -03:00
Mario Jr
e9e436378a Correctly set audio input/output devices
When refusing ("thumbs down" button) echo test, user is able to select a different input device. This should work fine for chrome, firefox and safari (once user grants permission when asked by html5client).
For output devices, we depend on setSinkId function, which is enabled by default on current chrome release (2020) but not in Firefox (user needs to enable "setSinkId in about:config page). This implementation is listed as (?) in MDN.
In other words, output device selection should work out of the box for chrome, only.
When selecting an outputDevice, all alert sounds (hangup, screenshare , polling, etc) also goes to the same output device.
This solves #10592
2020-10-06 20:37:55 -03:00
Mario Jr
619ffa0ec1 Port SIP.js to 0.17.1 release
This considerably changes the way we process audio signaling and start audio elements in user's browser.
We now avoid using AudioContext element for both microphone and listenonly calls, once it is unstable for some iOS devices (cracky audio, user stops hearing audio after a while).
Increased default value for listenOnlyCallTimeout: this avoids activating FreeSWITCH's fallback when ICE negotiation takes longer than 15sec (tested on DO).
Increased listenonly logs.
This fixes #8133 #10388
2020-09-25 20:26:22 -03:00
KDSBrowne
51c3543826 fix shortcuts not working when helper is passed an array 2020-05-21 18:43:34 +00:00
Anton Georgiev
1fa426058f corrected issues related to publishing and methods 2020-02-13 14:19:29 -05:00
Chad Pilkey
e2eabfb44f attempt to stop accidental audio join double clicks 2019-11-22 13:55:26 -08:00
Anton Georgiev
42d640f3e2 Merge branch 'issue7791-add-support-to-new-parameters-name' of github.com:diegobenetti/bigbluebutton into test-7805 2019-11-05 11:59:00 -05:00
Chad Pilkey
6cccfb2ada
Merge pull request #8168 from KDSBrowne/issue-8112
Extend help text shown when getUserMedia with microphone fails
2019-10-24 12:28:53 -04:00
KDSBrowne
c548332b94 improve audio modal help content spacing 2019-10-22 19:32:04 +00:00
KDSBrowne
4fd06509e4 fix chrome on ios error being displayed incorrectly 2019-10-01 14:28:06 +00:00
KDSBrowne
89853dc026 move microphone error codes to const 2019-09-30 14:54:34 +00:00
KDSBrowne
636f49cd5d add error messages for getUserMedia failing with mic 2019-09-27 13:52:29 +00:00
KDSBrowne
830fb4252d remove unused css variables 2019-09-19 13:43:53 +00:00
KDSBrowne
8593b8607c center permission hint on safari 2019-09-18 18:02:29 +00:00
KDSBrowne
e7b53d34eb fix position of audio permission modal in RTL (chrome / firefox) 2019-09-17 15:07:31 +00:00
KDSBrowne
3d74e3c5c9 update arrow char so it works with ios and others 2019-09-10 14:20:37 +00:00
Anton Georgiev
4a335a1db6 reduce db probes for getAvailableActions; simplify SaveUsernames 2019-09-06 16:28:02 -04:00
Chad Pilkey
304bb2c103
Merge pull request #8030 from antobinary/chat-ids-2
Reduced client load via slight refactor
2019-09-05 13:23:37 -04:00
Anton Georgiev
c5856d43c8 moved static code outside of tracker 2019-09-04 14:32:58 -04:00
Anton Georgiev
2cbe91e222
Merge pull request #7996 from KDSBrowne/issue-7994
Fix join by phone icon placement in RTL
2019-08-30 09:43:31 -04:00
Anton Georgiev
ea18b09311 add a few more collection lookups "fields" delimiters 2019-08-29 12:26:07 -04:00
KDSBrowne
3e38a4f7d2 move arrow position 2019-08-29 14:26:51 +00:00
Anton Georgiev
b71dba2299
Merge pull request #7955 from KDSBrowne/001-fix-audio-logs
Fix mute audio log
2019-08-29 09:59:49 -04:00
Anton Georgiev
892336632f added "fields:{...}", removed most mapUser 2019-08-28 16:32:55 -04:00
KDSBrowne
a209449891 fix Join by phone icon placement RTL 2019-08-26 20:47:54 +00:00
Joao Siebel
7603c78740 Allow autoShareWebcam even when autoJoin is disabled
close #7902
2019-08-22 17:08:24 -03:00
KDSBrowne
17f9dfabd2 fix mute log 2019-08-20 00:26:05 +00:00
prlanzarin
982ab3631d Update play audio prompt on autoplay modal view 2019-08-14 19:15:11 +00:00
prlanzarin
9942dd0aa2 Merge remote-tracking branch 'upstream/master' into 2.2-ap-ui 2019-08-02 21:36:44 +00:00
prlanzarin
8d65ce565d Add UI prompts when autoplay is blocked for video/screenshare/listen only 2019-08-02 21:32:42 +00:00
Diego Benetti
c4462c4cb0 Fixes errors and improves parameters setting proccess 2019-08-02 15:38:38 -03:00
Anton Georgiev
e22d61b2e1 removed .log() function in favour of logger 2019-08-01 12:47:45 -04:00
Diego Benetti
3458458cfd Fixes proptypes errors 2019-07-26 15:44:56 -03:00
Diego Benetti
016088ec82 Fixes proptype error 2019-07-26 15:06:12 -03:00
Diego Benetti
3090950957 Fixes proptype error 2019-07-26 14:55:40 -03:00
KDSBrowne
624cc306d1 change prop name in audio controls container 2019-07-26 14:46:30 +00:00
KDSBrowne
bc0202d540 Merge branch 'issue-7794' of https://github.com/KDSBrowne/bigbluebutton into issue-7794 2019-07-26 14:38:59 +00:00
KDSBrowne
d8b2da7475 add suggested changes 2019-07-26 14:35:20 +00:00
KDSBrowne
65e58f2426 remove name duplication 2019-07-26 14:06:10 +00:00
KDSBrowne
4fba9978d3 add audio logs (join/leave/mute/unmute) / fix lint issues 2019-07-25 18:41:24 +00:00
Diego Benetti
f13239674b Changes other parameters to the new pattern 2019-07-24 14:04:46 -03:00
Diego Benetti
4a764f8f6c Implements new name for parameters and the support to the old names 2019-07-22 11:28:13 -03:00
KDSBrowne
ff71b15280 remove isRequired from resolve prop in audio modal 2019-07-19 14:45:04 +00:00
Anton Georgiev
7b06c6784e
Merge pull request #7765 from MaximKhlobystov/mute-unmute-tip
Tip that explains how to mute/unmute yourself using a phone
2019-07-11 15:39:03 -04:00