Commit Graph

28648 Commits

Author SHA1 Message Date
Anton Georgiev
27f3cd631c
Merge pull request #11543 from ramonlsouza/issue-11270-svg
Fix svg width error
2021-03-03 14:39:40 -05:00
Pedro Beschorner Marin
e08af4b43e Include waiting users push alert in settings
Since we added audio alert notifications in settings controls there was an ampty
grid gap reserved for the push alerts.
2021-03-03 16:26:15 -03:00
Ramon Souza
0a1516c36e fix svg width error 2021-03-03 15:59:34 -03:00
Pedro Beschorner Marin
e0bbe6e189 Using the correct constant value 2021-03-03 15:48:17 -03:00
Vitor Vanacor
1b218d4730 Change guest waiting bell debounce to throttle
Debounce could make the behaviour of "not always ringing when a guest
enters" feel "buggy". Throttle makes it clearer that it happens to
prevent it from ringing too frequently.

Also move Throttle time from magic number to constant for
a meaningful variable name.
2021-03-03 15:26:50 -03:00
Vitor Vanacor
65ceb37872 Change default guestWaitingAudioAlerts to false
Co-authored-by: Pedro Beschorner Marin <pedrobmarin@gmail.com>
2021-03-03 15:26:26 -03:00
Vitor Vanacor
f2e40d3286 guestWaitingAudioAlert moved to settings 2021-03-03 15:24:54 -03:00
Anton Georgiev
c3cf52f91d
Merge pull request #11542 from bigbluebutton/antobinary-patch-2-1
Revert custom changes to settings.yml
2021-03-03 13:09:52 -05:00
Anton Georgiev
de3cbec87a
Revert custom changes to settings.yml
Inadvertently introduced by #11514
2021-03-03 13:09:00 -05:00
Vitor Vanacor
55092a9de6 Use doorbell sound as waiting guest notification 2021-03-03 15:03:24 -03:00
Vitor Vanacor
d9007d2ce6 Add sound notification for waiting guest
Both debounce or throttle could be used to prevent a spammer from
annoying the moderators.
With debounce, a spammer won't even be noticed by the mods, but
there won't be new notifications for legit guests during the spam.
With throttle, a spammer could still annoy the mods, we would only make
the interval between notifications bigger.
It is a tradeoff. An ideal solution would be preventing spamming from
the same user, but probably unnecessarily complex.
2021-03-03 15:03:00 -03:00
Fred Dixon
08e9ef77ad
Merge pull request #11539 from kepstin/doc-analytics-callback
Add some extra docs/setup instructions to the analytics callback script
2021-03-02 17:33:15 -04:00
Calvin Walton
48956ce63f Add some extra docs/setup instructions to the analytics callback script 2021-03-02 16:19:26 -05:00
Aron Engineer
391ce4d83d feat: BasicStatusCheck added for redis db, computation added to HeathActor 2021-03-02 20:49:02 +00:00
Anton Georgiev
abf9ed4063
Merge pull request #11538 from prlanzarin/u22-track1006022021
Improve permission checks for video, screen sharing and listen only
2021-03-02 15:46:33 -05:00
Anton Georgiev
6c238dd240
Merge pull request #11537 from antobinary/backport-11477
Update handleClick condition (fix text-area for FireFox)
2021-03-02 15:02:02 -05:00
KDSBrowne
ccf12c268e update handleClick condition (fix text-area for FireFox) 2021-03-02 14:55:51 -05:00
Anton Georgiev
eba2d0ab58
Merge pull request #11535 from pedrobmarin/etherpad-patch
Rework padIds and turn bbb-web pad aware
2021-03-02 14:48:34 -05:00
Anton Georgiev
9848672775
Bumped up copyright year to 2021. Closes #11519 2021-03-02 14:20:27 -05:00
Anton Georgiev
17fa7ffea3
Merge pull request #11514 from daminebenq/add-tests-recording-to-video
Adds tests recording + updates some outdated tests + linting
2021-03-02 12:00:05 -05:00
Anton Georgiev
24e41946b8
Bump to 2.2.34 2021-03-02 11:25:51 -05:00
hiroshisuga
b228d4cbb8
Probably a bug in usersVideo 2021-03-02 23:56:10 +09:00
Tainan Felipe
71e0ca9d92 Add sync and reconnection handler 2021-03-02 11:35:26 -03:00
Anton Georgiev
b69f526982
Bumped up version to 2.3.0-alpha8 2021-03-02 09:07:26 -05:00
Anton Georgiev
879c54981e
Merge pull request #11447 from antobinary/external-video-sync-lucas-amguirado73
External video events propagated through akka-apps
2021-03-02 08:53:09 -05:00
Ramon Souza
c1efb6e6b4 fix openPanel errors related to polling and shared notes 2021-03-02 09:36:44 -03:00
Mario Jr
8036ce71b1 Fix audio and push alerts for user join
When validating tokens, the dummyUser created at the beginning is set
with validated=true. This means there won't be the state change that used
to occur from validated:false to validated:true (which detects the moment
joined the meeting) , therefore the alert code that expects for this change
won't run.
To fix this for audio alerts, we now detect when user join by observing
additions in Users's collection. This is actually good because we start
observing this only once (in componentDidMount), differently we used to do,
by calling this every time the tracker was activated.

To distinguish between the user addition that initially populates user's
collection from those that happens after user join (which are the ones we
want), we store the initial state (at componentDidMount) and compare it
with new additions. If the user added is present at the initial state,
then it is an addition to populates the collection, otherwise this is a real
user addition (happened after user joined the meeting)

Partially fixes #11399
2021-03-02 08:43:56 -03:00
Anton Georgiev
1268663030 wrap collection modifiers in try-catch blocks 2021-03-02 00:44:49 +00:00
Mohamed Amine Ben Salah
8daa4443cb Merge remote-tracking branch 'upstream/develop' into add-tests-recording-to-video 2021-03-01 18:47:35 -03:00
Mohamed Amine Ben Salah
2c9d8e4380 updates and adds specifications for polling 2021-03-01 18:47:08 -03:00
Anton Georgiev
550bf6d282
Merge pull request #11525 from gustavotrott/develop
Adds lastAuthTokenValidatedOn to users
2021-03-01 13:56:16 -05:00
Anton Georgiev
f6147d4425
Merge pull request #11526 from ramonlsouza/issue-11354
Fix chat textarea resizing bug
2021-03-01 13:43:23 -05:00
Anton Georgiev
b6ead0baa4
Merge pull request #11524 from ramonlsouza/issue-11461
Fix chat messages timestamp
2021-03-01 13:37:59 -05:00
Ramon Souza
2dedf197e0 fix textarea resizing bug 2021-03-01 15:36:09 -03:00
Mohamed Amine Ben Salah
56cde60cb8 remove no-needed logging 2021-03-01 15:24:17 -03:00
Ramon Souza
984c3d515c fix chat messages timestamp 2021-03-01 14:21:54 -03:00
Anton Georgiev
0856599406
Merge pull request #11520 from mariogasparoni/fix-11511
Breakout room audio fixes
2021-03-01 11:42:33 -05:00
Anton Georgiev
6a72496864
Merge pull request #11523 from ramonlsouza/issue-11488
Fix mobile user removal bug
2021-03-01 10:30:53 -05:00
Ramon Souza
ba6e6c8238 remove unnecessary dependency 2021-03-01 09:07:06 -03:00
Mario Jr
de05622d19 Avoid setting an unknown input deviceId
Without 'exact' match, the browser fallbacks to the default inputDeviceId

This prevents the error (input device error)  when breakout is ended and we try
to skipCheck the microphone when user returns to main room (assuming the
user had the microphone active before joining breakout room). Related
to the feature c451666d52
2021-02-28 17:15:08 -03:00
Mario Jr
629b6c901c Do not join microphone when user is already in breakout
Fixes #11511
Related to the feature implemented in c451666d52
2021-02-28 17:13:10 -03:00
Anton Georgiev
2bf959c76a
Merge pull request #11516 from mariogasparoni/develop
Do not try to recover mute state when joining listenonly
2021-02-26 13:59:46 -05:00
Mario Jr
fc1401ab53 Do not try to recover mute state when joining listenonly
Prevent toggleMute api call to be called for listenonly
This has no effect to the end user, but avoids unnecessary server calls
2021-02-26 15:52:11 -03:00
Anton Georgiev
e70470e975
Merge pull request #11515 from mariogasparoni/fix-11490
Cleanup joinedAudioOnly state when user disconnects or reconnect microphone
2021-02-26 13:30:05 -05:00
Mario Jr
ad23e9c0af Cleanup joinedAudioOnly state when user disconnects or reconnect microphone
Fixes #11490
2021-02-26 15:05:17 -03:00
Mohamed Amine Ben Salah
11a82d1524
CI presettings: part 1 - set page.viewPort && export visual regressions testing media files (#11422)
* add viewPort to page.js

* clone and import media and visual regressions files to the right directories

* change repo link to official bbb-ci-test-resources.git

* remove execution of import-tests-ci-resources.sh from tests/puppeteer/run.sh

* updates the import directory of the ci testing files

* correct imported repo folder name
2021-02-26 12:49:52 -05:00
Anton Georgiev
d20479d7c4
Merge pull request #11493 from aron-2809/bbb-core-http-endpoint-wip
WIP: Http endpoint added for health check
2021-02-26 12:44:04 -05:00
Anton Georgiev
2856075bc2
Merge pull request #11510 from ramonlsouza/issue-11358
Fix breakout room timer sync
2021-02-26 11:45:58 -05:00
Mohamed Amine Ben Salah
4dc679d000 Adds tests recording + updates some outdated tests + linting 2021-02-26 12:52:17 -03:00
Fred Dixon
754473317e
Merge pull request #11512 from bigbluebutton/ffdixon-patch-5
Bump to 2.2.33
2021-02-26 10:32:16 -04:00