Commit Graph

30017 Commits

Author SHA1 Message Date
Anton Georgiev
de638cf852
Merge pull request #12731 from prlanzarin/u24-recosocket-fastnecting
build(deps): update reconnecting-websocket to 4.4.0 (bbb-html5)
2021-07-06 16:11:01 -04:00
Anton Georgiev
ef4c756a1e
Merge pull request #12733 from antobinary/merge-2.3.5-into-develop
chore: Merge 2.3.5, 2.3.6 into develop
2021-07-06 16:04:37 -04:00
Anton Georgiev
1fd6246336 Merge branch 'v2.3.x-release' of github.com:bigbluebutton/bigbluebutton into merge-2.3.5-into-develop 2021-07-06 19:37:30 +00:00
Anton Georgiev
b9cc633286 Merge branch 'v2.3.x-release' of github.com:bigbluebutton/bigbluebutton into merge-2.3.5-into-develop 2021-07-06 19:36:19 +00:00
prlanzarin
8a1aa8740d build(deps): update reconnecting-websocket to 4.4.0 (bbb-html5) 2021-07-06 19:09:02 +00:00
Anton Georgiev
29cd607ecd
Merge pull request #12694 from mariogasparoni/feat-add-device-button-selector
feat(audio): add a new button for selecting audio device
2021-07-06 12:04:18 -04:00
Anton Georgiev
5f9b084514
Merge pull request #12730 from mariogasparoni/fix-12048
fix(audio): prevent mute notification to be triggered when mic is locked
2021-07-06 11:13:39 -04:00
Mario Jr
06c7edbb0b fix(audio): prevent mute notification to be triggered when mic is locked
When mic is locked, user is not able to talk so it doesn't make sense
to alert the user about unmuting (mute button is also disabled when mic
is locked).

Closes #12048
2021-07-06 11:59:42 -03:00
Anton Georgiev
07c69a08f1
Updated BBB release to 2.3.6 2021-07-06 10:08:45 -04:00
Anton Georgiev
2814148488
Merge pull request #12728 from mariogasparoni/fix-skip-check-12705
fix(audio): mic not working when skipCheck=true
2021-07-06 10:03:55 -04:00
Mario Jr
bd610c2fd5 fix(audio): mic not working when skipCheck=true
Complements #12705
2021-07-06 10:27:48 -03:00
Anton Georgiev
12bb7b427f
Merge pull request #12726 from antobinary/dev24
Merge 2.4 into 'develop'
2021-07-05 16:26:54 -04:00
Mario Jr
e9ca202767 fix(audio): fix icon for device list selector
This complements #12694, which was initially made using an
existent font (which may vary it's size depending on OS/browser)

Added a new specific icon for the device icon selector

Thanks to @ramonlsouza who found this problem
2021-07-05 17:26:07 -03:00
Anton Georgiev
18ff46aa60
Merge pull request #12724 from jfsiebel/prevent-empty-loggedOut-leaving-message
Prevent loggedOut property to be undefined
2021-07-05 15:07:03 -04:00
Joao Siebel
2cda889d51 Previne loggedOut property to be undefined. close #12656 2021-07-05 16:04:26 -03:00
Pedro Beschorner Marin
6264caccd9
Merge pull request #12700 from prlanzarin/u24-gum-store
Webcams: reduce number of gUM calls, refactor in video-preview, fix #9053
2021-07-05 14:13:36 -03:00
prlanzarin
d8dae1ec90 fix(webcams): handle Firefox video stream cleanup edge case
Firefox doesnt fire the ended evt/onended callback for live video mediastreamtracks. That caused the stream storage to not run the cleanup procedure in some scenarios

Manually emit the ended event which works with the onended callback when a track is stopped
2021-07-05 16:26:24 +00:00
prlanzarin
60dd10510c fix(webcams): add fallback labels for devices in video-preview
In cases where fingerprinting protection is so adamant that we are
unable to get device labels

Fixes #9053
2021-07-05 16:03:30 +00:00
prlanzarin
0ddf02e954 refactor(webcams): improve skipVideoPreview handling, add error handling to it
Also organized video-preview a little better overall
2021-07-05 16:03:15 +00:00
Anton Georgiev
5f71d53348
Merge pull request #12721 from antobinary/12589
fix: Check for correct directory before deploying bbb-html5
2021-07-05 11:51:54 -04:00
Anton Georgiev
6ceae4dbbc check for correct directory before deploying bbb-html5 2021-07-05 15:44:21 +00:00
Anton Georgiev
3889cf1dc9
Merge pull request #12701 from paultrudel/fix-get-sessions-bbb-web
Freemarker Null Error Fix
2021-07-05 11:11:16 -04:00
Anton Georgiev
f1d88537be
Merge pull request #12715 from pedrobmarin/c-asbc
chore: add stale bot config
2021-07-05 11:10:14 -04:00
Anton Georgiev
28a9b827cd
Merge pull request #12718 from ramonlsouza/webcam-position-mobile
fix: layout issues on mobile with portrait presentation
2021-07-05 09:06:57 -04:00
Ramon Souza
2335105030 force webcam position: top for mobile devices 2021-07-05 09:56:09 -03:00
Anton Georgiev
61e131e0b4
Merge pull request #12717 from ramonlsouza/issue-12714
fix: client crash when userlist is hidden and viewer is ejected
2021-07-05 08:09:02 -04:00
Ramon Souza
3aa4855a6b fix client crash when viewers is ejected and userlist is hidden 2021-07-05 08:20:27 -03:00
Pedro Beschorner Marin
13e5b3f9ef chore: add stale bot config
> In an ideal world with infinite resources, there would be no need for
> this app.
>
> But in any successful software project, there's always more work to do
> than people to do it. As more and more work piles up, it becomes
> paralyzing. Just making decisions about what work should and shouldn't
> get done can exhaust all available resources. In the experience of the
> maintainers of this app—and the hundreds of other projects and
> organizations that use it—focusing on issues that are actively affecting
> humans is an effective method for prioritizing work.
>
> To some, a robot trying to close stale issues may seem inhospitable or
> offensive to contributors. But the alternative is to disrespect them by
> setting false expectations and implicitly ignoring their work. This app
> makes it explicit: if work is not progressing, then it's stale. A
> comment is all it takes to keep the conversation alive.

https://github.com/probot/stale#is-closing-stale-issues-really-a-good-idea

This file add the configuration needed for stale issues and pull requests
to be automatically closed. Defined as follows:

 - issues and pull requests with no activity for 270 days will be marked as "status: stale";
 - after that, there will be a period of 90 days for the issue or pull request to be claimed, otherwise will be closed.

The bot will never interact/close with issues and pull requests marked as:
 - status: vetify
 - status: accepted
 - target: security
 - type: discussion

For this setup to be effective, add https://probot.github.io/apps/stale/
to BigBlueButton repository.
2021-07-04 11:56:50 -03:00
Anton Georgiev
95f5b6faf9
BBB version is quite useful to know, would rather if it is not optional 2021-07-02 22:14:22 -04:00
Anton Georgiev
437255edf3
Merge pull request #12707 from antobinary/jul-2
Pulled HTML5 locales on July 2, 2021
2021-07-02 19:39:14 -04:00
Anton Georgiev
a5c4f67aec Pulled HTML5 locales on July 2, 2021 2021-07-02 23:36:54 +00:00
Anton Georgiev
0150862eb1
Merge pull request #12705 from mariogasparoni/feat-trickle-ice-mic
feat(audio): use kurento's trickle-ice to improve mic negotiation
2021-07-02 17:44:05 -04:00
Anton Georgiev
0457868e4b
Merge pull request #12703 from jfsiebel/hide-poll-response-for-viewers
fix: Filter poll data for moderator and viewers
2021-07-02 16:06:06 -04:00
Joao Siebel
65ff7bca6c Hide poll responses and number of votes for viewers in minimongo 2021-07-02 16:47:00 -03:00
Anton Georgiev
1b8fea89cd
Merge pull request #12607 from hiroshisuga/patch-35
Remove linefeed for polling option
2021-07-02 15:09:39 -04:00
Anton Georgiev
2d0e31cce4
Merge pull request #12702 from jfsiebel/prevent-add-connection-status-spam
Prevent addConnectionStatus log spam when not authenticated
2021-07-02 15:01:56 -04:00
Anton Georgiev
4bcf7c467d
Merge pull request #12674 from ramonlsouza/rm-unused-code
refactor: remove unused variables
2021-07-02 14:33:20 -04:00
Anton Georgiev
5026df6e1d
Merge pull request #12672 from ramonlsouza/polling-component-nlm
fix: polling component position - new LM
2021-07-02 14:32:11 -04:00
Anton Georgiev
213e0e4b3b
Merge pull request #12691 from ramonlsouza/reconnect-fix
fix: reconnection crash
2021-07-02 14:17:40 -04:00
prlanzarin
0453e9e842 fix(webcams): reduce number of gUM calls
Shave off the number of calls in video-preview and video-provider by
using a stream storage

We don´t call an upfront gUM in video-preview anymore to lift the
fingerprinting barrier on device labels and IDs. Flow has been reversed:
upfront enumerate, load first preview, then check if previous
enumeration was obfuscated.

Add a stream storage in video-preview`s service to avoid re-fetching
them in video-providerj

Remove some unneeded video-preview container props

Improve some of video-preview`s error locales
2021-07-02 16:13:31 +00:00
Mario Jr
c4abd274e8 feat(audio): add option for enabling/disabling kms's trickle for mic 2021-07-02 12:51:00 -03:00
paultrudel
5db8c769c2 fixed freemarker getSessions null error 2021-07-02 10:57:45 -04:00
Joao Siebel
14abe5c278 Prevent addConnectionStatus log spam 2021-07-02 11:51:01 -03:00
Ramon Souza
36c9176b3d always get token info from current connectionId 2021-07-02 10:33:17 -03:00
Mario Jr
287c4eb682 feat(audio): use kurento's trickle-ice to improve mic negotiation
Here's what we do when user activates mic:
1 - When we do something similar to listenonly's joining process
until we find a valid candidate-pair. The information about this
local candidate is store.
2 - We then start a new userAgent, and as soon as browser finds
a candidate with the same local ip address, we leave only this
candidate in the SDP and send this to FreeSWITCH. SDP should
contain only a single candidate.
3 - The rest of signaling process is basically the same.
2021-07-01 16:26:44 -03:00
Mario Jr
2801848789 chore(audio): update some code checks done by sonarcloud 2021-06-30 18:39:32 -03:00
Anton Georgiev
a53917e057
Merge pull request #12692 from germanocaumo/qp-maxcustom-23
fix(poll): Respect maxCustom property in quick-polls
2021-06-30 17:27:38 -04:00
Anton Georgiev
4a1e43cc7b
Merge pull request #12695 from antobinary/user-left
fix: removeUser - handle connections in frontends, db changes in backend
2021-06-30 17:06:50 -04:00
Anton Georgiev
b5851aa152 removeUser: handle connections in frontends, db changes in backend 2021-06-30 20:08:00 +00:00
Mario Jr
1890cccae1 Merge branch 'develop' into feat-add-device-button-selector 2021-06-30 14:56:32 -03:00