Commit Graph

42766 Commits

Author SHA1 Message Date
prlanzarin
dd1cf00dd2 feat: make guest policy optional for dial-in in akka-apps
Dial-in endpoints currently follow the same guest approval process as regular
users. While this is correct for default installations, it complicates the join
procedure in setups where approval is managed externally, such as with pre-
configured conference PIN codes. Another relevant scenario is when call
origination is done from BBB, rather than as an inbound call.

This commit makes the enforcement of the guest policy for dial-in/external
endpoints optional in akka-apps. The default behavior remains unchanged
(enforce). This provides more flexibility for the dial-in mechanism, allowing
for smoother handling of the scenarios mentioned above.
2024-08-23 14:54:31 +00:00
Gustavo Trott
f4749b0e96
Merge pull request #21003 from gustavotrott/webpack-fix
fix (html5-dev-server): Prevent HEAD requests from crashing webpack-dev-server
2024-08-22 18:17:18 -03:00
Átila
09f565d0ef
fix(darkmode): fix avatar username color in chat when dark mode is enabled (#20999) 2024-08-22 15:01:35 -03:00
Gustavo Trott
e93388a6a2 prevent HEAD request from crashing webpack-dev-server 2024-08-22 10:44:08 -03:00
Paulo Lanzarin
f0738c8afb
Merge pull request #20997 from bigbluebutton/bbb30sfu2142
build(bbb-webrtc-sfu): v2.14.2
2024-08-21 20:28:08 -03:00
André Castro
635045ec84
Fix: Errors and warnings (#20994)
* The prop presentationIsOpen is marked as required in Presentation(null)

* The prop isPresentationManagementDisabled is marked as required in actions-dropdown(null)

* The prop autoJoin is marked as required in wake-lock(null)

* Al children must have key identifiers (userListParticipants)

* The prop presentationUploadExternalDescription is marked as required in presentation-uploadres
2024-08-21 17:22:54 -03:00
Paulo Lanzarin
3bdec18e17
build(bbb-webrtc-sfu): v2.14.2
v2.14.2
---
* refactor(audio): set FLOWING logs to INFO level
* build(mediasoup): v3.14.11
2024-08-21 16:16:30 -03:00
Átila
c48e93e00c
feat(darklogo): port customDarkLogo (#20922) 2024-08-21 14:58:32 -03:00
KDSBrowne
4ca3084db5
fix mouse wheel zoom not working on other pages (#20680) 2024-08-21 14:57:41 -03:00
Tainan Felipe
ba32e21c0f
Add: Local history of rtt status changes (#20983)
* Change: Add local history of rtt status changes
2024-08-21 10:05:37 -03:00
Paulo Lanzarin
80e71d619e
Merge pull request #20987 from bigbluebutton/sfu2141-msad
feat(audio): dedicate mediasoup workers for audio streams
2024-08-21 09:53:25 -03:00
Ramón Souza
07e79af097
new svg icon for reactions button (#20979) 2024-08-21 08:28:06 -03:00
Tainan Felipe
6597b41a8b
Add: store volume settings to preserve between player refresh (#20986) 2024-08-20 17:22:46 -03:00
Paulo Lanzarin
89209fc7ee
feat(audio): dedicate mediasoup workers for audio streams
mediasoup workers are currently for general use,
regardless of stream type. This makes it difficult to give
different scheduling priorities for audio workers or prevent
noise from video streams, when our goal is to give higher
priority to audio in all ends of the system.

Set `mediasoup.dedicatedMediaTypeWorkers.audio` to `auto`. This will spin up 
`ceil((min(nproc, 32) * 0.8) + (max(0, nproc - 32))` mediasoup workers 
dedicated to handling audio streams.
2024-08-20 15:06:32 -03:00
João Victor Nunes
3ad9aafd7b
fix: userdata-force_restore_presentation_on_new_events (#20974) 2024-08-20 13:29:04 -03:00
Paulo Lanzarin
a0fb450522
Merge pull request #20978 from prlanzarin/u30/fix/audio-ff-perm-api
fix(audio): ensure correct audio device labels in Firefox
2024-08-20 12:21:29 -03:00
Paulo Lanzarin
1cd6edf9ac
Merge pull request #20977 from prlanzarin/u30/fix/did-output
fix(audio): ensure current I/O devices are flagged as selected
2024-08-20 09:45:42 -03:00
prlanzarin
b9f66c2a10 fix(audio): ensure correct audio device labels in Firefox
Firefox incorretly displays placeholder audio device labels in the audio
settings/echo test modal when audio is disconnected. This issue arises
due to two quirks:
- Firefox does not support the 'microphone' query from the Permissions
  API, causing a fallback gUM permission check.
- Firefox omits device labels from `enumerateDevices` if no streams
  are active, even if gUM permission is granted. This behavior differs
  from other browsers and causes our `enumerateDevices` handling to
  assume that granted permission implies labels are present. This
  failed since we clear streams before resolving the fallback gUM.

We now run an additional `enumerateDevices` call in `AudioSettings` when
a selected input device is defined. This ensures `enumerateDevices` is
re-run when a new stream is active, adding the correct device labels in
Firefox and improving device listings in all browsers. We've also
enhanced error handling in the enumeration process and fixed a false
positive in `hasMicrophonePermission`.
2024-08-20 00:43:24 +00:00
prlanzarin
c055caf915 fix(audio): ensure current I/O devices are flagged as selected
There's a regression in 3.0's I/O device selector where default output
devices are not marked as selected in the input-stream-live-selector
component unless the user explicitly selects them. This issue can also affect
input devices, although less commonly than output due to the system's ability
to infer the selected input device ID after the user joins audio.

When a device is the first in the list and no currentDeviceId is set in
the client, treat the first device returned by enumerateDevices as the
system default and hence selected, in accordance with the "Media Capture
and Streams API", Section 9.2, enumerateDevices algorithm.
2024-08-19 21:35:12 +00:00
Anton Barboza de Sá
c60ca2313b
test: Ask for feedback on logout test improvement + button display and action fixes (#20872)
* test: update and improve Ask for feedback on logout test - add more steps, check for different buttons, check POST request after sending feedback

* test: add missing data-test prop for sendFeendbackButton

* test: fix sendFeedbackButton data-test
2024-08-19 17:06:59 -03:00
Paulo Lanzarin
a2e2f28aba
Merge pull request #20963 from prlanzarin/u30/fix/tlo-f2
fix(audio): close dialog when "Cancel" is clicked with listenOnlyMode=false
2024-08-19 16:50:44 -03:00
Ramón Souza
91b5b7cb5f
Merge pull request #20937 from Tainan404/fix-connection-status
Fix: connection status issues
2024-08-19 16:24:05 -03:00
Ramón Souza
ddfba135a6
Merge pull request #20962 from Scroody/i-20817
Fix: Even number of emoji clicks hide who the sender was
2024-08-19 15:10:30 -03:00
Gustavo Trott
09cc37feef
refactor (gql-middleware): Code improvements and new Prometheus metrics (#20896) 2024-08-19 10:58:14 -03:00
Ramón Souza
af644be16b
Merge pull request #20953 from prlanzarin/u30/fix/plg-load-log
fix: use logger convention in plugin startup logs
2024-08-19 08:58:23 -03:00
Paulo Lanzarin
2e87bf2123
Merge pull request #20948 from prlanzarin/u30/fix/prescam-loadingstate
fix(screenshare): actions-bar loading state reacts to camera as content
2024-08-16 16:58:50 -03:00
André Castro
62fe6ed18c
Update component.jsx 2024-08-16 13:31:25 -03:00
prlanzarin
135350b6dc fix(audio): close dialog when "Cancel" is clicked with listenOnlyMode=false
When `listenOnlyMode` is `false` and the audio dialog's "Cancel" action is
clicked, the modal incorrectly re-renders instead of closing. Additionally,
the "Cancel" action is mislabeled as "Back."

This fix ensures the audio dialog closes properly when there are no options
to select (i.e., `listenOnlyMode=false`). The `skipAudioOptions` method is
revised to consider `listenOnlyMode` and ignore the "content" state.

Ignoring the "content" state allows options to be skipped even if a subscreen
is rendered (e.g., returning from the AudioSettings modal). The check for
`content == null` combined with `skipAudioOptions` is only necessary when
rendering the main modal. The `content == null` check has been moved to
the relevant section.
2024-08-16 15:48:47 +00:00
André Möller
6bbe3d4baa Fix: Even number of emoji clicks hide who the sender was 2024-08-16 11:52:40 -03:00
Ramón Souza
0a38236f94
Merge pull request #20873 from Arthurk12/presentation-last-state
fix(presentation): restore last state after sharing media
2024-08-16 10:48:11 -03:00
Ramón Souza
7c62352079
Merge pull request #20958 from JoVictorNunes/pure-voice-activity-hooks
fix: prevent the whole client from rerendering on voice activity
2024-08-16 09:47:57 -03:00
Paulo Lanzarin
5414372f8d
Merge pull request #20960 from prlanzarin/u30/fix/tlo-f1
fix(audio): prevent spurious mute toggle due to AudioSettings remount
2024-08-16 09:47:27 -03:00
prlanzarin
9040cb86cb fix(audio): prevent spurious mute toggle due to AudioSettings remount
When listen only mode is deactivated and an user joins audio, an incorrect
remount of AudioSettings can trigger a spurious mute toggle. This happens
because AudioManager clears the `isConnecting` flag before setting the
`isConnected` flag. This creates a brief period where audio is flagged as
"disconnected," leading to a remount and unmount cycle that causes unwanted
mute/unmute actions due to AudioSettings' logic of muting/unmuting
active devices.

Ensure the `isConnected` flag is set before clearing the
`isConnecting` flag, preventing audio from being incorrectly flagged as
disconnected.
2024-08-16 01:51:10 +00:00
Paulo Lanzarin
2639600e1d
Merge pull request #20957 from bigbluebutton/sfu2141
build(bbb-webrtc-sfu): v2.14.1
2024-08-15 17:04:53 -03:00
Paulo Lanzarin
a152cc45c5
build(bbb-webrtc-sfu): v2.14.1
v2.14.1
---
* fix(screenshare): log presenter/viewer stop on all scenarios
* refactor(screenshare): add presenter data to viewer logs
* refactor(video): add video negotiation and flowing logs
* build(mediasoup): 3.14.9
2024-08-15 16:42:48 -03:00
Ramón Souza
39d68e4156
Merge pull request #20782 from prlanzarin/u30/feat/tlo-ui-rebased250724
feat(audio): rework audio join UI for transparentListenOnly
2024-08-15 16:38:35 -03:00
Arthurk12
a9c8fd7051 fix(screenshare): removes redundant presentation restore
Removes redundant presentation restore code since the presentation restore
is executed by the layout context when updating the presentation pile.
2024-08-15 14:47:26 -03:00
Arthurk12
9c5a02c18b fix(presentation): update state only for presentation
Prevents changes in the presentation state while sharing media from
updating the presentation last state value. Additionally adds a missing
prop value of generic content state.
2024-08-15 14:47:26 -03:00
Arthurk12
160af41165 fix(layout): restore last presentation state
Restores the last presentation state after sharing media.
2024-08-15 14:47:26 -03:00
Arthurk12
6688866fbd fix(presentation): check for changes
Prevents `undefined` values for `presentationId` from causing false
positives that trigger the presentation restore routine.
2024-08-15 14:47:25 -03:00
Arthurk12
cd9e178161 fix(external-video): remove duplicate presentation pile dispatch
Removes the duplicate presentation pile dispatch for external video, as
an identical dispatch runs when the external video component is mounted.
This duplication did not cause any noticeable issues for the user but
resulted in the external video being added to the pile twice.
2024-08-15 14:47:25 -03:00
prlanzarin
abd6f7fea1 fix: use logger convention in plugin startup logs
The plugin loader startup logs aren't following the logger convention,
which makes them hard to work with when post-processing logs.
The appended error message is also not useful since we're logging a
Event variant raw (which either outputs {} or nonsense like { isTrusted:
etc }).

Make the plugin "loaded" and "error" logs adhere to logger conventions.
In the future, the error log could use some tuning - there's no useful
info about root cause here.
2024-08-15 15:54:06 +00:00
Ramón Souza
4227827165
fix feedback screen (#20949) 2024-08-15 11:58:19 -03:00
André Castro
a704c58dee
Fix: [3.0] Audio autoplay button is visually broken (#20950) 2024-08-15 11:18:56 -03:00
Ramón Souza
23e8e01871
fix: allowModsToUnmuteUsers param not working (#20888)
* fix unmute user feature
2024-08-15 11:10:08 -03:00
João Victor
2b6e4b584e fix(voice): reorganize askForConfirmationOnLeave code
- Move askForConfirmationOnLeave into AudioContainer
- Get rid of the unstable useMuteMicrophone hook, which returns a new reference every time the user gets muted/unmuted. Use the stable useToggleVoice hook instead.
2024-08-15 10:34:16 -03:00
prlanzarin
38b568b0c7 fix(screenshare): actions-bar loading state reacts to camera as content
The isSharing var is content type agnostic, so it's picking up camera as
content to flag the actions-bar button loading state.

Change the loading flag to track isScreenBroadcasting
(contentType=screen, local || global) and isScreenGloballyBroadcasting
(contentType=screen, global only). Fixes the camera as content false
positive as well as the loading state itself.
2024-08-15 13:09:40 +00:00
João Victor
b2adf9ad15 fix(voice): keep voice activity hooks pure by skipping state update when applicable 2024-08-15 09:13:12 -03:00
prlanzarin
381718a353 fix(audio): unmute when going from "no mic" -> mic via unmute trigger, +
When going from "no mic" -> mic via the unmute action, the client isn't
unmuting itself after confirming the change. This is caused by not
waiting the liveChangeInputDevice method (which is a Promise) to be
fully executed before unmounting the AudioSettings modal -- the one
responsible for triggering the unmute. Since it unmounts before the
device is changed, the unmute action will be ignored because the device
is still "listen-only" (no mic).

Properly unmute audio when transitioning from "no mic" -> "mic" via the
unmute trigger by waiting for liveChangeInputDevice to resolve.
Additionally, some general improvements to UI/UX:
  - Display the AudioSettings modal title when gUM is on prompt mode
  - Add specific subtitles to the AudioSettings modal to 1) warn that no
    mic is selected 2) Give a hint that the user can test their devices
  - Always honor settings.yml's "initialHearingState" state (whether
    local echo feedback should be played by default in AudioSettings)
2024-08-15 03:30:18 +00:00
prlanzarin
120bef5cc1 refactor(audio): improve audio settings' UI
We are missing a way to select transcription languages in some
scenarios, e.g.: listenOnlyMode=false. The audio settings UI is also not
handling item disposition very well on smaller devices.

This commit does the following to improve those blind spots:
  - Add the transcription language selector to it whenever applicable
  - Add proper styling to the transcription selector
  - Handle small screens by changing the disposition of elements to
    portrait mode
  - Improve how elements are disposed to a more familiar view: Mic ->
    Activity Indicator; Speaker -> Speaker test. This is more in line
    with how other platforms do audio configuration/pre flight screens.
2024-08-15 00:43:37 +00:00