Commit Graph

924 Commits

Author SHA1 Message Date
Paulo Lanzarin
e1dc4b55e4
fix(bbb-html5): customHeartbeat would not close stale sessions, + (#19017)
* fix(bbb-html5): customHeartbeat would not close stale sessions, +

The [disabled by default] custom heartbeat included in Meteor's server
does not end connections when they are considered unhealthy/stale, which
deviates a bit from the default implementation. See:
https://github.com/bigbluebutton/bigbluebutton/pull/11486.

This commit includes a call to the default heartbeat termination timeout
so sockets are correctly cleaned up when the custom heartbeat is
activated. It also adds a customHeartbeatUseDataFrames config to allow
controlling whether the custom heartbeat should use WS data frames as
valid heartbeats as well - this should only be useful for
testing/debugging purposes and the default behavior (true) is
maintained.

As a side note: this change spun off from an investigation where some
problematic networks were triggering periodic client re-connects due to
the default heartbeat failing. Investigation points to the control
frames being put alongside fragmented WS data frames and the server side
failing to recognize the former - which means pong frames would be missed and
the health check would fail. Since the default heartbeat _does not_
account for data frame traffic (eg DDP payloads), it would shut down the
client's WS even though it was healthy.
The custom heartbeat _does_ account for data frames, which mitigates
that scenario and prevents unecessary reconnections.

* fix(bbb-html5): frontend crash due to undefined vars in customHeartbeat 

Meteor frontends may crash when customHeartbeat is enabled
due to an undefined access in the heartbeat`s logger.

Add optional chaining to the session props access so it won`t crash and tune down some log levels around that area.
2024-01-22 11:10:41 -05:00
Ramón Souza
8495777d5b feat: join param for default animations setting value 2024-01-15 11:59:40 -03:00
Lucas
125d70699b
feat: Initial implementation of Gladia transcriptions to BBB 2.7 (#19091)
* Demo changes

* Revert "feat(captions): no longer writes in the pad"

This reverts commit a76de8c458.

* feat(transcriptoin): Add config options for the transcription backend

* feat(transcription): Add autodetect option to cc chevron

* feat(transcription): Move transcription options into settings modal

* feat(transcription): Set transcription options via userdata

* fix(transcription): Correct userdata for settings transcription params

* feat(transcriptions): options to auto enable caption button

* feat(transcriptions): Option to hide old CC pad funcionality

* fix(transcription): Fix PR comments

* fix(transcription): Refactor updateTranscript to prevent null user and make it more readable

* feat(transcription): bbb_transcription_provider can be set via userdata

* fix(transcription): Use base10 for parseInt

* fix(transcriptions): Fix CC language divider when using webspeech

* fix(transcriptions): Use a default pad in the settings instead of hardcoding 'en'

We still need to use a language pad such as 'en', but in the future we can better
separate these systems.

* fix(transcription): Add a special permission for automatic transcription updates to the pad and restore old per user updates permission

* feature(transcriptions): Include transcriptions submenu and locales

* chore: bump bbb-transcription-controller to v0.2.0

* fix(transcription): Add missing menu files

* fix(transcription): Fix transcription provider options in settings.yml

* fix: setting password for bbb-transcription-controller

* build: add gladia-proxy.log for transcription-controller

* fix(transcriptions): Remove transcript splitting and floor logic from akka apps

* fix(captions): Show long utterances as split captions, show multiple speaker captions

* chore: bump bbb-transcription-controller to 0.2.1

---------

Co-authored-by: Anton Georgiev <anto.georgiev@gmail.com>
2023-11-30 10:10:36 -05:00
Anton Georgiev
7c91d4ff73 Merge remote-tracking branch 'bbb/v2.6.x-release' into merge-july12 2023-07-12 16:20:53 -04:00
Daniel Schreiber
67a491f07c Fix: use connection id to determine if a user is ejected or not
It used to be a boolean value which was durable if the server is
configured to use localStorage for bbb client settings. This would lead
to permanently blocking a user for all future BBB sessions.

To prevent that we use the connectionID to determine if a user is
blocked or not. If a user rejoins (in the same or a different meeting),
the connectionID is different, so the user can join again.
2023-07-11 15:00:24 +02:00
Anton Georgiev
ec2ad5ed45 chore: upgrade NodeJS to 18 2023-06-13 12:08:58 -04:00
Anton Georgiev
72c575b911 Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into merge-apr-6 2023-04-06 11:50:26 -04:00
Ramón Souza
bcd504b749 Merge remote-tracking branch 'upstream/v2.7.x-release' into lodash-radash 2023-04-05 09:42:05 -03:00
Carlos
39b308b91f fix(reconnect) waiting for approval
Removed code that enter the old status "waiting for approval".
2023-04-04 10:47:32 -03:00
Ramón Souza
014dfa2670 adjust defaultsDeep merge 2023-03-01 16:48:08 -03:00
Ramón Souza
aa47aaa22a replace lodash merge and mergeWith 2023-03-01 11:52:39 -03:00
imdt
4abc29f9c5 Fixed: Notification for ejected users now delivered. 2023-02-27 11:51:08 -03:00
Ramón Souza
ba9c414989 replace lodash isEqual and isEmpty 2023-02-23 10:27:16 -03:00
Ramón Souza
8315abc2c0 replace lodash find and isArray 2023-02-21 10:14:56 -03:00
André Castro
826fad1f84
Update bigbluebutton-html5/imports/startup/client/base.jsx
Co-authored-by: Anton Georgiev <antobinary@users.noreply.github.com>
2023-02-17 15:31:19 -03:00
imdt
ac8c33c3b0 Notification of: You have been removed from the conference. fixed. 2023-02-17 15:15:39 -03:00
GuiLeme
8af6c547f2 [issue-16284] - Changes in review 2023-01-20 08:44:21 -03:00
GuiLeme
6f5053d492 [issue-16284] - Changes in review 2023-01-19 11:32:00 -03:00
GuiLeme
7bb03551b1 [issue-16284] - changed behavior of not showing anything when user is moved out a breakout 2023-01-19 09:21:28 -03:00
GuiLeme
2e0a85f268 [issue-16284] - tweaked minor problems and fixed blue screen when changing breakout rooms 2023-01-17 11:30:25 -03:00
Ramón Souza
d20079e7b9 fix closed chat on join 2022-11-30 15:32:47 -03:00
Tainan Felipe
b06da1017a Fix client reconnection after meeting end 2022-11-17 15:59:13 -03:00
Ramón Souza
8d0316ed31
Merge pull request #15747 from JoVictorNunes/issue-15713
improvement: add internationalization singleton
2022-10-28 13:24:03 -03:00
Ramón Souza
8ed142a522 Merge remote-tracking branch 'upstream/v2.5.x-release' into merge-258-26 2022-10-21 14:43:23 -03:00
Ramón Souza
8968f1c91a
Merge pull request #15845 from JoVictorNunes/improved-error-screen-messages-backport
[2.5] improvement: error screen messages and logs
2022-10-17 14:24:56 -03:00
Joao Victor
d628131e64 improvement: error screen messages and logs 2022-10-14 14:47:27 -03:00
Ramón Souza
5b274add16
Merge pull request #15777 from germanocaumo/dup-ann-ws-fix-25
chore(whiteboard): backport of annotations dupplication fix
2022-10-14 13:54:45 -03:00
Ramón Souza
38a4c3eae7 remove empty object in logs 2022-10-14 10:36:24 -03:00
Joao Victor
4391d762e8 add missing condition 2022-10-07 16:43:34 -03:00
Joao Victor
ec837a1744 remove console.log 2022-10-07 16:22:35 -03:00
Joao Victor
e4f5317009 fix: unauthenticated user handling and manual disconnection 2022-10-07 16:21:43 -03:00
Joao Victor
010f1c2964 tweak userLeaving and Base 2022-10-07 10:38:50 -03:00
Joao Victor
45199cb6eb fix: stringify all codeError's 2022-10-07 09:18:07 -03:00
Joao Victor
912b7cf70c improvement: add setExitReason method 2022-10-07 09:15:00 -03:00
Joao Victor
7e8cee7340 improvement: error screen messages 2022-10-05 11:30:12 -03:00
germanocaumo
3ecf79cc4f fix(whiteboard): only call annotation upsert in one frontend instance
We were calling upsert in the Annotations collection for the same annotation in all frontend instances, this could lead to the same annotation being inserted
multiple times with different ids due to concurrency.

Added the html5InstanceId of the original request to the redis message so we can use it to only call upsert in one instance.
2022-10-04 10:28:36 +00:00
Ramón Souza
077592df18
Merge pull request #15745 from germanocaumo/dup-ann-ws-fix
fix(whiteboard): annotations duplication in websocket/collection
2022-10-03 15:10:59 -03:00
Ramón Souza
4b4afb6916 remove empty object in logs 2022-10-03 13:48:00 -03:00
João Victor Nunes
19b28de056
Merge branch 'v2.6.x-release' into issue-15713 2022-09-29 10:49:17 -03:00
Ramón Souza
6963bc0db4 Merge remote-tracking branch 'upstream/v2.6.x-release' into add-locale-format 2022-09-28 14:32:01 -03:00
Joao Victor
f8279ab5b4 improvement: add internationalization singleton 2022-09-28 13:48:27 -03:00
germanocaumo
d770a7df8c fix(whiteboard): only call annotation upsert in one frontend instance
We were calling upsert in the Annotations collection for the same annotation in all frontend instances, this could lead to the same annotation being inserted
multiple times with different ids due to concurrency.

Added the html5InstanceId of the original request to the redis message so we can use it to only call upsert in one instance.
2022-09-28 12:03:59 +00:00
Ramón Souza
ab50d4d60e add settings 2022-09-16 13:01:07 -03:00
Ramón Souza
83c9e644b1 add settings 2022-09-16 11:56:56 -03:00
Ramón Souza
706014430c change server name format and add timestamp to logs 2022-09-16 11:09:21 -03:00
Ramón Souza
485103ff93 include server role and instance in logs 2022-09-16 11:09:12 -03:00
Ramón Souza
7bb26b64ff add server health log 2022-09-16 11:09:04 -03:00
Ramón Souza
774da00d16 change server name format and add timestamp to logs 2022-09-16 10:48:21 -03:00
Ramón Souza
facae4e2fb include server role and instance in logs 2022-09-15 16:57:20 -03:00
Ramón Souza
f6642bd2a8 add server health log 2022-09-15 16:56:00 -03:00