Commit Graph

10779 Commits

Author SHA1 Message Date
Anton Georgiev
afc9795c5b
Merge pull request #13785 from ramonlsouza/issue-13760
increase sidebar-content max width value
2021-11-30 09:40:45 -05:00
Ramón Souza
b8e7641403 increase sidebar-content max width value 2021-11-30 14:07:30 +00:00
Ramón Souza
77e645ae22 catch uploader filename error to prevent client crash 2021-11-30 12:18:44 +00:00
Ramón Souza
a077ae0dae prevent undefined length error 2021-11-30 11:45:57 +00:00
Anton Georgiev
872c1ae297
Merge pull request #13776 from ramonlsouza/issue-13761
fix: waiting room ui regression
2021-11-29 16:25:43 -05:00
Anton Georgiev
5bdf2b86ac
Merge pull request #13763 from ramonlsouza/poll-response-leak
fix: prevent poll response leak
2021-11-29 13:58:04 -05:00
Ramón Souza
69b7564e7f fix waiting room ui regression 2021-11-29 16:51:13 +00:00
KDSBrowne
e86740becc update guest lobby title string 2021-11-29 14:48:51 +00:00
Ramón Souza
304c16c519 remove voiceUsers data on leave 2021-11-29 13:59:21 +00:00
Ramón Souza
9a078b1bd6 remove previous connections auth-token-validation data 2021-11-29 13:50:31 +00:00
Ramón Souza
50546934c9 remove user persistent-data from collection on leave 2021-11-29 13:34:09 +00:00
Gustavo Trott
fed7b366bf Remove button to Share Dashboard link 2021-11-26 15:50:33 -03:00
Ramón Souza
69689646b7 prevent poll response leak 2021-11-26 17:02:06 +00:00
Anton Georgiev
60c1339a1f
Merge pull request #13757 from ramonlsouza/typed-poll-single-answer
fix: prevent users from being able to send more than one typed poll answer
2021-11-26 10:24:47 -05:00
Pedro Beschorner Marin
958376c5d4 style(button): relative positioning 2021-11-26 14:08:31 +00:00
Arthur B. Grossi
5cc42cf0c5 refactor(layout): chevron button margin
Adds margin to chevron button to increase distinction between buttons
2021-11-26 13:50:13 +00:00
Max Franke
32aa4349b0 feat(video): remove video button warning
Changes the EmojiButton implementation on videoButton to not be a descendant
of <button>, avoiding the warning.
2021-11-26 13:43:07 +00:00
prlanzarin
fc01544d87 fix(webcams): disable webcam selector and always open video-preview in mobile envs 2021-11-26 13:19:20 +00:00
prlanzarin
23c49902a0 fix(webcams): always unshare cameras if video selector is active 2021-11-26 13:14:40 +00:00
Mario Jr
54bda21287 chore(video): change default setting to enable webcam's button selector
Renamed this setting and added some docs about it
Complements #979
2021-11-26 13:12:07 +00:00
prlanzarin
143ea132b9 refactor(webcams): remove video preview cancel/confirm/something button
Another round of experimentation with that button.

Removing it due to its role being already contemplated by two other actions in the modal: clicking outside and the X icon

Will have to see how this is received in internal testing
2021-11-26 13:01:17 +00:00
Max Franke
9ce58c38e7 fix(video): 'stop all' button shows when webcam = 1
Add a condition that, if the user has more than 1 camera and
not is on mobile, shows the 'stop all' button.
2021-11-26 12:58:53 +00:00
Max Franke
310add10ed feat(webcam): add a little button to webcam button
Add the <ButtonEmoji/> to the webcam button. Now it
is possible to change the webcam settings and change
your settings without having to turn off sharing.
Modifies the <ButtonEmoji/> component so that it can
receive an onClick per props.
It is possible to disable this feat in the settings.yml
2021-11-26 12:53:11 +00:00
Anton Georgiev
9d2099fff7
Merge pull request #13748 from Tainan404/fix-server-side-disconnection-24
fix: Fix server side connection close on user disconnection
2021-11-25 16:00:37 -05:00
Ramón Souza
30f6a642dd prevent users from being able to send more than one typed poll answer 2021-11-25 17:51:36 +00:00
Anton Georgiev
26336586af
Merge pull request #13753 from JoVictorNunes/issue-13750
fix: settings state
2021-11-25 12:26:07 -05:00
João Victor
0a80af51d9 fix: settings state restore 2021-11-25 10:22:53 -03:00
Ramón Souza
4b1f1594b1 replace arrays in configuration override 2021-11-24 17:09:06 +00:00
Tainan Felipe
24ae9d3628 Fix server side connection close on user disconnection 2021-11-23 17:45:49 -03:00
Localization Server
51617f099e chore: Pulled the latest 2.4 HTML5 locales from Transifex 2021-11-23 16:01:53 +00:00
Anton Georgiev
2b352183ac
Merge pull request #13738 from schrd/poll-a11y-fix
fix: [a11y] Make poll question navigatable
2021-11-22 15:12:40 -05:00
Daniel Schreiber
caf1eb5431 fix: [a11y] Make poll question navigatable
It is currently difficult for screen reader users to directly navigate
to poll options. I spoke to a screen reader user, he suggested to make
the poll question title a h2 element so users can directly jump to it.
2021-11-22 19:35:57 +01:00
Ramón Souza
2f7fb0bf8e fix resize handle/scrollbar overlap in userlist 2021-11-22 18:14:03 +00:00
Anton Georgiev
19f9489e47
Merge pull request #13733 from ramonlsouza/issue-13730
fix: webcam alignment in RTL languages - smart layout
2021-11-22 09:42:38 -05:00
Ramón Souza
c43991e6b5 fix cameras margin RTL - smart layout 2021-11-22 11:58:35 +00:00
KDSBrowne
e184912311 prevent properties of undefined (reading 'toUpperCase') 2021-11-22 00:55:51 +00:00
Daniel Schreiber
c46556e1f6 Allow BBB to run behind a proxy the avoid gUM permission queries per node
The idea is to run a loadbalancer node which maps each BBB node to a
path. That way each user gets only one gUM permission query for a
cluster. The loadbalancer node only serves the html5 client, each BBB
node will serve its own API and handle the websockets for freeswitch and
bbb-webrtc-sfu.

Configuring a cluster setup
===========================

* let bbb-lb.example.com be the loadbalancer node
* let bbb-01.eaxmple.com be a BBB node

Loadbalancer
------------

On the loadbalancer node add an nginx configuration similar to this one
for each BBB node:

```
location /bbb-01/html5client/ {
  proxy_pass https://bbb-01.example.com/bbb-01/html5client/;
  proxy_http_version 1.1;
  proxy_set_header Upgrade $http_upgrade;
  proxy_set_header Connection "Upgrade";
}

```

BBB Node
--------

On the BBB node add the following options to
`/etc/bigbluebutton/bbb-web.properties`:

```
defaultHTML5ClientUrl=https://bbb-lb.example.com/bbb-01/html5client/join
presentationBaseURL=https://bbb-01.example.com/bigbluebutton/presentation
accessControlAllowOrigin=https://bbb-lb.example.com
```

Add the following options to `/etc/bigbluebutton/bbb-html5.yml`:

```
public:
  app:
    basename: '/bbb-01/html5client'
    bbbWebBase: 'https://bbb-01.eaxmple.com/bigbluebutton'
    learningDashboardBase: 'https://bbb-01.eaxmple.com/learning-dashboard'
  media:
    stunTurnServersFetchAddress: 'https://bbb-01.eaxmple.com/bigbluebutton/api/stuns'
    sip_ws_host: 'bbb-01.eaxmple.com'
  presentation:
    uploadEndpoint: 'https://bbb-01.eaxmple.com/bigbluebutton/presentation/upload'
```

Create the following unit file overrides:

* `/etc/systemd/system/bbb-html5-frontend@.service.d/cluster.conf`
* `/etc/systemd/system/bbb-html5-backend@.service.d/cluster.conf`

with the following content:

```
[Service]
Environment=ROOT_URL=https://127.0.0.1/bbb-01/html5client
```

Change the nginx `$bbb_loadbalancer_node` variable to the name of the
load balancer node in `/etc/bigbluebutton/nginx/loadbalancer.nginx` to
allow CORS requests:

```
set $bbb_loadbalancer_node https://bbb-lb.example.com
```

Prepend the mount point of bbb-html5 in all location sections except
from the `location @html5client` section in
`/etc/bigbluebutton/nginx/bbb-html5.nginx`

```
location @html5client {
    ...
}
location /bbb-01/html5client/locales {
    ...
}
```
2021-11-20 22:13:47 +01:00
Anton Georgiev
e694c84fa4
Merge pull request #13719 from MaximKhlobystov/fix-push-layout
Fix for pushing layout: attempting to push while already using chosen layout locally
2021-11-19 16:10:46 -05:00
Anton Georgiev
a90faddfa0
Merge pull request #13726 from ramonlsouza/23fullscreen
Restore 2.3 fullscreen style
2021-11-19 16:03:34 -05:00
Anton Georgiev
ea4638388d
Merge pull request #13724 from Arthurk12/ff-panel-resize
fix(layout): unable resize side panel
2021-11-19 15:22:43 -05:00
Anton Georgiev
5162b4c403
Merge pull request #13679 from JoVictorNunes/issue-13241
fix: virtual background not kept when switching from breakout to main room
2021-11-19 15:11:21 -05:00
Ramón Souza
4121f61a59 restore 2.3 fullscreen 2021-11-19 19:26:04 +00:00
prlanzarin
3eb760e0b2 chore(webcams): cleanup unused vars in video-preview container 2021-11-19 19:03:36 +00:00
Arthurk12
96965ebeed fix(layout): unable resize side panel
Sets z-index attribute to screenshare component, only when it is in
fullscreen mode. This is the same way it is done for presentation
component.
2021-11-19 18:51:42 +00:00
prlanzarin
13eb9fe702 refactor(webcams): re-use lock check from video-provider in video-preview 2021-11-19 18:23:17 +00:00
Maxim Khlobystov
cb2a091b76 Make sure that the layout gets pushed when the chosen layout matches the current local one 2021-11-19 14:36:06 +00:00
João Victor
6524f70941 support for storing multiple virtual backgrounds 2021-11-19 08:10:24 -03:00
Anton Georgiev
370d2803d9
Merge pull request #13690 from JoVictorNunes/issue-13665
fix: hidden content in waiting users component
2021-11-17 11:21:37 -05:00
Joao Victor
c85ede6734 fix: hidden content in waiting users component 2021-11-12 15:22:53 -03:00
Ramón Souza
9ee4975e7f fix minimize presentation focus on presentation layout 2021-11-12 17:08:31 +00:00
Arthurk12
c2e90ede11 feat(screenshare): gain node
Splits screenshare stream into video and audio and adds gain node to audio
stream in order to permit volume control by the user. Volume is normalized
between [0, 2](muted and 2x boost).
2021-11-12 16:30:39 +00:00
Anton Georgiev
314f35c44e
Merge pull request #13667 from JoVictorNunes/preview-alignment
fix: video preview alignment
2021-11-11 15:11:12 -05:00
Joao Victor
2176898c9f fix: video preview alignment 2021-11-11 16:42:07 -03:00
Arthurk12
350b155309 feat(screenshare): add volume slider
Adds volume slider UI to screen sharing's viewer container
2021-11-11 17:38:18 +00:00
Joao Victor
77c32a6391 fix: virtual background not kept when switching from breakout to main room 2021-11-11 11:33:55 -03:00
Anton Georgiev
00775a26bf
Merge pull request #13672 from antobinary/2.4-locales
chore: Pulled the latest 2.4 HTML5 locales from Transifex
2021-11-10 16:23:10 -05:00
Localization Server
146cb843af chore: Pulled the latest 2.4 HTML5 locales from Transifex 2021-11-10 21:21:39 +00:00
Anton Georgiev
a0e9a7327f
Merge pull request #13663 from mariogasparoni/fix-fullaudio-breakout-audio-auto-join
fix(audio): prevent audio to hang when user is transferred to breakout room
2021-11-10 16:10:13 -05:00
Localization Server
6b4e20bed6 chore: Pulled the latest 2.4 HTML5 locales from Transifex 2021-11-10 20:14:56 +00:00
Mario Jr
9578efbcd3 fix(audio): prevent audio to hang when user is transferred to breakout room
When joining breakouts, we now wait for the bridge to be loaded before
automatically start user's audio.
This problems happens only on fullaudio bridge
2021-11-09 15:04:10 -03:00
Anton Georgiev
2869582225
Merge pull request #13662 from mariogasparoni/backport-fullaudio-bridge-v2.4
[backport 2.4] feat(audio): faster audio activation using fullaudio bridge
2021-11-09 12:25:33 -05:00
Anton Georgiev
e3740fd75e
Merge pull request #13661 from antobinary/fix-package-json
fix: Include bintrees and tdigest in package-json (needed for prod)
2021-11-09 11:17:36 -05:00
Anton Georgiev
db6d4dbb83 fix: Include bintrees and tdigest in package-json (needed for prod) 2021-11-09 16:14:08 +00:00
Mario Jr
a719f8f5e4 fix(audio): update fullaudio bridge according to sonar's checks 2021-11-09 12:10:44 -03:00
Mario Jr
117bb91a0e fix(audio): rename fullaudio bridge to FullAudioBridge
updated whitelist, also according to sonar checks
2021-11-09 12:10:36 -03:00
Mario Jr
1ee9203fad fix: enable useLocationOrigin in dynamic-import
This makes meteor to work with a reverse proxy, without changing it's
settings
2021-11-09 12:10:25 -03:00
Mario Jr
70815fad4f feat(audio): add meta param for selecting fullaudio bridge
This can be passed through API. For example, for setting fullaudio bridge, you
can pass the param "meta_fullaudio-bridge=fullaudio"
2021-11-09 12:09:36 -03:00
Mario Jr
db4e2f9c47 update(audio): correctly retrieves the media-server-fullaudio from meta params
Previously we were using the same for listenonly, which for default
environments points to kurento, and didn't make any difference in media server
selection.
This could be problematic in those environments where meta param
for listeonly media server is set , though.
Fullaudio has now it's own meta param that can be passed through API:
"meta_media-server-fullaudio"
2021-11-09 12:09:28 -03:00
Mario Jr
f9dbefe764 feat(audio): basic funcionality for fullaudio bridge
This commit allows user to join/leave audio using the fullaudio bridge.
This is still under development, but to use this now we must set values of
skipCheck to false, and defaultFullAudioBridge to fullaudio. This
depends on newest version of bbb-webrtc-sfu
2021-11-09 12:09:18 -03:00
Mario Jr
0ca1682138 chore(client): allow to set a custom ROOT_URL when calling npm start
We need to set ROOT_URL with the hostname/ip used to access BBB externaly,
otherwise dynamic-import won't work, therefore fullaudio bridge won't
be loaded.
2021-11-09 12:08:52 -03:00
Mario Jr
42778adeaf feat(audio): add base code for fullaudio bridge
This bridge will work with bbb-webrtc-sfu to handle microphone audio.
2021-11-09 12:08:45 -03:00
Mario Jr
cf2d595f12 fix(audio): correctly retrieve Object class from bridge module 2021-11-09 12:08:31 -03:00
Mario Jr
5c85f4c5b2 fix(audio): promisify loadBridges function
New bridges were being loaded with undefined value, since we didn't
wait for this to fully load before instantiating it
2021-11-09 12:08:25 -03:00
Mario Jr
86ef834476 fix(audio): bridges can be dynamically imported
Added bridge whitelist , to allow bridge modules to be dynamically imported.
2021-11-09 12:08:18 -03:00
Mario Jr
7e218c3eca feat(audio): add bridge configurable scheme
we are now able to switch between audio bridges, by selecting it in
config files.
2021-11-09 12:08:09 -03:00
Anton Georgiev
d725ee7734
Merge pull request #13655 from JoVictorNunes/issue-12840
improvement: video preview modal
2021-11-09 09:51:17 -05:00
Joao Victor
cc85b58ef4 improves video preview modal 2021-11-09 08:36:06 -03:00
Anton Georgiev
5bc33dce2e
Merge pull request #13647 from JoVictorNunes/pub-error-poll
fix: publication for user response polls
2021-11-08 13:43:50 -05:00
Anton Georgiev
752f783e72
Merge pull request #13649 from germanocaumo/f-h-prom-agent
feat(html5): add prometheus instrumentation
2021-11-08 09:14:06 -05:00
Anton Georgiev
f6972b8b55
Merge pull request #13605 from frankemax/rewrite-fullscreen-button
feat(external-videos): rewrite fullscreen button
2021-11-08 09:05:38 -05:00
Anton Georgiev
b2e0fd0b34
Merge pull request #13642 from JoVictorNunes/issue-13618
fix: user list button's arrow
2021-11-08 09:04:33 -05:00
hiroshisuga
4c8f4f9abb
remove unused style 2021-11-06 16:51:25 +09:00
germanocaumo
3dd679761f Merge branch 'v2.4.x-release' of https://github.com/bigbluebutton/bigbluebutton into f-h-prom-agent 2021-11-05 19:38:40 +00:00
germanocaumo
6f1e1d4f4a refactor(prom-html5): serve endpoint via meteor instead of http server +
- separate backend/frontend metrics, only add metrics related to the role
- add role and instance labels
2021-11-05 16:31:23 +00:00
Joao Victor
5e82448be3 fixes the publication for user response polls 2021-11-05 11:11:55 -03:00
João Victor Nunes
4868822216
fix: publish button for user response polls (#13638)
* fixes publish button for user response polls
Co-authored-by: Joao Victor <joaov@imdt.com.br>
2021-11-04 15:12:41 -04:00
Joao Victor
072284fe98 fixes user list button's arrow 2021-11-04 14:30:47 -03:00
prlanzarin
86f8e03e97 fix(screenshare): bad isPresenter transition check
Fixes #13245
2021-11-04 14:47:35 +00:00
Anton Georgiev
85c78cc73e
Merge pull request #13622 from antonbsa/external-video
test: Improves presentation tests
2021-11-02 16:39:04 -04:00
Anton Georgiev
00106e98be chore: Update Meteor 2.3.6->2.5 2021-10-29 21:11:13 +00:00
Anton Georgiev
dfcb207aeb build: bbb-html5 npm deps improvements 2021-10-29 19:34:47 +00:00
Anton Georgiev
bd002b3b3f build: bbb-html5 npm deps improvements 2021-10-29 19:30:59 +00:00
Max Franke
b507eeb80f feat(external-videos): rewrite fullscreen button
Following BBB v2.4 new layout manager fullscreen changes
2021-10-29 10:55:34 -03:00
Anton
f020c0da9d add Presentation test: Start external video 2021-10-28 15:37:56 -03:00
Bohdan Zhemelinskyi
b466778cd2 Removed wdyr 2021-10-28 13:58:11 +00:00
Max Franke
664bad7d08 feat(screenshare): UX updates
Reduce the font size to 21px (1.3rem) and font weight to 600.
2021-10-27 11:51:39 -03:00
Anton
ff338c0198 add Hide/Restore presentation test 2021-10-26 14:59:40 -03:00
Anton Georgiev
0a44cf0ebb
Merge branch 'v2.4.x-release' into discart-poll-button 2021-10-26 12:35:30 -04:00
Anton Georgiev
c834a5bd39
Merge pull request #13563 from antonbsa/polling-tests-improvements
test: Polling tests improvements
2021-10-26 12:32:43 -04:00
Max Franke
1e3c5d1b65 feat(poll): add cancel poll button
Add a new button that adds the option to cancel the polling and its results.
Avoiding the user from having to close the poll, and open another in the
actions bar.
2021-10-26 10:45:52 -03:00