Commit Graph

41874 Commits

Author SHA1 Message Date
prlanzarin
eccb06369b fix(bbb-html5): crash on video-provider unmount
There's a race condition that may cause a client crash whenever a
video-provider's unmount procedure is run, but its signalling websocket
is undefined. The WS's callback handlers are re-assigned without
checking for the socket's availability, causing an unhandled TypeError.

The WS may be undefined in a couple of scenarios, e.g.: unmouting before
the socket was successfully set up, unmounting while a reconnect is in
place etc.

Check whether the socket exists before accessing it in video-provider's
componentWillUnmount routine.
2024-05-02 22:55:25 +00:00
prlanzarin
cfa013fdaa fix(reactions): crash when interactionsButton coords are absent
The client may crash whenever a emoji rain animation is triggered, but
the interactions button element cannot be located. This happens because
the button coordinates are fetched without checking whether the element
exists.

Get the coordinate fetching method to return null if the
interactionsButton element cannot be located, and ignore the emoji rain
action if that is the case. Whenever no valid coordinates are found, log
an warning so we can track this and figure out what's happening with the
button.

Fix a few typos in the getInteractionsButtonCoordinates method.
2024-05-02 22:32:09 +00:00
prlanzarin
00a2ab52a5 fix(audio): acquire streams before negotiation when peer is answerer
When a sendrecv peer acts as the answerer, gUM is only called _after_
the remote offer is received. This is fine, but the error handling runs
different in that scenario in a way that eventual gUM errors are treated
as negotiation errors, leading to inconsistencies when surfacing the
error to end users.

If a peer is acting as answerer and is a transceiver, acquire the local
streams _before_ actual negotiation so that gUM errors are surfaced
correctly (and we spare uneeded negotiation steps).
2024-05-02 22:27:16 +00:00
prlanzarin
d658d81148 fix(audio): minimize redundant audio exit toasts
Audio exit toasts are fired in some redundant situations, e.g.: when the
error help screen is toast.

Change the logic a bit so that it's only fired when the audio help modal
won't be shown, i.e.: when audio had succesfully connected.
2024-05-02 22:09:56 +00:00
João Victor
f9b935e75b test: adjust timeout for connecting webcam to be removed 2024-05-02 18:27:32 -03:00
João Victor
32bb2dfe2f fix: make hook to store its own state to avoid useless re-renders 2024-05-02 17:18:38 -03:00
Ramón Souza
24b90070b7
Merge pull request #20136 from KDSBrowne/v30.19985
fix(whiteboard): Deactivate Drawing Tool On Access Change
2024-05-02 16:36:14 -03:00
Tiago Jacobs
a4556f42b3
Merge pull request #20149 from gustavotrott/gql-tables-performance-improvements
Graphql-server: Increase Streaming Queries Multiplexed Batch Size to 1000 (was 100)
2024-05-02 15:22:09 -03:00
Gustavo Trott
e60217670e Increase Streaming Queries Multiplexed Batch Size for 1000 (was 100) 2024-05-02 15:12:03 -03:00
Ramón Souza
5d27799448
Merge pull request #20143 from ramonlsouza/issue-20142
fix: Warning message character limit exceeded is still showing up after being sent
2024-05-02 14:57:12 -03:00
Tiago Jacobs
c5d1c8be3b
Merge pull request #20135 from GuiLeme/plugin-sdk-readme-logger-ui-data
feat(plugins): refactor intl code for plugin and general code
2024-05-02 14:45:52 -03:00
Anton Georgiev
6f5dcc908a
Merge pull request #20148 from bigbluebutton/dependabot/npm_and_yarn/bbb-learning-dashboard/npm_and_yarn-f8a910b6b7
Bump postcss from 8.4.34 to 8.4.35 in /bbb-learning-dashboard in the npm_and_yarn group across 1 directory
2024-05-02 12:51:10 -04:00
dependabot[bot]
3a7a9f7af7
Bump postcss
Bumps the npm_and_yarn group with 1 update in the /bbb-learning-dashboard directory: [postcss](https://github.com/postcss/postcss).


Updates `postcss` from 8.4.34 to 8.4.35
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](https://github.com/postcss/postcss/compare/8.4.34...8.4.35)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: direct:development
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-05-02 16:24:39 +00:00
Anton Georgiev
9747aea796
Merge pull request #20137 from bigbluebutton/dependabot/npm_and_yarn/bbb-graphql-client-test/npm_and_yarn-d772c3647a
Bump the npm_and_yarn group across 2 directories with 2 updates
2024-05-02 12:19:55 -04:00
Tiago Jacobs
60ab2ffce7
Merge pull request #20147 from gustavotrott/gql-tables-performance-improvements
enhancement (graphql-server): Optimization of Hasura Queries and Index Utilization in Postgres
2024-05-02 12:34:25 -03:00
Tiago Jacobs
17aebe6586
Merge pull request #20145 from gustavotrott/gql-middleware-handle-mutation
enhancement: `Graphql-middleware` will directly parse and route Mutations to `graphql-actions`, bypassing Hasura
2024-05-02 12:34:01 -03:00
Gustavo Trott
6846447644 Include commented HASURA_GRAPHQL_PG_CONNECTIONS to facilitate to change it 2024-05-02 11:55:07 -03:00
Gustavo Trott
dd07c838de Increase Hasura Multiplexed Batch Size to 1000 (default was 100) 2024-05-02 11:52:17 -03:00
João Victor
5a80f30711 fix: tweak video-streams typings (Part 4) 2024-05-02 11:51:14 -03:00
Gustavo Trott
4e4ba45535 Add a bunch of indexes to improve PG performance 2024-05-02 11:50:19 -03:00
João Victor Nunes
98d579401b
Merge branch 'v3.0.x-release' into video-streams-typings-fix 2024-05-02 11:41:09 -03:00
Ramón Souza
f589cb8828
Merge pull request #20076 from ramonlsouza/away-mode
feat: Improved away mode
2024-05-02 11:34:32 -03:00
João Victor
73eee42c66 fix: TS errors 2024-05-02 11:32:08 -03:00
João Victor Nunes
c61b6bb7e5
Merge branch 'v3.0.x-release' into video-streams-typings-fix 2024-05-02 11:26:08 -03:00
João Victor
9495e60d6f fix: ensure user's webcams are properly terminated 2024-05-02 11:22:24 -03:00
Gustavo Trott
148753ff6c Improve view v_chat 2024-05-02 11:19:39 -03:00
Gustavo Trott
f7c1b486b0 revert wrong file 2024-05-02 11:07:51 -03:00
Gustavo Trott
afccd6af32 improve code 2024-05-02 11:06:37 -03:00
Guilherme Leme
1cad46857c [plugin-sdk-readme-logger-ui-data] - update SDK 2024-05-02 10:53:00 -03:00
Ramón Souza
e0c8c0d933 remove chat error when a message is sent 2024-05-02 10:49:06 -03:00
Gustavo Trott
4fc3b2419c Graphql-middleware itself will handle mutations and forward to Graphql-actions 2024-05-02 10:45:32 -03:00
Tiago Jacobs
90f3539332
Merge pull request #20141 from JoVictorNunes/fix-video-stream-user-filtering
fix(webcam): fetch user data of webcam users only
2024-05-02 10:32:56 -03:00
Ramón Souza
250a559a4c
Merge pull request #20133 from ramonlsouza/tld19-snapshot
fix: snapshot of current slide
2024-05-02 10:21:41 -03:00
Anton B
1d90a8e966 test: remove "write closed captions" test 2024-05-02 10:06:49 -03:00
Ramón Souza
ae10830a1a move setTrackEnabled to new service file 2024-05-02 09:24:03 -03:00
João Victor
ee9f98a1ad fix(webcam): fetch user data of webcam users only
- Do not fetch user data of users who are not in webcam.
- Except when grid layout is active. In this situation we need to know about all users.
2024-05-02 09:17:58 -03:00
Anton B
04c17a59cd test: remove "pick random user" test 2024-05-02 08:58:18 -03:00
Ramón Souza
82b1101df8 Merge remote-tracking branch 'upstream/v3.0.x-release' into away-mode 2024-05-02 08:45:10 -03:00
dependabot[bot]
4362b8407f
Bump the npm_and_yarn group across 2 directories with 2 updates
Bumps the npm_and_yarn group with 1 update in the /bbb-graphql-client-test directory: [ejs](https://github.com/mde/ejs).
Bumps the npm_and_yarn group with 2 updates in the /bbb-learning-dashboard directory: [ejs](https://github.com/mde/ejs) and [postcss](https://github.com/postcss/postcss).


Updates `ejs` from 3.1.8 to 3.1.10
- [Release notes](https://github.com/mde/ejs/releases)
- [Commits](https://github.com/mde/ejs/compare/v3.1.8...v3.1.10)

Updates `ejs` from 3.1.8 to 3.1.10
- [Release notes](https://github.com/mde/ejs/releases)
- [Commits](https://github.com/mde/ejs/compare/v3.1.8...v3.1.10)

Updates `postcss` from 8.4.33 to 8.4.34
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](https://github.com/postcss/postcss/compare/8.4.33...8.4.34)

---
updated-dependencies:
- dependency-name: ejs
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: ejs
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: postcss
  dependency-type: direct:development
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-05-02 02:09:59 +00:00
KDSBrowne
0704628caa lint 2024-05-02 00:40:58 +00:00
KDSBrowne
7512d4c60e lint 2024-05-02 00:32:58 +00:00
KDSBrowne
4ae0dd5fba change from CRLF to LF 2024-05-02 00:28:22 +00:00
KDSBrowne
d2da9172da add no operation tool 2024-05-02 00:05:12 +00:00
João Victor
59d84f4722 fix: wrong style file import 2024-05-01 17:05:17 -03:00
Guilherme Leme
bc6b007f5a [plugin-sdk-readme-logger-ui-data] - fix intl ui-data-hook and fix warning of data-channel 2024-05-01 16:57:08 -03:00
João Victor
d72ce1a24c fix: tweak video-streams typings (Part 3)
- Fix almost the entire video-provider component typyings. Leaving some errors because the component depends on a lot of code which is not in typescript yet. Any attempt to fix them may cause problems.
2024-05-01 16:49:21 -03:00
João Victor
6d70904ba9 fix: tweak video-streams typings (Part 2)
- Tweak low-level components.
2024-05-01 16:48:50 -03:00
João Victor
7297778746 fix: tweak video-streams typings (Part 1)
- Tweak high-level components.
2024-05-01 16:48:12 -03:00
Ramón Souza
87786cfcb6 fix snapshot of current slide 2024-05-01 16:21:36 -03:00
Anton Georgiev
f8d5b5cd99 build: drop bbb-html5-with-roles.conf mentions 2024-05-01 15:00:58 -04:00