Commit Graph

9064 Commits

Author SHA1 Message Date
Ramón Souza
7f3dcb7f13
Merge pull request #15844 from JoVictorNunes/issue-15758
style: breakout item padding
2022-10-21 16:23:13 -03:00
Ramón Souza
8ed142a522 Merge remote-tracking branch 'upstream/v2.5.x-release' into merge-258-26 2022-10-21 14:43:23 -03:00
germanocaumo
835cf4f753 fix(whiteboard): diff shape update + shape permission +
Several improvements to tldraw whiteboard:
 - Only send the shape diff on shape updates (reduce a lot the message traffic)
 - Shape permissions (don't allow others to select/edit unless you are presenter/moderator)
  - This required some changes in akka model
 - Tldraw state patch changes to improve stability with fast updates (fix several crashes)
2022-10-21 14:05:31 +00:00
KDSBrowne
c38e256368 add screen reader alert when moving users to a breakout room 2022-10-20 14:37:11 +00:00
Daniel Petri Rocha
0a2b4186a2 Merge branch 'v2.6.x-release' into breakout-upload-ui 2022-10-19 19:51:05 +02:00
Joao Victor
1a0800ada7 fix: necessity of clicking twice for downloading presentation 2022-10-19 14:38:40 -03:00
germanocaumo
0e4f88d4b6 fix(tldraw): zoom inconsistency on some cases
Fix some unwanted zooms
2022-10-19 15:13:08 +00:00
germanocaumo
fdd09c578f fix(whiteboard): don't render out of slide cursors
Don't draw cursors with disabled position (-1,-1)
2022-10-19 15:09:13 +00:00
germanocaumo
df5d275f32 fix(whiteboard): allow pan with fitToWidth enabled 2022-10-19 15:07:47 +00:00
germanocaumo
cc84d6efef Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into tldraw-shape-updates 2022-10-19 14:27:27 +00:00
Daniel Petri Rocha
dd06ce2660 Show UploadingPresentations toast upon breakout notes capture
Displays a "To be uploaded..." toast in the main meeting while the shared notes of breakout rooms are being captured.
2022-10-19 13:36:25 +02:00
Ramón Souza
d3cfe305b0 Merge remote-tracking branch 'upstream/v2.5.x-release' into oct18 2022-10-18 17:13:33 -03:00
Ramón Souza
e17045031d Merge remote-tracking branch 'upstream/v2.5.x-release' into oct18 2022-10-18 17:02:48 -03:00
Joao Victor
9dead5d410 Adjustment on mobile: better spacing 2022-10-18 16:25:23 -03:00
Joao Victor
f21ec3e6b1 style: keyboard shortcuts modal 2022-10-18 15:39:28 -03:00
KDSBrowne
2d9dd58f9c set slide shape childIndex to -1 2022-10-18 18:12:42 +00:00
Gustavo Trott
a9fe2cf18d
Merge pull request #15755 from danielpetri1/capture-shared-notes 2022-10-18 14:19:29 -03:00
KDSBrowne
8ee7d85090 fix lint issue 2022-10-18 14:13:30 -03:00
KDSBrowne
32896d025b restrict poll item length to 30 chars 2022-10-18 14:13:23 -03:00
Ramón Souza
7553a7dbe2 add custom polling functionality to smart polls 2022-10-18 14:13:09 -03:00
Ramón Souza
4f96d35502
Merge pull request #15856 from KDSBrowne/26-smart-custom-polls
Add Custom Poll Functionality Via Smart Slides
2022-10-18 13:08:58 -03:00
Ramón Souza
77ae18f91c add safeMatch method 2022-10-18 14:50:18 +00:00
KDSBrowne
7cc79913f0 fix lint issue 2022-10-18 14:45:47 +00:00
Ramón Souza
44feee8dda add safeMatch method 2022-10-18 10:27:10 -03:00
KDSBrowne
011a41f6d1 restrict poll item length to 30 chars 2022-10-17 23:43:04 +00:00
KDSBrowne
412221c664 add custom polling functionality to smart polls 2022-10-17 20:25:20 +00:00
GuiLeme
bc9f24a5fb [backport-pdf-100] - backport of functionality 2022-10-17 17:05:16 -03:00
Ramón Souza
8968f1c91a
Merge pull request #15845 from JoVictorNunes/improved-error-screen-messages-backport
[2.5] improvement: error screen messages and logs
2022-10-17 14:24:56 -03:00
Joao Victor
79587a393b Stringify error code 2022-10-17 13:35:23 -03:00
GuiLeme
e1ec9fa13c [fix-issue-15843] - Best practice 2022-10-17 12:21:55 -03:00
GuiLeme
cfae5f91e6 [fix-issue-15843] - Fixed current not being persisted 2022-10-17 12:12:22 -03:00
Ramón Souza
e8143f1c68
Merge pull request #15849 from ramonlsouza/bp15826
Update Smart Slides to Support Typed Response Poll (2.5)
2022-10-14 16:28:12 -03:00
KDSBrowne
6e8b33f6a2 fix viewer crash when smart polling 2022-10-14 15:44:06 -03:00
KDSBrowne
815338db0d handle double ?? for multi response smart poll 2022-10-14 15:44:06 -03:00
KDSBrowne
db5db90548 fix lint issues in quick poll dropdown cmp 2022-10-14 15:44:06 -03:00
KDSBrowne
9f0351d0d6 update smart slides to detect user response poll 2022-10-14 15:44:06 -03:00
Lucas Fialho Zawacki
d53c8d90a2 Option to hide waiting users icon when no pending users 2022-10-14 15:20:06 -03:00
Joao Victor
d628131e64 improvement: error screen messages and logs 2022-10-14 14:47:27 -03:00
Ramón Souza
942f75f478
Merge pull request #15827 from bigbluebutton/waiting-users
Option to hide waiting users icon when no pending users
2022-10-14 14:37:55 -03:00
Ramón Souza
5b274add16
Merge pull request #15777 from germanocaumo/dup-ann-ws-fix-25
chore(whiteboard): backport of annotations dupplication fix
2022-10-14 13:54:45 -03:00
Joao Victor
e1adbc1f2e style: breakout item padding 2022-10-14 09:44:49 -03:00
Gustavo Trott
eccaf938dc
Merge pull request #15730 from gabriellpr/breakout-create-tests 2022-10-13 21:41:24 -03:00
Lucas Fialho Zawacki
a2bc96fe35 Ask for confirmation before closing meeting window 2022-10-13 16:41:43 -03:00
Joao Victor
b552ae5507 fix(webcam): brightness not working when changing quality profile 2022-10-13 16:26:25 -03:00
Ramón Souza
04eb95e70f
Merge pull request #15752 from JoVictorNunes/issue-15559-25
fix: screenshare volume control
2022-10-13 15:15:47 -03:00
KDSBrowne
a248c716da fix viewer crash when smart polling 2022-10-12 17:45:33 +00:00
KDSBrowne
340e309f23 handle double ?? for multi response smart poll 2022-10-12 17:34:40 +00:00
KDSBrowne
91676f419d fix lint issues in quick poll dropdown cmp 2022-10-11 20:24:22 +00:00
Lucas Fialho Zawacki
d4a424c1e6 Option to hide waiting users icon when no pending users 2022-10-11 16:17:03 -03:00
KDSBrowne
3e9c858717 update smart slides to detect user response poll 2022-10-11 19:11:04 +00:00
Daniel Molkentin
6ce3dd39cd fix: show learning dashboard after session was ended in cluster proxy scenario
Closes: #15821
2022-10-11 17:39:53 +02:00
Gabriel Porfirio
ad57bf48ab guest policy tests 2022-10-10 14:47:44 -03:00
Joao Victor
4efd1aa332 fix(locale): add localization for 'Manage users' label 2022-10-10 11:43:18 -03:00
Joao Victor
7ec5ba3fbc fix: use the correct meeting layout variable for the resizing event 2022-10-10 10:32:19 -03:00
Daniel Petri Rocha
184b1c2169 Merge branch 'v2.6.x-release' into capture-shared-notes 2022-10-08 11:24:22 +02:00
Gustavo Trott
f96a520a42
Merge pull request #15792 from GuiLeme/fix-debounce-shared-notes 2022-10-07 16:48:43 -03:00
Ramón Souza
6017786a85
Merge pull request #15783 from JoVictorNunes/improved-error-screen-messages
improvement: error screen messages and logs
2022-10-07 16:40:45 -03:00
Joao Victor
e4f5317009 fix: unauthenticated user handling and manual disconnection 2022-10-07 16:21:43 -03:00
GuiLeme
1046c08791 [fix-debounce-shared-notes] - Changes in review 2022-10-07 16:10:08 -03:00
GuiLeme
550eb6aa2e [fix-export-to-chat-toast] - Fixed export to chat Toast 2022-10-07 14:36:02 -03:00
GuiLeme
a098933e0f [fix-debounce-shared-notes] - Added data-test to current presentation toast 2022-10-07 09:40:46 -03:00
Joao Victor
45199cb6eb fix: stringify all codeError's 2022-10-07 09:18:07 -03:00
Daniel Petri Rocha
f170bdc19b Merge branch 'v2.6.x-release' into capture-shared-notes 2022-10-06 22:38:21 +02:00
KDSBrowne
6bccb3ff14 restore menu item descriptions | fix user options mute label not updating 2022-10-06 20:04:16 +00:00
GuiLeme
2b84b80ba8 [fix-debounce-shared-notes] - fix debounce not working 2022-10-06 14:46:06 -03:00
KDSBrowne
1375cf1535 fix menu item descriptions not announcing for screen readers 2022-10-06 17:43:58 +00:00
Joao Victor
caa8667526 fix: mute external video when in echo test 2022-10-06 11:45:52 -03:00
GuiLeme
af7c7d1191 [issue-pdf-100-processing] - fix for merge 2022-10-06 11:24:50 -03:00
GuiLeme
5ca4a92940 [issue-pdf-100-processing] - resolved conflicts 2022-10-06 09:58:42 -03:00
KDSBrowne
9c6a6298e2 update menu ids to be unique 2022-10-05 21:54:59 +00:00
germanocaumo
8f41ab31da fix(tldraw): persist bound shapes (arrows) + fix sending unneeded changes 2022-10-05 20:43:48 +00:00
Gabriel Porfirio
4bfb2eba95 improved breakout remaning time check 2022-10-05 17:35:19 -03:00
germanocaumo
2fa76d60c4 Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into tldraw-shape-updates 2022-10-05 19:56:54 +00:00
Joao Victor
45a230f7b4 fix: unread notes notification 2022-10-05 16:46:02 -03:00
Carlos
e53b961173 fix(external videos) youtube shorts link working
If the url is from youtube shorts change the url.
2022-10-05 15:53:44 -03:00
Gustavo Trott
bbe3ca34a8
Merge pull request #15474 from GuiLeme/apply-toast-shared-notes 2022-10-05 12:02:04 -03:00
Joao Victor
7e8cee7340 improvement: error screen messages 2022-10-05 11:30:12 -03:00
GuiLeme
3b90bdb8b2 [apply-toast-shared-notes] - Fix problems with shared notes 2022-10-04 16:25:54 -03:00
KDSBrowne
ed7cb5f6e5 add focus and hover styles to skip slide dropdown / reset zoom 2022-10-04 15:38:34 +00:00
KDSBrowne
ab63779b2f add video settings menu to tab order 2022-10-04 14:21:52 +00:00
germanocaumo
9d059dc5e5 fix(whiteboard): avoid subscribing to annotations multiple times
The subscription to annotations sometimes could be ready and stopped before the component fully loads,
allowing it to be subscribed again (and then receiving all the annotations via websocket two times).

Moved the subscription to occur only after the base ones.
2022-10-04 09:35:06 +00:00
Ramón Souza
077592df18
Merge pull request #15745 from germanocaumo/dup-ann-ws-fix
fix(whiteboard): annotations duplication in websocket/collection
2022-10-03 15:10:59 -03:00
Joao Victor
63b4ba7672 fix: undefined camera profile 2022-10-03 08:10:08 -03:00
Joao Victor
3f07430ff4 improvement: store last shared webcam 2022-10-03 08:09:03 -03:00
Daniel Petri Rocha
234e36f462
Merge branch 'v2.6.x-release' into breakout-upload-ui 2022-10-03 11:05:23 +02:00
Daniel Petri Rocha
26a93f6853
Merge branch 'v2.6.x-release' into capture-shared-notes 2022-10-03 11:03:24 +02:00
Ramón Souza
a15cf73721
Merge pull request #15763 from germanocaumo/tldraw-zoom-fixes
fix(whiteboard): several zoom fixes
2022-09-30 17:18:45 -03:00
Ramón Souza
61cfdd9377
Merge pull request #15725 from germanocaumo/f-t-cursor
fix(cursor): hide cursor for others on mouse leave
2022-09-30 12:58:41 -03:00
KDSBrowne
02836bd78d add missing aria-describedby label on delete btn 2022-09-30 15:24:45 +00:00
KDSBrowne
5bd8d7fd0f remove double tab on checkbox component 2022-09-30 15:24:36 +00:00
KDSBrowne
b73ad8a85f update aria descriptions in video preview modal | fix checkbox aria label 2022-09-30 15:24:24 +00:00
KDSBrowne
03cf283ab3 update upload virtual background button aria description 2022-09-30 15:24:15 +00:00
germanocaumo
e1ee782294 fix(whiteboard): several zoom fixes
Sometimes when whiteboard props change (mainly resizes), the tldraw component gets
mounted again, resetting its camera, and was causing zoom to be applied incorrectly.
I've added a useEffect to better react to when the camera resets and reset to the corret zoom.
2022-09-30 14:35:29 +00:00
GuiLeme
362371834a Merge remote-tracking branch 'upstream/v2.6.x-release' into issue-pdf-100-processing 2022-09-30 10:34:23 -03:00
gabriellpr
b23cc4ea51
Merge branch 'v2.6.x-release' into breakout-create-tests 2022-09-30 08:23:52 -03:00
Gabriel Porfirio
0e8a2b9a2e improving the tests 2022-09-30 08:17:15 -03:00
Ramón Souza
3ea427aa49
Merge pull request #15751 from JoVictorNunes/brightness-label-selection
improvement: disable text selection of brightness labels
2022-09-29 13:57:36 -03:00
KDSBrowne
7ed1c5b274 add hover and focus outlines to layout buttons 2022-09-29 14:58:55 +00:00
KDSBrowne
4453425350 add aria description to layout buttons 2022-09-29 14:46:49 +00:00
Joao Victor
e4d8863e9f fix: screenshare volume control 2022-09-29 11:07:31 -03:00
João Victor Nunes
19b28de056
Merge branch 'v2.6.x-release' into issue-15713 2022-09-29 10:49:17 -03:00
Ramón Souza
045e2ec95d
Merge pull request #15740 from JoVictorNunes/issue-15712
fix: add config to disable emoji sort on click
2022-09-29 10:32:07 -03:00
Ramón Souza
e1095869c9
Merge pull request #15665 from ramonlsouza/add-locale-format
Support @ notation for localization files
2022-09-29 10:23:08 -03:00
KDSBrowne
6560fbff32 remove paths from layout buttons alt text 2022-09-29 13:20:38 +00:00
KDSBrowne
d7314ff442 update whiteboard options aria label 2022-09-29 13:04:17 +00:00
Ramón Souza
223bc60814
Merge pull request #15748 from JoVictorNunes/issue-15746
improvement: text selection in chat
2022-09-29 10:02:37 -03:00
Joao Victor
82f385c88e improvement: disable text selection of brightness labels 2022-09-29 09:49:36 -03:00
Joao Victor
27268dc697 improvement: text selection in chat 2022-09-28 15:32:37 -03:00
Ramón Souza
9b7186a23a
Merge pull request #15738 from ramonlsouza/fix-cursor-bug
fix: cursor bug after camera is dropped in the same place
2022-09-28 14:33:40 -03:00
Ramón Souza
6963bc0db4 Merge remote-tracking branch 'upstream/v2.6.x-release' into add-locale-format 2022-09-28 14:32:01 -03:00
Ramón Souza
ea96301893
Merge pull request #15737 from ramonlsouza/issue-15718
fix: Unable to expand the sidebar content by pulling on webcam part when close to whiteboard
2022-09-28 14:20:42 -03:00
Joao Victor
f8279ab5b4 improvement: add internationalization singleton 2022-09-28 13:48:27 -03:00
Gustavo Trott
be81a0e32a
Merge pull request #15541 from gustavotrott/html5-show-ejectedReason 2022-09-28 10:59:04 -03:00
germanocaumo
af1c7fe7fc fix(whiteboard): avoid subscribing to annotations multiple times
The subscription to annotations sometimes could be ready and stopped before the component fully loads,
allowing it to be subscribed again (and then receiving all the annotations via websocket two times).

Moved the subscription to occur only after the base ones.
2022-09-28 11:43:10 +00:00
Joao Victor
862c9fb64d fix: add config to disable emoji sort on click 2022-09-27 15:47:39 -03:00
Ramón Souza
089b64deb7
Merge pull request #15657 from JoVictorNunes/issue-15574
refactor: push layout
2022-09-27 11:13:28 -03:00
GuiLeme
9495e9ae01 [apply-toast-shared-notes] - fix shared-notes display wrong information when clicking the confirm button 2022-09-27 10:05:27 -03:00
Ramón Souza
2ae9eca935 fix cursor bug on camera drag 2022-09-26 17:15:48 -03:00
Ramón Souza
52e8d58a54 fix sidebar resize when webcam is below the chat 2022-09-26 16:22:47 -03:00
Ramón Souza
fcf05910d1
Merge pull request #15724 from JoVictorNunes/issue-15692
fix: allow video settings to open
2022-09-26 13:39:52 -03:00
Ramón Souza
2b0971e2c8 Merge tag 'v2.5.6' into merge-256-26 2022-09-26 09:17:59 -03:00
GuiLeme
5cb34e7917 [apply-toast-shared-notes] - changes in Review 2022-09-23 12:24:39 -03:00
Gabriel Porfirio
7d8a52d106 breakout test creation and after creation 2022-09-22 17:17:15 -03:00
GuiLeme
633a032fd0 [issue-pdf-100-processing] - implemented retry flow and fixed error message 2022-09-22 16:58:37 -03:00
Gustavo Trott
03378ed48e Remove delay to endMeeting when user is ejected=true 2022-09-22 14:22:58 -03:00
Tim Schneider
0562b997f9 Added dropdown menu for selecting emojis next to the raiseHand Button 2022-09-22 15:02:19 +00:00
Joao Victor
ab40586702 fix: allow video settings to open 2022-09-22 09:37:24 -03:00
germanocaumo
fea31e366c refactor: code smell 2022-09-22 10:06:23 +00:00
germanocaumo
01a1cf83d7 fix(cursor): correctly hide cursor for others on mouse leave
Also update out of bounds coords to -1.0 to not display on playback.
2022-09-21 20:49:07 +00:00
GuiLeme
ecf5146604 [apply-toast-shared-notes] - fixed delay in shared notes' move-to-whiteboard button 2022-09-21 17:41:31 -03:00
Ramón Souza
ca52a2e073
Merge pull request #15714 from ramonlsouza/port-15687-25
fix: multiple answer translation in live results (2.5)
2022-09-21 16:49:24 -03:00
Gustavo Trott
89ea5d07d3 Merge remote-tracking branch 'upstream/v2.5.x-release' into html5-show-ejectedReason 2022-09-21 15:58:01 -03:00
germanocaumo
ae7eb92c86 Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into tldraw-disable-select 2022-09-21 18:10:05 +00:00
Gustavo Trott
f3bb17a5e1
Merge pull request #15616 from gabriellpr/emojis-test 2022-09-20 16:50:59 -03:00
Gustavo Trott
7e18b03bf1
Merge pull request #15651 from gabriellpr/help-button-tests 2022-09-20 16:50:50 -03:00
Ramón Souza
c6ea6a5d12 fix multiple answer translation in live results 2022-09-20 13:28:25 -03:00
Ramón Souza
3cccbc4b97
Merge pull request #15687 from ramonlsouza/issue-15686
fix: multiple answer translation in live results
2022-09-20 13:27:23 -03:00
Daniel Petri Rocha
e23d00004f 'Capture Shared Notes' button in front-end 2022-09-20 17:43:13 +02:00
Ramón Souza
a882701ac7 fix broadcast push alert in breakouts 2022-09-20 09:57:08 -03:00
Daniel Petri Rocha
c84c2e2892 Merge branch 'v2.6.x-release' into breakout-upload-ui 2022-09-19 19:30:18 +02:00
Daniel Petri Rocha
7c086c3ea2 No checkbox in UI if capture disabled 2022-09-18 17:53:52 +02:00
Daniel Petri Rocha
e5ed5a4546 Capture slides from breakout rooms upon their end
Sends out the request to export the presentations from the main meeting to each breakout room.
The breakout rooms then generate the PDF file and upload it back to the main meeting.
2022-09-18 15:55:20 +02:00
GuiLeme
d7c5ab3623 [apply-toast-shared-notes] - error messages wait until user closes them and added timeout to toast 2022-09-16 17:36:23 -03:00
GuiLeme
dea0e498c7 [apply-toast-shared-notes] - Fix default and large presentation crash 2022-09-16 12:52:41 -03:00
prlanzarin
b3eebbb926 fix(audio): retry gUM without pre-set deviceIds on OverconstrainedError(s)
There are some situations where previously set deviceIds (
local/session storage) may become stale. This causes an unexpected
behavior where audio is temporarily borked until the user clears their
local storage.
This issue has been seen more recently on Safari endpoints when switching
back-and-forth breakout rooms in environments running under iframes.
Also seen randomly on endpoints with virtual input devices.

This centralizes audio gUM calling into a single method that retries the
gUM procedure without pre-set deviceIds only if the initial call fails
due with an OverconstrainedError - hopefully circumventing the issue.
2022-09-15 19:25:30 +00:00
Gabriel Porfirio
9ee4e929b9 data-test to breakout rooms 2022-09-15 15:34:14 -03:00
Joao Victor
745937868c fix: 'horizontalPosition' prop type 2022-09-15 12:01:31 -03:00
Gustavo Trott
10c81bf689
Merge pull request #15690 from zhem0004/handleCursorPropertyError 2022-09-15 10:36:14 -03:00
Joao Victor
968e872c5b Merge branch 'v2.6.x-release' into issue-15574 2022-09-15 09:13:02 -03:00
Gustavo Trott
faa1c93edf Improve readability 2022-09-14 22:28:06 -03:00
Gustavo Trott
0adab1c9c4 Improve readability 2022-09-14 22:24:14 -03:00
Gustavo Trott
14453a43f9 Include alerts when client lose connection with server 2022-09-14 22:16:27 -03:00
Ramón Souza
2a062b25dc
Merge pull request #15683 from ramonlsouza/issue-15669
fix: set breakout name input as readonly when updating users
2022-09-14 17:08:49 -03:00
Bohdan Zhemelinskyi
811d135585 handle missing cursor property case 2022-09-14 19:42:15 +00:00
Ramón Souza
7d7f26ea55
Merge pull request #15624 from KDSBrowne/bbb-text-updates
fix: Restore Text Shape Updates Per Character
2022-09-14 13:06:10 -03:00
GuiLeme
39b6359441 [issue-pdf-100-processing] - fix timeout error when PDF is too complex. 2022-09-14 10:33:41 -03:00
Ramón Souza
634393e740
Merge pull request #15670 from ramonlsouza/fix-warnings
Fix: bigbluebutton-html5 warnings
2022-09-14 10:17:01 -03:00
Ramón Souza
a924aecc1d fix multiple answer translation in live results 2022-09-14 09:51:48 -03:00
Ramón Souza
2b6b129df9 set breakout name input as readonly when updating users 2022-09-13 10:45:13 -03:00
Ramón Souza
1925124e82 fix button overflow in presentation toolbar 2022-09-12 16:27:29 -03:00
Ramón Souza
ce539ec44a rename external upload parameters 2022-09-12 11:04:13 -03:00
Gabriel Porfirio
f1d45502a0 WIP: breakout room create tests 2022-09-09 13:54:50 -03:00
Ramón Souza
5a83f9b392 add unique className to current presentation toasts 2022-09-09 13:25:20 -03:00
Ramón Souza
efb3083373 only mount layoutEngine when layoutType is available 2022-09-09 10:19:43 -03:00
Ramón Souza
4e80475fd0 fix tabIndex warning 2022-09-09 10:19:04 -03:00
Ramón Souza
dda6b83958 fix panning warning 2022-09-09 10:14:20 -03:00
Paulo Lanzarin
9c4707b56d
Merge pull request #15582 from prlanzarin/u26/refactor/mic-inout-logs-26
fix(audio): review in/out device management and switching
2022-09-09 09:22:40 -03:00
Paulo Lanzarin
362785a83a
Merge pull request #15647 from prlanzarin/u26/fix/cam-profile-switch-notreadableerror
fix(webcam): switching profiles in preview fails intermittently
2022-09-08 15:11:33 -03:00
Ramón Souza
560d9370c6 adjust html/body lang on page load 2022-09-08 14:25:29 -03:00
Ramón Souza
406c215add
Merge pull request #15659 from JoVictorNunes/issue-15658
fix(whiteboard toolbar): reduce distance from the bottom
2022-09-08 09:37:20 -03:00
Joao Victor
4277a0ed03 fix: volume icon 2022-09-07 11:59:43 -03:00
Joao Victor
19e71697d6 Merge remote-tracking branch 'upstream/v2.6.x-release' into issue-15559 2022-09-07 11:54:52 -03:00
Joao Victor
36864a8880 fix(whiteboard toolbar): reduce offset from the bottom 2022-09-07 11:34:54 -03:00
Joao Victor
acc55f0d08 fix: don't allow moderators to propagate meeting layout info (#15574). -- Currently moderators can propagate meeting layout info, but the layout which is propagated is the presenter's, not their own. This can mislead the moderators because they think their layout is being propagated but it's not. It makes more sense to allow only presenters to propagate their layouts. 2022-09-07 09:14:35 -03:00
Joao Victor
84f9eeebc4 refactor: push layout 2022-09-07 08:52:08 -03:00
Gabriel Porfirio
4ce4ef7446 help button test 2022-09-06 13:52:45 -03:00
prlanzarin
646db91367 fix(webcam): add MediaStream id to 'inactive' event handlers
BBBVideoStream 'inactive' event currently does not send the
MediaStream id as the payload for handlers. This can cause theoretical
race conditions due to media stream mismatches in places where
'inactive' handling is done globally (eg video-preview).

This adds the MediaStream id to BBBVideoStream's 'inactive' event
and uses it in video-preview to avoid such race conditions.
2022-09-06 12:31:26 +00:00
prlanzarin
5d04bcaf93 fix(webcam): retry gUM on NotReadableError for Chrome/Edge
tl;dr: switching camera profiles in video-preview fails intermittently
in Chrome/Edge.
Long version: Chrome/Edge sometimes bork gUM calls when switching camera
profiles. This looks like a browser bug (issue TBD). Track release not
being done synchronously -> quick subsequent gUM calls for the same
device (profile switching) -> device becoming unavaible while previous
tracks aren't finished.

Since track stop is not "awaitable", this commit adds a retry procedure
that re-runs gUM up to 5 times (200 ms delay) only if error.name is
NotReadableError and browser is either Chrome or Edge.
2022-09-06 12:26:31 +00:00
Ramón Souza
f7657d73db
Merge pull request #15627 from JoVictorNunes/fix-camera-brightness-Sep-01
fix(camera): disable brightness on Safari and stop segmentation if brightness is unchanged
2022-09-06 09:22:30 -03:00
Daniel Petri Rocha
f1690247fd Include capture checkbox in bbb-html5 2022-09-05 19:27:38 +02:00
germanocaumo
1db9fdacb1 fix(tldraw): disable selecting shapes on certain cases
- For presenter/multiuser Don't allow selecting the background shape (could be done with right click on empty area)
- For viewers: don't allow selecting anything (also hides the selection brush)
2022-09-02 20:59:03 +00:00
germanocaumo
87544a8b38 fix(tldraw): correctly sync draw shape updates +
Refactor how shape updates are parsed from tldraw, instead of doing it manually in each action,
uses the tldraw provided list of what changed available in the "onChangePage" callback, simplifying a lot of our code.
2022-09-02 19:26:26 +00:00
GuiLeme
2dec0f051b [apply-toast-shared-notes] - resolving conflicts 2022-09-02 16:08:24 -03:00
GuiLeme
f366b54498 Merge branch 'apply-toast-shared-notes' of github.com:GuiLeme/bigbluebutton into apply-toast-shared-notes 2022-09-02 15:26:21 -03:00
GuiLeme
80a381c87c [apply-toast-shared-notes] - resolved conflicts and refactored temporaryPresentationId's name 2022-09-02 15:24:29 -03:00
Ramón Souza
f9bbef759c
Merge pull request #15517 from JoVictorNunes/issue-15276
fix(tldraw): hide context menu for users who don't have access to whiteboard
2022-09-02 10:34:25 -03:00
Gustavo Trott
f7f20f3e2e
Merge pull request #15251 from ramonlsouza/issue-15001 2022-09-02 09:44:10 -03:00
Ramón Souza
cc7e5c7fa9
Merge pull request #15628 from ramonlsouza/send-chat-font
style: increase send to chat button font size
2022-09-01 15:43:50 -03:00
Joao Victor
b782a7fc06 fix: screenshare volume control 2022-09-01 13:48:59 -03:00
Ramón Souza
b8afe76837
Merge pull request #15620 from JoVictorNunes/sonar-warnings-Aug-31
fix: SonarCloud warnings
2022-09-01 13:22:31 -03:00
Ramón Souza
31c1e7b200 increase send to chat button font size 2022-09-01 11:07:39 -03:00
Arthurk12
d2b2acbf2d fix(whiteboard): re-adds right click to cancel
Re-adds cancelling text annotation on right click. To achieve this,
some mechanisms that were previously used to handle live synced annotations
were rescued. So this partially reverts 40b18b0.
2022-09-01 12:40:14 +00:00
Arthurk12
480925517c fix(whiteboard): text annotations stuck as fake
Cleans up and modifies the added annotation handler to suit only for text
annotation. As soon as the DRAW_END message is sent, the local fake
annotations are removed and replaced by the complete/not fake annotation.
2022-09-01 12:40:10 +00:00
Joao Victor
d4949bd7cf fix(camera): disable brightness on Safari and stop segmentation if brightness is unchanged 2022-09-01 09:29:08 -03:00
Ramón Souza
4e46284a3b
Merge pull request #15603 from JoVictorNunes/camera-brightness
feat(camera): set camera brightness
2022-08-31 17:00:34 -03:00
KDSBrowne
3277286525 persist patched text changes 2022-08-31 19:01:53 +00:00
Ramón Souza
b4f4de7e34
Merge pull request #15623 from ramonlsouza/fix-import-lost
fix: restore imports lost on merge
2022-08-31 13:26:15 -03:00
Ramón Souza
8bd14d3a91 restore imports lost on merge 2022-08-31 13:06:33 -03:00
Joao Victor
aefc5c6c6a Merge branch 'v2.6.x-release' into issue-15536 2022-08-31 10:47:58 -03:00
Joao Victor
916a14e1f9 fix: SonarCloud warnings 2022-08-31 10:33:55 -03:00
Arthurk12
070aa3425f Revert "fix: don't clear text fake annotations"
This reverts commit 74c4c1c4cc.
Reverting this commit because it causes fake annotations from the text
tool not to be removed. Since the text tool is the only one that
generates fake annotations(because it is the only one that is live
synced), the function to clear fake annotations is directly intended to
clear them.
2022-08-30 20:08:26 +00:00
Ramón Souza
470f491352
Merge pull request #15583 from germanocaumo/tldraw-viewbox-sync
fix(tldraw): sync viewed area between presenter/viewers +
2022-08-30 17:00:14 -03:00
Ramón Souza
8aa0d1b0e7
Merge pull request #15544 from gustavotrott/html5-show-ejectedReason-2.6
fix (2.6): enhancements over disconnection situation (delay to remove and show ejected reason)
2022-08-30 10:58:49 -03:00
Gabriel Porfirio
554f3d11da add data-test to emoji picker button 2022-08-30 09:55:57 -03:00
Gustavo Trott
84e482e55e Remove delay to endMeeting when user is ejected=true 2022-08-29 22:50:57 -03:00
Ramón Souza
e7107f87a7
Merge pull request #15598 from ramonlsouza/merge-2526-aug25
chore: Merge v2.5.5 into v2.6
2022-08-29 15:58:53 -03:00
Ramón Souza
45e49ea7d2
Merge pull request #15606 from ramonlsouza/light-button-color
fix: light button warning
2022-08-29 13:59:52 -03:00
Ramón Souza
fef01d8fb6
Merge pull request #15567 from ramonlsouza/fix-emoji-button
fix: emoji picker button styles
2022-08-29 13:01:42 -03:00
Ramón Souza
61f7700080 fix light button warning 2022-08-29 09:39:20 -03:00
germanocaumo
105ed256c3 fix: tldraw not changing pages correctly 2022-08-29 12:27:17 +00:00
Ramón Souza
033a23e336 restore needed imports 2022-08-26 14:30:40 -03:00
Ramón Souza
62f8ab3cb2 Merge remote-tracking branch 'upstream/v2.6.x-release' into pr-15460-aug26 2022-08-26 14:05:45 -03:00
Ramón Souza
e3b7c89ac9
Merge pull request #15586 from ramonlsouza/adjust-assign-buttons
style: adjust breakout room assignment buttons
2022-08-26 13:54:32 -03:00
Joao Victor
24c227cc75 Merge 2.6.x-release into camera-brightness 2022-08-26 11:53:23 -03:00
Joao Victor
396f5320a4 feat(camera): set camera brightness 2022-08-26 11:50:46 -03:00
Ramón Souza
609d43157a Merge tag 'v2.5.5' into merge-2526-aug25 2022-08-25 14:33:44 -03:00
Ramón Souza
fbeb775313
Merge pull request #15551 from ramonlsouza/uploader-errors
fix: display presentation uploader limit errors
2022-08-25 09:49:48 -03:00
Joao Victor
54b146effe fix: add missing custom virtual background param 2022-08-25 08:30:36 -03:00
Ramón Souza
14dd486f3a prevent infinite generating slides 2022-08-24 13:34:50 -03:00
Arthurk12
0ede0fa0e9 feat(captions): change transcription language on the fly
Adds a chevron button that allows enabling/disabling and changing the
language of the automatic transcription.
2022-08-24 15:40:03 +00:00
Daniel Petri Rocha
94fc8a4d41 Toast messages in front-end 2022-08-24 17:03:34 +02:00
prlanzarin
ec1879f96b fix(audio): add inputDeviceId enforcement for post-join/gUM
Extract the deviceId again from the stream to guarantee consistency
between stream DID vs chosen DID. That's necessary in scenarios where,
eg, there's no default/pre-set deviceId ('') and the browser's
default device has been altered by the user (browser default != system's
default).
2022-08-24 14:39:09 +00:00
Ramón Souza
c52a3ffb25 adjust assignment buttons - create breakout 2022-08-24 10:37:10 -03:00
prlanzarin
89e814d570 fix(audio): centralize device change code, add rollbacks, surface errors
There's no rollback procedure in case a device switch fails right now,
nor does the code entrypoints that call the switching procedures wait
for resolution or failure before marking the new device as chosen. That
may cause inconsistent states in a couple of ways:
  - No rollback: switch fails, audio is still on but no actual
    microphone input is being transmitted
  - Not waiting for resolutions: inconsistent chosen devices on failures
Device switching errors are also not surfaced to the end user

This commit:
  - Adds device rollback and proper resolution/failure response
    awaits to try and make the state a bit more consistent.
  - Centralizes the input device switching code to be reused between
    different bridges
  - Centralizes device ID state management in audio-manager to try and
    mantain them a bit more consistent across the board
  - Surface device switching failures to the end user
  - Guarantee device IDs are set to the session storage on all
    appropriate scenarios
2022-08-24 13:28:27 +00:00
KDSBrowne
45b3166863 Merge branch 'tldraw-viewbox-sync' of https://github.com/germanocaumo/bigbluebutton into tldraw-viewbox-sync 2022-08-24 11:55:38 +00:00
KDSBrowne
c758664651 remove toolbar from non presenter cursor calculation 2022-08-24 11:55:31 +00:00
Ramón Souza
82e234be33
Merge pull request #15500 from JoVictorNunes/issue-15458
fix: don't clear text fake annotations
2022-08-23 16:19:39 -03:00
germanocaumo
61cb5b8ef4 fix(tldraw): fit to width / presenter / slide changing 2022-08-23 18:19:17 +00:00
Ramón Souza
59f717265a adjustments after PR 15573 2022-08-23 13:59:58 -03:00
Ramón Souza
4d82d76d4a Merge remote-tracking branch 'upstream/v2.5.x-release' into uploader-errors 2022-08-23 09:34:25 -03:00
KDSBrowne
9f7b45b172 hide eraser animation on mobile 2022-08-23 12:08:31 +00:00
Guilherme Pereira Leme
621503e258
Merge pull request #6 from JoVictorNunes/issue-15505
fix: show conversion process info in toast
2022-08-23 09:01:02 -03:00
Anton B
8e7e1e7e42 test: add data-test props in lock settings items 2022-08-22 18:02:31 -03:00
Gustavo Trott
87e4c52cee Fix error when trying to read role when user was removed already 2022-08-22 16:32:12 -03:00
KDSBrowne
ab4cb469fb Merge branch 'tldraw-viewbox-sync' of https://github.com/germanocaumo/bigbluebutton into tldraw-viewbox-sync 2022-08-22 19:07:23 +00:00
KDSBrowne
9df18af50f update presentation offset for cursor (mobile) 2022-08-22 19:05:02 +00:00
Guilherme Pereira Leme
7288d9b9f2
Changes in review
Co-authored-by: João Victor Nunes <62393923+JoVictorNunes@users.noreply.github.com>
2022-08-22 15:54:34 -03:00
germanocaumo
0e7c27968e Merge branch 'tldraw-viewbox-sync' of https://github.com/germanocaumo/bigbluebutton into tldraw-viewbox-sync 2022-08-22 18:11:40 +00:00
GuiLeme
d9de398d90 [fix-page-count-exeed] - Forwarded temporaryPresentationId to front-end and refactor it's name 2022-08-22 15:00:27 -03:00
Anton Georgiev
2be6909e26
Merge pull request #15525 from gabriellpr/about-modal
test: About Modal Test
2022-08-22 13:05:11 -04:00
KDSBrowne
eb7c3dcbc8 update pan tool button after zoom changes 2022-08-22 16:55:44 +00:00
João Victor Nunes
aba9d86904
Merge branch 'v2.6.x-release' into issue-15276 2022-08-22 13:05:25 -03:00
germanocaumo
c948f39392 Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into tldraw-viewbox-sync 2022-08-22 15:47:51 +00:00
germanocaumo
f209fd17c1 Merge branch 'tldraw-viewbox-sync' of https://github.com/germanocaumo/bigbluebutton into tldraw-viewbox-sync 2022-08-22 15:43:04 +00:00
KDSBrowne
1de4b3f644 update cursor position handling | temp hide eraser animation 2022-08-22 14:37:34 +00:00
Ramón Souza
9303c598c1
Merge pull request #15532 from KDSBrowne/bbb-responsive-wb-toolbar
fix: Make Whiteboard Toolbar Responsive to Smaller Sizes
2022-08-22 11:33:46 -03:00
Ramón Souza
03b1f13ab5 fix duplicated presentation on remove + upload 2022-08-22 10:37:05 -03:00
KDSBrowne
9c018ee6db restore large toolbar size when view enlarged 2022-08-21 21:38:54 +00:00
Anton Georgiev
4b8b216bbe
Merge pull request #15566 from antobinary/cairosvg
chore: Merge BBB 2.5 into 2.6
2022-08-19 14:32:24 -04:00
Ramón Souza
7dd5a3daa9 fix emoji picker button styles 2022-08-19 15:19:10 -03:00
Ramón Souza
318807b9e4
Merge pull request #15533 from JoVictorNunes/issue-15509
fix: push layout not working unless changed
2022-08-19 13:45:17 -03:00
Anton Georgiev
bbb7dd421d Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into cairosvg 2022-08-19 14:25:03 +00:00
Ramón Souza
3a1d0fc09e undo page_count_exceeded changes in service 2022-08-19 11:20:58 -03:00
Anton Georgiev
1b7b63baf6 Merge branch 'v2.5.x-release' of github.com:bigbluebutton/bigbluebutton into cairosvg 2022-08-19 14:14:54 +00:00
Anton Georgiev
23c0dc56c4 Merge branch 'v2.5.x-release' of github.com:bigbluebutton/bigbluebutton into cairosvg 2022-08-19 13:04:00 +00:00
germanocaumo
7bf8668f23 Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into tldraw-viewbox-sync 2022-08-18 18:41:27 +00:00
germanocaumo
99549d880f fix(tldraw): fit-to-width / presenter change view area sync
- Correctly sync the viewed area when in fit-to-width mode and when the presenter reloades the page or the presenter changes to another user.
2022-08-18 18:18:02 +00:00
Ramón Souza
ff52b6ae28 fix presentation snapshot feature 2022-08-18 15:17:38 -03:00
Ramón Souza
81b15ae329
Merge pull request #15518 from JoVictorNunes/issue-15291
fix: incorrect calculation of number of users in multi user whiteboard
2022-08-18 10:52:34 -03:00
Gabriel Porfirio
35cac6ce8d added data-test to the about button and modal 2022-08-18 08:46:31 -03:00
Gustavo Trott
222a763b8c Prevent client to end meeting while trying to restablish authentication 2022-08-17 14:08:55 -03:00
Ramón Souza
30a17562c1
Merge pull request #15539 from JoVictorNunes/issue-15484
style: presentation toolbar in RTL mode
2022-08-17 13:53:13 -03:00
Ramón Souza
408a66eb49
Merge pull request #15531 from KDSBrowne/bbb-tldraw-pan
refactor: Add Pan Button to Presentation Toolbar
2022-08-17 13:44:31 -03:00
KDSBrowne
554c792345 restrict pan tool shortcut to presenter only 2022-08-17 15:36:56 +00:00
KDSBrowne
f1ba37fc2f handle active pan state via shortcut 2022-08-17 15:23:48 +00:00
Ramón Souza
54e2618011 adjust large file error on presentation 2022-08-17 10:17:26 -03:00
Ramón Souza
b90d4ce81e fix conversion state 2022-08-16 17:26:42 -03:00
germanocaumo
98d431ad92 fix(recording): correctly save tldraw pan/zoom events 2022-08-16 19:11:49 +00:00
Joao Victor
eb8838dfaa fix: show conversion process info in toast #15505 2022-08-16 12:04:02 -03:00
Ramón Souza
a895b087f9 display page exceeded error on presentation uploader 2022-08-16 11:41:11 -03:00
germanocaumo
d4b8bdce7e fix(tldraw): sync viewed area between presenter/viewers +
- Return to the ResizeAndMoveSlide event to do pan&zoom, respecting the viewed width and height ratio
- Defaults zoom in toolbar to 100% like before to be more consistent
- Fit to width and Reset Zoom is back (fit tho width still has some sync problems)
- Fix to not change to first page when presenter reloads page
2022-08-16 12:12:43 +00:00
prlanzarin
0e162f1cda feat: configurable DSCP marking for WebRTC media
RTCRTPSender exposes DSCP marking via `networkPriority` in the encodings
configuration dictionaries. That should allow us to control
QoS priorities for different media streams, eg audio with higher network
priority than video. The only browser that implements that right
now is Chromium.

To use this, the public.app.media.networkPriorities configuration in
settings.yml. Audio, camera and screenshare priorities can be controlled
separately. For further info on the possible values, see:
  - https://www.w3.org/TR/webrtc-priority/
  - https://datatracker.ietf.org/doc/html/rfc8837#section-5
2022-08-15 21:24:05 +00:00
Gustavo Trott
ee560bf188 Makes meeting-ended and error-screen show ejectedReason message 2022-08-15 17:25:45 -03:00
Gustavo Trott
6ebdca8dc6 Makes meeting-ended and error-screen show ejectedReason message 2022-08-15 14:59:58 -03:00
Joao Victor
14d8200742 style: presentation toolbar 2022-08-15 14:56:10 -03:00
Ramón Souza
082057ba55
Merge pull request #15177 from JoVictorNunes/issue-15111
fix: restore virtual background after leaving breakout room
2022-08-15 14:45:37 -03:00
KDSBrowne
48157ae49b reset pan when not zoomed | presenter change 2022-08-15 13:17:36 +00:00
KDSBrowne
12a324631f update cursor type when pan enabled 2022-08-15 13:02:56 +00:00
Ramón Souza
f851765ab3 fix presentation downloadable state 2022-08-15 09:50:07 -03:00
Joao Victor
f4fc11d53b fix: condition to switch between layouts 2022-08-15 09:21:29 -03:00
Joao Victor
9507797588 fix: update of settings 2022-08-15 08:18:24 -03:00
KDSBrowne
26f3e5dc3f add pan button to presentation toolbar 2022-08-14 22:49:39 +00:00
KDSBrowne
df0fc0da15 make whiteboard toolbar responsive to small screens 2022-08-12 19:08:26 +00:00
GuiLeme
491380096e [apply-toast-shared-notes] - changes in review and resolve merge conflict 2022-08-11 15:50:06 -03:00
Joao Victor
8e9ca4b2c8 fix: incorrect calculation of number of users in multi user whiteboard 2022-08-11 15:44:16 -03:00
GuiLeme
6c319b5183 [apply-toast-shared-notes] - changes in review~ 2022-08-11 15:07:42 -03:00
Ramón Souza
c032009677 fix remove presentation bug 2022-08-11 14:27:29 -03:00
Joao Victor
60857a0056 fix(tldraw): hide context menu for users who don't have access to whiteboard 2022-08-11 13:38:17 -03:00
Ramón Souza
a1dd5f0a36
Merge pull request #15466 from JoVictorNunes/issue-15341
fix(layout): don't show `navbar`/`actions-bar` before layout has been calculated
2022-08-10 14:47:22 -03:00
Ramón Souza
c0246215d4
Merge pull request #15502 from KDSBrowne/bbb-tldraw-keys
refactor: Add Remaining Shortcut Keys to Help Modal
2022-08-10 13:37:35 -03:00
GuiLeme
c65def5a0f [apply-toast-shared-notes] - ajustments to maintain flow 2022-08-10 11:57:53 -03:00
Ramón Souza
44966f3e18
Merge pull request #15501 from KDSBrowne/bbb-tldraw-dock-position
fix: Position Whiteboard Toolbar with API | Sync Current Locale
2022-08-09 17:16:19 -03:00
GuiLeme
246153e62c [apply-toast-shared-notes] - Removed some of the comments and separated toast controller 2022-08-09 12:24:44 -03:00
Ramón Souza
c65ed3c785
Merge pull request #15494 from ramonlsouza/media-fix-port
fix: port screenshare/external video fixes to 2.5
2022-08-09 10:11:52 -03:00
KDSBrowne
7f4151e6eb update shortcut keys list 2022-08-09 11:45:46 +00:00
KDSBrowne
3ebfdef9bd use api toolbar general position | sync current locale 2022-08-08 22:47:51 +00:00
GuiLeme
93b51ded53 [apply-toast-shared-notes] - Finished separation of the component 2022-08-08 17:42:06 -03:00
Joao Victor
74c4c1c4cc fix: don't clear text fake annotations 2022-08-08 17:07:41 -03:00
Ramón Souza
c48e942a62
Merge pull request #15488 from ramonlsouza/fix-dialin-button-styles
fix(styles): adjust dial-in button styles
2022-08-08 10:49:19 -03:00
GuiLeme
147f339e55 [apply-toast-shared-notes] - change the tracker from the service, implemented the solution to shared notes. 2022-08-08 08:50:52 -03:00
Ramón Souza
a7495ad16b add presentation snapshot button data-test 2022-08-05 13:14:27 -03:00
Ramón Souza
da370a10cb
Merge pull request #15475 from ramonlsouza/fix-cc-icon-position
fix: adjust captions icon position
2022-08-05 11:02:00 -03:00
Ramón Souza
4721184eb6 fix mobile init values for external video/screnshare 2022-08-05 09:52:48 -03:00
prlanzarin
6f13961018 fix(layout): set external-video/screen share initial states on all layouts
Only smart layout takes screen sharing/external video states in account
when populating its initial state. The others don't, and that causes
some weird issues when switching back-and-forth between layout types due
to their input states becoming inconsistent - ie having an active screen
sharing and transitioning from Smart -> Custom would mark it as false
(due to its absence from the initial state) and pollute its state for
subsequent layouts.

This commit guarantees those features are taken into account when
populating initial input states for Focus On*/Custom layouts.
2022-08-05 09:52:36 -03:00
Gustavo Trott
3e6d546062
Merge pull request #15367 from danielpetri1/pdf-disabledFeatures-tldraw 2022-08-04 21:51:57 -03:00
Ramón Souza
eb19199235 adjust dial-in button styles 2022-08-04 14:17:45 -03:00
KDSBrowne
942327f4f1 Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into bbb-tldraw-latest 2022-08-04 12:51:48 +00:00
Ramón Souza
9cfc3e7edd
Merge pull request #15343 from frankemax/dynamic-filter-emojis
feat(emoji-picker): dynamically filter emojis
2022-08-04 09:42:56 -03:00
KDSBrowne
48cc57dbaf move variable definition 2022-08-03 14:30:22 +00:00
KDSBrowne
7ade8a0d7d Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into bbb-tldraw-latest 2022-08-03 14:23:38 +00:00
KDSBrowne
b66e44a4cb Upgrade tldraw to latest version 2022-08-03 14:19:12 +00:00
GuiLeme
1e0700b455 [apply-toast-shared-notes] - merge 26 and resolved conflicts 2022-08-03 11:12:55 -03:00
Ramón Souza
7408523b2c
Merge pull request #15473 from KDSBrowne/bbb-15381
refactor: Add Whiteboard Shortcuts to Help Modal
2022-08-03 10:23:41 -03:00
Ramón Souza
ded8493f05 Merge remote-tracking branch 'upstream/v2.5.x-release' into 2526-aug3 2022-08-03 09:53:41 -03:00
Ramón Souza
9e219d9cb3 adjust cc icon position 2022-08-02 17:33:53 -03:00
GuiLeme
74caa9cb5f [apply-toast-shared-notes] - Savepoint - Made some changes 2022-08-02 17:25:15 -03:00
KDSBrowne
7c6f7f64b1 update icons in shortcuts modal 2022-08-02 15:33:33 +00:00
Anton Georgiev
ca0195585f
Merge pull request #15441 from antonbsa/audio-tests
test: Add new audio tests
2022-08-02 11:07:04 -04:00
Daniel Petri Rocha
3529fe9f28 Rename parameters; hide download button and label when disabled 2022-08-02 15:53:40 +02:00
KDSBrowne
b838d3862d localize tabs in shortcut modal 2022-08-02 11:43:29 +00:00
KDSBrowne
aabfdbb991 update shortcut modal style | add new shortcuts for WB 2022-08-01 22:41:48 +00:00
Joao Victor
efb40e00bb fix(layout): don't show navbar/action-bar before layout has been calculated 2022-07-29 16:02:31 -03:00
Gabriel Porfirio
8198953f30 removing unused imports 2022-07-28 16:50:31 -03:00
Ramón Souza
d9f2660d6a
Merge pull request #15330 from JoVictorNunes/vb-improvements-Jul-04
improvement(virtual background): better error handling, notifications…
2022-07-28 09:25:00 -03:00
Ramón Souza
40f61ecce4
Merge pull request #15452 from JoVictorNunes/fix-crash-remove-background
fix: check virtual background index
2022-07-27 16:40:46 -03:00
Ramón Souza
49b12e57c0
Merge pull request #15446 from KDSBrowne/2.6-console-err
fix(wb): Fix Console Type Error on Shape Hover
2022-07-27 16:20:24 -03:00
Joao Victor
d2eda01bcb fix: check for undefined value 2022-07-27 16:15:19 -03:00
KDSBrowne
a485f372f6 fix console error 2022-07-27 18:46:44 +00:00
Ramón Souza
1da57d8c50
Merge pull request #15455 from ramonlsouza/add-missing-media-init
fix: In Android Screen share and Share external video not showing to newly joined
2022-07-27 15:01:36 -03:00
Ramón Souza
b4fb203593 fix mobile init values for external video/screnshare 2022-07-27 10:56:04 -03:00
Ramón Souza
ccce085aed Merge remote-tracking branch 'upstream/v2.6.x-release' into issue-15001 2022-07-27 09:49:19 -03:00
Ramón Souza
640356af4f
Merge pull request #15442 from ramonlsouza/issue-15431
fix: chat panel resizing in RTL
2022-07-27 09:05:21 -03:00
Joao Victor
fe669b2f58 fix: check virtual background index 2022-07-27 09:00:18 -03:00
Gustavo Trott
acb0465266
Merge pull request #15412 from JoVictorNunes/export-presentation 2022-07-26 17:49:09 -03:00
Ramón Souza
b00d19b097
Merge pull request #15110 from ramonlsouza/fix-restore-on-update
fix: autoSwapLayout/restoreOnUpdate new presentation fails to show (2.5)
2022-07-26 16:38:33 -03:00
Ramón Souza
b14e5bc290
Merge pull request #15416 from KDSBrowne/v2.6.x-viewer-resize-wb-crash
Prevent Viewer Panel Resize Crashing Whiteboard
2022-07-26 15:50:15 -03:00
Joao Victor
26cd80506e fix: snapshot of current slide 2022-07-26 11:54:50 -03:00
GuiLeme
f0c95c4fe5 [apply-toast-shared-notes] Checkpoint - moving responsability of monitoring the upload to the service 2022-07-26 09:25:36 -03:00
Ramón Souza
4f39e419ac
Merge pull request #15421 from gabriellpr/waiting-list-feedback
fix: Adding notification to waiting users list
2022-07-26 09:06:20 -03:00
Joao Victor
07434d238c refactor: toast notification rework 2022-07-25 18:56:26 -03:00
Ramón Souza
c6f4056677 fix chat resizing in RTL 2022-07-25 16:53:19 -03:00
Joao Victor
5c6c28cdd2 Fix conflicts 2022-07-25 15:14:27 -03:00
Ramón Souza
01ba2a27f5
Merge pull request #15332 from JoVictorNunes/virtual-backgrounds-skeleton-preview
improvement(virtual background): loading skeleton, custom backgrounds in video preview modal
2022-07-25 13:34:22 -03:00
Ramón Souza
890ca5c4a0
Merge pull request #15429 from prlanzarin/u26/fix/screenshare-layout-dimensions
fix(layout): use actual screen share size when calculating smart layout
2022-07-25 13:02:00 -03:00
Gabriel Porfirio
15b28d52fe updating feedback message 2022-07-22 13:27:39 -03:00
prlanzarin
b8811bafd4 fix(layout): use actual screen share size when calculating smart layout
Smart layout (et al) presumes screen sharing will always use 100%
width of the media area. That causes cameras to always be positioned on
top, which is not always the optimal position depending on the viewport
and stream aspect ratio/resolution - so space is wasted.

This commit uses the actual screen sharing video size as provided by
HTMLVideo's videoWidth/videoHeight properties. The calculation uses the
same logic as the one used for presentation/slides, which should make it
a bit familiar.

There's also a handler for HTMLVideo's `resize` event for those browsers
that support it - which enables handling of variable-sized screen
sharing streams. That handler is debounced at 500 ms to prevent
excessive CPU use.

Extra testing is needed with the widest range possible of
browsers/environments and feature combinations.
2022-07-22 13:28:43 +00:00
Ramón Souza
7c4457bfa1
Merge pull request #15415 from JoVictorNunes/issue-15397
fix: breakout remaining time label
2022-07-22 14:23:47 +01:00
Joao Victor
dbafb610d5 fix: whiteboard access avatar icon in RTL mode 2022-07-22 10:16:57 -03:00
GuiLeme
82e0204cfa [apply-toast-shared-notes] - Savepoint refactor toast 2022-07-22 10:06:32 -03:00
Ramón Souza
9c8c580db2
Merge pull request #15424 from prlanzarin/u26/fix/layout-ss-calc
fix(layout): set external-video/screen share initial states on all layouts
2022-07-22 13:12:31 +01:00
Joao Victor
ce7f35b3db fix: checkbox and remove button alignment in RTL languages 2022-07-21 17:30:25 -03:00
Anton Georgiev
d7bdc324a0 chore: pull BBB 2.5.4+ into 2.6 2022-07-21 20:25:31 +00:00
Joao Victor
e59e3b68af fix: header alignment 2022-07-21 17:20:03 -03:00
GuiLeme
dbb2681b28 WIP - started refactoring service 2022-07-21 15:56:44 -03:00
prlanzarin
8f77f4cd1f fix(layout): set external-video/screen share initial states on all layouts
Only smart layout takes screen sharing/external video states in account
when populating its initial state. The others don't, and that causes
some weird issues when switching back-and-forth between layout types due
to their input states becoming inconsistent - ie having an active screen
sharing and transitioning from Smart -> Custom would mark it as false
(due to its absence from the initial state) and pollute its state for
subsequent layouts.

This commit guarantees those features are taken into account when
populating initial input states for Focus On*/Custom layouts.
2022-07-21 18:07:49 +00:00
Gabriel Porfirio
94cfa3c084 WIP: Adding notification to waiting users list 2022-07-21 14:07:19 -03:00
KDSBrowne
9234dee077 fix viewer wb crash switching to rtl 2022-07-20 19:54:23 +00:00
KDSBrowne
db41932fe7 update render wb condition | add operator 2022-07-20 19:20:46 +00:00
KDSBrowne
21f2a441ee update editable whiteboard component key 2022-07-20 19:03:26 +00:00
KDSBrowne
9d8ce2215d remove key prop 2022-07-20 18:51:50 +00:00
KDSBrowne
fb63975a7e fix viewer WB crash when resizing 2022-07-20 18:50:13 +00:00
prlanzarin
6c8b097eba fix: add option to disable transcription in mobile, extend support check
Mobile endpoints are flaky with the WebSpeechAPI:
  - iOS versions that support it are borking our outbound audio when it's
    enabled
  - Android speech recognition has flaky locale detection and speech
    transcription
Additionally: the support check is not checking the WebSpeechAPI
availability properly, so older devices (eg iOS 12) are flagged as
supported even though they aren't.

This commit adds a configuration flag (public.audioCaptions.mobile) to
control transcription availability on mobile. False by default.
Also extends the setSpeechVoices support check and
hasSpeechRecognitionSupport method to prevent false positives.
2022-07-20 17:20:54 +00:00
Arthurk12
e93b9739de style(captions): adds border to toggle button 2022-07-20 17:20:53 +00:00
Max Franke
75eef650e6 feat(audio-captions): reallocate button from mobile
Remove CC button toggle in the action bar only in mobile.
Add a new CC button toggle in settings dropdown only to mobile.
2022-07-20 17:20:53 +00:00
Arthurk12
c96b53093c feat(captions): adds locale settings
Adds two new flags to the settings file which change the way the locale
flag is used:

- forceLocale: (true/false) => If true, enforces the transcription
  language to be the locale content field and jumps the language
selector
  in audio modal.
- defaultSelectLocale: (true/false) => If true, the default selected
  value in the dropdown language selector in audio modal will be defined
  by the locale content field.

In any case, if the locale flag holds an invalid value, it defaults to
disabled.
2022-07-20 17:20:53 +00:00
Arthurk12
da9adca229 fix(captions): talking indicator icon
Prevents the speech recognition from being initialized when the closed
captions feature is disabled.
2022-07-20 17:20:52 +00:00
Pedro Beschorner Marin
d553ca65cf feat(captions): use navigator language
If not set to use the default language, try to select the navigator
language as speech default locale.
2022-07-20 17:20:52 +00:00
Pedro Beschorner Marin
116c0d9a49 fix(captions): filter duplicated languages
Avoid multiple instances of the same language at the voices data.
2022-07-20 17:20:52 +00:00
Pedro Beschorner Marin
51eeb092b3 refactor(captions): configurable languages
Move the language collection to the HTML settings file. This data defines
the available languages available for the speech API.

These language tags are used to filter SpeechSynthesis' API `getVoices`
result. Tags must use BCP 47 format.

https://developer.mozilla.org/en-US/docs/Web/API/SpeechSynthesisVoice/lang
2022-07-20 17:20:52 +00:00
Pedro Beschorner Marin
b52c67d7a7 feat(captions): first pass on recording
Add the main server-side adapter for using the legacy closed captions
recording process with the audio captions data.
2022-07-20 17:20:52 +00:00
Pedro Beschorner Marin
aa7f2abae2 feat(captions): talking users' floor
Associate the floor status with the talking users to improve feedback
on automated closed captions.
2022-07-20 17:20:51 +00:00
Pedro Beschorner Marin
1064aab84d style(captions): add background alpha
Add some transparency to the background color.
2022-07-20 17:20:51 +00:00
Pedro Beschorner Marin
fb48e61d6d feat(captions): add talking indicator feedback
Inform other users about who are the current talkers with the speech
recognition enabled.
2022-07-20 17:20:51 +00:00
Pedro Beschorner Marin
df184b542c feat(captions): add unsupported warning
Add a disclaimer for users on browsers that do not provide speech synthesis'
voices.
2022-07-20 17:20:51 +00:00
Pedro Beschorner Marin
307ab6ea40 feat(captions): add author avatar
Include captions' author avatar at the live feedback to improve identification.
2022-07-20 17:20:50 +00:00
Pedro Beschorner Marin
d00909751a refactor(captions): change getVoices routine
In some cases, `getVoices` returns an empty array even if the browser's vendor
has full support for speech synthesis. Add a trigger call to initiate the
voices fetching process.

As drafted, `getVoices` can be an asynchronous call and monitoring it
depends on the support of a `voiceschanged` event. Although many of the
main vendors support voices, this event is not (yet) by Safari.

https://wicg.github.io/speech-api/#dom-speechsynthesis-getvoices
https://wicg.github.io/speech-api/#eventdef-speechsynthesis-voiceschanged
https://developer.mozilla.org/en-US/docs/Web/API/SpeechSynthesis/voiceschanged_event
2022-07-20 17:20:50 +00:00
Pedro Beschorner Marin
d6dc66f57e feat(captions): language selector
Replace the checkbox with a selector up with 3 languages: en-US, es-ES and pt-BR.

Add setting option to enable by default with predetermined locale.
2022-07-20 17:20:50 +00:00
Pedro Beschorner Marin
5671bd7d3c fix(captions): check for voices
Avoid enable audio transcription if the browser's vendor does not provide
voices data.

This should prevent false positives for browsers such as Chromium and
Brave.
2022-07-20 17:20:49 +00:00
Pedro Beschorner Marin
e131925370 style(captions): font-family fallback
Add extra `sans` alternatives
2022-07-20 17:20:49 +00:00
Pedro Beschorner Marin
d688a2572f fix(captions): remove padding when no content
Avoid rendering the captions wrapper's padding when there's no data to
be displayed at the live feedback.
2022-07-20 17:20:49 +00:00
Pedro Beschorner Marin
f726cb0ad5 refactor(captions): UX improvements
Parse the audio transcript before broadcasting it's content back to the
client and the recording actor. Limiting by 8 words per line and max of
2 lines to avoid CPU intensive operations over this recurring event.

Replace Calibri font family with Verdana to improve character spacing,
add relative sizing to the text content and a background padding.
2022-07-20 17:20:49 +00:00
Pedro Beschorner Marin
75969ec93c feat(captions): audio captions app
Add a server-side app for the audio captions feature and record proto-events
for this data.

As it is, only behaves as a pass-through module. The idea is to include all
the business intelligence in this app.
2022-07-20 17:20:48 +00:00
Pedro Beschorner Marin
0bc730b3e3 refactor(captions): improve recovery
Use the user's talking state to trigger a speech API recovery after long
periods of silence.
2022-07-20 17:20:48 +00:00
Pedro Beschorner Marin
944edf2ccf feat(captions): web speech prototype
Hardcoded pt-BR prototype for closed captions generated by the browser's
WebSpeech API.
2022-07-20 17:20:48 +00:00
Joao Victor
a1ed921039 fix: breakout remaining time label 2022-07-20 12:22:46 -03:00
Joao Victor
cff1c087a8 feat: front-end support for exporting presentations with annotations 2022-07-19 16:36:00 -03:00
KDSBrowne
100bfcfb86 update fullscreen element check 2022-07-19 10:51:59 +00:00
KDSBrowne
ed55d58b01 handle cursor positions for video focus 2022-07-19 03:37:47 +00:00
KDSBrowne
47303757de handle cursor position for fullscreen presentation 2022-07-19 01:23:10 +00:00
Ramón Souza
f083bb9a20
Merge pull request #15273 from JoVictorNunes/issue-15272
fix: apply presentation 'isCurrent' changes to local state
2022-07-18 21:19:20 +01:00
Ramón Souza
2fd65dfc1c
Merge pull request #15099 from schrd/fix-issue-14982
Fix: only show breakout room in user list when user is in breakout room
2022-07-18 21:17:17 +01:00
Anton B
944e0b2981 test: add audio tests 2022-07-15 17:54:16 -03:00
Joao Victor
0ac69cba0a fix: comparison to render custom buttons 2022-07-15 17:16:33 -03:00
Joao Victor
34aaf07fed Merge branch v2.6.x-release into virtual-backgrounds-skeleton-preview 2022-07-15 17:14:16 -03:00
Paulo Lanzarin
383fe89653
Merge pull request #15364 from prlanzarin/u26/refactor/kutils-kboom
refactor: remove kurento-utils-js
2022-07-15 14:53:10 -03:00
prlanzarin
d06ae5ce40 fix: add default gUM factory to new peer wrapper
For scenarios such as preview-less camera sharing, old echo test
2022-07-15 17:07:15 +00:00
Anton Georgiev
f2e25768c7
Merge pull request #15390 from ramonlsouza/merge25-26-jul14
chore: Merge v2.5.3 into v2.6
2022-07-15 11:43:17 -04:00
Ramon Souza
83d9feb9c0 fix missing import in audio controls 2022-07-15 11:41:11 -03:00
Ramon Souza
d08ff18add Merge remote-tracking branch 'upstream/v2.6.x-release' into merge25-26-jul14 2022-07-15 11:12:25 -03:00
Ramon Souza
db5ac1428a Merge tag 'v2.5.3' into merge25-26-jul14 2022-07-15 11:08:02 -03:00
prlanzarin
6a4ceac61f refactor(webcam): swap kurento-utils for the new peer wrapper 2022-07-15 14:00:12 +00:00
Ramón Souza
267a6f5c9c
Merge pull request #15203 from ramonlsouza/improve-ghost-button-border
style: improve ghost buttons border in low density display
2022-07-15 12:06:59 +01:00
Ramón Souza
da848e990a
Merge pull request #15320 from gabriellpr/dark-light-buttons
Styling light and dark buttons
2022-07-13 21:03:46 +01:00
gabriellpr
1c2f9e9cd9
Update styles.js 2022-07-13 16:35:02 -03:00
Paulo Lanzarin
3e8ccd370d
Merge pull request #15375 from prlanzarin/u26/fix/local-echo-gUM-block
fix(audio): block audio join while gUM isn't resolved (local echo)
2022-07-13 15:57:02 -03:00
gabriellpr
49f12c43af
Merge branch 'v2.6.x-release' into dark-light-buttons 2022-07-13 15:36:31 -03:00
prlanzarin
27896e74e6 fix(audio): block audio join while gUM isn't resolved (local echo)
The new local echo view doesn't block the "Join audio" button while
awaiting for getUserMedia permission to be granted/denied. That may
cause unexpected behavior when unattentive users just click "Join audio"
without granting or denying gUM.

This commit accounts for gUM resolution when deciding whether to block
the "Join audio" button. It also includes an extra "isConnecting" check
to it to avoid spam-clicking issues.
2022-07-13 14:35:37 +00:00
Ramón Souza
04386dfcd5
Merge pull request #15212 from gabriellpr/styling-buttons
style: Revised styles for our secondary buttons
2022-07-13 15:22:49 +01:00
Ramón Souza
a0f80e0efb
Merge pull request #15353 from gabriellpr/contrast-record-indicator
Improving contrast on recording indicator
2022-07-13 15:20:36 +01:00
prlanzarin
7b76d2e88f fix: change local echo Stop hearing locale to Stop audio feedback 2022-07-13 13:59:49 +00:00
Anton Georgiev
1393e4a7de
Merge pull request #15352 from germanocaumo/tldraw-z-f
fix(tldraw): initial/viewer zoom fixes + presToolbar height
2022-07-13 09:42:36 -04:00
Anton Georgiev
70c084bfdb
Merge pull request #15300 from JoVictorNunes/fix-focus-loss-Jun-30
fix: disable Tldraw autofocus
2022-07-13 09:39:06 -04:00
Paulo Lanzarin
64af188f1b
Merge pull request #15371 from prlanzarin/u26/fix/webcam-oninactive
fix(webcam): handle stream inactivation/gUM revocations
2022-07-13 10:37:36 -03:00
Anton Georgiev
20762cfac6
Merge pull request #15310 from germanocaumo/tldraw-production-fix
fix(tldraw): fix shapes not persisting in production +
2022-07-13 09:36:44 -04:00
prlanzarin
029c957b22 fix(webcam): handle stream inactivation/gUM revocations
The 'inactive' event is fired whenever the stream gets inactive (ie it
cannot be used anymore), and there are scenarios where that is
unexpected behavior and must be handled accordingly.
The main example of that is when gUM permissions are revoked by the user
via the browser's permission management panel.
Since MediaStream/Track inactive events aren't being handled in such
scenarios, what actually happens is that the camera just freezes without
further indication why.

This commit handles those scenarios in both video-preview and
video-provider by:
  - 1) correctly stopping the camera (provider)
  - 2) surfacing a toast (provider) or error indication (preview)
2022-07-12 22:03:01 +00:00
prlanzarin
e93440e15a refactor(webcam): fix linter errors in BBBVideoStream 2022-07-12 17:50:16 +00:00
prlanzarin
fba2c88494 fix(audio): make hearing a transient prop in local-echo
Prevents annoying console exceptions in dev mode
2022-07-12 16:37:36 +00:00
Joao Victor
cca17f9def fix(chat): property access 2022-07-12 10:25:50 -03:00
Anton Georgiev
40a8034070
Merge pull request #15313 from antonbsa/test-fixes-v2.6
test: Fix v2.6 tests
2022-07-11 18:21:33 -04:00
Anton B
d00699561f fix data-test props to same quote type 2022-07-11 17:35:14 -03:00
Joao Victor
2f78edddf3 fix: add suport for disabling upload of custom backgrounds through custom parameter 2022-07-08 17:01:57 -03:00
Gabriel Porfirio
aecc5fa710 WIP: improving contrast on recording indicator 2022-07-08 14:39:14 -03:00
gabriellpr
17a1bc086f
Update styles.js 2022-07-08 13:53:30 -03:00
germanocaumo
0c75b3ce02 fix(tldraw): correctly get toolbar height
This solves the problem where the toolbar is not counted in the slide area space, so the presentation would stay behind the toolbar when zoomed out
2022-07-08 15:45:55 +00:00
Joao Victor
8809ff3a65 fix: add missing activity date in drag & drop handler 2022-07-08 12:26:01 -03:00
Joao Victor
915ffce3c6 improvement: sort buttons by recently used/uploaded 2022-07-08 12:16:37 -03:00
germanocaumo
217fd6c06e fix(tldraw): wrong initial/viewer zoom
Fixes a case when the presentation is just uploaded and a wrong initial zoom was set.
Also fix viewer zoom not correclty adjusting to the area size when zoomed out.
2022-07-08 15:06:00 +00:00
Joao Victor
f8ec4ef640 refactor: virtual background context 2022-07-07 18:59:30 -03:00
Max Franke
52e27e8030 feat(emoji-picker): dynamic filter emojis
Configure filtered emojis via settings.yml
Emojis can be filtered by their unicodes
2022-07-07 13:12:35 -03:00
gabriellpr
f848d31014 modifying specific buttons
removing border and implementing box-shadow

adding transparent border

passing styles to common buttons

adding secundary color to component

updating color components
2022-07-07 10:45:54 -03:00
Ramón Souza
1b03b1fd50
Merge pull request #15301 from KDSBrowne/z-26-rtl-cursor
Fix RTL Cursor Position on Whiteboard
2022-07-06 21:40:19 +01:00
KDSBrowne
046518abe5 handle cursor positions for smart layout 2022-07-06 20:03:04 +00:00
Joao Victor
8481103e47 improvement(virtual background): loading skeleton, custom backgrounds in video preview modal 2022-07-06 16:03:55 -03:00
Mario Junior
72854de683
Merge pull request #15295 from iMDT/v2.6.x-mobile
feat (mobile screenshare): Add replacement webRTC methods for screenshare and full audio in mobile (when running in BigBlueButtonMobile app)
2022-07-06 15:46:25 -03:00
KDSBrowne
42acca2124 handle cursor position for all custom layout orientations 2022-07-06 17:17:05 +00:00
Anton B
d6f32f3422 Merge remote-tracking branch 'upstream/v2.6.x-release' into test-fixes-v2.6 2022-07-06 11:07:00 -03:00
Ramón Souza
f66481411e
Merge pull request #15239 from JoVictorNunes/issue-15059
fix: screen sharing data saving option
2022-07-06 14:42:41 +01:00
Ramón Souza
16d871bdb5
Merge pull request #15174 from ramonlsouza/fix-poll-results-chat
fix: wrong poll results displayed in the chat when answers are grouped
2022-07-06 14:42:28 +01:00
Anton Georgiev
eca4ebe56f
Merge pull request #15221 from MaximKhlobystov/25-test-update
test: New 2.5 tests + links from test specs to 2.5 test plan
2022-07-06 09:39:49 -04:00
Joao Victor
aaf7f8e78e improvement(virtual background): better error handling, notifications, performance 2022-07-06 10:38:40 -03:00
KDSBrowne
b075cf822b fix delay minimizing presentation | display default cursor for no MUA 2022-07-05 20:16:55 +00:00
Ramon Souza
29d597f7df Merge remote-tracking branch 'upstream/v2.6.x-release' into improve-ghost-button-border 2022-07-05 14:06:19 -03:00
Ramon Souza
d55ee67f5e Merge remote-tracking branch 'upstream/v2.6.x-release' into fix-duplicated-label-webcam 2022-07-05 14:02:02 -03:00
Anton Georgiev
4595b6688f
Merge pull request #15244 from germanocaumo/tldraw-recording
fix(whiteboard): tldraw recording processing/publishing
2022-07-05 08:55:01 -04:00
gabriellpr
8d75eddd88 WIP: styling light and dark buttons 2022-07-05 09:05:46 -03:00
Ramón Souza
a1ac9fe11d
Merge pull request #15293 from ramonlsouza/restore-audio-shortcuts
fix: audio shortcuts regression
2022-07-04 21:09:27 +01:00
Joao Victor
4ab0a82c7a refactor: Icon component rotate info 2022-07-04 12:27:46 -03:00
Ramon Souza
9e246093f9 remove duplicated webcam label 2022-07-04 10:41:27 -03:00
germanocaumo
8cacd96a0c fix(tldraw): fix shapes not persisting in production +
Tldraw uses the constructor name for session complete names:
80ed0bf27b/packages/tldraw/src/state/TldrawApp.ts (L2916)
So in production they are changed because of js minifier.

I changed the onCommand reactor to be one generic for all session:complete actions.
Also fixed some crashes with grouping and ungrouping shapes, in those cases the order of adding/removing is important because children have a reference to the father (grouping shape).
2022-07-02 14:16:45 +00:00
Anton B
c71e5c9f74 test: fix all 2.6 tests and temporarily skip inconsistent ones 2022-07-01 17:55:32 -03:00
Ramon Souza
67abbe9489 only remove annotations/cursors when multiUser is disabled 2022-07-01 14:38:12 -03:00
Ramon Souza
f74beed916 fix(whiteboard): don't hide presenter's cursor 2022-07-01 14:37:23 -03:00
Ramon Souza
b5cf43b04e fix: cursor displaying for another users 2022-07-01 14:35:16 -03:00
Ramon Souza
4acbce94cd fix: clear cursors data on multi-user whiteboard off 2022-07-01 14:32:34 -03:00
Joao Victor
66d3d2c13b fix: clear fake annotations on multi-user whiteboard off 2022-07-01 14:31:14 -03:00
Ramón Souza
baf7aa857a
Merge pull request #15304 from JoVictorNunes/fix-virtual-background-thumb-Jun-30
improvement: virtual background selector thumbnail
2022-07-01 14:05:39 +01:00
Joao Victor
93d98d9b3e fix: margin unit 2022-06-30 17:10:48 -03:00
Joao Victor
5e2c113cae improvement: virtual background selector thumbnail 2022-06-30 16:39:50 -03:00
KDSBrowne
438afa7db1 fix RTL cursor position 2022-06-30 16:48:42 +00:00
Joao Victor
ddcaa9590f fix: disable Tldraw autofocus 2022-06-30 13:23:35 -03:00
germanocaumo
c2db91b5f9 Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into tldraw-recording 2022-06-30 14:31:08 +00:00
Ramón Souza
1181b54a55
Merge pull request #15279 from KDSBrowne/2.6-mobile-cursor-fix
Fix Cursor Not Updating For Mobile
2022-06-30 14:10:11 +01:00
Tiago Jacobs
75c8dcd491 Merge 2.6 2022-06-29 17:38:21 -03:00
KDSBrowne
bf62362162 only render cursor label when mutiuser enabled 2022-06-29 20:27:14 +00:00
Paulo Lanzarin
8f6b65b23c
Merge pull request #15290 from prlanzarin/u26/fix/button-audio-props
fix: omit unused props in talking-indicator, input stream selector and EmojiButton
2022-06-29 16:45:57 -03:00
Ramon Souza
a29b651d9c restore audio mute / leave shortcuts 2022-06-29 15:19:30 -03:00
prlanzarin
0fead2ebbb fix: omit unused props in talking-indicator, input stream selector and emoji button
The talking-indicator, emoji-button and input-live-stream-selector
components are passing props downstream that weren't omitted or handled
by inherited components (Button, Icon). That causes a handful of error
logs to be spammed in the console of dev environments, which is
annoying.

This commit addresses the issue by:
  - Making the talking, spoke, muted and isViewer props transient
    (styled-components) - which means they won't reach the DOM (as
    expected since they're style-only)
  - Omitting the EmojiButton `rotate` prop in the Icon component itself
    * Made that instead of transient because might be useful to migrate
      the rotate code to the Icon component?
2022-06-29 17:15:46 +00:00
Ramón Souza
9a480c247c
Merge pull request #15256 from ramonlsouza/issue-15252
fix: Recording indicator too subtle
2022-06-29 17:04:28 +01:00
Ramón Souza
ffb41cb90f
Merge pull request #15278 from KDSBrowne/2.6-disable-hover-slidebg
Disable Background Slide Image Hover Highlight
2022-06-29 14:31:30 +01:00
Anton Georgiev
046dce804a
Merge pull request #15280 from JoVictorNunes/undefined-values-Jun-28
fix: add check for potential undefined userId
2022-06-28 16:47:52 -04:00
Joao Victor
4b9f16ca0f fix: add check for potential undefined userId 2022-06-28 17:41:03 -03:00
KDSBrowne
c702cc34a4 remove cursors from wb when multiuser is disabled 2022-06-28 20:13:05 +00:00
Ramon Souza
bcd508712e prevent chat-context crash 2022-06-28 16:26:25 -03:00
KDSBrowne
33e19124c1 disable shape selection for users without multiuser access 2022-06-28 19:16:35 +00:00
Joao Victor
3ea33ce3ac fix: apply presentation 'isCurrent' changes to local state 2022-06-28 13:33:54 -03:00
KDSBrowne
ee6a3dcc62 fix cursor not updating on mobile 2022-06-28 14:25:43 +00:00
KDSBrowne
2d7ef92581 disable hover highlight for background slide image 2022-06-28 14:15:20 +00:00
Ramón Souza
74287a204e
Merge pull request #15266 from gabriellpr/modal-audio-design
fix: microphone design inside audio modal
2022-06-28 14:25:45 +01:00
gabriellpr
a3e17490f4 WIP: fix microphone design inside audio modal 2022-06-27 15:23:57 -03:00
Ramon Souza
c3f0c079e5 add big recording indicator for viewers when record is active 2022-06-24 16:25:42 -03:00
Ramon Souza
45dae6953d external upload area in presentation upload modal 2022-06-24 13:47:17 -03:00
germanocaumo
853d0dfd9b fix(whiteboard): tldraw recording processing/publishing
Changed the names of tldraw record events to differentiate from before.
Publish tldraw.json file with all shape information during the meeting to be used in playback.
Adapted cursor.xml and panzoom.xml to store tldraw data.
Publish slides svgs to be used by playback's tldraw component (otherwise we have different image sizes in pngs and thus messing the coordinates).
Retro-compatible with old recordings.
2022-06-23 17:04:09 +00:00
Joao Victor
24504178a6 fix: screen sharing data saving option 2022-06-23 10:05:11 -03:00
Ramón Souza
88697650a2
Merge pull request #15232 from antobinary/merge-252
chore: Merge BBB 2.5.2 into 2.6.x
2022-06-22 19:05:27 +01:00
Ramon Souza
adbe90582e Merge remote-tracking branch 'upstream/v2.5.x-release' into fix-expression-assignment-25 2022-06-22 14:44:20 -03:00
Anton Georgiev
4402f20c34 chore: Merged BBB 2.5.2 into v2.6.x-release 2022-06-22 16:11:48 +00:00
Anton Georgiev
10b0d47257
Merge pull request #15178 from gabriellpr/presentation-menu
refactor: Adding bbbmenu component to presentation menu
2022-06-22 11:42:53 -04:00
Anton Georgiev
37933d1c11
Merge pull request #15229 from ramonlsouza/fix-get-secret-poll-value
fix: secret poll value not recalculated
2022-06-22 11:22:17 -04:00
Anton Georgiev
8955267988
Merge pull request #15181 from ramonlsouza/user-leave-fix
fix: users counter inconsistent
2022-06-22 11:21:57 -04:00
Ramon Souza
560b53a452 fix first anon poll live-result 2022-06-22 10:17:59 -03:00
KDSBrowne
a899bbeb79
Merge branch 'v2.6.x-release' into 2.6-wb-options-dropdown 2022-06-21 23:16:31 -04:00
KDSBrowne
dd37a2479f fix menu position in rtl and iPhone 2022-06-22 03:11:25 +00:00
Ramon Souza
27f1e75500 fix secret poll value recalculation 2022-06-21 17:40:48 -03:00
Ramon Souza
6066fdec9f fix assignment in expression 2022-06-21 13:42:46 -03:00
gabriellpr
0e831c86cc adding tooltip-container 2022-06-21 08:53:06 -03:00
Maxim Khlobystov
72213eb91d New connection status test specs 2022-06-20 20:22:14 -04:00
Maxim Khlobystov
93a94ca88f Fit to width and multi-presentation upload 2022-06-20 19:02:10 -04:00
Ramón Souza
97f6857fd3
Merge pull request #15189 from KDSBrowne/2.6-disable-fd
fix: Disable File Drop on Whiteboard
2022-06-20 13:19:34 +01:00
Ramón Souza
d3fc924f10
Merge pull request #15137 from KDSBrowne/2.6-toolbar-zoom-val
Display Correct Zoom Value on Presentation Restore
2022-06-20 13:11:25 +01:00
KDSBrowne
3b44d17417 restore WB snapshot image download 2022-06-17 19:10:23 +00:00
KDSBrowne
4f9f9c11d3 fix viewer zoom reset when presenter remounts presentation 2022-06-17 00:35:27 +00:00
Ramon Souza
04f3b50d0d improve ghost buttons border 2022-06-16 16:59:01 -03:00
Ramon Souza
edeb70de0d Merge tag 'v2.5.1' into merge25-26-jun16 2022-06-16 13:58:54 -03:00
gabriellpr
449d6ca463 fix fullscreen not working normally 2022-06-16 13:32:27 -03:00
Ramón Souza
851340d551
Merge pull request #15154 from frankemax/unify-audio-buttons-27
feat(audio): unify audio buttons
2022-06-16 13:28:12 +01:00
KDSBrowne
8df5e3de02 recover presentation option menu | position inside tldraw menu 2022-06-15 22:10:42 +00:00
KDSBrowne
8dac344f43 replace zoom minBound with zoomed state 2022-06-15 19:46:06 +00:00
KDSBrowne
5828ed2149 add comment 2022-06-15 17:55:14 +00:00
KDSBrowne
6546b32585 disable dropping of assets on whiteboard 2022-06-15 17:43:58 +00:00
Max Franke
a1860f3dd4 fix(audio): select device dropdown icon position
Move the 'leave' icon to the left-hand side
2022-06-15 12:07:51 -03:00
Max Franke
9dfef30dba fix(audio): select device dropdown colors
Set list titles colors to colorGrayDark
Set active devices background color to off-white
2022-06-15 12:00:40 -03:00
Ramón Souza
86a05cd431
Merge pull request #15156 from gabriellpr/etherpad-cutting-text
fix: Etherpad cutting off text
2022-06-15 13:15:59 +01:00
Gustavo Trott
565b36c263
Merge pull request #15176 from mariogasparoni/fix-15169 2022-06-14 16:47:24 -03:00
Ramón Souza
e56b821f40
Merge pull request #15143 from ramonlsouza/current-poll-presenter
fix: re-subscribe to current poll when presenter changes
2022-06-14 20:17:37 +01:00
Ramon Souza
2dc00ddf35 handle user leave for viewers 2022-06-14 11:29:59 -03:00
Ramón Souza
fd76d35b0b
Merge pull request #15102 from JoVictorNunes/v2.5.x-release
fix(chat notification): duplication of first message notification
2022-06-14 15:25:17 +01:00
Ramón Souza
1446bfb163
Merge pull request #15139 from JoVictorNunes/issue-15060
fix(tooltip): wait 150ms to hide the tooltip
2022-06-14 15:24:06 +01:00
Ramón Souza
a4337f620e
Merge pull request #15173 from JoVictorNunes/issue-15168
fix: presenter indicator in RTL layout
2022-06-14 15:23:18 +01:00
Ramón Souza
7b1af1891b
Merge pull request #15153 from JoVictorNunes/issue-15133
fix(connection status modal): network status icon
2022-06-14 15:22:42 +01:00
Ramón Souza
933d9b438b
Merge pull request #15148 from ramonlsouza/rename-snapshot-feature
Rename snapshot button label
2022-06-14 15:21:15 +01:00
Ramón Souza
549f9499ba
Merge pull request #15123 from ramonlsouza/issue-15112
fix: Wrong aggregation of broadcast messages to breakout room
2022-06-14 15:20:13 +01:00
Ramón Souza
b0f6df6de5
Merge pull request #15124 from JoVictorNunes/issue-15113
fix(chat): show new message indicators for poll mesages
2022-06-14 15:19:23 +01:00
Ramón Souza
441e275f4f
Merge pull request #15117 from gabriellpr/export-chat-bug
fix: missing "chat has been cleared" message at chat export
2022-06-14 15:17:38 +01:00
gabriellpr
7adbce8e32 WIP:adding bbbmenu component to presentation menu 2022-06-14 10:18:40 -03:00
Joao Victor
ddb63f8e71 fix: restore virtual background after leaving breakout room #15111 2022-06-14 09:40:13 -03:00
Mario Jr
e3ad7aea0c fix(audio): moderator not able to transfer audio to breakout room
Closes #15169
2022-06-14 09:00:42 -03:00
Ramon Souza
69eba762d3 fix grouping of poll results in chat 2022-06-13 13:08:44 -03:00
KDSBrowne
53f4224fd1 Merge branch '2.6-toolbar-zoom-val' of https://github.com/KDSBrowne/bigbluebutton into 2.6-toolbar-zoom-val 2022-06-13 15:40:42 +00:00
KDSBrowne
15e58c0f69 stop zoom out at min % 2022-06-13 15:39:34 +00:00
Joao Victor
8cbf23ad7b fix: presenter indicator in RTL layout #15168 2022-06-13 11:52:26 -03:00
Anton Georgiev
696960f7b5
Merge pull request #15146 from antonbsa/2.5-tests-fix-and-ci-improvements
test: v2.5 tests fixes and CI improvements
2022-06-10 16:47:23 -04:00
gabriellpr
ec34e7e105 etherpad cutting text
fixing etherpad alignment for lock viewers

removing break words

fix: break-word

adding white-space
2022-06-10 16:00:54 -03:00
Joao Victor
bd1fcd6546 improvement: a more mobile-like behavior in connection status modal 2022-06-10 11:50:35 -03:00
Ramón Souza
4609f9f246
Revert "fix: user not removed from users context on leave" 2022-06-10 09:52:00 -03:00
Ramon Souza
11b85783d6 fix user not removed from users context on leave 2022-06-09 13:47:43 -03:00
Max Franke
1c6577f4db feat(audio): unify audio buttons
Move device selection dropdown to microphone button
Move option 'leave audio' to an option within the dropdown
Remove the audio exit button when device !== mobile
2022-06-09 13:37:37 -03:00
Joao Victor
4c238392b2 fix(connection status modal): data saving settings button 2022-06-09 12:01:05 -03:00
Joao Victor
b191a8d63b fix(connection status modal): network status icon color #15133 2022-06-09 11:58:57 -03:00
Ramon Souza
4f3600e683 rename snapshot button label 2022-06-08 15:24:46 -03:00
Anton B
de1c7043a9 test: fix/update tests on v2.5 2022-06-08 09:29:21 -03:00
Ramón Souza
44c24cf249
Merge pull request #15131 from ramonlsouza/audio-modal-polishing
Audio modal polishing
2022-06-08 13:25:43 +01:00
Ramon Souza
375635c797 re-sub to current poll when presenter changes 2022-06-07 16:54:09 -03:00
Joao Victor
887b1a588a fix(tooltip): wait 150ms to hide the tooltip 2022-06-07 10:59:18 -03:00
Ramón Souza
7a005efc88
Update bigbluebutton-html5/imports/ui/components/common/button/styles.js
Co-authored-by: João Victor Nunes <62393923+JoVictorNunes@users.noreply.github.com>
2022-06-07 10:06:32 -03:00
KDSBrowne
668be68b8e fix zoom value reset on unmount / mount 2022-06-06 20:30:34 +00:00
Ramon Souza
8ce74903db remove unused custom button styles 2022-06-06 14:44:30 -03:00
Ramon Souza
1c17e9ad95 adjust external video button 2022-06-06 14:33:15 -03:00
Ramon Souza
fe8ffbd2a5 revised styles primary button 2022-06-06 14:26:13 -03:00
Ramón Souza
bb29cd1d68
Merge pull request #15121 from KDSBrowne/2.6-lock-cursor
Restore Viewer Cursors Lock Functionality
2022-06-06 13:54:43 +01:00
Ramon Souza
242f5d3e29 audio modal spacing polishing 2022-06-03 16:10:09 -03:00
Ramón Souza
c489303672
Merge pull request #15128 from gabriellpr/line-space-pads
fix: pad line space not showing for viewers
2022-06-03 17:13:00 +01:00
gabriellpr
bdb703a056 fix: pad line space not showing
flex column removed
2022-06-03 12:10:47 -03:00
Joao Victor
de6800dc98 fix(chat): show new message indicators for poll mesages 2022-06-02 15:54:03 -03:00
Ramón Souza
f6b190aaa8
Merge pull request #15078 from lfzawacki/develop-layout
fix(layout): Fix propagation bugs and allow moderators to set the pushLayout flag
2022-06-02 19:48:07 +01:00
Ramon Souza
0f6a638551 do not group moderator message sent to all breakouts 2022-06-02 13:47:49 -03:00
KDSBrowne
6d4d11a34d fix cursors lock for viewers 2022-06-02 15:00:28 +00:00
Ramón Souza
162c89d701
Merge pull request #15095 from ramonlsouza/issue-7653
style: Revised styles for our primary circle buttons
2022-06-02 13:19:51 +01:00
Joao Victor
b75fbe8279 Remove merge residue 2022-06-01 16:55:28 -03:00
Joao Victor
2a1401f2ae Merge remote-tracking branch v2.6.x-release into virtual-background-upload 2022-06-01 16:50:29 -03:00
Joao Victor
bfe3472609 fix: remove style prop 'isVisualEffects' from button props 2022-06-01 14:46:43 -03:00
Joao Victor
1c02ff3877 fix: make drag-and-drop stuff follow the config 2022-06-01 14:30:50 -03:00
Joao Victor
4840543701 fix: move config key to public.virtualBackgrounds (Settings.yml) 2022-06-01 14:23:00 -03:00
Ramón Souza
9c978e91ee
Merge pull request #15114 from germanocaumo/tldraw-improvs
feat(whiteboard): poll result, zoom fit slide +
2022-06-01 17:02:52 +01:00
Joao Victor
22a924181d fix: state update on delete 2022-06-01 12:31:56 -03:00
Joao Victor
769629daf6 improvement: add a new service function for reading the file 2022-06-01 12:05:16 -03:00
gabriellpr
75bf0bc76f export chat save and copy updated
adding system messages key to public_chat_clear
2022-06-01 10:48:09 -03:00
germanocaumo
08b3659b68 fix(whiteboard): missing import 2022-06-01 13:47:28 +00:00
Joao Victor
b3d18a1d28 improvement: add HOC to concentrate drag-and-drop code 2022-06-01 10:34:21 -03:00
Mario Junior
c06bc26488
Merge pull request #15106 from frankemax/camera-avatar-polishment
feat(webcam) camera avatar polishment
2022-05-31 18:34:11 -03:00
Joao Victor
c1a42f7ee7 fix: actions bar button styling 2022-05-31 18:03:42 -03:00
germanocaumo
07a3a915c0 feat(whiteboard): poll result, zoom fit slide +
- Poll result as text shape in the lower right-hand
- Include all tldraw shape bounds as size in akka (to help Daniel rendering in pdf export)
- Default/initital zoom will be centered in the slide and maximize the size according to the presentation area
- Also limited the max zoom out to be the one that fits the slide, to be similar as we had before
2022-05-31 19:40:31 +00:00
Joao Victor
e7d9b46097 fix: add some file sanitization 2022-05-31 16:32:58 -03:00
Max Franke
8b8ba0c9f4 fix(webcam): draggable camera dock 2022-05-31 14:14:18 -03:00
Ramón Souza
a965dcee82
Merge pull request #15103 from KDSBrowne/2.6-bbb-tldraw
feat(whiteboard): Move Multiuser Whiteboard Button to Presentation Toolbar
2022-05-31 18:05:31 +01:00
Ramon Souza
b9a98e3fb9 undo double quotes replace 2022-05-31 13:52:37 -03:00
Max Franke
2fbb4e8821 fix(webcam): user status icons align
Align user status icons to match other icons paddings/margins
2022-05-31 13:38:37 -03:00
Max Franke
a53b41721b fix(video-avatar): prevent state update on an unmounted component 2022-05-31 13:38:37 -03:00
Joao Victor
936829338d fix: localize default button label for custom backgrounds 2022-05-31 11:38:24 -03:00
Joao Victor
ae3355d685 revert: unifying of click handlers of custom backgrounds 2022-05-31 11:14:33 -03:00
Joao Victor
69b4342e39 revert: unifying of click handlers of the default backgrounds 2022-05-31 11:06:58 -03:00
Mario Junior
f6d7706626
Merge pull request #15075 from frankemax/emoji-picker-v3
feat(emoji-picker): add component
2022-05-31 10:34:25 -03:00
Ramon Souza
e705152cc7 restore removed styles 2022-05-31 10:22:17 -03:00
Max Franke
32b3d55ab8 feat(message-form): send emoji at caret position 2022-05-30 17:53:41 -03:00
Ramon Souza
e43c83b7ba fix restoreOnUpdate 2022-05-30 17:37:40 -03:00
Joao Victor
65b59a6062 Rename custom hook 2022-05-30 15:49:19 -03:00
Max Franke
00a8e64261 feat(video-avatar): change border
Apply isTalking border with a pseudo-element.
2022-05-30 15:08:25 -03:00
KDSBrowne
f683740a2e allow pan when multiuser enabled 2022-05-30 14:51:08 +00:00
Joao Victor
1143cb87c7 fix(chat notification): duplication of first message notification 2022-05-30 10:10:03 -03:00
Daniel Schreiber
0506928367 Fix: only show breakout room in user list when user is in breakout room
The user list in the main room showed user being in breakout rooms who
already left a breakout room

closes #14982
2022-05-29 20:02:09 +02:00
KDSBrowne
f58882ffcc stop rendering curors when they leave the WB area 2022-05-29 16:24:44 +00:00
KDSBrowne
d404bd3e0f disable pan when multiuser access is off 2022-05-29 15:14:39 +00:00
Lucas Fialho Zawacki
a150bd20d7 feature(layout): Bring back layoutType propagation, but disallow 'custom' layout in mobile screens 2022-05-27 18:11:42 -03:00
Ramon Souza
e199ef2c35 primary circle button - revised styles 2022-05-27 16:33:12 -03:00
Joao Victor
9d66ff43ad fix: ghost button focus shadow 2022-05-26 17:34:25 -03:00
Max Franke
e853f032be fix(message-form): send message with emoji 2022-05-26 16:40:37 -03:00
Ramón Souza
f9e76502ad
Merge pull request #15084 from gabriellpr/external-links-style
style: Adding revised styles for our external links
2022-05-26 19:46:38 +01:00
gabriellpr
a4bf69aeba adding url styles
...

styling external links inside the banner

Refactoring code

adding underline on hover and focus

removing hasLiink
2022-05-26 15:10:20 -03:00
Ramón Souza
69bebe5875
Merge pull request #15087 from Tainan404/fix-userleft
Make sure do not show wrong data in user left message
2022-05-26 17:18:35 +01:00
Tainan Felipe
34fcf1d5c4 Make sure do not show wrong data in user left message 2022-05-26 11:29:05 -03:00
KDSBrowne
626259bf33 move multi user WB button to presentation toolbar (100% width) | reduce zoom increment 2022-05-25 23:25:53 +00:00