Commit Graph

6495 Commits

Author SHA1 Message Date
Arthur B. Grossi
cdd688000c style(layout): buttons outline
Adds margin to presentation and screenshare buttons
in order to prevent outline cut.
2021-06-14 14:53:21 -03:00
Vitor Mateus De Almeida
192fbf986b Add condition to size of presentation component 2021-06-14 14:47:12 -03:00
germanocaumo
a4fc9c1a27 fix(poll): remove wrong argument in quick-polls 2021-06-14 17:44:12 +00:00
Pedro Beschorner Marin
f6fae58ef1
Merge pull request #12522 from pedrobmarin/f-s-rme
feat(screenshare): reduce mirror effect
2021-06-14 14:38:46 -03:00
Ramon Souza
8da630da03 fix presentation service isPresenter 2021-06-14 09:56:17 -03:00
Pedro Beschorner Marin
068b82b1fa refactor(connection status): remove legacy monitor
Remove parts of a previous connection monitor.

To add some context (as far as my memory goes) to the multiple connection
monitor features the product has, `stats` (currently named `connection status`)
was introduced at the Flash client back in ~2016. @fcecagno and I did it
as a BigBlueButton's Summit activity. Our work was squashed into a single
commit in 92554f8b3e :).

I'm not sure about the whole story behind `network information` (the late
connection monitor added to the HTML5 client) but I assume it should work
as a collector for a bunch of different connectivity monitors. I remember
when it was introduced but I don't know why it wasn't adopted. My best guess
would be because of some performance issues the `user list` had back then.

To follow on why `connection status` replaced `network information` at the
HTML5 client, when I did the `multiple webcams` feature I had to refactor
a big chunk of the `video provider` (#8374). Something that wasn't really
helping there was the adaptation of `stats` that was made to show local
feedback for each webcam connection. Although this feature wasn't being
used anymore, `network information` did rely on that to build up data. With
this monitor gone I assumed it was my responsibility to provide an alternative
so I promoted Mconf's port of the Flash `stats` monitor to BigBlueButton's
HTML5 client (#8579).

Well, that's my perspective on how things went for those features. If
anyone would like to correct me on something or add something else on
that history I would appreciate to know.
2021-06-13 14:02:46 -03:00
Anton Georgiev
78385ab3ea
Merge pull request #12569 from pedrobmarin/f-v-ds
feat(video): data savings
2021-06-12 16:59:38 -04:00
Anton Georgiev
062db71e92
Merge pull request #12561 from germanocaumo/answers-tarnslation-12546
fix(poll): don't translate user/presenter typed answers
2021-06-12 16:54:12 -04:00
Arthur
78047eb68e feat(video): data savings
Enable video sharing when data savings is activated.
2021-06-12 14:16:32 -03:00
Max Franke
8b274476b1 feat(video): indicate who is sharing webcam
Add the `camera` icon in the user list for whoever is sharing,
in order to improve the understanding of who is sharing the webcam.
It is possible to enable/disable this indication in the settings.yml
2021-06-12 13:40:47 -03:00
Anton Georgiev
1369cb2269
Merge pull request #12505 from gustavotrott/breakoutroom-inscrease-time
Add 'Extend duration' option for breakout rooms
2021-06-11 16:33:15 -04:00
Ramon Souza
4ca3d17393 check for presenter status at presentation upload modal 2021-06-11 16:33:15 -03:00
Ramon Souza
b67e8ce7bf css fixes 2021-06-11 14:36:06 -03:00
germanocaumo
7bedcb08e5 fix(poll): don't translate user/presenter typed answers
When the answer is not default (Custom or UserResponse), don't translate the answers.
2021-06-11 16:55:53 +00:00
Ramon Souza
385bdf1568 add minimum duration for breakout room 2021-06-11 13:24:36 -03:00
Anton Georgiev
9d804ad05b
Merge pull request #12551 from ramonlsouza/fix-locked-join
fix: Attendee join with mic-ish permission even though mic is Locked
2021-06-10 13:00:39 -04:00
Ramon Souza
94e58938b4 fix raise hand order 2021-06-10 13:46:27 -03:00
Ramon Souza
83da4448fa fix attendee auto join audio locked 2021-06-10 09:14:51 -03:00
Ramon Souza
da924234d3 store layout manager in meeting collection 2021-06-09 15:30:08 -03:00
Ramon Souza
4c44a90704 Merge remote-tracking branch 'upstream/develop' into layout-meeting-collection 2021-06-09 14:13:26 -03:00
Ramon Souza
1ac3767ed4 store layout type in meeting collection 2021-06-09 14:08:11 -03:00
Vitor Mateus De Almeida
ba400b2ebd Merge remote-tracking branch 'upstream/develop' into layoutManagerNew 2021-06-09 11:03:34 -03:00
Vitor Mateus De Almeida
f6fc8225f6 Add container for presentation 2021-06-09 10:49:59 -03:00
Anton Georgiev
2903c5e3cd
Merge pull request #12452 from ramonlsouza/chat-alerts-refactor
refactor: chat alerts
2021-06-09 08:54:56 -04:00
germanocaumo
df504cf2d5 refactor(quick-poll): Remove unneeded code for poll answers
The answers are already translated in the UI based on type.
2021-06-08 13:26:07 +00:00
Ramon Souza
97aa7278a5 add option to emphasize moderator messages in public chat 2021-06-08 08:56:59 -03:00
germanocaumo
0be7c6c9f5 fix(poll): fix client crash with A-F as options and quick-poll type 2021-06-07 19:21:21 +00:00
Gustavo Trott
5b579d3a16 Avoid extend breakout rooms time exceed parent meeting remaining time 2021-06-07 14:19:20 -03:00
Ramon Souza
0598394329 fix updated notification bug 2021-06-07 13:53:35 -03:00
Ramon Souza
5b8f783e87 fix push alert onClick (open chat) 2021-06-07 11:18:57 -03:00
Max Franke
f2c95c61e3 feat(screenshare): reduce mirror effect
Add the shrink/expand button in the screenshare layout to reduce the mirror/tunnel
effect, when the presenter is sharing the same screen as the application is.
2021-06-07 09:11:32 -03:00
tibroc
306beff1d1 add better user explanations and remaining differences to #12435
PR #12435 was slightly different than #12430 but especially had better explanations for users.
This commit incorporates the remaining ideas from that PR.
2021-06-07 11:01:34 +02:00
tibroc
13ae19bc3d Use currentPoll instead of state to determine if live results should be rendered
To avoid re-rendering of the poll answers when the poll panel is opened and closed,
this commit uses the currentPoll object to determine wether results should be rendered.
2021-06-07 10:56:14 +02:00
tibroc
828cf60cb2 Add option to hide individual answers in polls
This patch adds a new option to hide the individual answers to the presenter
when starting a poll. This includes hiding the answers for the presenter and
informing the other users that the current poll is anonymous.

See #9524
2021-06-07 10:56:14 +02:00
Arthur B. Grossi
bf62857ca7 fix(video): talking indicator
Shows video talking indicator even if the video isn't ready
2021-06-06 15:24:39 -03:00
Anton Georgiev
2f2b75097d
Merge pull request #12504 from pedrobmarin/f-ev-bei
feat(external videos): back end improvements
2021-06-04 15:57:19 -04:00
Anton Georgiev
96474f2ca7
Merge pull request #12501 from Tainan404/fix-user-dropdown
Add field to toggle the download of the public chat message
2021-06-04 15:39:30 -04:00
Anton Georgiev
1cd44e6067
Merge pull request #12517 from ramonlsouza/navbar-large-fonts
fix: different navbar height for large fonts
2021-06-04 15:21:06 -04:00
Tainan Felipe
bf6bbfca69 Add conditional to don't show dropdown when no opition avaible 2021-06-04 15:51:29 -03:00
Ramon Souza
4b964f897f improve 'meeting ended by user' message 2021-06-04 13:37:07 -03:00
Ramon Souza
3ba15a83dd different navbar height for large fonts 2021-06-04 10:44:50 -03:00
Ramon Souza
3030fbc206 Merge remote-tracking branch 'upstream/develop' into chat-alerts-refactor 2021-06-04 08:28:47 -03:00
Anton Georgiev
74ac0f8e01 fix: Increase slightly area for webcam+presentation 2021-06-03 17:55:13 +00:00
Anton Georgiev
fd9b68b526
Revert "fix: different navbar size for locales with large fonts" 2021-06-03 10:42:02 -04:00
Anton Georgiev
776d979e42
Merge pull request #12486 from ramonlsouza/actions-bar-new-lm
actions bar in new layout manager
2021-06-02 16:47:12 -04:00
Gustavo Trott
02ef1186be Avoid set negative values in Extend time for breakout rooms 2021-06-02 17:36:43 -03:00
Gustavo Trott
2551f71d7c
code fix: use 0 instead of string
Co-authored-by: Anton Georgiev <antobinary@users.noreply.github.com>
2021-06-02 16:16:35 -03:00
Anton Georgiev
e01bdf69c5 Merge branch 'v2.3.x-release' of github.com:bigbluebutton/bigbluebutton into june2-merge-into-develop 2021-06-02 18:45:31 +00:00
Gustavo Trott
fd2ef393ed Code fixes in Breakoutroom extend time parts 2021-06-02 15:38:26 -03:00
Gustavo Trott
a312557461 Adds extend breakout room time functionality 2021-06-02 15:29:40 -03:00
Pedro Beschorner Marin
d4888f585c refactor(external videos): state as integer
A media state may have more than 2 states. Moving this property back to
integer so it can be extended.
2021-06-02 15:07:03 -03:00
Pedro Beschorner Marin
6c84a3295b refactor(external videos): frontend permissions
Revoked extra frontend permission checks and removed dependency from
external video stop Meteor's system call.
2021-06-02 13:03:04 -03:00
Max Franke
7f926edfcc refactor(external videos): add own collection
Refactor the external videos collection, moving the logic and functionalities
outside of /imports/api/meetings to a new location in /external-videos/server/modifiers
in order to decrease the coupling between the functionalities, favoring
the maintenance.
2021-06-02 12:50:40 -03:00
Tainan Felipe
25bf0096c5 Add field to toggle the download of the public chat message 2021-06-02 11:50:26 -03:00
Ramon Souza
f4f01818f8 add localeChanged event to resize presentation area 2021-06-02 09:41:15 -03:00
Ramon Souza
8d2474135a formatting 2021-06-01 14:46:29 -03:00
Ramon Souza
96edb582f7 different navbar height for large fonts 2021-06-01 14:45:16 -03:00
Anton Georgiev
9395f50b99
Merge pull request #12474 from Tainan404/refactor-dropdown
refactor: Decrease amount of imports in dropdown
2021-06-01 09:32:14 -04:00
Ramon Souza
f526ab88fb actions bar in new layout manager 2021-05-31 17:28:57 -03:00
Ramon Souza
a4849f109c fix navbar z-index - new LM 2021-05-31 15:37:14 -03:00
Tainan Felipe
baf7afc883 Decrease amount of imports in dropdown 2021-05-31 15:28:27 -03:00
Anton Georgiev
ff24c5ae0d
Merge pull request #12466 from pedrobmarin/f-g-ns
feat(guests): notification settings
2021-05-31 10:48:15 -04:00
Ramon Souza
fdb07b8c37 use same z-index for all new layouts 2021-05-31 10:44:55 -03:00
Joao Siebel
f16700a8c4 Allow tags in meeting and user name. close #10221 close #12370 2021-05-31 09:59:15 -03:00
Pedro Beschorner Marin
21a7324f70 feat(guests): notification settings
Avoid showing the guest's notification toggles at client's settings if the guest
policy isn't `ASK_MODERATOR`.
2021-05-30 12:09:33 -03:00
germanocaumo
be8d7405a0 fix: missing line break of poll chat export 2021-05-29 00:56:25 +00:00
germanocaumo
5c7fa6ece5 fix: export poll chat message
Include the new poll text in the chat export function.
Refactor some chat type constants.
Also fixes empty lines in the export chat file.
2021-05-29 00:28:47 +00:00
Ramon Souza
247601ad3d fix captions button crash 2021-05-28 17:16:35 -03:00
Anton Georgiev
409f10bd03
Merge pull request #12460 from ramonlsouza/fix-poll-panel-new-lm
fix: poll panel styles - new LM
2021-05-28 15:06:17 -04:00
Ramon Souza
7b2fd3b38e fix poll panel in new layout manager 2021-05-28 15:55:12 -03:00
Ramon Souza
8cfc4aa5c4 fix panels height with focus on video - LM 2021-05-28 15:20:29 -03:00
Ramon Souza
e0b3de1d3c add modals to new layout manager 2021-05-28 10:30:35 -03:00
Ramon Souza
29ed0c658b fix open chat alert 2021-05-27 16:19:16 -03:00
Pedro Beschorner Marin
10e29f3832
Merge pull request #12451 from germanocaumo/poll-chat-translation
fix: translate poll answer key for default polls in chat message
2021-05-27 15:21:57 -03:00
germanocaumo
4d62f8a971 fix: translate poll answer key for default polls 2021-05-27 18:16:11 +00:00
Ramon Souza
3c41c6fd83 lint + cleanup 2021-05-27 15:12:49 -03:00
Ramon Souza
94436d2630 chat alerts refactor 2021-05-27 14:46:27 -03:00
germanocaumo
c213b88451 refactor(poll): improve poll types code
this also fixes certain poll type detection for other languages than english,
so that the correct poll type is sent in the events (they were being detected as custom)
2021-05-26 17:52:55 +00:00
Pedro Beschorner Marin
b3c698a2a9
Merge pull request #12422 from germanocaumo/poll-chat-refactor
refactor: redo how poll result chat message is done
2021-05-26 14:49:19 -03:00
Anton Georgiev
a82505dee1
Merge pull request #12440 from ramonlsouza/unused-remove
refactor: remove unused import and variables
2021-05-26 09:16:08 -04:00
Ramon Souza
1cb880bb30 fix extract poll question crash 2021-05-25 15:48:53 -03:00
Ramon Souza
fe804ae657 remove unused imports in app component 2021-05-25 13:15:09 -03:00
Ramon Souza
d515f90b2d remove unused import and variables in layout manager 2021-05-25 13:11:27 -03:00
Mohamed Amine Ben Salah
2a9fdebd61
Mobile/Tablet devices automated tests for mobile/tablet on ios/android devices (#12173)
* adds unability to see screenshare button on mobile devices test specs

* simplify code in testMobileDevice()

* userlist and chat panels should not appear at page load in mobile devices

* lint

* updates outdated audio specs due to leaveAudio changes

* correct clicks on disconnectAudio elements

* whiteboard not visible on userlistPanel or on chatPanel

* reworks mobile devices/usersagents

* fixes screenshare mobile/tablet specs

* adds whiteboardNotAppearOnMobile spec

* adds Chat Panel specification to Mobile-Tablet specs

* simplify getArgs() functions for all devices
2021-05-25 12:05:11 -04:00
Vitor Mateus De Almeida
42efa722e6 Add presentation update when change layout typeNLM 2021-05-24 15:35:37 -03:00
Vitor Mateus De Almeida
04715230dc Add webcam container and presentation container 2021-05-24 14:05:39 -03:00
Ramon Souza
69c1a7028d add padding to action bar dropdowns 2021-05-24 10:50:22 -03:00
Vitor Mateus De Almeida
ede57507ef Merge remote-tracking branch 'upstream/develop' into layoutManagerNew 2021-05-21 14:56:10 -03:00
Vitor Mateus De Almeida
a3aea117ed Fix options menu, private chat message, breakout panel 2021-05-21 14:52:08 -03:00
Anton Georgiev
eadd2d093f
Merge pull request #12414 from ramonlsouza/issue-12411
fix: do not display private chat before first message is sent
2021-05-21 10:34:52 -04:00
Ramon Souza
d17cc3149f use session instead of storage 2021-05-21 09:17:24 -03:00
Vitor Mateus De Almeida
41965d49ed Fix problem with slides with a quick poll 2021-05-20 12:12:08 -03:00
germanocaumo
3a9e9c1358 refactor: redo how poll result chat message is done +
Fix prolems with ":" char in answers.
Respect poll question formatting (lineBreaks/spaces) in other fields of UI
2021-05-20 14:53:52 +00:00
Vitor Mateus De Almeida
f3d759a7fb Fix chat panel space empty 2021-05-20 11:36:26 -03:00
Anton Georgiev
cb4697c932
Merge pull request #12381 from ramonlsouza/issue-12373
fix: options button appearing in save chat
2021-05-19 23:30:14 -04:00
Anton Georgiev
eafa260320
Merge pull request #12347 from jfsiebel/start-poll-after-publish-button
Improve Start A Poll button after publishing poll results
2021-05-19 23:28:17 -04:00
Anton Georgiev
4d788dfdd5
Merge pull request #12378 from ramonlsouza/large-locales
fix: ui adjustments for large te and km locales
2021-05-19 20:34:40 -04:00
Vitor Mateus De Almeida
d44fea18c2 Fix allways show mobile sub name tag 2021-05-19 20:05:26 -03:00
Vitor Mateus De Almeida
047b573d10 Fix auto resize when open/close panels 2021-05-19 19:29:03 -03:00
Ramon Souza
02057c7057 replace locale-specific code with align-items:center 2021-05-19 16:29:01 -03:00
Ramon Souza
32afa3bdbc do not display private chat before first message is sent 2021-05-19 14:46:04 -03:00
Vitor Mateus De Almeida
72e074eb7c Merge remote-tracking branch 'upstream/develop' into layoutManagerNew 2021-05-19 13:21:31 -03:00
Anton Georgiev
ce18cc4bfa
Merge pull request #12405 from ramonlsouza/issue-12399
fix(chat): auto scroll to bottom for new users
2021-05-19 12:03:13 -04:00
Vitor Mateus De Almeida
444b29a346 Merge remote-tracking branch 'upstream/develop' into layoutManagerNew 2021-05-19 11:54:22 -03:00
Vitor Mateus De Almeida
88a1edcc06 Fix userlist item button, Fix polling close button 2021-05-19 11:51:31 -03:00
Ramon Souza
d11e0917b0 remove useless conditional in user-name component 2021-05-19 09:28:16 -03:00
Ramon Souza
7c2a1384e2 remove useless conditional in whiteboard toolbar 2021-05-19 09:07:14 -03:00
Ramon Souza
e193fb7ec9 remove useless conditional in chat item component 2021-05-19 09:03:04 -03:00
Ramon Souza
80f80706f4 fix chat auto scroll to bottom for new users 2021-05-18 16:59:42 -03:00
Anton Georgiev
47b69f942d
Merge pull request #12402 from Tainan404/issue-7926
Fix re-renders when another chat receives new messages
2021-05-18 13:34:19 -04:00
Anton Georgiev
61da01819f
Merge pull request #12388 from pedrobmarin/cc-m-d
fix(closed captions): dictation mode and redis communication
2021-05-18 13:33:33 -04:00
Anton Georgiev
af04a4c20d
Merge pull request #12404 from ramonlsouza/issue-12396
feat: add setting to enable/disable raise hand action button
2021-05-18 13:30:58 -04:00
Ramon Souza
098746d3c0 add setting to enable/disable raise hand action button 2021-05-18 13:39:09 -03:00
Anton Georgiev
b9955a5b43
Merge pull request #12344 from ramonlsouza/toggle-text
fix: move toggle text outside of buttons in debug window and network modal
2021-05-18 10:34:52 -04:00
Tainan Felipe
6e57ca817f Fix re-renders when another chat receives new messages 2021-05-18 10:04:17 -03:00
Vitor Mateus De Almeida
1326f3f791 Add New Layout Manager 2021-05-17 17:25:07 -03:00
Pedro Beschorner Marin
185b77f720 refactor(closed captions): simplify appended text format 2021-05-16 10:06:16 -03:00
Ramon Souza
b27314b6e8 fix options button appearing in save chat 2021-05-14 09:47:37 -03:00
Anton Georgiev
1bc324b657
Merge pull request #12353 from germanocaumo/poll-record-improvs
Recorded polling events improvements
2021-05-13 13:43:36 -04:00
Ramon Souza
d061294f74 add ui adjustments for large languages 2021-05-13 11:55:33 -03:00
Anton Georgiev
51776ca7ad
Merge pull request #12369 from Tainan404/issue-12251
Fix presentation moving down when someone is talking
2021-05-13 09:12:36 -04:00
MrKeksi
8cfc174625
Update styles.scss 2021-05-13 02:02:53 +02:00
Anton Georgiev
b3f0609984
Merge pull request #12367 from ramonlsouza/issue-12355
fix: show avatar in private chat list
2021-05-12 16:10:59 -04:00
Tainan Felipe
aa33697cfd
Merge branch 'develop' into issue-12251 2021-05-12 16:57:14 -03:00
Tainan Felipe
840ac86364 Fix presentation moving down when someone is talking 2021-05-12 16:51:45 -03:00
prlanzarin
61cb8457d6 fix(video): check if encodings array is empty before trying to apply bitrate 2021-05-12 19:42:07 +00:00
Ramon Souza
49bba65f5f indentation 2021-05-12 16:33:20 -03:00
prlanzarin
d707048c56 fix(video): remove unused floorStream variable 2021-05-12 19:26:26 +00:00
Ramon Souza
f5887d29fc show avatar in private chat list 2021-05-12 16:21:48 -03:00
Anton Georgiev
cdbaef6867
Merge pull request #12364 from ramonlsouza/issue-12363
fix: presentation uploader error
2021-05-12 14:49:42 -04:00
Ramon Souza
0844f54716 fix presentation uploader error 2021-05-12 15:43:45 -03:00
Anton Georgiev
b9062e70ec
Merge pull request #12362 from ramonlsouza/issue-8414
fix: change firefox legacy warning + add media query for mobile
2021-05-12 14:43:02 -04:00
Ramon Souza
abd5eff1ea change firefox legacy warning + add media query for mobile 2021-05-12 14:34:53 -03:00
Anton Georgiev
b4e609f2c8 feat(guests): Introduce dynamicGuestPolicy in setting.yml 2021-05-12 16:01:04 +00:00
Anton Georgiev
1bf910c26b
Merge pull request #12360 from ramonlsouza/fix-action-buttons
fix: action buttons in audio selector - mobile
2021-05-12 10:15:52 -04:00
Ramon Souza
ffb067a8a3 fix action buttons visibility 2021-05-12 11:07:18 -03:00
Anton Georgiev
608ee314ce
Merge pull request #12359 from ramonlsouza/issue-12089
fix: increase audio menu width
2021-05-12 10:06:23 -04:00
Anton Georgiev
b29d5884e4
Merge pull request #12342 from gustavotrott/user-inactivity-fix
Fix: Eject user from meeting after inactivity warning timeout
2021-05-12 09:51:33 -04:00
Ramon Souza
99b04f33f0 use max-content for audio menu instead of fixed width 2021-05-12 09:53:32 -03:00
Anton Georgiev
bd51a191bd
Merge pull request #12354 from ramonlsouza/new-message-chat-scroll
fix: handle new message auto-scroll in chat
2021-05-11 18:40:04 -04:00
Anton Georgiev
cfab8518e8
Merge pull request #12352 from jfsiebel/content-loss-warning
feat: Add warning on meeting end modal about content in meeting.
2021-05-11 16:30:32 -04:00
Ramon Souza
ba616be126 handle new message auto-scroll in chat 2021-05-11 17:30:06 -03:00
germanocaumo
ca2ad30e12 fix(record): add missing info to polling events
Add PollPublishedRecordEvent with all infos (also fix duplicated handlePollStoppedEvtMsg)
Add answer text to UserRespondedToPollRecordEvent (useful for custom answers)
Add type in PollStartedRecordEvent
2021-05-11 18:37:23 +00:00
germanocaumo
04bd5c36b1 fix(poll): fix question title overflow
improve done translation in pt_br
2021-05-11 18:37:08 +00:00
Joao Siebel
70e72cca25 Add warning on meeting end modal about content in meeting. close #10721 2021-05-11 14:34:18 -03:00
Ramon Souza
6b1e19696a adjust navbar height 2021-05-11 14:07:38 -03:00
Joao Siebel
90b54265e6 Improve Start A Poll button after publishing poll results 2021-05-11 11:22:08 -03:00
Ramon Souza
91eb8b0e9e move toggle text outside of buttons in debug window and network modal 2021-05-10 17:41:52 -03:00
Anton Georgiev
4c3edbcea3
Merge pull request #12341 from ramonlsouza/issue-12141
fix: show message when starting poll without active presentation
2021-05-10 15:50:39 -04:00
Anton Georgiev
04c038edfb
Merge pull request #12337 from ramonlsouza/issue-12323
fix: breakout panel width (mobile)
2021-05-10 15:48:54 -04:00