Commit Graph

8325 Commits

Author SHA1 Message Date
prlanzarin
89e814d570 fix(audio): centralize device change code, add rollbacks, surface errors
There's no rollback procedure in case a device switch fails right now,
nor does the code entrypoints that call the switching procedures wait
for resolution or failure before marking the new device as chosen. That
may cause inconsistent states in a couple of ways:
  - No rollback: switch fails, audio is still on but no actual
    microphone input is being transmitted
  - Not waiting for resolutions: inconsistent chosen devices on failures
Device switching errors are also not surfaced to the end user

This commit:
  - Adds device rollback and proper resolution/failure response
    awaits to try and make the state a bit more consistent.
  - Centralizes the input device switching code to be reused between
    different bridges
  - Centralizes device ID state management in audio-manager to try and
    mantain them a bit more consistent across the board
  - Surface device switching failures to the end user
  - Guarantee device IDs are set to the session storage on all
    appropriate scenarios
2022-08-24 13:28:27 +00:00
KDSBrowne
45b3166863 Merge branch 'tldraw-viewbox-sync' of https://github.com/germanocaumo/bigbluebutton into tldraw-viewbox-sync 2022-08-24 11:55:38 +00:00
KDSBrowne
c758664651 remove toolbar from non presenter cursor calculation 2022-08-24 11:55:31 +00:00
Ramón Souza
82e234be33
Merge pull request #15500 from JoVictorNunes/issue-15458
fix: don't clear text fake annotations
2022-08-23 16:19:39 -03:00
germanocaumo
61cb5b8ef4 fix(tldraw): fit to width / presenter / slide changing 2022-08-23 18:19:17 +00:00
Ramón Souza
59f717265a adjustments after PR 15573 2022-08-23 13:59:58 -03:00
Ramón Souza
4d82d76d4a Merge remote-tracking branch 'upstream/v2.5.x-release' into uploader-errors 2022-08-23 09:34:25 -03:00
KDSBrowne
9f7b45b172 hide eraser animation on mobile 2022-08-23 12:08:31 +00:00
Anton B
8e7e1e7e42 test: add data-test props in lock settings items 2022-08-22 18:02:31 -03:00
Gustavo Trott
87e4c52cee Fix error when trying to read role when user was removed already 2022-08-22 16:32:12 -03:00
KDSBrowne
ab4cb469fb Merge branch 'tldraw-viewbox-sync' of https://github.com/germanocaumo/bigbluebutton into tldraw-viewbox-sync 2022-08-22 19:07:23 +00:00
KDSBrowne
9df18af50f update presentation offset for cursor (mobile) 2022-08-22 19:05:02 +00:00
germanocaumo
0e7c27968e Merge branch 'tldraw-viewbox-sync' of https://github.com/germanocaumo/bigbluebutton into tldraw-viewbox-sync 2022-08-22 18:11:40 +00:00
GuiLeme
d9de398d90 [fix-page-count-exeed] - Forwarded temporaryPresentationId to front-end and refactor it's name 2022-08-22 15:00:27 -03:00
Anton Georgiev
2be6909e26
Merge pull request #15525 from gabriellpr/about-modal
test: About Modal Test
2022-08-22 13:05:11 -04:00
KDSBrowne
eb7c3dcbc8 update pan tool button after zoom changes 2022-08-22 16:55:44 +00:00
João Victor Nunes
aba9d86904
Merge branch 'v2.6.x-release' into issue-15276 2022-08-22 13:05:25 -03:00
germanocaumo
c948f39392 Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into tldraw-viewbox-sync 2022-08-22 15:47:51 +00:00
germanocaumo
f209fd17c1 Merge branch 'tldraw-viewbox-sync' of https://github.com/germanocaumo/bigbluebutton into tldraw-viewbox-sync 2022-08-22 15:43:04 +00:00
KDSBrowne
1de4b3f644 update cursor position handling | temp hide eraser animation 2022-08-22 14:37:34 +00:00
Ramón Souza
9303c598c1
Merge pull request #15532 from KDSBrowne/bbb-responsive-wb-toolbar
fix: Make Whiteboard Toolbar Responsive to Smaller Sizes
2022-08-22 11:33:46 -03:00
Ramón Souza
03b1f13ab5 fix duplicated presentation on remove + upload 2022-08-22 10:37:05 -03:00
KDSBrowne
9c018ee6db restore large toolbar size when view enlarged 2022-08-21 21:38:54 +00:00
Anton Georgiev
4b8b216bbe
Merge pull request #15566 from antobinary/cairosvg
chore: Merge BBB 2.5 into 2.6
2022-08-19 14:32:24 -04:00
Ramón Souza
7dd5a3daa9 fix emoji picker button styles 2022-08-19 15:19:10 -03:00
Ramón Souza
318807b9e4
Merge pull request #15533 from JoVictorNunes/issue-15509
fix: push layout not working unless changed
2022-08-19 13:45:17 -03:00
Anton Georgiev
bbb7dd421d Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into cairosvg 2022-08-19 14:25:03 +00:00
Ramón Souza
3a1d0fc09e undo page_count_exceeded changes in service 2022-08-19 11:20:58 -03:00
Anton Georgiev
1b7b63baf6 Merge branch 'v2.5.x-release' of github.com:bigbluebutton/bigbluebutton into cairosvg 2022-08-19 14:14:54 +00:00
Anton Georgiev
23c0dc56c4 Merge branch 'v2.5.x-release' of github.com:bigbluebutton/bigbluebutton into cairosvg 2022-08-19 13:04:00 +00:00
germanocaumo
7bf8668f23 Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into tldraw-viewbox-sync 2022-08-18 18:41:27 +00:00
germanocaumo
99549d880f fix(tldraw): fit-to-width / presenter change view area sync
- Correctly sync the viewed area when in fit-to-width mode and when the presenter reloades the page or the presenter changes to another user.
2022-08-18 18:18:02 +00:00
Ramón Souza
ff52b6ae28 fix presentation snapshot feature 2022-08-18 15:17:38 -03:00
Ramón Souza
81b15ae329
Merge pull request #15518 from JoVictorNunes/issue-15291
fix: incorrect calculation of number of users in multi user whiteboard
2022-08-18 10:52:34 -03:00
Gabriel Porfirio
35cac6ce8d added data-test to the about button and modal 2022-08-18 08:46:31 -03:00
Gustavo Trott
222a763b8c Prevent client to end meeting while trying to restablish authentication 2022-08-17 14:08:55 -03:00
Ramón Souza
30a17562c1
Merge pull request #15539 from JoVictorNunes/issue-15484
style: presentation toolbar in RTL mode
2022-08-17 13:53:13 -03:00
Ramón Souza
408a66eb49
Merge pull request #15531 from KDSBrowne/bbb-tldraw-pan
refactor: Add Pan Button to Presentation Toolbar
2022-08-17 13:44:31 -03:00
KDSBrowne
554c792345 restrict pan tool shortcut to presenter only 2022-08-17 15:36:56 +00:00
KDSBrowne
f1ba37fc2f handle active pan state via shortcut 2022-08-17 15:23:48 +00:00
Ramón Souza
54e2618011 adjust large file error on presentation 2022-08-17 10:17:26 -03:00
Ramón Souza
b90d4ce81e fix conversion state 2022-08-16 17:26:42 -03:00
germanocaumo
98d431ad92 fix(recording): correctly save tldraw pan/zoom events 2022-08-16 19:11:49 +00:00
Ramón Souza
a895b087f9 display page exceeded error on presentation uploader 2022-08-16 11:41:11 -03:00
germanocaumo
d4b8bdce7e fix(tldraw): sync viewed area between presenter/viewers +
- Return to the ResizeAndMoveSlide event to do pan&zoom, respecting the viewed width and height ratio
- Defaults zoom in toolbar to 100% like before to be more consistent
- Fit to width and Reset Zoom is back (fit tho width still has some sync problems)
- Fix to not change to first page when presenter reloads page
2022-08-16 12:12:43 +00:00
prlanzarin
0e162f1cda feat: configurable DSCP marking for WebRTC media
RTCRTPSender exposes DSCP marking via `networkPriority` in the encodings
configuration dictionaries. That should allow us to control
QoS priorities for different media streams, eg audio with higher network
priority than video. The only browser that implements that right
now is Chromium.

To use this, the public.app.media.networkPriorities configuration in
settings.yml. Audio, camera and screenshare priorities can be controlled
separately. For further info on the possible values, see:
  - https://www.w3.org/TR/webrtc-priority/
  - https://datatracker.ietf.org/doc/html/rfc8837#section-5
2022-08-15 21:24:05 +00:00
Gustavo Trott
ee560bf188 Makes meeting-ended and error-screen show ejectedReason message 2022-08-15 17:25:45 -03:00
Joao Victor
14d8200742 style: presentation toolbar 2022-08-15 14:56:10 -03:00
Ramón Souza
082057ba55
Merge pull request #15177 from JoVictorNunes/issue-15111
fix: restore virtual background after leaving breakout room
2022-08-15 14:45:37 -03:00
KDSBrowne
48157ae49b reset pan when not zoomed | presenter change 2022-08-15 13:17:36 +00:00
KDSBrowne
12a324631f update cursor type when pan enabled 2022-08-15 13:02:56 +00:00
Ramón Souza
f851765ab3 fix presentation downloadable state 2022-08-15 09:50:07 -03:00
Joao Victor
f4fc11d53b fix: condition to switch between layouts 2022-08-15 09:21:29 -03:00
Joao Victor
9507797588 fix: update of settings 2022-08-15 08:18:24 -03:00
KDSBrowne
26f3e5dc3f add pan button to presentation toolbar 2022-08-14 22:49:39 +00:00
KDSBrowne
df0fc0da15 make whiteboard toolbar responsive to small screens 2022-08-12 19:08:26 +00:00
Joao Victor
8e9ca4b2c8 fix: incorrect calculation of number of users in multi user whiteboard 2022-08-11 15:44:16 -03:00
Ramón Souza
c032009677 fix remove presentation bug 2022-08-11 14:27:29 -03:00
Joao Victor
60857a0056 fix(tldraw): hide context menu for users who don't have access to whiteboard 2022-08-11 13:38:17 -03:00
Ramón Souza
a1dd5f0a36
Merge pull request #15466 from JoVictorNunes/issue-15341
fix(layout): don't show `navbar`/`actions-bar` before layout has been calculated
2022-08-10 14:47:22 -03:00
Ramón Souza
c0246215d4
Merge pull request #15502 from KDSBrowne/bbb-tldraw-keys
refactor: Add Remaining Shortcut Keys to Help Modal
2022-08-10 13:37:35 -03:00
Ramón Souza
44966f3e18
Merge pull request #15501 from KDSBrowne/bbb-tldraw-dock-position
fix: Position Whiteboard Toolbar with API | Sync Current Locale
2022-08-09 17:16:19 -03:00
Ramón Souza
c65ed3c785
Merge pull request #15494 from ramonlsouza/media-fix-port
fix: port screenshare/external video fixes to 2.5
2022-08-09 10:11:52 -03:00
KDSBrowne
7f4151e6eb update shortcut keys list 2022-08-09 11:45:46 +00:00
KDSBrowne
3ebfdef9bd use api toolbar general position | sync current locale 2022-08-08 22:47:51 +00:00
Joao Victor
74c4c1c4cc fix: don't clear text fake annotations 2022-08-08 17:07:41 -03:00
Ramón Souza
c48e942a62
Merge pull request #15488 from ramonlsouza/fix-dialin-button-styles
fix(styles): adjust dial-in button styles
2022-08-08 10:49:19 -03:00
Ramón Souza
a7495ad16b add presentation snapshot button data-test 2022-08-05 13:14:27 -03:00
Ramón Souza
da370a10cb
Merge pull request #15475 from ramonlsouza/fix-cc-icon-position
fix: adjust captions icon position
2022-08-05 11:02:00 -03:00
Ramón Souza
4721184eb6 fix mobile init values for external video/screnshare 2022-08-05 09:52:48 -03:00
prlanzarin
6f13961018 fix(layout): set external-video/screen share initial states on all layouts
Only smart layout takes screen sharing/external video states in account
when populating its initial state. The others don't, and that causes
some weird issues when switching back-and-forth between layout types due
to their input states becoming inconsistent - ie having an active screen
sharing and transitioning from Smart -> Custom would mark it as false
(due to its absence from the initial state) and pollute its state for
subsequent layouts.

This commit guarantees those features are taken into account when
populating initial input states for Focus On*/Custom layouts.
2022-08-05 09:52:36 -03:00
Gustavo Trott
3e6d546062
Merge pull request #15367 from danielpetri1/pdf-disabledFeatures-tldraw 2022-08-04 21:51:57 -03:00
Ramón Souza
eb19199235 adjust dial-in button styles 2022-08-04 14:17:45 -03:00
KDSBrowne
942327f4f1 Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into bbb-tldraw-latest 2022-08-04 12:51:48 +00:00
Ramón Souza
9cfc3e7edd
Merge pull request #15343 from frankemax/dynamic-filter-emojis
feat(emoji-picker): dynamically filter emojis
2022-08-04 09:42:56 -03:00
KDSBrowne
48cc57dbaf move variable definition 2022-08-03 14:30:22 +00:00
KDSBrowne
7ade8a0d7d Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into bbb-tldraw-latest 2022-08-03 14:23:38 +00:00
KDSBrowne
b66e44a4cb Upgrade tldraw to latest version 2022-08-03 14:19:12 +00:00
Ramón Souza
7408523b2c
Merge pull request #15473 from KDSBrowne/bbb-15381
refactor: Add Whiteboard Shortcuts to Help Modal
2022-08-03 10:23:41 -03:00
Ramón Souza
ded8493f05 Merge remote-tracking branch 'upstream/v2.5.x-release' into 2526-aug3 2022-08-03 09:53:41 -03:00
Ramón Souza
9e219d9cb3 adjust cc icon position 2022-08-02 17:33:53 -03:00
KDSBrowne
7c6f7f64b1 update icons in shortcuts modal 2022-08-02 15:33:33 +00:00
Anton Georgiev
ca0195585f
Merge pull request #15441 from antonbsa/audio-tests
test: Add new audio tests
2022-08-02 11:07:04 -04:00
Daniel Petri Rocha
3529fe9f28 Rename parameters; hide download button and label when disabled 2022-08-02 15:53:40 +02:00
KDSBrowne
b838d3862d localize tabs in shortcut modal 2022-08-02 11:43:29 +00:00
KDSBrowne
aabfdbb991 update shortcut modal style | add new shortcuts for WB 2022-08-01 22:41:48 +00:00
Joao Victor
efb40e00bb fix(layout): don't show navbar/action-bar before layout has been calculated 2022-07-29 16:02:31 -03:00
Gabriel Porfirio
8198953f30 removing unused imports 2022-07-28 16:50:31 -03:00
Ramón Souza
d9f2660d6a
Merge pull request #15330 from JoVictorNunes/vb-improvements-Jul-04
improvement(virtual background): better error handling, notifications…
2022-07-28 09:25:00 -03:00
Ramón Souza
40f61ecce4
Merge pull request #15452 from JoVictorNunes/fix-crash-remove-background
fix: check virtual background index
2022-07-27 16:40:46 -03:00
Ramón Souza
49b12e57c0
Merge pull request #15446 from KDSBrowne/2.6-console-err
fix(wb): Fix Console Type Error on Shape Hover
2022-07-27 16:20:24 -03:00
Joao Victor
d2eda01bcb fix: check for undefined value 2022-07-27 16:15:19 -03:00
KDSBrowne
a485f372f6 fix console error 2022-07-27 18:46:44 +00:00
Ramón Souza
1da57d8c50
Merge pull request #15455 from ramonlsouza/add-missing-media-init
fix: In Android Screen share and Share external video not showing to newly joined
2022-07-27 15:01:36 -03:00
Ramón Souza
b4fb203593 fix mobile init values for external video/screnshare 2022-07-27 10:56:04 -03:00
Ramón Souza
ccce085aed Merge remote-tracking branch 'upstream/v2.6.x-release' into issue-15001 2022-07-27 09:49:19 -03:00
Ramón Souza
640356af4f
Merge pull request #15442 from ramonlsouza/issue-15431
fix: chat panel resizing in RTL
2022-07-27 09:05:21 -03:00
Joao Victor
fe669b2f58 fix: check virtual background index 2022-07-27 09:00:18 -03:00
Gustavo Trott
acb0465266
Merge pull request #15412 from JoVictorNunes/export-presentation 2022-07-26 17:49:09 -03:00
Ramón Souza
b00d19b097
Merge pull request #15110 from ramonlsouza/fix-restore-on-update
fix: autoSwapLayout/restoreOnUpdate new presentation fails to show (2.5)
2022-07-26 16:38:33 -03:00