Commit Graph

9025 Commits

Author SHA1 Message Date
Ramon Souza
76c4bb6c85 Merge remote-tracking branch 'upstream/develop' into pr-11408 2021-02-23 11:35:21 -03:00
Anton Georgiev
fc001a142c
Merge pull request #11443 from mariogasparoni/develop
Do not uncessarily fetch locales at first time you open/save settings menu
2021-02-23 09:31:24 -05:00
Anton Georgiev
777bf01e8b
Merge pull request #11451 from hiroshisuga/patch-23
Show modals overlaid on full-screen slide or shared screen
2021-02-23 09:18:50 -05:00
Mario Jr
2e92de8010 Clean up HTMLAudioElement used for notification sounds
After ending the notification playback, we set the ".src" property to null, which immediately stop the internal player of mobile browser (tested on Chrome for Android -  device list is on #11458).
For the specific list of devices, this prevents the internal buffer error "-61" described in #11458.
Fixes #11458.
2021-02-23 11:12:37 -03:00
Ramon Souza
6eaa0c8079 fix skip check test 2021-02-23 10:53:37 -03:00
Anton Georgiev
111109674e
Merge pull request #11247 from ramonlsouza/language-dropdown
Reduces the number of options displayed on locale settings dropdown
2021-02-22 15:44:29 -05:00
Anton Georgiev
dfa754af79
Merge pull request #11436 from AadityaPrakash/meteor-config
Implemented merge option for default and local settings.
2021-02-22 15:30:15 -05:00
Anton Georgiev
0eac03394c remove duplicated logging of pengingAuth 2021-02-22 19:48:14 +00:00
Ramon Souza
b01246f23f rework on echo test flow 2021-02-22 15:09:14 -03:00
Tainan Felipe
b298bf4384 WIP add timestamp greater than to publisher 2021-02-22 13:35:32 -03:00
Ramon Souza
11d924af70 fix bbb_skip_check_audio_on_first_join 2021-02-22 10:43:58 -03:00
hiroshisuga
f6b7ca779f
show modal over fullscreen 2021-02-22 18:30:33 +09:00
Anton Georgiev
740a3a9db9 stop external video if presenter changed 2021-02-21 12:19:01 +00:00
Anton Georgiev
0b6496618c Merge branch 'develop' of github.com:amguirado73/bigbluebutton into external-video-sync-lucas 2021-02-21 11:04:39 +00:00
KDSBrowne
e2156157f5 remove comment 2021-02-21 06:12:38 +00:00
Mario Jr
6508674d38 Prevent ejecting user from them main room when leaving breakout room
When user observing changes, we must guarantee these changes are from main room, and not from breakout one.
Fixes #11029
2021-02-21 01:07:25 -03:00
KDSBrowne
babaf1b578 Merge branch 'develop' of https://github.com/bigbluebutton/bigbluebutton into 2.3-per-user-wb 2021-02-21 00:04:36 +00:00
Mario Jr
d961dea594 Do not uncessarily fetch locales at first time you open/save settings menu
Locales would be fetched even if you simply open and save settings window (without changing any setting)
We now test it similarly we do on 2.2
Closes #11318
2021-02-20 11:47:46 -03:00
Anton Georgiev
3589ee5232
Merge pull request #11423 from ramonlsouza/fix-layout-params
Fix layout params (show participants + show public chat) not affecting the meeting
2021-02-19 11:51:55 -05:00
Anton Georgiev
100d089246
Merge pull request #11437 from ramonlsouza/new-poll-results
Fix user-sent poll result messages
2021-02-19 10:38:34 -05:00
Anton Georgiev
d3a33382fe
Propagate typo fix from #11432
Needed for https://github.com/bigbluebutton/bigbluebutton/pull/11432
2021-02-19 10:34:20 -05:00
Ramon Souza
043fa4bac8 fix user-sent poll result messages 2021-02-19 10:57:11 -03:00
Aaditya Prakash
c3a7fde807 Implemented merge option for default and local settings. 2021-02-19 14:44:23 +01:00
hiroshisuga
195bb8363d
Update en.json 2021-02-19 17:18:26 +09:00
Anton Georgiev
ca9a3a6500 Pulled HTML5 locales on Feb 18, 2021 2021-02-18 22:15:35 +00:00
Anton Georgiev
35ea07b4cd
Merge pull request #11429 from antobinary/feb18-merge
Remove duplicate import of throttle
2021-02-18 15:54:29 -05:00
Anton Georgiev
58be3d42ef remove duplicate import of throttle 2021-02-18 20:52:23 +00:00
Anton Georgiev
d30f0dc710
Merge pull request #11428 from antobinary/feb18-merge
Merge 2.2 into 'develop'
2021-02-18 15:46:45 -05:00
Anton Georgiev
b3b905fd40
Merge pull request #11420 from Tainan404/develop+pr10919+pr10838
Fix user status in chat
2021-02-18 15:44:13 -05:00
Anton Georgiev
55e8de4357 Merge branch 'v2.2.x-release' of github.com:bigbluebutton/bigbluebutton into feb18-merge 2021-02-18 20:33:19 +00:00
Tainan Felipe
271736b30f Fix nav bar unread message indicator 2021-02-18 17:11:02 -03:00
dependabot[bot]
92c6c9a491
Bump node-notifier in /bigbluebutton-html5/tests/puppeteer
Bumps [node-notifier](https://github.com/mikaelbr/node-notifier) from 8.0.0 to 8.0.1.
- [Release notes](https://github.com/mikaelbr/node-notifier/releases)
- [Changelog](https://github.com/mikaelbr/node-notifier/blob/v8.0.1/CHANGELOG.md)
- [Commits](https://github.com/mikaelbr/node-notifier/compare/v8.0.0...v8.0.1)

Signed-off-by: dependabot[bot] <support@github.com>
2021-02-18 18:46:41 +00:00
Anton Georgiev
d686f0b04d
Merge pull request #11417 from KDSBrowne/bbb-11097
Skip publishing poll annotation to whiteboard if presentation swapped
2021-02-18 13:26:08 -05:00
Tainan Felipe
8825cd3789 remove uneeded log 2021-02-18 13:37:10 -03:00
Ramon Souza
3778ccb397 fix layout params not affecting the meeting 2021-02-18 13:11:02 -03:00
KDSBrowne
9aff7ea22b add yes / no / abstention poll btn 2021-02-18 16:06:21 +00:00
Anton Georgiev
e966d6c7b6
Merge pull request #11366 from MaximKhlobystov/updating-poll-ui
Updated poll UI: question field and typed responses
2021-02-18 10:32:33 -05:00
Anton Georgiev
d5e7f5cf67
Merge pull request #11339 from basisbit/v2.2.x-release
Enable video-pagination and cameraQualityThresholds by default
2021-02-17 18:37:40 -05:00
Anton Georgiev
49cdf9faef
Merge pull request #11413 from gustavotrott/develop
Include registeredOn date in pubSub user creation messages to replace loginTime creation in Meteor
2021-02-17 16:56:53 -05:00
Anton Georgiev
d16ee3067d
Merge pull request #11317 from antobinary/2.3-alpha5-with-split-meteor-roles-10349
Split Meteor roles backend-frontend revisit
2021-02-17 16:35:23 -05:00
Anton Georgiev
c6253b9953 Merge branch '2.3-alpha5-with-split-meteor-roles-10349' of github.com:antobinary/bigbluebutton into 2.3-alpha5-with-split-meteor-roles-10349 2021-02-17 20:52:33 +00:00
Anton Georgiev
683847304d on frontend attempt to handle events without matching queue 2021-02-17 20:51:36 +00:00
Tainan Felipe
c47b52cf71 Add user online status change 2021-02-17 17:43:41 -03:00
KDSBrowne
2f094f7048 skip publishing poll annotation to whiteboard if presentation swapped 2021-02-17 14:15:20 +00:00
Ramon Souza
1f2a653af1 fix 'data-test' values for chat messages 2021-02-17 11:03:28 -03:00
Gustavo Trott
573bfc107b Remove changes not related to issue 2021-02-17 09:39:36 -03:00
Gustavo Trott
91f4eba678 Replace registeredOn params to Long (timestamp) instead of String (ISO_OFFSET_DATE_TIME) 2021-02-17 09:20:55 -03:00
Anton Georgiev
45f6a0e69e
Merge branch 'develop' into 2.3-alpha5-with-split-meteor-roles-10349 2021-02-16 16:09:20 -05:00
Mohamed Amine Ben Salah
d8c5aa46d9
multiple automated tests suites updates + add missing polling specs and move them with old ones to a polling test suite (#10766)
* updating old tests + collecting more snapshots [WIP]

* updates old test suites and collects more visual regressions screenshots

* remove snapshots and their collection temporary

* run tests from packages.json

* update test execution command/export constants from .env to core/constants.js

* update tests/puppeteer/README.md file

* update LOOP_INTERVAL variable call and assign timeouts to the webcam share spec

* redefine waitForSelector func in page.js, update chat test suite specs and add poll chat message test spec

* Merge remote-tracking branch 'upstream/develop' into updating-old-tests-visual-with-visual-regressions

* update webcam test specs collecting videoPreviewTimeout and use it to wait for videoPreview selector

* update custom parameters test suite

* update breakout test suite

* update webcam layout test suite

* update multiusers test suite

* update notifications test suite

* update presentation test suite

* whiteboard test suite

* screenshare test suite

* update sharednotes test suite

* user ELEMENT_WAIT_TIME variable from timeouts constants.js

* list TEST CONSTANTS by category

* add poll test suite and assigns the right unassigned timeouts

* set test pages to headless
2021-02-16 15:57:10 -05:00
Anton Georgiev
b2c4244276 Merge branch 'develop' of github.com:bigbluebutton/bigbluebutton into 2.3-alpha5-with-split-meteor-roles-10349 2021-02-16 19:55:10 +00:00
Anton Georgiev
8933ca2de6
Merge pull request #11400 from KDSBrowne/bbb-10915
Fix user-list-item dropdowns breaking on mobile screen sizes
2021-02-16 14:51:22 -05:00
Anton Georgiev
3aa3591f12
Merge pull request #10291 from Tainan404/issue-8545
Store the changed and default settings in different variables
2021-02-16 14:49:53 -05:00
Gustavo Trott
12e363eb92 Removes loginTime creation from Meteor and use the registeredOn date created on Akka. Makes Akka send the registeredOn date throught PubSub messages: UserRegisteredRespMsg, GuestsWaitingForApprovalEvtMsg and ValidateAuthTokenRespMsg. 2021-02-16 14:46:30 -03:00
Anton Georgiev
970d91aecf Added deploy_to_usr_share.sh to override locally bbb-html5 2021-02-16 15:59:01 +00:00
Anton Georgiev
1cedc56504 process only some of CreateMeeting logic in frontends to avoid meeting duplication 2021-02-16 15:12:25 +00:00
Anton Georgiev
f43560d535 Support for backend vs frontend nodejs instances bbb-html5 2021-02-16 03:19:31 +00:00
Ramon Souza
c88e4e3133 show uploaded slides from other users 2021-02-15 15:23:02 -03:00
hiroshisuga
91f6bc752a
show polling button in fullscreen mode 2021-02-15 17:54:02 +09:00
KDSBrowne
55d91f8616 fix user-list-item dropdowns breaking on mobile screen sizes 2021-02-13 19:06:45 +00:00
hiroshisuga
97d390cd0e
Update service.js 2021-02-13 10:20:45 +09:00
Anton Georgiev
1476deb268
Merge pull request #11173 from Tainan404/develop+pr10919+pr10838
Chat with adapter and context
2021-02-12 16:35:22 -05:00
Tainan Felipe
de24ec94c6 Fix user typing, message form alligment and private chat title 2021-02-12 17:54:44 -03:00
Tainan Felipe
29864e7955 improve performance of chat copy 2021-02-12 16:43:56 -03:00
Tainan Felipe
f2107a87f7 Fix copy/save public chat 2021-02-12 16:13:21 -03:00
Anton Georgiev
188c406e1b
Merge pull request #11389 from ramonlsouza/issue-11351
Fixes interruption of webcam, external video and screenshare when user changes language settings
2021-02-12 13:46:22 -05:00
Tainan Felipe
b99faecd67 Fix rtl on chat item 2021-02-12 15:07:05 -03:00
Tainan Felipe
133b561d4b Fix outline clipping on message form 2021-02-12 14:53:50 -03:00
Tainan Felipe
80be16a8ce Fix blank chat issue 2021-02-12 14:43:04 -03:00
Ramon Souza
1083fe810a no unmount on change locale 2021-02-12 13:55:39 -03:00
Tainan Felipe
b20c606e9c Add close chat feature 2021-02-12 11:07:53 -03:00
Mario Jr
b7216dd100 Preserve mutestatus when disconnecting/reconnecting microphone
After audio reconnection, a muted user would have it's microphone unmuted by default, unless muteOnStart is set to true. This fix this problem.
Fixes #9016
2021-02-11 23:55:34 -03:00
Anton Georgiev
39759c7a16
Merge pull request #11298 from ramonlsouza/issue-11270
Set safe default values for slide position (WIP)
2021-02-11 12:34:23 -05:00
Anton Georgiev
45aa7ff55a
Merge pull request #8697 from Tainan404/issue-8610-2
Fix lost output audio when change client language
2021-02-11 12:29:17 -05:00
Anton Georgiev
81f5302696
Merge pull request #11381 from ramonlsouza/PR-8696
Skip echo test in breakout room
2021-02-11 09:41:42 -05:00
Anton Georgiev
78b21c98ad
Merge pull request #11376 from KDSBrowne/bbb-11372
Make screen reader announce status changes in userlist
2021-02-11 09:02:17 -05:00
Ramon Souza
0034b1bccc resolve conflicts 2021-02-11 10:23:38 -03:00
Ramon Souza
46af7880d6 Merge remote-tracking branch 'upstream/develop' into PR-8696 2021-02-11 09:12:13 -03:00
KDSBrowne
eb5cd228b4 make screen reader announce status changes in userlist 2021-02-10 23:53:59 +00:00
Jacob Burroughs
1131ad1987 Fix rendering after public chat cleared
This bug was introduced in #11305, as the system-generated message notifying
the user that the chat history has been cleared does not have an id.

fixes #11349
2021-02-10 22:07:22 +00:00
Ramon Souza
672bd3f318 Merge branch 'PR-10217' into develop 2021-02-10 17:55:32 -03:00
Ramon Souza
3652562b63 resolve conflict 2021-02-10 17:35:55 -03:00
Pedro Beschorner Marin
09b39a8d63 Add extra pad validation
Associate pads with meetings so session validation is restricted to the
meeting's valid session tokens.

Meteor will dispatch new redis events on shared notes and closed captions
pads creation. This event will go through apps and reach web to populate
a new meeting's pad collection that contains all valid pad id's for that
session. Nginx will use this collection to check if the user's session token
belongs to the pad's authorized users.

Besides these modifications, an extra change will be needed at notes.nginx.
Location /pad/p/ needs to change it's auth_request:

from /bigbluebutton/connection/checkAuthorization;
to /bigbluebutton/connection/validatePad;
2021-02-10 13:37:04 -03:00
Anton Georgiev
35e631cff4
Merge pull request #11370 from ramonlsouza/issue-8367
Add delay to join video button
2021-02-10 09:00:08 -05:00
Ramon Souza
9738f42432 add debounce to join video button 2021-02-10 10:44:45 -03:00
Tainan Felipe
e2b68a3202 Fix missing file 2021-02-10 10:33:18 -03:00
Tainan Felipe
e05d8886c6 Handle clear chat and fix clear message 2021-02-10 10:14:30 -03:00
Anton Georgiev
eddc3f0e1e
Merge pull request #11364 from ramonlsouza/issue-11338
Fix webcam video dropdown collapse after expanding
2021-02-09 19:54:04 -05:00
Anton Georgiev
adefc6a20c
Merge pull request #11341 from ramonlsouza/breakout-invitation-settings
Add property to settings.yml to enable/disable breakout invitations to moderators
2021-02-09 15:50:24 -05:00
Anton Georgiev
f11c9e69d0
Merge pull request #11365 from ramonlsouza/issue-10035
Stop screenshare on joining breakout room
2021-02-09 15:41:20 -05:00
Ramon Souza
54f983f250 stop screenshare on joining breakout room 2021-02-09 17:22:39 -03:00
Ramon Souza
cde124f237 fix webcam video dropdown collapse 2021-02-09 16:12:33 -03:00
Anton Georgiev
fa89646188
Merge pull request #11363 from lfzawacki/insecure-video-urls
Don't validate insecure http urls for external video to prevent browser errors
2021-02-09 14:04:12 -05:00
Lucas Zawacki
7216619811 Don't validate insecure http urls for external video to prevent browser errors 2021-02-09 15:24:21 -03:00
Joao Siebel
0e79203119 Clear screenshare collection when meeting has ended while screensharing 2021-02-09 14:26:43 -03:00
Anton Georgiev
6c64545e67
Merge pull request #11357 from jfsiebel/2.3-clear-collections-on-meeting-end
[2.3] Clear missing collections on meeting end
2021-02-09 12:04:52 -05:00
Joao Siebel
7f4b2789f2 Clear screenshare collection when meeting has ended while screensharing 2021-02-09 13:44:49 -03:00
Pedro Beschorner Marin
c0a7f9cd92 Replace FNV32a pad's id generator with salted SHA1
When managing Etherpad's pads, Meteor makes API calls to initiate the closed captions
and shared notes modules. The pad id was being mapped to a shorter id than the meeting
id because of a Etherpad lenght limitation.

Changed to something less guessable.
2021-02-09 12:59:59 -03:00
Anton Georgiev
3d78045363 Clear meeting-time-remaining collection 2021-02-09 12:44:33 -03:00
Joao Siebel
811d6d3f98 Clear guestUsers, voiceCallStates and whiteboard-multi-user collections on meeting end 2021-02-09 12:44:10 -03:00
Anton Georgiev
74d34e1a10
Merge pull request #11319 from ramonlsouza/fullscreen-polling-buttons
Display polling buttons on fullscreen presentation
2021-02-09 09:50:35 -05:00
Anton Georgiev
6b3c97037f Clear meeting-time-remaining collection 2021-02-09 11:23:51 -03:00
Tainan Felipe
e99825f60a Merge remote-tracking branch 'upstream/develop' into develop+pr10919+pr10838 2021-02-09 10:40:39 -03:00
Ramon Souza
319a620d7e polling fullscreen now only checks if presentation is fullscreen 2021-02-09 10:15:29 -03:00
Tainan Felipe
99ebbf0b17 Remove unused props from proptype 2021-02-09 09:44:01 -03:00
Joao Siebel
2eb8abcba9 Clear guestUsers, voiceCallStates and whiteboard-multi-user collections on meeting end 2021-02-09 09:30:09 -03:00
Ramon Souza
5607ed4007 disable user typing notifications when feature is disabled 2021-02-09 09:06:48 -03:00
Maxim Khlobystov
7a703464de Small misprint introduced in the merge 2021-02-09 06:22:41 +00:00
dependabot[bot]
530d1429a1
Bump axios from 0.18.1 to 0.21.1 in /bigbluebutton-html5/tests/puppeteer
Bumps [axios](https://github.com/axios/axios) from 0.18.1 to 0.21.1.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md)
- [Commits](https://github.com/axios/axios/compare/v0.18.1...v0.21.1)

Signed-off-by: dependabot[bot] <support@github.com>
2021-02-09 00:27:36 +00:00
Anton Georgiev
e2e0b78d40 Merge branch 'develop' of github.com:bigbluebutton/bigbluebutton into split-meteor-roles-on-top-of-2.3-alpha6 2021-02-08 23:39:42 +00:00
Maxim Khlobystov
ff4260dc98 Merge branch 'develop' of https://github.com/bigbluebutton/bigbluebutton into updating-poll-ui 2021-02-08 21:41:43 +00:00
Anton Georgiev
86d056d53c
Merge pull request #11343 from antobinary/alpha6-locales
Pulled HTML5 locales, Feb 8, 2021
2021-02-08 15:42:00 -05:00
Tainan Felipe
3e921ee93b Remove filter for messages before login time 2021-02-08 17:35:16 -03:00
Anton Georgiev
146d42ecae Pulled HTML5 locales, Feb 8, 2021 2021-02-08 20:35:08 +00:00
Tainan Felipe
44bdfa6e5d Improve adapter to batch messages 2021-02-08 17:00:18 -03:00
Ramon Souza
a3780209f3 Add property to settings.yml to enable/disable breakout invitations to moderators 2021-02-08 14:40:03 -03:00
basisbit
d5c9cc38e7
disable video-pagination for desktop view users by default
also adjusted moderator mobile video-pagination as suggested by @prlanzarin
2021-02-08 18:13:26 +01:00
Tainan Felipe
2103b9331c Fix crash in private chat and unread counter in opened chats 2021-02-08 13:55:10 -03:00
basisbit
5af1f1cd81
Enable video-pagination and cameraQualityThresholds by default
One of the main issues in 2.2.x problem reports currently in the wild in social media and in the bbb admin groups seems to be that people turn a couple of webcams on and the clients or the server already can't handle it any more. In most cases, enabling video-pagination for mobile devices and also cameraQualityThresholds already "solves" the problem and makes it possible for much more students to attend online-class as well as raise acceptance of using BBB instead of other commercial services.
Even after promoting these new settings for weeks, many BBB operators still don't know of them and are surprised and happy once they enable it.
This change contians rather high values so that admins see that these features exist, but typical use cases which might not want video-pagination enabled (typical 28people school class) are still not "annoyed".
2021-02-08 15:44:01 +01:00
Pedro Beschorner Marin
d7c0975b61 Fix mobile user-list identification
Added the missing extractCredential method and replaced the old callback strategy
with the new try-catch block.
2021-02-08 09:55:38 -03:00
Ramon Souza
463694aff9 moved fullscreen pollingContainer to PresentationArea + fix duplicated component in fullscreen 2021-02-08 08:50:47 -03:00
prlanzarin
03cd3af26c screenshare: change the reconnection UI style trigger to avoid false positives
Mainly: track unhealthy fatal states instead of supposedly healthy states

Avoids unwarranted UI reconnecting states or flickering on low end devices or struggling networks

Also added a version of isVideoBroadcasting for presenters which only accounts for the server state, so that we can deal with the presnter`s sharing state with more fidelity in the UI
2021-02-05 19:54:12 -03:00
prlanzarin
e0e22733dd video-provider,screenshare: consider a stream unhealthy only when the peer fails
Done to avoid false positives where the stream would transition to the unhealthy UI state (or flicker between states) due to disconnected also triggering it, which is not fatal. Disconnected has to be used alongside getStats heuristics, which I removed due to issues with it, so I´m hardening the transition to fatal states only
2021-02-05 19:54:05 -03:00
Anton Georgiev
75a1896b0d Set default cursorInterval to 150ms (was 40ms) 2021-02-05 21:42:52 +00:00
Anton Georgiev
363c801338
Merge pull request #11215 from pedrobmarin/guest-draft
Disable authenticated guests
2021-02-05 16:13:46 -05:00
Ramon Souza
ac87b6c401 correctly display polling buttons if presentation is fullscreen 2021-02-05 17:06:14 -03:00
Anton Georgiev
7343b23d37
Merge pull request #11272 from KDSBrowne/bbb-10733
Clone unmuted input stream for usage with hark
2021-02-05 13:44:02 -05:00
Anton Georgiev
8c0f0fdd52 Split Meteor roles backend-frontend revisit 2021-02-05 17:47:46 +00:00
Anton Georgiev
d9b7a76092
Merge pull request #11314 from KDSBrowne/bbb-11291
Fix icon in chat poll result not displaying
2021-02-05 12:41:24 -05:00
Anton Georgiev
330561c19b
Merge pull request #11312 from KDSBrowne/bbb-10002
Fix message list not updating when switching between private chats
2021-02-05 12:40:29 -05:00
Anton Georgiev
46d98a5afd
Merge pull request #11315 from ramonlsouza/fix-video-preview-blink
Fix video preview modal behavior
2021-02-05 12:38:54 -05:00
Ramon Souza
78b61103da fix video preview blink when skip preview = true 2021-02-05 14:30:58 -03:00
KDSBrowne
852ea929a8 add default poll color for chat results 2021-02-05 16:29:58 +00:00
KDSBrowne
9307215a2d make chat list element key unique 2021-02-05 01:07:24 +00:00
Anton Georgiev
c0c5a87e3c
Updated CopyRight year in bbb-html5 to 2021 2021-02-04 16:58:45 -05:00
Anton Georgiev
5a6f232989
Merge pull request #11285 from ramonlsouza/issue-10454
Changes on webcam skip preview behavior
2021-02-04 13:43:46 -05:00
KDSBrowne
0abdf00a25
Add new join param skip echo test on first join only (#11284)
* add param to force echo test when user joins audio after init

* fix UI stuck on connecting when userdata-bbb_auto_join_audio=false

* fix conditions for joinFullAudioImmediately and joinFullAudioEchoTest | remove old format

* remove extra param in getItem

* recover audioLocked | only set getEchoTest if doesnt exist
2021-02-04 13:42:31 -05:00
Ramon Souza
b1cb4435ee introduce userdata-bbb_skip_video_preview_on_first_join parameter 2021-02-04 15:05:48 -03:00
Anton Georgiev
0db4c167de
Merge pull request #11273 from Dogr95/patch-1
Update guest-wait.html
2021-02-04 10:57:26 -05:00
Anton Georgiev
b796a8beb7
Merge pull request #11280 from MaximKhlobystov/fix-user-random-select
Fix for random user picking: presenter is notified when there's no viewers to randomly pick from
2021-02-04 10:32:50 -05:00
Anton Georgiev
1c598d81c1
Merge pull request #11293 from PhMemmel/fixNotificationLabelTranslation
fixes non localized notifications label in settings
2021-02-04 10:24:02 -05:00
Anton Georgiev
d667174571
Merge pull request #11305 from Tainan404/fix-overlapping-messages
Fix overlapping messages
2021-02-04 10:19:58 -05:00
Tainan Felipe
2a57982e24 Fix overlapping messages 2021-02-04 11:02:19 -03:00
Ramon Souza
f649f67655 current user identification on breakout room creation 2021-02-04 10:59:13 -03:00
Maxim Khlobystov
89f968deab Better code readability for random-user component 2021-02-04 06:18:40 +00:00
Tainan Felipe
9cf483d18f Change message getter 2021-02-03 17:49:58 -03:00
Ramon Souza
06bd75dd9e make sure slidePosition is only used if it exists 2021-02-03 16:38:09 -03:00
Ramon Souza
49ee9821f8 possible fix for #11270 2021-02-03 13:49:14 -03:00
Anton Georgiev
c11c4fcf1b
Merge pull request #10805 from hex-m/fixing_strings
string fixes
2021-02-03 10:01:52 -05:00
Ramon Souza
55651506a4 improve language selector filter, closes #10706 2021-02-02 15:44:58 -03:00
Tainan Felipe
a7534fa2e5 Fix missing lodash 2021-02-02 09:59:39 -03:00
Tainan Felipe
7b4f6e2231 Fix hit area of more message bellow and css recalc 2021-02-01 19:12:04 -03:00
Philipp Memmel
5049698d13 fixes non localized notifications label in settings 2021-02-01 15:57:43 +00:00
Maxim Khlobystov
9162f3b286 Make sure presenter is notified when there's no viewers to randomly pick from 2021-02-01 04:41:28 +00:00
vertiKarl
f24b0f6569
Update guest-wait.html
fixed typo
2021-01-30 20:37:44 +01:00
KDSBrowne
d3fa32e111 clone unmuted input stream for usage with hark 2021-01-30 17:04:07 +00:00
Mario Jr
08732767e3 Removed duplicated audio filter option in Settings > Application 2021-01-29 19:23:38 -03:00
Mario Jr
b582b1ca78 Correctly return MediaStream object when calling audio-manager's inputStream
This was missed in recent audio/sip.js changes.
MediaStream is now returned from SIP.js
Related to #10733
2021-01-29 19:05:51 -03:00
Anton Georgiev
aae9ca055a Pulled HTML5 locales Jan 29, 2021; tested 2021-01-29 21:22:20 +00:00
Anton Georgiev
09e6ba8dfd Merge branch 'v2.2.x-release' of github.com:bigbluebutton/bigbluebutton into merge-Jan30 2021-01-29 20:58:05 +00:00
Joao Siebel
09f5931d65 Keep track of active connection id for users 2021-01-29 17:29:07 -03:00
Anton Georgiev
1564a7a9d9
Merge pull request #11264 from ramonlsouza/fix-typing-indicator-display
Fixes typing indicator display
2021-01-29 12:39:12 -05:00
Tainan Felipe
dd63051825 fix typing indicator display 2021-01-29 14:33:51 -03:00
Anton Georgiev
60cfeb6189
Merge pull request #11263 from ramonlsouza/fix-active-webcam-icon
Fixes active webcam icon
2021-01-29 12:28:39 -05:00
Anton Georgiev
d122639042
Merge pull request #11239 from jfsiebel/sync-with-active-connections
Synchronize users with active connections
2021-01-29 12:28:07 -05:00
Joao Siebel
68b2752e0d Add flag to enable sync 2021-01-29 14:27:13 -03:00
Ramon Souza
6c1856c0a4 fix active webcam icon 2021-01-29 14:23:50 -03:00
Mario Jr
f2de2806eb Add setting for enabling/disabling microphone audio filters
As explained in #11143, disabling audio filters is desired in some scenarios.
This basically adds an option for user to disable default constraints.
When user doesn't change this value in Settings > Application, the default
value for each audio constraints is retrieved from settings.yml.
When user changes this value in Settings > Application, audio
filters (AGC, Noise Supression and Echo Cancellation) are all set to
true/false, according to the value selected in the Settings GUI.

To start it simple, we decided to not to add a different setting in the GUI for
each audio contraint. This may be added in the future, though (perhaps in a
dedicated Audio Settings tab)
This is related to #4873
2021-01-29 14:18:15 -03:00
Ramon Souza
f72a7f0fea create a reusable component for settings and captions language dropdown 2021-01-29 13:17:35 -03:00
Anton Georgiev
abb44a7949 Set default cursorInterval to 150ms (was 40ms) 2021-01-28 09:42:36 -05:00
Ramon Souza
7c2a488f15 show only variations of the selected language on locale settings 2021-01-27 16:50:48 -03:00
Anton Georgiev
b2c702417c
Merge pull request #11216 from werk21/9101_add_poll_abstention
9101 add poll abstention
2021-01-27 11:57:15 -05:00
Anton Georgiev
aae4d1567d
Merge pull request #11232 from prlanzarin/u22-lv521012021
video-provider: fix inconsistent client state when a webcam being shared times out
2021-01-27 11:29:16 -05:00
Anton Georgiev
28eb93ebaa
Merge pull request #11244 from antobinary/bbb-11197
Update axios to 0.21.1
2021-01-27 11:24:50 -05:00
Anton Georgiev
07b4142a27 update axios to resolve security vuln 2021-01-27 11:19:59 -05:00
Joao Siebel
31552f6c78 Add heapdump threshold in settings 2021-01-27 11:04:49 -03:00
Anton Georgiev
12a6b73ba0
Merge pull request #11240 from antobinary/bbb-11197
Prevent open textarea blocking dropdown menus
2021-01-26 17:16:03 -05:00
KDSBrowne
47e2f12b74 prevent open textarea blocking dropdown menus 2021-01-26 17:13:18 -05:00
Anton Georgiev
991d978f77
Merge pull request #11230 from prlanzarin/u22-poodlepower25012021
audio: fix talking-indicator mute debounce
2021-01-26 16:55:10 -05:00
Anton Georgiev
e2f821d780
Merge pull request #11229 from prlanzarin/u22-revert10912
video-provider: Revert "Improve 16x9 Support"
2021-01-26 16:51:03 -05:00
Anton Georgiev
28fc33462d
Merge pull request #11228 from prlanzarin/u22-frameshift26012021
video-provider: make video-list-item actions dropdown keys unique
2021-01-26 16:50:01 -05:00
Anton Georgiev
5e365d138f
Merge pull request #11231 from prlanzarin/u22-drc25012021
audio: add a configurable throttle to action-bar`s mute toggle
2021-01-26 16:49:13 -05:00
Joao Siebel
8c7c21f936 Sync users in collection with server active connections 2021-01-26 16:22:32 -03:00
Mario Jr
b753ef5d8d Fix wrong path in settings for audio constraints
Using now 'application' instead of old 'audio' path
2021-01-26 14:12:18 -03:00
Anton Georgiev
6c27e815fc Only publish full users to client side, no dummy users 2021-01-26 16:56:28 +00:00
prlanzarin
c57941dbdb video-provider: make video-list-item actions dropdown keys unique
When multiple actions were bolted in the dropdown (mirror, focus), keys were getting duplicated with cameraId. Make them unique based on the action`s name
2021-01-26 12:32:27 -03:00
prlanzarin
32e7ddeaf7 Revert "Improve 16x9 Support"
This reverts commit b8fc94c722.
2021-01-26 12:03:11 -03:00
prlanzarin
c37c3d0c7b video-provider: fix inconsistent client state when a webcam being shared timed out (1020)
Recent fix to the stop all cameras behaviour exposed a bug where the local camera connecting state wasnt being cleared up when a camera timed out before being successfully shared
2021-01-26 11:49:39 -03:00
prlanzarin
234efd289a audio: add a configurable throttle to action-bar`s mute toggle
Default value is 300ms, with default trailing/leading. Set toggleMuteThrottleTime to 0 to restore old behaviour
2021-01-26 11:47:48 -03:00
prlanzarin
a8f817555d audio: fix talking-indicator mute debounce
The debounce method argument was being passed wrong (its supposed to be a method, not a function call), thus spewing exceptions in the console and rendering the debounce virtually ineffective
2021-01-26 11:44:45 -03:00
Mario Jr
7858ba94ba Avoid setting empty/undefined constraint
This removes the console warning about invalid constraint
2021-01-25 23:45:27 -03:00
Tainan Felipe
3aa8e115b5
Merge branch 'develop' into unsafe-whiteboard-components 2021-01-25 17:36:12 -03:00
Pedro Beschorner Marin
7e26e78c4f Cleanup from authenticated guests removal
While cherry-picking some of this work I noticed those extras.
2021-01-23 22:22:52 -03:00
werk21
80af96ff76 9101: Survey: New profile yes/no/abstention 2021-01-24 02:22:40 +01:00
Pedro Beschorner Marin
e595d31f80 Set default guest configuration
Changes to the current (v2.2) default configuration of the guest feature.

The ideal is to keep the simplified guest feature as default (`authenticatedGuests=false`)
but we also need to be in sync with Greenlight settings to make this happen.

Greenlight will have to re-add the `guest=true` param on user's join API call when ASK_MODERATOR
is set as guest's policy.
2021-01-23 21:58:34 -03:00
Pedro Beschorner Marin
4fbc237a8f Configurable users' labels
User's name labels can be enabled and disabled at `settings.yml`.
2021-01-23 21:58:25 -03:00
Pedro Beschorner Marin
85ee3b283f Identify mobile users at user list 2021-01-23 21:57:55 -03:00
Pedro Beschorner Marin
bd15f14ca0 Allow guests promotion/demotion
When authenticated guest is disabled (bigbluebutton-web's `authenticatedGuest` property)
2021-01-23 21:55:20 -03:00
Pedro Beschorner Marin
ea207d6f8c Adjust guest panel header and width 2021-01-23 21:54:51 -03:00
Pedro Beschorner Marin
a8af70993b Make the guest list a scrollable element 2021-01-23 21:52:52 -03:00
Pedro Beschorner Marin
0bbef12ac7 Authenticated guests feature controlled at bbb-web properties 2021-01-23 21:48:02 -03:00
KDSBrowne
a76b740ffe prevent open textarea blocking dropdown menus 2021-01-22 21:42:45 +00:00
Anton Georgiev
8a72b8ef22
Merge pull request #11194 from ramonlsouza/PR-9946-fix
Improves the end meeting confirmation message
2021-01-22 15:33:18 -05:00
Anton Georgiev
45c1ff6e40
Merge pull request #11175 from MaximKhlobystov/select-random-user
Presenter selecting a random viewer
2021-01-22 15:31:00 -05:00
Ramon Souza
244842c86b applying suggested changes 2021-01-22 16:48:50 -03:00
Mario Jr
97c76900cb Add setting for enabling/disabling microphone audio filters
As explained in #11143, disabling audio filters is desired in some scenarios.
This basically adds an option for user to disable default constraints.
When user doesn't change this value in Settings > Application, the default
value for each audio constraints is retrieved from settings.yml.
When user changes this value in Settings > Application, audio
filters (AGC, Noise Supression and Echo Cancellation) are all set to
true/false, according to the value selected in the Settings GUI.

To start it simple, we decided to not to add a different setting in the GUI for
each audio contraint. This may be added in the future, though (perhaps in a
dedicated Audio Settings tab)
This is related to #4873
2021-01-22 16:30:42 -03:00
Anton Georgiev
ac9cec4149
Merge pull request #11165 from daminebenq/update-custom-params-autotests
adds missing custom parameters specs to the custom parameters test suite
2021-01-21 16:03:13 -05:00
Joao Siebel
bb831e0442 Modify throttle interval to be a const variable 2021-01-21 14:05:59 -03:00
Joao Siebel
8f36ac3586 Add throttle to startUserTyping function 2021-01-21 13:05:41 -03:00
Tainan Felipe
1a46a2fb1e fix typing indicator display 2021-01-21 11:49:48 -03:00
Ramon Souza
3742746de3 PR 9946 + suggested text changes 2021-01-20 17:49:07 -03:00
Ramon Souza
f04733d85e Merge remote-tracking branch 'upstream/develop' into PR-9946-fix 2021-01-20 17:42:47 -03:00
Anton Georgiev
af76a56ba7
Merge pull request #11186 from ramonlsouza/issue-11181
Fixes crash when presenter is kicked
2021-01-20 11:42:37 -05:00
Ramon Souza
ef1725fff9 fixes similar bug on user-list/service/getEmoji function 2021-01-20 13:22:17 -03:00
Ramon Souza
6f9d60c520 code style 2021-01-20 11:39:47 -03:00
Joao Siebel
fa0fd8a054 Add configurable process interval for cursor and annotations 2021-01-20 11:36:40 -03:00
Ramon Souza
fe12208d6c better fix for issue #11181 2021-01-20 11:28:37 -03:00
Ramon Souza
b0551e24ad added a comment on the code to make changes clear 2021-01-20 10:07:00 -03:00
Ramon Souza
79bbbc0fb1 Fixes #11181 2021-01-20 09:23:51 -03:00
Anton Georgiev
62aca3b8ae
Merge pull request #11179 from ramonlsouza/issue-11116
Fixes closed captions language list
2021-01-19 15:31:32 -05:00
Ramon Souza
39b63368e2 Fixes #11116 2021-01-19 17:16:29 -03:00
Tainan Felipe
141be357ed Little clean up 2021-01-19 14:16:34 -03:00
Tainan Felipe
8e2fe47c6f Implements chat using react context as middleware 2021-01-19 14:06:32 -03:00
KDSBrowne
3f0cde7dbb Merge branch 'develop' of https://github.com/bigbluebutton/bigbluebutton into bbb-11056 2021-01-19 16:02:32 +00:00
KDSBrowne
206cae3707 fix locale fetch loop with xx_XX fallback/override 2021-01-19 16:02:20 +00:00
Maxim Khlobystov
5238dac647 Remove callbacks from update and clear Mongo operations for randomly selecting a user 2021-01-19 01:53:13 +00:00
Maxim Khlobystov
88c6e773e3 Fix the issue with connectionStatus resulting in no users being availble to randomly pick from (select random viewer feature) 2021-01-19 01:01:46 +00:00
Anton Georgiev
0ba3aa713a
Merge pull request #10912 from lkiesow/16x9
Improve 16x9 Support
2021-01-18 16:05:01 -05:00
Fred Dixon
27cb9e8a39
Merge pull request #11078 from hiroshisuga/patch-11
Remove mountModal requirement in presentation uploader
2021-01-15 22:53:53 -04:00
Mohamed Amine Ben Salah
1c40b0b8c8 adds missing custom parameters specs to the custom parameters test suite 2021-01-15 19:51:52 -03:00
prlanzarin
0a36da1e46 screensharing: remake error locales, split them into error classes
There are new locale strings for screensharing errors with a new format (Code X. #What to do) to make it easier for the end user
2021-01-13 09:43:28 -03:00
prlanzarin
25f5139973 screenshare: clean up getDisplayMedia method bindings 2021-01-13 09:05:24 -03:00
prlanzarin
077369c442 screenshare: add a centralized error code/message helper 2021-01-13 09:05:18 -03:00
prlanzarin
9a916878f9 sfu: split broker errors into different classes
Will be used in subsequent changes to allow us to compose them into error normalization procedures
2021-01-13 09:05:12 -03:00
prlanzarin
b4ac2e7fd3 Bump min Firefox (desktop) version to 68
Rationale: removed support for gUM based screen sharing. Uses getDisplayMedia now, minimum FF 68 and Chrome 72
2021-01-13 09:04:59 -03:00
prlanzarin
c9220a48b7 screenshare: remove deprecated chrome extension configs 2021-01-13 09:04:52 -03:00
prlanzarin
6f16154035 screenshare: logging/trailing lines cleanup 2021-01-13 09:04:46 -03:00
Paulo Lanzarin
1f3d487ecc
Merge pull request #11142 from pedrobmarin/fix-multiple-webcam-stop-all
Fix stream stop for multiple webcams
2021-01-12 17:35:10 -03:00
Mario Jr
92708da447 Allow audio constraints to be changed in bbb-html5's settings.yml
In some scenarios, there's no need for the browser to apply such audio filters. For example, when user's microphone already does audio filtering (echo cancellation, noise supression ...).
This commit doens't change the current behavior (filters still follow browser's default config): admins need to uncomment/set these values if disabling/enabling specific filters if desired.
This is related to #4873
2021-01-12 14:42:27 -03:00
Pedro Beschorner Marin
cc9b552e2a Fix stream stop for multiple webcams
Video provider's service for local stream control was wrongly setting the disconnected
state when a multiple webcam user tried to stop a single cam. The `stopVideo` method
was inconsistent when called multiple times for the same `cameraId`.

Included a better testing scope for event dispatching and disconnected state handling.
2021-01-12 13:24:40 -03:00
basisbit
9c3c926ede
Increase camera baseTimeout to 30 seconds
see https://github.com/bigbluebutton/bigbluebutton/issues/11099#issuecomment-753985300
2021-01-08 04:56:20 +01:00
Anton Georgiev
d9629113cb fix undefined css class button in video-button 2021-01-06 19:13:48 +00:00
Anton Georgiev
24e2fe967b temporarily allow undefined user name for offline chat sender 2021-01-06 19:12:35 +00:00
Anton Georgiev
2dabeaae29 remove duplicated html id video-modal-input 2021-01-06 16:53:22 +00:00
Anton Georgiev
3e3f3236cc correct path to silence.mp3 2021-01-06 15:55:01 +00:00
Anton Georgiev
eb8e412935 ensure sorting has a fallback in case of undefined name 2021-01-06 15:21:44 +00:00
Anton Georgiev
f734071cb8 update axios to 0.21.1 to resolve vuln 2021-01-05 16:16:36 +00:00
Anton Georgiev
3135c6bb22 Handle guestWait url for multiple nodejs instanceIds 2021-01-05 15:38:21 +00:00
Fred Dixon
9e7bd44c9b
Merge pull request #10604 from hiroshisuga/patch-8
Fix slide size problem at fullscreen <-> window-mode transition
2020-12-30 08:08:38 -04:00
Fred Dixon
278a010ae3
Merge pull request #11074 from hiroshisuga/patch-10
Suppress warning of React file player
2020-12-28 22:38:11 -04:00
Fred Dixon
9b973c331f
Merge pull request #11077 from hiroshisuga/bug-shortcutwindow
Adding ID to debug window shortcut translation
2020-12-28 22:37:30 -04:00