Commit Graph

484 Commits

Author SHA1 Message Date
Mario Jr
97c76900cb Add setting for enabling/disabling microphone audio filters
As explained in #11143, disabling audio filters is desired in some scenarios.
This basically adds an option for user to disable default constraints.
When user doesn't change this value in Settings > Application, the default
value for each audio constraints is retrieved from settings.yml.
When user changes this value in Settings > Application, audio
filters (AGC, Noise Supression and Echo Cancellation) are all set to
true/false, according to the value selected in the Settings GUI.

To start it simple, we decided to not to add a different setting in the GUI for
each audio contraint. This may be added in the future, though (perhaps in a
dedicated Audio Settings tab)
This is related to #4873
2021-01-22 16:30:42 -03:00
Anton Georgiev
f34826718d include instanceId in resources url 2020-11-30 16:09:35 +00:00
Anton Georgiev
3faabd1821 Merge 2.2.29 and 2.2.30 into 2.3.x 2020-11-24 15:13:09 +00:00
Mario Jr
1b1a055d37 Fix audio modal buttons (MIC/LISTEN) not working after audio error
When user joins audio and for some reason an error (such as 1001, 1002,...), happens, the user is not able to click "Mic" and "Listen Only Buttons"; except if the audio window is closed and oppened again.
2020-11-17 15:31:42 -03:00
Anton Georgiev
ce8c733ec4 move the check to disable mutedAlert feature; temp disable it 2020-10-26 21:07:15 +00:00
Anton Georgiev
0c7ead1916 Merge branch 'v2.2.x-release' of github.com:bigbluebutton/bigbluebutton into oct16-merge 2020-10-21 14:48:02 +00:00
Mario Jr
df67d2e680 Better handling audio reconnection
When getting disconnected with 1001 ("websocket closed unexpectedly" error) we were creating a new SIP session, therefore a new FreeSWITCH channel.
While reconnecting the socket, instead of closing the SIP session, we keep it alive during reconnection (audio should keep working in the meantime). When reconnected we keep using this same session (avoiding the creation of an extra one).
We also better handle WebSocket error codes from SIP.js.
FF immediately closes websocket when unloading page, so we now to stop user agent when 'beforeunload' event is triggered, to avoid leaving open sessions in FreeSWITCH when user leaves page.
2020-10-15 11:24:23 -03:00
Mario Jr
e9e436378a Correctly set audio input/output devices
When refusing ("thumbs down" button) echo test, user is able to select a different input device. This should work fine for chrome, firefox and safari (once user grants permission when asked by html5client).
For output devices, we depend on setSinkId function, which is enabled by default on current chrome release (2020) but not in Firefox (user needs to enable "setSinkId in about:config page). This implementation is listed as (?) in MDN.
In other words, output device selection should work out of the box for chrome, only.
When selecting an outputDevice, all alert sounds (hangup, screenshare , polling, etc) also goes to the same output device.
This solves #10592
2020-10-06 20:37:55 -03:00
Mario Jr
619ffa0ec1 Port SIP.js to 0.17.1 release
This considerably changes the way we process audio signaling and start audio elements in user's browser.
We now avoid using AudioContext element for both microphone and listenonly calls, once it is unstable for some iOS devices (cracky audio, user stops hearing audio after a while).
Increased default value for listenOnlyCallTimeout: this avoids activating FreeSWITCH's fallback when ICE negotiation takes longer than 15sec (tested on DO).
Increased listenonly logs.
This fixes #8133 #10388
2020-09-25 20:26:22 -03:00
Anton Georgiev
d8b185f2b3 Merge branch 'issue-9219' of github.com:Tainan404/bigbluebutton into locales-total 2020-09-09 19:29:18 +00:00
KDSBrowne
77b71a4d1f fix duplicate css variables being loaded (improve imports) 2020-09-01 18:46:13 +00:00
Tainan Felipe
dda7182757 Merge remote-tracking branch 'upstream/develop' into skip-audio-check 2020-08-19 10:24:17 -03:00
Tainan Felipe
cb53b42c0e Merge remote-tracking branch 'upstream/develop' into issue-9723 2020-08-10 16:52:58 -03:00
Tainan Felipe
cc9662b6b8 Implement speaker change and add device update feature 2020-08-10 16:43:49 -03:00
Tainan Felipe
e64c0e1c62
Merge branch 'develop' into issue-9219 2020-07-28 13:28:32 -03:00
Tainan Felipe
0ba6ff5cf6 Merge remote-tracking branch 'upstream/develop' into issue-9723 2020-07-27 17:02:44 -03:00
Tainan Felipe
2c61d5ee75 Add input/output dynamic audio change 2020-07-27 16:49:26 -03:00
KDSBrowne
0877604d00 improve notification position / prevent state update on unmounted component 2020-06-23 13:38:59 +00:00
KDSBrowne
d3284bb748 remove extra gUM call / pass stream from audio manager 2020-06-16 15:03:45 +00:00
KDSBrowne
061e522493 add notification when speaking while muted 2020-06-16 13:41:51 +00:00
Tainan Felipe
aa668e3f91 Merge remote-tracking branch 'upstream/develop' into issue-9219 2020-05-25 17:05:58 -03:00
Tainan Felipe
db8e7fcd39 Update react-intl and add fallback to unsupported languages 2020-05-25 17:00:13 -03:00
Anton Georgiev
c9e996de21 Merge branch 'v2.2.x-release' of github.com:bigbluebutton/bigbluebutton into merge-2.2-into-develop 2020-05-25 17:32:24 +00:00
KDSBrowne
51c3543826 fix shortcuts not working when helper is passed an array 2020-05-21 18:43:34 +00:00
Ahmed Omar
e77cfe3755
Apply autoShareWebCam on return from breakout room 2020-05-01 18:09:29 +02:00
Tainan Felipe
9dd38ef8f1 Fix lost output audio when change client language 2020-03-03 14:22:26 -03:00
Tainan Felipe
8f1000437a Clean up the code 2020-03-03 10:59:01 -03:00
Tainan Felipe
c451666d52 WIP Implements skip to audio check in breakout rooms 2020-03-02 17:49:15 -03:00
Anton Georgiev
3754d0ab6f Merge branch 'v2.2.x-release' of github.com:bigbluebutton/bigbluebutton into merge-2.2-into-master-feb-28-2020 2020-02-28 17:47:06 -05:00
Anton Georgiev
1fa426058f corrected issues related to publishing and methods 2020-02-13 14:19:29 -05:00
Tainan Felipe
10969f2601 Add debounce to mute/unmute button 2020-02-06 17:20:42 -03:00
Chad Pilkey
e2eabfb44f attempt to stop accidental audio join double clicks 2019-11-22 13:55:26 -08:00
Anton Georgiev
42d640f3e2 Merge branch 'issue7791-add-support-to-new-parameters-name' of github.com:diegobenetti/bigbluebutton into test-7805 2019-11-05 11:59:00 -05:00
Chad Pilkey
6cccfb2ada
Merge pull request #8168 from KDSBrowne/issue-8112
Extend help text shown when getUserMedia with microphone fails
2019-10-24 12:28:53 -04:00
KDSBrowne
c548332b94 improve audio modal help content spacing 2019-10-22 19:32:04 +00:00
KDSBrowne
4fd06509e4 fix chrome on ios error being displayed incorrectly 2019-10-01 14:28:06 +00:00
KDSBrowne
89853dc026 move microphone error codes to const 2019-09-30 14:54:34 +00:00
KDSBrowne
636f49cd5d add error messages for getUserMedia failing with mic 2019-09-27 13:52:29 +00:00
KDSBrowne
830fb4252d remove unused css variables 2019-09-19 13:43:53 +00:00
KDSBrowne
8593b8607c center permission hint on safari 2019-09-18 18:02:29 +00:00
KDSBrowne
e7b53d34eb fix position of audio permission modal in RTL (chrome / firefox) 2019-09-17 15:07:31 +00:00
KDSBrowne
3d74e3c5c9 update arrow char so it works with ios and others 2019-09-10 14:20:37 +00:00
Anton Georgiev
4a335a1db6 reduce db probes for getAvailableActions; simplify SaveUsernames 2019-09-06 16:28:02 -04:00
Chad Pilkey
304bb2c103
Merge pull request #8030 from antobinary/chat-ids-2
Reduced client load via slight refactor
2019-09-05 13:23:37 -04:00
Anton Georgiev
c5856d43c8 moved static code outside of tracker 2019-09-04 14:32:58 -04:00
Anton Georgiev
2cbe91e222
Merge pull request #7996 from KDSBrowne/issue-7994
Fix join by phone icon placement in RTL
2019-08-30 09:43:31 -04:00
Anton Georgiev
ea18b09311 add a few more collection lookups "fields" delimiters 2019-08-29 12:26:07 -04:00
KDSBrowne
3e38a4f7d2 move arrow position 2019-08-29 14:26:51 +00:00
Anton Georgiev
b71dba2299
Merge pull request #7955 from KDSBrowne/001-fix-audio-logs
Fix mute audio log
2019-08-29 09:59:49 -04:00
Anton Georgiev
892336632f added "fields:{...}", removed most mapUser 2019-08-28 16:32:55 -04:00
KDSBrowne
a209449891 fix Join by phone icon placement RTL 2019-08-26 20:47:54 +00:00
Joao Siebel
7603c78740 Allow autoShareWebcam even when autoJoin is disabled
close #7902
2019-08-22 17:08:24 -03:00
KDSBrowne
17f9dfabd2 fix mute log 2019-08-20 00:26:05 +00:00
prlanzarin
982ab3631d Update play audio prompt on autoplay modal view 2019-08-14 19:15:11 +00:00
prlanzarin
9942dd0aa2 Merge remote-tracking branch 'upstream/master' into 2.2-ap-ui 2019-08-02 21:36:44 +00:00
prlanzarin
8d65ce565d Add UI prompts when autoplay is blocked for video/screenshare/listen only 2019-08-02 21:32:42 +00:00
Diego Benetti
c4462c4cb0 Fixes errors and improves parameters setting proccess 2019-08-02 15:38:38 -03:00
Anton Georgiev
e22d61b2e1 removed .log() function in favour of logger 2019-08-01 12:47:45 -04:00
Diego Benetti
3458458cfd Fixes proptypes errors 2019-07-26 15:44:56 -03:00
Diego Benetti
016088ec82 Fixes proptype error 2019-07-26 15:06:12 -03:00
Diego Benetti
3090950957 Fixes proptype error 2019-07-26 14:55:40 -03:00
KDSBrowne
624cc306d1 change prop name in audio controls container 2019-07-26 14:46:30 +00:00
KDSBrowne
bc0202d540 Merge branch 'issue-7794' of https://github.com/KDSBrowne/bigbluebutton into issue-7794 2019-07-26 14:38:59 +00:00
KDSBrowne
d8b2da7475 add suggested changes 2019-07-26 14:35:20 +00:00
KDSBrowne
65e58f2426 remove name duplication 2019-07-26 14:06:10 +00:00
KDSBrowne
4fba9978d3 add audio logs (join/leave/mute/unmute) / fix lint issues 2019-07-25 18:41:24 +00:00
Diego Benetti
f13239674b Changes other parameters to the new pattern 2019-07-24 14:04:46 -03:00
Diego Benetti
4a764f8f6c Implements new name for parameters and the support to the old names 2019-07-22 11:28:13 -03:00
KDSBrowne
ff71b15280 remove isRequired from resolve prop in audio modal 2019-07-19 14:45:04 +00:00
Anton Georgiev
7b06c6784e
Merge pull request #7765 from MaximKhlobystov/mute-unmute-tip
Tip that explains how to mute/unmute yourself using a phone
2019-07-11 15:39:03 -04:00
Maxim Khlobystov
96094be4a3 Get rid of the whitespace literal 2019-07-11 15:36:30 -04:00
Maxim Khlobystov
05609e1ded Cleanup 2019-07-11 15:22:44 -04:00
Maxim Khlobystov
6f30657e34 Add the tip message that explains how to mute/unmute using a phone 2019-07-11 15:00:46 -04:00
Chad Pilkey
c71de81b03 fix audio input selector 2019-07-06 22:04:05 +00:00
Anton Georgiev
f96ae6033a
Merge pull request #7692 from KDSBrowne/issue-7137
Fix blue screen after selecting share webcam (Chrome iOS)
2019-07-04 16:18:16 -04:00
Anton Georgiev
f095f04fd3
Merge pull request #7702 from capilkey/fix-user-roles
Clean up user roles
2019-07-04 14:57:19 -04:00
KDSBrowne
392aac9857 Merge branch 'master' of https://github.com/bigbluebutton/bigbluebutton into issue-7137 2019-07-04 18:37:40 +00:00
Joao Siebel
18670fdaf2 Merge remote-tracking branch 'upstream/master' into reconnection-improvement 2019-07-04 15:09:06 -03:00
Anton Georgiev
3fcb95ab44 log structure {logCode, extraInfo}, comment 2019-06-28 21:45:50 +00:00
Chad Pilkey
f0930e2d23 refactor user role management to follow proper format 2019-06-28 21:02:12 +00:00
KDSBrowne
dbf8938d24 fix chrome on ios blue screen after selecting share webcam / lint issues 2019-06-27 16:02:42 +00:00
Joao Siebel
512ceaa8e0 Merge remote-tracking branch 'upstream/master' into reconnection-improvement 2019-06-21 15:03:37 -03:00
Fred Dixon
2c617fed7b
Merge pull request #7610 from capilkey/ipv4-audio-fallback
IPv4 FS audio fallback, auto-reconnect, and fixed input select
2019-06-12 19:41:15 -04:00
Chad Pilkey
cc7513279e IPv4 FS audio fallback, auto-reconnect, and fixed input select 2019-06-12 21:01:20 +00:00
Joao Siebel
c6c8ca400b Merge remote-tracking branch 'upstream/master' into reconnection-improvement 2019-06-12 15:56:14 -03:00
Anton Georgiev
96e9f57d84
Merge pull request #7497 from Tainan404/issue-7343
Add context to manage locksettings
2019-06-11 15:45:15 -04:00
Tainan Felipe
747afb3093 Fix misscomparation 2019-06-11 15:04:47 -03:00
Joao Siebel
e924ea08cc Merge remote-tracking branch 'upstream/master' into reconnection-improvement 2019-06-05 17:22:30 -03:00
Anton Georgiev
b67908ce79 pass callback for closing of permissions-overlay 2019-06-04 17:43:58 +00:00
Joao Siebel
6c9e0def4b exit from audio when not connected and disable button 2019-06-03 11:28:05 -03:00
Tainan Felipe
6a4103c559 Add context to manage locksettings 2019-05-23 13:47:56 -03:00
Anton Georgiev
88cfd6bde8
Merge pull request #7277 from Tainan404/issue-7200
Stop webcams when opens audio modal.
2019-05-22 11:36:53 -04:00
Ghazi Triki
76371b9b6e Merge remote-tracking branch 'bigbluebutton/master' into html5-rtl 2019-05-16 17:32:58 +01:00
Anton Georgiev
54bf7f9d41 set the audio permissions overlay text color to black 2019-05-14 14:30:06 +00:00
Ghazi Triki
1f6326f7fd Change layout direction for RTL languages.
Update styles for RTL layout.
2019-05-14 14:17:19 +01:00
Anton Georgiev
9880ca85b8
Merge pull request #7382 from KDSBrowne/_summit-move-modal-warnings-to-top
Move warnings to top of modals
2019-05-13 16:24:18 -04:00
KDSBrowne
3378524fd3 add htmlfor to labels in cam modal / move warnings to top of modals 2019-05-08 15:22:27 +00:00
KDSBrowne
12669c323e add formatted labels 2019-05-08 13:16:00 +00:00
KDSBrowne
fb13d5ae7e add title to lock viewers modal 2019-05-08 12:47:55 +00:00
Tainan Felipe
1fbad0de31 Invert modal calls 2019-05-07 16:49:32 -03:00
Anton Georgiev
128e0b9cec
Merge branch 'master' into 2.2-High-contrast-outline 2019-05-06 15:55:59 -04:00
Pedro Beschorner Marin
a0590c12ea Merge remote-tracking branch 'origin/master' into set-lock-settings-on-meeting-create 2019-05-02 11:05:34 -03:00
Anton Georgiev
785c1b1d0b
Merge pull request #7016 from KDSBrowne/2.2-Edge-audio-settings-modal-overflow
Fix Edge audio settings modal overflow / toast issues
2019-04-24 18:23:16 -04:00
Tainan Felipe
006c1d293d just close video on first time that audio modal is opened 2019-04-18 17:29:06 -03:00
Tainan Felipe
0a730bcf62 Stop webcams when open audio modal 2019-04-18 15:48:39 -03:00
KDSBrowne
0e724fb890 Merge branch 'master' of https://github.com/bigbluebutton/bigbluebutton into 2.2-High-contrast-outline 2019-04-18 14:29:17 +00:00
Anton Georgiev
4e902ff22e
Add another default dial in number to be ignored 2019-04-17 16:36:15 -04:00
Anton Georgiev
6d76e61e58
Merge pull request #7230 from BobakOftadeh/dial-option
Implement option for audio dial in audio modal
2019-04-16 13:43:22 -04:00
bobakoftadeh
9d11c0ad1f update invalidDialNumbers 2019-04-16 17:34:12 +00:00
bobakoftadeh
fcf7bc0a73 update audio-dial modal format 2019-04-16 17:08:01 +00:00
bobakoftadeh
2d526a0d4a update audio-dial implementation 2019-04-15 16:39:36 +00:00
Pedro Beschorner Marin
87435c515c Merge remote-tracking branch 'master' into set-lock-settings-on-meeting-create 2019-04-12 13:58:58 -03:00
KDSBrowne
83127bcdae fix animations not working on iOS 12.3 beta 2019-04-11 15:04:10 +00:00
bobakoftadeh
465c265d75 Implemented option for audioDial in audio modal 2019-04-10 20:51:06 +00:00
KDSBrowne
ce98eeee77 fix remaining outline issues 2019-04-10 14:59:25 +00:00
Pedro Beschorner Marin
3f2cb781d7 Adjusted lockSettingsProps for the HTML5 client 2019-04-10 13:04:27 +00:00
Anton Georgiev
d9dfc9b999
Adjust path to audioSample.mp3
Closes #7207
2019-04-09 13:57:25 -04:00
Chad Pilkey
687d3dbc7e
Merge pull request #7075 from BobakOftadeh/permission-overlay-improve
Improved permissions-overlay
2019-04-01 17:01:49 -04:00
Chad Pilkey
b75e579acf
Merge pull request #7062 from riadvice/html5-files-cdn
Support loading the HTML5 main JS file and its assets from a CDN
2019-03-29 16:38:01 -04:00
Ghazi Triki
5b87524520 Use the embedded meteor CDN feature. 2019-03-29 16:47:07 +01:00
KDSBrowne
3d5a15acd6 Merge branch 'master' of https://github.com/bigbluebutton/bigbluebutton into 2.2-Edge-audio-settings-modal-overflow 2019-03-28 23:49:17 +00:00
Chad Pilkey
d12707b14d add modal warnings for edge users 2019-03-28 15:18:22 -07:00
Chad Pilkey
606ecc3dc5 moved the translation of the audio modal headers 2019-03-25 15:43:25 -07:00
bobakoftadeh
f36cb36dfa Improve position of permission-overlay for Safari 2019-03-25 16:44:55 +00:00
Chad Pilkey
d1851708f2 eslint correction in audio-controls 2019-03-21 15:43:11 -07:00
Chad Pilkey
237f37f874 Merge remote-tracking branch 'upstream/master' into clean-up-action-bar-buttons 2019-03-21 15:36:58 -07:00
Chad Pilkey
c224040e9b more cleanup of the buttons and listen-only action bar icon 2019-03-21 15:16:56 -07:00
bobakoftadeh
cb6757864c Improved permissions-overlay 2019-03-19 20:59:12 +00:00
Chad Pilkey
d3656ef022 clean up of the buttons. simplified and reduced 2019-03-19 10:11:48 -07:00
Ghazi Triki
e3d36b4bc6 Fix audio test path using a CDN. 2019-03-18 14:21:57 +01:00
Ghazi Triki
106058e1dd Support loading the HTML5 main JS file and its assets from a CDN. 2019-03-18 09:57:43 +01:00
Anton Georgiev
f695078d29
Merge pull request #6988 from Tainan404/issue-6941
Hide mute button when moderator join via audio in breakout room.
2019-03-14 11:56:47 -04:00
Tainan Felipe
46d13fde0f Mute locked users not remove from audio 2019-03-12 18:33:03 -03:00
Tainan Felipe
290804b3a1 Remove unused imports 2019-03-12 15:32:01 -03:00
Tainan Felipe
4dd93b12d8 Revert changes and implement clean verification 2019-03-12 15:28:41 -03:00
KDSBrowne
e63f056821 remove scrollbar from audio modal settings 2019-03-12 04:14:31 +00:00
Tainan Felipe
aa2664d9dd Hide mute button when moderator join via audio in breakout room 2019-03-11 18:09:07 -03:00
KDSBrowne
761c11581b Merge branch 'master' of https://github.com/bigbluebutton/bigbluebutton into 2.2-Edge-support-01 2019-03-05 02:52:49 +00:00
KDSBrowne
de660a0abe make remaining animations work with Edge 2019-03-05 02:46:37 +00:00
Anton Georgiev
16c5852174
Merge pull request #6875 from Tainan404/issue-6861
Mute shared video when echo test is open.
2019-03-04 16:04:43 -05:00
Anton Georgiev
012a25e893
Merge pull request #6832 from KDSBrowne/2.2-Edge-talking-anim
Improve talking indicators in edge
2019-03-04 15:58:22 -05:00
KDSBrowne
a2c57796bd fix animations / some whiteboard toolbar icons not rendering 2019-02-28 15:11:36 +00:00
Tainan Felipe
2662df51dd Mute shared video when echo test is open 2019-02-27 16:59:45 -03:00
KDSBrowne
b65939a298 improve talking indicators not visible in edge 2019-02-23 23:11:06 +00:00
Chad Pilkey
89b8189087 html5 sipjs bridge has useful errors now 2019-02-20 13:58:37 -08:00
Gustavo Trott
eedbe93906 Show 'Default' in Speaker list when browser is Safari 2019-02-06 09:48:01 -02:00
Anton Georgiev
42ce30416b
Merge pull request #6634 from vitormateusalmeida/issue-5846
Implement enable/disable Animations
2019-02-05 09:49:36 -05:00
Anton Georgiev
cd531f91ff
Merge pull request #6702 from MaximKhlobystov/html5-logs
Improve logging
2019-02-01 16:03:23 -05:00
Maxim Khlobystov
b86a990612 Add logCode and build number to log messages 2019-02-01 14:12:06 -05:00
Gustavo Trott
fe99ea889a Hide Mic and Camera buttons if userAgent contains bbbnative 2019-01-31 15:17:03 -02:00