Commit Graph

810 Commits

Author SHA1 Message Date
prlanzarin
10a6a840b5 fix(bbb-html5): crash on video-provider unmount
There's a race condition that may cause a client crash whenever a
video-provider's unmount procedure is run, but its signalling websocket
is undefined. The WS's callback handlers are re-assigned without
checking for the socket's availability, causing an unhandled TypeError.

The WS may be undefined in a couple of scenarios, e.g.: unmouting before
the socket was successfully set up, unmounting while a reconnect is in
place etc.

Check whether the socket exists before accessing it in video-provider's
componentWillUnmount routine.
2024-04-12 14:33:35 -03:00
Anton Georgiev
221327e4c5
Update bigbluebutton-html5/imports/ui/components/video-provider/video-list/video-list-item/user-actions/component.jsx
Co-authored-by: Ramón Souza <contato@ramonsouza.com>
2023-11-02 16:06:41 -04:00
Anton Georgiev
17427fbd9b refactor: Add a toast warning you that your webcam is still streaming (self view disabled) 2023-11-02 14:07:30 -04:00
Ramón Souza
fde37f08c9 fix video dropdown in rtl 2023-09-28 14:02:32 -03:00
Ramón Souza
48aa8df5a3 fix self-view label 2023-08-24 15:41:06 -03:00
Ramón Souza
eac3cc84ab display username in grid mode 2023-08-16 16:54:43 -03:00
Anton Georgiev
8cc8bfab00
Merge pull request #18387 from ramonlsouza/issue-18125
feat(bbb-html5): Grid mode pagination
2023-08-16 09:36:50 -04:00
Ramón Souza
5bf6d0489a fix empty grid users object when pagination is disabled 2023-08-14 09:52:52 -03:00
Ramón Souza
c5872e9cd3 rename grid page sizes -> grid sizes 2023-08-14 09:46:05 -03:00
Ramón Souza
0b8c493381 return gridUsers when pagination is disabled 2023-08-14 09:30:53 -03:00
Paulo Lanzarin
f3bd84e81f
refator(video): guarantee connectStreams scope is valid
The original debounce implementation (lodash) preserved the
caller's context - radash didn't, so it was failing and it wasn't noticed.

The new debounce implementation with the native function seems to preserve caller's context, but as a safety measure this commit binds the method to its appropriate scope.
2023-08-11 10:57:39 -03:00
Ramón Souza
835bbd4733 replace unaffected debounce 2023-08-09 13:26:42 -03:00
Ramón Souza
07ce5befec limit cameras page in grid mode 2023-08-08 13:05:54 -03:00
imdt
205d1d5f35 Fix: disabled self cam tied to specific cam or all 2023-08-02 17:59:19 -03:00
Ramón Souza
22605b3fbb grid mode pagination 2023-07-26 09:18:23 -03:00
Scroody
86f4e372f8 Fix: Warnings when creating a new meeting 2023-07-19 13:22:50 -03:00
Scroody
abdf85b508 Bug solving 2023-07-11 16:50:24 -03:00
Scroody
4faca42e37 Requested changes 2023-07-05 15:38:52 -03:00
Scroody
700edd19b4 Overlay over avatar 2023-07-04 10:44:24 -03:00
Ramón Souza
fc79c5b891 remove duplicated muted indicator from grid mode 2023-06-27 17:00:45 -03:00
Ramón Souza
3bac90a40c fix lint errors 2023-06-19 15:39:04 -03:00
Ramón Souza
9d3242037f sort grid mode items 2023-06-19 10:03:25 -03:00
Anton Georgiev
748c7a4a0b Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into june227 2023-06-02 09:45:34 -04:00
Ramón Souza
46849eae84 change webcam placeholder border color 2023-06-02 10:06:41 -03:00
prlanzarin
854f1e6e1b fix(video): drag-and-drop virtual background isnt applied
Drag-and-drop based virtual BG activation isn`t working since we refactored the logic to determine whether a peer is attached or not
2023-05-31 11:51:06 -03:00
prlanzarin
bf482fa373 refactor(video): remove stale iOSWarning locale declaration 2023-05-31 11:17:03 -03:00
Ramón Souza
0756d030a5
Merge pull request #17968 from Scroody/I-16114
Fix: Self cam coming back after trying to add effects or settings
2023-05-31 11:06:24 -03:00
prlanzarin
f34f8e5a9c fix(video): autoplay handling fails due to wrong mediaElement reference 2023-05-31 10:33:39 -03:00
André Castro
f2c4d55c2d
Update component.jsx 2023-05-29 15:02:29 -03:00
Anton Georgiev
20d124722a
Merge pull request #17962 from ramonlsouza/change-self-cam-label
refactor: Change enable/disable self cam label based on state
2023-05-29 09:49:52 -04:00
André Castro
51b0549e59
Update component.jsx 2023-05-26 10:19:29 -03:00
Ramón Souza
1540a9a7ec
Merge branch 'v2.7.x-release' into I-16114 2023-05-25 16:38:15 -03:00
Scroody
6e6fbe11be Fix: Self cam caoming back after trying to add effects or settings 2023-05-22 16:54:41 -03:00
Ramón Souza
810a9895f8 change enable/disable self cam label based on state 2023-05-22 09:06:39 -03:00
Ramón Souza
0040ee7028 do not display self view disabled message if camera is not being shared 2023-05-19 09:44:08 -03:00
Ramón Souza
18720e1536 Merge remote-tracking branch 'upstream/v2.7.x-release' into issue-13844 2023-05-17 15:44:39 -03:00
Ramón Souza
c64cf5ccbd
Merge pull request #17935 from Scroody/I-16114
feat: Disable self-view of webcam
2023-05-17 14:49:40 -03:00
Scroody
0fa1b9b3eb More requested changes made 2023-05-17 13:54:54 -03:00
Scroody
4a6d1258ae Requested changes made and fix of deactivating mutiple cams 2023-05-17 11:30:06 -03:00
Scroody
99885c20ed Final Adjust 2023-05-16 15:43:06 -03:00
Scroody
8272b487f3 Testing 2023-05-16 14:39:56 -03:00
Anton Georgiev
510c94cfa7 Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into may16-merge 2023-05-16 13:35:47 -04:00
prlanzarin
a693133b5a fix: remove legacy iOS UA checks that borked camera sharing in iPads
There are a couple of hardcoded UA checks targeted at iOS endpoints
introduced circa 2.2-beta. One of those pops up an "unsupported" toast
when the device joins a conference - the other blocks camera
sharing.

Those checks are outdated since we transitioned to minBrowserVersions
approach that redirects the client to an unsupported view upon join. I
also assume the checks are bugged since, in some environments, it flags
iPadOS endpoints as iOS and version-checks it to a hardcoded "12.2"
threshold (which is incompatible with iPadOS versioning). That caused
camera sharing not to work, which is a false negative.

I consider the checks to be outdated, so I removed all references to
them.
2023-05-15 13:22:52 -03:00
Anton Georgiev
4e851a7571 Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into merge-267-27 2023-05-15 11:51:17 -04:00
Ramón Souza
aca4179248 add isTalking animation 2023-05-12 11:17:04 -03:00
Ramón Souza
102063ca60 disable drop bg, pin and focus for grid items 2023-05-12 10:34:35 -03:00
Ramón Souza
1d27aaa35b fix grid on user leave 2023-05-12 09:03:54 -03:00
Anton Georgiev
1c9ba032a6
Merge pull request #17554 from AtilaU19/reconection-fixes
fix: overlapping screen end alerts and invisible cameras on reconnections
2023-05-11 17:15:12 -04:00
Ramón Souza
ffe8754733 add grid layout 2023-05-11 17:20:26 -03:00
KDSBrowne
1b51377147 fix getContentAnchorEl console error 2023-05-10 01:31:48 +00:00