Commit Graph

7250 Commits

Author SHA1 Message Date
Ramon Souza
984c3d515c fix chat messages timestamp 2021-03-01 14:21:54 -03:00
Anton Georgiev
0856599406
Merge pull request #11520 from mariogasparoni/fix-11511
Breakout room audio fixes
2021-03-01 11:42:33 -05:00
Ramon Souza
ba6e6c8238 remove unnecessary dependency 2021-03-01 09:07:06 -03:00
Mario Jr
de05622d19 Avoid setting an unknown input deviceId
Without 'exact' match, the browser fallbacks to the default inputDeviceId

This prevents the error (input device error)  when breakout is ended and we try
to skipCheck the microphone when user returns to main room (assuming the
user had the microphone active before joining breakout room). Related
to the feature c451666d52
2021-02-28 17:15:08 -03:00
Mario Jr
629b6c901c Do not join microphone when user is already in breakout
Fixes #11511
Related to the feature implemented in c451666d52
2021-02-28 17:13:10 -03:00
Mario Jr
fc1401ab53 Do not try to recover mute state when joining listenonly
Prevent toggleMute api call to be called for listenonly
This has no effect to the end user, but avoids unnecessary server calls
2021-02-26 15:52:11 -03:00
Mario Jr
ad23e9c0af Cleanup joinedAudioOnly state when user disconnects or reconnect microphone
Fixes #11490
2021-02-26 15:05:17 -03:00
Mohamed Amine Ben Salah
4dc679d000 Adds tests recording + updates some outdated tests + linting 2021-02-26 12:52:17 -03:00
Ramon Souza
cbb20b7375 resync breakout room timer 2021-02-26 11:09:44 -03:00
Pedro Beschorner Marin
d69ed72b54 Fixing eventName overriding 2021-02-26 01:03:05 +00:00
Pedro Beschorner Marin
540ce10c24 Recording external video events 2021-02-26 00:59:40 +00:00
Lucas Fialho Zawacki
ddc7a974bf Register external video playback events to Redis 2021-02-25 21:58:43 +00:00
Anton Georgiev
89057d64ce
Merge pull request #11505 from mariogasparoni/develop
Recover mute state for moderator when returning from breakout's audio transfer
2021-02-25 15:01:39 -05:00
Anton Georgiev
aff272cbf3 Merge #7484 into #11447 ExternalVideo recording events 2021-02-25 19:54:22 +00:00
Gustavo Trott
63e00bd7ca Adds lastAuthTokenValidatedOn to users in Akka, send it in ValidateAuthTokenRespMsg pubSub msg, makes Meteor store it as authTokenValidatedTime 2021-02-25 16:52:20 -03:00
Mario Jr
404d65d7a4 Recover mute state for moderator when returning from breakout's audio transfer
Fixes #11489
2021-02-25 15:38:41 -03:00
Ramon Souza
09fef2f139 fix for userlist menu on tablets 2021-02-25 14:18:12 -03:00
Anton Georgiev
23e65e6f40
Merge pull request #11500 from ramonlsouza/mobile-whiteboard-fix
Fix whiteboard use for iPad and other landscape mobile devices
2021-02-25 08:54:04 -05:00
Anton Georgiev
2948eca9e9
Merge pull request #11502 from ramonlsouza/connection-status-modal
Visual changes on connection status modal
2021-02-25 08:42:48 -05:00
Ramon Souza
319ab71826 stats help url check + text center on connection modal 2021-02-25 10:14:09 -03:00
Ramon Souza
65ca979e7e fix whiteboard use for ipad and other landscape mobile devices 2021-02-25 08:15:20 -03:00
Joao Siebel
31d49536e8 Add extra logs when handling messages on redis 2021-02-24 17:56:14 -03:00
Anton Georgiev
875f9c1ca9
Merge pull request #11477 from KDSBrowne/bbb-10774
Fix whiteboard text-area not allowing input on Firefox
2021-02-24 10:20:36 -05:00
Ramon Souza
ea59f59376 fix many re-renders 2021-02-24 12:06:49 -03:00
Anton Georgiev
e0db693ffd
Merge pull request #11483 from ramonlsouza/issue-11445
Add break-word to system messages
2021-02-24 10:03:48 -05:00
Anton Georgiev
6472ff8533
Merge pull request #11480 from ramonlsouza/issue-11475
Fix moderator welcome message closing border
2021-02-24 08:56:21 -05:00
Ramon Souza
b66a7e20fd add break-word on system messages 2021-02-24 10:33:47 -03:00
Ramon Souza
bf914dd7ff fix moderator message closing border 2021-02-24 09:07:27 -03:00
KDSBrowne
d2c36c1c94 update handleClick condition (fix text-area for FireFox) 2021-02-24 02:05:23 +00:00
Mario Jr
19c1626c39 Do not return empty array when groupChats is empty
Instead, return empty array when both users and groupChats arrays are empty.
The public chat and user chats may be active when groupChats array is empty.
Fixes #11476
2021-02-23 17:52:19 -03:00
Anton Georgiev
416eb512e1
Merge pull request #11426 from Tainan404/fix-nav-bar-notification
Fix nav-bar unread message indicator
2021-02-23 13:53:16 -05:00
Anton Georgiev
3c4212cdb2
Merge pull request #10613 from hiroshisuga/fsshortcuthelp
Shortcut help for toggle fullscreen
2021-02-23 12:45:48 -05:00
Anton Georgiev
91b09418f7
Merge pull request #11471 from ramonlsouza/pr-11408
Show polling button over the full-screened shared-screen
2021-02-23 12:41:10 -05:00
Ramon Souza
08067e905f polling component also checks if screenshare is fullscreen 2021-02-23 14:04:00 -03:00
Anton Georgiev
4b1ae5e63f
Merge pull request #11398 from hiroshisuga/patch-18
Enable arrow keys immediately after fullscreen
2021-02-23 10:35:15 -05:00
Anton Georgiev
bfd564233d
Merge pull request #11468 from mariogasparoni/fix-11029
Prevent ejecting user from them main room when leaving breakout room
2021-02-23 10:22:03 -05:00
Ramon Souza
76c4bb6c85 Merge remote-tracking branch 'upstream/develop' into pr-11408 2021-02-23 11:35:21 -03:00
Anton Georgiev
fc001a142c
Merge pull request #11443 from mariogasparoni/develop
Do not uncessarily fetch locales at first time you open/save settings menu
2021-02-23 09:31:24 -05:00
Anton Georgiev
777bf01e8b
Merge pull request #11451 from hiroshisuga/patch-23
Show modals overlaid on full-screen slide or shared screen
2021-02-23 09:18:50 -05:00
Mario Jr
2e92de8010 Clean up HTMLAudioElement used for notification sounds
After ending the notification playback, we set the ".src" property to null, which immediately stop the internal player of mobile browser (tested on Chrome for Android -  device list is on #11458).
For the specific list of devices, this prevents the internal buffer error "-61" described in #11458.
Fixes #11458.
2021-02-23 11:12:37 -03:00
Anton Georgiev
111109674e
Merge pull request #11247 from ramonlsouza/language-dropdown
Reduces the number of options displayed on locale settings dropdown
2021-02-22 15:44:29 -05:00
Anton Georgiev
dfa754af79
Merge pull request #11436 from AadityaPrakash/meteor-config
Implemented merge option for default and local settings.
2021-02-22 15:30:15 -05:00
Anton Georgiev
0eac03394c remove duplicated logging of pengingAuth 2021-02-22 19:48:14 +00:00
Ramon Souza
b01246f23f rework on echo test flow 2021-02-22 15:09:14 -03:00
Tainan Felipe
b298bf4384 WIP add timestamp greater than to publisher 2021-02-22 13:35:32 -03:00
Ramon Souza
11d924af70 fix bbb_skip_check_audio_on_first_join 2021-02-22 10:43:58 -03:00
hiroshisuga
f6b7ca779f
show modal over fullscreen 2021-02-22 18:30:33 +09:00
Anton Georgiev
740a3a9db9 stop external video if presenter changed 2021-02-21 12:19:01 +00:00
Anton Georgiev
0b6496618c Merge branch 'develop' of github.com:amguirado73/bigbluebutton into external-video-sync-lucas 2021-02-21 11:04:39 +00:00
KDSBrowne
e2156157f5 remove comment 2021-02-21 06:12:38 +00:00
Mario Jr
6508674d38 Prevent ejecting user from them main room when leaving breakout room
When user observing changes, we must guarantee these changes are from main room, and not from breakout one.
Fixes #11029
2021-02-21 01:07:25 -03:00
KDSBrowne
babaf1b578 Merge branch 'develop' of https://github.com/bigbluebutton/bigbluebutton into 2.3-per-user-wb 2021-02-21 00:04:36 +00:00
Mario Jr
d961dea594 Do not uncessarily fetch locales at first time you open/save settings menu
Locales would be fetched even if you simply open and save settings window (without changing any setting)
We now test it similarly we do on 2.2
Closes #11318
2021-02-20 11:47:46 -03:00
Anton Georgiev
3589ee5232
Merge pull request #11423 from ramonlsouza/fix-layout-params
Fix layout params (show participants + show public chat) not affecting the meeting
2021-02-19 11:51:55 -05:00
Anton Georgiev
100d089246
Merge pull request #11437 from ramonlsouza/new-poll-results
Fix user-sent poll result messages
2021-02-19 10:38:34 -05:00
Anton Georgiev
d3a33382fe
Propagate typo fix from #11432
Needed for https://github.com/bigbluebutton/bigbluebutton/pull/11432
2021-02-19 10:34:20 -05:00
Ramon Souza
043fa4bac8 fix user-sent poll result messages 2021-02-19 10:57:11 -03:00
Aaditya Prakash
c3a7fde807 Implemented merge option for default and local settings. 2021-02-19 14:44:23 +01:00
Anton Georgiev
35ea07b4cd
Merge pull request #11429 from antobinary/feb18-merge
Remove duplicate import of throttle
2021-02-18 15:54:29 -05:00
Anton Georgiev
58be3d42ef remove duplicate import of throttle 2021-02-18 20:52:23 +00:00
Anton Georgiev
d30f0dc710
Merge pull request #11428 from antobinary/feb18-merge
Merge 2.2 into 'develop'
2021-02-18 15:46:45 -05:00
Anton Georgiev
b3b905fd40
Merge pull request #11420 from Tainan404/develop+pr10919+pr10838
Fix user status in chat
2021-02-18 15:44:13 -05:00
Anton Georgiev
55e8de4357 Merge branch 'v2.2.x-release' of github.com:bigbluebutton/bigbluebutton into feb18-merge 2021-02-18 20:33:19 +00:00
Tainan Felipe
271736b30f Fix nav bar unread message indicator 2021-02-18 17:11:02 -03:00
Anton Georgiev
d686f0b04d
Merge pull request #11417 from KDSBrowne/bbb-11097
Skip publishing poll annotation to whiteboard if presentation swapped
2021-02-18 13:26:08 -05:00
Tainan Felipe
8825cd3789 remove uneeded log 2021-02-18 13:37:10 -03:00
Ramon Souza
3778ccb397 fix layout params not affecting the meeting 2021-02-18 13:11:02 -03:00
KDSBrowne
9aff7ea22b add yes / no / abstention poll btn 2021-02-18 16:06:21 +00:00
Anton Georgiev
e966d6c7b6
Merge pull request #11366 from MaximKhlobystov/updating-poll-ui
Updated poll UI: question field and typed responses
2021-02-18 10:32:33 -05:00
Anton Georgiev
49cdf9faef
Merge pull request #11413 from gustavotrott/develop
Include registeredOn date in pubSub user creation messages to replace loginTime creation in Meteor
2021-02-17 16:56:53 -05:00
Anton Georgiev
d16ee3067d
Merge pull request #11317 from antobinary/2.3-alpha5-with-split-meteor-roles-10349
Split Meteor roles backend-frontend revisit
2021-02-17 16:35:23 -05:00
Anton Georgiev
c6253b9953 Merge branch '2.3-alpha5-with-split-meteor-roles-10349' of github.com:antobinary/bigbluebutton into 2.3-alpha5-with-split-meteor-roles-10349 2021-02-17 20:52:33 +00:00
Anton Georgiev
683847304d on frontend attempt to handle events without matching queue 2021-02-17 20:51:36 +00:00
Tainan Felipe
c47b52cf71 Add user online status change 2021-02-17 17:43:41 -03:00
KDSBrowne
2f094f7048 skip publishing poll annotation to whiteboard if presentation swapped 2021-02-17 14:15:20 +00:00
Ramon Souza
1f2a653af1 fix 'data-test' values for chat messages 2021-02-17 11:03:28 -03:00
Gustavo Trott
573bfc107b Remove changes not related to issue 2021-02-17 09:39:36 -03:00
Gustavo Trott
91f4eba678 Replace registeredOn params to Long (timestamp) instead of String (ISO_OFFSET_DATE_TIME) 2021-02-17 09:20:55 -03:00
Anton Georgiev
45f6a0e69e
Merge branch 'develop' into 2.3-alpha5-with-split-meteor-roles-10349 2021-02-16 16:09:20 -05:00
Mohamed Amine Ben Salah
d8c5aa46d9
multiple automated tests suites updates + add missing polling specs and move them with old ones to a polling test suite (#10766)
* updating old tests + collecting more snapshots [WIP]

* updates old test suites and collects more visual regressions screenshots

* remove snapshots and their collection temporary

* run tests from packages.json

* update test execution command/export constants from .env to core/constants.js

* update tests/puppeteer/README.md file

* update LOOP_INTERVAL variable call and assign timeouts to the webcam share spec

* redefine waitForSelector func in page.js, update chat test suite specs and add poll chat message test spec

* Merge remote-tracking branch 'upstream/develop' into updating-old-tests-visual-with-visual-regressions

* update webcam test specs collecting videoPreviewTimeout and use it to wait for videoPreview selector

* update custom parameters test suite

* update breakout test suite

* update webcam layout test suite

* update multiusers test suite

* update notifications test suite

* update presentation test suite

* whiteboard test suite

* screenshare test suite

* update sharednotes test suite

* user ELEMENT_WAIT_TIME variable from timeouts constants.js

* list TEST CONSTANTS by category

* add poll test suite and assigns the right unassigned timeouts

* set test pages to headless
2021-02-16 15:57:10 -05:00
Anton Georgiev
b2c4244276 Merge branch 'develop' of github.com:bigbluebutton/bigbluebutton into 2.3-alpha5-with-split-meteor-roles-10349 2021-02-16 19:55:10 +00:00
Anton Georgiev
8933ca2de6
Merge pull request #11400 from KDSBrowne/bbb-10915
Fix user-list-item dropdowns breaking on mobile screen sizes
2021-02-16 14:51:22 -05:00
Anton Georgiev
3aa3591f12
Merge pull request #10291 from Tainan404/issue-8545
Store the changed and default settings in different variables
2021-02-16 14:49:53 -05:00
Gustavo Trott
12e363eb92 Removes loginTime creation from Meteor and use the registeredOn date created on Akka. Makes Akka send the registeredOn date throught PubSub messages: UserRegisteredRespMsg, GuestsWaitingForApprovalEvtMsg and ValidateAuthTokenRespMsg. 2021-02-16 14:46:30 -03:00
Anton Georgiev
1cedc56504 process only some of CreateMeeting logic in frontends to avoid meeting duplication 2021-02-16 15:12:25 +00:00
Anton Georgiev
f43560d535 Support for backend vs frontend nodejs instances bbb-html5 2021-02-16 03:19:31 +00:00
Ramon Souza
c88e4e3133 show uploaded slides from other users 2021-02-15 15:23:02 -03:00
hiroshisuga
91f6bc752a
show polling button in fullscreen mode 2021-02-15 17:54:02 +09:00
KDSBrowne
55d91f8616 fix user-list-item dropdowns breaking on mobile screen sizes 2021-02-13 19:06:45 +00:00
hiroshisuga
97d390cd0e
Update service.js 2021-02-13 10:20:45 +09:00
Anton Georgiev
1476deb268
Merge pull request #11173 from Tainan404/develop+pr10919+pr10838
Chat with adapter and context
2021-02-12 16:35:22 -05:00
Tainan Felipe
de24ec94c6 Fix user typing, message form alligment and private chat title 2021-02-12 17:54:44 -03:00
Tainan Felipe
29864e7955 improve performance of chat copy 2021-02-12 16:43:56 -03:00
Tainan Felipe
f2107a87f7 Fix copy/save public chat 2021-02-12 16:13:21 -03:00
Anton Georgiev
188c406e1b
Merge pull request #11389 from ramonlsouza/issue-11351
Fixes interruption of webcam, external video and screenshare when user changes language settings
2021-02-12 13:46:22 -05:00
Tainan Felipe
b99faecd67 Fix rtl on chat item 2021-02-12 15:07:05 -03:00
Tainan Felipe
133b561d4b Fix outline clipping on message form 2021-02-12 14:53:50 -03:00
Tainan Felipe
80be16a8ce Fix blank chat issue 2021-02-12 14:43:04 -03:00
Ramon Souza
1083fe810a no unmount on change locale 2021-02-12 13:55:39 -03:00
Tainan Felipe
b20c606e9c Add close chat feature 2021-02-12 11:07:53 -03:00
Mario Jr
b7216dd100 Preserve mutestatus when disconnecting/reconnecting microphone
After audio reconnection, a muted user would have it's microphone unmuted by default, unless muteOnStart is set to true. This fix this problem.
Fixes #9016
2021-02-11 23:55:34 -03:00
Anton Georgiev
39759c7a16
Merge pull request #11298 from ramonlsouza/issue-11270
Set safe default values for slide position (WIP)
2021-02-11 12:34:23 -05:00
Anton Georgiev
45aa7ff55a
Merge pull request #8697 from Tainan404/issue-8610-2
Fix lost output audio when change client language
2021-02-11 12:29:17 -05:00
Anton Georgiev
81f5302696
Merge pull request #11381 from ramonlsouza/PR-8696
Skip echo test in breakout room
2021-02-11 09:41:42 -05:00
Anton Georgiev
78b21c98ad
Merge pull request #11376 from KDSBrowne/bbb-11372
Make screen reader announce status changes in userlist
2021-02-11 09:02:17 -05:00
Ramon Souza
0034b1bccc resolve conflicts 2021-02-11 10:23:38 -03:00
Ramon Souza
46af7880d6 Merge remote-tracking branch 'upstream/develop' into PR-8696 2021-02-11 09:12:13 -03:00
KDSBrowne
eb5cd228b4 make screen reader announce status changes in userlist 2021-02-10 23:53:59 +00:00
Jacob Burroughs
1131ad1987 Fix rendering after public chat cleared
This bug was introduced in #11305, as the system-generated message notifying
the user that the chat history has been cleared does not have an id.

fixes #11349
2021-02-10 22:07:22 +00:00
Ramon Souza
672bd3f318 Merge branch 'PR-10217' into develop 2021-02-10 17:55:32 -03:00
Ramon Souza
3652562b63 resolve conflict 2021-02-10 17:35:55 -03:00
Pedro Beschorner Marin
09b39a8d63 Add extra pad validation
Associate pads with meetings so session validation is restricted to the
meeting's valid session tokens.

Meteor will dispatch new redis events on shared notes and closed captions
pads creation. This event will go through apps and reach web to populate
a new meeting's pad collection that contains all valid pad id's for that
session. Nginx will use this collection to check if the user's session token
belongs to the pad's authorized users.

Besides these modifications, an extra change will be needed at notes.nginx.
Location /pad/p/ needs to change it's auth_request:

from /bigbluebutton/connection/checkAuthorization;
to /bigbluebutton/connection/validatePad;
2021-02-10 13:37:04 -03:00
Anton Georgiev
35e631cff4
Merge pull request #11370 from ramonlsouza/issue-8367
Add delay to join video button
2021-02-10 09:00:08 -05:00
Ramon Souza
9738f42432 add debounce to join video button 2021-02-10 10:44:45 -03:00
Tainan Felipe
e2b68a3202 Fix missing file 2021-02-10 10:33:18 -03:00
Tainan Felipe
e05d8886c6 Handle clear chat and fix clear message 2021-02-10 10:14:30 -03:00
Anton Georgiev
eddc3f0e1e
Merge pull request #11364 from ramonlsouza/issue-11338
Fix webcam video dropdown collapse after expanding
2021-02-09 19:54:04 -05:00
Anton Georgiev
adefc6a20c
Merge pull request #11341 from ramonlsouza/breakout-invitation-settings
Add property to settings.yml to enable/disable breakout invitations to moderators
2021-02-09 15:50:24 -05:00
Anton Georgiev
f11c9e69d0
Merge pull request #11365 from ramonlsouza/issue-10035
Stop screenshare on joining breakout room
2021-02-09 15:41:20 -05:00
Ramon Souza
54f983f250 stop screenshare on joining breakout room 2021-02-09 17:22:39 -03:00
Ramon Souza
cde124f237 fix webcam video dropdown collapse 2021-02-09 16:12:33 -03:00
Anton Georgiev
fa89646188
Merge pull request #11363 from lfzawacki/insecure-video-urls
Don't validate insecure http urls for external video to prevent browser errors
2021-02-09 14:04:12 -05:00
Lucas Zawacki
7216619811 Don't validate insecure http urls for external video to prevent browser errors 2021-02-09 15:24:21 -03:00
Joao Siebel
0e79203119 Clear screenshare collection when meeting has ended while screensharing 2021-02-09 14:26:43 -03:00
Anton Georgiev
6c64545e67
Merge pull request #11357 from jfsiebel/2.3-clear-collections-on-meeting-end
[2.3] Clear missing collections on meeting end
2021-02-09 12:04:52 -05:00
Joao Siebel
7f4b2789f2 Clear screenshare collection when meeting has ended while screensharing 2021-02-09 13:44:49 -03:00
Pedro Beschorner Marin
c0a7f9cd92 Replace FNV32a pad's id generator with salted SHA1
When managing Etherpad's pads, Meteor makes API calls to initiate the closed captions
and shared notes modules. The pad id was being mapped to a shorter id than the meeting
id because of a Etherpad lenght limitation.

Changed to something less guessable.
2021-02-09 12:59:59 -03:00
Anton Georgiev
3d78045363 Clear meeting-time-remaining collection 2021-02-09 12:44:33 -03:00
Joao Siebel
811d6d3f98 Clear guestUsers, voiceCallStates and whiteboard-multi-user collections on meeting end 2021-02-09 12:44:10 -03:00
Anton Georgiev
74d34e1a10
Merge pull request #11319 from ramonlsouza/fullscreen-polling-buttons
Display polling buttons on fullscreen presentation
2021-02-09 09:50:35 -05:00
Anton Georgiev
6b3c97037f Clear meeting-time-remaining collection 2021-02-09 11:23:51 -03:00
Tainan Felipe
e99825f60a Merge remote-tracking branch 'upstream/develop' into develop+pr10919+pr10838 2021-02-09 10:40:39 -03:00
Ramon Souza
319a620d7e polling fullscreen now only checks if presentation is fullscreen 2021-02-09 10:15:29 -03:00
Tainan Felipe
99ebbf0b17 Remove unused props from proptype 2021-02-09 09:44:01 -03:00
Joao Siebel
2eb8abcba9 Clear guestUsers, voiceCallStates and whiteboard-multi-user collections on meeting end 2021-02-09 09:30:09 -03:00
Ramon Souza
5607ed4007 disable user typing notifications when feature is disabled 2021-02-09 09:06:48 -03:00
Maxim Khlobystov
7a703464de Small misprint introduced in the merge 2021-02-09 06:22:41 +00:00
Anton Georgiev
e2e0b78d40 Merge branch 'develop' of github.com:bigbluebutton/bigbluebutton into split-meteor-roles-on-top-of-2.3-alpha6 2021-02-08 23:39:42 +00:00
Maxim Khlobystov
ff4260dc98 Merge branch 'develop' of https://github.com/bigbluebutton/bigbluebutton into updating-poll-ui 2021-02-08 21:41:43 +00:00
Tainan Felipe
3e921ee93b Remove filter for messages before login time 2021-02-08 17:35:16 -03:00
Tainan Felipe
44bdfa6e5d Improve adapter to batch messages 2021-02-08 17:00:18 -03:00
Ramon Souza
a3780209f3 Add property to settings.yml to enable/disable breakout invitations to moderators 2021-02-08 14:40:03 -03:00
Tainan Felipe
2103b9331c Fix crash in private chat and unread counter in opened chats 2021-02-08 13:55:10 -03:00
Pedro Beschorner Marin
d7c0975b61 Fix mobile user-list identification
Added the missing extractCredential method and replaced the old callback strategy
with the new try-catch block.
2021-02-08 09:55:38 -03:00
Ramon Souza
463694aff9 moved fullscreen pollingContainer to PresentationArea + fix duplicated component in fullscreen 2021-02-08 08:50:47 -03:00
prlanzarin
03cd3af26c screenshare: change the reconnection UI style trigger to avoid false positives
Mainly: track unhealthy fatal states instead of supposedly healthy states

Avoids unwarranted UI reconnecting states or flickering on low end devices or struggling networks

Also added a version of isVideoBroadcasting for presenters which only accounts for the server state, so that we can deal with the presnter`s sharing state with more fidelity in the UI
2021-02-05 19:54:12 -03:00
prlanzarin
e0e22733dd video-provider,screenshare: consider a stream unhealthy only when the peer fails
Done to avoid false positives where the stream would transition to the unhealthy UI state (or flicker between states) due to disconnected also triggering it, which is not fatal. Disconnected has to be used alongside getStats heuristics, which I removed due to issues with it, so I´m hardening the transition to fatal states only
2021-02-05 19:54:05 -03:00
Anton Georgiev
363c801338
Merge pull request #11215 from pedrobmarin/guest-draft
Disable authenticated guests
2021-02-05 16:13:46 -05:00
Ramon Souza
ac87b6c401 correctly display polling buttons if presentation is fullscreen 2021-02-05 17:06:14 -03:00
Anton Georgiev
7343b23d37
Merge pull request #11272 from KDSBrowne/bbb-10733
Clone unmuted input stream for usage with hark
2021-02-05 13:44:02 -05:00
Anton Georgiev
8c0f0fdd52 Split Meteor roles backend-frontend revisit 2021-02-05 17:47:46 +00:00
Anton Georgiev
d9b7a76092
Merge pull request #11314 from KDSBrowne/bbb-11291
Fix icon in chat poll result not displaying
2021-02-05 12:41:24 -05:00
Anton Georgiev
330561c19b
Merge pull request #11312 from KDSBrowne/bbb-10002
Fix message list not updating when switching between private chats
2021-02-05 12:40:29 -05:00
Ramon Souza
78b61103da fix video preview blink when skip preview = true 2021-02-05 14:30:58 -03:00
KDSBrowne
852ea929a8 add default poll color for chat results 2021-02-05 16:29:58 +00:00
KDSBrowne
9307215a2d make chat list element key unique 2021-02-05 01:07:24 +00:00
Anton Georgiev
5a6f232989
Merge pull request #11285 from ramonlsouza/issue-10454
Changes on webcam skip preview behavior
2021-02-04 13:43:46 -05:00
KDSBrowne
0abdf00a25
Add new join param skip echo test on first join only (#11284)
* add param to force echo test when user joins audio after init

* fix UI stuck on connecting when userdata-bbb_auto_join_audio=false

* fix conditions for joinFullAudioImmediately and joinFullAudioEchoTest | remove old format

* remove extra param in getItem

* recover audioLocked | only set getEchoTest if doesnt exist
2021-02-04 13:42:31 -05:00
Ramon Souza
b1cb4435ee introduce userdata-bbb_skip_video_preview_on_first_join parameter 2021-02-04 15:05:48 -03:00
Anton Georgiev
b796a8beb7
Merge pull request #11280 from MaximKhlobystov/fix-user-random-select
Fix for random user picking: presenter is notified when there's no viewers to randomly pick from
2021-02-04 10:32:50 -05:00
Anton Georgiev
1c598d81c1
Merge pull request #11293 from PhMemmel/fixNotificationLabelTranslation
fixes non localized notifications label in settings
2021-02-04 10:24:02 -05:00
Anton Georgiev
d667174571
Merge pull request #11305 from Tainan404/fix-overlapping-messages
Fix overlapping messages
2021-02-04 10:19:58 -05:00
Tainan Felipe
2a57982e24 Fix overlapping messages 2021-02-04 11:02:19 -03:00
Ramon Souza
f649f67655 current user identification on breakout room creation 2021-02-04 10:59:13 -03:00
Maxim Khlobystov
89f968deab Better code readability for random-user component 2021-02-04 06:18:40 +00:00
Tainan Felipe
9cf483d18f Change message getter 2021-02-03 17:49:58 -03:00
Ramon Souza
06bd75dd9e make sure slidePosition is only used if it exists 2021-02-03 16:38:09 -03:00
Ramon Souza
49ee9821f8 possible fix for #11270 2021-02-03 13:49:14 -03:00
Ramon Souza
55651506a4 improve language selector filter, closes #10706 2021-02-02 15:44:58 -03:00
Tainan Felipe
a7534fa2e5 Fix missing lodash 2021-02-02 09:59:39 -03:00
Tainan Felipe
7b4f6e2231 Fix hit area of more message bellow and css recalc 2021-02-01 19:12:04 -03:00
Philipp Memmel
5049698d13 fixes non localized notifications label in settings 2021-02-01 15:57:43 +00:00
Maxim Khlobystov
9162f3b286 Make sure presenter is notified when there's no viewers to randomly pick from 2021-02-01 04:41:28 +00:00
KDSBrowne
d3fa32e111 clone unmuted input stream for usage with hark 2021-01-30 17:04:07 +00:00
Mario Jr
08732767e3 Removed duplicated audio filter option in Settings > Application 2021-01-29 19:23:38 -03:00
Mario Jr
b582b1ca78 Correctly return MediaStream object when calling audio-manager's inputStream
This was missed in recent audio/sip.js changes.
MediaStream is now returned from SIP.js
Related to #10733
2021-01-29 19:05:51 -03:00
Anton Georgiev
09e6ba8dfd Merge branch 'v2.2.x-release' of github.com:bigbluebutton/bigbluebutton into merge-Jan30 2021-01-29 20:58:05 +00:00
Joao Siebel
09f5931d65 Keep track of active connection id for users 2021-01-29 17:29:07 -03:00
Anton Georgiev
1564a7a9d9
Merge pull request #11264 from ramonlsouza/fix-typing-indicator-display
Fixes typing indicator display
2021-01-29 12:39:12 -05:00
Tainan Felipe
dd63051825 fix typing indicator display 2021-01-29 14:33:51 -03:00
Anton Georgiev
60cfeb6189
Merge pull request #11263 from ramonlsouza/fix-active-webcam-icon
Fixes active webcam icon
2021-01-29 12:28:39 -05:00
Anton Georgiev
d122639042
Merge pull request #11239 from jfsiebel/sync-with-active-connections
Synchronize users with active connections
2021-01-29 12:28:07 -05:00
Joao Siebel
68b2752e0d Add flag to enable sync 2021-01-29 14:27:13 -03:00
Ramon Souza
6c1856c0a4 fix active webcam icon 2021-01-29 14:23:50 -03:00
Mario Jr
f2de2806eb Add setting for enabling/disabling microphone audio filters
As explained in #11143, disabling audio filters is desired in some scenarios.
This basically adds an option for user to disable default constraints.
When user doesn't change this value in Settings > Application, the default
value for each audio constraints is retrieved from settings.yml.
When user changes this value in Settings > Application, audio
filters (AGC, Noise Supression and Echo Cancellation) are all set to
true/false, according to the value selected in the Settings GUI.

To start it simple, we decided to not to add a different setting in the GUI for
each audio contraint. This may be added in the future, though (perhaps in a
dedicated Audio Settings tab)
This is related to #4873
2021-01-29 14:18:15 -03:00
Ramon Souza
f72a7f0fea create a reusable component for settings and captions language dropdown 2021-01-29 13:17:35 -03:00
Ramon Souza
7c2a488f15 show only variations of the selected language on locale settings 2021-01-27 16:50:48 -03:00
Anton Georgiev
b2c702417c
Merge pull request #11216 from werk21/9101_add_poll_abstention
9101 add poll abstention
2021-01-27 11:57:15 -05:00
Anton Georgiev
aae4d1567d
Merge pull request #11232 from prlanzarin/u22-lv521012021
video-provider: fix inconsistent client state when a webcam being shared times out
2021-01-27 11:29:16 -05:00
Joao Siebel
31552f6c78 Add heapdump threshold in settings 2021-01-27 11:04:49 -03:00
Anton Georgiev
12a6b73ba0
Merge pull request #11240 from antobinary/bbb-11197
Prevent open textarea blocking dropdown menus
2021-01-26 17:16:03 -05:00
KDSBrowne
47e2f12b74 prevent open textarea blocking dropdown menus 2021-01-26 17:13:18 -05:00
Anton Georgiev
991d978f77
Merge pull request #11230 from prlanzarin/u22-poodlepower25012021
audio: fix talking-indicator mute debounce
2021-01-26 16:55:10 -05:00
Anton Georgiev
e2f821d780
Merge pull request #11229 from prlanzarin/u22-revert10912
video-provider: Revert "Improve 16x9 Support"
2021-01-26 16:51:03 -05:00
Anton Georgiev
28fc33462d
Merge pull request #11228 from prlanzarin/u22-frameshift26012021
video-provider: make video-list-item actions dropdown keys unique
2021-01-26 16:50:01 -05:00
Anton Georgiev
5e365d138f
Merge pull request #11231 from prlanzarin/u22-drc25012021
audio: add a configurable throttle to action-bar`s mute toggle
2021-01-26 16:49:13 -05:00
Joao Siebel
8c7c21f936 Sync users in collection with server active connections 2021-01-26 16:22:32 -03:00
Mario Jr
b753ef5d8d Fix wrong path in settings for audio constraints
Using now 'application' instead of old 'audio' path
2021-01-26 14:12:18 -03:00
Anton Georgiev
6c27e815fc Only publish full users to client side, no dummy users 2021-01-26 16:56:28 +00:00
prlanzarin
c57941dbdb video-provider: make video-list-item actions dropdown keys unique
When multiple actions were bolted in the dropdown (mirror, focus), keys were getting duplicated with cameraId. Make them unique based on the action`s name
2021-01-26 12:32:27 -03:00