Commit Graph

27106 Commits

Author SHA1 Message Date
Mario Jr
af48c8977d Reduce delay for the first reconnection attempt of audio's websocket
This is the same behavior we used to have on older sip.js version code
By doing this we reduce errors when user try to perform join/hangup during an websocket reconnection
2020-11-23 12:40:38 -03:00
Joao Siebel
bcc1d6c880 WIP remove callback from mongo operations 2020-11-23 10:13:46 -03:00
Fred Dixon
5d4d9ab0f5
Merge pull request #10887 from ffdixon/update-bbb-conf-30
Added check for default stun.freeswitch.org
2020-11-23 08:13:08 -05:00
Fred Dixon
0a4726bfcf Added check for default stun.freeswitch.org 2020-11-23 07:11:06 -06:00
Fred Dixon
eba0058bac
Merge pull request #10873 from mariogasparoni/v2.2.x-release
Do not trigger reconnect when ICE connection terminates before hanging up process is finished
2020-11-20 07:43:14 -05:00
Mario Jr
2b89dd7db2 Do not trigger reconnect when ICE connection terminates before hanging up process is finished
This could leave users to have your audio reconnected in the main room, while joining a breakout room
Some information can be found in #10528
2020-11-20 00:25:46 -03:00
Mario Jr
9a2fcd27e0 Revert "Prevent Error 1006 when user has two or more occurrences of ':' (colon) in your name"
This reverts commit 0a601359bb.
2020-11-20 00:23:43 -03:00
Anton Georgiev
a310a59257
Merge pull request #10870 from antobinary/breakouts-who-is-talking-mute
Breakouts: do not allow mute via who-is-talking button
2020-11-19 14:20:12 -05:00
Anton Georgiev
35032963b9 bump up release to 2.2.30 2020-11-19 14:15:45 -05:00
Anton Georgiev
dedaea5ad2 who-is-talking - do not allow mute in breakouts 2020-11-19 14:14:37 -05:00
Anton Georgiev
a947977c66
Merge pull request #10865 from jfsiebel/handle-chat-message-in-order
Handle chat messages in sync way
2020-11-19 09:31:11 -05:00
Joao Siebel
4a88d0a6db Handle chat messages in sync way 2020-11-18 18:09:38 -03:00
Anton Georgiev
468725c386
Merge pull request #10858 from mariogasparoni/v2.2.x-release
Set listenOnly to false when user left voice
2020-11-18 13:27:39 -05:00
Mario Jr
70456ef93d Set listenOnly to false when user left voice
The message/event UserLeftVoiceConfToClientEvtMsg is used when user leaves mic and listenonly, but it only sets to false the 'voiceJoined' (which represents the <hasVoiceVoiceJoined> property in BBB's XML API.
We now also set to false the 'listeningOnly' (which represents the <isListeningOnly> property in BBB's XML API). Setting both to false is not a problem, once 'MIC' and 'ListenOnly' states are mutually exclusives
Fixes #10852
2020-11-18 11:55:32 -03:00
Anton Georgiev
0b34c4fa81
Merge pull request #10857 from mariogasparoni/v2.2.x-release
Filter 'name' field in user's search
2020-11-18 09:09:20 -05:00
Mario Jr
8822819900 Filter 'name' field in user's search
This is a part of #10848, as discussed in https://github.com/bigbluebutton/bigbluebutton/pull/10848#discussion_r525480434
2020-11-18 10:40:15 -03:00
Anton Georgiev
aaf3878a4d
Merge pull request #10848 from mariogasparoni/v2.2.x-release
Fix audio modal buttons (MIC/LISTEN) after errors AND prevent Error 1006 when user has two or more occurrences of ':'
2020-11-17 15:14:20 -05:00
Mario Jr
0a601359bb Prevent Error 1006 when user has two or more occurrences of ':' (colon) in your name
This happens because FreeSWITCH is not able to parse the "From" header when it has multiple occurrences of ':'. So user is not able to join audio.
To fix, we now changed the "callerId" to use the base64 value of the user name, instead of directly using user's input (the callerId format keeps being a triple like this: <user_id>-bbbID-<base64_encoded_name>).
Once this callerIdName is encoded at the same point it is generated, there shouldn't be server side effects for changing this value; except for those places where the callerName is retrieved by splitting this triple (such as the voice talking-indicator, as described below).
Updated the talking-indicator to retrieve the username from User's object, instead of retrieving from the one username generated by splitting the callerId triple.
This problem also happens in versions <= 2.2.26.
2020-11-17 15:31:43 -03:00
Mario Jr
1b1a055d37 Fix audio modal buttons (MIC/LISTEN) not working after audio error
When user joins audio and for some reason an error (such as 1001, 1002,...), happens, the user is not able to click "Mic" and "Listen Only Buttons"; except if the audio window is closed and oppened again.
2020-11-17 15:31:42 -03:00
Anton Georgiev
38b71049f9
Merge pull request #10826 from jfsiebel/tweak-sockjs-timeout
Tweak sockjs timeout value
2020-11-17 11:24:42 -05:00
Fred Dixon
04959f45d8
Merge pull request #10841 from lkiesow/allow-bbb-to-manage-rec
Allow user bigbluebutton to delete recordings
2020-11-16 19:49:46 -05:00
Lars Kiesow
7a59069958
Allow user bigbluebutton to delete recordings
This patch modifies `bbb-record` allowing the user `bigbluebutton` to
delete recordings. The user has all necessary access rights, meaning
that the deletion works without a problem and the check for root does
not protect anything. The users owns the data after all. The current
check just makes things less convenient.
2020-11-16 23:58:47 +01:00
Joao Siebel
b6b211f4fb Tweak heartbeat 2020-11-16 18:37:25 -03:00
Joao Siebel
1c47023e8a Add original function link for reference 2020-11-16 10:46:18 -03:00
Joao Siebel
3a2d06fd88 Tweak sockjs timeout value 2020-11-13 18:41:56 -03:00
Anton Georgiev
18b7528571
Merge pull request #10824 from antobinary/debug-behind-flag
Pulled HTML5 locales on Nov 13, 2020
2020-11-13 14:18:47 -05:00
Anton Georgiev
9ed5154740 Pulled HTML5 locales on Nov 13, 2020 2020-11-13 14:17:15 -05:00
Anton Georgiev
b1227f5785
Merge pull request #10810 from prlanzarin/u22-gumtgc-wa
[html5/webrtc] Fix tryGenerateIceCandidates rejections and put it behind a flag
2020-11-13 11:00:05 -05:00
Anton Georgiev
ecbf575dcf
Merge pull request #10819 from bigbluebutton/join-api-sanitize
Sanitize parameters of API's. Fixes #10818
2020-11-13 10:55:38 -05:00
Anton Georgiev
ca0adf046c
Merge pull request #10820 from bigbluebutton/clear-return-messages
Split error message from session token in bbb-web enter API
2020-11-13 10:45:11 -05:00
Anton Georgiev
72b4c83844
Merge pull request #10817 from antobinary/debug-behind-flag
Simplified redis debug and placed behind check
2020-11-13 09:53:26 -05:00
Tiago Daniel Jacobs
e59bcd0c33 Sanitize all received parameters 2020-11-13 06:54:32 +00:00
Tiago Daniel Jacobs
52e3eea552 Split error message from session token ( making it easier to translate - and more secure/ ) 2020-11-13 06:13:48 +00:00
Tiago Daniel Jacobs
5c911ddeec Sanitize fullName parameter of join API. Fixes #10818 2020-11-13 05:59:31 +00:00
Anton Georgiev
a8dc7a0bff Simplified redis debug and placed behind check 2020-11-12 21:03:57 -05:00
Fred Dixon
cafe1a53ce
Merge pull request #10816 from mariogasparoni/v2.2.x-release
Increase private key size for dtls-srtp.pem to 4096
2020-11-12 15:29:32 -05:00
Mario Jr
ebe9b3a789 Increase private key size for dtls-srtp.pem to 4096
Using this larger value helps reducing ocurrences 1005/1010 errors for Chrome, avoiding an openssl's error which interrupts the dtls handshake (Chrome triggers "DTLS timeout expired" error)
This key size is also the default value used by freeswitch on switch_core_cert.c
2020-11-12 16:59:45 -03:00
prlanzarin
8dda22f8a7 [html5/webrtc] Fix tryGenerateIceCandidates rejections, put it behind a flag
Fixed two occurrences where the tryGenerateIceCandidates workaround rejected without an error, which borked the callers error handling

Also put it behind a config flag. This workaround used to be important when Kurento didnt infer prflx candidates properly, but that`s no longer the case. With the flag, we can disable the workaround to see if there`s any visible regression and hopefully remove it down the road
2020-11-11 13:43:36 +00:00
Fred Dixon
fb96ffdc00
Merge pull request #10808 from prlanzarin/u22-1002-6-wa
[html5/audio] Add a configurable hackViaWs to SIP.js. Part of a workaround for #9667
2020-11-10 13:39:59 -05:00
prlanzarin
a1f0276b64 [html5/audio] Add hackViaWs to SIP.js and make it configurable in settings.yml, 1002 workaround
This adds the possibility to configure the SIP Via header to plain WS to allow reverse proxying from WSS to WS, internally, to work around a bug in freeswitch where the WSS stack would get deadlocked due to a still unidentified bug in there that has to do with SSL termination
2020-11-10 15:04:45 +00:00
Fred Dixon
6383af3667
Merge pull request #10806 from mariogasparoni/v2.2.x-release
Force using plan-b as default sdpSemantics for chrome
2020-11-09 20:03:48 -05:00
Mario Jr
b948bea11b Force using plan-b as default sdpSemantics for chrome
Although Chrome's default is now unified plan, Chrome <-> FreeSWITCH ICE connection fails for some Chrome installations (specially those running on Windows).
FS ICE fails when Chromes's SDP has "a=mid:<index>" (instead of "a=mid:audio").
This fixes Error 1010 and situations where echo test takes too long.
This fixes #6414 regression, once we do the same older version of SIP.js used to do.
2020-11-09 21:58:16 -03:00
Fred Dixon
a74f62ef44
Merge pull request #10800 from mariogasparoni/v2.2.x-release
Use iceConnectionState to monitor ICE connection status
2020-11-09 06:59:04 -05:00
Mario Jr
46e0c263fe Use iceConnectionState to monitor ICE connection status
We now use both peer's connectionstatechange and iceconnectionstatechange to monitor ICE state for audio sessions.
The same way we did with old sip.js version, we leave iceconnectionstate trigger audio actions , such as connect, disconnect, reconnect.
We still listen for 'failed' state for connectionstatechange event, because chrome triggers this (tested on 86+).
This should reduce the audio error 1010 ocurrences, once some browsers (specially Chrome/Android) don't trigger connectionstatechangeevent.
This might reduce problems reported in #10708, which still needs more investigation though.
2020-11-08 22:43:52 -03:00
Fred Dixon
83dfc99260
Merge pull request #10799 from jarmediagmbh/my-changes-branch
Remove unwanted debug logging of PDF binaries
2020-11-08 17:52:50 -05:00
Your Name
b4ecf53c80 Remove unwanted debug logging: This pushed the whole binary of every PDF uploaded into the logs. 2020-11-08 16:56:26 +01:00
Fred Dixon
97da7d6023
Merge pull request #10704 from KDSBrowne/2.2-upload-modal-error-bound
Add error boundary to presentation upload modal
2020-11-06 16:40:50 -05:00
Richard Alam
e28bba42fc
Merge pull request #10742 from KDSBrowne/2.2-issue-10705
Prevent users from sending multiple votes per poll
2020-11-06 16:33:56 -05:00
Fred Dixon
7ba1ce721b
Merge pull request #10790 from mariogasparoni/v2.2.x-release
Correctly Map Websocket error and better monitoring of ICE events
2020-11-06 08:50:27 -05:00
Mario Jr
3a689578c6 Monitor peer's iceconnectionstatechange event
This gives more information about ICE connection, combined with onconnectionstatechange event
2020-11-06 09:37:58 -03:00