Commit Graph

8456 Commits

Author SHA1 Message Date
Ramón Souza
e7107f87a7
Merge pull request #15598 from ramonlsouza/merge-2526-aug25
chore: Merge v2.5.5 into v2.6
2022-08-29 15:58:53 -03:00
Ramón Souza
45e49ea7d2
Merge pull request #15606 from ramonlsouza/light-button-color
fix: light button warning
2022-08-29 13:59:52 -03:00
Ramón Souza
fef01d8fb6
Merge pull request #15567 from ramonlsouza/fix-emoji-button
fix: emoji picker button styles
2022-08-29 13:01:42 -03:00
Ramón Souza
61f7700080 fix light button warning 2022-08-29 09:39:20 -03:00
germanocaumo
105ed256c3 fix: tldraw not changing pages correctly 2022-08-29 12:27:17 +00:00
Ramón Souza
033a23e336 restore needed imports 2022-08-26 14:30:40 -03:00
Ramón Souza
62f8ab3cb2 Merge remote-tracking branch 'upstream/v2.6.x-release' into pr-15460-aug26 2022-08-26 14:05:45 -03:00
Ramón Souza
e3b7c89ac9
Merge pull request #15586 from ramonlsouza/adjust-assign-buttons
style: adjust breakout room assignment buttons
2022-08-26 13:54:32 -03:00
Joao Victor
24c227cc75 Merge 2.6.x-release into camera-brightness 2022-08-26 11:53:23 -03:00
Joao Victor
396f5320a4 feat(camera): set camera brightness 2022-08-26 11:50:46 -03:00
Ramón Souza
609d43157a Merge tag 'v2.5.5' into merge-2526-aug25 2022-08-25 14:33:44 -03:00
Ramón Souza
fbeb775313
Merge pull request #15551 from ramonlsouza/uploader-errors
fix: display presentation uploader limit errors
2022-08-25 09:49:48 -03:00
Joao Victor
54b146effe fix: add missing custom virtual background param 2022-08-25 08:30:36 -03:00
Ramón Souza
14dd486f3a prevent infinite generating slides 2022-08-24 13:34:50 -03:00
prlanzarin
ec1879f96b fix(audio): add inputDeviceId enforcement for post-join/gUM
Extract the deviceId again from the stream to guarantee consistency
between stream DID vs chosen DID. That's necessary in scenarios where,
eg, there's no default/pre-set deviceId ('') and the browser's
default device has been altered by the user (browser default != system's
default).
2022-08-24 14:39:09 +00:00
Ramón Souza
c52a3ffb25 adjust assignment buttons - create breakout 2022-08-24 10:37:10 -03:00
prlanzarin
89e814d570 fix(audio): centralize device change code, add rollbacks, surface errors
There's no rollback procedure in case a device switch fails right now,
nor does the code entrypoints that call the switching procedures wait
for resolution or failure before marking the new device as chosen. That
may cause inconsistent states in a couple of ways:
  - No rollback: switch fails, audio is still on but no actual
    microphone input is being transmitted
  - Not waiting for resolutions: inconsistent chosen devices on failures
Device switching errors are also not surfaced to the end user

This commit:
  - Adds device rollback and proper resolution/failure response
    awaits to try and make the state a bit more consistent.
  - Centralizes the input device switching code to be reused between
    different bridges
  - Centralizes device ID state management in audio-manager to try and
    mantain them a bit more consistent across the board
  - Surface device switching failures to the end user
  - Guarantee device IDs are set to the session storage on all
    appropriate scenarios
2022-08-24 13:28:27 +00:00
KDSBrowne
45b3166863 Merge branch 'tldraw-viewbox-sync' of https://github.com/germanocaumo/bigbluebutton into tldraw-viewbox-sync 2022-08-24 11:55:38 +00:00
KDSBrowne
c758664651 remove toolbar from non presenter cursor calculation 2022-08-24 11:55:31 +00:00
Ramón Souza
82e234be33
Merge pull request #15500 from JoVictorNunes/issue-15458
fix: don't clear text fake annotations
2022-08-23 16:19:39 -03:00
germanocaumo
61cb5b8ef4 fix(tldraw): fit to width / presenter / slide changing 2022-08-23 18:19:17 +00:00
Ramón Souza
59f717265a adjustments after PR 15573 2022-08-23 13:59:58 -03:00
Ramón Souza
4d82d76d4a Merge remote-tracking branch 'upstream/v2.5.x-release' into uploader-errors 2022-08-23 09:34:25 -03:00
KDSBrowne
9f7b45b172 hide eraser animation on mobile 2022-08-23 12:08:31 +00:00
Guilherme Pereira Leme
621503e258
Merge pull request #6 from JoVictorNunes/issue-15505
fix: show conversion process info in toast
2022-08-23 09:01:02 -03:00
Anton B
8e7e1e7e42 test: add data-test props in lock settings items 2022-08-22 18:02:31 -03:00
Gustavo Trott
87e4c52cee Fix error when trying to read role when user was removed already 2022-08-22 16:32:12 -03:00
KDSBrowne
ab4cb469fb Merge branch 'tldraw-viewbox-sync' of https://github.com/germanocaumo/bigbluebutton into tldraw-viewbox-sync 2022-08-22 19:07:23 +00:00
KDSBrowne
9df18af50f update presentation offset for cursor (mobile) 2022-08-22 19:05:02 +00:00
Guilherme Pereira Leme
7288d9b9f2
Changes in review
Co-authored-by: João Victor Nunes <62393923+JoVictorNunes@users.noreply.github.com>
2022-08-22 15:54:34 -03:00
germanocaumo
0e7c27968e Merge branch 'tldraw-viewbox-sync' of https://github.com/germanocaumo/bigbluebutton into tldraw-viewbox-sync 2022-08-22 18:11:40 +00:00
GuiLeme
d9de398d90 [fix-page-count-exeed] - Forwarded temporaryPresentationId to front-end and refactor it's name 2022-08-22 15:00:27 -03:00
Anton Georgiev
2be6909e26
Merge pull request #15525 from gabriellpr/about-modal
test: About Modal Test
2022-08-22 13:05:11 -04:00
KDSBrowne
eb7c3dcbc8 update pan tool button after zoom changes 2022-08-22 16:55:44 +00:00
João Victor Nunes
aba9d86904
Merge branch 'v2.6.x-release' into issue-15276 2022-08-22 13:05:25 -03:00
germanocaumo
c948f39392 Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into tldraw-viewbox-sync 2022-08-22 15:47:51 +00:00
germanocaumo
f209fd17c1 Merge branch 'tldraw-viewbox-sync' of https://github.com/germanocaumo/bigbluebutton into tldraw-viewbox-sync 2022-08-22 15:43:04 +00:00
KDSBrowne
1de4b3f644 update cursor position handling | temp hide eraser animation 2022-08-22 14:37:34 +00:00
Ramón Souza
9303c598c1
Merge pull request #15532 from KDSBrowne/bbb-responsive-wb-toolbar
fix: Make Whiteboard Toolbar Responsive to Smaller Sizes
2022-08-22 11:33:46 -03:00
Ramón Souza
03b1f13ab5 fix duplicated presentation on remove + upload 2022-08-22 10:37:05 -03:00
KDSBrowne
9c018ee6db restore large toolbar size when view enlarged 2022-08-21 21:38:54 +00:00
Anton Georgiev
4b8b216bbe
Merge pull request #15566 from antobinary/cairosvg
chore: Merge BBB 2.5 into 2.6
2022-08-19 14:32:24 -04:00
Ramón Souza
7dd5a3daa9 fix emoji picker button styles 2022-08-19 15:19:10 -03:00
Ramón Souza
318807b9e4
Merge pull request #15533 from JoVictorNunes/issue-15509
fix: push layout not working unless changed
2022-08-19 13:45:17 -03:00
Anton Georgiev
bbb7dd421d Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into cairosvg 2022-08-19 14:25:03 +00:00
Ramón Souza
3a1d0fc09e undo page_count_exceeded changes in service 2022-08-19 11:20:58 -03:00
Anton Georgiev
1b7b63baf6 Merge branch 'v2.5.x-release' of github.com:bigbluebutton/bigbluebutton into cairosvg 2022-08-19 14:14:54 +00:00
Anton Georgiev
23c0dc56c4 Merge branch 'v2.5.x-release' of github.com:bigbluebutton/bigbluebutton into cairosvg 2022-08-19 13:04:00 +00:00
germanocaumo
7bf8668f23 Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into tldraw-viewbox-sync 2022-08-18 18:41:27 +00:00
germanocaumo
99549d880f fix(tldraw): fit-to-width / presenter change view area sync
- Correctly sync the viewed area when in fit-to-width mode and when the presenter reloades the page or the presenter changes to another user.
2022-08-18 18:18:02 +00:00
Ramón Souza
ff52b6ae28 fix presentation snapshot feature 2022-08-18 15:17:38 -03:00
Ramón Souza
81b15ae329
Merge pull request #15518 from JoVictorNunes/issue-15291
fix: incorrect calculation of number of users in multi user whiteboard
2022-08-18 10:52:34 -03:00
Gabriel Porfirio
35cac6ce8d added data-test to the about button and modal 2022-08-18 08:46:31 -03:00
Gustavo Trott
222a763b8c Prevent client to end meeting while trying to restablish authentication 2022-08-17 14:08:55 -03:00
Ramón Souza
30a17562c1
Merge pull request #15539 from JoVictorNunes/issue-15484
style: presentation toolbar in RTL mode
2022-08-17 13:53:13 -03:00
Ramón Souza
408a66eb49
Merge pull request #15531 from KDSBrowne/bbb-tldraw-pan
refactor: Add Pan Button to Presentation Toolbar
2022-08-17 13:44:31 -03:00
KDSBrowne
554c792345 restrict pan tool shortcut to presenter only 2022-08-17 15:36:56 +00:00
KDSBrowne
f1ba37fc2f handle active pan state via shortcut 2022-08-17 15:23:48 +00:00
Ramón Souza
54e2618011 adjust large file error on presentation 2022-08-17 10:17:26 -03:00
Ramón Souza
b90d4ce81e fix conversion state 2022-08-16 17:26:42 -03:00
germanocaumo
98d431ad92 fix(recording): correctly save tldraw pan/zoom events 2022-08-16 19:11:49 +00:00
Joao Victor
eb8838dfaa fix: show conversion process info in toast #15505 2022-08-16 12:04:02 -03:00
Ramón Souza
a895b087f9 display page exceeded error on presentation uploader 2022-08-16 11:41:11 -03:00
germanocaumo
d4b8bdce7e fix(tldraw): sync viewed area between presenter/viewers +
- Return to the ResizeAndMoveSlide event to do pan&zoom, respecting the viewed width and height ratio
- Defaults zoom in toolbar to 100% like before to be more consistent
- Fit to width and Reset Zoom is back (fit tho width still has some sync problems)
- Fix to not change to first page when presenter reloads page
2022-08-16 12:12:43 +00:00
prlanzarin
0e162f1cda feat: configurable DSCP marking for WebRTC media
RTCRTPSender exposes DSCP marking via `networkPriority` in the encodings
configuration dictionaries. That should allow us to control
QoS priorities for different media streams, eg audio with higher network
priority than video. The only browser that implements that right
now is Chromium.

To use this, the public.app.media.networkPriorities configuration in
settings.yml. Audio, camera and screenshare priorities can be controlled
separately. For further info on the possible values, see:
  - https://www.w3.org/TR/webrtc-priority/
  - https://datatracker.ietf.org/doc/html/rfc8837#section-5
2022-08-15 21:24:05 +00:00
Gustavo Trott
ee560bf188 Makes meeting-ended and error-screen show ejectedReason message 2022-08-15 17:25:45 -03:00
Gustavo Trott
6ebdca8dc6 Makes meeting-ended and error-screen show ejectedReason message 2022-08-15 14:59:58 -03:00
Joao Victor
14d8200742 style: presentation toolbar 2022-08-15 14:56:10 -03:00
Ramón Souza
082057ba55
Merge pull request #15177 from JoVictorNunes/issue-15111
fix: restore virtual background after leaving breakout room
2022-08-15 14:45:37 -03:00
KDSBrowne
48157ae49b reset pan when not zoomed | presenter change 2022-08-15 13:17:36 +00:00
KDSBrowne
12a324631f update cursor type when pan enabled 2022-08-15 13:02:56 +00:00
Ramón Souza
f851765ab3 fix presentation downloadable state 2022-08-15 09:50:07 -03:00
Joao Victor
f4fc11d53b fix: condition to switch between layouts 2022-08-15 09:21:29 -03:00
Joao Victor
9507797588 fix: update of settings 2022-08-15 08:18:24 -03:00
KDSBrowne
26f3e5dc3f add pan button to presentation toolbar 2022-08-14 22:49:39 +00:00
KDSBrowne
df0fc0da15 make whiteboard toolbar responsive to small screens 2022-08-12 19:08:26 +00:00
GuiLeme
491380096e [apply-toast-shared-notes] - changes in review and resolve merge conflict 2022-08-11 15:50:06 -03:00
Joao Victor
8e9ca4b2c8 fix: incorrect calculation of number of users in multi user whiteboard 2022-08-11 15:44:16 -03:00
GuiLeme
6c319b5183 [apply-toast-shared-notes] - changes in review~ 2022-08-11 15:07:42 -03:00
Ramón Souza
c032009677 fix remove presentation bug 2022-08-11 14:27:29 -03:00
Joao Victor
60857a0056 fix(tldraw): hide context menu for users who don't have access to whiteboard 2022-08-11 13:38:17 -03:00
Ramón Souza
a1dd5f0a36
Merge pull request #15466 from JoVictorNunes/issue-15341
fix(layout): don't show `navbar`/`actions-bar` before layout has been calculated
2022-08-10 14:47:22 -03:00
Ramón Souza
c0246215d4
Merge pull request #15502 from KDSBrowne/bbb-tldraw-keys
refactor: Add Remaining Shortcut Keys to Help Modal
2022-08-10 13:37:35 -03:00
GuiLeme
c65def5a0f [apply-toast-shared-notes] - ajustments to maintain flow 2022-08-10 11:57:53 -03:00
Ramón Souza
44966f3e18
Merge pull request #15501 from KDSBrowne/bbb-tldraw-dock-position
fix: Position Whiteboard Toolbar with API | Sync Current Locale
2022-08-09 17:16:19 -03:00
GuiLeme
246153e62c [apply-toast-shared-notes] - Removed some of the comments and separated toast controller 2022-08-09 12:24:44 -03:00
Ramón Souza
c65ed3c785
Merge pull request #15494 from ramonlsouza/media-fix-port
fix: port screenshare/external video fixes to 2.5
2022-08-09 10:11:52 -03:00
KDSBrowne
7f4151e6eb update shortcut keys list 2022-08-09 11:45:46 +00:00
KDSBrowne
3ebfdef9bd use api toolbar general position | sync current locale 2022-08-08 22:47:51 +00:00
GuiLeme
93b51ded53 [apply-toast-shared-notes] - Finished separation of the component 2022-08-08 17:42:06 -03:00
Joao Victor
74c4c1c4cc fix: don't clear text fake annotations 2022-08-08 17:07:41 -03:00
Ramón Souza
c48e942a62
Merge pull request #15488 from ramonlsouza/fix-dialin-button-styles
fix(styles): adjust dial-in button styles
2022-08-08 10:49:19 -03:00
GuiLeme
147f339e55 [apply-toast-shared-notes] - change the tracker from the service, implemented the solution to shared notes. 2022-08-08 08:50:52 -03:00
Ramón Souza
a7495ad16b add presentation snapshot button data-test 2022-08-05 13:14:27 -03:00
Ramón Souza
da370a10cb
Merge pull request #15475 from ramonlsouza/fix-cc-icon-position
fix: adjust captions icon position
2022-08-05 11:02:00 -03:00
Ramón Souza
4721184eb6 fix mobile init values for external video/screnshare 2022-08-05 09:52:48 -03:00
prlanzarin
6f13961018 fix(layout): set external-video/screen share initial states on all layouts
Only smart layout takes screen sharing/external video states in account
when populating its initial state. The others don't, and that causes
some weird issues when switching back-and-forth between layout types due
to their input states becoming inconsistent - ie having an active screen
sharing and transitioning from Smart -> Custom would mark it as false
(due to its absence from the initial state) and pollute its state for
subsequent layouts.

This commit guarantees those features are taken into account when
populating initial input states for Focus On*/Custom layouts.
2022-08-05 09:52:36 -03:00
Gustavo Trott
3e6d546062
Merge pull request #15367 from danielpetri1/pdf-disabledFeatures-tldraw 2022-08-04 21:51:57 -03:00
Ramón Souza
eb19199235 adjust dial-in button styles 2022-08-04 14:17:45 -03:00
KDSBrowne
942327f4f1 Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into bbb-tldraw-latest 2022-08-04 12:51:48 +00:00
Ramón Souza
9cfc3e7edd
Merge pull request #15343 from frankemax/dynamic-filter-emojis
feat(emoji-picker): dynamically filter emojis
2022-08-04 09:42:56 -03:00
KDSBrowne
48cc57dbaf move variable definition 2022-08-03 14:30:22 +00:00
KDSBrowne
7ade8a0d7d Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into bbb-tldraw-latest 2022-08-03 14:23:38 +00:00
KDSBrowne
b66e44a4cb Upgrade tldraw to latest version 2022-08-03 14:19:12 +00:00
GuiLeme
1e0700b455 [apply-toast-shared-notes] - merge 26 and resolved conflicts 2022-08-03 11:12:55 -03:00
Ramón Souza
7408523b2c
Merge pull request #15473 from KDSBrowne/bbb-15381
refactor: Add Whiteboard Shortcuts to Help Modal
2022-08-03 10:23:41 -03:00
Ramón Souza
ded8493f05 Merge remote-tracking branch 'upstream/v2.5.x-release' into 2526-aug3 2022-08-03 09:53:41 -03:00
Ramón Souza
9e219d9cb3 adjust cc icon position 2022-08-02 17:33:53 -03:00
GuiLeme
74caa9cb5f [apply-toast-shared-notes] - Savepoint - Made some changes 2022-08-02 17:25:15 -03:00
KDSBrowne
7c6f7f64b1 update icons in shortcuts modal 2022-08-02 15:33:33 +00:00
Anton Georgiev
ca0195585f
Merge pull request #15441 from antonbsa/audio-tests
test: Add new audio tests
2022-08-02 11:07:04 -04:00
Daniel Petri Rocha
3529fe9f28 Rename parameters; hide download button and label when disabled 2022-08-02 15:53:40 +02:00
KDSBrowne
b838d3862d localize tabs in shortcut modal 2022-08-02 11:43:29 +00:00
KDSBrowne
aabfdbb991 update shortcut modal style | add new shortcuts for WB 2022-08-01 22:41:48 +00:00
Joao Victor
efb40e00bb fix(layout): don't show navbar/action-bar before layout has been calculated 2022-07-29 16:02:31 -03:00
Gabriel Porfirio
8198953f30 removing unused imports 2022-07-28 16:50:31 -03:00
Ramón Souza
d9f2660d6a
Merge pull request #15330 from JoVictorNunes/vb-improvements-Jul-04
improvement(virtual background): better error handling, notifications…
2022-07-28 09:25:00 -03:00
Ramón Souza
40f61ecce4
Merge pull request #15452 from JoVictorNunes/fix-crash-remove-background
fix: check virtual background index
2022-07-27 16:40:46 -03:00
Ramón Souza
49b12e57c0
Merge pull request #15446 from KDSBrowne/2.6-console-err
fix(wb): Fix Console Type Error on Shape Hover
2022-07-27 16:20:24 -03:00
Joao Victor
d2eda01bcb fix: check for undefined value 2022-07-27 16:15:19 -03:00
KDSBrowne
a485f372f6 fix console error 2022-07-27 18:46:44 +00:00
Ramón Souza
1da57d8c50
Merge pull request #15455 from ramonlsouza/add-missing-media-init
fix: In Android Screen share and Share external video not showing to newly joined
2022-07-27 15:01:36 -03:00
Ramón Souza
b4fb203593 fix mobile init values for external video/screnshare 2022-07-27 10:56:04 -03:00
Ramón Souza
ccce085aed Merge remote-tracking branch 'upstream/v2.6.x-release' into issue-15001 2022-07-27 09:49:19 -03:00
Ramón Souza
640356af4f
Merge pull request #15442 from ramonlsouza/issue-15431
fix: chat panel resizing in RTL
2022-07-27 09:05:21 -03:00
Joao Victor
fe669b2f58 fix: check virtual background index 2022-07-27 09:00:18 -03:00
Gustavo Trott
acb0465266
Merge pull request #15412 from JoVictorNunes/export-presentation 2022-07-26 17:49:09 -03:00
Ramón Souza
b00d19b097
Merge pull request #15110 from ramonlsouza/fix-restore-on-update
fix: autoSwapLayout/restoreOnUpdate new presentation fails to show (2.5)
2022-07-26 16:38:33 -03:00
Ramón Souza
b14e5bc290
Merge pull request #15416 from KDSBrowne/v2.6.x-viewer-resize-wb-crash
Prevent Viewer Panel Resize Crashing Whiteboard
2022-07-26 15:50:15 -03:00
Joao Victor
26cd80506e fix: snapshot of current slide 2022-07-26 11:54:50 -03:00
GuiLeme
f0c95c4fe5 [apply-toast-shared-notes] Checkpoint - moving responsability of monitoring the upload to the service 2022-07-26 09:25:36 -03:00
Ramón Souza
4f39e419ac
Merge pull request #15421 from gabriellpr/waiting-list-feedback
fix: Adding notification to waiting users list
2022-07-26 09:06:20 -03:00
Joao Victor
07434d238c refactor: toast notification rework 2022-07-25 18:56:26 -03:00
Ramón Souza
c6f4056677 fix chat resizing in RTL 2022-07-25 16:53:19 -03:00
Joao Victor
5c6c28cdd2 Fix conflicts 2022-07-25 15:14:27 -03:00
Ramón Souza
01ba2a27f5
Merge pull request #15332 from JoVictorNunes/virtual-backgrounds-skeleton-preview
improvement(virtual background): loading skeleton, custom backgrounds in video preview modal
2022-07-25 13:34:22 -03:00
Ramón Souza
890ca5c4a0
Merge pull request #15429 from prlanzarin/u26/fix/screenshare-layout-dimensions
fix(layout): use actual screen share size when calculating smart layout
2022-07-25 13:02:00 -03:00
Gabriel Porfirio
15b28d52fe updating feedback message 2022-07-22 13:27:39 -03:00
prlanzarin
b8811bafd4 fix(layout): use actual screen share size when calculating smart layout
Smart layout (et al) presumes screen sharing will always use 100%
width of the media area. That causes cameras to always be positioned on
top, which is not always the optimal position depending on the viewport
and stream aspect ratio/resolution - so space is wasted.

This commit uses the actual screen sharing video size as provided by
HTMLVideo's videoWidth/videoHeight properties. The calculation uses the
same logic as the one used for presentation/slides, which should make it
a bit familiar.

There's also a handler for HTMLVideo's `resize` event for those browsers
that support it - which enables handling of variable-sized screen
sharing streams. That handler is debounced at 500 ms to prevent
excessive CPU use.

Extra testing is needed with the widest range possible of
browsers/environments and feature combinations.
2022-07-22 13:28:43 +00:00
Ramón Souza
7c4457bfa1
Merge pull request #15415 from JoVictorNunes/issue-15397
fix: breakout remaining time label
2022-07-22 14:23:47 +01:00
Joao Victor
dbafb610d5 fix: whiteboard access avatar icon in RTL mode 2022-07-22 10:16:57 -03:00
GuiLeme
82e0204cfa [apply-toast-shared-notes] - Savepoint refactor toast 2022-07-22 10:06:32 -03:00
Ramón Souza
9c8c580db2
Merge pull request #15424 from prlanzarin/u26/fix/layout-ss-calc
fix(layout): set external-video/screen share initial states on all layouts
2022-07-22 13:12:31 +01:00
Joao Victor
ce7f35b3db fix: checkbox and remove button alignment in RTL languages 2022-07-21 17:30:25 -03:00
Anton Georgiev
d7bdc324a0 chore: pull BBB 2.5.4+ into 2.6 2022-07-21 20:25:31 +00:00
Joao Victor
e59e3b68af fix: header alignment 2022-07-21 17:20:03 -03:00
GuiLeme
dbb2681b28 WIP - started refactoring service 2022-07-21 15:56:44 -03:00
prlanzarin
8f77f4cd1f fix(layout): set external-video/screen share initial states on all layouts
Only smart layout takes screen sharing/external video states in account
when populating its initial state. The others don't, and that causes
some weird issues when switching back-and-forth between layout types due
to their input states becoming inconsistent - ie having an active screen
sharing and transitioning from Smart -> Custom would mark it as false
(due to its absence from the initial state) and pollute its state for
subsequent layouts.

This commit guarantees those features are taken into account when
populating initial input states for Focus On*/Custom layouts.
2022-07-21 18:07:49 +00:00
Gabriel Porfirio
94cfa3c084 WIP: Adding notification to waiting users list 2022-07-21 14:07:19 -03:00
KDSBrowne
9234dee077 fix viewer wb crash switching to rtl 2022-07-20 19:54:23 +00:00
KDSBrowne
db41932fe7 update render wb condition | add operator 2022-07-20 19:20:46 +00:00
KDSBrowne
21f2a441ee update editable whiteboard component key 2022-07-20 19:03:26 +00:00
KDSBrowne
9d8ce2215d remove key prop 2022-07-20 18:51:50 +00:00
KDSBrowne
fb63975a7e fix viewer WB crash when resizing 2022-07-20 18:50:13 +00:00
prlanzarin
6c8b097eba fix: add option to disable transcription in mobile, extend support check
Mobile endpoints are flaky with the WebSpeechAPI:
  - iOS versions that support it are borking our outbound audio when it's
    enabled
  - Android speech recognition has flaky locale detection and speech
    transcription
Additionally: the support check is not checking the WebSpeechAPI
availability properly, so older devices (eg iOS 12) are flagged as
supported even though they aren't.

This commit adds a configuration flag (public.audioCaptions.mobile) to
control transcription availability on mobile. False by default.
Also extends the setSpeechVoices support check and
hasSpeechRecognitionSupport method to prevent false positives.
2022-07-20 17:20:54 +00:00
Arthurk12
e93b9739de style(captions): adds border to toggle button 2022-07-20 17:20:53 +00:00
Max Franke
75eef650e6 feat(audio-captions): reallocate button from mobile
Remove CC button toggle in the action bar only in mobile.
Add a new CC button toggle in settings dropdown only to mobile.
2022-07-20 17:20:53 +00:00
Arthurk12
c96b53093c feat(captions): adds locale settings
Adds two new flags to the settings file which change the way the locale
flag is used:

- forceLocale: (true/false) => If true, enforces the transcription
  language to be the locale content field and jumps the language
selector
  in audio modal.
- defaultSelectLocale: (true/false) => If true, the default selected
  value in the dropdown language selector in audio modal will be defined
  by the locale content field.

In any case, if the locale flag holds an invalid value, it defaults to
disabled.
2022-07-20 17:20:53 +00:00
Arthurk12
da9adca229 fix(captions): talking indicator icon
Prevents the speech recognition from being initialized when the closed
captions feature is disabled.
2022-07-20 17:20:52 +00:00
Pedro Beschorner Marin
d553ca65cf feat(captions): use navigator language
If not set to use the default language, try to select the navigator
language as speech default locale.
2022-07-20 17:20:52 +00:00
Pedro Beschorner Marin
116c0d9a49 fix(captions): filter duplicated languages
Avoid multiple instances of the same language at the voices data.
2022-07-20 17:20:52 +00:00
Pedro Beschorner Marin
51eeb092b3 refactor(captions): configurable languages
Move the language collection to the HTML settings file. This data defines
the available languages available for the speech API.

These language tags are used to filter SpeechSynthesis' API `getVoices`
result. Tags must use BCP 47 format.

https://developer.mozilla.org/en-US/docs/Web/API/SpeechSynthesisVoice/lang
2022-07-20 17:20:52 +00:00
Pedro Beschorner Marin
b52c67d7a7 feat(captions): first pass on recording
Add the main server-side adapter for using the legacy closed captions
recording process with the audio captions data.
2022-07-20 17:20:52 +00:00
Pedro Beschorner Marin
aa7f2abae2 feat(captions): talking users' floor
Associate the floor status with the talking users to improve feedback
on automated closed captions.
2022-07-20 17:20:51 +00:00
Pedro Beschorner Marin
1064aab84d style(captions): add background alpha
Add some transparency to the background color.
2022-07-20 17:20:51 +00:00
Pedro Beschorner Marin
fb48e61d6d feat(captions): add talking indicator feedback
Inform other users about who are the current talkers with the speech
recognition enabled.
2022-07-20 17:20:51 +00:00
Pedro Beschorner Marin
df184b542c feat(captions): add unsupported warning
Add a disclaimer for users on browsers that do not provide speech synthesis'
voices.
2022-07-20 17:20:51 +00:00
Pedro Beschorner Marin
307ab6ea40 feat(captions): add author avatar
Include captions' author avatar at the live feedback to improve identification.
2022-07-20 17:20:50 +00:00
Pedro Beschorner Marin
d00909751a refactor(captions): change getVoices routine
In some cases, `getVoices` returns an empty array even if the browser's vendor
has full support for speech synthesis. Add a trigger call to initiate the
voices fetching process.

As drafted, `getVoices` can be an asynchronous call and monitoring it
depends on the support of a `voiceschanged` event. Although many of the
main vendors support voices, this event is not (yet) by Safari.

https://wicg.github.io/speech-api/#dom-speechsynthesis-getvoices
https://wicg.github.io/speech-api/#eventdef-speechsynthesis-voiceschanged
https://developer.mozilla.org/en-US/docs/Web/API/SpeechSynthesis/voiceschanged_event
2022-07-20 17:20:50 +00:00
Pedro Beschorner Marin
d6dc66f57e feat(captions): language selector
Replace the checkbox with a selector up with 3 languages: en-US, es-ES and pt-BR.

Add setting option to enable by default with predetermined locale.
2022-07-20 17:20:50 +00:00
Pedro Beschorner Marin
5671bd7d3c fix(captions): check for voices
Avoid enable audio transcription if the browser's vendor does not provide
voices data.

This should prevent false positives for browsers such as Chromium and
Brave.
2022-07-20 17:20:49 +00:00
Pedro Beschorner Marin
e131925370 style(captions): font-family fallback
Add extra `sans` alternatives
2022-07-20 17:20:49 +00:00
Pedro Beschorner Marin
d688a2572f fix(captions): remove padding when no content
Avoid rendering the captions wrapper's padding when there's no data to
be displayed at the live feedback.
2022-07-20 17:20:49 +00:00
Pedro Beschorner Marin
f726cb0ad5 refactor(captions): UX improvements
Parse the audio transcript before broadcasting it's content back to the
client and the recording actor. Limiting by 8 words per line and max of
2 lines to avoid CPU intensive operations over this recurring event.

Replace Calibri font family with Verdana to improve character spacing,
add relative sizing to the text content and a background padding.
2022-07-20 17:20:49 +00:00
Pedro Beschorner Marin
75969ec93c feat(captions): audio captions app
Add a server-side app for the audio captions feature and record proto-events
for this data.

As it is, only behaves as a pass-through module. The idea is to include all
the business intelligence in this app.
2022-07-20 17:20:48 +00:00
Pedro Beschorner Marin
0bc730b3e3 refactor(captions): improve recovery
Use the user's talking state to trigger a speech API recovery after long
periods of silence.
2022-07-20 17:20:48 +00:00
Pedro Beschorner Marin
944edf2ccf feat(captions): web speech prototype
Hardcoded pt-BR prototype for closed captions generated by the browser's
WebSpeech API.
2022-07-20 17:20:48 +00:00
Joao Victor
a1ed921039 fix: breakout remaining time label 2022-07-20 12:22:46 -03:00
Joao Victor
cff1c087a8 feat: front-end support for exporting presentations with annotations 2022-07-19 16:36:00 -03:00
KDSBrowne
100bfcfb86 update fullscreen element check 2022-07-19 10:51:59 +00:00
KDSBrowne
ed55d58b01 handle cursor positions for video focus 2022-07-19 03:37:47 +00:00
KDSBrowne
47303757de handle cursor position for fullscreen presentation 2022-07-19 01:23:10 +00:00
Ramón Souza
f083bb9a20
Merge pull request #15273 from JoVictorNunes/issue-15272
fix: apply presentation 'isCurrent' changes to local state
2022-07-18 21:19:20 +01:00
Ramón Souza
2fd65dfc1c
Merge pull request #15099 from schrd/fix-issue-14982
Fix: only show breakout room in user list when user is in breakout room
2022-07-18 21:17:17 +01:00
Anton B
944e0b2981 test: add audio tests 2022-07-15 17:54:16 -03:00
Joao Victor
0ac69cba0a fix: comparison to render custom buttons 2022-07-15 17:16:33 -03:00
Joao Victor
34aaf07fed Merge branch v2.6.x-release into virtual-backgrounds-skeleton-preview 2022-07-15 17:14:16 -03:00
Paulo Lanzarin
383fe89653
Merge pull request #15364 from prlanzarin/u26/refactor/kutils-kboom
refactor: remove kurento-utils-js
2022-07-15 14:53:10 -03:00
prlanzarin
d06ae5ce40 fix: add default gUM factory to new peer wrapper
For scenarios such as preview-less camera sharing, old echo test
2022-07-15 17:07:15 +00:00
Anton Georgiev
f2e25768c7
Merge pull request #15390 from ramonlsouza/merge25-26-jul14
chore: Merge v2.5.3 into v2.6
2022-07-15 11:43:17 -04:00
Ramon Souza
83d9feb9c0 fix missing import in audio controls 2022-07-15 11:41:11 -03:00
Ramon Souza
d08ff18add Merge remote-tracking branch 'upstream/v2.6.x-release' into merge25-26-jul14 2022-07-15 11:12:25 -03:00
Ramon Souza
db5ac1428a Merge tag 'v2.5.3' into merge25-26-jul14 2022-07-15 11:08:02 -03:00
prlanzarin
6a4ceac61f refactor(webcam): swap kurento-utils for the new peer wrapper 2022-07-15 14:00:12 +00:00
Ramón Souza
267a6f5c9c
Merge pull request #15203 from ramonlsouza/improve-ghost-button-border
style: improve ghost buttons border in low density display
2022-07-15 12:06:59 +01:00
Ramón Souza
da848e990a
Merge pull request #15320 from gabriellpr/dark-light-buttons
Styling light and dark buttons
2022-07-13 21:03:46 +01:00
gabriellpr
1c2f9e9cd9
Update styles.js 2022-07-13 16:35:02 -03:00
Paulo Lanzarin
3e8ccd370d
Merge pull request #15375 from prlanzarin/u26/fix/local-echo-gUM-block
fix(audio): block audio join while gUM isn't resolved (local echo)
2022-07-13 15:57:02 -03:00
gabriellpr
49f12c43af
Merge branch 'v2.6.x-release' into dark-light-buttons 2022-07-13 15:36:31 -03:00
prlanzarin
27896e74e6 fix(audio): block audio join while gUM isn't resolved (local echo)
The new local echo view doesn't block the "Join audio" button while
awaiting for getUserMedia permission to be granted/denied. That may
cause unexpected behavior when unattentive users just click "Join audio"
without granting or denying gUM.

This commit accounts for gUM resolution when deciding whether to block
the "Join audio" button. It also includes an extra "isConnecting" check
to it to avoid spam-clicking issues.
2022-07-13 14:35:37 +00:00