Commit Graph

8659 Commits

Author SHA1 Message Date
Anton Georgiev
e2f821d780
Merge pull request #11229 from prlanzarin/u22-revert10912
video-provider: Revert "Improve 16x9 Support"
2021-01-26 16:51:03 -05:00
Anton Georgiev
28fc33462d
Merge pull request #11228 from prlanzarin/u22-frameshift26012021
video-provider: make video-list-item actions dropdown keys unique
2021-01-26 16:50:01 -05:00
Anton Georgiev
5e365d138f
Merge pull request #11231 from prlanzarin/u22-drc25012021
audio: add a configurable throttle to action-bar`s mute toggle
2021-01-26 16:49:13 -05:00
Joao Siebel
8c7c21f936 Sync users in collection with server active connections 2021-01-26 16:22:32 -03:00
Mario Jr
b753ef5d8d Fix wrong path in settings for audio constraints
Using now 'application' instead of old 'audio' path
2021-01-26 14:12:18 -03:00
Anton Georgiev
6c27e815fc Only publish full users to client side, no dummy users 2021-01-26 16:56:28 +00:00
prlanzarin
c57941dbdb video-provider: make video-list-item actions dropdown keys unique
When multiple actions were bolted in the dropdown (mirror, focus), keys were getting duplicated with cameraId. Make them unique based on the action`s name
2021-01-26 12:32:27 -03:00
prlanzarin
32e7ddeaf7 Revert "Improve 16x9 Support"
This reverts commit b8fc94c722.
2021-01-26 12:03:11 -03:00
prlanzarin
c37c3d0c7b video-provider: fix inconsistent client state when a webcam being shared timed out (1020)
Recent fix to the stop all cameras behaviour exposed a bug where the local camera connecting state wasnt being cleared up when a camera timed out before being successfully shared
2021-01-26 11:49:39 -03:00
prlanzarin
234efd289a audio: add a configurable throttle to action-bar`s mute toggle
Default value is 300ms, with default trailing/leading. Set toggleMuteThrottleTime to 0 to restore old behaviour
2021-01-26 11:47:48 -03:00
prlanzarin
a8f817555d audio: fix talking-indicator mute debounce
The debounce method argument was being passed wrong (its supposed to be a method, not a function call), thus spewing exceptions in the console and rendering the debounce virtually ineffective
2021-01-26 11:44:45 -03:00
Mario Jr
7858ba94ba Avoid setting empty/undefined constraint
This removes the console warning about invalid constraint
2021-01-25 23:45:27 -03:00
Pedro Beschorner Marin
7e26e78c4f Cleanup from authenticated guests removal
While cherry-picking some of this work I noticed those extras.
2021-01-23 22:22:52 -03:00
werk21
80af96ff76 9101: Survey: New profile yes/no/abstention 2021-01-24 02:22:40 +01:00
Pedro Beschorner Marin
e595d31f80 Set default guest configuration
Changes to the current (v2.2) default configuration of the guest feature.

The ideal is to keep the simplified guest feature as default (`authenticatedGuests=false`)
but we also need to be in sync with Greenlight settings to make this happen.

Greenlight will have to re-add the `guest=true` param on user's join API call when ASK_MODERATOR
is set as guest's policy.
2021-01-23 21:58:34 -03:00
Pedro Beschorner Marin
4fbc237a8f Configurable users' labels
User's name labels can be enabled and disabled at `settings.yml`.
2021-01-23 21:58:25 -03:00
Pedro Beschorner Marin
85ee3b283f Identify mobile users at user list 2021-01-23 21:57:55 -03:00
Pedro Beschorner Marin
bd15f14ca0 Allow guests promotion/demotion
When authenticated guest is disabled (bigbluebutton-web's `authenticatedGuest` property)
2021-01-23 21:55:20 -03:00
Pedro Beschorner Marin
ea207d6f8c Adjust guest panel header and width 2021-01-23 21:54:51 -03:00
Pedro Beschorner Marin
a8af70993b Make the guest list a scrollable element 2021-01-23 21:52:52 -03:00
Pedro Beschorner Marin
0bbef12ac7 Authenticated guests feature controlled at bbb-web properties 2021-01-23 21:48:02 -03:00
KDSBrowne
a76b740ffe prevent open textarea blocking dropdown menus 2021-01-22 21:42:45 +00:00
Anton Georgiev
8a72b8ef22
Merge pull request #11194 from ramonlsouza/PR-9946-fix
Improves the end meeting confirmation message
2021-01-22 15:33:18 -05:00
Anton Georgiev
45c1ff6e40
Merge pull request #11175 from MaximKhlobystov/select-random-user
Presenter selecting a random viewer
2021-01-22 15:31:00 -05:00
Ramon Souza
244842c86b applying suggested changes 2021-01-22 16:48:50 -03:00
Mario Jr
97c76900cb Add setting for enabling/disabling microphone audio filters
As explained in #11143, disabling audio filters is desired in some scenarios.
This basically adds an option for user to disable default constraints.
When user doesn't change this value in Settings > Application, the default
value for each audio constraints is retrieved from settings.yml.
When user changes this value in Settings > Application, audio
filters (AGC, Noise Supression and Echo Cancellation) are all set to
true/false, according to the value selected in the Settings GUI.

To start it simple, we decided to not to add a different setting in the GUI for
each audio contraint. This may be added in the future, though (perhaps in a
dedicated Audio Settings tab)
This is related to #4873
2021-01-22 16:30:42 -03:00
Anton Georgiev
ac9cec4149
Merge pull request #11165 from daminebenq/update-custom-params-autotests
adds missing custom parameters specs to the custom parameters test suite
2021-01-21 16:03:13 -05:00
Joao Siebel
bb831e0442 Modify throttle interval to be a const variable 2021-01-21 14:05:59 -03:00
Joao Siebel
8f36ac3586 Add throttle to startUserTyping function 2021-01-21 13:05:41 -03:00
Ramon Souza
3742746de3 PR 9946 + suggested text changes 2021-01-20 17:49:07 -03:00
Ramon Souza
f04733d85e Merge remote-tracking branch 'upstream/develop' into PR-9946-fix 2021-01-20 17:42:47 -03:00
Anton Georgiev
af76a56ba7
Merge pull request #11186 from ramonlsouza/issue-11181
Fixes crash when presenter is kicked
2021-01-20 11:42:37 -05:00
Ramon Souza
ef1725fff9 fixes similar bug on user-list/service/getEmoji function 2021-01-20 13:22:17 -03:00
Ramon Souza
6f9d60c520 code style 2021-01-20 11:39:47 -03:00
Joao Siebel
fa0fd8a054 Add configurable process interval for cursor and annotations 2021-01-20 11:36:40 -03:00
Ramon Souza
fe12208d6c better fix for issue #11181 2021-01-20 11:28:37 -03:00
Ramon Souza
b0551e24ad added a comment on the code to make changes clear 2021-01-20 10:07:00 -03:00
Ramon Souza
79bbbc0fb1 Fixes #11181 2021-01-20 09:23:51 -03:00
Anton Georgiev
62aca3b8ae
Merge pull request #11179 from ramonlsouza/issue-11116
Fixes closed captions language list
2021-01-19 15:31:32 -05:00
Ramon Souza
39b63368e2 Fixes #11116 2021-01-19 17:16:29 -03:00
KDSBrowne
3f0cde7dbb Merge branch 'develop' of https://github.com/bigbluebutton/bigbluebutton into bbb-11056 2021-01-19 16:02:32 +00:00
KDSBrowne
206cae3707 fix locale fetch loop with xx_XX fallback/override 2021-01-19 16:02:20 +00:00
Maxim Khlobystov
5238dac647 Remove callbacks from update and clear Mongo operations for randomly selecting a user 2021-01-19 01:53:13 +00:00
Maxim Khlobystov
88c6e773e3 Fix the issue with connectionStatus resulting in no users being availble to randomly pick from (select random viewer feature) 2021-01-19 01:01:46 +00:00
Anton Georgiev
0ba3aa713a
Merge pull request #10912 from lkiesow/16x9
Improve 16x9 Support
2021-01-18 16:05:01 -05:00
Fred Dixon
27cb9e8a39
Merge pull request #11078 from hiroshisuga/patch-11
Remove mountModal requirement in presentation uploader
2021-01-15 22:53:53 -04:00
Mohamed Amine Ben Salah
1c40b0b8c8 adds missing custom parameters specs to the custom parameters test suite 2021-01-15 19:51:52 -03:00
Paulo Lanzarin
1f3d487ecc
Merge pull request #11142 from pedrobmarin/fix-multiple-webcam-stop-all
Fix stream stop for multiple webcams
2021-01-12 17:35:10 -03:00
Mario Jr
92708da447 Allow audio constraints to be changed in bbb-html5's settings.yml
In some scenarios, there's no need for the browser to apply such audio filters. For example, when user's microphone already does audio filtering (echo cancellation, noise supression ...).
This commit doens't change the current behavior (filters still follow browser's default config): admins need to uncomment/set these values if disabling/enabling specific filters if desired.
This is related to #4873
2021-01-12 14:42:27 -03:00
Pedro Beschorner Marin
cc9b552e2a Fix stream stop for multiple webcams
Video provider's service for local stream control was wrongly setting the disconnected
state when a multiple webcam user tried to stop a single cam. The `stopVideo` method
was inconsistent when called multiple times for the same `cameraId`.

Included a better testing scope for event dispatching and disconnected state handling.
2021-01-12 13:24:40 -03:00
basisbit
9c3c926ede
Increase camera baseTimeout to 30 seconds
see https://github.com/bigbluebutton/bigbluebutton/issues/11099#issuecomment-753985300
2021-01-08 04:56:20 +01:00
Anton Georgiev
d9629113cb fix undefined css class button in video-button 2021-01-06 19:13:48 +00:00
Anton Georgiev
24e2fe967b temporarily allow undefined user name for offline chat sender 2021-01-06 19:12:35 +00:00
Anton Georgiev
2dabeaae29 remove duplicated html id video-modal-input 2021-01-06 16:53:22 +00:00
Anton Georgiev
3e3f3236cc correct path to silence.mp3 2021-01-06 15:55:01 +00:00
Anton Georgiev
eb8e412935 ensure sorting has a fallback in case of undefined name 2021-01-06 15:21:44 +00:00
Anton Georgiev
f734071cb8 update axios to 0.21.1 to resolve vuln 2021-01-05 16:16:36 +00:00
Anton Georgiev
3135c6bb22 Handle guestWait url for multiple nodejs instanceIds 2021-01-05 15:38:21 +00:00
Fred Dixon
9e7bd44c9b
Merge pull request #10604 from hiroshisuga/patch-8
Fix slide size problem at fullscreen <-> window-mode transition
2020-12-30 08:08:38 -04:00
Fred Dixon
278a010ae3
Merge pull request #11074 from hiroshisuga/patch-10
Suppress warning of React file player
2020-12-28 22:38:11 -04:00
Fred Dixon
9b973c331f
Merge pull request #11077 from hiroshisuga/bug-shortcutwindow
Adding ID to debug window shortcut translation
2020-12-28 22:37:30 -04:00
hiroshisuga
3c0a35706c
Update styles.scss 2020-12-27 15:10:32 +09:00
hiroshisuga
4e4d3beb10
Update component.jsx 2020-12-27 10:36:01 +09:00
hiroshisuga
90ea3f845b
Update en.json 2020-12-27 09:58:44 +09:00
hiroshisuga
d30a9bba47
Update component.jsx 2020-12-27 09:55:32 +09:00
hiroshisuga
3dc0aa83f2
Update component.jsx 2020-12-27 00:01:54 +09:00
Paulo Lanzarin
b78d2b85a8 Add missing app.video.genericError en locale
It seems the video-preview generic error fallback locale (to handle unexpected errors on our side which do not inherently come from gUM calls) was removed by accident. Adding it back.
2020-12-22 21:10:22 +00:00
prlanzarin
0aa7d67c4d video-preview: normalize some error locales 2020-12-22 20:50:01 +00:00
Paulo Lanzarin
1334127b35 video-preview: bump default gUMTimeout to 20s
Otherwise users who took long enough to accept the gUM permission prompt would fall into the workaround
2020-12-22 20:10:59 +00:00
Pedro Beschorner Marin
4e370d28ec Add timeout at video's preview modal
Some browsers seem to (occasionally) not return the getUserMedia promise call and the
user gets stuck in this state unable to share her/his webcam.

Since enumerateDevices still works even on a gUM rejection this includes a racing
timeout that skips gUM. Configured at settings `gUMTimeout`.

Reproduced with Windows 10 Chrome 87.
2020-12-22 20:10:19 +00:00
Pedro Beschorner Marin
c8ace18f85 Enumerate devices even if first getUserMedia fails
The first getUserMedia was not supposed to be considered critical to the whole
video preview flow.

Scenarios where the user has multiple media sources and one of them was already
in use or had some malfunction problem were forcing a global skip at the video
preview modal even if one of them was available to be used.
2020-12-22 19:26:28 +00:00
Pedro Beschorner Marin
f6217308dd Refactor video preview getUserMedia preview error handler 2020-12-22 19:26:23 +00:00
Pedro Beschorner Marin
dced6bd2b8 Add missing getUserMedia errors
Collected from https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getUserMedia
2020-12-22 19:25:48 +00:00
Pedro Beschorner Marin
62d491c8e4 Refactor video preview getUserMedia device error handler 2020-12-21 20:54:21 +00:00
CristianSilvaGrosseli
0c4f903c39 use placeholder in the logger.error method return in the video-preview component. fix wrong file permission. 2020-12-21 20:53:56 +00:00
CristianSilvaGrosseli
d8ed8f2570 use correct pattern in video-preview's handleGUMError method. 2020-12-21 20:53:12 +00:00
CristianSilvaGrosseli
ffd1063332 video-preview component's handleGUMError method rehabilitation. 2020-12-21 20:52:15 +00:00
Anton Georgiev
2a825c8aaa settings.yml media configs incorrectly placed under "stats" 2020-12-18 17:55:44 +00:00
Anton Georgiev
646dd583e3 add Kazakh and Mongol 2020-12-18 16:54:27 +00:00
Anton Georgiev
438deeff6a Pulled HTML5 locales on 2.3, Dec 18, 2020 2020-12-18 16:41:10 +00:00
Anton Georgiev
2bbd345782 add missing videoDock locale strings 2020-12-18 16:00:05 +00:00
Anton Georgiev
4f14086f72 set default value for isPresenter in case user removed 2020-12-18 15:37:45 +00:00
Anton Georgiev
fc93b5a91c correctly add chat message without flattening 2020-12-17 22:02:38 +00:00
Anton Georgiev
c1ffced27d Merge branch 'v2.2.x-release' of github.com:bigbluebutton/bigbluebutton into develop 2020-12-17 21:14:29 +00:00
Anton Georgiev
99ff801d34 remove obsolete callback from user remove 2020-12-15 22:04:26 +00:00
Anton Georgiev
1880c0b5db
Merge pull request #11024 from jfsiebel/generate-heapdump-file
Add option to generate heap file and tweak metrics
2020-12-15 14:47:15 -05:00
Anton Georgiev
2bf6758f31
Enable customHeartbeat by default
https://github.com/bigbluebutton/bigbluebutton/pull/10826
2020-12-15 14:46:38 -05:00
Joao Siebel
3ad269c24c Check if metrics are enabled 2020-12-15 16:20:32 -03:00
Joao Siebel
c5b8f30f5d Add option to generate heapdump file and improve metrics 2020-12-15 13:10:39 -03:00
Anton Georgiev
8b65f9e15b Set bbb-html5 loadbalancing to be round robin 2020-12-15 01:55:57 +00:00
Anton Georgiev
9239d515a5 dispatch whiteboard events to html5 redis channel only 2020-12-12 01:45:38 +00:00
Anton Georgiev
0be8773e4c Loadbalance bbb-html5 in bbb-web based on CPU 2020-12-11 21:36:06 +00:00
Anton Georgiev
9a04087c12
Merge pull request #11006 from mariogasparoni/v2.2.x-release
Add keep alive message to audio's websocket
2020-12-11 10:41:33 -05:00
Joao Siebel
b07b200a2f Prevent calling function when parameters are undefined 2020-12-11 11:24:03 -03:00
Mario Jr
6113113af9 Add option to disable traceSip logs
Audio client logs already cover audio session progress the way we need.
This avoids keepAlive and other unnecessary messages to be logged in browser's console.
If setting is not present, default value is set to false.
2020-12-11 00:31:10 -03:00
Mario Jr
c65fa2b350 Add keep alive message to audio's websocket
This was added as an option (websocketKeepAliveInterval), which is the interval to send keep alive messages.
Setting websocketKeepAliveInterval to 0 disables the keep alive, producing the same old behavior.
This helps avoid websocket disconnection due to socket inactivity, preventing it to unnecessarily reconnect.
Also, sometimes reconnect fails and error 1005 is triggered.
Fixes problems reported in #10985.
Also reduces occurrences of error 1005.
2020-12-10 23:48:01 -03:00
Joao Siebel
ec2cb2dbde Chek for queueMetrics 2020-12-10 14:07:46 -03:00
Joao Siebel
5b0d6c59e6 Code clean up 2020-12-10 14:05:22 -03:00
Joao Siebel
e9d05454ea Remvoe console 2020-12-10 13:52:25 -03:00
Joao Siebel
bf5a45d303 Create Metrics class 2020-12-10 12:07:06 -03:00