Calvin Walton
aa1aef6727
Recording: Don't use stateful filters in ffmpeg video processing
...
Because the input videos for BigBlueButton recording processing switch
resolution and aspect ratio, the filter chain gets re-initialized, and
any state in the filters is lost. This causes problems with the
following filters:
`color`: Timestamps restart from 0, rather than continuing at the point
where they left off.
`fps=start_time=12.345`: After reset, the fps filter thinks it's at the
start of the file again, so the next frame it sees gets duplicated
output for timestamps from the `start_time` until it catches back up.
`setpts=PTS-STARTPTS`: The 'STARTPTS' is re-read as the first pts the
filter sees after reinitialization, so timestamp of the next frame is
reset to 0. (In practise, this didn't cause any problems because the
duplicate frames created by the fps filter had the original start time.)
The end result of all of these issues is that a lot of duplicate frames
were created with invalid timestamps, which eventually get discarded
by ffmpeg. But a lot of time is wasted, causing recordings to sometimes
take hours to process when they should be ready in minutes.
The fixes are as follows:
* The `color` filters are used to generate the background and
substitutes for missing videos. Move them out to separate filter
chains by using the 'lavfi' input format, which lets you use a filter
as if it was an input file.
* Rather than use the `fps` filter's `start_time` feature, use the
`trim` filter to remove early frames.
* The actual start pts is already known by the script, so replace
`setpts=PTS-STARTPTS` with `setpts=PTS-12.345/TB`, substituting in the
absolute time.
2022-11-22 13:35:48 -05:00
Gustavo Trott
c7566b174d
Merge pull request #15611 from MaximKhlobystov/draw-visual-regression
2022-11-22 14:15:58 -03:00
Joao Victor
b34bd0d682
Don't open it if on mobile, presentation is closed, or there are no webcams
2022-11-22 14:15:15 -03:00
Ramón Souza
2e0ed23f8e
Merge pull request #16042 from ramonlsouza/sonarcloud-alerts-nov22
...
refactor: conditional hooks
2022-11-22 13:48:05 -03:00
Joao Victor
a784cc398d
Merge branch 'v2.6.x-release' into auto-opening-sb-content
2022-11-22 13:36:14 -03:00
Ramón Souza
1878ffb0b0
Merge pull request #16045 from ramonlsouza/sonarcloud-guest-policy
...
refactor: adjust guest policy component name
2022-11-22 13:25:19 -03:00
Ramón Souza
b3903f5e87
adjust guest policy component naming
2022-11-22 13:16:46 -03:00
Gabriel Porfirio
e4b10838fa
presentation fullscreen and snapshot tests
2022-11-22 12:01:09 -03:00
Gabriel Porfirio
0cb364214a
added new function for two different browser instances
2022-11-22 10:44:28 -03:00
Ramón Souza
9b0cff367a
fix conditional hooks - captions select
2022-11-22 09:20:14 -03:00
Ramón Souza
f2a6fc7694
fix conditional hooks - captions button
2022-11-22 09:16:26 -03:00
Joao Victor
ac8012f0f2
style: poll custom input toggle
2022-11-22 09:09:35 -03:00
GuiLeme
5c41f53d0b
Merge remote-tracking branch 'upstream/v2.6.x-release' into fix-check-mime-insert-document
2022-11-22 08:47:54 -03:00
Guilherme Pereira Leme
773ee880e0
Merge pull request #7 from gustavotrott/pr-15990
...
Code improvements using best practices
2022-11-22 08:32:34 -03:00
Gustavo Trott
0113d35f87
Add code improvements
2022-11-21 23:29:23 -03:00
GuiLeme
3f9fcc693f
[update-gem-tzinfo] - updated resque gem
2022-11-21 17:05:26 -03:00
Ramón Souza
d7005a70bd
Merge pull request #16023 from Tainan404/fix-client-reconnection
...
Fix: client reconnection after meeting end
2022-11-21 14:53:31 -03:00
GuiLeme
041d964932
[fix-check-mime-insert-document] - Changes in review
2022-11-21 14:52:08 -03:00
Gustavo Trott
8b7b501ea2
Merge pull request #15589 from danielpetri1/breakout-shared-notes-upload
2022-11-21 08:08:36 -03:00
Fred Dixon
72f863d504
Merge pull request #16033 from KDSBrowne/bbb-common-bold-patch
...
Fix Most Common Poll Answer Bold Style
2022-11-20 10:59:57 -04:00
Fred Dixon
a3d351d5bc
Merge pull request #16032 from KDSBrowne/bbb-resize-wb-toolbars
...
Improve Whiteboard Toolbar Responsiveness To Element Width
2022-11-20 10:59:33 -04:00
KDSBrowne
604446ffe0
fix is most common comparison failing
2022-11-20 14:26:52 +00:00
GuiLeme
cf70ea39ae
[fix-check-mime-insert-document] - changes in review
2022-11-18 17:20:44 -03:00
Maxim Khlobystov
8e72776a3c
Remove unnecessary skips in the whiteboard tests
2022-11-18 15:03:38 -05:00
KDSBrowne
0c99f4a30c
improve spacing in connection status modal
2022-11-18 19:54:00 +00:00
Gustavo Trott
17a16eced5
Merge pull request #16022 from gustavotrott/presentation-refactor
2022-11-18 16:31:00 -03:00
Ramón Souza
a2d6a45782
Merge pull request #15903 from BrentBaccala/testsuite-console-log
...
Testsuite console log
2022-11-18 15:36:36 -03:00
KDSBrowne
6a13c70ec4
Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into 26-con-status-a11y
2022-11-18 17:42:09 +00:00
Gabriel Porfirio
60db3182c2
changes on pin notes test
2022-11-18 13:38:46 -03:00
Ramón Souza
046e54141d
Merge pull request #15986 from owi92/homogenize-tooltip-padding
...
adjust horizontal tooltip padding
2022-11-18 13:34:17 -03:00
Ramón Souza
982e7c8d98
Merge pull request #15988 from owi92/accessible-tooltips
...
make tooltips more accessible
2022-11-18 13:28:54 -03:00
Ramón Souza
330c5e9b94
Merge pull request #16005 from JoVictorNunes/fix-console-warnings
...
fix: console warnings due to invalid attributes
2022-11-18 13:24:55 -03:00
Gustavo Trott
defc2835a1
Update bbb-common-web/src/main/java/org/bigbluebutton/api/MeetingService.java
...
Co-authored-by: Guilherme Pereira Leme <69865537+GuiLeme@users.noreply.github.com>
2022-11-18 12:46:23 -03:00
Ramón Souza
0ac798d261
Merge pull request #16026 from Tainan404/new-nginx-rule-25
...
Add new nginx rules
2022-11-18 10:52:18 -03:00
Tainan Felipe
e3e94fff75
Add new nginx rules
2022-11-18 10:44:50 -03:00
KDSBrowne
bca5cc9fbe
fix toolbar not responding to wb width
2022-11-17 23:37:17 +00:00
Daniel Petri Rocha
a53a7e924f
Refactor: remove setPresentationExportingProgress; AnalyticsActor log
2022-11-17 20:55:15 +01:00
Tainan Felipe
b06da1017a
Fix client reconnection after meeting end
2022-11-17 15:59:13 -03:00
Ramón Souza
4f59f2afd9
Merge pull request #15911 from gabriellpr/poll-remain-tests
...
test: Poll remaining tests
2022-11-17 15:46:30 -03:00
Ramón Souza
ff2cbe1317
Merge pull request #15962 from gabriellpr/test-download-presentation
...
test: Download presentation
2022-11-17 15:46:18 -03:00
Gustavo Trott
8002abc33b
Merge pull request #15989 from gustavotrott/setip-follow-symlink
...
Closes https://github.com/bigbluebutton/bigbluebutton/issues/15887
2022-11-17 13:25:05 -03:00
Gustavo Trott
7781909d50
Removes all references to swf files (used by old flash client)
2022-11-17 10:55:19 -03:00
Ramón Souza
3b61696004
Merge pull request #16020 from JoVictorNunes/fix-drop-area-overflow
...
fix: text overflow in sidebar drop area
2022-11-17 10:27:39 -03:00
Ramón Souza
4f353b31dc
Merge pull request #16017 from JoVictorNunes/npm-audit-html5-Nov-16
...
chore (bigbluebutton-html5): npm audit fix
2022-11-17 10:16:37 -03:00
Joao Victor
db0f79d400
fix: text overflow in sidebar drop area
2022-11-17 09:44:04 -03:00
Gabriel Porfirio
b339402933
changed dark mode test name
2022-11-16 17:17:28 -03:00
Gabriel Porfirio
ee0c3c49bd
dark mode testing background and text colors
2022-11-16 17:15:24 -03:00
Gabriel Porfirio
35e5236683
few improvements and pin notes test
2022-11-16 15:18:03 -03:00
Joao Victor
54514649a1
chore (bigbluebutton-html5): npm audit fix
2022-11-16 14:39:12 -03:00
Paulo Lanzarin
0287d38363
Merge pull request #16010 from bigbluebutton/bpads140
...
build(bbb-pads): v1.4.0
2022-11-16 13:49:59 -03:00
