Commit Graph

8632 Commits

Author SHA1 Message Date
Mario Jr
8822819900 Filter 'name' field in user's search
This is a part of #10848, as discussed in https://github.com/bigbluebutton/bigbluebutton/pull/10848#discussion_r525480434
2020-11-18 10:40:15 -03:00
Mario Jr
0a601359bb Prevent Error 1006 when user has two or more occurrences of ':' (colon) in your name
This happens because FreeSWITCH is not able to parse the "From" header when it has multiple occurrences of ':'. So user is not able to join audio.
To fix, we now changed the "callerId" to use the base64 value of the user name, instead of directly using user's input (the callerId format keeps being a triple like this: <user_id>-bbbID-<base64_encoded_name>).
Once this callerIdName is encoded at the same point it is generated, there shouldn't be server side effects for changing this value; except for those places where the callerName is retrieved by splitting this triple (such as the voice talking-indicator, as described below).
Updated the talking-indicator to retrieve the username from User's object, instead of retrieving from the one username generated by splitting the callerId triple.
This problem also happens in versions <= 2.2.26.
2020-11-17 15:31:43 -03:00
Mario Jr
1b1a055d37 Fix audio modal buttons (MIC/LISTEN) not working after audio error
When user joins audio and for some reason an error (such as 1001, 1002,...), happens, the user is not able to click "Mic" and "Listen Only Buttons"; except if the audio window is closed and oppened again.
2020-11-17 15:31:42 -03:00
Joao Siebel
b6b211f4fb Tweak heartbeat 2020-11-16 18:37:25 -03:00
Joao Siebel
1c47023e8a Add original function link for reference 2020-11-16 10:46:18 -03:00
Joao Siebel
3a2d06fd88 Tweak sockjs timeout value 2020-11-13 18:41:56 -03:00
Fred Dixon
4bc44bfa9c
Merge pull request #10825 from KDSBrowne/2.3-safair-console-errors
Fix console errors in safari on iPad
2020-11-13 16:06:45 -05:00
Anton Georgiev
9ed5154740 Pulled HTML5 locales on Nov 13, 2020 2020-11-13 14:17:15 -05:00
Anton Georgiev
b1227f5785
Merge pull request #10810 from prlanzarin/u22-gumtgc-wa
[html5/webrtc] Fix tryGenerateIceCandidates rejections and put it behind a flag
2020-11-13 11:00:05 -05:00
Anton Georgiev
a8dc7a0bff Simplified redis debug and placed behind check 2020-11-12 21:03:57 -05:00
prlanzarin
8dda22f8a7 [html5/webrtc] Fix tryGenerateIceCandidates rejections, put it behind a flag
Fixed two occurrences where the tryGenerateIceCandidates workaround rejected without an error, which borked the callers error handling

Also put it behind a config flag. This workaround used to be important when Kurento didnt infer prflx candidates properly, but that`s no longer the case. With the flag, we can disable the workaround to see if there`s any visible regression and hopefully remove it down the road
2020-11-11 13:43:36 +00:00
prlanzarin
a1f0276b64 [html5/audio] Add hackViaWs to SIP.js and make it configurable in settings.yml, 1002 workaround
This adds the possibility to configure the SIP Via header to plain WS to allow reverse proxying from WSS to WS, internally, to work around a bug in freeswitch where the WSS stack would get deadlocked due to a still unidentified bug in there that has to do with SSL termination
2020-11-10 15:04:45 +00:00
Mario Jr
b948bea11b Force using plan-b as default sdpSemantics for chrome
Although Chrome's default is now unified plan, Chrome <-> FreeSWITCH ICE connection fails for some Chrome installations (specially those running on Windows).
FS ICE fails when Chromes's SDP has "a=mid:<index>" (instead of "a=mid:audio").
This fixes Error 1010 and situations where echo test takes too long.
This fixes #6414 regression, once we do the same older version of SIP.js used to do.
2020-11-09 21:58:16 -03:00
KDSBrowne
bd4a3d2500 fix console errors in safari 2020-11-09 22:40:25 +00:00
hex-m
153665c19a string fixes 2020-11-09 18:00:38 +01:00
Mario Jr
46e0c263fe Use iceConnectionState to monitor ICE connection status
We now use both peer's connectionstatechange and iceconnectionstatechange to monitor ICE state for audio sessions.
The same way we did with old sip.js version, we leave iceconnectionstate trigger audio actions , such as connect, disconnect, reconnect.
We still listen for 'failed' state for connectionstatechange event, because chrome triggers this (tested on 86+).
This should reduce the audio error 1010 ocurrences, once some browsers (specially Chrome/Android) don't trigger connectionstatechangeevent.
This might reduce problems reported in #10708, which still needs more investigation though.
2020-11-08 22:43:52 -03:00
Fred Dixon
97da7d6023
Merge pull request #10704 from KDSBrowne/2.2-upload-modal-error-bound
Add error boundary to presentation upload modal
2020-11-06 16:40:50 -05:00
Richard Alam
e28bba42fc
Merge pull request #10742 from KDSBrowne/2.2-issue-10705
Prevent users from sending multiple votes per poll
2020-11-06 16:33:56 -05:00
KDSBrowne
42cdc51710 add z-index to actionbar elements 2020-11-06 20:48:06 +00:00
Mario Jr
3a689578c6 Monitor peer's iceconnectionstatechange event
This gives more information about ICE connection, combined with onconnectionstatechange event
2020-11-06 09:37:58 -03:00
Mario Jr
2585d957e8 Correctly map WebSocket error
Maps WebSocket's 1006 error to BBB's 1002, the same way it was done with old sip.js version
Set user agent's number of reconnection attempts to the same value as older sip.js version
2020-11-06 09:25:40 -03:00
KDSBrowne
2468ac225c return null in publishVote if user already voted 2020-11-05 17:02:31 +00:00
KDSBrowne
5076a2accd fix typo / use operator / add log 2020-11-05 14:19:36 +00:00
KDSBrowne
2f46c1fd28 Merge branch 'develop' of https://github.com/bigbluebutton/bigbluebutton into 2.3-user-rand-select 2020-11-02 16:16:29 +00:00
KDSBrowne
7c690ab22c fix presentation downloadable tooltip msg 2020-10-30 13:00:07 +00:00
Anton Georgiev
5ba12846d5
Update index.js 2020-10-28 15:17:17 -04:00
KDSBrowne
d2cb02b3bd prevent users from being able to send more than 1 poll vote 2020-10-28 18:33:09 +00:00
Mario Jr
3e3b648040 Properly stops userAgent / peer when audio connection/reconnection fails
Changed the maximum attempts of the UserAgent reconnection (this should be changed when binding audio's websocket to meteor's connection state).
Added a log to monitor WS reconnect attempts.
2020-10-28 15:04:30 -03:00
Anton Georgiev
df8b6350c9
Merge pull request #10617 from KDSBrowne/2.3-undo-pencil
Fix broken undo of consecutive pencil annotations
2020-10-27 14:59:57 -04:00
Mohamed Amine Ben Salah
bf45dbc7f9 adds visual regressions test with snapshots ready to use 2020-10-27 12:54:55 -03:00
Mohamed Amine Ben Salah
f0a0e21972 Merge remote-tracking branch 'upstream/develop' into add-visual-regressions-testing 2020-10-27 12:52:59 -03:00
Anton Georgiev
24442f1050
Merge pull request #10369 from jfsiebel/connection-manager
Add ClientConnection manager
2020-10-27 11:49:35 -04:00
Mohamed Amine Ben Salah
aee7534c9e update Jest ^23.5.0 > ^26.6.1 2020-10-27 12:09:24 -03:00
Anton Georgiev
b808b0185f
Merge pull request #10728 from antobinary/jquery
Move the check to disable mutedAlert feature; temp disable it
2020-10-26 17:12:03 -04:00
Anton Georgiev
ce8c733ec4 move the check to disable mutedAlert feature; temp disable it 2020-10-26 21:07:15 +00:00
Joao Siebel
91c8e78d44 Fix join listen only problem 2020-10-26 13:10:40 -03:00
Anton Georgiev
b8649629eb
Merge pull request #10702 from Zh4rsiest/develop
[Mobile] - Setting or clearing user status locks the whole screen
2020-10-26 11:29:11 -04:00
Mario Jr
d1e5f189ba Prevent 1005 error log when user close/reload bbb's window/tab
When closing/reloading tab with active microphone, audio exits successfully but a wrong log-error (1005) is shown.
We now process closing/reloading tab the same way we do when user hangup the call.
2020-10-25 16:12:58 -03:00
Mario Jr
18c20261e1 Change default value of iceGatheringTimeout to current's SIP.js default
For some reason (still investigating), using turn/coturn on 443/tcp makes firefox's iceGathering process (during echo test) takes 12+ seconds (tested on webrtc's trickle page with multiple instances).
This was found when testing the current default (15s) on production with a private turn/coturn server on port 443/tcp. For default bbb setup (stun only), echo test still runs fast.
To avoid adding extra delay to iceGathering on this scenario (Firefox + turn on 443/tcp), i am just setting the default value back to the 5s (old default).
So , for those who wants to reduce the 1004 occurrences, increasing the iceGatheringTimeout could help (just be aware this adds delay on the mentioned scenario).
2020-10-24 08:58:25 -03:00
Zh4rsiest
3f13f4eca4 Changing isIphone value
The component expects a boolean but isIphone property return an array ["Iphone"] if the user is from an iPhone
2020-10-23 12:37:43 -03:00
Zh4rsiest
1b7a672a1b Updating variables in container
They both return an array with ["Iphone"] if you're from an iphone but the component expects bool variables.
2020-10-23 12:37:18 -03:00
Mario Jr
a86ff72aa3 Increase default iceGatheringTimeout
Added a default 'MEDIA' option: iceGatheringTimeout. This option allows admin to set a higher ICE gathering timeout, which can help when getting ICE errors during audio negotiation (eg 1004)
Default value set to 15s (current default is 5s).
2020-10-23 11:21:20 -03:00
Mario Jr
993c3a5a8a Do not show reconnect/disconnect message when new ICE candidates are found
Sometimes, when user already joined audio session, RTCPeerConnection may
find new ICE candidates, which triggers 'connected' state for peer's
'onconnectionstatechange' event. When this happens we process this
new state the same way when user is not running an audio session, which
makes html5client popup an annoying 'Audio Connected' message.
The audio keeps working fine, but this can make user think that there's a
connection issue, or the audio is reconnecting, while audio is ok.
2020-10-23 11:20:08 -03:00
Anton Georgiev
21ab1e0d47
Merge pull request #10663 from Zh4rsiest/ios-safari-fix
Fix for OSX and iOS Safari errors in console
2020-10-22 15:03:37 -04:00
Zh4rsiest
096556a74f
Dropdown component.jsx update
On mobile if you clicked on a user or your own user to set their status, the tethered modal would keep it's z-index, which would prevent the user from interacting with anything because the tethered modal would overlap the whole site.
2020-10-22 19:14:50 +02:00
KDSBrowne
e116396481 add error boundry to presentation upload modal 2020-10-22 13:00:09 +00:00
Joao Siebel
e50c348874 WIP improve log 2020-10-21 14:27:40 -03:00
Lucas Zawacki
7efcd3b87e Dont include extra dot in instructure media url 2020-10-21 14:00:51 -03:00
Joao Siebel
be8421db3c Merge remote-tracking branch 'upstream/develop' into connection-manager 2020-10-21 13:57:17 -03:00
Anton Georgiev
e18d94dd23 resolve media/component issues after 2.2.28 merge 2020-10-21 14:50:06 +00:00
Anton Georgiev
0c7ead1916 Merge branch 'v2.2.x-release' of github.com:bigbluebutton/bigbluebutton into oct16-merge 2020-10-21 14:48:02 +00:00
KDSBrowne
d74b5af2a9 clear selected user when moderator closes modal | clean up 2020-10-19 14:46:41 +00:00
Mohamed Amine Ben Salah
5c4c20c871 fixes webcams layout autotest 2020-10-18 14:33:06 -03:00
Anton Georgiev
70eb028da9
Merge pull request #10667 from jfsiebel/improve-streamer-and-error-logs
Improve annotations and cursor streamer logs
2020-10-16 14:42:05 -04:00
Joao Siebel
109c18beb0 Improve annotations and cursor streamer logs, also add a type info for some logs in authentication process
and rollback some attempts to fix multiple leaving end call.
2020-10-16 10:30:50 -03:00
Mario Jr
df67d2e680 Better handling audio reconnection
When getting disconnected with 1001 ("websocket closed unexpectedly" error) we were creating a new SIP session, therefore a new FreeSWITCH channel.
While reconnecting the socket, instead of closing the SIP session, we keep it alive during reconnection (audio should keep working in the meantime). When reconnected we keep using this same session (avoiding the creation of an extra one).
We also better handle WebSocket error codes from SIP.js.
FF immediately closes websocket when unloading page, so we now to stop user agent when 'beforeunload' event is triggered, to avoid leaving open sessions in FreeSWITCH when user leaves page.
2020-10-15 11:24:23 -03:00
Zh4rsiest
d9de58e1c8
Changing isIphone value
The component expects a boolean but isIphone property return an array ["Iphone"] if the user is from an iPhone
2020-10-15 16:20:06 +02:00
Zh4rsiest
1a987243f7
Updating variables in container
They both return an array with ["Iphone"] if you're from an iphone but the component expects bool variables.
2020-10-15 16:18:34 +02:00
Mario Jr
a7ab00e3e9 Fix wrong skipCheck handling
We now let sip.js handle getUserMedia calls, same should happen when skipCheck is active.
Solves #10652.
2020-10-14 23:30:08 -03:00
Anton Georgiev
b1e57e3d2f
Bump up log level of forced meeting end 2020-10-14 09:44:17 -04:00
Joao Siebel
dadca62741 Merge remote-tracking branch 'upstream/develop' into connection-manager 2020-10-13 10:49:12 -03:00
hiroshisuga
84937a0d07
Delete bbb-icons-ori.woff 2020-10-11 18:53:10 +09:00
hiroshisuga
391434445a
Add files via upload 2020-10-11 18:52:44 +09:00
hiroshisuga
7c245c666d
Delete bbb-icons.woff 2020-10-11 18:51:31 +09:00
hiroshisuga
6f8c764c4b
Add files via upload 2020-10-11 18:50:48 +09:00
hiroshisuga
5141e65359
Delete tmp.woff 2020-10-11 18:44:04 +09:00
hiroshisuga
c8f7b17b04
Add files via upload 2020-10-11 18:43:37 +09:00
hiroshisuga
73c4506594
Create tmp.woff 2020-10-11 18:43:17 +09:00
hiroshisuga
9d01d58527
Delete bbb-icons.woff 2020-10-11 18:42:43 +09:00
Fred Dixon
0ae5d29b25
Merge pull request #10625 from lfzawacki/v2.2.x-release
Make instructuremedia regexp more general
2020-10-09 17:15:01 -04:00
Anton Georgiev
1ee7946d38
Merge pull request #10615 from antobinary/09-30-libs
Added allowDefaultLogoutUrl config to optionally ignore non-custom logoutUrl
2020-10-09 17:14:36 -04:00
Anton Georgiev
e200cba6c8 utilize a simpler way to drop the protocol for comparison 2020-10-09 17:10:12 -04:00
Lucas Zawacki
19d24cbb60 Make instructuremedia regexp more general 2020-10-09 18:09:35 -03:00
Anton Georgiev
1ffad034f7 Revert "compare the true URLs, ignore protocols"
This reverts commit 3bb6b70d90.
2020-10-09 16:54:34 -04:00
Anton Georgiev
ed32333494 Pulled HTML5 locales on Oct 09, 2020 2020-10-09 16:41:18 -04:00
Anton Georgiev
3bb6b70d90 compare the true URLs, ignore protocols 2020-10-09 14:30:41 -04:00
Anton Georgiev
adcb05b1ec
Merge pull request #10612 from jfsiebel/improve-logs
Improve  log in/authentication logs
2020-10-09 13:43:09 -04:00
Anton Georgiev
bf555dc047
Merge pull request #10564 from KDSBrowne/2.2-publishVote-error
Fix exception while invoking method 'publishVote'
2020-10-09 13:36:21 -04:00
KDSBrowne
9827664efc fix textArea width / height sent from client 2020-10-09 14:20:22 +00:00
Mohamed Amine Ben Salah
2bb8ef8abc [WIP] adds visual regression testing 2020-10-08 16:32:00 -03:00
KDSBrowne
c518263fc9 fix broken undo of consecutive pencil annotations 2020-10-08 14:35:36 +00:00
Anton Georgiev
41cab38e87 Added allowDefaultLogoutUrl config to optionally ignore non-custom logoutUrl 2020-10-08 05:15:05 -04:00
Anton Georgiev
38b51ea359
Merge pull request #10561 from antobinary/09-30
[Backport] Allow Samsung and Yandex browsers
2020-10-07 15:50:26 -04:00
Joao Siebel
14388ec922 Improve logs for a better debug/understanding of problems related to authentication and log in process 2020-10-07 16:50:17 -03:00
Anton Georgiev
6f60324a4e
Merge pull request #10585 from hiroshisuga/fix-undo-fs-label
Fix undo-presentation-fullscreen button label
2020-10-07 15:49:48 -04:00
Anton Georgiev
10276b3301
Merge pull request #10590 from hiroshisuga/patch-7
Shortcut key to toggle fullscreen
2020-10-07 15:49:06 -04:00
Pedro Beschorner Marin
6b87491796 Check if DOMMatrix exists before cursor coordinate transform
Cursor coordinates are calculated using the presentation SVG object
DOMMatrix. When getting this matrix, some browsers (Firefox at least)
responds it as null if the svg object does not have a visible area.

This adds a check before trying to transform the cursor coordinates
using the matrix inverse so we avoid calling a method from a null object.
If there isn't a DOMMatrix to be used as reference, returns a simple out of
bounds SVGPoint (-1, -1)
2020-10-07 15:07:23 -03:00
Anton Georgiev
e65498e978
Merge pull request #10602 from KDSBrowne/2.2-sharecam-sr-label
Fix share webcam button label for screen readers
2020-10-07 09:04:32 -04:00
Anton Georgiev
1363f8e1e5
Merge pull request #10607 from pedrobmarin/breakout-join-audio-ui
Fix the UI state on breakout room audio join
2020-10-07 09:02:10 -04:00
Pedro Beschorner Marin
d0645983f5 Fix the UI state on breakout room audio join
Users must return their audio to the main room before joining a different one.
Since the audio transfer and the UI state manager doesn't provide a shortcut for
jumping from a breakout room to another, avoid making this opiton available.
2020-10-07 09:23:13 -03:00
hiroshisuga
28c9ca6484
Update component.jsx 2020-10-07 17:21:18 +09:00
Mario Jr
e9e436378a Correctly set audio input/output devices
When refusing ("thumbs down" button) echo test, user is able to select a different input device. This should work fine for chrome, firefox and safari (once user grants permission when asked by html5client).
For output devices, we depend on setSinkId function, which is enabled by default on current chrome release (2020) but not in Firefox (user needs to enable "setSinkId in about:config page). This implementation is listed as (?) in MDN.
In other words, output device selection should work out of the box for chrome, only.
When selecting an outputDevice, all alert sounds (hangup, screenshare , polling, etc) also goes to the same output device.
This solves #10592
2020-10-06 20:37:55 -03:00
Anton Georgiev
55bdd22170
Merge pull request #10601 from KDSBrowne/2.2-notes-sr-label
Fix aria labels on shared notes button
2020-10-06 12:49:34 -04:00
KDSBrowne
66e487b146 update status string for raise hand 2020-10-06 13:58:59 +00:00
KDSBrowne
a6533111b7 add active state to aria label for selected emoji 2020-10-06 13:58:07 +00:00
KDSBrowne
feea250c0b fix share webcam btn label for screen reader 2020-10-06 13:46:21 +00:00
KDSBrowne
889a212be7 fix aria labels on shared notes btn 2020-10-06 13:42:04 +00:00
Pedro Beschorner Marin
eaa610c1f7 Hide draggable overlay when data saving is enabled
If someone is sharing her/his webcam and the presenter enables webcam's data savings the
draggable overlay covers a portion of the presentation slide.
2020-10-06 08:35:29 -03:00
hiroshisuga
e5f6fe77b1
Update component.jsx 2020-10-05 11:26:24 +09:00
hiroshisuga
340d86f26c
Update component.jsx 2020-10-04 11:06:54 +09:00
hiroshisuga
1b2987df4c
Update en.json 2020-10-04 11:04:32 +09:00
Mario Jr
e1b9ad3536 Map stun/turn servers into WebRTC's iceServers, when using fallback stun 2020-10-02 16:19:55 -03:00
Anton Georgiev
95277836f8
Merge pull request #10580 from mariogasparoni/v2.2.x-release
Set stun/turn server for audio's peer in html5 client
2020-10-02 13:50:35 -04:00
Mohamed Amine Ben Salah
85ca1882e5 adds webcams layout autotest to all.test.js 2020-10-02 09:27:31 -03:00
Joao Siebel
895e82f260 Remove unused method 2020-10-01 15:32:24 -03:00
Joao Siebel
78ead44d17 Fix reconnection flow 2020-10-01 14:31:38 -03:00
Mario Jr
49bfe9f48d Set stun/turn server for audio's peer in html5 client
Latest SIP.js version sets this using peerConnectionConfiguration property instead of UserAgent option.
This solves #10569
2020-10-01 10:16:48 -03:00
Anton Georgiev
d0cf1b8f7e remove currently unused webdriverio lib due to vulnerabilities 2020-09-30 11:09:57 -04:00
Anton Georgiev
6a2e70d5eb remove currently unused webdriverio lib due to vulnerabilities 2020-09-30 11:00:23 -04:00
Anton Georgiev
0c68823784 allow Yandex browser to the list of supported browsers 2020-09-30 09:33:24 -04:00
Alexander Bias
4f55a49f5a Tooltip which indicates if a presentation can be downloaded or not can be confusing - Fixes #9436 2020-09-30 09:22:12 -04:00
Anton Georgiev
f78014a189
Merge pull request #10529 from abias/patch-1
Tooltip which indicates if a presentation can be downloaded or not can be confusing
2020-09-30 09:21:41 -04:00
fireba11
91c49417ad fixes #9952
adds identifier for samsungs mobile browser (based on chromium) as
supported browser for check
2020-09-30 09:12:39 -04:00
Joao Siebel
db7164253d Prevent repeated setUserId 2020-09-29 18:02:03 -03:00
Anton Georgiev
3ddf834de0
Merge pull request #10549 from jfsiebel/prevent-multiple-on-close-handler-attach
Prevent multiple on close handler attach
2020-09-29 12:57:55 -04:00
Anton Georgiev
64efa67412
Merge pull request #10548 from jfsiebel/rework-session-token-check
Add extra check for sessionToken
2020-09-29 12:39:02 -04:00
Joao Siebel
6919498234 Prevent multiple attaches on socket close for the same user 2020-09-29 09:57:31 -03:00
Joao Siebel
b0f2abad8b Prevent user who logout from meeting to join again using the same sessionToken
also move this and banned user check to a different method.
2020-09-29 09:33:15 -03:00
KDSBrowne
e99292836f fix Match error: Expected object, got undefined in publishVote 2020-09-28 19:28:35 +00:00
fireba11
49a44d1339 fixes #9952
adds identifier for samsungs mobile browser (based on chromium) as
supported browser for check
2020-09-28 20:41:53 +02:00
Mario Jr
2d2a034729 Add sessionDescriptionHandlerModifiersPostICEGathering option to SIP.js INVITER
Current sessionDescriptionHandlerModifiers of SIP.js acts before ICE gathering is done. This means we are not able to modify/strip candidates in local SDP.
This modifier acts on local SDP, by allowing user to modify SDP before it is sent on INVITE message.
2020-09-25 20:26:28 -03:00
Mario Jr
619ffa0ec1 Port SIP.js to 0.17.1 release
This considerably changes the way we process audio signaling and start audio elements in user's browser.
We now avoid using AudioContext element for both microphone and listenonly calls, once it is unstable for some iOS devices (cracky audio, user stops hearing audio after a while).
Increased default value for listenOnlyCallTimeout: this avoids activating FreeSWITCH's fallback when ICE negotiation takes longer than 15sec (tested on DO).
Increased listenonly logs.
This fixes #8133 #10388
2020-09-25 20:26:22 -03:00
KDSBrowne
3e8eebdd1b move random viewer selection to akka-apps 2020-09-25 19:41:30 +00:00
Anton Georgiev
2fe0530d6e Pulled HTML5 locales and tested Sept 25, 2020 2020-09-25 09:57:53 -04:00
Alexander Bias
3c88604f63
Tooltip which indicates if a presentation can be downloaded or not can be confusing - Fixes #9436 2020-09-25 14:33:01 +02:00
hiroshisuga
3af7d2cfa1
Update container.jsx 2020-09-25 09:30:40 +09:00
Anton Georgiev
ca64c7c1b2
Merge pull request #10521 from KDSBrowne/2.2-profile-messages
Remove string concatenation from webcam profile label
2020-09-24 16:19:59 -04:00
Anton Georgiev
7536419930 add log for moderator forcing end meeting 2020-09-24 14:45:52 -04:00
KDSBrowne
1dfa2ff2a8 remove string concatenation from webcam profile formatted label 2020-09-24 14:53:21 +00:00
Anton Georgiev
0794d017cd
Merge pull request #10501 from antobinary/remove-bowser
Removed unused bowser.js
2020-09-24 09:20:40 -04:00
Vitor Mateus De Almeida
69eb26f281 Merge remote-tracking branch 'upstream/develop' into debug-window 2020-09-22 09:37:42 -03:00
Anton Georgiev
124b2d9b51
Merge branch 'develop' into move-guest-wait 2020-09-21 16:28:59 -04:00
Joao Siebel
a3cf7cd98e Prevent validateAuthToken spamming.
If an ejected user tries to enter in the meeting using the current url
html5 client keep trying to validate that user, but without success
causing a validateAuthToken message spam until the connection times out.
2020-09-21 15:50:54 -03:00
Mohamed Amine Ben Salah
c87d1cacbf adds missing webcam video mirroring data-test 2020-09-21 12:07:57 -03:00
Anton Georgiev
00656ddf63 Removed unused bowser.js 2020-09-21 14:31:32 +00:00
Anton Georgiev
918f58b343 Moved the default avatar.png to be part of bigbluebutton-html5/ 2020-09-21 12:24:12 +00:00
Anton Georgiev
d5450af5df
Merge pull request #10458 from pedrobmarin/avatar-image
Support for avatar images
2020-09-21 08:22:04 -04:00
Joao Siebel
6a139aa224 Fix last name sort function for save user name 2020-09-18 18:05:31 -03:00
Joao Siebel
b2adffa4c2 Merge remote-tracking branch 'upstream/develop' into connection-manager 2020-09-18 16:30:20 -03:00
Anton Georgiev
377dc27a8d Merge branch 'v2.2.x-release' of github.com:bigbluebutton/bigbluebutton into 09-16-merge 2020-09-17 14:37:28 +00:00
KDSBrowne
239a29a341 switch sortName to name prop (shows list as names were entered) 2020-09-17 13:26:38 +00:00
Joao Siebel
087939855e fix some problems with using same user in multiple tabs 2020-09-16 09:52:44 -03:00
Pedro Beschorner Marin
e2adf24546 Support for avatar images
Use the former Flash client avatarURL join param to replace the name
initials avatar from the user list, chat, waiting guests and connection
status list.

It is possible to define a defaultAvatarURL at bbb-web and enable/disable it
2020-09-15 16:50:10 -03:00
Anton Georgiev
b26e26095e In Breakouts, Leave -> OK now closes tab 2020-09-14 11:21:11 -04:00
prlanzarin
b0ccaf330f audio-manager: shortcut on setSenderTrackEnabled when in listen only mode 2020-09-11 23:06:56 +00:00
Tainan Felipe
9275fd3922 Fix misalign in presenter useritem 2020-09-11 15:00:14 -03:00
Anton Georgiev
1d86d0ea80
Merge pull request #10341 from vitormateusalmeida/issue-10339
Fix bug when alternate panel. Fix external video size
2020-09-11 09:18:10 -04:00
Anton Georgiev
33a71e5f67
Merge pull request #10218 from Tainan404/unsafe-media-and-presentation-components
Remove unsafe lifecycle from all media and presentation components
2020-09-10 15:23:48 -04:00
Anton Georgiev
ed9c8af1e7
Merge pull request #10431 from prlanzarin/upstream-2.2-spl
screenshare: make presenter's screenshare preview local instead of remote
2020-09-10 14:40:29 -04:00
Anton Georgiev
9ccee7b7b3
Merge pull request #10434 from pedrobmarin/breakout-limit
Configurable max number of breakout rooms
2020-09-10 14:32:03 -04:00
Anton Georgiev
4ffb845402
Add ... to Webcam sharing starting notification 2020-09-10 14:11:48 -04:00
Anton Georgiev
bc668a366b
Merge pull request #10433 from prlanzarin/upstream-2.2-csm2
audio-manager: refactor client-side mute/unmute
2020-09-10 11:04:18 -04:00
Anton Georgiev
afda60ee08
Merge pull request #10425 from antobinary/locales-total
Locales revamp - support for larger spectrum of languages
2020-09-10 11:02:17 -04:00
prlanzarin
b9e1bd3e31 screenshare: cleanup on old playElement code 2020-09-10 15:01:10 +00:00
mvasylenko
7ba421cc4a Configurable max number of breakout rooms
Use this wisely: breakoutRoomLimit parameter was introduced to controll max number of breakout rooms.
2020-09-10 11:59:21 -03:00
prlanzarin
e994680e14 audio-manager: refactor client-side mute/unmute 2020-09-10 14:50:50 +00:00
Anton Georgiev
2d0e37b4a9
Merge pull request #10429 from prlanzarin/upstream-2.2-fmsmc
video-provider: fix mesh stream sorting with multiple cameras
2020-09-10 10:41:48 -04:00
Anton Georgiev
3b2446989e recalculate locales on new request if there was issue on start 2020-09-10 14:32:42 +00:00
prlanzarin
aae7a19d50 screenshare: Remove unused amIPresenter from kurentoViewScreen call 2020-09-10 14:12:44 +00:00
prlanzarin
37d21ddd97 screenshare: adjust stun fetch failure log 2020-09-10 14:11:42 +00:00
prlanzarin
18c2d33ff1 video-provider/screenshare: streamline isUserPresenter usage 2020-09-10 14:11:18 +00:00
prlanzarin
7b7c10db64 screenshare: make presenter preview local
Also some much needed code movearound in Kurento`s bridge
2020-09-10 13:48:05 +00:00
prlanzarin
259a780303 video-provider: fix mesh stream sorting with multiple cameras 2020-09-10 13:33:22 +00:00
Anton Georgiev
a151ceffad
Merge pull request #10342 from daminebenq/fix-custom-parameters-autotest
fixes custom paramters autotest
2020-09-10 08:46:00 -04:00
Anton Georgiev
068175a367
Merge pull request #10419 from daminebenq/add-webcams-layout-autotest
adds webcams layout test suite
2020-09-10 08:45:40 -04:00
Joao Siebel
ac0a014571 WIP onClose 2020-09-10 08:49:22 -03:00
Anton Georgiev
fd0e69c280 Added fallback support for Armenian, Georgian, Occitan 2020-09-10 03:21:41 +00:00
Anton Georgiev
c984967d7a Tackled numerous incorrect usage of newLine and doubleQuotes in Transifex 2020-09-10 03:02:19 +00:00
Anton Georgiev
707f80a785 Only calculate locales list once, on process start 2020-09-10 01:27:03 +00:00
Anton Georgiev
e3d1fa2c17 return all locales, not just an empty [] 2020-09-10 00:37:43 +00:00
Anton Georgiev
0c72076a37
Merge pull request #10424 from Tainan404/issue-10319-2.2
Add individual messages to video disable
2020-09-09 15:35:56 -04:00
Tainan Felipe
95ad14aa3c Rename locale 2020-09-09 16:31:20 -03:00
Anton Georgiev
f1e92341a5 Merge branch 'issue-10291' of github.com:Tainan404/bigbluebutton into locales-total 2020-09-09 19:30:52 +00:00
Anton Georgiev
d8b185f2b3 Merge branch 'issue-9219' of github.com:Tainan404/bigbluebutton into locales-total 2020-09-09 19:29:18 +00:00
Anton Georgiev
b63db3010c
Merge pull request #10423 from prlanzarin/upstream-2.2-csm
Add a client-side microphone mute/unmute
2020-09-09 15:12:24 -04:00
prlanzarin
2315208887 Remove explicit mute/unmute calls from toggle and leave them only for the voice state tracker
Should increase client-server mute state consistency
2020-09-09 18:08:11 +00:00
Tainan Felipe
1d0e5e5cdc Add individual messages to video disable 2020-09-09 15:07:32 -03:00
prlanzarin
59221530df Add a client-side mute via the sender track corresponding to the mute state
The mic mute is done client side via the track`s enabled flag, which generates silent when false. This still tracks the server/freeswitch mute state, so server-side mutes will be reproduced in the client
2020-09-09 17:03:27 +00:00
Anton Georgiev
f27872b3a0
Merge pull request #10416 from Tainan404/issue-10354
Add rtl to userItem
2020-09-09 12:21:37 -04:00
Mohamed Amine Ben Salah
b48b82330a adds webcams layout test suite 2020-09-09 12:51:56 -03:00
Anton Georgiev
deebbe5b70 Pulled HTML5 locales Sept 9, 2020 2020-09-09 10:45:27 -04:00
Mohamed Amine Ben Salah
bb6158dc0f add webcams layout talking user data test 2020-09-09 10:17:14 -03:00
Tainan Felipe
94cfcbc7fd Add rtl to userItem 2020-09-09 08:29:18 -03:00
Joao Siebel
6e4e0a510a Merge branch 'remove-user-on-exit' into connection-manager 2020-09-08 16:36:01 -03:00
Tainan Felipe
8651a02676 Add override default locale to user settings 2020-09-08 15:54:08 -03:00
Anton Georgiev
07a776ea0e
Merge pull request #10411 from jfsiebel/banned-users-log
Fix banned users log
2020-09-08 13:40:16 -04:00
Joao Siebel
96bd372f15 Fix banned users log 2020-09-08 13:56:17 -03:00
Joao Siebel
1581c71efe Normalize custom parameters by removing extra space. 2020-09-08 11:29:05 -03:00
Vitor Mateus De Almeida
ac2e57205b Fix multiple click's when try to open breakoutroom 2020-09-04 17:26:09 -03:00
Joao Siebel
700c91729e Prevent non presenters to start/stop an external video 2020-09-04 13:49:01 -03:00
Vitor Mateus De Almeida
1e3c531b76 Enable the auto arrange layout when change the presentation aspect ratio 2020-09-03 20:57:41 -03:00
Vitor Mateus De Almeida
d26de05e9f Merge remote-tracking branch 'upstream/develop' into debug-window 2020-09-03 20:36:29 -03:00
Vitor Mateus De Almeida
849bb9a469 Add debug window 2020-09-03 20:35:57 -03:00
João Francisco Siebel
52654bc927
Update bigbluebutton-html5/imports/api/external-videos/server/methods/stopWatchingExternalVideo.js
Co-authored-by: Anton Georgiev <antobinary@users.noreply.github.com>
2020-09-03 17:02:27 -03:00
Joao Siebel
5f03f23e02 Add check when start/stop an external video to prevent edge case 2020-09-03 16:07:54 -03:00
Anton Georgiev
5922a9890b
Merge pull request #10382 from KDSBrowne/2.3-issue-10372
Fix presentation width of undefined or null
2020-09-02 10:00:53 -04:00
KDSBrowne
fbf277ee76 fix width of undefined or null 2020-09-02 13:30:44 +00:00
KDSBrowne
66ee2c0e39 add breakpoints import to note styles 2020-09-01 21:20:16 +00:00
KDSBrowne
b33b5f3f01 Merge branch 'develop' of https://github.com/bigbluebutton/bigbluebutton into 2.3-remove-css-variable-duplicates 2020-09-01 21:17:25 +00:00
KDSBrowne
cf9338cb30 add breakpoint import to captions pad styles 2020-09-01 21:03:42 +00:00
KDSBrowne
77b71a4d1f fix duplicate css variables being loaded (improve imports) 2020-09-01 18:46:13 +00:00
Joao Siebel
4be9bc4c94 Adjust publishers to use auth-token-validation collection 2020-09-01 13:31:11 -03:00
Joao Siebel
2873eb2c1b Merge remote-tracking branch 'upstream/develop' into connection-manager 2020-09-01 09:08:33 -03:00
Joao Siebel
b8f42ac712 Create ClientConnections structure and auth-token-validation collection 2020-09-01 09:07:56 -03:00
KDSBrowne
03fb47842b localize text in saved names txt file 2020-08-29 16:39:29 +00:00
KDSBrowne
e4000110bb add lists sorted by first and last name to saved user names 2020-08-29 02:17:04 +00:00
Anton Georgiev
14f464087f
Merge pull request #8417 from pedrobmarin/backend-cleanup
Backend cleanup
2020-08-28 15:37:00 -04:00
KDSBrowne
e9d4f8e42c adds a select random user feature for presenter 2020-08-28 17:23:27 +00:00
Anton Georgiev
1b2d0f9f15
Merge pull request #10350 from antobinary/08-28
Update minBrowserVersions
2020-08-28 09:40:03 -04:00
Anton Georgiev
7ed6a2c083 Update minBrowserVersions 2020-08-28 09:36:59 -04:00
Mohamed Amine Ben Salah
920ff92fe5 adjusts test timeout and changed css test file name 2020-08-28 09:42:27 -03:00
Anton Georgiev
8cc8474655 Merge branch 'v2.2.x-release' of github.com:bigbluebutton/bigbluebutton into 08-26-merge 2020-08-27 19:09:07 +00:00
Anton Georgiev
3003897bfe
Merge pull request #10336 from prlanzarin/upstream-2.2-vpeg-pagination
video-provider: add missing PropType, remove render socketOpen check
2020-08-27 09:17:04 -04:00
Anton Georgiev
c14d43f3ab
Merge pull request #10335 from prlanzarin/upstream-2.2-ssisvb
screenshare: improve screenshare service findOne calls
2020-08-27 09:14:45 -04:00
Anton Georgiev
e5740b18ce
Merge pull request #10334 from pedrobmarin/v2.2.x-mute-button-status
Include voice user's upsert to changes observer
2020-08-27 09:09:33 -04:00
Vitor Mateus De Almeida
9ed9d1fd6c Fix bug when alternate panel. Fix external video size 2020-08-27 09:44:41 -03:00
Mohamed Amine Ben Salah
f547a2eba6 fixes custom paramters autotest 2020-08-27 09:44:36 -03:00
prlanzarin
395de41f60 video-provider: add missing proptype
Also trim down prop assignment in render
2020-08-27 02:20:09 +00:00
prlanzarin
191654814a video-provider: remove socket open state condition for rendering video-list
That check doesnt make sense anymore. Removing it makes the video list load faster and webcam sharing seem more responsive
2020-08-27 02:19:55 +00:00
prlanzarin
e5c1eddf88 [screenshare]: improve screenshare service findOne calls 2020-08-26 21:41:11 +00:00
Pedro Beschorner Marin
0971edfcb6 Include voice user's upsert to changes observer
We noticed that the mute action button wasn't being consistent when
using muteOnStart as meeting configuration.

Included the addition of the voice user object to the collection as
an event to also be observed.
2020-08-26 18:37:04 -03:00
Anton Georgiev
d4b82257b3
Merge pull request #10198 from daminebenq/all-in-one-autotest
fixes outdated auto tests
2020-08-25 10:59:14 -04:00
Anton Georgiev
22641c0e33
Merge pull request #10219 from Tainan404/unsafe-dropdown-components
Remove unsafe lifecycle from all dropdown related components
2020-08-25 08:54:16 -04:00
Anton Georgiev
13c939f971
Merge pull request #10324 from Tainan404/intl-fix
Fix intl loop
2020-08-25 08:44:23 -04:00
Anton Georgiev
7d9a58ac61
Merge pull request #10273 from lkiesow/modern-camera-profiles
Modern Camera Profiles
2020-08-25 08:35:25 -04:00
Anton Georgiev
1bb70a62ca
Merge pull request #10320 from prlanzarin/upstream-2.2-vpeg-pagination
video-provider: add inline docs for pagination configuration
2020-08-25 08:33:54 -04:00
Tainan Felipe
9230dfcc62 Fix wrong default setting 2020-08-25 09:29:23 -03:00
Tainan Felipe
4a81457b10 Fix comparison 2020-08-25 08:47:38 -03:00
Tainan Felipe
5956531941 Add init state for locale comparison 2020-08-25 08:36:06 -03:00
prlanzarin
81868ce922 video-provider: add inline docs for pagination configuration
Change the default page sizes for mobile to 2
2020-08-24 21:28:42 +00:00
Anton Georgiev
4476df6f09
Merge pull request #10318 from prlanzarin/upstream-2.2-vpeg-pagination
video-provider: prioritise presenter in pagination ordering, restore pre-.22 full mesh ordering
2020-08-24 17:14:43 -04:00
Anton Georgiev
b8959be312
Merge pull request #10304 from pedrobmarin/individual-video-record-control
Add individual video record control
2020-08-24 16:58:16 -04:00
prlanzarin
f3674335a4 video-provider: prioritise presenter in pagination ordering
Also restore the old full mesh, pre-.22 ordering where outbound streams were put first
2020-08-24 19:55:29 +00:00
Anton Georgiev
89319787f8
Merge pull request #10317 from prlanzarin/upstream-2.2-vpeg-pagination
video-provider: fix dynamic profile accounting when using pagination
2020-08-24 15:14:00 -04:00
prlanzarin
e7323ee6a5 video-provider: fix dynamic profile accounting when using pagination 2020-08-24 18:30:24 +00:00
KDSBrowne
6f377c3d77 make external video MATCH_URL even more generic 2020-08-24 17:59:46 +00:00
Anton Georgiev
59ab8e215d
Merge pull request #10315 from prlanzarin/upstream-2.2-vpeg-pagination
video-provider: fix pagination edge case
2020-08-24 10:42:07 -04:00
prlanzarin
2e6627b820 video-provider: fix pagination edge case where pages would be calculated as NaN 2020-08-24 14:35:28 +00:00
Pedro Beschorner Marin
8b54c01898 Add hack to avoid recording viewers video stream
If, at the time the video is shared, the user has a viewer role and
meta_hack-record-viewer-video is false this user won't have this video
stream recorded.
2020-08-22 21:00:31 -03:00
Pedro Beschorner Marin
95bc7cd59e Add individual video record control
This adds bbb_record_video userdata that, when is set to false, signals
bbb-webrtc-sfu to avoid generating the stream recording assets for a
particular user.

By default, bbb_record_video is true.
2020-08-21 19:10:25 -03:00
Anton Georgiev
b82eca1422 Pulled HTML5 locales Aug 21, 2020 2020-08-21 15:27:46 -04:00
Anton Georgiev
4fb301c48b
Merge pull request #10293 from prlanzarin/upstream-2.2-vpeg-pagination
video-provider: first tackle at video pagination
2020-08-20 15:24:57 -04:00
prlanzarin
0b29b5a812 video-provider: enrich pagination enabled checks 2020-08-20 17:26:32 +00:00
prlanzarin
a98c476239 video-provider: remove page change lock in favor of a debounced approach 2020-08-20 15:43:02 +00:00
Anton Georgiev
077f0c985a
Merge pull request #10295 from prlanzarin/upstream-2.2-fix-mirroring
video-provider: fix mirrorOwnWebcam behaviour (regression from #10208)
2020-08-20 08:39:34 -04:00
Anton Georgiev
64cc59fd4c
Merge pull request #10296 from KDSBrowne/2.2-add-slide-text-SR
Add presentation slide text for screen readers
2020-08-20 08:37:51 -04:00
KDSBrowne
916b7d7f31 add slide text for screeen reader 2020-08-20 01:48:10 +00:00
prlanzarin
5f72cecf4f video-provider: fix mirrorOwnWebcam behaviour (regression from #10208) 2020-08-20 01:12:56 +00:00
Pedro Beschorner Marin
69c408e16a Disable notes and captions footer
Something related on not being able to provide links
2020-08-19 20:27:41 -03:00
prlanzarin
bc4ce58251 video-provider: make pagination circular 2020-08-19 22:27:47 +00:00