Commit Graph

28236 Commits

Author SHA1 Message Date
Tiago Daniel Jacobs
5c911ddeec Sanitize fullName parameter of join API. Fixes #10818 2020-11-13 05:59:31 +00:00
Anton Georgiev
a8dc7a0bff Simplified redis debug and placed behind check 2020-11-12 21:03:57 -05:00
Fred Dixon
cafe1a53ce
Merge pull request #10816 from mariogasparoni/v2.2.x-release
Increase private key size for dtls-srtp.pem to 4096
2020-11-12 15:29:32 -05:00
Mario Jr
ebe9b3a789 Increase private key size for dtls-srtp.pem to 4096
Using this larger value helps reducing ocurrences 1005/1010 errors for Chrome, avoiding an openssl's error which interrupts the dtls handshake (Chrome triggers "DTLS timeout expired" error)
This key size is also the default value used by freeswitch on switch_core_cert.c
2020-11-12 16:59:45 -03:00
prlanzarin
8dda22f8a7 [html5/webrtc] Fix tryGenerateIceCandidates rejections, put it behind a flag
Fixed two occurrences where the tryGenerateIceCandidates workaround rejected without an error, which borked the callers error handling

Also put it behind a config flag. This workaround used to be important when Kurento didnt infer prflx candidates properly, but that`s no longer the case. With the flag, we can disable the workaround to see if there`s any visible regression and hopefully remove it down the road
2020-11-11 13:43:36 +00:00
Fred Dixon
fb96ffdc00
Merge pull request #10808 from prlanzarin/u22-1002-6-wa
[html5/audio] Add a configurable hackViaWs to SIP.js. Part of a workaround for #9667
2020-11-10 13:39:59 -05:00
prlanzarin
a1f0276b64 [html5/audio] Add hackViaWs to SIP.js and make it configurable in settings.yml, 1002 workaround
This adds the possibility to configure the SIP Via header to plain WS to allow reverse proxying from WSS to WS, internally, to work around a bug in freeswitch where the WSS stack would get deadlocked due to a still unidentified bug in there that has to do with SSL termination
2020-11-10 15:04:45 +00:00
Fred Dixon
6383af3667
Merge pull request #10806 from mariogasparoni/v2.2.x-release
Force using plan-b as default sdpSemantics for chrome
2020-11-09 20:03:48 -05:00
Mario Jr
b948bea11b Force using plan-b as default sdpSemantics for chrome
Although Chrome's default is now unified plan, Chrome <-> FreeSWITCH ICE connection fails for some Chrome installations (specially those running on Windows).
FS ICE fails when Chromes's SDP has "a=mid:<index>" (instead of "a=mid:audio").
This fixes Error 1010 and situations where echo test takes too long.
This fixes #6414 regression, once we do the same older version of SIP.js used to do.
2020-11-09 21:58:16 -03:00
KDSBrowne
bd4a3d2500 fix console errors in safari 2020-11-09 22:40:25 +00:00
Fred Dixon
a74f62ef44
Merge pull request #10800 from mariogasparoni/v2.2.x-release
Use iceConnectionState to monitor ICE connection status
2020-11-09 06:59:04 -05:00
Mario Jr
46e0c263fe Use iceConnectionState to monitor ICE connection status
We now use both peer's connectionstatechange and iceconnectionstatechange to monitor ICE state for audio sessions.
The same way we did with old sip.js version, we leave iceconnectionstate trigger audio actions , such as connect, disconnect, reconnect.
We still listen for 'failed' state for connectionstatechange event, because chrome triggers this (tested on 86+).
This should reduce the audio error 1010 ocurrences, once some browsers (specially Chrome/Android) don't trigger connectionstatechangeevent.
This might reduce problems reported in #10708, which still needs more investigation though.
2020-11-08 22:43:52 -03:00
Fred Dixon
83dfc99260
Merge pull request #10799 from jarmediagmbh/my-changes-branch
Remove unwanted debug logging of PDF binaries
2020-11-08 17:52:50 -05:00
Your Name
b4ecf53c80 Remove unwanted debug logging: This pushed the whole binary of every PDF uploaded into the logs. 2020-11-08 16:56:26 +01:00
Fred Dixon
97da7d6023
Merge pull request #10704 from KDSBrowne/2.2-upload-modal-error-bound
Add error boundary to presentation upload modal
2020-11-06 16:40:50 -05:00
Richard Alam
e28bba42fc
Merge pull request #10742 from KDSBrowne/2.2-issue-10705
Prevent users from sending multiple votes per poll
2020-11-06 16:33:56 -05:00
Fred Dixon
a5b0d0318d
Merge pull request #10796 from KDSBrowne/2.3-issue-10779
Fix actions bar buttons not being clickable on iPad
2020-11-06 15:52:36 -05:00
KDSBrowne
42cdc51710 add z-index to actionbar elements 2020-11-06 20:48:06 +00:00
Fred Dixon
7ba1ce721b
Merge pull request #10790 from mariogasparoni/v2.2.x-release
Correctly Map Websocket error and better monitoring of ICE events
2020-11-06 08:50:27 -05:00
Mario Jr
3a689578c6 Monitor peer's iceconnectionstatechange event
This gives more information about ICE connection, combined with onconnectionstatechange event
2020-11-06 09:37:58 -03:00
Mario Jr
2585d957e8 Correctly map WebSocket error
Maps WebSocket's 1006 error to BBB's 1002, the same way it was done with old sip.js version
Set user agent's number of reconnection attempts to the same value as older sip.js version
2020-11-06 09:25:40 -03:00
KDSBrowne
50f85ff2e2 make responders private | add accessors 2020-11-05 19:24:10 +00:00
KDSBrowne
2468ac225c return null in publishVote if user already voted 2020-11-05 17:02:31 +00:00
KDSBrowne
5076a2accd fix typo / use operator / add log 2020-11-05 14:19:36 +00:00
KDSBrowne
2f46c1fd28 Merge branch 'develop' of https://github.com/bigbluebutton/bigbluebutton into 2.3-user-rand-select 2020-11-02 16:16:29 +00:00
Anton Georgiev
6fe983af6d
Merge pull request #10754 from KDSBrowne/2.2-issue-10748
Fix presentation downloadable tooltip label
2020-10-30 09:47:45 -04:00
KDSBrowne
7c690ab22c fix presentation downloadable tooltip msg 2020-10-30 13:00:07 +00:00
Fred Dixon
f23490ccf8
Merge pull request #10744 from bigbluebutton/fix-soffice-image-build
Avoid cache usage when building docker image
2020-10-28 18:13:41 -04:00
Tiago D J
3bcd41fd7b
Avoid cache usage when building docker image 2020-10-28 16:50:08 -03:00
Anton Georgiev
5ba12846d5
Update index.js 2020-10-28 15:17:17 -04:00
KDSBrowne
d2cb02b3bd prevent users from being able to send more than 1 poll vote 2020-10-28 18:33:09 +00:00
Anton Georgiev
b17f54283a
Merge pull request #10741 from mariogasparoni/v2.2.x-release
Properly stops userAgent / peer when audio connection/reconnection fails
2020-10-28 14:13:14 -04:00
Mario Jr
3e3b648040 Properly stops userAgent / peer when audio connection/reconnection fails
Changed the maximum attempts of the UserAgent reconnection (this should be changed when binding audio's websocket to meteor's connection state).
Added a log to monitor WS reconnect attempts.
2020-10-28 15:04:30 -03:00
Anton Georgiev
df8b6350c9
Merge pull request #10617 from KDSBrowne/2.3-undo-pencil
Fix broken undo of consecutive pencil annotations
2020-10-27 14:59:57 -04:00
Anton Georgiev
95372c1c94
Merge pull request #10618 from daminebenq/add-visual-regressions-testing
Adds visual regression testing
2020-10-27 12:49:18 -04:00
Mohamed Amine Ben Salah
bf45dbc7f9 adds visual regressions test with snapshots ready to use 2020-10-27 12:54:55 -03:00
Mohamed Amine Ben Salah
f0a0e21972 Merge remote-tracking branch 'upstream/develop' into add-visual-regressions-testing 2020-10-27 12:52:59 -03:00
Anton Georgiev
24442f1050
Merge pull request #10369 from jfsiebel/connection-manager
Add ClientConnection manager
2020-10-27 11:49:35 -04:00
Anton Georgiev
95a3496437
Merge pull request #10734 from daminebenq/updated-develop
Update Jest ^23.5.0 > ^26.6.1
2020-10-27 11:12:39 -04:00
Mohamed Amine Ben Salah
aee7534c9e update Jest ^23.5.0 > ^26.6.1 2020-10-27 12:09:24 -03:00
Fred Dixon
4f62decf4f
Merge pull request #10730 from ffdixon/bbb-conf-libreoffice
Bbb conf libreoffice
2020-10-26 21:45:33 -04:00
Fred Dixon
74186dcd0e Don't check for libreoffice on bionic 2020-10-26 20:43:58 -05:00
Fred Dixon
5e1a63ae3d Fix merge conflict 2020-10-26 20:42:08 -05:00
Anton Georgiev
b808b0185f
Merge pull request #10728 from antobinary/jquery
Move the check to disable mutedAlert feature; temp disable it
2020-10-26 17:12:03 -04:00
Anton Georgiev
ce8c733ec4 move the check to disable mutedAlert feature; temp disable it 2020-10-26 21:07:15 +00:00
Joao Siebel
91c8e78d44 Fix join listen only problem 2020-10-26 13:10:40 -03:00
Anton Georgiev
b8649629eb
Merge pull request #10702 from Zh4rsiest/develop
[Mobile] - Setting or clearing user status locks the whole screen
2020-10-26 11:29:11 -04:00
Anton Georgiev
8966fbf89a
Merge pull request #10718 from mariogasparoni/v2.2.x-release
Prevent 1005 error log when user close/reload bbb's window/tab
2020-10-26 10:37:30 -04:00
Mario Jr
d1e5f189ba Prevent 1005 error log when user close/reload bbb's window/tab
When closing/reloading tab with active microphone, audio exits successfully but a wrong log-error (1005) is shown.
We now process closing/reloading tab the same way we do when user hangup the call.
2020-10-25 16:12:58 -03:00
Anton Georgiev
e63c49e515
Merge pull request #10716 from mariogasparoni/v2.2.x-release
Change default value of iceGatheringTimeout to current's SIP.js default
2020-10-24 08:27:35 -04:00