BigBlueButton/bigbluebutton-Github
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
37,637 Commits 13 Branches 260 Tags 1.1 GiB
6ef4781ad1
Commit Graph

11551 Commits

Author SHA1 Message Date
Anton Georgiev
730e1e26e4
Merge pull request #17496 from gustavotrott/set-ismobile-on-akkaapps 
refactor: Stores user-isMobile flag in akka-apps (instead of only in Meteor/Mongo)
 2023-04-12 07:30:08 -04:00
Anton Georgiev
abc94a2906
Merge pull request #17495 from gustavotrott/pick-usercolor-on-akkaapps 
refactor: Moves user color picker to akka-apps (instead of meteor-backend)
 2023-04-12 07:08:35 -04:00
prlanzarin
b17ba35238 fix(audio): decouple remote media setup (play) from state callback 
Audio state callback and remote media setup both depend on FS's state
(comes through Meteor) and the ICE state (local, peer connection). The
caveat: FS's state can come delayed on reconnection scenarios because
Meteor's websocket generally takes significantly longer to re-connect than
the peer connection, which means the ICE state gets completed way before FS
is flagged as ready.
The practical issue: while outbound audio (client -> FS) will work, inbound
audio (FS -> client) won't _just because it wasn't played_ (even though
data is  coming through).

This commit decouples the remote media setup step from the state
through:
  - Setup remote media when ICE state is completed
  - Run the state callback only after FS is flagged as ready. This
    should maintain the UI states consistent across client-server.
    Keep in mind the assumption that if FS is ready, ICE is completed by
    consequence.
 2023-04-11 16:02:20 -03:00
prlanzarin
fb30b145af refactor: remove unused VU ejection on socket disconnection 
The voice user ejection callback tethered to Meteor's socket
disconnection seems broken (since its introduction). The VU selector
uses an invalid field (requesterUserId) - so no VU is ever returned.

Since I'm unaware of the original goal behind this code and there's
already ejections in place in other components (akka-apps, for
instance), this is basically a revert of #9888.
 2023-04-11 15:58:22 -03:00
prlanzarin
a47ef9c244 fix(audio): add default device placeholder in input-stream-live-selector 
Handles scenarios where setSinkId is not supported and use a placeholder Default device label
 2023-04-11 15:48:02 -03:00
Ramón Souza
fb308f0a60
Merge pull request #17397 from hiroshisuga/dev2.6.1_tooltip 
[2.6 fix] Show the pan tool tip at the same timing and position as other tools
 2023-04-11 13:18:18 -03:00
Anton Georgiev
94de530108
Merge pull request #17509 from KDSBrowne/bbb-imp-chat-sr 
fix(access): Remove Aria-Live From Chat Area
 2023-04-11 11:40:07 -04:00
GuiLeme
5eb29e0ab5 [issue-16954] - merge upstream/v2.7.x-release 2023-04-11 11:02:00 -03:00
Tainan Felipe
81914279b6 WIP: Move Icon and Tooltip to common components 2023-04-11 10:10:02 -03:00
prlanzarin
5d214cb27d fix(video): ensure streams are always attached on reconnections 
There's a scenario where remote streams won't be attached again if the
sharer experienced a Meteor/client disconnection.
The disconnection empties some necessary user data temporarily, which
causes the corresponding video-list-item to be unmounted while the peer
persists for a little longer.
If the sharer re-connects fast enough, video-list-item will re-mount but
will 1) miss the current stream state (ie stuck in loading) 2) fail to
re-attach the streams since the peer was already flagged as attached.

Ensure remote camera streams are always attached and shown by:
  - always propagating the current stream state on attachment
  - refactoring the attachment pre-requisites away from a static boolean
    to a required data + diff check (based on target and current
    attached streams)
 2023-04-11 09:36:13 -03:00
Paulo Lanzarin
67e4a9ebf3
Merge pull request #17394 from schrd/fix-issue-16057 
Fix: Workaround firefox' missing audio output selection
 2023-04-11 09:04:23 -03:00
Ramón Souza
95f4212c59
Merge pull request #16115 from KDSBrowne/dev26-link-nl 
fix: Handle External Video Links On Multi Lines In Smart Slides
 2023-04-11 09:04:13 -03:00
Daniel Schreiber
68c583f53e Fix: Workaround firefox' missing audio output selection 
Firefox does not support selecting an audio output device in its default
configuration. This works around this flaw by just displaying default
output instead of no device found.

Fixes #16057
 2023-04-11 10:41:32 +02:00
Carlos
1f16c8b483 fix(screenshare) autoplay overlay 
Changed z-index of autoplay overlay.
 2023-04-10 16:51:20 -03:00
Scroody
5b0bc16e5c Fix: Presentation unminimizing when exiting external video or screen share. 2023-04-10 16:25:19 -03:00
Scroody
69f39da665 Fix: Poll results not appearing. 2023-04-10 11:17:35 -03:00
Ramón Souza
d70788e832
Merge pull request #17060 from hiroshisuga/testHideTools 
[2.6] Hide tldraw toolbar
 2023-04-10 08:51:53 -03:00
Gustavo Trott
0b2bf8f68b Akka-apps will set mobile flag instead of Meteor 2023-04-06 17:43:57 -03:00
Ramón Souza
abbe64ab16
add missing await 2023-04-06 17:04:47 -03:00
Gustavo Trott
0630fb05ea Moves user color picker to akka-apps instead of meteor-backend 2023-04-06 16:39:05 -03:00
Scroody
958170bf8a Fix: Warnings when creating new meetings solved. 2023-04-06 16:22:21 -03:00
Ramón Souza
ca668f165e
Merge branch 'v2.6.x-release' into meteor-migration 2023-04-06 16:06:10 -03:00
Ramón Souza
17f428d0af
Merge pull request #17486 from danielpetri1/blank-space 
fix(bbb-html5): Maximize webcams when removing all presentations
 2023-04-06 13:17:52 -03:00
Anton Georgiev
72c575b911 Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into merge-apr-6 2023-04-06 11:50:26 -04:00
danielpetri1
eb9b12a581 No blank space in sidebar 2023-04-06 14:37:34 +00:00
Ramón Souza
030384b165
Merge pull request #17382 from KDSBrowne/bbb-imp-menu-access 
fix(access): Keyboard Navigation With Arrows Only In Dropdown Menus
 2023-04-06 09:33:37 -03:00
Ramón Souza
cd7fc0b11f
Merge pull request #17392 from KDSBrowne/bbb-17164 
fix: Preserve Tool & Style Settings On Page Change
 2023-04-06 09:09:51 -03:00
Anton Georgiev
e2dc7da98a
Merge pull request #16828 from prlanzarin/u27/fix/ss-cam-reconn 
fix: re-connection improvements for cameras and screen sharing
 2023-04-05 16:13:01 -04:00
Anton Georgiev
14b1abb6e4
Merge pull request #17114 from prlanzarin/u26/fix/echo-switch-output 
fix(audio): output device changes not effective in local echo test
 2023-04-05 16:11:28 -04:00
Anton Georgiev
124ab8d972
Merge pull request #17468 from prlanzarin/u26/feat/sfu-gather-block 
feat: add option to force/extend gathering window in SFU components, +
 2023-04-05 15:52:10 -04:00
Tainan Felipe
026d9ef3eb Merge branch 'pull-17124' into apollo-client 2023-04-05 16:25:19 -03:00
Tainan Felipe
e18059fffa WIP: Initial implementation of graphql in user list 2023-04-05 16:18:04 -03:00
Anton Georgiev
f6004b477c
Merge pull request #17340 from KDSBrowne/bbb-16951 
fix: Handle Exception While Invoking ZoomSlide
 2023-04-05 15:17:26 -04:00
Anton Georgiev
173ca01519
Merge pull request #17344 from KDSBrowne/bbb-17331 
fix: Move Setting isForcePanning To Patch Event
 2023-04-05 15:16:29 -04:00
Anton Georgiev
cc820ad02d
Merge pull request #17370 from Scroody/I-17330 
Fixed: Error when trying to apply custom styles via URL.
 2023-04-05 15:15:57 -04:00
Ramón Souza
92275c4e49
Merge pull request #17455 from Scroody/I-17403 
Enhancement: Unread and read privet chats now order by unread and alphabetical order.
 2023-04-05 15:36:17 -03:00
Scroody
4696503c81 Add: Order priority by number of unread messages. 2023-04-05 15:20:49 -03:00
Ramón Souza
10a00d8e05
Merge pull request #17427 from Scroody/fix-bbb-tips 
Fix: BBB tips overlapping other elements out of his own box
 2023-04-05 15:18:48 -03:00
Gustavo Trott
be4bac6037 Merge with v2.7.x-release 2023-04-05 15:05:16 -03:00
Anton Georgiev
29f9bc47bd
Merge pull request #17436 from Carloshsc/bug-waiting-for-approval 
fix(reconnect): Fix waiting for approval
 2023-04-05 13:56:23 -04:00
Scroody
8bacc855a6 Fix: bug in animation caused by CSS overflow. 2023-04-05 14:46:22 -03:00
Ramón Souza
5d960887d2
Merge pull request #17395 from hiroshisuga/dev2.6.1_toolbarhover 
[2.6 fix] recover hover effect on icons of whiteboard toolbar
 2023-04-05 14:43:45 -03:00
prlanzarin
f4b4de6f88 fix(video): prevent a client crash when cleaning up video peers 
There's a very rare scenario where the client may crash if a video
publisher is released before the source stream had its inactivation
listener callback set up.

This adds a type check to the inactivation handler before trying to
clean it up.
 2023-04-05 13:31:59 -03:00
prlanzarin
c81a7e70f2 fix: properly check constraints before creating transceivers in peer.js 
In peer.js offer generation method, the provided constraitns are only
being type checked. It needs a value check when the constraint is a
boolean.

This commit should prevent useless transceivers from being added when
explictly specifying audio/video as `false`
 2023-04-05 13:30:30 -03:00
prlanzarin
be6a23a003 feat: add option to force/extend gathering window in SFU components 
There's an edge case in finnicky networks where ALG-like firewalls
tamper with USE-CANDIDATE STUN packets and, consequently, bork ICE-lite
connectivity establishment. The odd part is that client-side gathering
seems to complete if intermediate STUN bindings work (before the final
USE-CANDIDATE), which may cause the peer not to generate relay
candidates == connectivity fails.

This adds the `public.kurento.gatheringTimeout` option to forcefully extend
the candidate gathering window in peers that act as offerers. The
behavior is as follows: if the flag is set (ms), the peer will wait
either the gathering completed stage or, _at most_,
public.kurento.gatheringTimeout ms before proceeding with calls chained
to setLocalDescription.

This option is disabled by default and intentionally ommited from the
base settings.yml file as to not encourage its use. Don't use it unless
you know what you're doing :).
 2023-04-05 13:22:38 -03:00
Ramón Souza
a4c074658e
Merge pull request #17434 from ramonlsouza/fix-cam-position-sidebar 
fix: camera position when notificationBar appears
 2023-04-05 13:03:31 -03:00
danielpetri1
b91e766184 Maximize webcams when all presentations removed 2023-04-05 15:37:56 +00:00
Ramón Souza
20f020a7b2 replace react-color with react-colorful 2023-04-05 10:49:07 -03:00
Scroody
868ee54371 Enhancement: Unread and read privet chats now order by unread and alphabetical order. 2023-04-05 10:38:59 -03:00
Ramón Souza
7438f100fe remove new instances of lodash methods 2023-04-05 09:44:47 -03:00
Ramón Souza
bcd504b749 Merge remote-tracking branch 'upstream/v2.7.x-release' into lodash-radash 2023-04-05 09:42:05 -03:00
Carlos
39b308b91f fix(reconnect) waiting for approval 
Removed code that enter the old status "waiting for approval".
 2023-04-04 10:47:32 -03:00
Ramón Souza
caddf61259 fix camera position when notificationBar appears 2023-04-04 09:34:00 -03:00
hiroshisuga
b3e6cf0c78
Fix a bug 
Clicking the presentation with the pan tool selected grayed the presentation.
 2023-04-04 17:40:21 +09:00
hiroshisuga
4d2c6fecc0
lower case to avoid warning 2023-04-04 12:09:45 +09:00
hiroshisuga
5bc2976328
lower case to avoid warning 2023-04-04 12:08:35 +09:00
hiroshisuga
09460c3de0
Fix toggle animation setting 
ignore the update if "delay" prop is set for the pan tool.
 2023-04-04 11:03:51 +09:00
Scroody
356cf73f3c Fix: BBB tips overlapping other elements out of his own box 2023-04-03 15:10:22 -03:00
Ramón Souza
62e9b3a4d6
Merge pull request #17381 from Scroody/drop-down-arrow 
style: drop down arrow better centralized.
 2023-04-03 09:45:22 -03:00
hiroshisuga
58ef3c6a5a
add props to tooptip component 2023-04-03 17:13:54 +09:00
hiroshisuga
f6d401b502
add props to button component 2023-04-03 17:11:37 +09:00
hiroshisuga
828f692d7b
add two props to pan injector 2023-04-03 17:09:53 +09:00
hiroshisuga
d873156ed8
Update styles.js 2023-04-03 00:30:22 +09:00
hiroshisuga
2a31b1e0ee
Update styles.js 2023-04-03 00:13:44 +09:00
hiroshisuga
5be3e2ef1c
Update component.jsx 2023-04-02 23:42:12 +09:00
hiroshisuga
476c31a912
Update component.jsx 2023-04-02 23:39:41 +09:00
hiroshisuga
8b92b444ca
Update styles.js 2023-04-02 23:38:32 +09:00
KDSBrowne
a0f6bfcff2 fix the need to double click on style items 2023-04-01 21:05:27 +00:00
KDSBrowne
da66eeccc4 Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into bbb-17164 2023-04-01 20:22:50 +00:00
KDSBrowne
9abc00bcbc preserve tool and style setting on page change 2023-04-01 20:18:03 +00:00
KDSBrowne
f32ac70a7b remove unneeded aria-live area's 2023-04-01 20:10:41 +00:00
Scroody
4b965a2a71 Migration of the API to async for Meteor3.0 2023-03-31 17:40:41 -03:00
KDSBrowne
b3a6c0be98 remove aria-live from chat message list wrapper 2023-03-31 19:38:34 +00:00
KDSBrowne
9fbf5c2fde fix keyboard navigation in dropdown menus 2023-03-31 18:06:41 +00:00
imdt
90ea2bd98e Usability: drop down arrow better centralized. 2023-03-31 13:19:15 -03:00
Anton Georgiev
a6b5375391
Merge pull request #17377 from paultrudel/remove-client-config-service 
refactor(bbb-web): Remove Client Config Service
 2023-03-31 09:33:50 -04:00
imdt
7d117e3dd6 Fixed: Error when trying to apply custom styles via URL. 2023-03-30 17:00:41 -03:00
Anton Georgiev
2e424bd2d4
Merge pull request #15680 from antonbsa/webcam-tests 
test: Webcam tests additions
 2023-03-30 12:12:58 -04:00
Anton Georgiev
77c5c27153
Merge pull request #17239 from danielpetri1/content-capture-toast-fix 
fix(bbb-html5): Dismiss uploading toast after content capture
 2023-03-30 09:29:30 -04:00
Anton Georgiev
71b07e5cd9
Merge pull request #17054 from paultrudel/allow-mods-unmute-users-fix 
fix: Recover broken allowModsToUnmuteUsers functionality
 2023-03-30 09:11:48 -04:00
Anton Georgiev
eecde552ce Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into mar-30-1 2023-03-30 08:47:07 -04:00
Ramón Souza
9684847ae7
Merge pull request #17361 from Scroody/I-17351 
Fixed: Error message on layout change.
 2023-03-30 09:09:08 -03:00
Ramón Souza
671d9a589e
Merge branch 'v2.6.x-release' into I-17081 2023-03-30 08:58:58 -03:00
imdt
573c8a47a9 Fixed: another bug cause by undo related to the one solved initial PR. 2023-03-29 16:30:32 -03:00
Anton Georgiev
279ee3211d
Merge pull request #17345 from antobinary/fix-const 
fix: fix some code smell by adding const for variables
 2023-03-29 15:22:40 -04:00
GuiLeme
280a65b3fe [issue-16954] - revert config 2023-03-29 15:57:11 -03:00
imdt
0b34b4e971 Fixed: Error message on layout change. 2023-03-29 15:38:55 -03:00
GuiLeme
93cd3268c4 [issue-16954] - remove of console.log 2023-03-29 12:37:31 -03:00
Paul Trudel
f11eac6064 Re-removed userLocked check from allowedToUnmuteAudio 2023-03-29 14:50:53 +00:00
GuiLeme
a277e77718 [issue-16954] - Adjusting modal priorities and refactor of code 2023-03-29 11:38:48 -03:00
Anton B
3a7b59c19a test: add video quality and background webcam tests 2023-03-29 11:16:47 -03:00
GuiLeme
81ae4e9ca6 [issue-16954] - Adjusting modal priorities 2023-03-29 11:08:56 -03:00
GuiLeme
9b39decec7 [issue-16954] - Fix minor issues and cleanning of the old modal structure traces 2023-03-29 11:02:14 -03:00
Anton B
4b5d4e9e2a Merge remote-tracking branch 'upstream/v2.6.x-release' into webcam-tests 2023-03-29 10:29:58 -03:00
Ramón Souza
ab8d9214af fix empty slide on presentation change 2023-03-29 09:35:10 -03:00
Paul Trudel
4b24e037f2 Changed value of userLocked 2023-03-28 21:26:40 +00:00
Paul Trudel
d5f8650666 Added userLocked check to allowedToUnmuteAudio check 2023-03-28 21:24:58 +00:00
Paul Trudel
4142917f57 Re-added check for user lock to unmute 2023-03-28 18:50:16 +00:00
Paul Trudel
349886b3b1 Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into allow-mods-unmute-users-fix 2023-03-28 17:52:43 +00:00
Anton Georgiev
e654c390b7 fix: fix some code smell by adding const for variables 2023-03-28 13:25:59 -04:00