Commit Graph

13571 Commits

Author SHA1 Message Date
Ramón Souza
699c056709 add names to queries 2024-05-07 13:26:56 -03:00
Gustavo Trott
4b91675658
Merge pull request #20168 from JoVictorNunes/grid-user-limit
fix: limit grid users at the data access level
2024-05-07 09:16:42 -03:00
Ramón Souza
78d237502b
Merge pull request #20128 from Scroody/fix-external-video-presenter-change
Fix: External video re-starting when changing presenters
2024-05-06 15:56:13 -03:00
Ramón Souza
a41f09c18a
Merge pull request #20167 from ramonlsouza/fix-custom-logo
fix: custom logo
2024-05-06 10:48:08 -03:00
Ramón Souza
c1e6d21149
Merge pull request #20173 from ramonlsouza/warnings-may3
fix: client warnings
2024-05-06 10:48:00 -03:00
Ramón Souza
cfab7a82e9
Merge pull request #20120 from KDSBrowne/v30-19547
fix(whiteboard):  Stop Loading Tldraw Assets From Unpkg Site
2024-05-06 10:45:33 -03:00
João Victor
fc8e59bfba fix(webcam): lint errors 2024-05-06 09:19:51 -03:00
João Victor
0003252207 fix(webcam): remove useless data consumption 2024-05-06 09:13:24 -03:00
João Victor
49f236ee3c Merge branch 'v3.0.x-release' into grid-user-limit and fix conflicts 2024-05-06 09:01:39 -03:00
João Victor Nunes
83f6f8d0f9
fix: order grid items by both name and userId
Co-authored-by: Gustavo Trott <gustavo@trott.com.br>
2024-05-06 08:23:55 -03:00
Ramón Souza
f742a6d25d
Merge pull request #20134 from JoVictorNunes/video-streams-typings-fix
fix: tweak video-streams typings
2024-05-03 17:19:52 -03:00
João Victor
9e0ea8a33f fix(webcam): rename query variable 2024-05-03 16:35:56 -03:00
João Victor Nunes
4f9e75ae0c
fix(webcam): remove loggedOut filter
Co-authored-by: Gustavo Trott <gustavo@trott.com.br>
2024-05-03 16:33:13 -03:00
João Victor
6aa1e0f336 Remove isGridItem field 2024-05-03 15:34:10 -03:00
João Victor
fb1947dc8f Remove console.log's 2024-05-03 15:11:30 -03:00
João Victor
65ac5b6b9b fix(webcam): avoid sending a negative value for grid user limit 2024-05-03 14:33:04 -03:00
Ramón Souza
2e7608e653 fix currentPageShapes prop type warning 2024-05-03 13:05:31 -03:00
Ramón Souza
967ae9ddcc fix undefined label in leave meeting button warning 2024-05-03 13:02:53 -03:00
Gustavo Trott
16800ce8ef Merge remote-tracking branch 'upstream/v3.0.x-release' into client-settings-cache-system 2024-05-03 12:05:41 -03:00
Ramón Souza
8e728d2cc4
Merge pull request #20019 from Scroody/fix-volume-bar-overlap
Fix: Volume bar overlapping
2024-05-03 11:24:03 -03:00
André
8c57f63bb9 Later changes 2024-05-03 10:34:35 -03:00
João Victor
ca5d74e9d4 fix(webcam): type user as partial 2024-05-03 10:29:25 -03:00
André
4c0df76b23 Merge remote-tracking branch 'upstream/v3.0.x-release' into fix-volume-bar-overlap 2024-05-03 10:29:00 -03:00
Gustavo Trott
ea82508b5d introduces a nginx cache for /api/rest/(clientStartupSettings|clientSettings) 2024-05-03 10:27:26 -03:00
André
cbd06c0790 Side effect solving 2024-05-03 10:22:16 -03:00
Ramón Souza
9307b33a4e fix undefined isPresenter warning 2024-05-03 10:07:26 -03:00
Anton Georgiev
205d110f5b
Merge pull request #20104 from Tainan404/remove-redis
!remove: Frontend Redis client listener
2024-05-03 09:02:08 -04:00
Ramón Souza
c951acc3bb fix undefined isTimerActive warning 2024-05-03 09:59:57 -03:00
João Victor
2dddd161bf fix: limit grid users at the data access level 2024-05-03 09:58:27 -03:00
Anton Georgiev
d19677d5a3
Merge pull request #20166 from prlanzarin/u30/fix/review-mobile-audio-chevron
fix(audio): review device selection in mobile endpoints
2024-05-03 08:56:51 -04:00
Anton Georgiev
d85561b17b
Merge pull request #20164 from prlanzarin/u30/fix/Arthurk12-live-1809
fix(bbb-html5): correct parameter type for wake lock log codes
2024-05-03 08:56:03 -04:00
Anton Georgiev
0e68003c08
Merge pull request #20163 from prlanzarin/u30/fix/assorted-br-crashes
fix: undefined accesses causes crashes in actions-bar breakout utils
2024-05-03 08:55:43 -04:00
Anton Georgiev
0df167180e
Merge pull request #20162 from prlanzarin/u30/fix/ff-pairselection
fix(audio): broken connection stats on Firefox >= 125
2024-05-03 08:53:40 -04:00
Anton Georgiev
05d8f9110b
Merge pull request #20161 from prlanzarin/u30/fix/arthurk12-undefined-role-crash
fix: add safeguards when returning user roles
2024-05-03 08:53:01 -04:00
Anton Georgiev
7c407567e1
Merge pull request #20160 from prlanzarin/u30/fix/arthurk12-screenreader-crash
fix(screen-reader): add safeguards for adding alerts
2024-05-03 08:52:45 -04:00
Anton Georgiev
70e4ab1f66
Merge pull request #20159 from prlanzarin/u30/fix/onconnectionstatechange-crash-rc
fix(bbb-html5): crash when stopping WebRTC peers
2024-05-03 08:52:28 -04:00
Anton Georgiev
3babf4c16e
Merge pull request #20158 from prlanzarin/u30/fix/crash-videoprovider-onmessage
fix(bbb-html5): crash on video-provider unmount
2024-05-03 08:51:58 -04:00
Anton Georgiev
84fd90bc49
Merge pull request #20157 from prlanzarin/u30/fix/crash-getBoundingClientRect-emojirain
fix(reactions): crash when interactionsButton coords are absent
2024-05-03 08:49:42 -04:00
Anton Georgiev
9d99f7f78b
Merge pull request #20156 from prlanzarin/u30/fix/audio-answerer-gum-failure
fix(audio): acquire streams before negotiation when peer is answerer
2024-05-03 08:49:08 -04:00
Ramón Souza
35af05e594 fix custom logo 2024-05-03 09:31:18 -03:00
prlanzarin
a21addfa1f fix(audio): review device selection in mobile endpoints
Mobile users have no way to change I/O devices after joining audio.
The removal of the audio options chevron in mobile browsers was supposed
to be replaced by something else - in this case, by the dedicated
leave/join audio button. That didn't happen, leave/join audio button
retained the old behavior.

Review device selection in mobile endpoints via two UI/UX changes:
  - Fix an styling issue where the mute and listen only buttons were
    crammed together
  - Restore the device selection chevron/icon in mobile endpoints
  - Override the leave/join button action in mobile endpoints so that it
    opens the device selection contextual menu, which also includes the
    "Leave audio" option. This retains the old behavior (leaving audio)
    while also providing an way for users to change devices mid-call in
    mobile browsers.
2024-05-03 01:32:01 +00:00
Arthurk12
31a6527cca fix(wake-lock): correct parameter type for log code
Previously, an object was incorrectly passed as the log code parameter.
Fixes it by ensuring that a string is passed instead.
2024-05-03 00:06:07 +00:00
prlanzarin
cea92631fa fix: undefined accesses causes crashes in actions-bar breakout utils
Multiple undefined accesses in actions-bar's service, mainly related to
breakouts and ageneral Meetings info, cause crashes in production
environments - most likely in reconnection scenarios.

Guarantee that nested data is safely accessed.
2024-05-02 23:50:56 +00:00
prlanzarin
20daf56390 fix(audio): broken connection stats on Firefox >= 125
WebRTC-based stats generation in the connection status modal is broken
on Firefox >= 125. A broken type check coupled with a new partially
implemented RTCIceTransport dictionary causes and undefined function
call when fetching the selected candidate pair. Since that error is
unhandled, collection breaks.

Correctly check for the getSelectedCandidatePair method availability in
RTCIceTransport so that it skips to pair inference from getStats if
necessary.
2024-05-02 23:37:44 +00:00
Arthurk12
148c25e2cb fix: add safeguards when returning user roles 2024-05-02 23:35:45 +00:00
Arthurk12
9947aa451e fix(screen-reader): add safeguards for adding alerts
Adds checks for the alert's text and DOM element before adding screen
reader alerts.
2024-05-02 23:06:55 +00:00
prlanzarin
85cdc7cc2a fix(bbb-html5): crash when stopping WebRTC peers
There's a race condition that may cause a client crash whenever a
connectionstatechange callback is cleaned up in a peer without a
valid peer connection present in our custom RTCPeerConnection wrapper.

Check for peerConnection availability in the WebRtcPeer wrapper before
trying to clean up its connectionstatechange callback.
2024-05-02 22:59:39 +00:00
prlanzarin
eccb06369b fix(bbb-html5): crash on video-provider unmount
There's a race condition that may cause a client crash whenever a
video-provider's unmount procedure is run, but its signalling websocket
is undefined. The WS's callback handlers are re-assigned without
checking for the socket's availability, causing an unhandled TypeError.

The WS may be undefined in a couple of scenarios, e.g.: unmouting before
the socket was successfully set up, unmounting while a reconnect is in
place etc.

Check whether the socket exists before accessing it in video-provider's
componentWillUnmount routine.
2024-05-02 22:55:25 +00:00
prlanzarin
cfa013fdaa fix(reactions): crash when interactionsButton coords are absent
The client may crash whenever a emoji rain animation is triggered, but
the interactions button element cannot be located. This happens because
the button coordinates are fetched without checking whether the element
exists.

Get the coordinate fetching method to return null if the
interactionsButton element cannot be located, and ignore the emoji rain
action if that is the case. Whenever no valid coordinates are found, log
an warning so we can track this and figure out what's happening with the
button.

Fix a few typos in the getInteractionsButtonCoordinates method.
2024-05-02 22:32:09 +00:00
prlanzarin
00a2ab52a5 fix(audio): acquire streams before negotiation when peer is answerer
When a sendrecv peer acts as the answerer, gUM is only called _after_
the remote offer is received. This is fine, but the error handling runs
different in that scenario in a way that eventual gUM errors are treated
as negotiation errors, leading to inconsistencies when surfacing the
error to end users.

If a peer is acting as answerer and is a transceiver, acquire the local
streams _before_ actual negotiation so that gUM errors are surfaced
correctly (and we spare uneeded negotiation steps).
2024-05-02 22:27:16 +00:00