Commit Graph

9128 Commits

Author SHA1 Message Date
Paulo Lanzarin
65c359a79c
audio: change default SDP format to Unified Plan
Making the default transition a bit earlier so that we can field trial it just to be sure enough it's safe.
2021-03-24 12:16:13 -03:00
Anton Georgiev
7398e005e8
Merge pull request #11725 from Tainan404/fix-chat-reconnection
Fix reactive issue with reconnection
2021-03-24 10:25:51 -04:00
Pedro Beschorner Marin
0c4cf0135d Handle pad's events and Meteor's instances
Since Meteor was split in multiple process and events started to be
filtered by instances, all Etherpad's Redis events were being discarded.

Etherpad has a Redis' publisher plugin that is unaware of BigBlueButton's
existence. All the communication between them is kept simple with minimal
of internal data exchange. The concept of distincts subscribers at Meteor's
side broke part of this simplicity and, now, Etherpad has to know which
instance must receive it's messages. To provide such information I decided
to include Meteor's instance as part of the pad's id. Should look like:

 - [instanceId]padId for the shared notes
 - [instanceId]padId_cc_(locale) for the closed captions

With those changes the pad id generation made at the recording scripts had to
be re-done because there is no instance id available. Pad id is now recorded at
akka-apps and queried while archiving the shared notes.
2021-03-23 18:03:50 -03:00
Ramon Souza
4cca83b202 fix userlist rtl/ltr when language is changed 2021-03-23 17:30:51 -03:00
Tainan Felipe
36c1abc890 Fix reactive issue with reconnection 2021-03-23 17:30:38 -03:00
Mario Jr
af4f9dbf26 Merge branch 'v2.2.x-release' into merge-2.2-develop 2021-03-23 17:10:28 -03:00
Anton Georgiev
8f3140897d
Merge pull request #11709 from jfsiebel/invalidated-logged-out-user
Prevent logged out user to spam validateAuthToken
2021-03-23 13:52:45 -04:00
Mario Jr
402b082355 Default enable banner alert when user speaks with mic muted
This sets back the default value after fixes done in #11272 and #11268
2021-03-23 14:45:41 -03:00
Mario Jr
b830e794f7 Do not create mutedalert component when user is disconnected
If created, mutedalert will crash client when trying to access inputstream
which is not yet ready.
Fixes #11433
2021-03-23 14:45:38 -03:00
Anton Georgiev
fe58a11249
Merge pull request #11718 from MaximKhlobystov/typed-poll-case-insensitive
Case insensitive typed poll responses grouping
2021-03-23 10:58:15 -04:00
Anton Georgiev
c6a9d8e213
Merge pull request #11719 from ramonlsouza/issue-11714
Locales fetch rework
2021-03-23 10:57:50 -04:00
Ramon Souza
3b08a54df7 adding locale instructions in settings.yml 2021-03-23 11:50:16 -03:00
Anton Georgiev
428b048b2e
Merge pull request #11713 from ramonlsouza/guest-user-messages
Retrieve guest user pre-join messages only when userId is available
2021-03-23 09:17:52 -04:00
Ramon Souza
c4fc7bcd92 locales fetch rework 2021-03-23 10:09:28 -03:00
Maxim Khlobystov
5adb3429eb Make typed poll responses grouping case insensitive 2021-03-23 06:30:37 +00:00
Tainan Felipe
443df78c6e add logs to observer and re-implement role render logic 2021-03-22 18:07:46 -03:00
Tainan Felipe
ba91dcb17c Implements user persistent data to user context and redo users status logic on chat item 2021-03-22 17:44:53 -03:00
Anton Georgiev
70ef985fde
Merge pull request #11703 from KDSBrowne/bbb-move-raiseHand
Move Raise Hand Functionality To Actions Bar Button
2021-03-22 14:24:32 -04:00
KDSBrowne
d89e6a8c3a move debounce to service 2021-03-22 18:02:31 +00:00
Ramon Souza
192f202f9c only retrieve guest user pre-join messages after userId is available 2021-03-22 14:00:03 -03:00
KDSBrowne
8e9718eb0b add debounce to raise hand toggle 2021-03-22 16:08:53 +00:00
KDSBrowne
6f5b9ceff5 adjust actions bar buttons position on mobile 2021-03-22 15:50:35 +00:00
Anton Georgiev
3e526f4e14
Merge pull request #11711 from ramonlsouza/presenter-menu-width
Increasing presenter menu width
2021-03-22 10:52:06 -04:00
Anton Georgiev
800c10eb1c
Merge pull request #11691 from Tainan404/issue-11618
Fix messages being not cleared
2021-03-22 10:48:08 -04:00
Ramon Souza
34dc5ca79f increasing presentation menu width 2021-03-22 11:42:13 -03:00
Ramon Souza
383efc31f8 increasing userlist width 2021-03-22 10:54:23 -03:00
Joao Siebel
4d759ad63c Prevent logged out user tp spam validateAuthToken 2021-03-22 09:37:17 -03:00
Tainan Felipe
2271d4fe61 Fix messages being not cleared 2021-03-22 08:34:12 -03:00
KDSBrowne
4473fa084b add lower hand label 2021-03-21 23:56:00 +00:00
KDSBrowne
132dfb02d9 add raise hand shortcut and help entry 2021-03-21 23:47:15 +00:00
KDSBrowne
676abd1f85 move raise hand functionality to actions bar 2021-03-21 17:06:16 +00:00
Anton Georgiev
5641252e56
Merge pull request #11700 from ramonlsouza/select-random-user-flag
Add selectRandomUser settings
2021-03-19 17:40:45 -04:00
Tainan Felipe
fa550c707b Subscribe to user pesistent data only after the other subscriptions be ready 2021-03-19 17:33:32 -03:00
Tainan Felipe
e8f4d11446 Add collection user persistent data 2021-03-19 17:12:27 -03:00
Ramon Souza
3715266883 add selectRandomUser flag 2021-03-19 15:54:54 -03:00
Anton Georgiev
cbb7a69cf2
Merge pull request #11698 from ramonlsouza/camera-remove-crash
Fix client crash when user is sharing video
2021-03-19 14:05:30 -04:00
Ramon Souza
050844c275 fix client crash when user is sharing video 2021-03-19 14:26:06 -03:00
Ramon Souza
c85abbbb75 fix userlist height if banners are enabled 2021-03-19 09:00:39 -03:00
Pedro Beschorner Marin
63a637940b
Merge pull request #11689 from pedrobmarin/fix-solo-presenter-multi-user-whiteboard
Handle multi-user whiteboard for solo presenter
2021-03-18 21:06:15 -03:00
Anton Georgiev
4e74fcf1b8 Updated versions of npm packages for bbb-html5 2021-03-18 19:30:11 +00:00
Pedro Beschorner Marin
92d3300d81 Handle multi-user whiteboard for solo presenter
Adjusts the user interface to keep coherence when activating the multi-user
whiteboard while there is only the presenter in the meeting.
2021-03-18 14:53:11 -03:00
prlanzarin
d4d391b2c2 html5, kurento-utils: update js.merge to v2.1.1 (was v1.2.0) 2021-03-18 14:47:36 -03:00
Ramon Souza
1df849a218 show poll question in polling panel 2021-03-18 14:16:32 -03:00
prlanzarin
efd0ff2ff1 html5, kurento-utils: update UAParser to v0.7.24 (was v0.7.17) 2021-03-18 14:05:27 -03:00
Ramon Souza
70ab1f099a show poll question in chat 2021-03-18 13:13:57 -03:00
Anton Georgiev
4e762c6ae9
Merge pull request #11574 from daminebenq/update-and-add-polling-specs
Update and add Polling specs
2021-03-17 18:40:12 -04:00
Anton Georgiev
b0122a81fd
Merge pull request #11672 from ramonlsouza/fix-chat-openpanel
Fixes chat panel appearing after webcam share/unshare
2021-03-17 17:05:01 -04:00
Anton Georgiev
5284a39323
Merge pull request #11671 from ramonlsouza/poll-chat-escape
Escaping user typed poll results
2021-03-17 16:53:19 -04:00
Anton Georgiev
51c7ea4ff3
Merge pull request #11678 from ramonlsouza/active-mic-webcam-icon
Show unmuted microphone in video
2021-03-17 15:34:00 -04:00
Ramon Souza
1b8d6a0fab show unmuted microphone in video 2021-03-17 16:26:31 -03:00
Anton Georgiev
483d37fc02
Merge pull request #11676 from Tainan404/issue-11528
Fix for posJoinMessage as undefined
2021-03-17 15:10:36 -04:00
Ramon Souza
5c5834ddc6 fix poll results counter 2021-03-17 15:20:00 -03:00
Ramon Souza
5f2138ddea check if user settings are loaded 2021-03-17 15:01:08 -03:00
Tainan Felipe
e40a1cfcfc Fix posJoinMessage as undefined 2021-03-17 14:49:44 -03:00
Ramon Souza
9ed8af666e fix chat panel appearing after webcam share/unshare 2021-03-17 13:20:59 -03:00
Ramon Souza
8a2ddd5b9f escape all <br/> 2021-03-17 11:44:09 -03:00
Anton Georgiev
6f3898f933
Merge pull request #11664 from prlanzarin/u23-imago
video-provider: add dynamic video page sizes based on number of users
2021-03-17 09:48:50 -04:00
Ramon Souza
e450173bd0 escaping typed poll response before displaying results in chat 2021-03-17 08:26:12 -03:00
Pedro Beschorner Marin
d90ba5e286 Merge branch '2.3-per-user-wb' into develop 2021-03-16 20:28:39 -03:00
Pedro Beschorner Marin
381c5cb15c Isolated whiteboard access
Modified the previous implementation of the whiteboard individual access to remove
multiple Collections dependency on this feature. Multi-user whiteboard is now an
array instead of a boolean value and most of the access control can be synchronized
and handled by akka-apps.
2021-03-16 19:55:25 -03:00
prlanzarin
e8a8deb006 video, user-list: remove obsolete connectionStatus from getUserCount 2021-03-16 20:34:25 +00:00
prlanzarin
0a0a4b4915 video-provider: add dynamic video page sizes based on number of users
New config called paginationThreshold defines classes of page sizes that depend on the number of participants of a meeting

The rationale is pretty much the same as the cameraQualityThresholds, but the thresholds are users here and the ceilings are the page sizes
2021-03-16 20:15:13 +00:00
Anton Georgiev
28ff029d65
Merge pull request #11658 from ramonlsouza/extract-credentials-check
Adds parameters check after extractCredentials is used
2021-03-16 13:17:28 -04:00
Ramon Souza
adc48047a1 prevent sending typed poll empty response 2021-03-16 14:10:10 -03:00
Ramon Souza
ca345de246 add check after extractCredentials is used 2021-03-16 13:15:41 -03:00
hiroshisuga
cabddc6ddf
Change the color of color-picker icon even when the text tool is selected (#11642) 2021-03-15 14:19:52 -04:00
Anton Georgiev
a41fa87bdd
Re-enable redis.js log for meetings handled by other processes
I was shown a case just now where `CreateNewPresentationPodEvtMsg` can happen prior to the full add of a meeting. This log line becomes relevant once again
2021-03-15 12:55:51 -04:00
Anton Georgiev
8568bb03b9
Disable redis.js log for meetings handled by other processes
Disabled `'Backend meeting queue had not been initialized'` which was added to pinpoint an issue with handling of meeting create events, but the issue seems to be unrelated (and has not been hit after resolving a memory leak)
2021-03-15 12:30:02 -04:00
Mohamed Amine Ben Salah
c0834840a8 Merge remote-tracking branch 'upstream/develop' into update-and-add-polling-specs 2021-03-12 21:12:55 -03:00
Anton Georgiev
e475403e9a bbb-html5: Update npm versions 2021-03-12 21:28:12 +00:00
Anton Georgiev
59cb2f107f Pulled HTML5 locales on March 12, 2021 2021-03-12 21:17:53 +00:00
Fred Dixon
c2748e2cac Enable pagination by default 2021-03-12 14:50:01 -06:00
Anton Georgiev
e673fb2cf4
Merge pull request #11630 from prlanzarin/u23-sculptor
listenonly,video-provider,screenshare: remove ICE gathering pre-flight check
2021-03-12 12:58:43 -05:00
Pedro Beschorner Marin
dbb19b79a4 Avoid guest policy change inside breakout rooms 2021-03-12 09:56:04 -03:00
Pedro Beschorner Marin
defc33a043 Removed callback from setGuestPolicy 2021-03-12 09:22:08 -03:00
Lucas Zawacki
07b51a6bf0 Correctly set guestPolicy to not overwrite userProps 2021-03-12 09:19:53 -03:00
Pedro Beschorner Marin
af64232e45 Change guest policy 2021-03-12 09:19:22 -03:00
Anton Georgiev
6d6e1885dd
Merge pull request #11632 from prlanzarin/u23-car-song
listen only: remove the old silent audio autoplay workaround (#11115)
2021-03-12 05:35:12 -05:00
Anton Georgiev
3fbb40875f
Merge pull request #11631 from prlanzarin/u23-planZETA
audio: make sdpSemantics configurable
2021-03-12 05:34:10 -05:00
Anton Georgiev
9f841bd64b
Merge pull request #11622 from prlanzarin/u23-ilgiardino
[screenshare] Rewrite SFU/Kurento screensharing bridge (+reconnections|audio sharing|QoL, was #11025)
2021-03-12 05:13:11 -05:00
prlanzarin
da0a3c36af listen only: remove the old silent audio autoplay workaround
The underlying webkit autoplay issues were properly tackled a long time ago now; this thing isnt needed anymore

Also took the liberty to remove the whole create listen only stream thing because it`s useless
2021-03-12 03:39:12 +00:00
prlanzarin
f20fb3eef2 audio: make sdpSemantics configurable
Plan B is going to be phased out of Chrome soon and we should be testing it with unified plan
2021-03-12 03:04:55 +00:00
prlanzarin
ab17b10c38 listenonly,video-provider,screenshare: remove ICE gathering pre-flight check 2021-03-12 02:51:45 +00:00
prlanzarin
35f519206b Revert additional indentation to actions-bar component
I must have messed this up in the 2.2 - 2.3 merge or with vim somehow, mea culpa
2021-03-12 01:47:05 +00:00
prlanzarin
ef4ad8820d screenshare: adapt shutdown on breakout room joins, only stop sharers
Adapted the breakout room screen sharing shutdown to use the new refactor calls

Also changed the behaviour a bit to only trigger the stop code for presenters/sharers, mimicking the camera behaviour and not leaving viewer with stuck screens
2021-03-12 01:31:46 +00:00
prlanzarin
775cbf4124 screenshare: move end alert sound to a reliable place 2021-03-12 00:44:38 +00:00
Anton Georgiev
a165d3a7e3
Merge pull request #11606 from prlanzarin/u22-sadl1
video-provider: add video pagination UI toggle (was #10970)
2021-03-11 16:05:33 -05:00
Mohamed Amine Ben Salah
5fe7a18db4 Merge remote-tracking branch 'upstream/develop' into update-and-add-polling-specs 2021-03-11 17:38:49 -03:00
Anton Georgiev
5c9314d582
Merge pull request #11623 from ramonlsouza/fix-open-panel
Fix captions and guest list openPanel error
2021-03-11 15:35:08 -05:00
Ramon Souza
edb6ff9455 fix typo 2021-03-11 17:22:46 -03:00
Ramon Souza
17cfd8c9bd fix guest openPanel 2021-03-11 17:00:54 -03:00
Ramon Souza
55a2bc2d02 fix captions openPanel 2021-03-11 16:12:35 -03:00
prlanzarin
7eb91f9273 Merge branch 'u22-screenshare18102020' of https://github.com/prlanzarin/bigbluebutton-1 into u23-ilgiardino 2021-03-11 18:49:14 +00:00
Anton Georgiev
73979f1cba
Merge pull request #11621 from ramonlsouza/fix-captions
Fix locales url settings + captions locales order
2021-03-11 13:44:56 -05:00
Ramon Souza
150bedf16d fix locales url settings + captions locales order 2021-03-11 15:33:48 -03:00
Anton Georgiev
8a640877b2
Merge pull request #11611 from BrentBaccala/audio-prompt
don't prompt for "Microphone" if that's the only option presented to the user
2021-03-11 13:27:31 -05:00
Anton Georgiev
9cc78ca4a5
Merge pull request #11620 from ramonlsouza/issue-11578
Submit typed polling response by pressing enter
2021-03-11 13:01:22 -05:00
Anton Georgiev
6a96bbfb93
Merge pull request #11612 from prlanzarin/u23-planF
video-provider: add inbound/recvonly video reconnection (was #11233)
2021-03-11 13:00:14 -05:00
Ramon Souza
15fccf0ba1 submit typed polling response by pressing enter 2021-03-11 14:45:48 -03:00
Anton Georgiev
4f2f0d123d
Merge pull request #11596 from Tainan404/fix-chat-issues
re-implement chat sync and fix stucked loading indicator
2021-03-11 12:29:01 -05:00