Commit Graph

249 Commits

Author SHA1 Message Date
Ramón Souza
b4fb203593 fix mobile init values for external video/screnshare 2022-07-27 10:56:04 -03:00
prlanzarin
b8811bafd4 fix(layout): use actual screen share size when calculating smart layout
Smart layout (et al) presumes screen sharing will always use 100%
width of the media area. That causes cameras to always be positioned on
top, which is not always the optimal position depending on the viewport
and stream aspect ratio/resolution - so space is wasted.

This commit uses the actual screen sharing video size as provided by
HTMLVideo's videoWidth/videoHeight properties. The calculation uses the
same logic as the one used for presentation/slides, which should make it
a bit familiar.

There's also a handler for HTMLVideo's `resize` event for those browsers
that support it - which enables handling of variable-sized screen
sharing streams. That handler is debounced at 500 ms to prevent
excessive CPU use.

Extra testing is needed with the widest range possible of
browsers/environments and feature combinations.
2022-07-22 13:28:43 +00:00
prlanzarin
8f77f4cd1f fix(layout): set external-video/screen share initial states on all layouts
Only smart layout takes screen sharing/external video states in account
when populating its initial state. The others don't, and that causes
some weird issues when switching back-and-forth between layout types due
to their input states becoming inconsistent - ie having an active screen
sharing and transitioning from Smart -> Custom would mark it as false
(due to its absence from the initial state) and pollute its state for
subsequent layouts.

This commit guarantees those features are taken into account when
populating initial input states for Focus On*/Custom layouts.
2022-07-21 18:07:49 +00:00
gabriellpr
f848d31014 modifying specific buttons
removing border and implementing box-shadow

adding transparent border

passing styles to common buttons

adding secundary color to component

updating color components
2022-07-07 10:45:54 -03:00
KDSBrowne
046518abe5 handle cursor positions for smart layout 2022-07-06 20:03:04 +00:00
Ramon Souza
edeb70de0d Merge tag 'v2.5.1' into merge25-26-jun16 2022-06-16 13:58:54 -03:00
Lucas Fialho Zawacki
a150bd20d7 feature(layout): Bring back layoutType propagation, but disallow 'custom' layout in mobile screens 2022-05-27 18:11:42 -03:00
Lucas Zawacki
cd13446c5a fix(layout): Moderators could not change layout if pushLayout was true 2022-05-24 17:31:35 -03:00
Lucas Zawacki
7ef7b52a30 feat(layout): Both presenters and moderators can set pushLayout 2022-05-24 15:38:47 -03:00
Joao Victor
e070b586c4 [2.5] fix: popover menus in RTL mode 2022-05-13 10:42:19 -03:00
Ramon Souza
0d3a5326fc Merge remote-tracking branch 'upstream/v2.5.x-release' into 25260-may10 2022-05-10 10:53:00 -03:00
Ramon Souza
07f9a192b9 Merge remote-tracking branch 'upstream/v2.4.x-release' into merge-2425-apr27 2022-04-27 15:32:20 -03:00
Lucas Zawacki
00f1b33456 feat(layout): Only propagate custom layout 2022-04-25 19:57:11 +00:00
Lucas Zawacki
7a5086cde8 fix(layout): Remove stray code from merge and fix indentation 2022-04-14 19:22:21 +00:00
Lucas Zawacki
83847a21aa Merge branch 'v2.5.x-release-Layouts' of github.com:lfzawacki/bigbluebutton into develop-bbb 2022-04-13 21:08:32 +00:00
Ramon Souza
0b26f066e0 change captions position to not depend on presentation 2022-04-13 15:10:40 -03:00
Ramon Souza
375cf41498 fix smart layout invisible video bug 2022-03-30 15:30:39 -03:00
Arthurk12
eacce4ee46 fix(layout): camera resize when pushing
Adds isResizing property to LayoutMeetings collection.
Moves the point where the last camera dock size is stored from webcam
component to custom layout component, since it is the only one with
this feature.
2022-03-22 15:29:49 -03:00
Arthurk12
1c3a5bd053 fix(layout): camera dock size
Fixes camera dock sudden increase when moving its position in custom layout.
Uses the last camera dock size stored for that dock position, if not,
make it default size.
2022-03-22 15:28:36 -03:00
Ramon Souza
7b86065e3f fix smart layout invisible video bug 2022-03-17 11:06:21 -03:00
Max Franke
93013d5ad1 fix(layout): layout modal styled components
Add custom layout svgs
If a custom style is set via bbb_custom_style_url or settings.yml,
the svgs applied will be the ones inside the /images/layouts/customStyle/ folder
2022-03-15 14:22:36 -03:00
Lucas Zawacki
d30fc746a4 fix(layout): Fix code after merges 2022-03-09 18:28:12 -03:00
Max Franke
e7e0b25b18 fix(layout): remove unused state 2022-03-09 18:10:20 -03:00
Lucas Zawacki
31ddd9a8d8 fix(layout): Better config names for layout push/toggle 2022-03-09 18:10:09 -03:00
Max Franke
3549d3bfa6 fix(layout): keep border when active
Fixes an issue when the selected layout would not stay "active" when
another object was focused.
Now the selected layout always appears with a border, even if it is
the first time the modal is opened.
2022-03-09 17:13:58 -03:00
Max Franke
0f27b1add4 feat(layout): new layout modal
Add a new modal that makes it easier to switch between layouts
Adds a new flag in html5 settings that allows to enable/disable
keepPushing layout
2022-03-09 17:00:06 -03:00
Arthurk12
5100049c29 fix(layout): webcam container resize bar
Fixes missing webcam container's resize bar on custom layout when cameras
are placed at the bottom of the presentation and the chat is closed.
2022-03-09 16:49:24 -03:00
Anton Georgiev
9cd7eccf63
Merge pull request #14558 from ramonlsouza/issue-14552
fix: Video warning keeps showing after hiding presentation/external video
2022-03-08 12:18:03 -05:00
Ramón Souza
38d804da37 do not display external video message when it is minimized 2022-03-08 17:10:26 +00:00
Ramón Souza
9ec9bfc790 do not display presentation placeholder in smart layout 2022-03-07 20:21:58 +00:00
Ramón Souza
6d268c4092 refactor isMobile check in actions-dropdown 2022-03-03 17:46:20 +00:00
Lucas Zawacki
43afef9bad feature(layout): Remove 'swap layout' concept 2022-02-24 16:05:18 -03:00
Lucas Zawacki
8d6931f656 feature(layout): Add focused camera to layout context 2022-02-24 14:22:00 -03:00
Lucas Zawacki
6dfdc6a579 feature(layout): Push most layout parts with custom layout 2022-02-24 13:21:16 -03:00
Ramón Souza
dba04834c7 Merge remote-tracking branch 'upstream/v2.4.x-release' into 2524-feb08 2022-02-09 15:52:42 +00:00
Ramón Souza
b028e4f4aa do not use presentation size for screenshare and external video in smart layout 2022-02-07 19:29:27 +00:00
Ramón Souza
16cd3c4ebb Merge remote-tracking branch 'upstream/v2.4.x-release' into dev-24-0125 2022-01-25 16:56:52 +00:00
Ramón Souza
a9d4d87d2a restore missing variable 2022-01-21 17:38:25 +00:00
Ramón Souza
bc9957c13d add background to cameras/presentation when positioned in sidebar-content 2022-01-21 13:24:03 +00:00
Max
38d95b0ea8 fix(layout): hide/show media in videoFocus
Fix an error that the hide/show button does not work when there is external
video/screenshare and the layout is "videoFocus".
2022-01-17 19:11:43 -03:00
Ramón Souza
d4c1b985b3 fix webcam overlap in breakout room 2022-01-12 19:30:14 +00:00
Ramón Souza
f6e65f58c5 merge 2.4 into develop and resolve conflicts - partial 2022-01-12 16:40:45 +00:00
Arthurk12
63d3d3efd2 fix(layout): sidebar inconsistent state
Fixes initial state of navigation sidebar.
Navigation sidebar opens along with the content sidebar.
2022-01-03 19:51:05 +00:00
Arthurk12
aabee1ee6f fix(layout): navigation sidebar not opening with content sidebar
Forces navigation sidebar to open with content sidebar.
2021-12-20 18:24:30 +00:00
Ramón Souza
d1c516fef6 resolve html5 conflicts 2021-12-10 21:07:35 +00:00
Anton Georgiev
797fc49633 TEMP 2021-12-09 20:37:05 +00:00
Ramón Souza
6b67527f8d fix sidebar media position with banner 2021-12-02 12:17:40 +00:00
Ramón Souza
e4e7721890 reduce minimal sidebar values - 2.4 2021-11-30 16:43:16 +00:00
Ramón Souza
b8e7641403 increase sidebar-content max width value 2021-11-30 14:07:30 +00:00
Ramón Souza
c43991e6b5 fix cameras margin RTL - smart layout 2021-11-22 11:58:35 +00:00