Commit Graph

27187 Commits

Author SHA1 Message Date
Anton Georgiev
5e365d138f
Merge pull request #11231 from prlanzarin/u22-drc25012021
audio: add a configurable throttle to action-bar`s mute toggle
2021-01-26 16:49:13 -05:00
Anton Georgiev
2912281829
Merge pull request #11235 from mariogasparoni/v2.2.x-release
Fix wrong path in settings for audio constraints
2021-01-26 12:35:23 -05:00
Mario Jr
b753ef5d8d Fix wrong path in settings for audio constraints
Using now 'application' instead of old 'audio' path
2021-01-26 14:12:18 -03:00
prlanzarin
234efd289a audio: add a configurable throttle to action-bar`s mute toggle
Default value is 300ms, with default trailing/leading. Set toggleMuteThrottleTime to 0 to restore old behaviour
2021-01-26 11:47:48 -03:00
Anton Georgiev
5fd837dbd6
Merge pull request #11222 from mariogasparoni/v2.2.x-release
Avoid setting empty/undefined constraint
2021-01-26 08:43:36 -05:00
Mario Jr
7858ba94ba Avoid setting empty/undefined constraint
This removes the console warning about invalid constraint
2021-01-25 23:45:27 -03:00
Anton Georgiev
86e4b44744
Merge pull request #11206 from mariogasparoni/v2.2.x-release
Add setting for enabling/disabling microphone audio filters
2021-01-22 15:59:22 -05:00
Mario Jr
97c76900cb Add setting for enabling/disabling microphone audio filters
As explained in #11143, disabling audio filters is desired in some scenarios.
This basically adds an option for user to disable default constraints.
When user doesn't change this value in Settings > Application, the default
value for each audio constraints is retrieved from settings.yml.
When user changes this value in Settings > Application, audio
filters (AGC, Noise Supression and Echo Cancellation) are all set to
true/false, according to the value selected in the Settings GUI.

To start it simple, we decided to not to add a different setting in the GUI for
each audio contraint. This may be added in the future, though (perhaps in a
dedicated Audio Settings tab)
This is related to #4873
2021-01-22 16:30:42 -03:00
Anton Georgiev
98d03272d0
Merge pull request #11199 from jfsiebel/throttle-typing-indicator
Throttle user typing indicator function
2021-01-21 13:41:35 -05:00
Joao Siebel
bb831e0442 Modify throttle interval to be a const variable 2021-01-21 14:05:59 -03:00
Joao Siebel
8f36ac3586 Add throttle to startUserTyping function 2021-01-21 13:05:41 -03:00
Anton Georgiev
9c0d7b0516
Merge pull request #11187 from jfsiebel/configurable-annotation-cursor-interval
Configurable annotation and cursor interval
2021-01-20 11:44:07 -05:00
Joao Siebel
fa0fd8a054 Add configurable process interval for cursor and annotations 2021-01-20 11:36:40 -03:00
Anton Georgiev
0ba3aa713a
Merge pull request #10912 from lkiesow/16x9
Improve 16x9 Support
2021-01-18 16:05:01 -05:00
Paulo Lanzarin
1f3d487ecc
Merge pull request #11142 from pedrobmarin/fix-multiple-webcam-stop-all
Fix stream stop for multiple webcams
2021-01-12 17:35:10 -03:00
Anton Georgiev
377a57e47e
Merge pull request #11143 from mariogasparoni/v2.2.x-release
Allow audio constraints to be changed in bbb-html5's settings.yml
2021-01-12 15:31:31 -05:00
Mario Jr
92708da447 Allow audio constraints to be changed in bbb-html5's settings.yml
In some scenarios, there's no need for the browser to apply such audio filters. For example, when user's microphone already does audio filtering (echo cancellation, noise supression ...).
This commit doens't change the current behavior (filters still follow browser's default config): admins need to uncomment/set these values if disabling/enabling specific filters if desired.
This is related to #4873
2021-01-12 14:42:27 -03:00
Pedro Beschorner Marin
cc9b552e2a Fix stream stop for multiple webcams
Video provider's service for local stream control was wrongly setting the disconnected
state when a multiple webcam user tried to stop a single cam. The `stopVideo` method
was inconsistent when called multiple times for the same `cameraId`.

Included a better testing scope for event dispatching and disconnected state handling.
2021-01-12 13:24:40 -03:00
Paulo Lanzarin
31865846d7
Merge pull request #11123 from pedrobmarin/api-stream-check
Check if stream already exists before adding in list
2021-01-08 17:43:12 -03:00
Pedro Beschorner Marin
ca7e3baf0f Check if stream already exists before adding in list 2021-01-08 13:48:36 -03:00
Paulo Lanzarin
1aadc69826
Merge pull request #11120 from bigbluebutton/basisbit-webcam1020timeout
Increase camera baseTimeout to 30 seconds (webcam share timeout workaround)
2021-01-08 13:30:30 -03:00
basisbit
9c3c926ede
Increase camera baseTimeout to 30 seconds
see https://github.com/bigbluebutton/bigbluebutton/issues/11099#issuecomment-753985300
2021-01-08 04:56:20 +01:00
Fred Dixon
073a04e83a
Merge pull request #11068 from prlanzarin/u22-videopreview-fixes
video-preview: improvements to error handling (#9943) and cleanups
2020-12-22 18:00:00 -05:00
Paulo Lanzarin
b78d2b85a8 Add missing app.video.genericError en locale
It seems the video-preview generic error fallback locale (to handle unexpected errors on our side which do not inherently come from gUM calls) was removed by accident. Adding it back.
2020-12-22 21:10:22 +00:00
prlanzarin
0aa7d67c4d video-preview: normalize some error locales 2020-12-22 20:50:01 +00:00
Paulo Lanzarin
1334127b35 video-preview: bump default gUMTimeout to 20s
Otherwise users who took long enough to accept the gUM permission prompt would fall into the workaround
2020-12-22 20:10:59 +00:00
Pedro Beschorner Marin
4e370d28ec Add timeout at video's preview modal
Some browsers seem to (occasionally) not return the getUserMedia promise call and the
user gets stuck in this state unable to share her/his webcam.

Since enumerateDevices still works even on a gUM rejection this includes a racing
timeout that skips gUM. Configured at settings `gUMTimeout`.

Reproduced with Windows 10 Chrome 87.
2020-12-22 20:10:19 +00:00
Pedro Beschorner Marin
c8ace18f85 Enumerate devices even if first getUserMedia fails
The first getUserMedia was not supposed to be considered critical to the whole
video preview flow.

Scenarios where the user has multiple media sources and one of them was already
in use or had some malfunction problem were forcing a global skip at the video
preview modal even if one of them was available to be used.
2020-12-22 19:26:28 +00:00
Pedro Beschorner Marin
f6217308dd Refactor video preview getUserMedia preview error handler 2020-12-22 19:26:23 +00:00
Pedro Beschorner Marin
dced6bd2b8 Add missing getUserMedia errors
Collected from https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getUserMedia
2020-12-22 19:25:48 +00:00
Pedro Beschorner Marin
62d491c8e4 Refactor video preview getUserMedia device error handler 2020-12-21 20:54:21 +00:00
CristianSilvaGrosseli
0c4f903c39 use placeholder in the logger.error method return in the video-preview component. fix wrong file permission. 2020-12-21 20:53:56 +00:00
CristianSilvaGrosseli
d8ed8f2570 use correct pattern in video-preview's handleGUMError method. 2020-12-21 20:53:12 +00:00
CristianSilvaGrosseli
ffd1063332 video-preview component's handleGUMError method rehabilitation. 2020-12-21 20:52:15 +00:00
Anton Georgiev
1880c0b5db
Merge pull request #11024 from jfsiebel/generate-heapdump-file
Add option to generate heap file and tweak metrics
2020-12-15 14:47:15 -05:00
Anton Georgiev
2bf6758f31
Enable customHeartbeat by default
https://github.com/bigbluebutton/bigbluebutton/pull/10826
2020-12-15 14:46:38 -05:00
Joao Siebel
3ad269c24c Check if metrics are enabled 2020-12-15 16:20:32 -03:00
Joao Siebel
c5b8f30f5d Add option to generate heapdump file and improve metrics 2020-12-15 13:10:39 -03:00
Fred Dixon
c8f23fe34b
Merge pull request #11011 from ffdixon/fix-dangling-if
Fix dangling fi
2020-12-12 17:51:01 -04:00
Fred Dixon
1105e85456 Removed extra fi 2020-12-12 15:49:26 -06:00
Fred Dixon
c99834f187 Echo STUN server if enabled 2020-12-12 15:35:14 -06:00
Fred Dixon
00f6ca2282
Merge pull request #11010 from ffdixon/shorten-sounds
Provide shorter audio prompts for muted/unmuted
2020-12-12 13:19:30 -04:00
Fred Dixon
053eba27b0 Provide shorter audio prompts for muted/unmuted 2020-12-12 11:15:14 -06:00
Anton Georgiev
9a04087c12
Merge pull request #11006 from mariogasparoni/v2.2.x-release
Add keep alive message to audio's websocket
2020-12-11 10:41:33 -05:00
Anton Georgiev
d99321836e
Merge pull request #11005 from jfsiebel/stop-typing-log-error
Prevent calling stopUserTyping when parameters are undefined
2020-12-11 09:42:10 -05:00
Joao Siebel
b07b200a2f Prevent calling function when parameters are undefined 2020-12-11 11:24:03 -03:00
Mario Jr
6113113af9 Add option to disable traceSip logs
Audio client logs already cover audio session progress the way we need.
This avoids keepAlive and other unnecessary messages to be logged in browser's console.
If setting is not present, default value is set to false.
2020-12-11 00:31:10 -03:00
Mario Jr
c65fa2b350 Add keep alive message to audio's websocket
This was added as an option (websocketKeepAliveInterval), which is the interval to send keep alive messages.
Setting websocketKeepAliveInterval to 0 disables the keep alive, producing the same old behavior.
This helps avoid websocket disconnection due to socket inactivity, preventing it to unnecessarily reconnect.
Also, sometimes reconnect fails and error 1005 is triggered.
Fixes problems reported in #10985.
Also reduces occurrences of error 1005.
2020-12-10 23:48:01 -03:00
Anton Georgiev
f7e17cb1e7
Merge pull request #10999 from lonesomewalker/patch-1
fix typo in apply-lib.sh
2020-12-10 12:45:56 -05:00
Anton Georgiev
33f5a854e1
Merge pull request #10998 from jfsiebel/improve-redis-metrics
Add processing time metrics
2020-12-10 12:42:23 -05:00