Commit Graph

41796 Commits

Author SHA1 Message Date
João Victor Nunes
83f6f8d0f9
fix: order grid items by both name and userId
Co-authored-by: Gustavo Trott <gustavo@trott.com.br>
2024-05-06 08:23:55 -03:00
prlanzarin
d6e160a2c3 refactor(audio): remove stale iOS webview polyfills
Shouldn't be necessary anymore
2024-05-03 21:42:36 +00:00
prlanzarin
983b8a85cf fix(audio): improve help modal for listen only scenarios
The audio troubleshooting modal has very microphone-specific strings,
which might confuse users trying to join listen only.

Review the Help screen so that listen only scenarios are more generic.
As a bonus, review the unknownError locale with a more actionable text.
2024-05-03 21:41:06 +00:00
prlanzarin
a748d8ccbb fix(audio): remove listen only retry routines
Listen only has a built-in retry routine on join failures that's
convoluted half-broken. It stems from the Kurento era where it could
fail randomly due to a myriad of reasons.
Production logs indicate that the retry is seldom used nowadays in
mediasoup-based environments. The presence of the retry also breaks
the error troubleshooting modal when actual failures happening, leaving
users in the dark about what's happening.

Remove the listen only retry code from AudioManager and bubble up any
join failure to the callers.
2024-05-03 21:18:44 +00:00
prlanzarin
027d5ad288 fix(audio): handle NotAllowedError in skipCheck:true scenarios
In scenarios where the join audio flow skips echo test, NotAllowedError
(and any other errors) are all being mashed together under a generic
MEDIA_ERROR object.

Properly handle specific errors in audio-manager so they're correctly
render in the audio modal help screen.
2024-05-03 21:15:58 +00:00
prlanzarin
a3a1245078 fix(audio): review audio modal help screen
- Adds a new Help view for unknown error codes
- Correctly detect NotAllowedError (permissions) - they are currently
  being treated like unknown errors in the Help modal
- Rephrase NotAllowedError help text; make it more succint and direct
- Rephrase the unknown error help text; make it more succint and direct
  - Add error code and message to that view
- Add public.media.audioTroubleshootingLinks to allow referencing KB
  links on the Help modal
  - See inline docs
2024-05-03 20:50:03 +00:00
Ramón Souza
f742a6d25d
Merge pull request #20134 from JoVictorNunes/video-streams-typings-fix
fix: tweak video-streams typings
2024-05-03 17:19:52 -03:00
Anton Georgiev
8db5b74c44
Merge pull request #20171 from gustavotrott/client-settings-cache-system
enhancement: Speed up the client loading (by implementing a cache system to obtain ClientSettings)
2024-05-03 15:55:07 -04:00
João Victor
9e0ea8a33f fix(webcam): rename query variable 2024-05-03 16:35:56 -03:00
João Victor Nunes
4f9e75ae0c
fix(webcam): remove loggedOut filter
Co-authored-by: Gustavo Trott <gustavo@trott.com.br>
2024-05-03 16:33:13 -03:00
Gustavo Trott
d3d12c7bf1 Move building files to /build/... directory 2024-05-03 15:56:37 -03:00
João Victor
6aa1e0f336 Remove isGridItem field 2024-05-03 15:34:10 -03:00
João Victor
fb1947dc8f Remove console.log's 2024-05-03 15:11:30 -03:00
Gustavo Trott
1d808f9c7b Set cache endpoint to graphql-middleware nginx file 2024-05-03 14:42:54 -03:00
João Victor
65ac5b6b9b fix(webcam): avoid sending a negative value for grid user limit 2024-05-03 14:33:04 -03:00
Ramón Souza
2e7608e653 fix currentPageShapes prop type warning 2024-05-03 13:05:31 -03:00
Ramón Souza
967ae9ddcc fix undefined label in leave meeting button warning 2024-05-03 13:02:53 -03:00
prlanzarin
533c7e86dc fix(bbb-html5): add specific logCodes for root error boundaries
The ErrorBoundary component has a generic log message that is not
overridable and will aggregate errors from different components. The
ideal scenario is that log tags are configurable so that errors can be
filtered for in log post-processing.

Add the logMetadata: { logCode, logMessage } prop to the ErrorBoundary
component so that log tags are configurable. Default tags are
maintained.
Add specific log metadatas for the client startup error boundary
(logCode: 'app_startup_crash') and the user connection error boundary
(logCode: 'app_crash').
2024-05-03 15:27:17 +00:00
Gustavo Trott
16800ce8ef Merge remote-tracking branch 'upstream/v3.0.x-release' into client-settings-cache-system 2024-05-03 12:05:41 -03:00
Ramón Souza
8e728d2cc4
Merge pull request #20019 from Scroody/fix-volume-bar-overlap
Fix: Volume bar overlapping
2024-05-03 11:24:03 -03:00
Gustavo Trott
cb7fd136de remove unnecessary step 2024-05-03 11:13:25 -03:00
Gustavo Trott
62da41ab90 Create staging/etc/default/bbb-graphql-server in case its missing 2024-05-03 11:12:55 -03:00
André
8c57f63bb9 Later changes 2024-05-03 10:34:35 -03:00
João Victor
ca5d74e9d4 fix(webcam): type user as partial 2024-05-03 10:29:25 -03:00
André
4c0df76b23 Merge remote-tracking branch 'upstream/v3.0.x-release' into fix-volume-bar-overlap 2024-05-03 10:29:00 -03:00
Gustavo Trott
ea82508b5d introduces a nginx cache for /api/rest/(clientStartupSettings|clientSettings) 2024-05-03 10:27:26 -03:00
André
cbd06c0790 Side effect solving 2024-05-03 10:22:16 -03:00
Ramón Souza
9307b33a4e fix undefined isPresenter warning 2024-05-03 10:07:26 -03:00
Anton Georgiev
205d110f5b
Merge pull request #20104 from Tainan404/remove-redis
!remove: Frontend Redis client listener
2024-05-03 09:02:08 -04:00
Ramón Souza
c951acc3bb fix undefined isTimerActive warning 2024-05-03 09:59:57 -03:00
João Victor
2dddd161bf fix: limit grid users at the data access level 2024-05-03 09:58:27 -03:00
Anton Georgiev
d19677d5a3
Merge pull request #20166 from prlanzarin/u30/fix/review-mobile-audio-chevron
fix(audio): review device selection in mobile endpoints
2024-05-03 08:56:51 -04:00
Anton Georgiev
d85561b17b
Merge pull request #20164 from prlanzarin/u30/fix/Arthurk12-live-1809
fix(bbb-html5): correct parameter type for wake lock log codes
2024-05-03 08:56:03 -04:00
Anton Georgiev
0e68003c08
Merge pull request #20163 from prlanzarin/u30/fix/assorted-br-crashes
fix: undefined accesses causes crashes in actions-bar breakout utils
2024-05-03 08:55:43 -04:00
Anton Georgiev
0df167180e
Merge pull request #20162 from prlanzarin/u30/fix/ff-pairselection
fix(audio): broken connection stats on Firefox >= 125
2024-05-03 08:53:40 -04:00
Anton Georgiev
05d8f9110b
Merge pull request #20161 from prlanzarin/u30/fix/arthurk12-undefined-role-crash
fix: add safeguards when returning user roles
2024-05-03 08:53:01 -04:00
Anton Georgiev
7c407567e1
Merge pull request #20160 from prlanzarin/u30/fix/arthurk12-screenreader-crash
fix(screen-reader): add safeguards for adding alerts
2024-05-03 08:52:45 -04:00
Anton Georgiev
70e4ab1f66
Merge pull request #20159 from prlanzarin/u30/fix/onconnectionstatechange-crash-rc
fix(bbb-html5): crash when stopping WebRTC peers
2024-05-03 08:52:28 -04:00
Anton Georgiev
3babf4c16e
Merge pull request #20158 from prlanzarin/u30/fix/crash-videoprovider-onmessage
fix(bbb-html5): crash on video-provider unmount
2024-05-03 08:51:58 -04:00
Anton Georgiev
84fd90bc49
Merge pull request #20157 from prlanzarin/u30/fix/crash-getBoundingClientRect-emojirain
fix(reactions): crash when interactionsButton coords are absent
2024-05-03 08:49:42 -04:00
Anton Georgiev
9d99f7f78b
Merge pull request #20156 from prlanzarin/u30/fix/audio-answerer-gum-failure
fix(audio): acquire streams before negotiation when peer is answerer
2024-05-03 08:49:08 -04:00
Anton Georgiev
d385d97cdb
Merge pull request #20155 from prlanzarin/u30/fix/audio-less-toasts
fix(audio): minimize redundant audio exit toasts
2024-05-03 08:48:32 -04:00
Ramón Souza
35af05e594 fix custom logo 2024-05-03 09:31:18 -03:00
prlanzarin
a21addfa1f fix(audio): review device selection in mobile endpoints
Mobile users have no way to change I/O devices after joining audio.
The removal of the audio options chevron in mobile browsers was supposed
to be replaced by something else - in this case, by the dedicated
leave/join audio button. That didn't happen, leave/join audio button
retained the old behavior.

Review device selection in mobile endpoints via two UI/UX changes:
  - Fix an styling issue where the mute and listen only buttons were
    crammed together
  - Restore the device selection chevron/icon in mobile endpoints
  - Override the leave/join button action in mobile endpoints so that it
    opens the device selection contextual menu, which also includes the
    "Leave audio" option. This retains the old behavior (leaving audio)
    while also providing an way for users to change devices mid-call in
    mobile browsers.
2024-05-03 01:32:01 +00:00
Arthurk12
31a6527cca fix(wake-lock): correct parameter type for log code
Previously, an object was incorrectly passed as the log code parameter.
Fixes it by ensuring that a string is passed instead.
2024-05-03 00:06:07 +00:00
prlanzarin
cea92631fa fix: undefined accesses causes crashes in actions-bar breakout utils
Multiple undefined accesses in actions-bar's service, mainly related to
breakouts and ageneral Meetings info, cause crashes in production
environments - most likely in reconnection scenarios.

Guarantee that nested data is safely accessed.
2024-05-02 23:50:56 +00:00
prlanzarin
20daf56390 fix(audio): broken connection stats on Firefox >= 125
WebRTC-based stats generation in the connection status modal is broken
on Firefox >= 125. A broken type check coupled with a new partially
implemented RTCIceTransport dictionary causes and undefined function
call when fetching the selected candidate pair. Since that error is
unhandled, collection breaks.

Correctly check for the getSelectedCandidatePair method availability in
RTCIceTransport so that it skips to pair inference from getStats if
necessary.
2024-05-02 23:37:44 +00:00
Arthurk12
148c25e2cb fix: add safeguards when returning user roles 2024-05-02 23:35:45 +00:00
Arthurk12
9947aa451e fix(screen-reader): add safeguards for adding alerts
Adds checks for the alert's text and DOM element before adding screen
reader alerts.
2024-05-02 23:06:55 +00:00
prlanzarin
85cdc7cc2a fix(bbb-html5): crash when stopping WebRTC peers
There's a race condition that may cause a client crash whenever a
connectionstatechange callback is cleaned up in a peer without a
valid peer connection present in our custom RTCPeerConnection wrapper.

Check for peerConnection availability in the WebRtcPeer wrapper before
trying to clean up its connectionstatechange callback.
2024-05-02 22:59:39 +00:00