Commit Graph

10436 Commits

Author SHA1 Message Date
Joao Victor
5c6c28cdd2 Fix conflicts 2022-07-25 15:14:27 -03:00
Ramón Souza
01ba2a27f5
Merge pull request #15332 from JoVictorNunes/virtual-backgrounds-skeleton-preview
improvement(virtual background): loading skeleton, custom backgrounds in video preview modal
2022-07-25 13:34:22 -03:00
Ramón Souza
890ca5c4a0
Merge pull request #15429 from prlanzarin/u26/fix/screenshare-layout-dimensions
fix(layout): use actual screen share size when calculating smart layout
2022-07-25 13:02:00 -03:00
Joao Victor
24e78a1864 fix: 1 minute threshold for each slide 2022-07-25 10:33:23 -03:00
Joao Victor
e32eeec9a2 improvement: query selector 2022-07-25 09:35:08 -03:00
Joao Victor
9f0999f623 fix: rename exported presentation default filename 2022-07-25 09:19:39 -03:00
Gabriel Porfirio
15b28d52fe updating feedback message 2022-07-22 13:27:39 -03:00
prlanzarin
b8811bafd4 fix(layout): use actual screen share size when calculating smart layout
Smart layout (et al) presumes screen sharing will always use 100%
width of the media area. That causes cameras to always be positioned on
top, which is not always the optimal position depending on the viewport
and stream aspect ratio/resolution - so space is wasted.

This commit uses the actual screen sharing video size as provided by
HTMLVideo's videoWidth/videoHeight properties. The calculation uses the
same logic as the one used for presentation/slides, which should make it
a bit familiar.

There's also a handler for HTMLVideo's `resize` event for those browsers
that support it - which enables handling of variable-sized screen
sharing streams. That handler is debounced at 500 ms to prevent
excessive CPU use.

Extra testing is needed with the widest range possible of
browsers/environments and feature combinations.
2022-07-22 13:28:43 +00:00
Ramón Souza
7c4457bfa1
Merge pull request #15415 from JoVictorNunes/issue-15397
fix: breakout remaining time label
2022-07-22 14:23:47 +01:00
Joao Victor
dbafb610d5 fix: whiteboard access avatar icon in RTL mode 2022-07-22 10:16:57 -03:00
Ramón Souza
9c8c580db2
Merge pull request #15424 from prlanzarin/u26/fix/layout-ss-calc
fix(layout): set external-video/screen share initial states on all layouts
2022-07-22 13:12:31 +01:00
Joao Victor
ce7f35b3db fix: checkbox and remove button alignment in RTL languages 2022-07-21 17:30:25 -03:00
Anton Georgiev
d7bdc324a0 chore: pull BBB 2.5.4+ into 2.6 2022-07-21 20:25:31 +00:00
Joao Victor
e59e3b68af fix: header alignment 2022-07-21 17:20:03 -03:00
Joao Victor
e3062f2da7 fix: increase exporting threshold to 1 minute 2022-07-21 16:40:52 -03:00
Joao Victor
2f623a2731 fix: better log message when setting exporting status 2022-07-21 16:39:19 -03:00
prlanzarin
8f77f4cd1f fix(layout): set external-video/screen share initial states on all layouts
Only smart layout takes screen sharing/external video states in account
when populating its initial state. The others don't, and that causes
some weird issues when switching back-and-forth between layout types due
to their input states becoming inconsistent - ie having an active screen
sharing and transitioning from Smart -> Custom would mark it as false
(due to its absence from the initial state) and pollute its state for
subsequent layouts.

This commit guarantees those features are taken into account when
populating initial input states for Focus On*/Custom layouts.
2022-07-21 18:07:49 +00:00
Paulo Lanzarin
34a3c2be49
Merge pull request #15408 from prlanzarin/u26/fix/audio-reconn-stuck
refactor(audio): log VoiceUser cleanup on User remove and centralize it
2022-07-21 15:06:41 -03:00
Gabriel Porfirio
94cfa3c084 WIP: Adding notification to waiting users list 2022-07-21 14:07:19 -03:00
Joao Victor
854dcf5a93 fix: use Meteor bindings for both setTimeout and clearTimeout 2022-07-21 10:49:36 -03:00
Gustavo Trott
59ddf3e8e3 broadcast NewPresAnnFileAvailableMsg to html5 2022-07-20 20:20:32 -03:00
KDSBrowne
9234dee077 fix viewer wb crash switching to rtl 2022-07-20 19:54:23 +00:00
KDSBrowne
db41932fe7 update render wb condition | add operator 2022-07-20 19:20:46 +00:00
KDSBrowne
21f2a441ee update editable whiteboard component key 2022-07-20 19:03:26 +00:00
KDSBrowne
9d8ce2215d remove key prop 2022-07-20 18:51:50 +00:00
KDSBrowne
fb63975a7e fix viewer WB crash when resizing 2022-07-20 18:50:13 +00:00
prlanzarin
6c8b097eba fix: add option to disable transcription in mobile, extend support check
Mobile endpoints are flaky with the WebSpeechAPI:
  - iOS versions that support it are borking our outbound audio when it's
    enabled
  - Android speech recognition has flaky locale detection and speech
    transcription
Additionally: the support check is not checking the WebSpeechAPI
availability properly, so older devices (eg iOS 12) are flagged as
supported even though they aren't.

This commit adds a configuration flag (public.audioCaptions.mobile) to
control transcription availability on mobile. False by default.
Also extends the setSpeechVoices support check and
hasSpeechRecognitionSupport method to prevent false positives.
2022-07-20 17:20:54 +00:00
Arthurk12
e93b9739de style(captions): adds border to toggle button 2022-07-20 17:20:53 +00:00
Max Franke
75eef650e6 feat(audio-captions): reallocate button from mobile
Remove CC button toggle in the action bar only in mobile.
Add a new CC button toggle in settings dropdown only to mobile.
2022-07-20 17:20:53 +00:00
Arthurk12
c96b53093c feat(captions): adds locale settings
Adds two new flags to the settings file which change the way the locale
flag is used:

- forceLocale: (true/false) => If true, enforces the transcription
  language to be the locale content field and jumps the language
selector
  in audio modal.
- defaultSelectLocale: (true/false) => If true, the default selected
  value in the dropdown language selector in audio modal will be defined
  by the locale content field.

In any case, if the locale flag holds an invalid value, it defaults to
disabled.
2022-07-20 17:20:53 +00:00
Arthurk12
da9adca229 fix(captions): talking indicator icon
Prevents the speech recognition from being initialized when the closed
captions feature is disabled.
2022-07-20 17:20:52 +00:00
Pedro Beschorner Marin
d553ca65cf feat(captions): use navigator language
If not set to use the default language, try to select the navigator
language as speech default locale.
2022-07-20 17:20:52 +00:00
Pedro Beschorner Marin
116c0d9a49 fix(captions): filter duplicated languages
Avoid multiple instances of the same language at the voices data.
2022-07-20 17:20:52 +00:00
Pedro Beschorner Marin
51eeb092b3 refactor(captions): configurable languages
Move the language collection to the HTML settings file. This data defines
the available languages available for the speech API.

These language tags are used to filter SpeechSynthesis' API `getVoices`
result. Tags must use BCP 47 format.

https://developer.mozilla.org/en-US/docs/Web/API/SpeechSynthesisVoice/lang
2022-07-20 17:20:52 +00:00
Pedro Beschorner Marin
b52c67d7a7 feat(captions): first pass on recording
Add the main server-side adapter for using the legacy closed captions
recording process with the audio captions data.
2022-07-20 17:20:52 +00:00
Pedro Beschorner Marin
aa7f2abae2 feat(captions): talking users' floor
Associate the floor status with the talking users to improve feedback
on automated closed captions.
2022-07-20 17:20:51 +00:00
Pedro Beschorner Marin
1064aab84d style(captions): add background alpha
Add some transparency to the background color.
2022-07-20 17:20:51 +00:00
Pedro Beschorner Marin
fb48e61d6d feat(captions): add talking indicator feedback
Inform other users about who are the current talkers with the speech
recognition enabled.
2022-07-20 17:20:51 +00:00
Pedro Beschorner Marin
df184b542c feat(captions): add unsupported warning
Add a disclaimer for users on browsers that do not provide speech synthesis'
voices.
2022-07-20 17:20:51 +00:00
Pedro Beschorner Marin
307ab6ea40 feat(captions): add author avatar
Include captions' author avatar at the live feedback to improve identification.
2022-07-20 17:20:50 +00:00
Pedro Beschorner Marin
d00909751a refactor(captions): change getVoices routine
In some cases, `getVoices` returns an empty array even if the browser's vendor
has full support for speech synthesis. Add a trigger call to initiate the
voices fetching process.

As drafted, `getVoices` can be an asynchronous call and monitoring it
depends on the support of a `voiceschanged` event. Although many of the
main vendors support voices, this event is not (yet) by Safari.

https://wicg.github.io/speech-api/#dom-speechsynthesis-getvoices
https://wicg.github.io/speech-api/#eventdef-speechsynthesis-voiceschanged
https://developer.mozilla.org/en-US/docs/Web/API/SpeechSynthesis/voiceschanged_event
2022-07-20 17:20:50 +00:00
Pedro Beschorner Marin
d6dc66f57e feat(captions): language selector
Replace the checkbox with a selector up with 3 languages: en-US, es-ES and pt-BR.

Add setting option to enable by default with predetermined locale.
2022-07-20 17:20:50 +00:00
Pedro Beschorner Marin
5671bd7d3c fix(captions): check for voices
Avoid enable audio transcription if the browser's vendor does not provide
voices data.

This should prevent false positives for browsers such as Chromium and
Brave.
2022-07-20 17:20:49 +00:00
Pedro Beschorner Marin
e131925370 style(captions): font-family fallback
Add extra `sans` alternatives
2022-07-20 17:20:49 +00:00
Pedro Beschorner Marin
d688a2572f fix(captions): remove padding when no content
Avoid rendering the captions wrapper's padding when there's no data to
be displayed at the live feedback.
2022-07-20 17:20:49 +00:00
Pedro Beschorner Marin
f726cb0ad5 refactor(captions): UX improvements
Parse the audio transcript before broadcasting it's content back to the
client and the recording actor. Limiting by 8 words per line and max of
2 lines to avoid CPU intensive operations over this recurring event.

Replace Calibri font family with Verdana to improve character spacing,
add relative sizing to the text content and a background padding.
2022-07-20 17:20:49 +00:00
Pedro Beschorner Marin
75969ec93c feat(captions): audio captions app
Add a server-side app for the audio captions feature and record proto-events
for this data.

As it is, only behaves as a pass-through module. The idea is to include all
the business intelligence in this app.
2022-07-20 17:20:48 +00:00
Pedro Beschorner Marin
0bc730b3e3 refactor(captions): improve recovery
Use the user's talking state to trigger a speech API recovery after long
periods of silence.
2022-07-20 17:20:48 +00:00
Pedro Beschorner Marin
944edf2ccf feat(captions): web speech prototype
Hardcoded pt-BR prototype for closed captions generated by the browser's
WebSpeech API.
2022-07-20 17:20:48 +00:00
Joao Victor
a1ed921039 fix: breakout remaining time label 2022-07-20 12:22:46 -03:00
prlanzarin
d23189d1ed refactor(audio): log VoiceUser cleanup on User remove and centralize it
There's a VoiceUser cleanup procedure bound to the User's cleanup
routine in Meteor's server-side. That cleanup is _silent_ and does not
use a dedicated modifier from voice-user et al, which is not
straightforward and might waste a few minutes of understanding what's
happening when debugging audio collections.

This commit centralizes that cleanup in a new clearVoiceUser modifier in
voice-user as well as logs when it works.
2022-07-20 12:13:37 +00:00
Joao Victor
cff1c087a8 feat: front-end support for exporting presentations with annotations 2022-07-19 16:36:00 -03:00
KDSBrowne
100bfcfb86 update fullscreen element check 2022-07-19 10:51:59 +00:00
KDSBrowne
ed55d58b01 handle cursor positions for video focus 2022-07-19 03:37:47 +00:00
KDSBrowne
47303757de handle cursor position for fullscreen presentation 2022-07-19 01:23:10 +00:00
Ramón Souza
f083bb9a20
Merge pull request #15273 from JoVictorNunes/issue-15272
fix: apply presentation 'isCurrent' changes to local state
2022-07-18 21:19:20 +01:00
Ramón Souza
2fd65dfc1c
Merge pull request #15099 from schrd/fix-issue-14982
Fix: only show breakout room in user list when user is in breakout room
2022-07-18 21:17:17 +01:00
Anton B
944e0b2981 test: add audio tests 2022-07-15 17:54:16 -03:00
Joao Victor
0ac69cba0a fix: comparison to render custom buttons 2022-07-15 17:16:33 -03:00
Joao Victor
34aaf07fed Merge branch v2.6.x-release into virtual-backgrounds-skeleton-preview 2022-07-15 17:14:16 -03:00
Paulo Lanzarin
a156db25e4
Merge pull request #15358 from frankemax/fix-audio-infinite-joining
fix(audio): prevent race condition when joining audio
2022-07-15 15:24:14 -03:00
Paulo Lanzarin
383fe89653
Merge pull request #15364 from prlanzarin/u26/refactor/kutils-kboom
refactor: remove kurento-utils-js
2022-07-15 14:53:10 -03:00
prlanzarin
d06ae5ce40 fix: add default gUM factory to new peer wrapper
For scenarios such as preview-less camera sharing, old echo test
2022-07-15 17:07:15 +00:00
Anton Georgiev
f2e25768c7
Merge pull request #15390 from ramonlsouza/merge25-26-jul14
chore: Merge v2.5.3 into v2.6
2022-07-15 11:43:17 -04:00
Ramon Souza
83d9feb9c0 fix missing import in audio controls 2022-07-15 11:41:11 -03:00
prlanzarin
cd9b8ccef4 fix: handle Firefox stream cleanup edge case (peer.js)
Firefox doesn't fire the ended evt/onended callback for live
 MediaStreamTrack(s). We rely on that event.

 Manually emit the ended event which works with the onended callback
 when a track is stopped
2022-07-15 14:25:37 +00:00
Ramon Souza
d08ff18add Merge remote-tracking branch 'upstream/v2.6.x-release' into merge25-26-jul14 2022-07-15 11:12:25 -03:00
Ramon Souza
db5ac1428a Merge tag 'v2.5.3' into merge25-26-jul14 2022-07-15 11:08:02 -03:00
prlanzarin
45049cbd65 refactor: swap kurento-utils for new peer wrapper in screen sharing and audio 2022-07-15 14:00:12 +00:00
prlanzarin
6a4ceac61f refactor(webcam): swap kurento-utils for the new peer wrapper 2022-07-15 14:00:12 +00:00
prlanzarin
7281475271 feat: add new peer wrapper to phase out kurento-utils
kurento-utils is unmaintained. It's served us well, but its age
shows.  We need to transition to something else if we want to
have better  maintainability and include simulcast, multistream, ...

This introduces a simplified/leaner wrapper kit that's almost
API-compatible with what we use right now - so widespread changes
are minimal). It's easier to maintain/read/transition from. This
can be read as an intermediate step to transitioning to
something definitive (ie mediasoup-client).
2022-07-15 13:51:03 +00:00
Ramón Souza
267a6f5c9c
Merge pull request #15203 from ramonlsouza/improve-ghost-button-border
style: improve ghost buttons border in low density display
2022-07-15 12:06:59 +01:00
Ramón Souza
da848e990a
Merge pull request #15320 from gabriellpr/dark-light-buttons
Styling light and dark buttons
2022-07-13 21:03:46 +01:00
gabriellpr
1c2f9e9cd9
Update styles.js 2022-07-13 16:35:02 -03:00
Paulo Lanzarin
3e8ccd370d
Merge pull request #15375 from prlanzarin/u26/fix/local-echo-gUM-block
fix(audio): block audio join while gUM isn't resolved (local echo)
2022-07-13 15:57:02 -03:00
gabriellpr
49f12c43af
Merge branch 'v2.6.x-release' into dark-light-buttons 2022-07-13 15:36:31 -03:00
prlanzarin
27896e74e6 fix(audio): block audio join while gUM isn't resolved (local echo)
The new local echo view doesn't block the "Join audio" button while
awaiting for getUserMedia permission to be granted/denied. That may
cause unexpected behavior when unattentive users just click "Join audio"
without granting or denying gUM.

This commit accounts for gUM resolution when deciding whether to block
the "Join audio" button. It also includes an extra "isConnecting" check
to it to avoid spam-clicking issues.
2022-07-13 14:35:37 +00:00
Ramón Souza
04386dfcd5
Merge pull request #15212 from gabriellpr/styling-buttons
style: Revised styles for our secondary buttons
2022-07-13 15:22:49 +01:00
Ramón Souza
a0f80e0efb
Merge pull request #15353 from gabriellpr/contrast-record-indicator
Improving contrast on recording indicator
2022-07-13 15:20:36 +01:00
prlanzarin
7b76d2e88f fix: change local echo Stop hearing locale to Stop audio feedback 2022-07-13 13:59:49 +00:00
Anton Georgiev
1393e4a7de
Merge pull request #15352 from germanocaumo/tldraw-z-f
fix(tldraw): initial/viewer zoom fixes + presToolbar height
2022-07-13 09:42:36 -04:00
Anton Georgiev
70c084bfdb
Merge pull request #15300 from JoVictorNunes/fix-focus-loss-Jun-30
fix: disable Tldraw autofocus
2022-07-13 09:39:06 -04:00
Paulo Lanzarin
64af188f1b
Merge pull request #15371 from prlanzarin/u26/fix/webcam-oninactive
fix(webcam): handle stream inactivation/gUM revocations
2022-07-13 10:37:36 -03:00
Anton Georgiev
20762cfac6
Merge pull request #15310 from germanocaumo/tldraw-production-fix
fix(tldraw): fix shapes not persisting in production +
2022-07-13 09:36:44 -04:00
prlanzarin
029c957b22 fix(webcam): handle stream inactivation/gUM revocations
The 'inactive' event is fired whenever the stream gets inactive (ie it
cannot be used anymore), and there are scenarios where that is
unexpected behavior and must be handled accordingly.
The main example of that is when gUM permissions are revoked by the user
via the browser's permission management panel.
Since MediaStream/Track inactive events aren't being handled in such
scenarios, what actually happens is that the camera just freezes without
further indication why.

This commit handles those scenarios in both video-preview and
video-provider by:
  - 1) correctly stopping the camera (provider)
  - 2) surfacing a toast (provider) or error indication (preview)
2022-07-12 22:03:01 +00:00
prlanzarin
e93440e15a refactor(webcam): fix linter errors in BBBVideoStream 2022-07-12 17:50:16 +00:00
Daniel Petri Rocha
5f98290413 Add presentationWithAnnotationDownload, exportPresentationWithAnnotation to disabledFeatures 2022-07-12 18:58:56 +02:00
prlanzarin
fba2c88494 fix(audio): make hearing a transient prop in local-echo
Prevents annoying console exceptions in dev mode
2022-07-12 16:37:36 +00:00
Joao Victor
cca17f9def fix(chat): property access 2022-07-12 10:25:50 -03:00
Anton Georgiev
40a8034070
Merge pull request #15313 from antonbsa/test-fixes-v2.6
test: Fix v2.6 tests
2022-07-11 18:21:33 -04:00
Anton B
d00699561f fix data-test props to same quote type 2022-07-11 17:35:14 -03:00
Max Franke
70bf69182a fix(audio): prevent race condition when joining audio
Sometimes the handler that listens for the state change in the callState is
not updated correctly.
In these rare cases, the state of the callstate changes directly to in_conference,
not taking the expected path: call_started -> in_echo_test -> in_conference
2022-07-11 14:09:43 -03:00
Joao Victor
2f78edddf3 fix: add suport for disabling upload of custom backgrounds through custom parameter 2022-07-08 17:01:57 -03:00
Gabriel Porfirio
aecc5fa710 WIP: improving contrast on recording indicator 2022-07-08 14:39:14 -03:00
gabriellpr
17a1bc086f
Update styles.js 2022-07-08 13:53:30 -03:00
germanocaumo
0c75b3ce02 fix(tldraw): correctly get toolbar height
This solves the problem where the toolbar is not counted in the slide area space, so the presentation would stay behind the toolbar when zoomed out
2022-07-08 15:45:55 +00:00
Joao Victor
8809ff3a65 fix: add missing activity date in drag & drop handler 2022-07-08 12:26:01 -03:00
Joao Victor
915ffce3c6 improvement: sort buttons by recently used/uploaded 2022-07-08 12:16:37 -03:00
germanocaumo
217fd6c06e fix(tldraw): wrong initial/viewer zoom
Fixes a case when the presentation is just uploaded and a wrong initial zoom was set.
Also fix viewer zoom not correclty adjusting to the area size when zoomed out.
2022-07-08 15:06:00 +00:00
Joao Victor
f8ec4ef640 refactor: virtual background context 2022-07-07 18:59:30 -03:00
Max Franke
52e27e8030 feat(emoji-picker): dynamic filter emojis
Configure filtered emojis via settings.yml
Emojis can be filtered by their unicodes
2022-07-07 13:12:35 -03:00
gabriellpr
f848d31014 modifying specific buttons
removing border and implementing box-shadow

adding transparent border

passing styles to common buttons

adding secundary color to component

updating color components
2022-07-07 10:45:54 -03:00
prlanzarin
a6861a16d5 fix: don`t ignore settings.yml virtualBackgrounds.enabled config 2022-07-07 12:37:32 +00:00
Ramón Souza
1b03b1fd50
Merge pull request #15301 from KDSBrowne/z-26-rtl-cursor
Fix RTL Cursor Position on Whiteboard
2022-07-06 21:40:19 +01:00
KDSBrowne
046518abe5 handle cursor positions for smart layout 2022-07-06 20:03:04 +00:00
Joao Victor
8481103e47 improvement(virtual background): loading skeleton, custom backgrounds in video preview modal 2022-07-06 16:03:55 -03:00
Mario Junior
72854de683
Merge pull request #15295 from iMDT/v2.6.x-mobile
feat (mobile screenshare): Add replacement webRTC methods for screenshare and full audio in mobile (when running in BigBlueButtonMobile app)
2022-07-06 15:46:25 -03:00
KDSBrowne
42acca2124 handle cursor position for all custom layout orientations 2022-07-06 17:17:05 +00:00
Anton B
d6f32f3422 Merge remote-tracking branch 'upstream/v2.6.x-release' into test-fixes-v2.6 2022-07-06 11:07:00 -03:00
Ramón Souza
f66481411e
Merge pull request #15239 from JoVictorNunes/issue-15059
fix: screen sharing data saving option
2022-07-06 14:42:41 +01:00
Ramón Souza
16d871bdb5
Merge pull request #15174 from ramonlsouza/fix-poll-results-chat
fix: wrong poll results displayed in the chat when answers are grouped
2022-07-06 14:42:28 +01:00
Anton Georgiev
eca4ebe56f
Merge pull request #15221 from MaximKhlobystov/25-test-update
test: New 2.5 tests + links from test specs to 2.5 test plan
2022-07-06 09:39:49 -04:00
Joao Victor
aaf7f8e78e improvement(virtual background): better error handling, notifications, performance 2022-07-06 10:38:40 -03:00
KDSBrowne
b075cf822b fix delay minimizing presentation | display default cursor for no MUA 2022-07-05 20:16:55 +00:00
Ramon Souza
29d597f7df Merge remote-tracking branch 'upstream/v2.6.x-release' into improve-ghost-button-border 2022-07-05 14:06:19 -03:00
Ramon Souza
d55ee67f5e Merge remote-tracking branch 'upstream/v2.6.x-release' into fix-duplicated-label-webcam 2022-07-05 14:02:02 -03:00
Anton Georgiev
4595b6688f
Merge pull request #15244 from germanocaumo/tldraw-recording
fix(whiteboard): tldraw recording processing/publishing
2022-07-05 08:55:01 -04:00
gabriellpr
8d75eddd88 WIP: styling light and dark buttons 2022-07-05 09:05:46 -03:00
Ramón Souza
a1ac9fe11d
Merge pull request #15293 from ramonlsouza/restore-audio-shortcuts
fix: audio shortcuts regression
2022-07-04 21:09:27 +01:00
Tiago Jacobs
9ea4171af6 Add support to 2.6 by initializing stream active flag 2022-07-04 16:19:38 -03:00
Joao Victor
4ab0a82c7a refactor: Icon component rotate info 2022-07-04 12:27:46 -03:00
Ramon Souza
9e246093f9 remove duplicated webcam label 2022-07-04 10:41:27 -03:00
germanocaumo
8cacd96a0c fix(tldraw): fix shapes not persisting in production +
Tldraw uses the constructor name for session complete names:
80ed0bf27b/packages/tldraw/src/state/TldrawApp.ts (L2916)
So in production they are changed because of js minifier.

I changed the onCommand reactor to be one generic for all session:complete actions.
Also fixed some crashes with grouping and ungrouping shapes, in those cases the order of adding/removing is important because children have a reference to the father (grouping shape).
2022-07-02 14:16:45 +00:00
Anton B
c71e5c9f74 test: fix all 2.6 tests and temporarily skip inconsistent ones 2022-07-01 17:55:32 -03:00
Ramon Souza
67abbe9489 only remove annotations/cursors when multiUser is disabled 2022-07-01 14:38:12 -03:00
Ramon Souza
f74beed916 fix(whiteboard): don't hide presenter's cursor 2022-07-01 14:37:23 -03:00
Ramon Souza
b5cf43b04e fix: cursor displaying for another users 2022-07-01 14:35:16 -03:00
Ramon Souza
4acbce94cd fix: clear cursors data on multi-user whiteboard off 2022-07-01 14:32:34 -03:00
Joao Victor
66d3d2c13b fix: clear fake annotations on multi-user whiteboard off 2022-07-01 14:31:14 -03:00
Paulo Lanzarin
3b820b60a9
Merge pull request #15299 from prlanzarin/u26/fix/vbg-stall
fix(webcam): prevent camera freeze due to _renderMask exceptions
2022-07-01 12:53:59 -03:00
Ramón Souza
baf7aa857a
Merge pull request #15304 from JoVictorNunes/fix-virtual-background-thumb-Jun-30
improvement: virtual background selector thumbnail
2022-07-01 14:05:39 +01:00
Joao Victor
93d98d9b3e fix: margin unit 2022-06-30 17:10:48 -03:00
Joao Victor
5e2c113cae improvement: virtual background selector thumbnail 2022-06-30 16:39:50 -03:00
Gustavo Trott
807f0286c9
Merge pull request #14786 from paultrudel/recording-api-changes 2022-06-30 15:57:23 -03:00
KDSBrowne
438afa7db1 fix RTL cursor position 2022-06-30 16:48:42 +00:00
Joao Victor
ddcaa9590f fix: disable Tldraw autofocus 2022-06-30 13:23:35 -03:00
germanocaumo
c2db91b5f9 Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into tldraw-recording 2022-06-30 14:31:08 +00:00
prlanzarin
0c7c628f7a fix(webcam): prevent camera freeze due to _renderMask exceptions
Under some scenarios, cameras are freezing when the virtual background
code is running due to runPostProcessing(_renderMask) throwing
NS_ERROR_FAILURE - mainly on Firefox - consequently preventing
subsequent TimerWorker ticks from being scheduled.
Cases where I've seen that happen are:
  - conferences running under an iframe where the iframe is briefly
    stalled for some reason

Address the issue with a try-catch and a log for debugability (it's high
frequency, hence why not error level). We should probably remove the log
entirely once we figure out why the post-processing method is failing.
2022-06-30 13:50:53 +00:00
Ramón Souza
1181b54a55
Merge pull request #15279 from KDSBrowne/2.6-mobile-cursor-fix
Fix Cursor Not Updating For Mobile
2022-06-30 14:10:11 +01:00
Gustavo Emanuel Farias Rosa
b13039c31f Detect screen share stop and propagate it to the application 2022-06-29 17:38:40 -03:00
Tiago Jacobs
2b953a47bb Add structure to detect and forward full audio calls to mobile application 2022-06-29 17:38:38 -03:00
Tiago Jacobs
092f5bcafd Add logic to skip webRTC replacement methods when it's not a screenshare 2022-06-29 17:38:34 -03:00
Tiago Jacobs
f459aec949 Fixes variable name to avoid colision with reserved arguments variable 2022-06-29 17:38:29 -03:00
Tiago Jacobs
75c8dcd491 Merge 2.6 2022-06-29 17:38:21 -03:00
KDSBrowne
bf62362162 only render cursor label when mutiuser enabled 2022-06-29 20:27:14 +00:00
Paulo Lanzarin
8f6b65b23c
Merge pull request #15290 from prlanzarin/u26/fix/button-audio-props
fix: omit unused props in talking-indicator, input stream selector and EmojiButton
2022-06-29 16:45:57 -03:00
Paulo Lanzarin
240bb9e1cb
Merge pull request #15292 from prlanzarin/u26/fix/audio-undef-broker-onstop
fix(audio): check if broker exists before trying to stop
2022-06-29 15:42:05 -03:00
Paulo Lanzarin
885e0ca72c
Merge pull request #15281 from prlanzarin/u26/fix/sxs-callerId
feat: add user name to checkAuthorization response, [...]
2022-06-29 15:40:42 -03:00
Ramon Souza
a29b651d9c restore audio mute / leave shortcuts 2022-06-29 15:19:30 -03:00
prlanzarin
f026c397d9 fix(audio): check if broker exists before trying to stop
There are scenarios where the full audio broker (SFU) stop  procedure
may be called multiple times in a very short timestamp - eg a concurrent
stop + connection failure; a timeout in the transfer procedure + a
reconnect attempt, [...]. When that happens, calls to exitAudio may throw
errors if the broker was already released - and that's not the expected
behavior.
2022-06-29 17:44:52 +00:00
prlanzarin
0fead2ebbb fix: omit unused props in talking-indicator, input stream selector and emoji button
The talking-indicator, emoji-button and input-live-stream-selector
components are passing props downstream that weren't omitted or handled
by inherited components (Button, Icon). That causes a handful of error
logs to be spammed in the console of dev environments, which is
annoying.

This commit addresses the issue by:
  - Making the talking, spoke, muted and isViewer props transient
    (styled-components) - which means they won't reach the DOM (as
    expected since they're style-only)
  - Omitting the EmojiButton `rotate` prop in the Icon component itself
    * Made that instead of transient because might be useful to migrate
      the rotate code to the Icon component?
2022-06-29 17:15:46 +00:00
Ramón Souza
9a480c247c
Merge pull request #15256 from ramonlsouza/issue-15252
fix: Recording indicator too subtle
2022-06-29 17:04:28 +01:00
Ramón Souza
ffb41cb90f
Merge pull request #15278 from KDSBrowne/2.6-disable-hover-slidebg
Disable Background Slide Image Hover Highlight
2022-06-29 14:31:30 +01:00
Anton Georgiev
046dce804a
Merge pull request #15280 from JoVictorNunes/undefined-values-Jun-28
fix: add check for potential undefined userId
2022-06-28 16:47:52 -04:00
Joao Victor
4b9f16ca0f fix: add check for potential undefined userId 2022-06-28 17:41:03 -03:00
prlanzarin
602238b84e refactor(audio): remove caller ID from fullaudio bridge start request
The callerId is assembled server-side as of bbb-webrtc-sfu
v2.9.0-alpha.3 based on the work done in commit
d940bff541b6fe3c4976428ca471457bc67ac97e.
2022-06-28 20:33:36 +00:00
KDSBrowne
c702cc34a4 remove cursors from wb when multiuser is disabled 2022-06-28 20:13:05 +00:00
Ramon Souza
bcd508712e prevent chat-context crash 2022-06-28 16:26:25 -03:00
KDSBrowne
33e19124c1 disable shape selection for users without multiuser access 2022-06-28 19:16:35 +00:00
Joao Victor
3ea33ce3ac fix: apply presentation 'isCurrent' changes to local state 2022-06-28 13:33:54 -03:00
KDSBrowne
ee6a3dcc62 fix cursor not updating on mobile 2022-06-28 14:25:43 +00:00
KDSBrowne
2d7ef92581 disable hover highlight for background slide image 2022-06-28 14:15:20 +00:00
Ramón Souza
74287a204e
Merge pull request #15266 from gabriellpr/modal-audio-design
fix: microphone design inside audio modal
2022-06-28 14:25:45 +01:00
mvasylenko
a2164e45d9 fix for issue #15209
Some slides of presentation not selectable if image is embedded
2022-06-28 09:10:18 -03:00
gabriellpr
a3e17490f4 WIP: fix microphone design inside audio modal 2022-06-27 15:23:57 -03:00
Ramon Souza
c3f0c079e5 add big recording indicator for viewers when record is active 2022-06-24 16:25:42 -03:00
Ramon Souza
45dae6953d external upload area in presentation upload modal 2022-06-24 13:47:17 -03:00
germanocaumo
853d0dfd9b fix(whiteboard): tldraw recording processing/publishing
Changed the names of tldraw record events to differentiate from before.
Publish tldraw.json file with all shape information during the meeting to be used in playback.
Adapted cursor.xml and panzoom.xml to store tldraw data.
Publish slides svgs to be used by playback's tldraw component (otherwise we have different image sizes in pngs and thus messing the coordinates).
Retro-compatible with old recordings.
2022-06-23 17:04:09 +00:00
Joao Victor
24504178a6 fix: screen sharing data saving option 2022-06-23 10:05:11 -03:00
Ramón Souza
88697650a2
Merge pull request #15232 from antobinary/merge-252
chore: Merge BBB 2.5.2 into 2.6.x
2022-06-22 19:05:27 +01:00
Ramon Souza
adbe90582e Merge remote-tracking branch 'upstream/v2.5.x-release' into fix-expression-assignment-25 2022-06-22 14:44:20 -03:00
Anton Georgiev
4402f20c34 chore: Merged BBB 2.5.2 into v2.6.x-release 2022-06-22 16:11:48 +00:00
Anton Georgiev
10b0d47257
Merge pull request #15178 from gabriellpr/presentation-menu
refactor: Adding bbbmenu component to presentation menu
2022-06-22 11:42:53 -04:00
Anton Georgiev
37933d1c11
Merge pull request #15229 from ramonlsouza/fix-get-secret-poll-value
fix: secret poll value not recalculated
2022-06-22 11:22:17 -04:00
Anton Georgiev
8955267988
Merge pull request #15181 from ramonlsouza/user-leave-fix
fix: users counter inconsistent
2022-06-22 11:21:57 -04:00
Ramon Souza
560b53a452 fix first anon poll live-result 2022-06-22 10:17:59 -03:00
KDSBrowne
a899bbeb79
Merge branch 'v2.6.x-release' into 2.6-wb-options-dropdown 2022-06-21 23:16:31 -04:00
KDSBrowne
dd37a2479f fix menu position in rtl and iPhone 2022-06-22 03:11:25 +00:00
Ramon Souza
27f1e75500 fix secret poll value recalculation 2022-06-21 17:40:48 -03:00
Ramon Souza
6066fdec9f fix assignment in expression 2022-06-21 13:42:46 -03:00
gabriellpr
0e831c86cc adding tooltip-container 2022-06-21 08:53:06 -03:00
Maxim Khlobystov
72213eb91d New connection status test specs 2022-06-20 20:22:14 -04:00
Maxim Khlobystov
93a94ca88f Fit to width and multi-presentation upload 2022-06-20 19:02:10 -04:00
mvasylenko
e0784b9c18
fix for issue #15209
Some slides of presentation not selectable if image is embedded
2022-06-20 15:50:49 +02:00
Ramón Souza
97f6857fd3
Merge pull request #15189 from KDSBrowne/2.6-disable-fd
fix: Disable File Drop on Whiteboard
2022-06-20 13:19:34 +01:00
Ramón Souza
d3fc924f10
Merge pull request #15137 from KDSBrowne/2.6-toolbar-zoom-val
Display Correct Zoom Value on Presentation Restore
2022-06-20 13:11:25 +01:00
KDSBrowne
3b44d17417 restore WB snapshot image download 2022-06-17 19:10:23 +00:00
KDSBrowne
4f9f9c11d3 fix viewer zoom reset when presenter remounts presentation 2022-06-17 00:35:27 +00:00
Ramon Souza
04f3b50d0d improve ghost buttons border 2022-06-16 16:59:01 -03:00
Ramon Souza
edeb70de0d Merge tag 'v2.5.1' into merge25-26-jun16 2022-06-16 13:58:54 -03:00
gabriellpr
449d6ca463 fix fullscreen not working normally 2022-06-16 13:32:27 -03:00
Ramón Souza
851340d551
Merge pull request #15154 from frankemax/unify-audio-buttons-27
feat(audio): unify audio buttons
2022-06-16 13:28:12 +01:00
KDSBrowne
8df5e3de02 recover presentation option menu | position inside tldraw menu 2022-06-15 22:10:42 +00:00
KDSBrowne
8dac344f43 replace zoom minBound with zoomed state 2022-06-15 19:46:06 +00:00
KDSBrowne
5828ed2149 add comment 2022-06-15 17:55:14 +00:00
KDSBrowne
6546b32585 disable dropping of assets on whiteboard 2022-06-15 17:43:58 +00:00
Max Franke
a1860f3dd4 fix(audio): select device dropdown icon position
Move the 'leave' icon to the left-hand side
2022-06-15 12:07:51 -03:00
Max Franke
9dfef30dba fix(audio): select device dropdown colors
Set list titles colors to colorGrayDark
Set active devices background color to off-white
2022-06-15 12:00:40 -03:00
Ramón Souza
86a05cd431
Merge pull request #15156 from gabriellpr/etherpad-cutting-text
fix: Etherpad cutting off text
2022-06-15 13:15:59 +01:00
Gustavo Trott
565b36c263
Merge pull request #15176 from mariogasparoni/fix-15169 2022-06-14 16:47:24 -03:00
Ramón Souza
e56b821f40
Merge pull request #15143 from ramonlsouza/current-poll-presenter
fix: re-subscribe to current poll when presenter changes
2022-06-14 20:17:37 +01:00
Ramon Souza
2dc00ddf35 handle user leave for viewers 2022-06-14 11:29:59 -03:00
Ramón Souza
fd76d35b0b
Merge pull request #15102 from JoVictorNunes/v2.5.x-release
fix(chat notification): duplication of first message notification
2022-06-14 15:25:17 +01:00
Ramón Souza
1446bfb163
Merge pull request #15139 from JoVictorNunes/issue-15060
fix(tooltip): wait 150ms to hide the tooltip
2022-06-14 15:24:06 +01:00
Ramón Souza
a4337f620e
Merge pull request #15173 from JoVictorNunes/issue-15168
fix: presenter indicator in RTL layout
2022-06-14 15:23:18 +01:00
Ramón Souza
7b1af1891b
Merge pull request #15153 from JoVictorNunes/issue-15133
fix(connection status modal): network status icon
2022-06-14 15:22:42 +01:00
Ramón Souza
933d9b438b
Merge pull request #15148 from ramonlsouza/rename-snapshot-feature
Rename snapshot button label
2022-06-14 15:21:15 +01:00
Ramón Souza
549f9499ba
Merge pull request #15123 from ramonlsouza/issue-15112
fix: Wrong aggregation of broadcast messages to breakout room
2022-06-14 15:20:13 +01:00
Ramón Souza
b0f6df6de5
Merge pull request #15124 from JoVictorNunes/issue-15113
fix(chat): show new message indicators for poll mesages
2022-06-14 15:19:23 +01:00
Ramón Souza
aa044105a9
Merge pull request #15130 from gabriellpr/replace-dependency
chore: Swap version of bbb-diff npm dependency
2022-06-14 15:18:34 +01:00
Ramón Souza
441e275f4f
Merge pull request #15117 from gabriellpr/export-chat-bug
fix: missing "chat has been cleared" message at chat export
2022-06-14 15:17:38 +01:00
gabriellpr
7adbce8e32 WIP:adding bbbmenu component to presentation menu 2022-06-14 10:18:40 -03:00
Joao Victor
ddb63f8e71 fix: restore virtual background after leaving breakout room #15111 2022-06-14 09:40:13 -03:00
Mario Jr
e3ad7aea0c fix(audio): moderator not able to transfer audio to breakout room
Closes #15169
2022-06-14 09:00:42 -03:00
Ramon Souza
69eba762d3 fix grouping of poll results in chat 2022-06-13 13:08:44 -03:00
KDSBrowne
53f4224fd1 Merge branch '2.6-toolbar-zoom-val' of https://github.com/KDSBrowne/bigbluebutton into 2.6-toolbar-zoom-val 2022-06-13 15:40:42 +00:00
KDSBrowne
15e58c0f69 stop zoom out at min % 2022-06-13 15:39:34 +00:00
Joao Victor
8cbf23ad7b fix: presenter indicator in RTL layout #15168 2022-06-13 11:52:26 -03:00
Anton Georgiev
696960f7b5
Merge pull request #15146 from antonbsa/2.5-tests-fix-and-ci-improvements
test: v2.5 tests fixes and CI improvements
2022-06-10 16:47:23 -04:00
gabriellpr
ec34e7e105 etherpad cutting text
fixing etherpad alignment for lock viewers

removing break words

fix: break-word

adding white-space
2022-06-10 16:00:54 -03:00
Ramón Souza
4609f9f246
Revert "fix: user not removed from users context on leave" 2022-06-10 09:52:00 -03:00
Ramon Souza
11b85783d6 fix user not removed from users context on leave 2022-06-09 13:47:43 -03:00
Max Franke
1c6577f4db feat(audio): unify audio buttons
Move device selection dropdown to microphone button
Move option 'leave audio' to an option within the dropdown
Remove the audio exit button when device !== mobile
2022-06-09 13:37:37 -03:00
Joao Victor
4c238392b2 fix(connection status modal): data saving settings button 2022-06-09 12:01:05 -03:00
Joao Victor
b191a8d63b fix(connection status modal): network status icon color #15133 2022-06-09 11:58:57 -03:00
Ramon Souza
4f3600e683 rename snapshot button label 2022-06-08 15:24:46 -03:00
Ramon Souza
507a594cae remove unused code 2022-06-08 09:40:24 -03:00
Anton B
de1c7043a9 test: fix/update tests on v2.5 2022-06-08 09:29:21 -03:00
Ramón Souza
44c24cf249
Merge pull request #15131 from ramonlsouza/audio-modal-polishing
Audio modal polishing
2022-06-08 13:25:43 +01:00
Ramon Souza
375635c797 re-sub to current poll when presenter changes 2022-06-07 16:54:09 -03:00
Joao Victor
887b1a588a fix(tooltip): wait 150ms to hide the tooltip 2022-06-07 10:59:18 -03:00
Ramón Souza
7a005efc88
Update bigbluebutton-html5/imports/ui/components/common/button/styles.js
Co-authored-by: João Victor Nunes <62393923+JoVictorNunes@users.noreply.github.com>
2022-06-07 10:06:32 -03:00
KDSBrowne
668be68b8e fix zoom value reset on unmount / mount 2022-06-06 20:30:34 +00:00
Ramon Souza
8ce74903db remove unused custom button styles 2022-06-06 14:44:30 -03:00
Ramon Souza
1c17e9ad95 adjust external video button 2022-06-06 14:33:15 -03:00
Ramon Souza
fe8ffbd2a5 revised styles primary button 2022-06-06 14:26:13 -03:00
Ramón Souza
bb29cd1d68
Merge pull request #15121 from KDSBrowne/2.6-lock-cursor
Restore Viewer Cursors Lock Functionality
2022-06-06 13:54:43 +01:00
Ramon Souza
242f5d3e29 audio modal spacing polishing 2022-06-03 16:10:09 -03:00
gabriellpr
79ed1d289b Swap version of bbb-diff npm dependency 2022-06-03 14:00:44 -03:00
Ramón Souza
c489303672
Merge pull request #15128 from gabriellpr/line-space-pads
fix: pad line space not showing for viewers
2022-06-03 17:13:00 +01:00
gabriellpr
bdb703a056 fix: pad line space not showing
flex column removed
2022-06-03 12:10:47 -03:00
Joao Victor
de6800dc98 fix(chat): show new message indicators for poll mesages 2022-06-02 15:54:03 -03:00
Ramón Souza
f6b190aaa8
Merge pull request #15078 from lfzawacki/develop-layout
fix(layout): Fix propagation bugs and allow moderators to set the pushLayout flag
2022-06-02 19:48:07 +01:00
Ramon Souza
0f6a638551 do not group moderator message sent to all breakouts 2022-06-02 13:47:49 -03:00
KDSBrowne
6d4d11a34d fix cursors lock for viewers 2022-06-02 15:00:28 +00:00
Ramón Souza
162c89d701
Merge pull request #15095 from ramonlsouza/issue-7653
style: Revised styles for our primary circle buttons
2022-06-02 13:19:51 +01:00
Joao Victor
b75fbe8279 Remove merge residue 2022-06-01 16:55:28 -03:00
Joao Victor
2a1401f2ae Merge remote-tracking branch v2.6.x-release into virtual-background-upload 2022-06-01 16:50:29 -03:00
Joao Victor
bfe3472609 fix: remove style prop 'isVisualEffects' from button props 2022-06-01 14:46:43 -03:00
Joao Victor
1c02ff3877 fix: make drag-and-drop stuff follow the config 2022-06-01 14:30:50 -03:00