Commit Graph

12158 Commits

Author SHA1 Message Date
Ramón Souza
192b44ce79
Merge pull request #18643 from ramonlsouza/fix-self-view-label
fix: disable self-view label
2023-08-25 14:11:13 -03:00
GuiLeme
0aacb12cc8 [issue-18408-back-end] - added disabled download of converted presentation 2023-08-25 11:37:32 -03:00
GuiLeme
2cf6720b5f [issue-18408-back-end] - change name of download original pres 2023-08-25 09:27:01 -03:00
prlanzarin
38965d100c fix: expose camera as content in mobile endpoints
It's actively blocked in code, but I think that's an oversight -
probably leftover from an initial iteration of the feature.
It should be useful in mobile endpoints and it's also supposed to work
seamlessly due to how the feature is implemented.

Lift the mobile block and expose "camera as content" in the presenter's
actions dropdown.
2023-08-24 18:49:53 -03:00
Anton Georgiev
527ecab8b2
Merge pull request #18642 from antobinary/aug22merge
chore: Merge 2.6.12 into BBB 2.7
2023-08-24 16:41:40 -04:00
Anton Georgiev
1186db7712 Merge remote-tracking branch 'bbb/v2.6.x-release' into aug22merge 2023-08-24 15:05:20 -04:00
Anton Georgiev
d52c398ec8
Merge pull request #18630 from Arthurk12/bbb/18431+
fix(wake-lock): remove the activation notification, increase the clarity of the faulire notification message
2023-08-24 14:48:00 -04:00
Ramón Souza
48aa8df5a3 fix self-view label 2023-08-24 15:41:06 -03:00
Ramón Souza
4867e934e2 add .cancel in throttle function 2023-08-24 14:49:05 -03:00
prlanzarin
c5b6110b94 fix: correctly dereference present camera streams in FF
The original BBBVideoStream termination handlers are being overwritten
by screen sharing's service when "Present camera" is started, which
causes the stream not to be dereferenced in the VIDEO_STREAM_STORAGE
map when the camera presentation stops. This breaks subsequent
camera/present camera attempts for the affected deviceId.

The second issue with is that Chrome isn't assigning the
termination handlers for the screen sharing subsystem - which causes
device/permission ejections to be silent.

This extends screen sharing's trackStreamTermination routine to preserve
whatever previous termination handlers were assigned if the stream was
provided beforehand by an external caller - which should fix both of the
aforementioned issues.
2023-08-24 13:42:28 -03:00
Arthurk12
8312e235f8 fix(wake-lock): remove the activation notification
Removes the activation notification for the wake lock to reduce visual noise.
2023-08-23 10:06:33 -03:00
Ramón Souza
bc2ce9dff9
Merge pull request #18226 from Tainan404/dedupe-chat-messages
fix: Add dedupe to messages based on referenceId (backport of #18230 from 2.7)
2023-08-22 16:35:53 -03:00
Tainan Felipe
cc85a33c7d Add Fix for users that change role 2023-08-22 16:27:18 -03:00
Ramón Souza
0d911a0102
Merge pull request #18597 from KDSBrowne/bbb-17982-2
fix: Handle Slide Change With Fit To Width
2023-08-22 12:04:57 -03:00
GuiLeme
97ac358ee0 [issue-18449] - changes in review 2023-08-22 11:53:38 -03:00
GuiLeme
b09e01518f Merge remote-tracking branch 'upstream/v2.7.x-release' into issue-18449 2023-08-22 11:02:40 -03:00
Ramón Souza
1388c95706
Merge pull request #18542 from Arthurk12/bbb/18431
feat(wake-lock): enable implicit activation based on the default setting
2023-08-22 09:41:26 -03:00
Ramón Souza
7615fb1f85
Merge pull request #18572 from ramonlsouza/add-username-grid
fix: display username in grid mode
2023-08-21 13:09:12 -03:00
KDSBrowne
c321eca70f fix presentation jerks while panning 2023-08-20 02:33:40 +00:00
KDSBrowne
399b9e805d handle slide change with fit to width 2023-08-20 00:21:03 +00:00
Ramón Souza
51533da3e2
Merge pull request #18545 from ramonlsouza/fix-warn
refactor: fix invalid prop warnings
2023-08-18 14:17:43 -03:00
GuiLeme
cf472511fc [issue-18449] - changes in review 2023-08-18 10:57:50 -03:00
Anton Georgiev
cb121f7803 fix(html5): backport Replace wasm detection library #18557 to 2.6 2023-08-17 11:16:39 -04:00
Anton Georgiev
49f8d95f11
Merge pull request #18537 from ramonlsouza/issue-18443
refactor(bbb-html5): Reactions - allow for two alternative views
2023-08-17 10:38:56 -04:00
Ramón Souza
eac3cc84ab display username in grid mode 2023-08-16 16:54:43 -03:00
KDSBrowne
901d9ac5ac add whiteboard options menu dropdown to autohide elements 2023-08-16 14:36:59 +00:00
GuiLeme
3761fc333b [plugin-architecture-implementation] - fix for disable downloadable 2023-08-16 11:18:51 -03:00
Anton Georgiev
8cc8bfab00
Merge pull request #18387 from ramonlsouza/issue-18125
feat(bbb-html5): Grid mode pagination
2023-08-16 09:36:50 -04:00
GuiLeme
c10df4c173 [issue-18449] - changes in review 2023-08-15 10:58:37 -03:00
GuiLeme
08f1b5832d [issue-18449] - changes in review 2023-08-15 10:30:17 -03:00
Ramón Souza
2e2b2d5b31 fix prop warnings 2023-08-14 10:47:23 -03:00
Ramón Souza
5bf6d0489a fix empty grid users object when pagination is disabled 2023-08-14 09:52:52 -03:00
Ramón Souza
c5872e9cd3 rename grid page sizes -> grid sizes 2023-08-14 09:46:05 -03:00
Ramón Souza
0b8c493381 return gridUsers when pagination is disabled 2023-08-14 09:30:53 -03:00
Anton Georgiev
e2cdd68bac
Merge pull request #18516 from ramonlsouza/2627-aug10
chore: Merge 2.6 into 2.7
2023-08-11 17:13:21 -04:00
Arthurk12
c52a35834e feat(wake-lock): enable implicit activation based on the default setting
This commit removes the wake lock activation toast along with the
enable/disable buttons, implementing the wake lock implicit activation
behavior. The wake lock feature is implicitly activated if the
`defaultSettings.application.wakeLock` in the `settings.yml` file is set
true. For mobile devices that do not support the API or fail when
requesting a wake lock, toasts are raised explaining that calls will be
dropped when the screen turns off.

In cases where `defaultSettings.application.wakeLock` is set false, users
can enable the wake lock manually through the settings menu.
2023-08-11 17:42:20 -03:00
KDSBrowne
822aabe6d1 fix: Move Presentation Option Dropdown To The Left Side (#18538)
* prevent duplication of presentation menu dropdown when visible

* move presentation options dropdown to the left (out of tldraw UI)

* adjust style menu UI in RTL
2023-08-11 17:13:33 -03:00
KDSBrowne
af16df385c
fix: Move Presentation Option Dropdown To The Left Side (#18538)
* prevent duplication of presentation menu dropdown when visible

* move presentation options dropdown to the left (out of tldraw UI)

* adjust style menu UI in RTL
2023-08-11 17:10:16 -03:00
Ramón Souza
c598db9c7a display selected emoji in reactions bar button 2023-08-11 11:01:50 -03:00
Paulo Lanzarin
f3bd84e81f
refator(video): guarantee connectStreams scope is valid
The original debounce implementation (lodash) preserved the
caller's context - radash didn't, so it was failing and it wasn't noticed.

The new debounce implementation with the native function seems to preserve caller's context, but as a safety measure this commit binds the method to its appropriate scope.
2023-08-11 10:57:39 -03:00
GuiLeme
85f1bdae51 [issue-18449] - change in the flow, it is not necessary to click to disable one format to enable the other 2023-08-11 10:31:07 -03:00
Ramón Souza
94cb2d5d97 only display reactions bar toggle if reactions are enabled 2023-08-11 10:14:16 -03:00
Ramón Souza
b103448091 Merge remote-tracking branch 'upstream/v2.7.x-release' into issue-18443 2023-08-11 09:36:08 -03:00
Anton Georgiev
09f5b8a464
Merge pull request #18524 from antonbsa/multiple-leave-audio-datatest
fix: Remove leaveAudio data-test from the reaction buttons
2023-08-10 16:37:10 -04:00
Ramón Souza
6d4c140f76 auto close reactions settings 2023-08-10 16:28:21 -03:00
Anton B
b6c73b4a04 fix: remove leaveAudio data-test from the reaction buttons 2023-08-10 16:14:33 -03:00
Anton Georgiev
a3cf5ce935
Merge pull request #18513 from ramonlsouza/fix-disabled-reactions
fix: do not display reactions button if reactions are disabled
2023-08-10 15:13:10 -04:00
GuiLeme
a1746da6fe [issue-18449] - added possibility of download original presentation with original format 2023-08-10 12:18:59 -03:00
Ramón Souza
866c40f84f Merge remote-tracking branch 'upstream/v2.6.x-release' into 2627-aug10 2023-08-10 11:49:01 -03:00
Anton Georgiev
5a878c6526
Merge pull request #18503 from ramonlsouza/native-debounce
refactor: replace debounce function
2023-08-10 09:58:11 -04:00
Anton Georgiev
2e80e406b9
Merge pull request #18469 from ramonlsouza/keyboard-reactions
style: reactions bar improvements
2023-08-10 09:55:30 -04:00
Gustavo Trott
456950a800
Merge pull request #18459 from GuiLeme/issue-18446
fix: download of original presentation
2023-08-10 10:37:11 -03:00
Ramón Souza
fadd035bea do not display reactions button if reactions are disabled 2023-08-10 09:02:08 -03:00
Anton Georgiev
20ea8da9f7
Merge pull request #18460 from ramonlsouza/issue-18437
fix: Display raise hand and away emoji in userlist
2023-08-09 17:19:58 -04:00
Ramón Souza
3bde4c970e
Merge pull request #18456 from ramonlsouza/issue-18434
fix: Labels flowing out of a <div> in breakout rooms creation view
2023-08-09 15:59:14 -03:00
Ramón Souza
38c6da7c29 add comment about debounce function 2023-08-09 15:42:21 -03:00
Ramón Souza
835bbd4733 replace unaffected debounce 2023-08-09 13:26:42 -03:00
Ramón Souza
80094581f6 replace leading:true, trailing: false debounces 2023-08-09 13:12:29 -03:00
Ramón Souza
7fee4d5f95 replace mute debounce 2023-08-09 13:06:57 -03:00
Ramón Souza
c55a9b43b3 add debounce function 2023-08-09 13:06:27 -03:00
prlanzarin
b8a1b881c5 fix(audio): clear connection timeout on autoplay failures
If the autoplay block is triggered in listen only, the connection timer
keeps ticking even if the user correctly accepts the audio play prompt.
That causes an audio re-connect once the timeout expires.

Clear the connection timer if the audio bridge starts with
NotAllowedError as a soft error. For connection purposes, the audio join
procedure worked. The autoplay thing is at the UI/UX level, not WebRTC.
2023-08-09 11:09:27 -03:00
Ramón Souza
e767a39799 centralize emoji, add focus color 2023-08-08 15:28:05 -03:00
KDSBrowne
ea9c687b07 prevent zooming out at 100% 2023-08-08 17:32:07 +00:00
Anton Georgiev
67b7b2a3a4
Merge pull request #18464 from gustavotrott/fix-same-reaction-twice-in-a-row
fix (html5): Unable to choose same Reaction emoji twice in a row
2023-08-08 12:46:11 -04:00
Anton Georgiev
7f6b7b2e74
Merge pull request #18447 from ramonlsouza/keyboard-reactions
fix(access): keyboard navigation in reactions bar
2023-08-08 12:16:48 -04:00
Ramón Souza
07ce5befec limit cameras page in grid mode 2023-08-08 13:05:54 -03:00
Gustavo Trott
eaf86b37a8 Fix: Unable to choose same reaction twice in a row 2023-08-08 11:32:52 -03:00
Paulo Lanzarin
d7e9cb05ee
Merge pull request #18461 from prlanzarin/u27/feat/transparent-listen-only
feat(audio): add experimental transparent listen only mode
2023-08-08 09:39:12 -03:00
prlanzarin
8feb934169 feat(audio): add experimental transparent listen only mode
This is an initial, experimental implementation of the feature proposed in
https://github.com/bigbluebutton/bigbluebutton/issues/14021.

The intention is to phase out the explicit listen only mode with two
overarching goals:
  - Reduce UX friction and increase familiarity: the existence of a separate
  listen only mode is a source of confusion for the majority of users
  Reduce average server-side CPU usage while also making it possible for
  having full audio-only meetings.

The proof-of-concept works based on the assumption that a "many
concurrent active talkers" scenario is both rare and not useful. With
that in mind, this including two server-side triggers:
 - On microphone inactivity (currently mute action that is sustained for
   4 seconds, configurable): FreeSWITCH channels are held (which translates
   to much lower CPU usage, virtually 0%). Receiving channels are switched,
   server side, to a listening mode (SFU, mediasoup).
   * This required an extension to mediasoup two allow re-assigning producers
     to already established consumers. No re-negotiation is done.
 - On microphone activity (currently unmute action, immediate):
   FreeSWITCH channels are unheld, listening mode is deactivated and the
   mute state is updated accordingly (in this order).

This is *off by default*. It needs to be enabled in two places:
  - `/etc/bigbluebutton/bbb-webrtc-sfu/production.yml` ->
    `transparentListenOnly: true`
  - End users:
    * Server wide: `/etc/bigbluebutton/bbb-html5.yml` ->
      `public.media.transparentListenOnly: true`
    * Per user: `userdata-bbb_transparent_listen_only=true`
2023-08-07 19:43:18 -03:00
Ramón Souza
9f2276b668 only display emoji if reactions are enabled 2023-08-07 17:02:49 -03:00
Ramón Souza
cc09894924 add raise hand and away emoji in userlist 2023-08-07 16:49:03 -03:00
Ramón Souza
c68da552d2 break lines in breakout room checkbox 2023-08-07 11:34:35 -03:00
GuiLeme
ce22c1894d [issue-18446] - fix download of original presentation 2023-08-04 17:38:17 -03:00
Ramón Souza
56c4657c46 adjust styles 2023-08-04 16:14:57 -03:00
Ramón Souza
1aba53885b
Merge pull request #18439 from Scroody/I-17970
fix: Disabled self cam tied to specific cam (or all cams)
2023-08-04 15:25:58 -03:00
KDSBrowne
632b7764bf move fitToWidth state up to app component (#17982) 2023-08-04 16:41:42 +00:00
Anton Georgiev
2fcbd31a42
Merge pull request #18427 from ramonlsouza/guest-updates
fix: Notify guest policy change
2023-08-04 10:39:57 -04:00
imdt
14c83bb6d3 Adjustments 2023-08-04 10:41:07 -03:00
KDSBrowne
dca7fe1997 fix slide positon when zooming out after pan (presenter) 2023-08-03 20:30:23 +00:00
Ramón Souza
87e2e88f6c
Merge pull request #18440 from Scroody/margin-to-talking-indicator
style: Margin of talking indicator adjusted to better fitting size
2023-08-03 16:18:20 -03:00
Ramón Souza
8802d8fffd
Merge pull request #18448 from Scroody/margin-to-timer2
style: Margin of timer adjusted to better fitting size
2023-08-03 16:18:09 -03:00
André Castro
163e18b8a3
Adjustments to the timer 2023-08-03 16:15:46 -03:00
Ramón Souza
4da6bb2864
Merge pull request #18441 from Scroody/margin-to-timer
Client: Margin of timer adjusted to better fitting size
2023-08-03 15:56:25 -03:00
Paulo Lanzarin
5ddf3155c7
Merge pull request #18407 from prlanzarin/u27/fix/audio-retry-timeout-logs
feat(audio): add retryThroughRelay, +...
2023-08-03 15:50:04 -03:00
Ramón Souza
95e3bba2f1 make reactions bar accessible by keyboard 2023-08-03 15:48:47 -03:00
imdt
44a0c2d10c Client: Margin of timer adjusted to better fitting size 2023-08-03 11:48:00 -03:00
imdt
08de342179 Adjustment 2023-08-03 11:32:27 -03:00
imdt
d843b8df56 Client: Margin adjusted to better fitting size 2023-08-03 11:29:51 -03:00
imdt
205d1d5f35 Fix: disabled self cam tied to specific cam or all 2023-08-02 17:59:19 -03:00
Daniel Molkentin
fa5aa182fe fix: do not escape text twice
The refactoring in 838accf015 incorrectly
replaced the wrong parseMessage function in addBulkGroupChatMsgs.js

This bug is only triggered when the option public.chat.bufferChatInsertsMs != 0.
2023-08-02 18:48:22 +02:00
Ramón Souza
e0e68f3896 guest policy change toast 2023-08-02 13:22:43 -03:00
Ramón Souza
d960ccb1c9
Merge pull request #18399 from Scroody/fix-pulse-animation-with-avatar
Fix: pulse animation with avatar
2023-08-02 08:47:33 -03:00
Anton Georgiev
b46ee4c52a
Merge pull request #18412 from KDSBrowne/bbb-18257
fix: Correct Tab Order For Presentation Options Dropdown
2023-08-01 15:46:14 -04:00
Ramón Souza
c15d1a352a undo auto lint 2023-08-01 11:08:27 -03:00
Ramón Souza
6b34cd38c1 replace double quotes 2023-08-01 11:01:27 -03:00
KDSBrowne
70a8267284 inject presentation options btn into tldraw toolbar | lint issues 2023-08-01 02:45:13 +00:00
Ramón Souza
df8e9e9440 split disabled download of presentation params 2023-07-31 17:03:29 -03:00
prlanzarin
a8e4e876d0 fix(audio): add connection timers for SFU audio
SFU based audio is missing connection timers, which means the join
procedure can go on indefinitely in a couple of scenarios.

Refactor the connection timers added for re-connections in the SFU audio
bridge and make them valid for the first try as well.

Make 1010 errors (connection timeout) retriable when retryThroughRelay
is enabled.
2023-07-31 11:39:52 -03:00
prlanzarin
7c3ac51e38 feat(audio): add retryThroughRelay flag for 1007 errors
1007 errors are still a large fraction of our overall audio join error
rate. This usually indicates some sort of firewall block or UDP issues
carrier networks. I can't figure out why some scenarios won't trickle
down to relay candidates though - I'm leaning to scenarios where STUN
packets with USE-CANDIDATE are being mangled/lost along the way or
something else that borks the (already fragile) conn checks for ICE-lite
implementations.

Add a new feature called retryThroughRelay which triggers a retry with
iceTransportPolicy=relay whenever audio fails to join with a 1007 error.
The goal is to force relay usage to try and bypass 1007s scenarios that
still happen.

Disabled by default.
2023-07-31 11:39:45 -03:00
prlanzarin
26815f4679 chore(audio): add more data to audio_joined/failure logs
Add secondsToActivateAudio, inputDeviceId, outputDeviceId and isListenOnly
to audio_joined.extraInfo

Add inputDeviceId, outputDeviceId and isListenOnly to
audio_failure.extraInfo

Add a try-catch to the device enforcement procedure triggered by
onAudioJoin - it may throw and block the modal.
2023-07-31 11:39:24 -03:00