Commit Graph

270 Commits

Author SHA1 Message Date
imdt
32597c7c6f Tweek 2023-02-21 16:52:09 -03:00
imdt
3549350f5e Fixed camera background alternatives not showing 2023-02-21 15:48:31 -03:00
Gabriel Porfirio
907589cef1 disabled features test 2023-02-21 15:28:53 -03:00
Anton B
9278ed296c fix: avoid aria warning 2023-01-25 16:50:10 -03:00
Joao Victor
97ad47d010 Create a new checkbox component 2022-12-14 17:03:23 -03:00
Ramón Souza
41a56cada3 increase max-height of video modal 2022-12-08 14:37:19 -03:00
Joao Victor
cf40b24ef6 fix: Webcam backgrounds crash the entire client on Firefox 2022-12-06 07:32:40 -03:00
Ramón Souza
c9717e6a6c
Merge pull request #15966 from JoVictorNunes/issue-15900
style: standardize padding, spacing and header font size/weight of several modals
2022-11-10 16:36:33 -03:00
Joao Victor
777eebfc37 Centralize header styles in a new component 2022-11-10 15:09:21 -03:00
Ramón Souza
cdc2bc7e04
Merge pull request #15770 from JoVictorNunes/store-webcam-microphone
improvement: share audio and video setup among different sessions
2022-11-09 10:37:52 -03:00
Joao Victor
ef4b9f5f8c fix: WebcamDeviceId storage 2022-11-09 09:19:01 -03:00
Joao Victor
fa557406fa style: standardize padding, spacing and header font size/weight of several modals 2022-11-08 14:51:36 -03:00
Ramón Souza
b66b52ad88
Merge pull request #15923 from owi92/unify-modals
Unify some dialog windows
2022-11-07 09:16:12 -03:00
Joao Victor
f1007fb7b6 Use the new config option from #15413 - A centralized way of defining which storage to use (Session or Local) 2022-11-03 17:57:54 -03:00
Ramón Souza
38b49d8792
Merge pull request #15841 from JoVictorNunes/issue-15834
fix(webcam): brightness not working when changing quality profile
2022-10-31 14:28:58 -03:00
Ole Wieners
c9a612ee8a Unify some dialog windows 2022-10-27 19:54:34 +02:00
Ramón Souza
0a6d479938
Merge pull request #15764 from KDSBrowne/26-a11y-fixes-02
Video Preview Modal A11y Updates
2022-10-24 10:26:03 -03:00
Joao Victor
b552ae5507 fix(webcam): brightness not working when changing quality profile 2022-10-13 16:26:25 -03:00
Joao Victor
3f07430ff4 improvement: store last shared webcam 2022-10-03 08:09:03 -03:00
KDSBrowne
02836bd78d add missing aria-describedby label on delete btn 2022-09-30 15:24:45 +00:00
KDSBrowne
b73ad8a85f update aria descriptions in video preview modal | fix checkbox aria label 2022-09-30 15:24:24 +00:00
KDSBrowne
03cf283ab3 update upload virtual background button aria description 2022-09-30 15:24:15 +00:00
Joao Victor
82f385c88e improvement: disable text selection of brightness labels 2022-09-29 09:49:36 -03:00
Anton B
3b04dbff48 test: add pinning and unpinning test, improve share webcam test and add selectors 2022-09-12 14:12:35 -03:00
Paulo Lanzarin
362785a83a
Merge pull request #15647 from prlanzarin/u26/fix/cam-profile-switch-notreadableerror
fix(webcam): switching profiles in preview fails intermittently
2022-09-08 15:11:33 -03:00
prlanzarin
646db91367 fix(webcam): add MediaStream id to 'inactive' event handlers
BBBVideoStream 'inactive' event currently does not send the
MediaStream id as the payload for handlers. This can cause theoretical
race conditions due to media stream mismatches in places where
'inactive' handling is done globally (eg video-preview).

This adds the MediaStream id to BBBVideoStream's 'inactive' event
and uses it in video-preview to avoid such race conditions.
2022-09-06 12:31:26 +00:00
prlanzarin
5d04bcaf93 fix(webcam): retry gUM on NotReadableError for Chrome/Edge
tl;dr: switching camera profiles in video-preview fails intermittently
in Chrome/Edge.
Long version: Chrome/Edge sometimes bork gUM calls when switching camera
profiles. This looks like a browser bug (issue TBD). Track release not
being done synchronously -> quick subsequent gUM calls for the same
device (profile switching) -> device becoming unavaible while previous
tracks aren't finished.

Since track stop is not "awaitable", this commit adds a retry procedure
that re-runs gUM up to 5 times (200 ms delay) only if error.name is
NotReadableError and browser is either Chrome or Edge.
2022-09-06 12:26:31 +00:00
Joao Victor
d4949bd7cf fix(camera): disable brightness on Safari and stop segmentation if brightness is unchanged 2022-09-01 09:29:08 -03:00
Joao Victor
24c227cc75 Merge 2.6.x-release into camera-brightness 2022-08-26 11:53:23 -03:00
Joao Victor
396f5320a4 feat(camera): set camera brightness 2022-08-26 11:50:46 -03:00
Joao Victor
54b146effe fix: add missing custom virtual background param 2022-08-25 08:30:36 -03:00
Anton Georgiev
bbb7dd421d Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into cairosvg 2022-08-19 14:25:03 +00:00
Anton Georgiev
1b7b63baf6 Merge branch 'v2.5.x-release' of github.com:bigbluebutton/bigbluebutton into cairosvg 2022-08-19 14:14:54 +00:00
Ramón Souza
d9f2660d6a
Merge pull request #15330 from JoVictorNunes/vb-improvements-Jul-04
improvement(virtual background): better error handling, notifications…
2022-07-28 09:25:00 -03:00
Joao Victor
d2eda01bcb fix: check for undefined value 2022-07-27 16:15:19 -03:00
Joao Victor
fe669b2f58 fix: check virtual background index 2022-07-27 09:00:18 -03:00
Joao Victor
5c6c28cdd2 Fix conflicts 2022-07-25 15:14:27 -03:00
Joao Victor
0ac69cba0a fix: comparison to render custom buttons 2022-07-15 17:16:33 -03:00
Joao Victor
34aaf07fed Merge branch v2.6.x-release into virtual-backgrounds-skeleton-preview 2022-07-15 17:14:16 -03:00
prlanzarin
029c957b22 fix(webcam): handle stream inactivation/gUM revocations
The 'inactive' event is fired whenever the stream gets inactive (ie it
cannot be used anymore), and there are scenarios where that is
unexpected behavior and must be handled accordingly.
The main example of that is when gUM permissions are revoked by the user
via the browser's permission management panel.
Since MediaStream/Track inactive events aren't being handled in such
scenarios, what actually happens is that the camera just freezes without
further indication why.

This commit handles those scenarios in both video-preview and
video-provider by:
  - 1) correctly stopping the camera (provider)
  - 2) surfacing a toast (provider) or error indication (preview)
2022-07-12 22:03:01 +00:00
prlanzarin
e93440e15a refactor(webcam): fix linter errors in BBBVideoStream 2022-07-12 17:50:16 +00:00
Joao Victor
2f78edddf3 fix: add suport for disabling upload of custom backgrounds through custom parameter 2022-07-08 17:01:57 -03:00
Joao Victor
915ffce3c6 improvement: sort buttons by recently used/uploaded 2022-07-08 12:16:37 -03:00
Joao Victor
f8ec4ef640 refactor: virtual background context 2022-07-07 18:59:30 -03:00
Joao Victor
8481103e47 improvement(virtual background): loading skeleton, custom backgrounds in video preview modal 2022-07-06 16:03:55 -03:00
Joao Victor
aaf7f8e78e improvement(virtual background): better error handling, notifications, performance 2022-07-06 10:38:40 -03:00
Joao Victor
93d98d9b3e fix: margin unit 2022-06-30 17:10:48 -03:00
Joao Victor
5e2c113cae improvement: virtual background selector thumbnail 2022-06-30 16:39:50 -03:00
Joao Victor
ddb63f8e71 fix: restore virtual background after leaving breakout room #15111 2022-06-14 09:40:13 -03:00
Joao Victor
22a924181d fix: state update on delete 2022-06-01 12:31:56 -03:00
Joao Victor
769629daf6 improvement: add a new service function for reading the file 2022-06-01 12:05:16 -03:00
Joao Victor
e7d9b46097 fix: add some file sanitization 2022-05-31 16:32:58 -03:00
Joao Victor
936829338d fix: localize default button label for custom backgrounds 2022-05-31 11:38:24 -03:00
Joao Victor
ae3355d685 revert: unifying of click handlers of custom backgrounds 2022-05-31 11:14:33 -03:00
Joao Victor
69b4342e39 revert: unifying of click handlers of the default backgrounds 2022-05-31 11:06:58 -03:00
Joao Victor
a7e5869c91 feat(video): upload of own webcam virtual background 2022-05-10 14:17:16 -03:00
prlanzarin
d6c7f23a0e feat(audio): local echo test and audio energy meter
New features:
  - A simplified echo test mode that only does a local loopback (instead of
  going to FS and back)
  - A volume meter for microphone streams to the AudioSettings view

Those two features are experimental and disabled by default; see
public.app.media.simplifiedEchoTest and public.app.media.showVolumeMeter configs

Collateral changes:
  - fix: localize fallback device strings in AudioSettings/DeviceSelector
  - Refactor on some media stream utils to be re-usable across components
  - Refactor in AudioSettings to keep gUM #uses stable.
    * TODO: need to pass streams through AudioManager to avoid the surplus gUM.
  - fix(audio): drop ScriptProcessorNode usage (deprecated)
    * Used in volume meter for tracking - use hark instead
2022-04-11 19:21:56 +00:00
Gustavo Trott
a6c3af7b0f Add disabledFeatures=virtualBackgrounds 2022-03-22 16:01:27 -03:00
Anton Georgiev
5f884f6674 Merge remote-tracking branch 'bbb/v2.4.x-release' into merge-24-into-25 2022-03-03 18:35:05 +00:00
Pedro Beschorner Marin
e8ff5ebdc8 feat(video): add user camera cap control
Include `userCameraCap` API param on create and enforce both server and
client to control the number of simultaneous webcams an user can share.

Default set to 3.
2022-02-22 13:13:48 -03:00
Ramón Souza
1d1375b3cf move modal component to common folder 2022-02-15 15:54:55 +00:00
Ramón Souza
246e3b3e8f move button component to common folder 2022-02-14 20:20:50 +00:00
Ramón Souza
dba04834c7 Merge remote-tracking branch 'upstream/v2.4.x-release' into 2524-feb08 2022-02-09 15:52:42 +00:00
Anton Georgiev
417744515a
Merge pull request #14273 from ramonlsouza/restore-button-css
fix: restore hover/focus button styles
2022-02-03 15:24:50 -05:00
Ramón Souza
cdb6e2e652 restore hover/focus button styles 2022-02-03 19:45:51 +00:00
Anton Georgiev
0b269d7973
Merge pull request #14231 from hiroshisuga/noShrunkenThumbnail
fix(virtualBG): recover shrunken thumbnails on the modal
2022-02-01 08:53:18 -05:00
Ramón Souza
b17ec549bd remove extra parentheses from virtual bg label 2022-02-01 12:43:40 +00:00
Anton Georgiev
06b8630719
Merge pull request #14230 from hiroshisuga/blur_translate
fix(virtualBG): snippet "blur" translation
2022-01-31 15:33:32 -05:00
hiroshisuga
65c8d14108
Update styles.scss 2022-01-29 14:26:27 +09:00
hiroshisuga
b1936e9fdc
Update component.jsx 2022-01-29 14:16:39 +09:00
Ramón Souza
16cd3c4ebb Merge remote-tracking branch 'upstream/v2.4.x-release' into dev-24-0125 2022-01-25 16:56:52 +00:00
Anton
7f075be033 fix all test selectors 2022-01-20 10:03:18 -03:00
Arthurk12
9c571dcc82 fix(webcam): unresponsive webcam selector button
Video preview modal opens when user clicks on the webcam selector
button/chevron even if the client is set to skip video preview
(userdata-bbb_skip_video_preview=true).
2022-01-12 19:25:35 +00:00
Ramón Souza
f6e65f58c5 merge 2.4 into develop and resolve conflicts - partial 2022-01-12 16:40:45 +00:00
Joao Victor
c0ebc50735 fixes bad alignment 2022-01-10 15:42:22 -03:00
Anton Georgiev
3ca8f2cc22
Merge pull request #13797 from JoVictorNunes/issue-13214
fix: camera background localization
2021-12-15 13:42:21 -05:00
Ramón Souza
d1c516fef6 resolve html5 conflicts 2021-12-10 21:07:35 +00:00
Anton Georgiev
797fc49633 TEMP 2021-12-09 20:37:05 +00:00
Joao Victor
2b554ad47f fix: camera background localization 2021-12-01 08:20:04 -03:00
prlanzarin
143ea132b9 refactor(webcams): remove video preview cancel/confirm/something button
Another round of experimentation with that button.

Removing it due to its role being already contemplated by two other actions in the modal: clicking outside and the X icon

Will have to see how this is received in internal testing
2021-11-26 13:01:17 +00:00
Max Franke
9ce58c38e7 fix(video): 'stop all' button shows when webcam = 1
Add a condition that, if the user has more than 1 camera and
not is on mobile, shows the 'stop all' button.
2021-11-26 12:58:53 +00:00
Anton Georgiev
5162b4c403
Merge pull request #13679 from JoVictorNunes/issue-13241
fix: virtual background not kept when switching from breakout to main room
2021-11-19 15:11:21 -05:00
prlanzarin
3eb760e0b2 chore(webcams): cleanup unused vars in video-preview container 2021-11-19 19:03:36 +00:00
prlanzarin
13eb9fe702 refactor(webcams): re-use lock check from video-provider in video-preview 2021-11-19 18:23:17 +00:00
João Victor
6524f70941 support for storing multiple virtual backgrounds 2021-11-19 08:10:24 -03:00
Anton Georgiev
542db847ff
Merge pull request #13574 from Tainan404/smooth-reconnection-25
Improve data structure to not break on reconnections
2021-11-17 15:55:21 -05:00
Ramón Souza
e5293d9109 only use colorBackground in backgrounds 2021-11-16 17:15:02 +00:00
Joao Victor
2176898c9f fix: video preview alignment 2021-11-11 16:42:07 -03:00
Joao Victor
cc85b58ef4 improves video preview modal 2021-11-09 08:36:06 -03:00
Tainan Felipe
f5eef03f3f Improve data structure to not break on reconnections 2021-11-03 14:37:54 -03:00
Ramón Souza
3565c8add0 convert video-preview component 2021-10-28 13:16:36 +00:00
Ramón Souza
6799922131 convert virtual-background component 2021-10-28 11:58:39 +00:00
Anton Georgiev
719afa6cd2 Merge branch 'v2.4.x-release' of github.com:bigbluebutton/bigbluebutton into merge-24-dev 2021-10-14 15:14:22 +00:00
Ramón Souza
9a56848a83 improve video preview - safari 2021-10-13 20:21:54 +00:00
Tainan Felipe
1de8e0779d Add server side reactivity to publications 2021-10-13 15:00:52 -03:00
KDSBrowne
eef95165a6 add aria-pressed to background thumbnails 2021-09-14 13:56:59 +00:00
KDSBrowne
be3bd85bca add group role | aria-label to virtual bg list | cam dropdown activate via keyboard 2021-09-14 01:50:24 +00:00
KDSBrowne
ed4d7a4b5a remove button access from keyboard when disabled 2021-08-31 23:34:16 +00:00
KDSBrowne
a024aaade5 recover greyscale thumbnail styles | fix varying spacing 2021-08-31 23:17:28 +00:00
Anton Georgiev
978d42044b
Merge pull request #13107 from KDSBrowne/bbb-cam-bg-acc
Update Accessibility For Virtual Background Buttons
2021-08-31 09:45:33 -04:00