Ramón Souza
b4fb203593
fix mobile init values for external video/screnshare
2022-07-27 10:56:04 -03:00
prlanzarin
b8811bafd4
fix(layout): use actual screen share size when calculating smart layout
...
Smart layout (et al) presumes screen sharing will always use 100%
width of the media area. That causes cameras to always be positioned on
top, which is not always the optimal position depending on the viewport
and stream aspect ratio/resolution - so space is wasted.
This commit uses the actual screen sharing video size as provided by
HTMLVideo's videoWidth/videoHeight properties. The calculation uses the
same logic as the one used for presentation/slides, which should make it
a bit familiar.
There's also a handler for HTMLVideo's `resize` event for those browsers
that support it - which enables handling of variable-sized screen
sharing streams. That handler is debounced at 500 ms to prevent
excessive CPU use.
Extra testing is needed with the widest range possible of
browsers/environments and feature combinations.
2022-07-22 13:28:43 +00:00
prlanzarin
8f77f4cd1f
fix(layout): set external-video/screen share initial states on all layouts
...
Only smart layout takes screen sharing/external video states in account
when populating its initial state. The others don't, and that causes
some weird issues when switching back-and-forth between layout types due
to their input states becoming inconsistent - ie having an active screen
sharing and transitioning from Smart -> Custom would mark it as false
(due to its absence from the initial state) and pollute its state for
subsequent layouts.
This commit guarantees those features are taken into account when
populating initial input states for Focus On*/Custom layouts.
2022-07-21 18:07:49 +00:00
KDSBrowne
046518abe5
handle cursor positions for smart layout
2022-07-06 20:03:04 +00:00
Ramon Souza
0d3a5326fc
Merge remote-tracking branch 'upstream/v2.5.x-release' into 25260-may10
2022-05-10 10:53:00 -03:00
Ramon Souza
07f9a192b9
Merge remote-tracking branch 'upstream/v2.4.x-release' into merge-2425-apr27
2022-04-27 15:32:20 -03:00
Lucas Zawacki
83847a21aa
Merge branch 'v2.5.x-release-Layouts' of github.com:lfzawacki/bigbluebutton into develop-bbb
2022-04-13 21:08:32 +00:00
Ramon Souza
0b26f066e0
change captions position to not depend on presentation
2022-04-13 15:10:40 -03:00
Ramon Souza
375cf41498
fix smart layout invisible video bug
2022-03-30 15:30:39 -03:00
Arthurk12
eacce4ee46
fix(layout): camera resize when pushing
...
Adds isResizing property to LayoutMeetings collection.
Moves the point where the last camera dock size is stored from webcam
component to custom layout component, since it is the only one with
this feature.
2022-03-22 15:29:49 -03:00
Arthurk12
1c3a5bd053
fix(layout): camera dock size
...
Fixes camera dock sudden increase when moving its position in custom layout.
Uses the last camera dock size stored for that dock position, if not,
make it default size.
2022-03-22 15:28:36 -03:00
Ramon Souza
7b86065e3f
fix smart layout invisible video bug
2022-03-17 11:06:21 -03:00
Arthurk12
5100049c29
fix(layout): webcam container resize bar
...
Fixes missing webcam container's resize bar on custom layout when cameras
are placed at the bottom of the presentation and the chat is closed.
2022-03-09 16:49:24 -03:00
Anton Georgiev
9cd7eccf63
Merge pull request #14558 from ramonlsouza/issue-14552
...
fix: Video warning keeps showing after hiding presentation/external video
2022-03-08 12:18:03 -05:00
Ramón Souza
38d804da37
do not display external video message when it is minimized
2022-03-08 17:10:26 +00:00
Ramón Souza
9ec9bfc790
do not display presentation placeholder in smart layout
2022-03-07 20:21:58 +00:00
Lucas Zawacki
43afef9bad
feature(layout): Remove 'swap layout' concept
2022-02-24 16:05:18 -03:00
Ramón Souza
dba04834c7
Merge remote-tracking branch 'upstream/v2.4.x-release' into 2524-feb08
2022-02-09 15:52:42 +00:00
Ramón Souza
b028e4f4aa
do not use presentation size for screenshare and external video in smart layout
2022-02-07 19:29:27 +00:00
Ramón Souza
16cd3c4ebb
Merge remote-tracking branch 'upstream/v2.4.x-release' into dev-24-0125
2022-01-25 16:56:52 +00:00
Ramón Souza
a9d4d87d2a
restore missing variable
2022-01-21 17:38:25 +00:00
Ramón Souza
bc9957c13d
add background to cameras/presentation when positioned in sidebar-content
2022-01-21 13:24:03 +00:00
Max
38d95b0ea8
fix(layout): hide/show media in videoFocus
...
Fix an error that the hide/show button does not work when there is external
video/screenshare and the layout is "videoFocus".
2022-01-17 19:11:43 -03:00
Ramón Souza
d4c1b985b3
fix webcam overlap in breakout room
2022-01-12 19:30:14 +00:00
Ramón Souza
f6e65f58c5
merge 2.4 into develop and resolve conflicts - partial
2022-01-12 16:40:45 +00:00
Arthurk12
63d3d3efd2
fix(layout): sidebar inconsistent state
...
Fixes initial state of navigation sidebar.
Navigation sidebar opens along with the content sidebar.
2022-01-03 19:51:05 +00:00
Ramón Souza
d1c516fef6
resolve html5 conflicts
2021-12-10 21:07:35 +00:00
Anton Georgiev
797fc49633
TEMP
2021-12-09 20:37:05 +00:00
Ramón Souza
6b67527f8d
fix sidebar media position with banner
2021-12-02 12:17:40 +00:00
Ramón Souza
c43991e6b5
fix cameras margin RTL - smart layout
2021-11-22 11:58:35 +00:00
Ramón Souza
9ee4975e7f
fix minimize presentation focus on presentation layout
2021-11-12 17:08:31 +00:00
Max Franke
b507eeb80f
feat(external-videos): rewrite fullscreen button
...
Following BBB v2.4 new layout manager fullscreen changes
2021-10-29 10:55:34 -03:00
Anton Georgiev
24d672a832
Merge branch 'v2.4.x-release' of github.com:bigbluebutton/bigbluebutton into merge-24-dev
2021-10-14 15:13:17 +00:00
Ramón Souza
4aab0eb043
fix fullscreen cameras with hidden presentation
2021-10-04 12:13:37 +00:00
Ramon Souza
4355601945
move isMobile and isTablet to layoutEngine
2021-09-24 14:38:44 -03:00
Ramon Souza
b22c12aef7
calculatesCameraDockBounds refactor - presentationFocus, smart and videoFocus layouts
2021-09-24 14:16:37 -03:00
Ramon Souza
30623b0c4f
remove duplicated functions from video focus layout
2021-09-24 13:19:41 -03:00
Ramon Souza
5ed7c06763
remove duplicated functions from smart layout
2021-09-24 11:48:59 -03:00
Ramon Souza
e47d62a224
remove duplicated functions from presentation focus layout
2021-09-24 11:08:50 -03:00
Ramon Souza
72bd47f457
move duplicated functions from customLayout to layoutEngine
2021-09-24 10:41:28 -03:00
Ramon Souza
4f54f32a1a
rename BaseLayout -> LayoutEngine
2021-09-23 17:46:50 -03:00
Ramon Souza
7f9bf6d167
move calculatesNavbarBounds and calculatesActionbarHeight to BaseLayout
2021-09-23 17:43:02 -03:00
Ramon Souza
a7a68e7d11
calculatesCameraDockBounds refactor - customLayout
2021-09-23 16:21:06 -03:00
Ramon Souza
668d2f8a25
add baseLayout component
2021-09-23 10:34:36 -03:00
Vitor Mateus De Almeida
f5bf6675de
fixes user list appears even if custom parameters is false
2021-09-22 18:26:37 -03:00
Anton Georgiev
ab845b3078
Merge branch 'v2.4.x-release' of github.com:bigbluebutton/bigbluebutton into merge-24-rc-1-into-dev
2021-09-22 15:28:13 +00:00
Ramon Souza
a86df37bfe
fix camera resizing bug
2021-09-21 17:20:32 -03:00
Vitor Mateus De Almeida
f6e17ba398
change cameraDock size in vertical position
2021-09-15 09:33:31 -03:00
Vitor Mateus De Almeida
c47cf21ba2
place both buttons at the bottom of the video dock when cameras are vertically positioned
2021-09-15 09:13:17 -03:00
Ramon Souza
9300b9b382
Merge remote-tracking branch 'upstream/develop' into use-context-selector
2021-09-13 15:41:52 -03:00