Commit Graph

30038 Commits

Author SHA1 Message Date
Anton Georgiev
3cd144ed84
Merge pull request #12754 from pedrobmarin/f-s-cli
feat(screenshare): change loading icon
2021-07-12 09:35:14 -04:00
Anton Georgiev
37c6175f09
Merge pull request #12704 from jfsiebel/hide-poll-response-viewers
Filter anonymous poll data for presenter, moderators and viewers
2021-07-12 08:51:29 -04:00
Max Franke
5d0ae8ff04 feat(screenshare): change loading icon
Change the previous loading spinner to the new loading dots, ensuring
a bit more UI consistency.
Add the "unhealthy stream" filter to make the dots a little more visible and
remove the loading spinner.
2021-07-09 14:51:38 -03:00
Pedro Beschorner Marin
72f99d5bdf
Merge pull request #12744 from ramonlsouza/fix-presenter-change-poll-panel
fix: close poll panel if user is no longer the presenter
2021-07-08 14:52:47 -03:00
Pedro Beschorner Marin
02008c460f
Merge pull request #12735 from prlanzarin/u24-gum-store-fl
fix(webcams): avoid leaking media streams on webcam profile changes
2021-07-08 14:50:08 -03:00
Pedro Beschorner Marin
454173fc6c
Merge pull request #12736 from prlanzarin/u24-gum-store-pricetags
refactor(locales): improve some of video-preview error messages
2021-07-08 14:49:41 -03:00
Pedro Beschorner Marin
cdb22e1f71
Merge pull request #12747 from prlanzarin/u24-aerodyn
fix(webcams): add error feedback when media is ejected by the server
2021-07-08 14:28:24 -03:00
Pedro Beschorner Marin
8333b545ea
Merge pull request #12739 from germanocaumo/publish-external-video
feat(recording): process published external videos
2021-07-08 12:49:29 -03:00
prlanzarin
15bd0b6087 fix(webcams): add error feedback when media is ejected by the server
Closes #12732
2021-07-08 15:10:22 +00:00
Pedro Beschorner Marin
e8eab54de2
Merge pull request #12743 from prlanzarin/u24-fix-ss-presch
fix(screenshare): fix client crash on presenter change
2021-07-07 18:07:05 -03:00
Ramon Souza
268608a9ab close poll panel if user is no longer the presenter 2021-07-07 17:15:07 -03:00
prlanzarin
67fca54d76 fix(screenshare): fix client crash on presenter change
Scenario: presenter`s client could crash when the presenter changed while they were sharing their screen

That is due to a race condition on the stop procedure in the bridge: two stops can be triggered (one from the server-side websocket tear off and another from the client itself detecting the presenter change)

That could create a scenario where the broker was cleaned in one stop procedure after the second had checked its availability, causing an attribute access of a null member
2021-07-07 19:29:17 +00:00
prlanzarin
e5aec7beab refactor(screenshare): append error message to failure log 2021-07-07 19:29:11 +00:00
germanocaumo
4392b0d462 feat(recording): process published external videos
Generate a external_videos.json file at the recordings with an array of
played external videos url and timestamp.

This file will be published along with the other presentation format files
and can be used to display at the playback.
2021-07-07 13:26:24 +00:00
prlanzarin
d851a79f16 refactor(locales): improve some of video-preview error messages
Fix #286
2021-07-07 03:30:10 +00:00
prlanzarin
0e6a900635 fix(webcams): avoid leaking media streams on webcam profile changes
Fix regression introduced by commit 0ddf02e
2021-07-07 02:54:19 +00:00
Anton Georgiev
6cf863ff3d
Merge pull request #12604 from KDSBrowne/bbb-api-unit-tests
test: Add Unit Tests For Meteor Polls API
2021-07-06 16:56:46 -04:00
Anton Georgiev
1a50fe9904
Delete bbb.sh
Severely out of date, 90% of these don't exist anymore
2021-07-06 16:18:51 -04:00
Anton Georgiev
c728e368e2
Severely out of date DEVELOPMENT.md - please use docs.bigbluebutton.org 2021-07-06 16:17:46 -04:00
Anton Georgiev
de638cf852
Merge pull request #12731 from prlanzarin/u24-recosocket-fastnecting
build(deps): update reconnecting-websocket to 4.4.0 (bbb-html5)
2021-07-06 16:11:01 -04:00
Anton Georgiev
ef4c756a1e
Merge pull request #12733 from antobinary/merge-2.3.5-into-develop
chore: Merge 2.3.5, 2.3.6 into develop
2021-07-06 16:04:37 -04:00
Anton Georgiev
1fd6246336 Merge branch 'v2.3.x-release' of github.com:bigbluebutton/bigbluebutton into merge-2.3.5-into-develop 2021-07-06 19:37:30 +00:00
Anton Georgiev
b9cc633286 Merge branch 'v2.3.x-release' of github.com:bigbluebutton/bigbluebutton into merge-2.3.5-into-develop 2021-07-06 19:36:19 +00:00
prlanzarin
8a1aa8740d build(deps): update reconnecting-websocket to 4.4.0 (bbb-html5) 2021-07-06 19:09:02 +00:00
Anton Georgiev
29cd607ecd
Merge pull request #12694 from mariogasparoni/feat-add-device-button-selector
feat(audio): add a new button for selecting audio device
2021-07-06 12:04:18 -04:00
Anton Georgiev
5f9b084514
Merge pull request #12730 from mariogasparoni/fix-12048
fix(audio): prevent mute notification to be triggered when mic is locked
2021-07-06 11:13:39 -04:00
Mario Jr
06c7edbb0b fix(audio): prevent mute notification to be triggered when mic is locked
When mic is locked, user is not able to talk so it doesn't make sense
to alert the user about unmuting (mute button is also disabled when mic
is locked).

Closes #12048
2021-07-06 11:59:42 -03:00
Anton Georgiev
07c69a08f1
Updated BBB release to 2.3.6 2021-07-06 10:08:45 -04:00
Anton Georgiev
2814148488
Merge pull request #12728 from mariogasparoni/fix-skip-check-12705
fix(audio): mic not working when skipCheck=true
2021-07-06 10:03:55 -04:00
Mario Jr
bd610c2fd5 fix(audio): mic not working when skipCheck=true
Complements #12705
2021-07-06 10:27:48 -03:00
Anton Georgiev
12bb7b427f
Merge pull request #12726 from antobinary/dev24
Merge 2.4 into 'develop'
2021-07-05 16:26:54 -04:00
Mario Jr
e9ca202767 fix(audio): fix icon for device list selector
This complements #12694, which was initially made using an
existent font (which may vary it's size depending on OS/browser)

Added a new specific icon for the device icon selector

Thanks to @ramonlsouza who found this problem
2021-07-05 17:26:07 -03:00
Anton Georgiev
18ff46aa60
Merge pull request #12724 from jfsiebel/prevent-empty-loggedOut-leaving-message
Prevent loggedOut property to be undefined
2021-07-05 15:07:03 -04:00
Joao Siebel
2cda889d51 Previne loggedOut property to be undefined. close #12656 2021-07-05 16:04:26 -03:00
Pedro Beschorner Marin
6264caccd9
Merge pull request #12700 from prlanzarin/u24-gum-store
Webcams: reduce number of gUM calls, refactor in video-preview, fix #9053
2021-07-05 14:13:36 -03:00
prlanzarin
d8dae1ec90 fix(webcams): handle Firefox video stream cleanup edge case
Firefox doesnt fire the ended evt/onended callback for live video mediastreamtracks. That caused the stream storage to not run the cleanup procedure in some scenarios

Manually emit the ended event which works with the onended callback when a track is stopped
2021-07-05 16:26:24 +00:00
prlanzarin
60dd10510c fix(webcams): add fallback labels for devices in video-preview
In cases where fingerprinting protection is so adamant that we are
unable to get device labels

Fixes #9053
2021-07-05 16:03:30 +00:00
prlanzarin
0ddf02e954 refactor(webcams): improve skipVideoPreview handling, add error handling to it
Also organized video-preview a little better overall
2021-07-05 16:03:15 +00:00
Anton Georgiev
5f71d53348
Merge pull request #12721 from antobinary/12589
fix: Check for correct directory before deploying bbb-html5
2021-07-05 11:51:54 -04:00
Anton Georgiev
6ceae4dbbc check for correct directory before deploying bbb-html5 2021-07-05 15:44:21 +00:00
Anton Georgiev
3889cf1dc9
Merge pull request #12701 from paultrudel/fix-get-sessions-bbb-web
Freemarker Null Error Fix
2021-07-05 11:11:16 -04:00
Anton Georgiev
f1d88537be
Merge pull request #12715 from pedrobmarin/c-asbc
chore: add stale bot config
2021-07-05 11:10:14 -04:00
Anton Georgiev
28a9b827cd
Merge pull request #12718 from ramonlsouza/webcam-position-mobile
fix: layout issues on mobile with portrait presentation
2021-07-05 09:06:57 -04:00
Ramon Souza
2335105030 force webcam position: top for mobile devices 2021-07-05 09:56:09 -03:00
Anton Georgiev
61e131e0b4
Merge pull request #12717 from ramonlsouza/issue-12714
fix: client crash when userlist is hidden and viewer is ejected
2021-07-05 08:09:02 -04:00
Ramon Souza
3aa4855a6b fix client crash when viewers is ejected and userlist is hidden 2021-07-05 08:20:27 -03:00
Pedro Beschorner Marin
13e5b3f9ef chore: add stale bot config
> In an ideal world with infinite resources, there would be no need for
> this app.
>
> But in any successful software project, there's always more work to do
> than people to do it. As more and more work piles up, it becomes
> paralyzing. Just making decisions about what work should and shouldn't
> get done can exhaust all available resources. In the experience of the
> maintainers of this app—and the hundreds of other projects and
> organizations that use it—focusing on issues that are actively affecting
> humans is an effective method for prioritizing work.
>
> To some, a robot trying to close stale issues may seem inhospitable or
> offensive to contributors. But the alternative is to disrespect them by
> setting false expectations and implicitly ignoring their work. This app
> makes it explicit: if work is not progressing, then it's stale. A
> comment is all it takes to keep the conversation alive.

https://github.com/probot/stale#is-closing-stale-issues-really-a-good-idea

This file add the configuration needed for stale issues and pull requests
to be automatically closed. Defined as follows:

 - issues and pull requests with no activity for 270 days will be marked as "status: stale";
 - after that, there will be a period of 90 days for the issue or pull request to be claimed, otherwise will be closed.

The bot will never interact/close with issues and pull requests marked as:
 - status: vetify
 - status: accepted
 - target: security
 - type: discussion

For this setup to be effective, add https://probot.github.io/apps/stale/
to BigBlueButton repository.
2021-07-04 11:56:50 -03:00
Anton Georgiev
95f5b6faf9
BBB version is quite useful to know, would rather if it is not optional 2021-07-02 22:14:22 -04:00
Anton Georgiev
437255edf3
Merge pull request #12707 from antobinary/jul-2
Pulled HTML5 locales on July 2, 2021
2021-07-02 19:39:14 -04:00
Anton Georgiev
a5c4f67aec Pulled HTML5 locales on July 2, 2021 2021-07-02 23:36:54 +00:00