Commit Graph

11654 Commits

Author SHA1 Message Date
Anton Georgiev
d19677d5a3
Merge pull request #20166 from prlanzarin/u30/fix/review-mobile-audio-chevron
fix(audio): review device selection in mobile endpoints
2024-05-03 08:56:51 -04:00
Anton Georgiev
d85561b17b
Merge pull request #20164 from prlanzarin/u30/fix/Arthurk12-live-1809
fix(bbb-html5): correct parameter type for wake lock log codes
2024-05-03 08:56:03 -04:00
Anton Georgiev
0e68003c08
Merge pull request #20163 from prlanzarin/u30/fix/assorted-br-crashes
fix: undefined accesses causes crashes in actions-bar breakout utils
2024-05-03 08:55:43 -04:00
Anton Georgiev
0df167180e
Merge pull request #20162 from prlanzarin/u30/fix/ff-pairselection
fix(audio): broken connection stats on Firefox >= 125
2024-05-03 08:53:40 -04:00
Anton Georgiev
05d8f9110b
Merge pull request #20161 from prlanzarin/u30/fix/arthurk12-undefined-role-crash
fix: add safeguards when returning user roles
2024-05-03 08:53:01 -04:00
Anton Georgiev
7c407567e1
Merge pull request #20160 from prlanzarin/u30/fix/arthurk12-screenreader-crash
fix(screen-reader): add safeguards for adding alerts
2024-05-03 08:52:45 -04:00
Anton Georgiev
70e4ab1f66
Merge pull request #20159 from prlanzarin/u30/fix/onconnectionstatechange-crash-rc
fix(bbb-html5): crash when stopping WebRTC peers
2024-05-03 08:52:28 -04:00
Anton Georgiev
3babf4c16e
Merge pull request #20158 from prlanzarin/u30/fix/crash-videoprovider-onmessage
fix(bbb-html5): crash on video-provider unmount
2024-05-03 08:51:58 -04:00
Anton Georgiev
84fd90bc49
Merge pull request #20157 from prlanzarin/u30/fix/crash-getBoundingClientRect-emojirain
fix(reactions): crash when interactionsButton coords are absent
2024-05-03 08:49:42 -04:00
Anton Georgiev
9d99f7f78b
Merge pull request #20156 from prlanzarin/u30/fix/audio-answerer-gum-failure
fix(audio): acquire streams before negotiation when peer is answerer
2024-05-03 08:49:08 -04:00
Ramón Souza
35af05e594 fix custom logo 2024-05-03 09:31:18 -03:00
prlanzarin
a21addfa1f fix(audio): review device selection in mobile endpoints
Mobile users have no way to change I/O devices after joining audio.
The removal of the audio options chevron in mobile browsers was supposed
to be replaced by something else - in this case, by the dedicated
leave/join audio button. That didn't happen, leave/join audio button
retained the old behavior.

Review device selection in mobile endpoints via two UI/UX changes:
  - Fix an styling issue where the mute and listen only buttons were
    crammed together
  - Restore the device selection chevron/icon in mobile endpoints
  - Override the leave/join button action in mobile endpoints so that it
    opens the device selection contextual menu, which also includes the
    "Leave audio" option. This retains the old behavior (leaving audio)
    while also providing an way for users to change devices mid-call in
    mobile browsers.
2024-05-03 01:32:01 +00:00
Arthurk12
31a6527cca fix(wake-lock): correct parameter type for log code
Previously, an object was incorrectly passed as the log code parameter.
Fixes it by ensuring that a string is passed instead.
2024-05-03 00:06:07 +00:00
prlanzarin
cea92631fa fix: undefined accesses causes crashes in actions-bar breakout utils
Multiple undefined accesses in actions-bar's service, mainly related to
breakouts and ageneral Meetings info, cause crashes in production
environments - most likely in reconnection scenarios.

Guarantee that nested data is safely accessed.
2024-05-02 23:50:56 +00:00
prlanzarin
20daf56390 fix(audio): broken connection stats on Firefox >= 125
WebRTC-based stats generation in the connection status modal is broken
on Firefox >= 125. A broken type check coupled with a new partially
implemented RTCIceTransport dictionary causes and undefined function
call when fetching the selected candidate pair. Since that error is
unhandled, collection breaks.

Correctly check for the getSelectedCandidatePair method availability in
RTCIceTransport so that it skips to pair inference from getStats if
necessary.
2024-05-02 23:37:44 +00:00
Arthurk12
148c25e2cb fix: add safeguards when returning user roles 2024-05-02 23:35:45 +00:00
Arthurk12
9947aa451e fix(screen-reader): add safeguards for adding alerts
Adds checks for the alert's text and DOM element before adding screen
reader alerts.
2024-05-02 23:06:55 +00:00
prlanzarin
85cdc7cc2a fix(bbb-html5): crash when stopping WebRTC peers
There's a race condition that may cause a client crash whenever a
connectionstatechange callback is cleaned up in a peer without a
valid peer connection present in our custom RTCPeerConnection wrapper.

Check for peerConnection availability in the WebRtcPeer wrapper before
trying to clean up its connectionstatechange callback.
2024-05-02 22:59:39 +00:00
prlanzarin
eccb06369b fix(bbb-html5): crash on video-provider unmount
There's a race condition that may cause a client crash whenever a
video-provider's unmount procedure is run, but its signalling websocket
is undefined. The WS's callback handlers are re-assigned without
checking for the socket's availability, causing an unhandled TypeError.

The WS may be undefined in a couple of scenarios, e.g.: unmouting before
the socket was successfully set up, unmounting while a reconnect is in
place etc.

Check whether the socket exists before accessing it in video-provider's
componentWillUnmount routine.
2024-05-02 22:55:25 +00:00
prlanzarin
cfa013fdaa fix(reactions): crash when interactionsButton coords are absent
The client may crash whenever a emoji rain animation is triggered, but
the interactions button element cannot be located. This happens because
the button coordinates are fetched without checking whether the element
exists.

Get the coordinate fetching method to return null if the
interactionsButton element cannot be located, and ignore the emoji rain
action if that is the case. Whenever no valid coordinates are found, log
an warning so we can track this and figure out what's happening with the
button.

Fix a few typos in the getInteractionsButtonCoordinates method.
2024-05-02 22:32:09 +00:00
prlanzarin
00a2ab52a5 fix(audio): acquire streams before negotiation when peer is answerer
When a sendrecv peer acts as the answerer, gUM is only called _after_
the remote offer is received. This is fine, but the error handling runs
different in that scenario in a way that eventual gUM errors are treated
as negotiation errors, leading to inconsistencies when surfacing the
error to end users.

If a peer is acting as answerer and is a transceiver, acquire the local
streams _before_ actual negotiation so that gUM errors are surfaced
correctly (and we spare uneeded negotiation steps).
2024-05-02 22:27:16 +00:00
prlanzarin
d658d81148 fix(audio): minimize redundant audio exit toasts
Audio exit toasts are fired in some redundant situations, e.g.: when the
error help screen is toast.

Change the logic a bit so that it's only fired when the audio help modal
won't be shown, i.e.: when audio had succesfully connected.
2024-05-02 22:09:56 +00:00
João Victor
32bb2dfe2f fix: make hook to store its own state to avoid useless re-renders 2024-05-02 17:18:38 -03:00
Ramón Souza
24b90070b7
Merge pull request #20136 from KDSBrowne/v30.19985
fix(whiteboard): Deactivate Drawing Tool On Access Change
2024-05-02 16:36:14 -03:00
Ramón Souza
5d27799448
Merge pull request #20143 from ramonlsouza/issue-20142
fix: Warning message character limit exceeded is still showing up after being sent
2024-05-02 14:57:12 -03:00
Tiago Jacobs
c5d1c8be3b
Merge pull request #20135 from GuiLeme/plugin-sdk-readme-logger-ui-data
feat(plugins): refactor intl code for plugin and general code
2024-05-02 14:45:52 -03:00
João Victor
5a80f30711 fix: tweak video-streams typings (Part 4) 2024-05-02 11:51:14 -03:00
João Victor Nunes
98d579401b
Merge branch 'v3.0.x-release' into video-streams-typings-fix 2024-05-02 11:41:09 -03:00
Ramón Souza
f589cb8828
Merge pull request #20076 from ramonlsouza/away-mode
feat: Improved away mode
2024-05-02 11:34:32 -03:00
João Victor
73eee42c66 fix: TS errors 2024-05-02 11:32:08 -03:00
João Victor Nunes
c61b6bb7e5
Merge branch 'v3.0.x-release' into video-streams-typings-fix 2024-05-02 11:26:08 -03:00
João Victor
9495e60d6f fix: ensure user's webcams are properly terminated 2024-05-02 11:22:24 -03:00
Ramón Souza
e0c8c0d933 remove chat error when a message is sent 2024-05-02 10:49:06 -03:00
Tiago Jacobs
90f3539332
Merge pull request #20141 from JoVictorNunes/fix-video-stream-user-filtering
fix(webcam): fetch user data of webcam users only
2024-05-02 10:32:56 -03:00
Ramón Souza
250a559a4c
Merge pull request #20133 from ramonlsouza/tld19-snapshot
fix: snapshot of current slide
2024-05-02 10:21:41 -03:00
Ramón Souza
ae10830a1a move setTrackEnabled to new service file 2024-05-02 09:24:03 -03:00
João Victor
ee9f98a1ad fix(webcam): fetch user data of webcam users only
- Do not fetch user data of users who are not in webcam.
- Except when grid layout is active. In this situation we need to know about all users.
2024-05-02 09:17:58 -03:00
Ramón Souza
82b1101df8 Merge remote-tracking branch 'upstream/v3.0.x-release' into away-mode 2024-05-02 08:45:10 -03:00
KDSBrowne
0704628caa lint 2024-05-02 00:40:58 +00:00
KDSBrowne
7512d4c60e lint 2024-05-02 00:32:58 +00:00
KDSBrowne
4ae0dd5fba change from CRLF to LF 2024-05-02 00:28:22 +00:00
KDSBrowne
d2da9172da add no operation tool 2024-05-02 00:05:12 +00:00
João Victor
59d84f4722 fix: wrong style file import 2024-05-01 17:05:17 -03:00
Guilherme Leme
bc6b007f5a [plugin-sdk-readme-logger-ui-data] - fix intl ui-data-hook and fix warning of data-channel 2024-05-01 16:57:08 -03:00
João Victor
d72ce1a24c fix: tweak video-streams typings (Part 3)
- Fix almost the entire video-provider component typyings. Leaving some errors because the component depends on a lot of code which is not in typescript yet. Any attempt to fix them may cause problems.
2024-05-01 16:49:21 -03:00
João Victor
6d70904ba9 fix: tweak video-streams typings (Part 2)
- Tweak low-level components.
2024-05-01 16:48:50 -03:00
João Victor
7297778746 fix: tweak video-streams typings (Part 1)
- Tweak high-level components.
2024-05-01 16:48:12 -03:00
Ramón Souza
87786cfcb6 fix snapshot of current slide 2024-05-01 16:21:36 -03:00
Tainan Felipe
527b6d4cbf Merge remote-tracking branch 'upstream/v3.0.x-release' into fix-meeting-end-audio 2024-05-01 14:14:15 -03:00
Tainan Felipe
d5bb06349b Fix: audio not disconnected when user leave the meeting 2024-05-01 14:11:04 -03:00
Anton Georgiev
a2984bb740 Merge remote-tracking branch 'bbb/v3.0.x-release' into html5-pack-30 2024-05-01 12:57:59 -04:00
Anton Georgiev
58cdb75c45 refactor: remove html5InstanceId 2024-05-01 12:53:11 -04:00
Tainan Felipe
b6f893c3c3 Fix: audio still playing when user left the meeting 2024-05-01 12:15:11 -03:00
André
66902fc9e3 Fix: External video re-starting when changing presenters 2024-05-01 10:21:28 -03:00
Tainan Felipe
5070d26c90 Merge remote-tracking branch 'upstream/v3.0.x-release' into code-removal 2024-05-01 09:58:01 -03:00
Ramón Souza
4767a0eec0
Merge pull request #20118 from Tainan404/remove-timer-js-files
Remove: timer js files
2024-05-01 09:41:55 -03:00
Tainan Felipe
e4a23feda3 Remove: old code from notes, pads and meeting ended 2024-05-01 09:39:03 -03:00
Tiago Jacobs
85b3cd88c5
Merge pull request #20127 from Tainan404/add-adapter-manager
Fix: add a adapters manager to lock loading while data sync
2024-05-01 09:23:09 -03:00
Ramón Souza
8fd4ea9bf0
Merge pull request #20115 from ramonlsouza/fix-chat-throttle
fix: throttle in user typing mutation
2024-05-01 09:09:05 -03:00
Tainan Felipe
210eb0911c Fix: add a adapters manager to lock loading while data sync 2024-05-01 08:38:12 -03:00
Ramón Souza
5f17c76b6a
Merge pull request #20113 from ramonlsouza/fix-default-selected-breakout
fix: user can't join default selected breakout
2024-04-30 16:34:30 -03:00
Ramón Souza
9b6e1e3ddd fix dependency array in memo 2024-04-30 16:34:16 -03:00
Tainan Felipe
7d7acb8a80 Remove: Breakout room unused code 2024-04-30 16:14:22 -03:00
Ramón Souza
d81bfdd7d4 fix ts error 2024-04-30 15:56:30 -03:00
KDSBrowne
14c44820f5 stop tldraw attempts to load assets from unpkg site 2024-04-30 16:40:43 +00:00
Tainan Felipe
528e82e2fc Remove: unused imports 2024-04-30 13:31:11 -03:00
Tainan Felipe
1e90237305 Remove: timer js files 2024-04-30 12:45:05 -03:00
Ramón Souza
248911b048 fix case where user is not assigned to any room and free join is enabled 2024-04-30 10:53:47 -03:00
Tainan Felipe
8d3d0008f0 Fix: lint error 2024-04-30 10:52:18 -03:00
Tainan Felipe
54d1ffa0ac Refactor: useUserCurrentData to use subscription instead of depends on context 2024-04-30 10:36:57 -03:00
Ramón Souza
c08c83e9e4 fix throttle in user typing mutation 2024-04-30 10:18:44 -03:00
Ramón Souza
d6c05189a1 fix default selected breakout invitation 2024-04-30 09:23:06 -03:00
Anton Georgiev
4227ff4ab6 Merge remote-tracking branch 'tainan/remove-redis' into html5-pack-30 2024-04-29 12:44:28 -04:00
Tainan Felipe
e58086c99e Remove: Frontend Redis client listener 2024-04-26 11:01:50 -03:00
Tainan Felipe
29c67e76ed Remove: client subscriptions component 2024-04-26 10:33:20 -03:00
Tiago Jacobs
3885c6a6e7
Merge pull request #20097 from GuiLeme/useCurrentMeeting
feat(plugin): Support useMeeting hook for plugin
2024-04-25 19:45:52 -03:00
Tainan Felipe
7096620781 Remove: video stream meteor server files 2024-04-25 17:53:47 -03:00
Tainan Felipe
c2399fa5b3 Merge remote-tracking branch 'upstream/v3.0.x-release' into remove-meteor-server-dependencies-2 2024-04-25 16:41:14 -03:00
Ramón Souza
7247407e7d
Merge pull request #20061 from JoVictorNunes/remove-video-streams-collection
Remove old `video-streams` Meteor subscription
2024-04-25 16:38:17 -03:00
Tiago Jacobs
023a7b1e4f
Merge pull request #20091 from ramonlsouza/remove-makecall
refactor: Remove remaining makecall
2024-04-25 16:36:43 -03:00
Guilherme Leme
0142ef7f81 [useCurrentMeeting] - created useMeeting hook 2024-04-25 16:19:44 -03:00
Tainan Felipe
5643305db2 Remove: pads meteor server files 2024-04-25 15:52:08 -03:00
Ramón Souza
e8a40aa301 remove makecall 2024-04-25 15:35:05 -03:00
Ramón Souza
a1c84229a6 remove userShareWebcam and userUnshareWebcam makecall 2024-04-25 15:33:23 -03:00
Ramón Souza
25760aafcb remove getPadId makecall 2024-04-25 15:27:43 -03:00
João Victor
453727b3ed Fix 2024-04-25 15:24:34 -03:00
João Victor
f10e7655eb Fix 2024-04-25 15:20:15 -03:00
Ramón Souza
5e78664e1d remove createSession makecall 2024-04-25 15:19:55 -03:00
Ramón Souza
220e689f1d remove pinPad makecall 2024-04-25 15:17:54 -03:00
Ramón Souza
0439a40535 remove createGroup makecall 2024-04-25 15:12:51 -03:00
Ramón Souza
6e546e0e6d remove requestUserInformation makecall 2024-04-25 15:08:40 -03:00
Ramón Souza
db4054df86 remove getServerTime makecall 2024-04-25 15:07:15 -03:00
Ramón Souza
2db64d7c3a remove timerEnded makecall 2024-04-25 14:55:22 -03:00
Ramón Souza
2723c8249d remove setPrivateGuestLobbyMessage makecall 2024-04-25 14:47:54 -03:00
João Victor
e623e9d0cd Fix 2024-04-25 14:44:41 -03:00
Tainan Felipe
7b6c948dc3 Fix: eslint 2024-04-25 14:42:25 -03:00
Tainan Felipe
9808d37092 Merge remote-tracking branch 'upstream/v3.0.x-release' into remove-meteor-server-dependencies-2 2024-04-25 14:33:56 -03:00
Ramón Souza
f9dda13e93 remove addUserSettings makecall 2024-04-25 14:26:51 -03:00
Ramón Souza
33b2854f01 remove endAllBreakouts makecall 2024-04-25 14:16:55 -03:00
Tainan Felipe
3142557849 Remove: external video player meteor server files 2024-04-25 14:06:38 -03:00