Commit Graph

4786 Commits

Author SHA1 Message Date
Anton Georgiev
e7917994d5 add banUser field in EjectUserFromMeetingCmdMsgBody 2020-05-22 10:45:28 -04:00
Anton Georgiev
aeeac803c7
Merge pull request #9620 from antobinary/simplify-publish
Simplify the code used for promote-demote subscriptions
2020-05-21 17:14:16 -04:00
Anton Georgiev
c290c9ee60 Merge branch 'v2.2.x-release' of github.com:bigbluebutton/bigbluebutton into ban-eject-user 2020-05-21 16:54:31 -04:00
Anton Georgiev
1874cf8392 Add visuals for banning vs ejecting user 2020-05-21 16:40:08 -04:00
Anton Georgiev
b6524e66c7
Fix typo closing parenthesis 2020-05-21 15:11:11 -04:00
Anton Georgiev
e08ee31338
Merge pull request #9629 from KDSBrowne/issue-9569
Update shared note item style
2020-05-21 15:06:45 -04:00
Anton Georgiev
66f11468ac
Merge pull request #9631 from KDSBrowne/issue-9592
Fix userData-shortcuts causing client crash
2020-05-21 15:01:49 -04:00
Anton Georgiev
8609418cda
Merge pull request #9630 from KDSBrowne/issue-9543
Change prompt message when screen share not supported
2020-05-21 14:58:07 -04:00
Anton Georgiev
be81b20ff1
Merge pull request #9632 from antobinary/lock-breakouts
Do not display "Lock viewers" option in breakouts
2020-05-21 14:57:21 -04:00
Anton Georgiev
33156f8bc5 Do not display "Lock viewers" option in breakouts 2020-05-21 14:55:32 -04:00
KDSBrowne
51c3543826 fix shortcuts not working when helper is passed an array 2020-05-21 18:43:34 +00:00
Anton Georgiev
ead986e3e2
Merge pull request #9542 from prlanzarin/upstream-2.2-safari-ss
Screenshare: add support on Safari 13+ and make constraints configurable
2020-05-21 14:38:32 -04:00
Anton Georgiev
2d16e020d8
Merge pull request #9593 from lfzawacki/2.2-external-video
Attempt to fix external video syncing
2020-05-21 14:34:52 -04:00
KDSBrowne
8fc32bc7dc update message in media container 2020-05-21 18:26:47 +00:00
Anton Georgiev
92d7975978
Merge pull request #9619 from antobinary/modOnlyMessage
Only provide modOnlyMessage to moderators
2020-05-21 13:55:09 -04:00
prlanzarin
2cba85e866 html5: refactor STUN/TURN fetch, add fallback STUN, fix deadlock in audio join
Refactored STUN/TURN fetch to be done only once, when successful, per session and cache it in mem to avoid too many reqs. Current way is a bit dumb, this should increase reliability a bit more. The caching is configurable so folks who want to use very short lived TURN credentials can disable it

Add a fallback STUN config option to be used when the default STUN/TURN fetch fails

Clean the safari/no candidate generation pre flight check from 3rd party STUNs

Fix deadlock in audio join when STUN/TURN fetch failed
2020-05-21 04:35:17 +00:00
Anton Georgiev
5238d81193 Simplify the code used for promote-demote subscriptions 2020-05-20 17:07:36 -04:00
Anton Georgiev
201fa2902e Only provide modOnlyMessage to moderators. Promoted mod requires refresh to see it 2020-05-20 15:56:44 -04:00
KDSBrowne
13cf0799a1 fix shortcuts passed as userData not activating 2020-05-20 13:47:04 +00:00
Pedro Beschorner Marin
73085ee88c Avoid guest promotion 2020-05-20 09:34:53 -03:00
KDSBrowne
2637685c1c update shared note item style 2020-05-19 13:58:00 +00:00
Lucas Zawacki
b9c75b4872 Remove timestamp correction logic 2020-05-18 13:16:03 -03:00
Lucas Zawacki
aa8326995c Work with video time based in seconds (integers) 2020-05-18 12:11:12 -03:00
KDSBrowne
f327f31e71 update not supported string to be browser agnostic (screen share) 2020-05-15 13:10:52 +00:00
KDSBrowne
4d8df0f91e restore presentation area when presentation changes 2020-05-14 21:06:55 +00:00
Paulo Lanzarin
7541395781
screenshare: fix safari availability check 2020-05-14 15:23:07 -03:00
prlanzarin
e875408f8d screenshare: add support on Safari 12.1+ and make constraints configurable
This adds support for screensharing on Safari 12.1+ or whichever has getDisplayMedia enabled

To be conservative and backwards compatible, I`ve maintained the current gUM-based code available as a fallback for those still using older versions of FF or Chrome

Made screenshare constraints configurable. The constraints config will be piped directly to gDM, so it`s just a regular gDM constraint dictionary
2020-05-14 16:54:54 +00:00
Anton Georgiev
a60407c665
Merge pull request #9301 from KDSBrowne/2.2-update-userlist-icon
Adds arrow to toggle user list icon
2020-05-14 10:48:43 -04:00
KDSBrowne
75270e20f8 fix TypeError: event.path is undefined 2020-05-13 12:53:55 +00:00
Anton Georgiev
4e636a2396
Merge pull request #9518 from KDSBrowne/issue-9511
Change shared notes lock behavior
2020-05-12 17:55:48 -04:00
KDSBrowne
43a9f04edf localise string 2020-05-12 21:34:07 +00:00
KDSBrowne
26143e5889 prevent user item unlock affecting shared notes 2020-05-12 21:21:56 +00:00
KDSBrowne
4c23e060bf add username to remove confirmation title / update modal description 2020-05-12 21:04:07 +00:00
KDSBrowne
c28b0108ea prevent user item displaying as locked for shared notes lock 2020-05-12 19:43:10 +00:00
KDSBrowne
5f4676ec63 show lock by moderator label on shared notes 2020-05-12 19:07:01 +00:00
KDSBrowne
321d2cbd37 hide default content conponent if hidePresentation and autoSwapLayout 2020-05-12 14:42:34 +00:00
KDSBrowne
f5d004c322 restore minimized presentation for viewer (slide or zoom change / published poll / added annotation) 2020-05-12 12:58:14 +00:00
Anton Georgiev
4b03c707a2
Merge pull request #9407 from KDSBrowne/issue-9297
Fix 'See other viewers in the Users list' lock enforcing lock on 'See other viewers webcams'
2020-05-11 15:06:38 -04:00
Anton Georgiev
21375864fe
Merge pull request #9477 from KDSBrowne/issue-9302
Localize default poll options before calculating annotation required space
2020-05-11 14:48:22 -04:00
Anton Georgiev
29f5154fcc
Merge pull request #9481 from KDSBrowne/issue-9450
Close video preview modal when "share webcam" lock activated
2020-05-11 14:38:20 -04:00
Anton Georgiev
ee3175cf86
Merge pull request #9408 from KDSBrowne/2.2-fix-selected-user
Set correct state in user list for selected user onClick
2020-05-11 12:55:29 -04:00
Anton Georgiev
97acff2433
Merge pull request #9475 from KDSBrowne/remove-user-confirmation
Adds remove user confirmation
2020-05-11 12:17:12 -04:00
Farzad Akbarinezhad
dd16e636ed customSvgIcon css class bug fixed for rtl layouts
in RTL layout, selecting colors and font thickness parts in whiteboard, will not appear correctly when they expand; one item will be thrown out of the container (overflow).
the following images demonstrate the problems.
adding some additional style to customSvgIcon class in css will fix the bug.

http://up.maralhost.com/do.php?img=359
http://up.maralhost.com/do.php?img=364
2020-05-11 12:03:17 -04:00
KDSBrowne
eaccf8364c add outline to poll annotation text 2020-05-11 12:56:53 +00:00
KDSBrowne
2be89479ba close video preview modal if lock setting active 2020-05-09 17:19:41 +00:00
KDSBrowne
41e33d9cda localise default poll options before calculating required annotation space 2020-05-08 18:17:50 +00:00
KDSBrowne
2ca54d69f4 add remove user confirmation 2020-05-07 14:32:15 +00:00
KDSBrowne
741455aeba remove hideUserList() from video-provider service 2020-05-06 15:14:07 +00:00
Joao Siebel
6f9c8ee8ee Filter by authed users and add projection to the query 2020-05-05 11:19:52 -03:00
Joao Siebel
3b8d10bd8c Fix race condition in addUserSettings 2020-05-04 22:16:52 -03:00
KDSBrowne
f9fa2f36dd set correct state for selected user on click 2020-05-04 13:40:13 +00:00
KDSBrowne
e82e0f5be9 fix see views in user list lock affecting webcams 2020-05-02 16:50:40 +00:00
Fred Dixon
f4b7287960
Merge pull request #9365 from KDSBrowne/2.2-prevent-dup-user-styles
Prevent multiple users displaying as selected in user list
2020-04-30 19:49:24 -04:00
KDSBrowne
dffe1b1747 prevent multiple users displaying as selected in userlist 2020-04-30 23:26:17 +00:00
Anton Georgiev
0ee1d7a4fe
Merge pull request #9363 from antobinary/breakouts-no-private-chat
Disable private chat initiation in breakouts
2020-04-30 17:54:59 -04:00
Anton Georgiev
722ffa5d07 disable private chat initiation in breakouts 2020-04-30 17:50:34 -04:00
KDSBrowne
6915a028e3 use extractCredentials to get meeting id 2020-04-30 13:46:30 +00:00
KDSBrowne
957e5e3d30 fix captions from dictation not working 2020-04-30 13:15:21 +00:00
Anton Georgiev
117d172b0d
Merge pull request #9343 from KDSBrowne/2.2-update-hideOverlay-css
Fix media overlay blocking whiteboard when drawing
2020-04-29 16:41:07 -04:00
KDSBrowne
174660a27c fully hide media ovelay / fix whiteboard drawing with no cams 2020-04-29 20:23:29 +00:00
Anton Georgiev
06f6331433
Merge pull request #8725 from capilkey/fix-typing-indicator-spacing
Fix the spacing in the typing indicator
2020-04-29 12:48:08 -04:00
KDSBrowne
9d9528798f Add client logger and error code messages 2020-04-29 16:34:37 +00:00
Joao Siebel
7eb935f244 Enforce extractCredentials 2020-04-29 01:41:16 -03:00
KDSBrowne
942df3b1a6 add arrow to toggle userlist icon 2020-04-28 16:43:14 +00:00
Anton Georgiev
1a2d0ae11b
Merge pull request #9081 from ubahnverleih/shortcut-help-osx
fixes shortcut help on mac browsers
2020-04-28 09:30:25 -04:00
KDSBrowne
7dcdfb1913 fix private chat lock not applying to already opened chats 2020-04-28 13:24:44 +00:00
KDSBrowne
de7e2780c7 Fix exception in presentation when publishing poll while minimized 2020-04-27 17:25:22 +00:00
ubahnverleih
92d3ee563f fixes shortcut help on mac browsers 2020-04-14 17:20:48 +02:00
KDSBrowne
1de9f2bfec show ss btn on safari (when selected display warning modal) 2020-04-13 15:31:16 +00:00
Fred Dixon
69a3b1c947
Merge pull request #9045 from riadvice/fix-download
Fix presentation download by using the presentation id not its name
2020-04-12 14:33:42 -04:00
Ghazi Triki
535f2d665a Fix presentation download by using the presentation id not its name. 2020-04-12 18:09:33 +03:00
Pedro Beschorner Marin
3a6260f6f3 Remove dangerouslySetInnerHTML from captions 2020-04-08 11:17:52 -03:00
KDSBrowne
e46a2c7ccc fix chat dropdown not filling screen (mobile) 2020-04-02 15:23:45 +00:00
KDSBrowne
50bb820eb7 Fix poll Maximum update depth exceeded error 2020-04-01 18:29:27 +00:00
Chad Pilkey
c44b8d452b fix the spacing in the typing indicator 2020-03-06 14:49:14 -08:00
Chad Pilkey
f41654729a force a stacking context to be created for the media container 2020-03-06 10:31:54 -08:00
Chad Pilkey
ace85ae6aa remove the minMessageLength warning from chat 2020-03-06 09:12:35 -08:00
Chad Pilkey
cc07bfff20 fixed inconsitencies and usage of the idChatOpen Session variable 2020-03-05 15:14:22 -08:00
Anton Georgiev
3c538d23d9
Merge pull request #8674 from lfzawacki/v2.2.x-release
More enhancements to the external video code
2020-03-03 09:49:31 -05:00
Lucas Zawacki
e67781d133 Centralize external video presenter message emission via a meteor call 2020-03-02 17:58:51 -03:00
KDSBrowne
ad808fb970 add conversion error messages / remove unused message 2020-02-28 21:57:05 +00:00
Anton Georgiev
addc5f2ea8
Merge pull request #8647 from pedrobmarin/user-list-text-overflow
Fix user-list item text-overflow
2020-02-28 11:05:14 -05:00
Anton Georgiev
99d31e9d5f
Merge pull request #8648 from capilkey/2.2-new-audio-state
Use internal messages for call state instead of DTMF
2020-02-28 11:04:03 -05:00
Lucas Zawacki
0088c348a5 Logic to throttle pause/un-pause messages coming from presenter 2020-02-27 16:42:07 -03:00
Lucas Zawacki
2102d0e66f Better handle and explain remote/local timestamp logic 2020-02-27 15:01:04 -03:00
Lucas Zawacki
6cbb4d6592 Adjust seek messages based on local and remote timestamps 2020-02-27 13:39:19 -03:00
Lucas Zawacki
f0d588511c Check presenter status outside of streamer 2020-02-27 13:39:00 -03:00
KDSBrowne
4e045283f4 move remove user option to bottom of dropdown menu 2020-02-27 15:17:24 +00:00
Chad Pilkey
584c115472
Merge pull request #8669 from antobinary/remove-some-atmosphere-packages
Explicitly import lodash where it is used
2020-02-26 14:58:52 -05:00
Anton Georgiev
f1fc72bc01 explicitly import lodash where it is used 2020-02-26 14:48:40 -05:00
Chad Pilkey
1912244de2
Merge pull request #8667 from antobinary/remove-some-atmosphere-packages
Remove some atmosphere packages
2020-02-26 12:47:50 -05:00
Anton Georgiev
dbc997cc85 explicitly import lodash so we can use _ functions 2020-02-26 10:43:24 -05:00
Anton Georgiev
e6f24fe874
Merge pull request #8650 from KDSBrowne/2.2-shortcut-fix
Fix broken shortcut keys
2020-02-24 16:54:38 -05:00
KDSBrowne
3933e04e43 correct typos / fixes broken shortcuts 2020-02-19 18:44:26 +00:00
Chad Pilkey
6a4ba7a300 watch for voice call state updates instead of DTMFs in the client 2020-02-18 14:03:06 -08:00
Pedro Beschorner Marin
8ccd24aefb Fix user-list item text-overflow 2020-02-18 18:31:58 -03:00
Anton Georgiev
4b5c6c65e9
Merge pull request #8613 from antobinary/userId-stuff
Utilize Meteor session id instead of trusting client side meetingI…
2020-02-18 11:56:21 -05:00
Anton Georgiev
fafc79b641
Merge pull request #8611 from pedrobmarin/user-list-style
Unify user-list content style
2020-02-14 16:54:18 -05:00
Pedro Beschorner Marin
5e3d039ec9
Fixed localization id 2020-02-14 12:12:36 -03:00
Anton Georgiev
1fa426058f corrected issues related to publishing and methods 2020-02-13 14:19:29 -05:00
Lucas Zawacki
c7bba345c6 Remove unused setState playing:true in onReady method 2020-02-12 17:39:45 -03:00
Lucas Zawacki
be9202a648 Adding some checks for null player in getCurrentTime and getCurrentPlaybackRate 2020-02-11 15:08:26 -03:00
Lucas Zawacki
fcecc3bcfe Fix playbackrate state when being set from local player 2020-02-11 15:08:24 -03:00
Lucas Zawacki
a90be659d7 Attempt to limit flow of presenterSync messages just in case 2020-02-11 15:08:21 -03:00
Lucas Zawacki
9f2826949d External video: don't use react state for flags that don't need re-renders 2020-02-11 15:08:18 -03:00
Lucas Zawacki
8165cba402 External video: prevent presenter from sending multiple unecessary play/pause messages 2020-02-11 15:08:13 -03:00
Anton Georgiev
a8f4827af8 utilize Meteor connection id instead of trusting client side meetingId, userId 2020-02-06 15:48:16 -05:00
Pedro Beschorner Marin
1d87949d65 Unify user-list content style 2020-02-06 16:46:21 -03:00
prlanzarin
10b4a60a57 Fix race condition in video-provider that may cause peers to fail
The peer object was being fetched only once in the ICE candidate callback, and it would fetch a placeholder empty object (sometimes) which would be kept in the callback closure till the end of the peer lifecycle. With that, the didSDPAnswered state variable which released the outbound ICE queue wouldnt be correctly read and the queue would never be flushed
2020-01-31 19:32:57 +00:00
Anton Georgiev
e420dc2546 add bbb_show_participants_on_login as a join parameter 2020-01-30 15:43:54 -05:00
Anton Georgiev
efbe4675b8
Merge pull request #8482 from jfsiebel/streamer-fix
Fix streamer not working on meteor restart
2020-01-15 12:25:02 -05:00
Lucas Zawacki
4ade850a5a Pause synced video if presenter exits the room 2020-01-13 13:53:49 -03:00
Lucas Zawacki
14fd979955 Remove viewerJoined logic and prevent handleOnReady from running multiple times 2020-01-13 13:53:47 -03:00
Joao Siebel
f95107e3a0 Remove JSON.parse and JSON.stringfy 2020-01-13 13:43:31 -03:00
Joao Siebel
b6c900ca84 Fix annotations and cursor streamer
The problem was caused when meteor restarted without reloading the page,
the ddp subscription called a onStop event that set all handlers to undefined
after we set the handlers on the init function.
2020-01-13 09:34:54 -03:00
Pedro Beschorner Marin
9b450ae1d9 Check Safari before listening for ondevicechange 2019-12-20 17:21:40 -03:00
Pedro Beschorner Marin
78b0d0276a Avoid multiple cameras sharing in mobile and safari 2019-12-20 17:21:23 -03:00
Anton Georgiev
4e1d55efd2 Prevent parallel screenshare and external-video 2019-12-18 16:40:04 -05:00
Pedro Beschorner Marin
ebef3f7a15 Linter things 2019-12-18 14:50:16 -03:00
Pedro Beschorner Marin
8e129fb961 Included multiple cameras UI 2019-12-18 14:44:56 -03:00
Pedro Beschorner Marin
801ed30a8e Missing after rebase 2019-12-10 13:02:18 +00:00
Pedro Beschorner Marin
5c71e2d0bb Included new getStats monitor for audio and video 2019-12-10 09:07:06 -03:00
Pedro Beschorner Marin
a434f61052 Reverting file mode changes 2019-12-10 09:05:04 -03:00
Pedro Beschorner Marin
f5d7be7f00 Making the interface functional for the multiple webcams. This must change after thinking on a design 2019-12-10 09:05:03 -03:00
Pedro Beschorner Marin
315fa755f0 Removed unused video visibility monitor 2019-12-10 09:02:17 -03:00
Pedro Beschorner Marin
3b591a086b Unified video providers 2019-12-10 09:02:16 -03:00
Pedro Beschorner Marin
9fcae355c7 joinVideo gets the deviceId 2019-12-10 08:21:22 -03:00
Pedro Beschorner Marin
59bc7f91a1 Refactored video service 2019-12-10 08:21:21 -03:00
Pedro Beschorner Marin
debd8f714a Removed unused session vars logic 2019-12-10 08:21:21 -03:00
Pedro Beschorner Marin
df6dd33c82 Fix for second camera connection 2019-12-10 08:21:21 -03:00
Pedro Beschorner Marin
3d2dd9b11c Sharing webcam with deviceId prefix 2019-12-10 08:21:20 -03:00
Pedro Beschorner Marin
aa51aadea7 Removed extra events 2019-12-10 08:21:20 -03:00
Pedro Beschorner Marin
85b517c6bf Linter stuff 2019-12-10 08:21:20 -03:00
Pedro Beschorner Marin
9da1c29c88 Cleanup 2019-12-10 08:21:19 -03:00
Pedro Beschorner Marin
4eb67c12be Multiple webcams first commit 2019-12-10 08:21:19 -03:00
Anton Georgiev
a952efe4b2
Merge pull request #8397 from KDSBrowne/update-whos-talking
Fix elements overlapping whos talking
2019-12-09 15:28:30 -05:00
Anton Georgiev
c2d90b1d2d
Merge pull request #8323 from KDSBrowne/issue-8290
Fix restore presentation button overlap (Mobile - Presenter)
2019-12-09 15:26:32 -05:00
Joao Siebel
88fad50233 WIP streamer stuff 2019-12-06 14:46:58 -03:00
KDSBrowne
d71b3e67ab clean up css values 2019-12-04 19:48:06 +00:00
Joao Siebel
8e252500ec Add debug messages to cursor streamer 2019-12-04 12:42:41 -03:00
KDSBrowne
a0374d61f6 fix indicator being overlapped (mobile portrait) 2019-11-29 15:19:48 +00:00
prlanzarin
4e55145381 Change VideoService userName fetch to Auth and pass it again to video-provider 2019-11-28 18:49:20 +00:00
prlanzarin
19bf430760 Add userId and userName to the SFU start calls where they were missing 2019-11-28 18:46:23 +00:00
prlanzarin
52d69156ca Fix viewer camera reconnection timers
Also try to reconnect when ICE fails, a server-side error comes through or the WebRTC stack throws a tantrum, not only when the first connection fails.
2019-11-28 18:03:14 +00:00
prlanzarin
d3fa2f6508 Add an outbound ice queue to video-provider peers
Only send candidates after the SDP exchange was locked due stop-start glare
2019-11-28 18:01:32 +00:00
Anton Georgiev
c7c29e37e9
Merge pull request #8368 from felcaetano/enable-change-slides-with-page-up-down
Swapping PAGE_UP and PAGE_DOWN key bindings
2019-11-26 17:13:34 -05:00
felcaetano
e13cf362b2
Swapping PAGE_UP and PAGE_DOWN key bindings
Swapping the keys as requested by @kaitkrull  to fit most of the remotes.
2019-11-26 19:00:28 -03:00
KDSBrowne
3cd81682f7 make talking indicator display users with the same name 2019-11-26 16:44:58 +00:00
KDSBrowne
7e1727f652 make talking indicator scrollable horizontally 2019-11-26 15:59:26 +00:00
KDSBrowne
b61fa7f9fc fix indicator clipping on safari 2019-11-25 19:24:12 +00:00