Commit Graph

290 Commits

Author SHA1 Message Date
prlanzarin
5d214cb27d fix(video): ensure streams are always attached on reconnections
There's a scenario where remote streams won't be attached again if the
sharer experienced a Meteor/client disconnection.
The disconnection empties some necessary user data temporarily, which
causes the corresponding video-list-item to be unmounted while the peer
persists for a little longer.
If the sharer re-connects fast enough, video-list-item will re-mount but
will 1) miss the current stream state (ie stuck in loading) 2) fail to
re-attach the streams since the peer was already flagged as attached.

Ensure remote camera streams are always attached and shown by:
  - always propagating the current stream state on attachment
  - refactoring the attachment pre-requisites away from a static boolean
    to a required data + diff check (based on target and current
    attached streams)
2023-04-11 09:36:13 -03:00
Anton Georgiev
e2dc7da98a
Merge pull request #16828 from prlanzarin/u27/fix/ss-cam-reconn
fix: re-connection improvements for cameras and screen sharing
2023-04-05 16:13:01 -04:00
Anton B
4b5d4e9e2a Merge remote-tracking branch 'upstream/v2.6.x-release' into webcam-tests 2023-03-29 10:29:58 -03:00
prlanzarin
e9f0a7347c fix(video): properly render reconnecting view
The stream state change handler in video-list-item is using a component
state reference inside a DOM event callback - which means it is always
presuming `isStreamHealthy` is false (initial value). That prevents the
health state from actually transitioning when necessary (and
consequently rendering the reconnecting view in video-list item).

This commit removes the state-based transition check in the state change
handler and unifies the reconnecting view to use the username
placeholde (replacing the loading spinners).
2023-03-08 15:46:44 -03:00
KDSBrowne
73cd791199 add aria label to webcam options with user name when small 2023-02-06 16:11:05 +00:00
Ramón Souza
0cf1d09978 add early return to video list item if user data is unavailable 2022-12-15 14:49:47 -03:00
KDSBrowne
9c6a6298e2 update menu ids to be unique 2022-10-05 21:54:59 +00:00
Anton B
3b04dbff48 test: add pinning and unpinning test, improve share webcam test and add selectors 2022-09-12 14:12:35 -03:00
Joao Victor
5c6c28cdd2 Fix conflicts 2022-07-25 15:14:27 -03:00
Joao Victor
8809ff3a65 fix: add missing activity date in drag & drop handler 2022-07-08 12:26:01 -03:00
Joao Victor
f8ec4ef640 refactor: virtual background context 2022-07-07 18:59:30 -03:00
Joao Victor
aaf7f8e78e improvement(virtual background): better error handling, notifications, performance 2022-07-06 10:38:40 -03:00
Ramon Souza
9e246093f9 remove duplicated webcam label 2022-07-04 10:41:27 -03:00
Joao Victor
4b9f16ca0f fix: add check for potential undefined userId 2022-06-28 17:41:03 -03:00
Ramon Souza
edeb70de0d Merge tag 'v2.5.1' into merge25-26-jun16 2022-06-16 13:58:54 -03:00
Joao Victor
b75fbe8279 Remove merge residue 2022-06-01 16:55:28 -03:00
Joao Victor
2a1401f2ae Merge remote-tracking branch v2.6.x-release into virtual-background-upload 2022-06-01 16:50:29 -03:00
Joao Victor
1c02ff3877 fix: make drag-and-drop stuff follow the config 2022-06-01 14:30:50 -03:00
Joao Victor
769629daf6 improvement: add a new service function for reading the file 2022-06-01 12:05:16 -03:00
Joao Victor
b3d18a1d28 improvement: add HOC to concentrate drag-and-drop code 2022-06-01 10:34:21 -03:00
Joao Victor
e7d9b46097 fix: add some file sanitization 2022-05-31 16:32:58 -03:00
Max Franke
8b8ba0c9f4 fix(webcam): draggable camera dock 2022-05-31 14:14:18 -03:00
Max Franke
2fbb4e8821 fix(webcam): user status icons align
Align user status icons to match other icons paddings/margins
2022-05-31 13:38:37 -03:00
Max Franke
a53b41721b fix(video-avatar): prevent state update on an unmounted component 2022-05-31 13:38:37 -03:00
Max Franke
00a8e64261 feat(video-avatar): change border
Apply isTalking border with a pseudo-element.
2022-05-30 15:08:25 -03:00
Max Franke
45d3738960 feat(video-avatar): hide icons when squeezed 2022-05-24 17:20:29 -03:00
prlanzarin
0a05d3b673 fix: client crash on meeting end/user left with cameras 2022-05-13 16:20:57 +00:00
Joao Victor
e070b586c4 [2.5] fix: popover menus in RTL mode 2022-05-13 10:42:19 -03:00
prlanzarin
6d02d7218f fix: client crash on meeting end/user left with cameras 2022-05-10 18:57:26 +00:00
Joao Victor
a7e5869c91 feat(video): upload of own webcam virtual background 2022-05-10 14:17:16 -03:00
Ramón Souza
092cda8000
Merge pull request #14965 from frankemax/fix-joined-spinner
fix(webcam): spinner and prop types
2022-05-10 17:01:46 +01:00
Paulo Lanzarin
c6dedfebe2
Merge pull request #14938 from frankemax/add-video-avatar-loading-2.6
feat(webcam): avatar loading
2022-05-10 09:56:58 -03:00
Max Franke
f9b2fbf4d2 fix(video-list-item): mirror own webcam
Fix mirror own webcam not working
Probably broke after e45deb5e7e
2022-05-09 16:28:30 -03:00
Max Franke
d75111d85a fix(video-list-item): spinner and unhealthy stream
Fix spinner
Add unhealthy stream filter to the avatar
2022-05-09 16:17:38 -03:00
Max Franke
cf56e064e4 fix(user-status): add joined value
Add correct prop types to user-status
2022-05-09 16:17:38 -03:00
Max Franke
d642464897 feat(video-list-item): avatar loading
Add a new avatar component to video list item
Change the design of the components, following the new video list idea
Add icons related to the state of the user
2022-05-09 16:17:33 -03:00
Max Franke
b0b5f812e5 fix(video-list-item): mirror own webcam
Fix mirror own webcam not working
Probably broke after e45deb5e7e
2022-05-06 14:06:25 -03:00
Max Franke
1a63dbd648 fix(webcam): joined value
Add correct prop types to user-status
2022-05-05 18:11:22 -03:00
Max Franke
2cf7e3903e fix(webcam): fix reconnecting spinner
Fix loading spinner not spinning
2022-05-05 17:58:09 -03:00
Mario Junior
dced094ad7
Merge pull request #14833 from lfzawacki/develop-bbb
New Layout code and push layout states for camera position, size, focus and presentation minize
2022-05-04 16:51:06 -03:00
Max Franke
9392669cd8 feat(video-list-item): prevent undefined observer
Add extras checks to observer related values
Move the video container width bound to a const
2022-04-27 11:48:14 -03:00
Lucas Zawacki
83847a21aa Merge branch 'v2.5.x-release-Layouts' of github.com:lfzawacki/bigbluebutton into develop-bbb 2022-04-13 21:08:32 +00:00
Max Franke
c01c778a2e feat(video): hide webcam stuff when squeezed
Hide the default buttons when video container is too small.
Groups the functionality of other buttons into just one button.
2022-04-11 18:48:17 -03:00
Anton B
6eead03fb3 set dynamic steps by current settings 2022-03-29 10:53:07 -03:00
Max Franke
e45deb5e7e refactor(video-list-item): hookify and reorganize component 2022-03-24 13:29:13 -03:00
Lucas Zawacki
1180f4edf1 bug(layout): Guarantee right size for focused video 2022-02-25 15:05:34 -03:00
Lucas Zawacki
8d6931f656 feature(layout): Add focused camera to layout context 2022-02-24 14:22:00 -03:00
Ramón Souza
fa7af8fe27 move menu component to common folder 2022-02-15 15:38:55 +00:00
Ramón Souza
96900ee6a3 move icon component to common folder 2022-02-15 14:51:51 +00:00
Ramón Souza
0377854b98 move fullscreen-button component to common folder 2022-02-15 14:42:02 +00:00