Commit Graph

10637 Commits

Author SHA1 Message Date
Joao Victor
caa8667526 fix: mute external video when in echo test 2022-10-06 11:45:52 -03:00
GuiLeme
af7c7d1191 [issue-pdf-100-processing] - fix for merge 2022-10-06 11:24:50 -03:00
GuiLeme
5ca4a92940 [issue-pdf-100-processing] - resolved conflicts 2022-10-06 09:58:42 -03:00
KDSBrowne
9c6a6298e2 update menu ids to be unique 2022-10-05 21:54:59 +00:00
germanocaumo
8f41ab31da fix(tldraw): persist bound shapes (arrows) + fix sending unneeded changes 2022-10-05 20:43:48 +00:00
Gabriel Porfirio
4bfb2eba95 improved breakout remaning time check 2022-10-05 17:35:19 -03:00
germanocaumo
2fa76d60c4 Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into tldraw-shape-updates 2022-10-05 19:56:54 +00:00
Carlos
e53b961173 fix(external videos) youtube shorts link working
If the url is from youtube shorts change the url.
2022-10-05 15:53:44 -03:00
Gustavo Trott
bbe3ca34a8
Merge pull request #15474 from GuiLeme/apply-toast-shared-notes 2022-10-05 12:02:04 -03:00
Joao Victor
7e8cee7340 improvement: error screen messages 2022-10-05 11:30:12 -03:00
GuiLeme
3b90bdb8b2 [apply-toast-shared-notes] - Fix problems with shared notes 2022-10-04 16:25:54 -03:00
KDSBrowne
ed7cb5f6e5 add focus and hover styles to skip slide dropdown / reset zoom 2022-10-04 15:38:34 +00:00
KDSBrowne
ab63779b2f add video settings menu to tab order 2022-10-04 14:21:52 +00:00
germanocaumo
3ecf79cc4f fix(whiteboard): only call annotation upsert in one frontend instance
We were calling upsert in the Annotations collection for the same annotation in all frontend instances, this could lead to the same annotation being inserted
multiple times with different ids due to concurrency.

Added the html5InstanceId of the original request to the redis message so we can use it to only call upsert in one instance.
2022-10-04 10:28:36 +00:00
germanocaumo
9d059dc5e5 fix(whiteboard): avoid subscribing to annotations multiple times
The subscription to annotations sometimes could be ready and stopped before the component fully loads,
allowing it to be subscribed again (and then receiving all the annotations via websocket two times).

Moved the subscription to occur only after the base ones.
2022-10-04 09:35:06 +00:00
Ramón Souza
077592df18
Merge pull request #15745 from germanocaumo/dup-ann-ws-fix
fix(whiteboard): annotations duplication in websocket/collection
2022-10-03 15:10:59 -03:00
Ramón Souza
4b4afb6916 remove empty object in logs 2022-10-03 13:48:00 -03:00
Daniel Petri Rocha
234e36f462
Merge branch 'v2.6.x-release' into breakout-upload-ui 2022-10-03 11:05:23 +02:00
Daniel Petri Rocha
26a93f6853
Merge branch 'v2.6.x-release' into capture-shared-notes 2022-10-03 11:03:24 +02:00
Ramón Souza
a15cf73721
Merge pull request #15763 from germanocaumo/tldraw-zoom-fixes
fix(whiteboard): several zoom fixes
2022-09-30 17:18:45 -03:00
Ramón Souza
61cfdd9377
Merge pull request #15725 from germanocaumo/f-t-cursor
fix(cursor): hide cursor for others on mouse leave
2022-09-30 12:58:41 -03:00
KDSBrowne
02836bd78d add missing aria-describedby label on delete btn 2022-09-30 15:24:45 +00:00
KDSBrowne
5bd8d7fd0f remove double tab on checkbox component 2022-09-30 15:24:36 +00:00
KDSBrowne
b73ad8a85f update aria descriptions in video preview modal | fix checkbox aria label 2022-09-30 15:24:24 +00:00
KDSBrowne
03cf283ab3 update upload virtual background button aria description 2022-09-30 15:24:15 +00:00
germanocaumo
e1ee782294 fix(whiteboard): several zoom fixes
Sometimes when whiteboard props change (mainly resizes), the tldraw component gets
mounted again, resetting its camera, and was causing zoom to be applied incorrectly.
I've added a useEffect to better react to when the camera resets and reset to the corret zoom.
2022-09-30 14:35:29 +00:00
GuiLeme
362371834a Merge remote-tracking branch 'upstream/v2.6.x-release' into issue-pdf-100-processing 2022-09-30 10:34:23 -03:00
gabriellpr
b23cc4ea51
Merge branch 'v2.6.x-release' into breakout-create-tests 2022-09-30 08:23:52 -03:00
Gabriel Porfirio
0e8a2b9a2e improving the tests 2022-09-30 08:17:15 -03:00
Ramón Souza
3ea427aa49
Merge pull request #15751 from JoVictorNunes/brightness-label-selection
improvement: disable text selection of brightness labels
2022-09-29 13:57:36 -03:00
KDSBrowne
7ed1c5b274 add hover and focus outlines to layout buttons 2022-09-29 14:58:55 +00:00
KDSBrowne
4453425350 add aria description to layout buttons 2022-09-29 14:46:49 +00:00
Joao Victor
e4d8863e9f fix: screenshare volume control 2022-09-29 11:07:31 -03:00
João Victor Nunes
19b28de056
Merge branch 'v2.6.x-release' into issue-15713 2022-09-29 10:49:17 -03:00
Ramón Souza
045e2ec95d
Merge pull request #15740 from JoVictorNunes/issue-15712
fix: add config to disable emoji sort on click
2022-09-29 10:32:07 -03:00
Ramón Souza
e1095869c9
Merge pull request #15665 from ramonlsouza/add-locale-format
Support @ notation for localization files
2022-09-29 10:23:08 -03:00
KDSBrowne
6560fbff32 remove paths from layout buttons alt text 2022-09-29 13:20:38 +00:00
KDSBrowne
d7314ff442 update whiteboard options aria label 2022-09-29 13:04:17 +00:00
Ramón Souza
223bc60814
Merge pull request #15748 from JoVictorNunes/issue-15746
improvement: text selection in chat
2022-09-29 10:02:37 -03:00
Joao Victor
82f385c88e improvement: disable text selection of brightness labels 2022-09-29 09:49:36 -03:00
Joao Victor
27268dc697 improvement: text selection in chat 2022-09-28 15:32:37 -03:00
Daniel Petri Rocha
289f4125ec Perform captured pad upload 2022-09-28 19:56:29 +02:00
Ramón Souza
9b7186a23a
Merge pull request #15738 from ramonlsouza/fix-cursor-bug
fix: cursor bug after camera is dropped in the same place
2022-09-28 14:33:40 -03:00
Ramón Souza
6963bc0db4 Merge remote-tracking branch 'upstream/v2.6.x-release' into add-locale-format 2022-09-28 14:32:01 -03:00
Joao Victor
50d92925f7 fix: add empty string fallback config 2022-09-28 14:24:27 -03:00
Ramón Souza
ea96301893
Merge pull request #15737 from ramonlsouza/issue-15718
fix: Unable to expand the sidebar content by pulling on webcam part when close to whiteboard
2022-09-28 14:20:42 -03:00
Joao Victor
f8279ab5b4 improvement: add internationalization singleton 2022-09-28 13:48:27 -03:00
Gustavo Trott
be81a0e32a
Merge pull request #15541 from gustavotrott/html5-show-ejectedReason 2022-09-28 10:59:04 -03:00
germanocaumo
d770a7df8c fix(whiteboard): only call annotation upsert in one frontend instance
We were calling upsert in the Annotations collection for the same annotation in all frontend instances, this could lead to the same annotation being inserted
multiple times with different ids due to concurrency.

Added the html5InstanceId of the original request to the redis message so we can use it to only call upsert in one instance.
2022-09-28 12:03:59 +00:00
germanocaumo
af1c7fe7fc fix(whiteboard): avoid subscribing to annotations multiple times
The subscription to annotations sometimes could be ready and stopped before the component fully loads,
allowing it to be subscribed again (and then receiving all the annotations via websocket two times).

Moved the subscription to occur only after the base ones.
2022-09-28 11:43:10 +00:00
Joao Victor
862c9fb64d fix: add config to disable emoji sort on click 2022-09-27 15:47:39 -03:00
Ramón Souza
089b64deb7
Merge pull request #15657 from JoVictorNunes/issue-15574
refactor: push layout
2022-09-27 11:13:28 -03:00
GuiLeme
9495e9ae01 [apply-toast-shared-notes] - fix shared-notes display wrong information when clicking the confirm button 2022-09-27 10:05:27 -03:00
Ramón Souza
2ae9eca935 fix cursor bug on camera drag 2022-09-26 17:15:48 -03:00
Ramón Souza
52e8d58a54 fix sidebar resize when webcam is below the chat 2022-09-26 16:22:47 -03:00
Ramón Souza
fcf05910d1
Merge pull request #15724 from JoVictorNunes/issue-15692
fix: allow video settings to open
2022-09-26 13:39:52 -03:00
Ramón Souza
2b0971e2c8 Merge tag 'v2.5.6' into merge-256-26 2022-09-26 09:17:59 -03:00
Daniel Petri Rocha
76b24e1ec3 Route padId to bbb-export-annotations 2022-09-24 22:59:29 +02:00
GuiLeme
5cb34e7917 [apply-toast-shared-notes] - changes in Review 2022-09-23 12:24:39 -03:00
Gabriel Porfirio
7d8a52d106 breakout test creation and after creation 2022-09-22 17:17:15 -03:00
GuiLeme
633a032fd0 [issue-pdf-100-processing] - implemented retry flow and fixed error message 2022-09-22 16:58:37 -03:00
Gustavo Trott
03378ed48e Remove delay to endMeeting when user is ejected=true 2022-09-22 14:22:58 -03:00
Joao Victor
ab40586702 fix: allow video settings to open 2022-09-22 09:37:24 -03:00
germanocaumo
fea31e366c refactor: code smell 2022-09-22 10:06:23 +00:00
germanocaumo
01a1cf83d7 fix(cursor): correctly hide cursor for others on mouse leave
Also update out of bounds coords to -1.0 to not display on playback.
2022-09-21 20:49:07 +00:00
GuiLeme
ecf5146604 [apply-toast-shared-notes] - fixed delay in shared notes' move-to-whiteboard button 2022-09-21 17:41:31 -03:00
Ramón Souza
b3c59ae672
Merge pull request #15723 from ramonlsouza/xhr-fallback-25
fix: disable xhr fallback on websocket connection (2.5)
2022-09-21 16:50:59 -03:00
Ramón Souza
ca52a2e073
Merge pull request #15714 from ramonlsouza/port-15687-25
fix: multiple answer translation in live results (2.5)
2022-09-21 16:49:24 -03:00
Ramón Souza
426b283f42
Merge pull request #15710 from ramonlsouza/issue-15709
fix: broadcast push alert crash in breakouts
2022-09-21 16:49:13 -03:00
Gustavo Trott
89ea5d07d3 Merge remote-tracking branch 'upstream/v2.5.x-release' into html5-show-ejectedReason 2022-09-21 15:58:01 -03:00
germanocaumo
ae7eb92c86 Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into tldraw-disable-select 2022-09-21 18:10:05 +00:00
Ramón Souza
6d1463e03b add disableWebsocketFallback settings 2022-09-21 11:03:21 -03:00
Gustavo Trott
f3bb17a5e1
Merge pull request #15616 from gabriellpr/emojis-test 2022-09-20 16:50:59 -03:00
Gustavo Trott
7e18b03bf1
Merge pull request #15651 from gabriellpr/help-button-tests 2022-09-20 16:50:50 -03:00
Ramón Souza
c6ea6a5d12 fix multiple answer translation in live results 2022-09-20 13:28:25 -03:00
Ramón Souza
3cccbc4b97
Merge pull request #15687 from ramonlsouza/issue-15686
fix: multiple answer translation in live results
2022-09-20 13:27:23 -03:00
Daniel Petri Rocha
e23d00004f 'Capture Shared Notes' button in front-end 2022-09-20 17:43:13 +02:00
Ramón Souza
a882701ac7 fix broadcast push alert in breakouts 2022-09-20 09:57:08 -03:00
Daniel Petri Rocha
c84c2e2892 Merge branch 'v2.6.x-release' into breakout-upload-ui 2022-09-19 19:30:18 +02:00
Daniel Petri Rocha
7c086c3ea2 No checkbox in UI if capture disabled 2022-09-18 17:53:52 +02:00
Daniel Petri Rocha
e5ed5a4546 Capture slides from breakout rooms upon their end
Sends out the request to export the presentations from the main meeting to each breakout room.
The breakout rooms then generate the PDF file and upload it back to the main meeting.
2022-09-18 15:55:20 +02:00
GuiLeme
d7c5ab3623 [apply-toast-shared-notes] - error messages wait until user closes them and added timeout to toast 2022-09-16 17:36:23 -03:00
Ramón Souza
ab50d4d60e add settings 2022-09-16 13:01:07 -03:00
GuiLeme
dea0e498c7 [apply-toast-shared-notes] - Fix default and large presentation crash 2022-09-16 12:52:41 -03:00
Ramón Souza
83c9e644b1 add settings 2022-09-16 11:56:56 -03:00
Ramón Souza
706014430c change server name format and add timestamp to logs 2022-09-16 11:09:21 -03:00
Ramón Souza
485103ff93 include server role and instance in logs 2022-09-16 11:09:12 -03:00
Ramón Souza
7bb26b64ff add server health log 2022-09-16 11:09:04 -03:00
Ramón Souza
774da00d16 change server name format and add timestamp to logs 2022-09-16 10:48:21 -03:00
prlanzarin
0f24e5634d fix(audio): bypass overconstrained errors in SFU-based audio 2022-09-15 20:42:43 +00:00
Ramón Souza
facae4e2fb include server role and instance in logs 2022-09-15 16:57:20 -03:00
Ramón Souza
f6642bd2a8 add server health log 2022-09-15 16:56:00 -03:00
prlanzarin
b3eebbb926 fix(audio): retry gUM without pre-set deviceIds on OverconstrainedError(s)
There are some situations where previously set deviceIds (
local/session storage) may become stale. This causes an unexpected
behavior where audio is temporarily borked until the user clears their
local storage.
This issue has been seen more recently on Safari endpoints when switching
back-and-forth breakout rooms in environments running under iframes.
Also seen randomly on endpoints with virtual input devices.

This centralizes audio gUM calling into a single method that retries the
gUM procedure without pre-set deviceIds only if the initial call fails
due with an OverconstrainedError - hopefully circumventing the issue.
2022-09-15 19:25:30 +00:00
Gabriel Porfirio
9ee4e929b9 data-test to breakout rooms 2022-09-15 15:34:14 -03:00
Joao Victor
745937868c fix: 'horizontalPosition' prop type 2022-09-15 12:01:31 -03:00
Gustavo Trott
10c81bf689
Merge pull request #15690 from zhem0004/handleCursorPropertyError 2022-09-15 10:36:14 -03:00
Joao Victor
968e872c5b Merge branch 'v2.6.x-release' into issue-15574 2022-09-15 09:13:02 -03:00
Ramón Souza
2a062b25dc
Merge pull request #15683 from ramonlsouza/issue-15669
fix: set breakout name input as readonly when updating users
2022-09-14 17:08:49 -03:00
Bohdan Zhemelinskyi
811d135585 handle missing cursor property case 2022-09-14 19:42:15 +00:00
Ramón Souza
8a59a104b5
Merge pull request #15649 from ramonlsouza/port-15618-25
fix: port adjustments in breakout publisher to 2.5
2022-09-14 13:28:58 -03:00
Ramón Souza
7d7f26ea55
Merge pull request #15624 from KDSBrowne/bbb-text-updates
fix: Restore Text Shape Updates Per Character
2022-09-14 13:06:10 -03:00
GuiLeme
39b6359441 [issue-pdf-100-processing] - fix timeout error when PDF is too complex. 2022-09-14 10:33:41 -03:00
Ramón Souza
634393e740
Merge pull request #15670 from ramonlsouza/fix-warnings
Fix: bigbluebutton-html5 warnings
2022-09-14 10:17:01 -03:00
Ramón Souza
a924aecc1d fix multiple answer translation in live results 2022-09-14 09:51:48 -03:00
Ramón Souza
cb9be4b072
Merge pull request #15612 from JoVictorNunes/issue-15579
chore/fix: update `react-intl` to `6.1.0` and add config to disable fallback
2022-09-13 16:28:03 -03:00
Ramón Souza
2b6b129df9 set breakout name input as readonly when updating users 2022-09-13 10:45:13 -03:00
Ramón Souza
1925124e82 fix button overflow in presentation toolbar 2022-09-12 16:27:29 -03:00
Anton Georgiev
5f4c89b6ff
Merge pull request #15672 from ramonlsouza/current-presentation-class
refactor: Add "current presentation" toast unique class
2022-09-09 19:43:44 -04:00
Gabriel Porfirio
f1d45502a0 WIP: breakout room create tests 2022-09-09 13:54:50 -03:00
Ramón Souza
5a83f9b392 add unique className to current presentation toasts 2022-09-09 13:25:20 -03:00
Ramón Souza
efb3083373 only mount layoutEngine when layoutType is available 2022-09-09 10:19:43 -03:00
Ramón Souza
4e80475fd0 fix tabIndex warning 2022-09-09 10:19:04 -03:00
Ramón Souza
dda6b83958 fix panning warning 2022-09-09 10:14:20 -03:00
Ramón Souza
5588e19e3c
Merge pull request #15558 from JoVictorNunes/issue-15555
fix: check virtual background type on change
2022-09-09 09:25:15 -03:00
Paulo Lanzarin
9c4707b56d
Merge pull request #15582 from prlanzarin/u26/refactor/mic-inout-logs-26
fix(audio): review in/out device management and switching
2022-09-09 09:22:40 -03:00
Paulo Lanzarin
362785a83a
Merge pull request #15647 from prlanzarin/u26/fix/cam-profile-switch-notreadableerror
fix(webcam): switching profiles in preview fails intermittently
2022-09-08 15:11:33 -03:00
Ramón Souza
560d9370c6 adjust html/body lang on page load 2022-09-08 14:25:29 -03:00
Ramón Souza
c6c65c4aa0 add support to xx@xxxx localization files 2022-09-08 11:47:41 -03:00
Ramón Souza
406c215add
Merge pull request #15659 from JoVictorNunes/issue-15658
fix(whiteboard toolbar): reduce distance from the bottom
2022-09-08 09:37:20 -03:00
Joao Victor
4277a0ed03 fix: volume icon 2022-09-07 11:59:43 -03:00
Joao Victor
19e71697d6 Merge remote-tracking branch 'upstream/v2.6.x-release' into issue-15559 2022-09-07 11:54:52 -03:00
Joao Victor
36864a8880 fix(whiteboard toolbar): reduce offset from the bottom 2022-09-07 11:34:54 -03:00
Joao Victor
acc55f0d08 fix: don't allow moderators to propagate meeting layout info (#15574). -- Currently moderators can propagate meeting layout info, but the layout which is propagated is the presenter's, not their own. This can mislead the moderators because they think their layout is being propagated but it's not. It makes more sense to allow only presenters to propagate their layouts. 2022-09-07 09:14:35 -03:00
Joao Victor
84f9eeebc4 refactor: push layout 2022-09-07 08:52:08 -03:00
Gabriel Porfirio
4ce4ef7446 help button test 2022-09-06 13:52:45 -03:00
Ramón Souza
b09c2e0b41 adjust breakout publisher 2022-09-06 11:22:15 -03:00
prlanzarin
646db91367 fix(webcam): add MediaStream id to 'inactive' event handlers
BBBVideoStream 'inactive' event currently does not send the
MediaStream id as the payload for handlers. This can cause theoretical
race conditions due to media stream mismatches in places where
'inactive' handling is done globally (eg video-preview).

This adds the MediaStream id to BBBVideoStream's 'inactive' event
and uses it in video-preview to avoid such race conditions.
2022-09-06 12:31:26 +00:00
prlanzarin
5d04bcaf93 fix(webcam): retry gUM on NotReadableError for Chrome/Edge
tl;dr: switching camera profiles in video-preview fails intermittently
in Chrome/Edge.
Long version: Chrome/Edge sometimes bork gUM calls when switching camera
profiles. This looks like a browser bug (issue TBD). Track release not
being done synchronously -> quick subsequent gUM calls for the same
device (profile switching) -> device becoming unavaible while previous
tracks aren't finished.

Since track stop is not "awaitable", this commit adds a retry procedure
that re-runs gUM up to 5 times (200 ms delay) only if error.name is
NotReadableError and browser is either Chrome or Edge.
2022-09-06 12:26:31 +00:00
Ramón Souza
f7657d73db
Merge pull request #15627 from JoVictorNunes/fix-camera-brightness-Sep-01
fix(camera): disable brightness on Safari and stop segmentation if brightness is unchanged
2022-09-06 09:22:30 -03:00
Daniel Petri Rocha
f1690247fd Include capture checkbox in bbb-html5 2022-09-05 19:27:38 +02:00
Daniel Petri Rocha
16b3d43f19 Initial back-end wiring for breakout slides capture 2022-09-04 22:34:04 +02:00
germanocaumo
1db9fdacb1 fix(tldraw): disable selecting shapes on certain cases
- For presenter/multiuser Don't allow selecting the background shape (could be done with right click on empty area)
- For viewers: don't allow selecting anything (also hides the selection brush)
2022-09-02 20:59:03 +00:00
germanocaumo
87544a8b38 fix(tldraw): correctly sync draw shape updates +
Refactor how shape updates are parsed from tldraw, instead of doing it manually in each action,
uses the tldraw provided list of what changed available in the "onChangePage" callback, simplifying a lot of our code.
2022-09-02 19:26:26 +00:00
GuiLeme
2dec0f051b [apply-toast-shared-notes] - resolving conflicts 2022-09-02 16:08:24 -03:00
GuiLeme
f366b54498 Merge branch 'apply-toast-shared-notes' of github.com:GuiLeme/bigbluebutton into apply-toast-shared-notes 2022-09-02 15:26:21 -03:00
GuiLeme
80a381c87c [apply-toast-shared-notes] - resolved conflicts and refactored temporaryPresentationId's name 2022-09-02 15:24:29 -03:00
Ramón Souza
f9bbef759c
Merge pull request #15517 from JoVictorNunes/issue-15276
fix(tldraw): hide context menu for users who don't have access to whiteboard
2022-09-02 10:34:25 -03:00
Gustavo Trott
f7f20f3e2e
Merge pull request #15251 from ramonlsouza/issue-15001 2022-09-02 09:44:10 -03:00
Ramón Souza
cc7e5c7fa9
Merge pull request #15628 from ramonlsouza/send-chat-font
style: increase send to chat button font size
2022-09-01 15:43:50 -03:00
Joao Victor
b782a7fc06 fix: screenshare volume control 2022-09-01 13:48:59 -03:00
Ramón Souza
b8afe76837
Merge pull request #15620 from JoVictorNunes/sonar-warnings-Aug-31
fix: SonarCloud warnings
2022-09-01 13:22:31 -03:00
Ramón Souza
31c1e7b200 increase send to chat button font size 2022-09-01 11:07:39 -03:00
Joao Victor
d4949bd7cf fix(camera): disable brightness on Safari and stop segmentation if brightness is unchanged 2022-09-01 09:29:08 -03:00
Ramón Souza
4e46284a3b
Merge pull request #15603 from JoVictorNunes/camera-brightness
feat(camera): set camera brightness
2022-08-31 17:00:34 -03:00
KDSBrowne
3277286525 persist patched text changes 2022-08-31 19:01:53 +00:00
Ramón Souza
b4f4de7e34
Merge pull request #15623 from ramonlsouza/fix-import-lost
fix: restore imports lost on merge
2022-08-31 13:26:15 -03:00
Ramón Souza
8bd14d3a91 restore imports lost on merge 2022-08-31 13:06:33 -03:00
Joao Victor
aefc5c6c6a Merge branch 'v2.6.x-release' into issue-15536 2022-08-31 10:47:58 -03:00
Joao Victor
916a14e1f9 fix: SonarCloud warnings 2022-08-31 10:33:55 -03:00
Anton Georgiev
85a9138ac6
Merge pull request #15618 from ramonlsouza/breakout-fix-26
fix: adjust breakout publisher
2022-08-30 20:28:33 -04:00