Commit Graph

41761 Commits

Author SHA1 Message Date
Anton Georgiev
05d8f9110b
Merge pull request #20161 from prlanzarin/u30/fix/arthurk12-undefined-role-crash
fix: add safeguards when returning user roles
2024-05-03 08:53:01 -04:00
Anton Georgiev
7c407567e1
Merge pull request #20160 from prlanzarin/u30/fix/arthurk12-screenreader-crash
fix(screen-reader): add safeguards for adding alerts
2024-05-03 08:52:45 -04:00
Anton Georgiev
70e4ab1f66
Merge pull request #20159 from prlanzarin/u30/fix/onconnectionstatechange-crash-rc
fix(bbb-html5): crash when stopping WebRTC peers
2024-05-03 08:52:28 -04:00
Anton Georgiev
3babf4c16e
Merge pull request #20158 from prlanzarin/u30/fix/crash-videoprovider-onmessage
fix(bbb-html5): crash on video-provider unmount
2024-05-03 08:51:58 -04:00
Anton Georgiev
84fd90bc49
Merge pull request #20157 from prlanzarin/u30/fix/crash-getBoundingClientRect-emojirain
fix(reactions): crash when interactionsButton coords are absent
2024-05-03 08:49:42 -04:00
Anton Georgiev
9d99f7f78b
Merge pull request #20156 from prlanzarin/u30/fix/audio-answerer-gum-failure
fix(audio): acquire streams before negotiation when peer is answerer
2024-05-03 08:49:08 -04:00
Anton Georgiev
d385d97cdb
Merge pull request #20155 from prlanzarin/u30/fix/audio-less-toasts
fix(audio): minimize redundant audio exit toasts
2024-05-03 08:48:32 -04:00
Ramón Souza
35af05e594 fix custom logo 2024-05-03 09:31:18 -03:00
prlanzarin
a21addfa1f fix(audio): review device selection in mobile endpoints
Mobile users have no way to change I/O devices after joining audio.
The removal of the audio options chevron in mobile browsers was supposed
to be replaced by something else - in this case, by the dedicated
leave/join audio button. That didn't happen, leave/join audio button
retained the old behavior.

Review device selection in mobile endpoints via two UI/UX changes:
  - Fix an styling issue where the mute and listen only buttons were
    crammed together
  - Restore the device selection chevron/icon in mobile endpoints
  - Override the leave/join button action in mobile endpoints so that it
    opens the device selection contextual menu, which also includes the
    "Leave audio" option. This retains the old behavior (leaving audio)
    while also providing an way for users to change devices mid-call in
    mobile browsers.
2024-05-03 01:32:01 +00:00
Arthurk12
31a6527cca fix(wake-lock): correct parameter type for log code
Previously, an object was incorrectly passed as the log code parameter.
Fixes it by ensuring that a string is passed instead.
2024-05-03 00:06:07 +00:00
prlanzarin
cea92631fa fix: undefined accesses causes crashes in actions-bar breakout utils
Multiple undefined accesses in actions-bar's service, mainly related to
breakouts and ageneral Meetings info, cause crashes in production
environments - most likely in reconnection scenarios.

Guarantee that nested data is safely accessed.
2024-05-02 23:50:56 +00:00
prlanzarin
20daf56390 fix(audio): broken connection stats on Firefox >= 125
WebRTC-based stats generation in the connection status modal is broken
on Firefox >= 125. A broken type check coupled with a new partially
implemented RTCIceTransport dictionary causes and undefined function
call when fetching the selected candidate pair. Since that error is
unhandled, collection breaks.

Correctly check for the getSelectedCandidatePair method availability in
RTCIceTransport so that it skips to pair inference from getStats if
necessary.
2024-05-02 23:37:44 +00:00
Arthurk12
148c25e2cb fix: add safeguards when returning user roles 2024-05-02 23:35:45 +00:00
Arthurk12
9947aa451e fix(screen-reader): add safeguards for adding alerts
Adds checks for the alert's text and DOM element before adding screen
reader alerts.
2024-05-02 23:06:55 +00:00
prlanzarin
85cdc7cc2a fix(bbb-html5): crash when stopping WebRTC peers
There's a race condition that may cause a client crash whenever a
connectionstatechange callback is cleaned up in a peer without a
valid peer connection present in our custom RTCPeerConnection wrapper.

Check for peerConnection availability in the WebRtcPeer wrapper before
trying to clean up its connectionstatechange callback.
2024-05-02 22:59:39 +00:00
prlanzarin
eccb06369b fix(bbb-html5): crash on video-provider unmount
There's a race condition that may cause a client crash whenever a
video-provider's unmount procedure is run, but its signalling websocket
is undefined. The WS's callback handlers are re-assigned without
checking for the socket's availability, causing an unhandled TypeError.

The WS may be undefined in a couple of scenarios, e.g.: unmouting before
the socket was successfully set up, unmounting while a reconnect is in
place etc.

Check whether the socket exists before accessing it in video-provider's
componentWillUnmount routine.
2024-05-02 22:55:25 +00:00
prlanzarin
cfa013fdaa fix(reactions): crash when interactionsButton coords are absent
The client may crash whenever a emoji rain animation is triggered, but
the interactions button element cannot be located. This happens because
the button coordinates are fetched without checking whether the element
exists.

Get the coordinate fetching method to return null if the
interactionsButton element cannot be located, and ignore the emoji rain
action if that is the case. Whenever no valid coordinates are found, log
an warning so we can track this and figure out what's happening with the
button.

Fix a few typos in the getInteractionsButtonCoordinates method.
2024-05-02 22:32:09 +00:00
prlanzarin
00a2ab52a5 fix(audio): acquire streams before negotiation when peer is answerer
When a sendrecv peer acts as the answerer, gUM is only called _after_
the remote offer is received. This is fine, but the error handling runs
different in that scenario in a way that eventual gUM errors are treated
as negotiation errors, leading to inconsistencies when surfacing the
error to end users.

If a peer is acting as answerer and is a transceiver, acquire the local
streams _before_ actual negotiation so that gUM errors are surfaced
correctly (and we spare uneeded negotiation steps).
2024-05-02 22:27:16 +00:00
prlanzarin
d658d81148 fix(audio): minimize redundant audio exit toasts
Audio exit toasts are fired in some redundant situations, e.g.: when the
error help screen is toast.

Change the logic a bit so that it's only fired when the audio help modal
won't be shown, i.e.: when audio had succesfully connected.
2024-05-02 22:09:56 +00:00
João Victor
f9b935e75b test: adjust timeout for connecting webcam to be removed 2024-05-02 18:27:32 -03:00
João Victor
32bb2dfe2f fix: make hook to store its own state to avoid useless re-renders 2024-05-02 17:18:38 -03:00
Ramón Souza
24b90070b7
Merge pull request #20136 from KDSBrowne/v30.19985
fix(whiteboard): Deactivate Drawing Tool On Access Change
2024-05-02 16:36:14 -03:00
Tiago Jacobs
a4556f42b3
Merge pull request #20149 from gustavotrott/gql-tables-performance-improvements
Graphql-server: Increase Streaming Queries Multiplexed Batch Size to 1000 (was 100)
2024-05-02 15:22:09 -03:00
Gustavo Trott
e60217670e Increase Streaming Queries Multiplexed Batch Size for 1000 (was 100) 2024-05-02 15:12:03 -03:00
Ramón Souza
5d27799448
Merge pull request #20143 from ramonlsouza/issue-20142
fix: Warning message character limit exceeded is still showing up after being sent
2024-05-02 14:57:12 -03:00
Tiago Jacobs
c5d1c8be3b
Merge pull request #20135 from GuiLeme/plugin-sdk-readme-logger-ui-data
feat(plugins): refactor intl code for plugin and general code
2024-05-02 14:45:52 -03:00
Tiago Jacobs
60ab2ffce7
Merge pull request #20147 from gustavotrott/gql-tables-performance-improvements
enhancement (graphql-server): Optimization of Hasura Queries and Index Utilization in Postgres
2024-05-02 12:34:25 -03:00
Tiago Jacobs
17aebe6586
Merge pull request #20145 from gustavotrott/gql-middleware-handle-mutation
enhancement: `Graphql-middleware` will directly parse and route Mutations to `graphql-actions`, bypassing Hasura
2024-05-02 12:34:01 -03:00
Gustavo Trott
6846447644 Include commented HASURA_GRAPHQL_PG_CONNECTIONS to facilitate to change it 2024-05-02 11:55:07 -03:00
Gustavo Trott
dd07c838de Increase Hasura Multiplexed Batch Size to 1000 (default was 100) 2024-05-02 11:52:17 -03:00
João Victor
5a80f30711 fix: tweak video-streams typings (Part 4) 2024-05-02 11:51:14 -03:00
Gustavo Trott
4e4ba45535 Add a bunch of indexes to improve PG performance 2024-05-02 11:50:19 -03:00
João Victor Nunes
98d579401b
Merge branch 'v3.0.x-release' into video-streams-typings-fix 2024-05-02 11:41:09 -03:00
Ramón Souza
f589cb8828
Merge pull request #20076 from ramonlsouza/away-mode
feat: Improved away mode
2024-05-02 11:34:32 -03:00
João Victor
73eee42c66 fix: TS errors 2024-05-02 11:32:08 -03:00
João Victor Nunes
c61b6bb7e5
Merge branch 'v3.0.x-release' into video-streams-typings-fix 2024-05-02 11:26:08 -03:00
João Victor
9495e60d6f fix: ensure user's webcams are properly terminated 2024-05-02 11:22:24 -03:00
Gustavo Trott
148753ff6c Improve view v_chat 2024-05-02 11:19:39 -03:00
Gustavo Trott
f7c1b486b0 revert wrong file 2024-05-02 11:07:51 -03:00
Gustavo Trott
afccd6af32 improve code 2024-05-02 11:06:37 -03:00
Guilherme Leme
1cad46857c [plugin-sdk-readme-logger-ui-data] - update SDK 2024-05-02 10:53:00 -03:00
Ramón Souza
e0c8c0d933 remove chat error when a message is sent 2024-05-02 10:49:06 -03:00
Gustavo Trott
4fc3b2419c Graphql-middleware itself will handle mutations and forward to Graphql-actions 2024-05-02 10:45:32 -03:00
Tiago Jacobs
90f3539332
Merge pull request #20141 from JoVictorNunes/fix-video-stream-user-filtering
fix(webcam): fetch user data of webcam users only
2024-05-02 10:32:56 -03:00
Ramón Souza
250a559a4c
Merge pull request #20133 from ramonlsouza/tld19-snapshot
fix: snapshot of current slide
2024-05-02 10:21:41 -03:00
Anton B
1d90a8e966 test: remove "write closed captions" test 2024-05-02 10:06:49 -03:00
Ramón Souza
ae10830a1a move setTrackEnabled to new service file 2024-05-02 09:24:03 -03:00
João Victor
ee9f98a1ad fix(webcam): fetch user data of webcam users only
- Do not fetch user data of users who are not in webcam.
- Except when grid layout is active. In this situation we need to know about all users.
2024-05-02 09:17:58 -03:00
Anton B
04c17a59cd test: remove "pick random user" test 2024-05-02 08:58:18 -03:00
Ramón Souza
82b1101df8 Merge remote-tracking branch 'upstream/v3.0.x-release' into away-mode 2024-05-02 08:45:10 -03:00