BigBlueButton/bigbluebutton-Github
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
35,073 Commits 13 Branches 260 Tags 1.1 GiB
1375cf1535
Commit Graph

10488 Commits

Author SHA1 Message Date
prlanzarin
b3eebbb926 fix(audio): retry gUM without pre-set deviceIds on OverconstrainedError(s) 
There are some situations where previously set deviceIds (
local/session storage) may become stale. This causes an unexpected
behavior where audio is temporarily borked until the user clears their
local storage.
This issue has been seen more recently on Safari endpoints when switching
back-and-forth breakout rooms in environments running under iframes.
Also seen randomly on endpoints with virtual input devices.

This centralizes audio gUM calling into a single method that retries the
gUM procedure without pre-set deviceIds only if the initial call fails
due with an OverconstrainedError - hopefully circumventing the issue.
 2022-09-15 19:25:30 +00:00
Joao Victor
745937868c fix: 'horizontalPosition' prop type 2022-09-15 12:01:31 -03:00
Gustavo Trott
10c81bf689
Merge pull request #15690 from zhem0004/handleCursorPropertyError 2022-09-15 10:36:14 -03:00
Joao Victor
968e872c5b Merge branch 'v2.6.x-release' into issue-15574 2022-09-15 09:13:02 -03:00
Ramón Souza
2a062b25dc
Merge pull request #15683 from ramonlsouza/issue-15669 
fix: set breakout name input as readonly when updating users
 2022-09-14 17:08:49 -03:00
Bohdan Zhemelinskyi
811d135585 handle missing cursor property case 2022-09-14 19:42:15 +00:00
Ramón Souza
8a59a104b5
Merge pull request #15649 from ramonlsouza/port-15618-25 
fix: port adjustments in breakout publisher to 2.5
 2022-09-14 13:28:58 -03:00
Ramón Souza
7d7f26ea55
Merge pull request #15624 from KDSBrowne/bbb-text-updates 
fix: Restore Text Shape Updates Per Character
 2022-09-14 13:06:10 -03:00
Ramón Souza
634393e740
Merge pull request #15670 from ramonlsouza/fix-warnings 
Fix: bigbluebutton-html5 warnings
 2022-09-14 10:17:01 -03:00
Ramón Souza
a924aecc1d fix multiple answer translation in live results 2022-09-14 09:51:48 -03:00
Ramón Souza
cb9be4b072
Merge pull request #15612 from JoVictorNunes/issue-15579 
chore/fix: update `react-intl` to `6.1.0` and add config to disable fallback
 2022-09-13 16:28:03 -03:00
Ramón Souza
2b6b129df9 set breakout name input as readonly when updating users 2022-09-13 10:45:13 -03:00
Ramón Souza
1925124e82 fix button overflow in presentation toolbar 2022-09-12 16:27:29 -03:00
Anton Georgiev
5f4c89b6ff
Merge pull request #15672 from ramonlsouza/current-presentation-class 
refactor: Add "current presentation" toast unique class
 2022-09-09 19:43:44 -04:00
Ramón Souza
5a83f9b392 add unique className to current presentation toasts 2022-09-09 13:25:20 -03:00
Ramón Souza
efb3083373 only mount layoutEngine when layoutType is available 2022-09-09 10:19:43 -03:00
Ramón Souza
4e80475fd0 fix tabIndex warning 2022-09-09 10:19:04 -03:00
Ramón Souza
dda6b83958 fix panning warning 2022-09-09 10:14:20 -03:00
Ramón Souza
5588e19e3c
Merge pull request #15558 from JoVictorNunes/issue-15555 
fix: check virtual background type on change
 2022-09-09 09:25:15 -03:00
Paulo Lanzarin
9c4707b56d
Merge pull request #15582 from prlanzarin/u26/refactor/mic-inout-logs-26 
fix(audio): review in/out device management and switching
 2022-09-09 09:22:40 -03:00
Paulo Lanzarin
362785a83a
Merge pull request #15647 from prlanzarin/u26/fix/cam-profile-switch-notreadableerror 
fix(webcam): switching profiles in preview fails intermittently
 2022-09-08 15:11:33 -03:00
Ramón Souza
560d9370c6 adjust html/body lang on page load 2022-09-08 14:25:29 -03:00
Ramón Souza
c6c65c4aa0 add support to xx@xxxx localization files 2022-09-08 11:47:41 -03:00
Ramón Souza
406c215add
Merge pull request #15659 from JoVictorNunes/issue-15658 
fix(whiteboard toolbar): reduce distance from the bottom
 2022-09-08 09:37:20 -03:00
Joao Victor
4277a0ed03 fix: volume icon 2022-09-07 11:59:43 -03:00
Joao Victor
19e71697d6 Merge remote-tracking branch 'upstream/v2.6.x-release' into issue-15559 2022-09-07 11:54:52 -03:00
Joao Victor
36864a8880 fix(whiteboard toolbar): reduce offset from the bottom 2022-09-07 11:34:54 -03:00
Joao Victor
acc55f0d08 fix: don't allow moderators to propagate meeting layout info (#15574). -- Currently moderators can propagate meeting layout info, but the layout which is propagated is the presenter's, not their own. This can mislead the moderators because they think their layout is being propagated but it's not. It makes more sense to allow only presenters to propagate their layouts. 2022-09-07 09:14:35 -03:00
Joao Victor
84f9eeebc4 refactor: push layout 2022-09-07 08:52:08 -03:00
Gabriel Porfirio
4ce4ef7446 help button test 2022-09-06 13:52:45 -03:00
Ramón Souza
b09c2e0b41 adjust breakout publisher 2022-09-06 11:22:15 -03:00
prlanzarin
646db91367 fix(webcam): add MediaStream id to 'inactive' event handlers 
BBBVideoStream 'inactive' event currently does not send the
MediaStream id as the payload for handlers. This can cause theoretical
race conditions due to media stream mismatches in places where
'inactive' handling is done globally (eg video-preview).

This adds the MediaStream id to BBBVideoStream's 'inactive' event
and uses it in video-preview to avoid such race conditions.
 2022-09-06 12:31:26 +00:00
prlanzarin
5d04bcaf93 fix(webcam): retry gUM on NotReadableError for Chrome/Edge 
tl;dr: switching camera profiles in video-preview fails intermittently
in Chrome/Edge.
Long version: Chrome/Edge sometimes bork gUM calls when switching camera
profiles. This looks like a browser bug (issue TBD). Track release not
being done synchronously -> quick subsequent gUM calls for the same
device (profile switching) -> device becoming unavaible while previous
tracks aren't finished.

Since track stop is not "awaitable", this commit adds a retry procedure
that re-runs gUM up to 5 times (200 ms delay) only if error.name is
NotReadableError and browser is either Chrome or Edge.
 2022-09-06 12:26:31 +00:00
Ramón Souza
f7657d73db
Merge pull request #15627 from JoVictorNunes/fix-camera-brightness-Sep-01 
fix(camera): disable brightness on Safari and stop segmentation if brightness is unchanged
 2022-09-06 09:22:30 -03:00
germanocaumo
1db9fdacb1 fix(tldraw): disable selecting shapes on certain cases 
- For presenter/multiuser Don't allow selecting the background shape (could be done with right click on empty area)
- For viewers: don't allow selecting anything (also hides the selection brush)
 2022-09-02 20:59:03 +00:00
GuiLeme
2dec0f051b [apply-toast-shared-notes] - resolving conflicts 2022-09-02 16:08:24 -03:00
GuiLeme
f366b54498 Merge branch 'apply-toast-shared-notes' of github.com:GuiLeme/bigbluebutton into apply-toast-shared-notes 2022-09-02 15:26:21 -03:00
GuiLeme
80a381c87c [apply-toast-shared-notes] - resolved conflicts and refactored temporaryPresentationId's name 2022-09-02 15:24:29 -03:00
Ramón Souza
f9bbef759c
Merge pull request #15517 from JoVictorNunes/issue-15276 
fix(tldraw): hide context menu for users who don't have access to whiteboard
 2022-09-02 10:34:25 -03:00
Gustavo Trott
f7f20f3e2e
Merge pull request #15251 from ramonlsouza/issue-15001 2022-09-02 09:44:10 -03:00
Ramón Souza
cc7e5c7fa9
Merge pull request #15628 from ramonlsouza/send-chat-font 
style: increase send to chat button font size
 2022-09-01 15:43:50 -03:00
Joao Victor
b782a7fc06 fix: screenshare volume control 2022-09-01 13:48:59 -03:00
Ramón Souza
b8afe76837
Merge pull request #15620 from JoVictorNunes/sonar-warnings-Aug-31 
fix: SonarCloud warnings
 2022-09-01 13:22:31 -03:00
Ramón Souza
31c1e7b200 increase send to chat button font size 2022-09-01 11:07:39 -03:00
Joao Victor
d4949bd7cf fix(camera): disable brightness on Safari and stop segmentation if brightness is unchanged 2022-09-01 09:29:08 -03:00
Ramón Souza
4e46284a3b
Merge pull request #15603 from JoVictorNunes/camera-brightness 
feat(camera): set camera brightness
 2022-08-31 17:00:34 -03:00
KDSBrowne
3277286525 persist patched text changes 2022-08-31 19:01:53 +00:00
Ramón Souza
b4f4de7e34
Merge pull request #15623 from ramonlsouza/fix-import-lost 
fix: restore imports lost on merge
 2022-08-31 13:26:15 -03:00
Ramón Souza
8bd14d3a91 restore imports lost on merge 2022-08-31 13:06:33 -03:00
Joao Victor
aefc5c6c6a Merge branch 'v2.6.x-release' into issue-15536 2022-08-31 10:47:58 -03:00
Joao Victor
916a14e1f9 fix: SonarCloud warnings 2022-08-31 10:33:55 -03:00
Anton Georgiev
85a9138ac6
Merge pull request #15618 from ramonlsouza/breakout-fix-26 
fix: adjust breakout publisher
 2022-08-30 20:28:33 -04:00
Ramón Souza
470f491352
Merge pull request #15583 from germanocaumo/tldraw-viewbox-sync 
fix(tldraw): sync viewed area between presenter/viewers +
 2022-08-30 17:00:14 -03:00
Ramón Souza
ee6eb01d04 adjust breakout publisher 2022-08-30 16:24:01 -03:00
Ramón Souza
8aa0d1b0e7
Merge pull request #15544 from gustavotrott/html5-show-ejectedReason-2.6 
fix (2.6): enhancements over disconnection situation (delay to remove and show ejected reason)
 2022-08-30 10:58:49 -03:00
Gabriel Porfirio
554f3d11da add data-test to emoji picker button 2022-08-30 09:55:57 -03:00
Joao Victor
c7b4f8bc66 chore/fix: update react-intl to 6.1.0 and add config to disable fallback 2022-08-30 09:32:21 -03:00
Gustavo Trott
84e482e55e Remove delay to endMeeting when user is ejected=true 2022-08-29 22:50:57 -03:00
Joao Victor
2dd5a73601 chore: update react-intl to 6.1.0 2022-08-29 17:25:43 -03:00
Ramón Souza
e7107f87a7
Merge pull request #15598 from ramonlsouza/merge-2526-aug25 
chore: Merge v2.5.5 into v2.6
 2022-08-29 15:58:53 -03:00
Ramón Souza
45e49ea7d2
Merge pull request #15606 from ramonlsouza/light-button-color 
fix: light button warning
 2022-08-29 13:59:52 -03:00
Ramón Souza
fef01d8fb6
Merge pull request #15567 from ramonlsouza/fix-emoji-button 
fix: emoji picker button styles
 2022-08-29 13:01:42 -03:00
Ramón Souza
61f7700080 fix light button warning 2022-08-29 09:39:20 -03:00
germanocaumo
105ed256c3 fix: tldraw not changing pages correctly 2022-08-29 12:27:17 +00:00
Ramón Souza
033a23e336 restore needed imports 2022-08-26 14:30:40 -03:00
Ramón Souza
62f8ab3cb2 Merge remote-tracking branch 'upstream/v2.6.x-release' into pr-15460-aug26 2022-08-26 14:05:45 -03:00
Ramón Souza
e3b7c89ac9
Merge pull request #15586 from ramonlsouza/adjust-assign-buttons 
style: adjust breakout room assignment buttons
 2022-08-26 13:54:32 -03:00
Joao Victor
24c227cc75 Merge 2.6.x-release into camera-brightness 2022-08-26 11:53:23 -03:00
Joao Victor
396f5320a4 feat(camera): set camera brightness 2022-08-26 11:50:46 -03:00
Ramón Souza
609d43157a Merge tag 'v2.5.5' into merge-2526-aug25 2022-08-25 14:33:44 -03:00
prlanzarin
bf802ced4c fix(audio): check if backup stream exists before trying to clean it up 2022-08-25 17:14:41 +00:00
Ramón Souza
fbeb775313
Merge pull request #15551 from ramonlsouza/uploader-errors 
fix: display presentation uploader limit errors
 2022-08-25 09:49:48 -03:00
Joao Victor
54b146effe fix: add missing custom virtual background param 2022-08-25 08:30:36 -03:00
Ramón Souza
14dd486f3a prevent infinite generating slides 2022-08-24 13:34:50 -03:00
prlanzarin
ec1879f96b fix(audio): add inputDeviceId enforcement for post-join/gUM 
Extract the deviceId again from the stream to guarantee consistency
between stream DID vs chosen DID. That's necessary in scenarios where,
eg, there's no default/pre-set deviceId ('') and the browser's
default device has been altered by the user (browser default != system's
default).
 2022-08-24 14:39:09 +00:00
Ramón Souza
c52a3ffb25 adjust assignment buttons - create breakout 2022-08-24 10:37:10 -03:00
prlanzarin
36bce51363 refactor(audio): remove unused imports from sip.js bridge 2022-08-24 13:28:32 +00:00
prlanzarin
89e814d570 fix(audio): centralize device change code, add rollbacks, surface errors 
There's no rollback procedure in case a device switch fails right now,
nor does the code entrypoints that call the switching procedures wait
for resolution or failure before marking the new device as chosen. That
may cause inconsistent states in a couple of ways:
  - No rollback: switch fails, audio is still on but no actual
    microphone input is being transmitted
  - Not waiting for resolutions: inconsistent chosen devices on failures
Device switching errors are also not surfaced to the end user

This commit:
  - Adds device rollback and proper resolution/failure response
    awaits to try and make the state a bit more consistent.
  - Centralizes the input device switching code to be reused between
    different bridges
  - Centralizes device ID state management in audio-manager to try and
    mantain them a bit more consistent across the board
  - Surface device switching failures to the end user
  - Guarantee device IDs are set to the session storage on all
    appropriate scenarios
 2022-08-24 13:28:27 +00:00
KDSBrowne
45b3166863 Merge branch 'tldraw-viewbox-sync' of https://github.com/germanocaumo/bigbluebutton into tldraw-viewbox-sync 2022-08-24 11:55:38 +00:00
KDSBrowne
c758664651 remove toolbar from non presenter cursor calculation 2022-08-24 11:55:31 +00:00
Ramón Souza
82e234be33
Merge pull request #15500 from JoVictorNunes/issue-15458 
fix: don't clear text fake annotations
 2022-08-23 16:19:39 -03:00
germanocaumo
61cb5b8ef4 fix(tldraw): fit to width / presenter / slide changing 2022-08-23 18:19:17 +00:00
Ramón Souza
59f717265a adjustments after PR 15573 2022-08-23 13:59:58 -03:00
prlanzarin
ac71167ba5 refactor(audio): add debug logs for microphone device changes 
In/out device changes are mostly silent which makes it hard to track
them to look for problems.
 2022-08-23 14:50:50 +00:00
Ramón Souza
4d82d76d4a Merge remote-tracking branch 'upstream/v2.5.x-release' into uploader-errors 2022-08-23 09:34:25 -03:00
KDSBrowne
9f7b45b172 hide eraser animation on mobile 2022-08-23 12:08:31 +00:00
Guilherme Pereira Leme
621503e258
Merge pull request #6 from JoVictorNunes/issue-15505 
fix: show conversion process info in toast
 2022-08-23 09:01:02 -03:00
Anton B
8e7e1e7e42 test: add data-test props in lock settings items 2022-08-22 18:02:31 -03:00
Gustavo Trott
87e4c52cee Fix error when trying to read role when user was removed already 2022-08-22 16:32:12 -03:00
KDSBrowne
ab4cb469fb Merge branch 'tldraw-viewbox-sync' of https://github.com/germanocaumo/bigbluebutton into tldraw-viewbox-sync 2022-08-22 19:07:23 +00:00
KDSBrowne
9df18af50f update presentation offset for cursor (mobile) 2022-08-22 19:05:02 +00:00
Guilherme Pereira Leme
7288d9b9f2
Changes in review 
Co-authored-by: João Victor Nunes <62393923+JoVictorNunes@users.noreply.github.com>
 2022-08-22 15:54:34 -03:00
germanocaumo
0e7c27968e Merge branch 'tldraw-viewbox-sync' of https://github.com/germanocaumo/bigbluebutton into tldraw-viewbox-sync 2022-08-22 18:11:40 +00:00
GuiLeme
d9de398d90 [fix-page-count-exeed] - Forwarded temporaryPresentationId to front-end and refactor it's name 2022-08-22 15:00:27 -03:00
Anton Georgiev
2be6909e26
Merge pull request #15525 from gabriellpr/about-modal 
test: About Modal Test
 2022-08-22 13:05:11 -04:00
KDSBrowne
eb7c3dcbc8 update pan tool button after zoom changes 2022-08-22 16:55:44 +00:00
João Victor Nunes
aba9d86904
Merge branch 'v2.6.x-release' into issue-15276 2022-08-22 13:05:25 -03:00
germanocaumo
c948f39392 Merge branch 'v2.6.x-release' of https://github.com/bigbluebutton/bigbluebutton into tldraw-viewbox-sync 2022-08-22 15:47:51 +00:00
germanocaumo
f209fd17c1 Merge branch 'tldraw-viewbox-sync' of https://github.com/germanocaumo/bigbluebutton into tldraw-viewbox-sync 2022-08-22 15:43:04 +00:00
KDSBrowne
1de4b3f644 update cursor position handling | temp hide eraser animation 2022-08-22 14:37:34 +00:00