BigBlueButton/bigbluebutton-Github
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
38,011 Commits 13 Branches 260 Tags 1.1 GiB
13657f1e6c
Commit Graph

38011 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Calvin Walton
9d02717b04 fix(recording): Deskshare audio processing hang 
This is a refinement of the fix introduced in 3c1a9cd7c4.

Further investigation of the issue reveals that the cause of the bad
timestamps which result in error messages or hang is when the `apad`
filter does not receive any input audio frames. This happens if the
seekpoint is after the end of audio. The existing seekpoint checks can't
cover this, because in a deskshare file the video stream can continue on
after the audio stream ends.

The `,asetpts=N` filter was added to deal with this problem, and it
works in most cases. But there is a case where it fails - when the
"mismatched length" audio stretching to work around broken recordings
from BigBlueButton 0.81/0.90 kicks in.

The issue there is that the `atrim=start=S` filter (used due to the
difficulty of calculating seeks when stretching) hits the invalid
timestamps and hangs.

I'm working around this issue with a "defense in depth" combination of
two changes:

* Move the `,asetpts=N` filter to be applied before the audio stretch
  filters. This fixes the processing hang.
* Adjust the conditions on the "mismatched length" audio stretching so
  that it only gets applied on audio files likely to be from extremely
  old BigBlueButton versions - those with audio in wav files, or encoded
  to vorbis.

BigBlueButton has been using audio recorded directly to opus by
FreeSWITCH for quite a while, and the handling for gaps or lost packets
is done in current BBB versions by a combination of the libopus decoder
and the use of ffmpeg's `aresample=async=1000` filter to dynamically
stretch, squish, or fill in audio so it becomes a continuous stream
that's locked to the file timestamps. Applying the "mismatched length"
processing on top of that is probably making audio sync issues worse.
 2023-10-04 13:30:59 -04:00
Anton Georgiev
82322938d2
Merge pull request #18699 from bigbluebutton/translations_bigbluebutton-html5-public-locales-en-json--v2-6-x-release_gl 
Updates for file bigbluebutton-html5/public/locales/en.json in gl on branch v2.6.x-release
 2023-09-07 08:49:54 -04:00
Anton Georgiev
4921a69b29
docs: add 2.6.14 link 2023-09-06 13:33:56 -04:00
Anton Georgiev
a9053de442
Merge pull request #18718 from bigbluebutton/antobinary-patch-1 
docs: Improve docs for 2.6.14 upgrade of nodejs
 2023-09-05 21:04:26 -04:00
Anton Georgiev
ec54c7111f
docs: Improve docs for 2.6.14 upgrade of nodejs 2023-09-05 21:03:07 -04:00
transifex-integration[bot]
5b82ced528
Translate en.json in gl 
100% translated source file: 'en.json'
on 'gl'.
 2023-09-02 16:29:15 +00:00
Anton Georgiev
cc3bea7f48
Merge pull request #18697 from antobinary/26-java17nodejs18 
build: fix nodejs version paste error in #18686
 2023-09-02 06:52:05 -04:00
Anton Georgiev
eae34304be build: fix nodejs version paste error in #18686 2023-09-02 06:49:29 -04:00
Anton Georgiev
437d90d147
Merge pull request #18695 from antobinary/26-java17nodejs18 
docs: add info on NodeJS v18 and Java 17 upgrade paths
 2023-09-01 15:12:00 -04:00
Anton Georgiev
2313ba043d docs: add info on NodeJS v18 and Java 17 upgrade paths 2023-09-01 14:18:12 -04:00
Anton Georgiev
e17f0315fd
chore: Bump BBB version to 2.6.14 2023-09-01 12:27:14 -04:00
Gustavo Trott
0d7b69862d
Merge pull request #18686 from antobinary/26-java17nodejs18 
!build: require node 18 to install bbb packages
 2023-09-01 11:37:09 -03:00
Anton Georgiev
89d17ff639 build: require node 18 to install bbb packages 2023-09-01 08:19:50 -04:00
Anton Georgiev
cf5d108be9
Merge pull request #18680 from antobinary/26-java17nodejs18 
build: Upgrade to Java17, NodeJS 18
 2023-08-31 15:00:17 -04:00
Anton Georgiev
aa7c649b2c build: fix mismatched quote 2023-08-31 07:23:18 -04:00
Anton Georgiev
5a4105b78b chore: allow newer nodejs to be used on bbb-export-annotations 2023-08-31 07:16:32 -04:00
Anton Georgiev
826b157e88 use bbb-install from github 2023-08-31 07:13:59 -04:00
Anton Georgiev
420fbdcdbc grails 5.3.2 in docs 2023-08-31 07:10:25 -04:00
Anton Georgiev
de3f5f0749 use package building image with java17 node18 2023-08-31 07:09:35 -04:00
Anton Georgiev
7f117eea45 add java17 as bbb-web dependency 2023-08-31 07:09:10 -04:00
Anton Georgiev
c4e849edc8 build: specify java 17 on bbb-web install 2023-08-31 07:06:11 -04:00
Anton Georgiev
d0417db65e docs: added info on Java 17 upgrade 2023-08-31 07:05:27 -04:00
Anton Georgiev
38286c6b7e build: use Java17 to build akka projects 2023-08-31 07:03:04 -04:00
Paul Trudel
dd59955c7d Upgrade gorm and groovy versions 2023-08-31 07:02:30 -04:00
Paul Trudel
f83ff60901 Change target to release for java 17 on fsesl 2023-08-31 07:01:00 -04:00
Paul Trudel
7bab189a23 Change target to release for java 17 2023-08-31 07:00:42 -04:00
Anton Georgiev
1159e7af3c build: resetting mcs-address from localhost to 127.0.01 2023-08-30 17:19:39 -04:00
Anton Georgiev
4ea77f1068 chore: upgrade NodeJS to 18 2023-08-30 17:18:46 -04:00
Anton Georgiev
bf18937efa
Merge pull request #18653 from KDSBrowne/bbb-18645 
fix: Mouse Wheel Zoom Disrupting Slide Position
 2023-08-29 14:46:08 -04:00
KDSBrowne
87a2f698a7 handle zoom percent value being lost on minimize + restore 2023-08-29 14:29:11 +00:00
Ramón Souza
ab14ed5a4c
Merge pull request #18654 from KDSBrowne/bbb-styles-menu-a11y 
fix (accessibility): Improve Keyboard Functionality With Tldraw Style Menu
 2023-08-28 14:53:53 -03:00
KDSBrowne
4e8965b218 improve tldraw style menu a11y 2023-08-27 20:06:26 +00:00
KDSBrowne
a381391968 update toolbar zoom value on slide change 2023-08-27 19:19:04 +00:00
KDSBrowne
7cb9764267 fix wheel zoom breaking slide position 2023-08-27 18:45:37 +00:00
Anton Georgiev
ee89a64914
docs: added link to 2.6.12 2023-08-24 11:14:40 -04:00
Anton Georgiev
64a74527a0
Merge pull request #18625 from bigbluebutton/translations_bigbluebutton-html5-public-locales-en-json--v2-6-x-release_ca 
Updates for file bigbluebutton-html5/public/locales/en.json in ca on branch v2.6.x-release
 2023-08-23 10:09:56 -04:00
transifex-integration[bot]
42a7b07db4
Translate en.json in ca 
100% translated source file: 'en.json'
on 'ca'.
 2023-08-23 07:04:45 +00:00
Anton Georgiev
41c5670e49
chore: Bump BBB version to 2.6.12 2023-08-22 16:21:57 -04:00
Ramón Souza
bc2ce9dff9
Merge pull request #18226 from Tainan404/dedupe-chat-messages 
fix: Add dedupe to messages based on referenceId (backport of #18230 from 2.7)
 2023-08-22 16:35:53 -03:00
Tainan Felipe
cc85a33c7d Add Fix for users that change role 2023-08-22 16:27:18 -03:00
Anton Georgiev
7654328b03
Merge pull request #18618 from antobinary/backport-meteor-213 
chore: upgrade Meteor 2.12 to 2.13 (backport to 2.6)
 2023-08-22 14:30:34 -04:00
Anton Georgiev
3966cfe965
Merge pull request #18619 from antobinary/backport-fs-11010 
build(freeswitch): v1.10.10 (backport to 2.6)
 2023-08-22 14:28:34 -04:00
Anton Georgiev
b9200ea85b build(freeswitch): v1.10.10 2023-08-22 14:27:28 -04:00
Anton Georgiev
f7feced4f9
Merge pull request #18616 from antonbsa/avoid-webcam-test 
test: Skip webcam test to run on CI
 2023-08-22 14:22:34 -04:00
Anton Georgiev
19b4781d1c chore: upgrade Meteor 2.12 to 2.13 2023-08-22 14:21:30 -04:00
Ramón Souza
0d911a0102
Merge pull request #18597 from KDSBrowne/bbb-17982-2 
fix: Handle Slide Change With Fit To Width
 2023-08-22 12:04:57 -03:00
Anton B
94410dc42d test: add flaky test flag on webcam background test 2023-08-22 12:04:07 -03:00
Anton Georgiev
4bcef4168d
Merge pull request #18610 from bigbluebutton/translations_bigbluebutton-html5-public-locales-en-json--v2-6-x-release_ca 
Updates for file bigbluebutton-html5/public/locales/en.json in ca on branch v2.6.x-release [Manual Sync]
 2023-08-22 10:25:49 -04:00
transifex-integration[bot]
eca4b6e558
Translate en.json in ca [Manual Sync] 
99% of minimum 99% translated source file: 'en.json'
on 'ca'.

Sync of partially translated files: 
untranslated content is included with an empty translation 
or source language content depending on file format
 2023-08-22 14:22:36 +00:00
Ramón Souza
adee1d1e64
Merge pull request #18598 from KDSBrowne/bbb-18596 
fix: Stop Presentation Jerks While Panning
 2023-08-22 09:07:42 -03:00