Commit Graph

11640 Commits

Author SHA1 Message Date
Arthurk12
10e1b70bf9 chore(timer): adds log message to beep 2023-05-18 15:29:38 -03:00
Arthurk12
6628296471 fix(timer): wrong attribute to get users count
There was a legacy attribute being used to find active users in the meeting.
This wrong attribute caused the returned number of users to be 0 which
makes the timer stop prematurely and, possibly, not to issue the timer beep.

Also adds a missing argument to updateTimer and moves the find call to
the Users collection to a external function, so it doesn't get executed
every time an user notifies timer has ended.
2023-05-18 15:29:38 -03:00
AtilaU19
a694595275 feat(timer): added requestedUserId and Action logs 2023-05-18 15:29:38 -03:00
Arthurk12
df9b0a2655 refactor(timer): audio tag and play/stop conditions
Sets conditions for calling play and stop music to avoid being called
repeatedly.
Groups all stop calls into a point to make the code cleaner.
Avoid recreating new audio tag whenever the timer song changes.
2023-05-18 15:29:37 -03:00
Arthurk12
857389e295 fix(timer): music selectors
Disables track radio selectors when timer feature is in stopwatch mode.
2023-05-18 15:29:37 -03:00
Arthurk12
cc2387a7dd fix(timer): stop music on unmount
Stops music when timer indicator component is unmounted.
2023-05-18 15:29:37 -03:00
Arthurk12
3895d86823 fix(timer): indicator not showing on mobile
Due to the new layout manager, open panels' checking needed tweaking.
2023-05-18 15:29:36 -03:00
Pedro Beschorner Marin
a8e7f9c896 fix(timer): add key prop to tracks list 2023-05-18 15:29:36 -03:00
Pedro Beschorner Marin
2b4d40d6e8 refactor(timer): functions order 2023-05-18 15:29:36 -03:00
Pedro Beschorner Marin
47cecbfea2 refactor(timer): add parseInt radix 2023-05-18 15:29:35 -03:00
Arthurk12
f5a5a960ba feat(timer): adds more songs
Adds 2 more songs to the timer, which can be switched using the radio
buttons inside timer panel.
Changed the music loop logic to make it gapless.
2023-05-18 15:29:35 -03:00
Arthurk12
529a5a6b10 fix(timer): music stop
Forces timer music to stop when timer is deactivated while running.
2023-05-18 15:29:35 -03:00
Arthur B. Grossi
17aa3d7177 Requested changes
Filters users collection by 'online' connection status and describes when/how
server detects that the timer has ended to automatically stop it.
Also, fixed a corner case that when timer alarm was disabled, clients didn't
notify that the timer ended.
2023-05-18 15:29:35 -03:00
Arthur B. Grossi
737b5e6b3a fix(timer): music toggle alignment
Music label and toggle are closer and centralized.
2023-05-18 15:29:34 -03:00
Arthur B. Grossi
dbbef569a9 fix(timer): autoplay
When user enters meeting with music already playing, an event listener is set
to play the music only after user interaction.
Also, to keep timer more cohesive and reduce complexity of the condition for
playing music, timer automatically stops after 90% of users notify that the
timer has expired.
2023-05-18 15:29:34 -03:00
Arthur B. Grossi
cc61652aa3 feat(timer): ambient music
Adds a music player for ambient sound which can be turned on and off using a
toggle located inside timer panel. When stopwatch is selected, this toggle is
automattically turned off.
2023-05-18 15:29:34 -03:00
Arthurk12
3952112f49 fix(timer): start/stop button color 2023-05-18 15:29:33 -03:00
Pedro Beschorner Marin
ea30525cb4 Timer design extra tweaks 2023-05-18 15:29:33 -03:00
Arthurk12
cc2f509c7c Refactored timer design 2023-05-18 15:29:33 -03:00
Pedro Beschorner Marin
585dbef43d Time offset refactor 2023-05-18 15:29:33 -03:00
Pedro Beschorner Marin
c040db8f58 Fix alarm when deactivated 2023-05-18 15:29:32 -03:00
Pedro Beschorner Marin
2f104eafc8 Syncing time offset between client and server 2023-05-18 15:29:32 -03:00
Pedro Beschorner Marin
4d8f7070de Add timer alarm 2023-05-18 15:29:32 -03:00
Pedro Beschorner Marin
f4a5421843 Add timer view 2023-05-18 15:29:31 -03:00
Pedro Beschorner Marin
5463a4a423 Stopwatch handlers 2023-05-18 15:29:31 -03:00
Arthurk12
953a3d3548 Timer first commit 2023-05-18 15:29:31 -03:00
Ramón Souza
c64cf5ccbd
Merge pull request #17935 from Scroody/I-16114
feat: Disable self-view of webcam
2023-05-17 14:49:40 -03:00
Scroody
0fa1b9b3eb More requested changes made 2023-05-17 13:54:54 -03:00
Scroody
4a6d1258ae Requested changes made and fix of deactivating mutiple cams 2023-05-17 11:30:06 -03:00
Scroody
99885c20ed Final Adjust 2023-05-16 15:43:06 -03:00
Scroody
8272b487f3 Testing 2023-05-16 14:39:56 -03:00
Anton Georgiev
510c94cfa7 Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into may16-merge 2023-05-16 13:35:47 -04:00
Ramón Souza
99832aa570
Merge pull request #17864 from hiroshisuga/dev2.6_fitToWidthStyle
style: Change style of fit-to-width button when it's on
2023-05-16 08:56:39 -03:00
Ramón Souza
341e2c9464
Merge pull request #17862 from hiroshisuga/patch-4
style: remove unnecessary fit-to-width style
2023-05-16 08:51:45 -03:00
Ramón Souza
af23ce542e
Merge pull request #17702 from Scroody/virtual-backgound-accepts-webp
feat (html5): Virtual backgrounds now accepts webp format
2023-05-15 17:06:41 -03:00
Ramón Souza
fecf42dada
Merge pull request #17905 from danielpetri1/export-toast-fix
fix(bbb-html5): Successful annotated export toast
2023-05-15 16:39:16 -03:00
danielpetri1
6435fbbf25 Linting changes 2023-05-15 18:56:01 +00:00
Paulo Lanzarin
2b374533ae
Merge pull request #17904 from prlanzarin/u26/fix/video-button-ios-uacheck
fix: remove legacy iOS UA checks that borked camera sharing in iPads
2023-05-15 15:16:56 -03:00
Ramón Souza
dcef3e3d7b
Merge pull request #17845 from ramonlsouza/issue-17839
fix: ignore restore on update for first load of initial presentation
2023-05-15 13:41:27 -03:00
prlanzarin
a693133b5a fix: remove legacy iOS UA checks that borked camera sharing in iPads
There are a couple of hardcoded UA checks targeted at iOS endpoints
introduced circa 2.2-beta. One of those pops up an "unsupported" toast
when the device joins a conference - the other blocks camera
sharing.

Those checks are outdated since we transitioned to minBrowserVersions
approach that redirects the client to an unsupported view upon join. I
also assume the checks are bugged since, in some environments, it flags
iPadOS endpoints as iOS and version-checks it to a hardcoded "12.2"
threshold (which is incompatible with iPadOS versioning). That caused
camera sharing not to work, which is a false negative.

I consider the checks to be outdated, so I removed all references to
them.
2023-05-15 13:22:52 -03:00
danielpetri1
c0c7f9d516 Add successful file export toast 2023-05-15 16:12:12 +00:00
Anton Georgiev
4e851a7571 Merge branch 'v2.6.x-release' of github.com:bigbluebutton/bigbluebutton into merge-267-27 2023-05-15 11:51:17 -04:00
Ramón Souza
494b547b49
Merge pull request #17879 from Scroody/fix-poll-results-editable-for-presenter
fix: Making poll results editing possible to presenter
2023-05-12 11:42:23 -03:00
André Castro
e9ae302d54
Making editing possible to presenter 2023-05-12 11:15:41 -03:00
Anton Georgiev
1c9ba032a6
Merge pull request #17554 from AtilaU19/reconection-fixes
fix: overlapping screen end alerts and invisible cameras on reconnections
2023-05-11 17:15:12 -04:00
KDSBrowne
eb1f5f5935 update to react 18 2023-05-11 16:16:10 +00:00
Anton Georgiev
9c513f2bab
Merge pull request #17777 from danielpetri1/notes-current-issue
fix(bbb-html5): Inconsistent current presentation indicator
2023-05-11 09:10:07 -04:00
Anton Georgiev
adc654880c
Merge pull request #17868 from Scroody/I-17734
Fix: Order of first and last names in save users
2023-05-10 17:43:40 -04:00
Anton Georgiev
52df800720
Merge pull request #17837 from Scroody/I-17684
Fix: editable polls.
2023-05-10 17:43:08 -04:00
Anton Georgiev
a91ae56b34
Merge pull request #17822 from ramonlsouza/issue-17720
fix: Toast notifications shows again when the language is switched
2023-05-10 15:49:08 -04:00